On 30.04.24 11:31, Vladimir Sementsov-Ogievskiy wrote:
On 30.04.24 11:19, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Add command to sync config from vhost-user backend to the device. It
may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not
triggered
On 30.04.24 12:13, Kevin Wolf wrote:
Am 29.04.2024 um 20:39 hat Vladimir Sementsov-Ogievskiy geschrieben:
[Add John]
On 29.04.24 17:18, Richard Henderson wrote:
On 4/29/24 04:51, Vladimir Sementsov-Ogievskiy wrote:
Add test for a new backup option: discard-source.
Signed-off-by: Vladimir
: add backup-discard-source"
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Hi all! That's a patch to unblock my PR
"[PULL 0/6] Block jobs patches for 2024-04-29"
<20240429115157.2260885-1-vsement...@yandex-team.ru>
https://patchew.org/QEMU/20240429115157.2260885-1
On 30.04.24 11:19, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Add command to sync config from vhost-user backend to the device. It
may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not
triggered interrupt to the guest or just not available (not supported
On 30.04.24 11:15, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Split vhost_user_blk_sync_config() out from
vhost_user_blk_handle_config_change(), to be reused in the following
commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/block/vhost-user-blk.c | 26
[Add John]
On 29.04.24 17:18, Richard Henderson wrote:
On 4/29/24 04:51, Vladimir Sementsov-Ogievskiy wrote:
Add test for a new backup option: discard-source.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fiona Ebner
Tested-by: Fiona Ebner
Message-Id: <20240313152822.62649
the subject helps to understand:
Use uint64_t for timeout in nanoseconds ...
Oh, sorry. I'll try to remember that for the future. Should I re-send as
a v2?
Not necessary, I can touch up the message when applying to my block branch.
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best
On 29.04.24 16:04, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
On 29.04.24 13:51, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
On 24.04.24 14:48, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Add command to sync config from vhost-user
On 29.04.24 13:51, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
On 24.04.24 14:48, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Add command to sync config from vhost-user backend to the device. It
may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG
Sorry for too much CC-ing, I've mistakenly added
--cc-cmd=./scripts/get_maintainer.pl
On 29.04.24 14:51, Vladimir Sementsov-Ogievskiy wrote:
The following changes since commit fd87be1dada5672f877e03c2ca8504458292c479:
Merge tag 'accel-20240426' of https://github.com/philmd/qemu
Add test for a new backup option: discard-source.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fiona Ebner
Tested-by: Fiona Ebner
Message-Id: <20240313152822.626493-6-vsement...@yandex-team.ru>
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
.../qemu-iotests/tests/backup-d
.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fiona Ebner
Tested-by: Fiona Ebner
Acked-by: Markus Armbruster
Message-Id: <20240313152822.626493-5-vsement...@yandex-team.ru>
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/backup.c | 5 +++--
ans RW mode
If the base image is in RW mode at the end of blockcommit and was in RO
mode before blockcommit, reopen the base BDS in RO.
Signed-off-by: Alexander Ivanov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20240404091136.129811-1-alexander.iva...@virtuozzo.com>
Signed
-Ogievskiy
Reviewed-by: Fiona Ebner
Tested-by: Fiona Ebner
Message-Id: <20240313152822.626493-4-vsement...@yandex-team.ru>
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-copy.c | 3 +-
block/copy-before-write.c | 2 +-
include/block/block-copy.h | 1 +
tests/qemu-iotes
base image as RO after abort
Alexander Ivanov (1):
blockcommit: Reopen base image as RO after abort
Vladimir Sementsov-Ogievskiy (5):
block/copy-before-write: fix permission
block/copy-before-write: support unligned
First thing that crashes on unligned access here is
bdrv_reset_dirty_bitmap(). Correct way is to align-down the
snapshot-discard request.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fiona Ebner
Tested-by: Fiona Ebner
Message-Id: <20240313152822.626493-3-vsement...@yandex-team
t...@openvz.org/
[2] https://patchew.org/QEMU/2023101718.932733-1-vsement...@yandex-team.ru/
Signed-off-by: Vladimir Sementsov-Ogievskiy
Tested-by: Fiona Ebner
Message-Id: <20240313152822.626493-2-vsement...@yandex-team.ru>
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/copy-b
Split vhost_user_blk_sync_config() out from
vhost_user_blk_handle_config_change(), to be reused in the following
commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/block/vhost-user-blk.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/hw
v4:
Fixes 01-02 from v3 are already merged.
02: new, split out from 03
03: refacting vhost_user_blk_handle_config_change() split out to 02
drop current_run_state_str() helper
some rewordings (Markus)
Vladimir Sementsov-Ogievskiy (3):
qdev-monitor: add option to report GenericError from
the
sync only in RUNNING state.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/block/vhost-user-blk.c | 1 +
hw/virtio/virtio-pci.c| 9
include/hw/qdev-core.h| 3 +++
qapi/qdev.json| 23 +++
system/qdev-monitor.c | 48
of DeviceNotFound anyway
- also, nothing prevent simply copy-pasting find_device_state() calls
with false argument
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
system/qdev-monitor.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/system/qdev-monitor.c b
On 24.04.24 15:11, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Send a new event when guest reads virtio-pci config after
virtio_notify_config() call.
That's useful to check that guest fetched modified config, for example
after resizing disk backend.
Signed-off-by: Vladimir
On 24.04.24 14:48, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Add command to sync config from vhost-user backend to the device. It
may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not
triggered interrupt to the guest or just not available (not supported
ping!)
--
Best regards,
Vladimir
On 09.04.24 18:49, Eric Blake wrote:
On Tue, Apr 09, 2024 at 09:30:39AM +0300, Vladimir Sementsov-Ogievskiy wrote:
On 08.04.24 19:00, Eric Blake wrote:
nbd_negotiate() is already marked coroutine_fn. And given the fix in
the previous patch to have nbd_negotiate_handle_starttls not create
Introduce a test, that checks that plug/unplug of virtio-blk device
works.
(the test is developed by copying hotplug_cpu.py, so keep original
copyright)
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/avocado/hotplug_blk.py | 69
1 file changed, 69
static
functions reachable only during option negotiation as also being
coroutine_fn.
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Eric Blake
---
nbd/server.c | 102 +--
1 file changed, 59 insertions(+), 43 deletions(-)
diff --git a/nbd
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
ation")
Signed-off-by: Zhu Yangyang
[eblake: move callbacks to their use point]
Signed-off-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
still, some notes below
---
v3: https://lists.gnu.org/archive/html/qemu-devel/2024-04/msg00375.html
in v4, factor even the struct to th
On 04.04.24 04:42, Eric Blake wrote:
From: Zhu Yangyang
Coroutines are not supposed to block. Instead, they should yield.
The client performs TLS upgrade outside of an AIOContext, during
synchronous handshake; this still requires g_main_loop. But the
server responds to TLS upgrade inside a
On 13.03.24 18:28, Vladimir Sementsov-Ogievskiy wrote:
Hi all! The main patch is 04, please look at it for description and
diagram.
v4: add t-b by Fiona
add r-b by Fiona to 02-05 (patch 01 still lack an r-b)
05: fix copyrights and subject in the test
04: since 9.0 --> since
02140002 < The last 2 means RW mode
If the base image is in RW mode at the end of blockcommit and was in RO
mode before blockcommit, reopen the base BDS in RO.
Signed-off-by: Alexander Ivanov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Thanks, applied to my block branch.
--
Best regards,
Vladimir
On 03.04.24 20:50, Eric Blake wrote:
On Wed, Apr 03, 2024 at 01:24:11PM +0400, Marc-André Lureau wrote:
Unfortunately, it doesn't work in all cases. It seems to have issues
with some guards:
../block/stream.c: In function ‘stream_run’:
../block/stream.c:216:12: error: ‘ret’ may be used
On 03.04.24 11:11, Marc-André Lureau wrote:
Hi
On Tue, Apr 2, 2024 at 11:24 PM Vladimir Sementsov-Ogievskiy
wrote:
On 02.04.24 18:34, Eric Blake wrote:
On Tue, Apr 02, 2024 at 12:58:43PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Again, same false-positives, because
On 07.03.24 16:47, Fiona Ebner wrote:
From: John Snow
for the mirror job. The bitmap's granularity is used as the job's
granularity.
The new @bitmap parameter is marked unstable in the QAPI and can
currently only be used for @sync=full mode.
Clusters initially dirty in the bitmap as well as
On 02.04.24 18:34, Eric Blake wrote:
On Tue, Apr 02, 2024 at 12:58:43PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Again, same false-positives, because of WITH_GRAPH_RDLOCK_GUARD()..
Didn't you try to change WITH_ macros somehow, so that compiler believe in our
good intentions?
#define
On 02.04.24 12:12, Marc-André Lureau wrote:
Hi
On Fri, Mar 29, 2024 at 12:35 PM Vladimir Sementsov-Ogievskiy
wrote:
On 28.03.24 13:20, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
../block/stream.c:193:19: error: ‘unfiltered_bs’ may be used uninitialized
[-Werror=maybe
in mirror_start().
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Fiona Ebner
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 29.03.24 13:56, Cédric Le Goater wrote:
This allows to report more precise errors in the migration handler
dirty_bitmap_save_setup().
Suggested-by Vladimir Sementsov-Ogievskiy
Signed-off-by: Cédric Le Goater
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
This "hotpluggable" here is misleading. Actually we check is object a
device or not. Let's drop the word.
Suggested-by: Markus Armbruster
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Markus Armbruster
---
system/qdev-monitor.c | 2 +-
1 file changed, 1 insertion(+),
v3:
02: add r-b by Markus
03: improve commit message
04: improve documentation, merge race-fix here (which was v2:05),
rebase on master (migration_is_running() now without arguments)
05: improve documentation
Vladimir Sementsov-Ogievskiy (5):
vhost-user-blk: simplify and fix
of DeviceNotFound anyway
- also, nothing prevent simply copy-pasting find_device_state() calls
with false argument
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
system/qdev-monitor.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/system/qdev-monitor.c b
Send a new event when guest reads virtio-pci config after
virtio_notify_config() call.
That's useful to check that guest fetched modified config, for example
after resizing disk backend.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/virtio/virtio-pci.c | 9 +
include/monitor
the
sync only in RUNNING state.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/block/vhost-user-blk.c | 27 --
hw/virtio/virtio-pci.c| 9
include/hw/qdev-core.h| 3 +++
include/sysemu/runstate.h | 1 +
qapi/qdev.json| 21
reason to create extra
branches in the logic.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Acked-by: Raphael Norwitz
---
hw/block/vhost-user-blk.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
index 6a856a
On 29.03.24 13:53, Cédric Le Goater wrote:
Hello Vladimir,
On 3/29/24 10:32, Vladimir Sementsov-Ogievskiy wrote:
On 20.03.24 09:49, Cédric Le Goater wrote:
diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
index
2708abf3d762de774ed294d3fdb8e56690d2974c
to the backup source will too. If
the granularity is too small, they will just be aligned down in
cbw_co_pdiscard_snapshot() and thus effectively ignored.
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Fiona Ebner
---
block/backup.c| 2 +-
block/copy-before-write.c | 2
node will too. If the
granularity is too small, they will just be aligned down in
cbw_co_pdiscard_snapshot() and thus effectively ignored.
The QAPI uses uint32 so the value will be non-negative, but still fit
into a uint64_t.
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Fiona Ebner
quot;Failed to initialize migration of block dirty bitmaps".
with this, for block dirty bitmap migration:
Acked-by: Vladimir Sementsov-Ogievskiy
Still, a lot better is add errp to init_dirty_bitmap_migration() and to
add_bitmaps_to_list() too: look,
init_dirty_bitmap_migration() fails only
}
+
All looks good to me except this: seems it is safer to place this "if" block before
"bdrv_drained_end(); bdrv_unref();" above. With it moved:
Reviewed-by: Vladimir Sementsov-Ogievskiy
bs_opaque->job = NULL;
bdrv_drained_end(src);
@@
, "unused variable initialization" is bad thing too.
Anyway, if no better solution for now:
Acked-by: Vladimir Sementsov-Ogievskiy
---
block/stream.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/stream.c b/block/stream.c
index 7031eef12b..9076203
unconditionally. Probably we should
mention this in a comment.
Signed-off-by: Marc-André Lureau
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/mirror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/mirror.c b/block/mirror.c
index 1bdce3b657..53dd7332ee
On 28.03.24 12:24, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
We are going to add more parameters to change. We want to make possible
to change only one or any subset of available options. So all the
options should be optional.
Signed-off-by: Vladimir Sementsov-Ogievskiy
On 28.03.24 12:15, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Look at block-job-change command: we have to specify both 'id' to chose
the job to operate on and 'type' for QAPI union be parsed. But for user
this looks redundant: when we specify 'id', QEMU should be able
On 28.03.24 12:40, Markus Armbruster wrote:
Subject: all unions are type-based. Perhaps "support implicit union
tags on the wire"?
Yes, sounds good.
Do you need this schema language feature for folding block jobs into the
jobs abstraction, or is it just for making the wire protocol nicer
On 25.03.24 16:04, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Most of fields have no description at all. Let's fix that. Still, no
reason to place here more detailed descriptions of what these
structures are, as we have public Qcow2 format specification.
Signed-off
Most of fields have no description at all. Let's fix that. Still, no
reason to place here more detailed descriptions of what these
structures are, as we have public Qcow2 format specification.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qapi/block-core.json | 25 +
1
On 15.03.24 12:55, Alexander Ivanov wrote:
On 2/28/24 17:48, Vladimir Sementsov-Ogievskiy wrote:
On 09.02.24 15:29, Alexander Ivanov wrote:
Could you please review the patch?
Sorry for long delay.
Honestly, I don't like refcnt in block-driver. It violate incapsulation, refcnt
is interal
On 15.03.24 15:51, Markus Armbruster wrote:
Sorry for the late answer.
Vladimir Sementsov-Ogievskiy writes:
On 07.03.24 12:46, Markus Armbruster wrote:
[...]
I appreciate the attempt to curb the spread of DeviceNotFound errors.
Two issues:
* Copy-pasting find_device_state() with a false
On 13.03.24 19:08, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Add a parameter that enables discard-after-copy. That is mostly useful
in "push backup with fleecing" scheme, when source is snapshot-access
format driver node, based on copy-before-write filter snaps
Hi all! The main patch is 04, please look at it for description and
diagram.
v4: add t-b by Fiona
add r-b by Fiona to 02-05 (patch 01 still lack an r-b)
05: fix copyrights and subject in the test
04: since 9.0 --> since 9.1 (we missed a soft freeze for 9.0)
Vladimir Sement
.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fiona Ebner
Tested-by: Fiona Ebner
---
block/backup.c | 5 +++--
block/block-copy.c | 9 +
block/copy-before-write.c | 15 +--
block/copy-before-write.h
copy_bitmap.
That's all not ideal: it would be better if internal bitmap of
block-copy object is not attached to any node. But that is not possible
now.
The simplest solution is just create copy_bitmap in filter node, where
anyway two other bitmaps are created.
Signed-off-by: Vladimir Sementsov
Add test for a new backup option: discard-source.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fiona Ebner
Tested-by: Fiona Ebner
---
.../qemu-iotests/tests/backup-discard-source | 152 ++
.../tests/backup-discard-source.out | 5 +
2 files changed, 157
t...@openvz.org/
[2] https://patchew.org/QEMU/2023101718.932733-1-vsement...@yandex-team.ru/
Signed-off-by: Vladimir Sementsov-Ogievskiy
Tested-by: Fiona Ebner
---
block/copy-before-write.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/block/copy-before-w
First thing that crashes on unligned access here is
bdrv_reset_dirty_bitmap(). Correct way is to align-down the
snapshot-discard request.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fiona Ebner
Tested-by: Fiona Ebner
---
block/copy-before-write.c | 16 +---
1 file
Duplicate the feature from query-block-jobs. It's a step to finally
deprecate query-block-jobs command and move to query-jobs.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/mirror.c | 14 --
include/qemu/job.h | 5 +
job-qmp.c | 6 ++
qapi/job.json
Now QEMU can understand type directly from the job itself, type is
redundant.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
blockjob.c | 2 +-
docs/about/deprecated.rst| 6 ++
job-qmp.c| 17 +
qapi/block
Sementsov-Ogievskiy
---
scripts/qapi/introspect.py | 5 +++-
scripts/qapi/schema.py | 50 +++---
scripts/qapi/types.py | 3 ++-
scripts/qapi/visit.py | 43 ++--
4 files changed, 73 insertions(+), 28 deletions(-)
diff --git
| \
xargs sed -i 's/BlockDeviceIoStatus/IoStatus/g'
git grep -l BLOCK_DEVICE_IO_STATUS | \
xargs sed -i 's/BLOCK_DEVICE_IO_STATUS/IO_STATUS/g'
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-backend.c | 14 +++---
block/mirror.c
job->ret must be always set together with job->err. Let's assert this.
Reproting no-error to the user, when job->err is unset and job->ret is
somehow set would be a bug.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
job-qmp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/job
to refactor when we finally drop
deprecated block-job-* APIs.
@type argument of the new command immediately becomes deprecated.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
docs/about/deprecated.rst | 4 ++--
job-qmp.c | 14 ++
qapi/block-core.json | 10
Add io-status and speed, which make sense only for block-jobs. This
allows us to finally deprecate old query-block-jobs API in the next
commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/backup.c | 6 ++
block/commit.c | 6 ++
block/mirror.c
Like for other block-job-* APIs we want have the actual functionality
in job layer and make block-job-change to be a deprecated duplication
of job-change in the following commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/mirror.c | 7 +++
blockdev.c
We will need to use the structure both in block-core.json and job.json.
So, move it to common.json, which could be then included to job.json.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qapi/block-core.json | 16
qapi/common.json | 16
2 files changed
er mode of "complete", not "cancel".
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/mirror.c | 8 +---
include/qemu/job.h | 8 +++-
job-qmp.c| 20 +++-
job.c
We are going to add more parameters to change. We want to make possible
to change only one or any subset of available options. So all the
options should be optional.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/mirror.c | 5 +
qapi/block-core.json | 2 +-
2 files changed, 6
/BlockJobChangeOptions/JobChangeOptions/g'
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/mirror.c | 4 ++--
blockdev.c | 2 +-
blockjob.c | 2 +-
include/block/blockjob.h | 2 +-
include/block/blockjob_int.h | 2 +-
qapi/block-core.json
Allow change job speed through job-change command. Old
block-job-set-speed would be deprecated soon.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/backup.c | 8 ++
block/commit.c | 10 ++-
block/mirror.c | 60
documentation changes for details).
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
docs/about/deprecated.rst | 73 +--
qapi/block-core.json | 59 ++-
2 files changed, 129 insertions(+), 3 deletions(-)
diff --git a/docs/about
User may specify wrong type for the job id. Let's check it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
blockjob.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/blockjob.c b/blockjob.c
index 8cfbb15543..788cb1e07d 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -319,6 +319,12
: support soft-cancelling ready mirror job in new API (as an
option to job-complete)
10-14: prepare query-jobs to substitute query-block-jobs
15: finally, deprecate old APIs
RFC: the series are untested. I plan to move tests to using new APIs
instead of deprecated ones in v2.
Vladimir Sementsov
On 12.03.24 18:49, Kevin Wolf wrote:
Am 12.03.2024 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben:
On 11.03.24 18:15, Vladimir Sementsov-Ogievskiy wrote:
On 08.03.24 11:52, Kevin Wolf wrote:
Am 07.03.2024 um 20:42 hat Vladimir Sementsov-Ogievskiy geschrieben:
On 04.03.24 14:09, Peter
On 11.03.24 18:15, Vladimir Sementsov-Ogievskiy wrote:
On 08.03.24 11:52, Kevin Wolf wrote:
Am 07.03.2024 um 20:42 hat Vladimir Sementsov-Ogievskiy geschrieben:
On 04.03.24 14:09, Peter Krempa wrote:
On Mon, Mar 04, 2024 at 11:48:54 +0100, Kevin Wolf wrote:
Am 28.02.2024 um 19:07 hat
On 11.03.24 00:07, Peter Krempa wrote:
On Thu, Mar 07, 2024 at 22:42:56 +0300, Vladimir Sementsov-Ogievskiy wrote:
On 04.03.24 14:09, Peter Krempa wrote:
On Mon, Mar 04, 2024 at 11:48:54 +0100, Kevin Wolf wrote:
Am 28.02.2024 um 19:07 hat Vladimir Sementsov-Ogievskiy geschrieben:
On 03.11.23
On 08.03.24 11:52, Kevin Wolf wrote:
Am 07.03.2024 um 20:42 hat Vladimir Sementsov-Ogievskiy geschrieben:
On 04.03.24 14:09, Peter Krempa wrote:
On Mon, Mar 04, 2024 at 11:48:54 +0100, Kevin Wolf wrote:
Am 28.02.2024 um 19:07 hat Vladimir Sementsov-Ogievskiy geschrieben:
On 03.11.23 18:56
On 04.03.24 14:09, Peter Krempa wrote:
On Mon, Mar 04, 2024 at 11:48:54 +0100, Kevin Wolf wrote:
Am 28.02.2024 um 19:07 hat Vladimir Sementsov-Ogievskiy geschrieben:
On 03.11.23 18:56, Markus Armbruster wrote:
Kevin Wolf writes:
[...]
Is the job abstraction a failure?
We have
On 07.03.24 12:46, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
system/qdev-monitor.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c
index
On 07.03.24 13:01, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Send a new event when guest reads virtio-pci config after
virtio_notify_config() call.
That's useful to check that guest fetched modified config, for example
after resizing disk backend.
Signed-off-by: Vladimir
On 07.03.24 12:57, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Command result is racy if allow it during migration. Let's allow the
sync only in RUNNING state.
Signed-off-by: Vladimir Sementsov-Ogievskiy
If I understand this correctly, the previous commit introduces
On 07.03.24 12:54, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Add command to sync config from vhost-user backend to the device. It
may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not
triggered interrupt to the guest or just not available (not supported
On 07.03.24 12:46, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
system/qdev-monitor.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c
index
On 06.03.24 16:44, Fiona Ebner wrote:
Am 29.02.24 um 13:47 schrieb Fiona Ebner:
Am 29.02.24 um 12:48 schrieb Vladimir Sementsov-Ogievskiy:
On 29.02.24 13:11, Fiona Ebner wrote:
The iotest creates a new target image for each incremental sync which
only records the diff relative
config, but it's still better than nothing: for sure
guest will not show new disk size until it read the updated config. So,
management tool may wait for this event to report success to the user.
Vladimir Sementsov-Ogievskiy (6):
vhost-user-blk: simplify and fix vhost_user_blk_handle_config_ch
Command result is racy if allow it during migration. Let's allow the
sync only in RUNNING state.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/sysemu/runstate.h | 1 +
system/qdev-monitor.c | 27 ++-
system/runstate.c | 5 +
3 files changed
Add command to sync config from vhost-user backend to the device. It
may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not
triggered interrupt to the guest or just not available (not supported
by vhost-user server).
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/block/vhost
Send a new event when guest reads virtio-pci config after
virtio_notify_config() call.
That's useful to check that guest fetched modified config, for example
after resizing disk backend.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/virtio/virtio-pci.c | 9 +
include/monitor
reason to create extra
branches in the logic.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Acked-by: Raphael Norwitz
---
hw/block/vhost-user-blk.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
index 6a856a
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
system/qdev-monitor.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c
index 9febb743f1..cf7481e416 100644
--- a/system/qdev-monitor.c
+++ b/system/qdev-monitor.c
This "hotpluggable" here is misleading. Actually we check is object a
device or not. Let's drop the word.
SUggested-by: Markus Armbruster
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
system/qdev-monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/s
1 - 100 of 9422 matches
Mail list logo
