Re: [PATCH] migration/block-dirty-bitmap: fix larger granularity bitmaps

2020-10-22 Thread Vladimir Sementsov-Ogievskiy
22.10.2020 10:46, Stefan Reiter wrote: On 10/21/20 5:17 PM, Vladimir Sementsov-Ogievskiy wrote: 21.10.2020 17:44, Stefan Reiter wrote: sectors_per_chunk is a 64 bit integer, but the calculation is done in 32 bits, leading to an overflow for coarse bitmap granularities. If that results in the

Re: [PATCH] migration/block-dirty-bitmap: fix larger granularity bitmaps

2020-10-22 Thread Stefan Reiter
On 10/21/20 5:17 PM, Vladimir Sementsov-Ogievskiy wrote: 21.10.2020 17:44, Stefan Reiter wrote: sectors_per_chunk is a 64 bit integer, but the calculation is done in 32 bits, leading to an overflow for coarse bitmap granularities. If that results in the value 0, it leads to a hang where no

Re: [PATCH] migration/block-dirty-bitmap: fix larger granularity bitmaps

2020-10-21 Thread Eric Blake
On 10/21/20 9:44 AM, Stefan Reiter wrote: > sectors_per_chunk is a 64 bit integer, but the calculation is done in 32 > bits, leading to an overflow for coarse bitmap granularities. > > If that results in the value 0, it leads to a hang where no progress is > made but send_bitmap_bits is

Re: [PATCH] migration/block-dirty-bitmap: fix larger granularity bitmaps

2020-10-21 Thread Vladimir Sementsov-Ogievskiy
21.10.2020 17:44, Stefan Reiter wrote: sectors_per_chunk is a 64 bit integer, but the calculation is done in 32 bits, leading to an overflow for coarse bitmap granularities. If that results in the value 0, it leads to a hang where no progress is made but send_bitmap_bits is constantly called

[PATCH] migration/block-dirty-bitmap: fix larger granularity bitmaps

2020-10-21 Thread Stefan Reiter
sectors_per_chunk is a 64 bit integer, but the calculation is done in 32 bits, leading to an overflow for coarse bitmap granularities. If that results in the value 0, it leads to a hang where no progress is made but send_bitmap_bits is constantly called with nr_sectors being 0. Signed-off-by: