Re: [PATCH 00/16] hw/block/nvme: zoned namespace command set

2020-09-25 Thread Klaus Jensen
On Sep 25 17:06, Dmitry Fomichev wrote: > > From: Klaus Jensen > > > > * Standard blockdev-based approach to persistent state. The > > > > implementation uses a plain blockdev associated with the nvme-ns > > > > device for storing state persistently. This same 'pstate' blockdev > >

RE: [PATCH 00/16] hw/block/nvme: zoned namespace command set

2020-09-25 Thread Dmitry Fomichev
ax Reitz > ; Keith Busch ; Klaus Jensen > > Subject: [PATCH 00/16] hw/block/nvme: zoned namespace command set > > From: Klaus Jensen > > > While going through a few rounds of reviews on Dmitry's series I have > > also continued nursing my own implementation since

Re: [PATCH 00/16] hw/block/nvme: zoned namespace command set

2020-09-25 Thread Klaus Jensen
; > Type: series > Message-id: 20200924204516.1881843-1-...@irrelevant.dk > Subject: [PATCH 00/16] hw/block/nvme: zoned namespace command set > > 7/16 Checking commit ab4c119d9d68 (hw/block/nvme: add commands supported and > effects log page) > ERROR: Macros with complex values should be enclo

Re: [PATCH 00/16] hw/block/nvme: zoned namespace command set

2020-09-24 Thread Klaus Jensen
On Sep 24 19:24, Keith Busch wrote: > On Thu, Sep 24, 2020 at 10:45:00PM +0200, Klaus Jensen wrote: > > Finally, I wrote this. I am *NOT* saying that this somehow makes it > > better, but as a maintainer, is a big deal to me since both series are > > arguably a lot of code to maintain and support

Re: [PATCH 00/16] hw/block/nvme: zoned namespace command set

2020-09-24 Thread Keith Busch
On Thu, Sep 24, 2020 at 10:45:00PM +0200, Klaus Jensen wrote: > Finally, I wrote this. I am *NOT* saying that this somehow makes it > better, but as a maintainer, is a big deal to me since both series are > arguably a lot of code to maintain and support (both series are about > the same size). But

Re: [PATCH 00/16] hw/block/nvme: zoned namespace command set

2020-09-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200924204516.1881843-1-...@irrelevant.dk/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200924204516.1881843-1-...@irrelevant.dk Subject: [PATCH 00/16] hw/block/nvme: zoned

[PATCH 00/16] hw/block/nvme: zoned namespace command set

2020-09-24 Thread Klaus Jensen
From: Klaus Jensen While going through a few rounds of reviews on Dmitry's series I have also continued nursing my own implementation since originally posted. I did not receive any reviews originally, since it depended on a lot of preceding series, but now, with the staging of multiple