Re: [PATCH v2 8/9] hw/dma: Use dma_addr_t type definition when relevant

2022-01-10 Thread Philippe Mathieu-Daudé
On 1/10/22 09:49, David Hildenbrand wrote: > On 04.01.22 09:54, Philippe Mathieu-Daudé wrote: >> From: Philippe Mathieu-Daudé >> >> Update the obvious places where dma_addr_t should be used >> (instead of uint64_t, hwaddr, size_t, int32_t types). >> >> This allows to have _addr_t type portable on

Re: [PATCH v2 8/9] hw/dma: Use dma_addr_t type definition when relevant

2022-01-10 Thread David Hildenbrand
On 04.01.22 09:54, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > Update the obvious places where dma_addr_t should be used > (instead of uint64_t, hwaddr, size_t, int32_t types). > > This allows to have _addr_t type portable on 32/64-bit > hosts. > > Move QEMUSGList

Re: [PATCH v2 8/9] hw/dma: Use dma_addr_t type definition when relevant

2022-01-04 Thread Peter Xu
On Tue, Jan 04, 2022 at 09:54:30AM +0100, Philippe Mathieu-Daudé wrote: > diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c > index 462f79a1f60..c3c49176110 100644 > --- a/hw/nvme/ctrl.c > +++ b/hw/nvme/ctrl.c > @@ -1147,7 +1147,7 @@ static uint16_t nvme_tx(NvmeCtrl *n, NvmeSg *sg, > uint8_t *ptr,

[PATCH v2 8/9] hw/dma: Use dma_addr_t type definition when relevant

2022-01-04 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Update the obvious places where dma_addr_t should be used (instead of uint64_t, hwaddr, size_t, int32_t types). This allows to have _addr_t type portable on 32/64-bit hosts. Move QEMUSGList declaration after dma_addr_t declaration so this structure can use the new