[Qemu-block] [PATCH 3/3] block: prohibit migration during transactions

2015-10-01 Thread John Snow
Similarly to BlockJobs, prohibit migration at least during the synchronous phase of a transaction. In particular, this guards internal and external snapshots, which are implemented via transaction actions through blockdev_do_action. Signed-off-by: John Snow --- blockdev.c |

Re: [Qemu-block] [PATCH 3/3] block: prohibit migration during transactions

2015-10-01 Thread Paolo Bonzini
On 01/10/2015 18:34, John Snow wrote: > + > +error_setg(, "Block device(s) are in use by a Block > Transaction"); s/Block Transaction/transaction command/ But how can migration start during a transaction? > +ret = migrate_add_blocker(blocker, errp); > +if (ret < 0) { > +