[adding qemu-block in cc, per MAINTAINERS]
On 12/10/2015 02:55 AM, Denis V. Lunev wrote:
> s->qcow_version is always set to 2 or 3. Let's assert if this is wrong.
>
> Signed-off-by: Denis V. Lunev <d...@openvz.org>
> CC: Roman Kagan <rka...@virtuozzo.com>
> CC: Max Reitz <mre...@redhat.com>
> CC: Kevin Wolf <kw...@redhat.com>
> ---
> block/qcow2.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 88f56c8..b285014 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -2757,6 +2757,10 @@ static ImageInfoSpecific
> *qcow2_get_specific_info(BlockDriverState *bs)
> .has_corrupt = true,
> .refcount_bits = s->refcount_bits,
> };
> + } else {
> + /* if this assertion fails, this probably means a new version was
> + * added without having it covered here */
> + assert(false);Only covers us if we don't turn on NDEBUG during compile; but then again, lots of spots in the code base assume assert() will never be crippled. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
