Re: [Qemu-block] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

On 07/28/2018 02:50 AM, Niels de Vos wrote: Part of me wishes that libgfapi had just created a new function 'glfs_ftruncate2', so that existing users don't need to handle the api change. But I guess in the grand scheme, not a huge deal either way. Gluster uses versioned symbols, so older

Re: [Qemu-block] [PATCH 1/6 for-3.0] Update .gitignore

On 07/30/2018 10:40 AM, Eric Blake wrote: On 07/29/2018 04:27 PM, Leonid Bloch wrote: Adds /roms/vgabios to .gitignore - this directory appears after the build, and was not ignored by Git so far. Actually, that's the directories for one of the submodules. It seems fishy to have a directory

Re: [Qemu-block] [PATCH 0/6] qcow2: Make the L2 cache cover the whole image by default

Am 29.07.2018 um 23:27 hat Leonid Bloch geschrieben: > This series makes the qcow2 L2 cache cover the entire image by default. > The importance of this change is in noticeable performance improvement, > especially with heavy random I/O. The memory overhead is very small: > only 1 MB of cache for

Re: [Qemu-block] [PATCH 4/6] qcow2: Update total_sectors when resizing the image

On 07/30/2018 12:43 PM, Kevin Wolf wrote: Am 29.07.2018 um 23:27 hat Leonid Bloch geschrieben: Signed-off-by: Leonid Bloch --- block/qcow2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index ec9e6238a0..223d351e40 100644 --- a/block/qcow2.c +++

Re: [Qemu-block] [PATCH 4/6] qcow2: Update total_sectors when resizing the image

Am 30.07.2018 um 13:41 hat Leonid Bloch geschrieben: > On 07/30/2018 12:43 PM, Kevin Wolf wrote: > > Am 29.07.2018 um 23:27 hat Leonid Bloch geschrieben: > > > Signed-off-by: Leonid Bloch > > > --- > > > block/qcow2.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git

[Qemu-block] [PULL 03/13] file-posix: Handle EINTR in preallocation=full write

From: Fam Zheng Cc: qemu-sta...@nongnu.org Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- block/file-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/file-posix.c b/block/file-posix.c index ad299beb38..928b863ced 100644 --- a/block/file-posix.c +++

[Qemu-block] [PULL 09/13] block: Fix documentation for BDRV_REQ_MAY_UNMAP

BDRV_REQ_MAY_UNMAP in a write_zeroes request does not only allow the driver to unmap the blocks, but it actively requests that the blocks be unmapped afterwards if at all possible. Signed-off-by: Kevin Wolf --- include/block/block.h | 11 ++- 1 file changed, 6 insertions(+), 5

[Qemu-block] [PULL 12/13] block/qapi: Include anonymous BBs in query-blockstats

Consistent with query-block, query-blockstats should not only include named BlockBackends, but also those that are anonymous, but belong to a device model. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block/qapi.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-block] [PATCH 1/6 for-3.0] Update .gitignore

On 07/29/2018 04:27 PM, Leonid Bloch wrote: Adds /roms/vgabios to .gitignore - this directory appears after the build, and was not ignored by Git so far. Actually, that's the directories for one of the submodules. It seems fishy to have a directory listed in both .gitignore and .gitmodules

Re: [Qemu-block] [PATCH] virtio-blk: fix comment for virtio_blk_rw_complete

Oh, sorry, this patch should go into trivial mail list. On Sat, Jul 28, 2018 at 01:18:44PM +0800, Yaowei Bai wrote: > Here should be submit_requests, there is no submit_merged_requests > function. > > Signed-off-by: Yaowei Bai > --- > hw/block/virtio-blk.c | 4 ++-- > 1 file changed, 2

Re: [Qemu-block] interactive qemu-img

> On Jul 30, 2018, at 11:09 AM, Eric Blake wrote: > > On 07/28/2018 08:22 PM, Programmingkid wrote: >> I thought of a way to make qemu-img much more user-friendly. When the user >> opens qemu-img without any arguments, we could present a prompt that guides >> the user on making an image

[Qemu-block] [PULL 08/13] iotests: Add test for 'qemu-img convert -C' compatibility

From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/082 | 8 tests/qemu-iotests/082.out | 11 +++ 2 files changed, 19 insertions(+) diff --git a/tests/qemu-iotests/082 b/tests/qemu-iotests/082 index a872f771a6..3e605d52d1 100755 ---

[Qemu-block] [PULL 07/13] qemu-img: Add -C option for convert with copy offloading

From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- qemu-img.c | 21 + qemu-img-cmds.hx | 2 +- qemu-img.texi| 8 +++- 3 files changed, 25 insertions(+), 6 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 9b7506b8ae..1acddf693c

[Qemu-block] [PULL 11/13] block/qapi: Add 'qdev' field to query-blockstats result

Like for query-block, the client needs to identify which BlockBackend the returned data is for. Anonymous BlockBackends are identified by the device model they are attached to. Add a 'qdev' field that contains the qdev ID or QOM path of the attached device model. Signed-off-by: Kevin Wolf

[Qemu-block] [PULL 10/13] file-posix: Fix write_zeroes with unmap on block devices

The BLKDISCARD ioctl doesn't guarantee that the discarded blocks read as all-zero afterwards, so don't try to abuse it for zero writing. We try to only use this if BLKDISCARDZEROES tells us that it is safe, but this is unreliable on older kernels and a constant 0 in newer kernels. In other words,

Re: [Qemu-block] [Qemu-devel] [PATCH for-3.0 0/7] fix persistent bitmaps migration logic

Quoting John Snow (2018-07-23 17:22:03) > This is an updated version of Vladimir's proposal for fixing the > handling around migration and persistent dirty bitmaps. Are these still being considered for 3.0 rc3/rc4? 2.12.1 releases this week and I'm not sure how badly these are needed. > >

[Qemu-block] [PULL 04/13] docs: Describe using images in writing iotests

From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: John Snow Signed-off-by: Kevin Wolf --- docs/devel/testing.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 5e19cd50da..8e1fa3a66e 100644

[Qemu-block] [PULL 00/13] Block layer patches

The following changes since commit 6d9dd5fb9d0e9f4a174f53a0e20a39fbe809c71e: Merge remote-tracking branch 'remotes/armbru/tags/pull-qobject-2018-07-27-v2' into staging (2018-07-30 09:55:47 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for

[Qemu-block] [PULL 02/13] qcow2: A grammar fix in conflicting cache sizing error message

From: Leonid Bloch Signed-off-by: Leonid Bloch Reviewed-by: John Snow Signed-off-by: Kevin Wolf --- block/qcow2.c | 2 +- tests/qemu-iotests/103.out | 4 ++-- tests/qemu-iotests/137.out | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block/qcow2.c

[Qemu-block] [PULL 06/13] Revert "qemu-img: Document copy offloading implications with -S and -c"

From: Fam Zheng This reverts commit eb461485f4558e362fab905735b50987505bca44. Now that we introduce an explicit option, these implicit rules are not used. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- qemu-img.texi | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

Re: [Qemu-block] interactive qemu-img

On 07/28/2018 08:22 PM, Programmingkid wrote: I thought of a way to make qemu-img much more user-friendly. When the user opens qemu-img without any arguments, we could present a prompt that guides the user on making an image file. This illustrates what I think should happen. Please select

[Qemu-block] [PULL 01/13] qcow: fix a reference leak

From: KONRAD Frederic Since 42a3e1ab367cdf38cce093de24eb406b99a4ef96 qemu asserts when using the vvfat driver: git clone git://qemu.org/qemu.git cd qemu ./configure --target-list=ppc-softmmu --enable-debug make -j8 mkdir foo touch foo/hello ./ppc-softmmu/qemu-system-ppc -M prep --nographic

[Qemu-block] [PULL 05/13] iotests: Don't lock /dev/null in 226

From: Fam Zheng On my system (Fedora 28), this script reports a 'failed to get "consistent read" lock' error. Following docs/devel/testing.rst, it's better to add locking=off here. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: John Snow Signed-off-by: Kevin Wolf ---

[Qemu-block] [PULL 13/13] qemu-iotests: Test query-blockstats with -drive and -blockdev

Make sure that query-blockstats returns information for every BlockBackend that is named or attached to a device model (or both). Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/qemu-iotests/227 | 101 ++ tests/qemu-iotests/227.out

Re: [Qemu-block] [PATCH for-3.0 1/3] block/qapi: Add 'qdev' field to query-blockstats result

On Fri, Jul 27, 2018 at 17:58:54 +0200, Kevin Wolf wrote: > Am 27.07.2018 um 17:07 hat Eric Blake geschrieben: > > On 07/27/2018 09:15 AM, Kevin Wolf wrote: > > > Like for query-block, the client needs to identify which BlockBackend > > > the returned data is for. Anonymous BlockBackends are

Re: [Qemu-block] [PATCH 0/6] qcow2: Make the L2 cache cover the whole image by default

On 07/30/2018 01:55 PM, Kevin Wolf wrote: Am 29.07.2018 um 23:27 hat Leonid Bloch geschrieben: This series makes the qcow2 L2 cache cover the entire image by default. The importance of this change is in noticeable performance improvement, especially with heavy random I/O. The memory overhead is

Re: [Qemu-block] [PATCH 0/6] qcow2: Make the L2 cache cover the whole image by default

Am 30.07.2018 um 14:13 hat Leonid Bloch geschrieben: > On 07/30/2018 01:55 PM, Kevin Wolf wrote: > > Am 29.07.2018 um 23:27 hat Leonid Bloch geschrieben: > > > This series makes the qcow2 L2 cache cover the entire image by default. > > > The importance of this change is in noticeable performance

Re: [Qemu-block] interactive qemu-img

On Mon, Jul 30, 2018 at 04:57:54PM -0400, Programmingkid wrote: > > > On Jul 30, 2018, at 3:55 PM, Jeff Cody wrote: > > > > On Mon, Jul 30, 2018 at 12:30:01PM -0400, Programmingkid wrote: > >> > >>> On Jul 30, 2018, at 11:09 AM, Eric Blake wrote: > >>> > >>> On 07/28/2018 08:22 PM,

Re: [Qemu-block] interactive qemu-img

On 07/30/2018 02:54 PM, Nir Soffer wrote: $ qemu-img qemu-img: Not enough arguments Try 'qemu-img --help' for more information This is not user friendly, but unfortunately very common. It can be improved by treating no arguments as --help, like git. I somewhat disagree that git is a good

Re: [Qemu-block] interactive qemu-img

> On Jul 30, 2018, at 3:54 PM, Nir Soffer wrote: > > On Mon, Jul 30, 2018 at 8:00 PM Programmingkid > wrote: > > > On Jul 30, 2018, at 11:09 AM, Eric Blake wrote: > > > > On 07/28/2018 08:22 PM, Programmingkid wrote: > >> I thought of a way to make qemu-img much more user-friendly. When

[Qemu-block] [PATCH] Add interactive mode to qemu-img command

Changes qemu-img so if the user runs it without any arguments, it will walk the user thru making an image file. Signed-off-by: John Arbuckle --- qemu-img.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index

Re: [Qemu-block] [PATCH] Add interactive mode to qemu-img command

> On Jul 30, 2018, at 3:48 PM, Eric Blake wrote: > > On 07/30/2018 02:14 PM, John Arbuckle wrote: >> Changes qemu-img so if the user runs it without any >> arguments, it will walk the user thru making an image >> file. > > Please remember to cc qemu-devel on ALL patches, as suggested by >

Re: [Qemu-block] [Qemu-devel] [PATCH for-3.0 0/7] fix persistent bitmaps migration logic

On 07/30/2018 01:06 PM, Michael Roth wrote: > Quoting John Snow (2018-07-23 17:22:03) >> This is an updated version of Vladimir's proposal for fixing the >> handling around migration and persistent dirty bitmaps. > > Are these still being considered for 3.0 rc3/rc4? 2.12.1 releases this week >

Re: [Qemu-block] [PATCH] Add interactive mode to qemu-img command

On 07/30/2018 02:14 PM, John Arbuckle wrote: Changes qemu-img so if the user runs it without any arguments, it will walk the user thru making an image file. Please remember to cc qemu-devel on ALL patches, as suggested by ./scripts/getmaintainer.pl. Signed-off-by: John Arbuckle ---

Re: [Qemu-block] interactive qemu-img

On Mon, Jul 30, 2018 at 12:30:01PM -0400, Programmingkid wrote: > > > On Jul 30, 2018, at 11:09 AM, Eric Blake wrote: > > > > On 07/28/2018 08:22 PM, Programmingkid wrote: > >> I thought of a way to make qemu-img much more user-friendly. When the user > >> opens qemu-img without any arguments,

Re: [Qemu-block] interactive qemu-img

On Mon, Jul 30, 2018 at 8:00 PM Programmingkid wrote: > > > On Jul 30, 2018, at 11:09 AM, Eric Blake wrote: > > > > On 07/28/2018 08:22 PM, Programmingkid wrote: > >> I thought of a way to make qemu-img much more user-friendly. When the > user opens qemu-img without any arguments, we could

Re: [Qemu-block] [PATCH] Add interactive mode to qemu-img command

> On Jul 30, 2018, at 3:39 PM, Max Reitz wrote: > > On 2018-07-30 21:14, John Arbuckle wrote: >> Changes qemu-img so if the user runs it without any >> arguments, it will walk the user thru making an image >> file. >> >> Signed-off-by: John Arbuckle >> --- >> qemu-img.c | 31

Re: [Qemu-block] interactive qemu-img

> On Jul 30, 2018, at 3:55 PM, Jeff Cody wrote: > > On Mon, Jul 30, 2018 at 12:30:01PM -0400, Programmingkid wrote: >> >>> On Jul 30, 2018, at 11:09 AM, Eric Blake wrote: >>> >>> On 07/28/2018 08:22 PM, Programmingkid wrote: I thought of a way to make qemu-img much more user-friendly.

Re: [Qemu-block] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

On Mon, Jul 30, 2018 at 10:07:27AM -0500, Eric Blake wrote: > On 07/28/2018 02:50 AM, Niels de Vos wrote: > >> > >>Part of me wishes that libgfapi had just created a new function > >>'glfs_ftruncate2', so that existing users don't need to handle the api > >>change. But I guess in the grand

Re: [Qemu-block] [PATCH] Add interactive mode to qemu-img command

On 2018-07-30 21:14, John Arbuckle wrote: > Changes qemu-img so if the user runs it without any > arguments, it will walk the user thru making an image > file. > > Signed-off-by: John Arbuckle > --- > qemu-img.c | 31 +-- > 1 file changed, 29 insertions(+), 2

Re: [Qemu-block] interactive qemu-img

On Mon, Jul 30, 2018 at 11:09 PM Eric Blake wrote: > On 07/30/2018 02:54 PM, Nir Soffer wrote: > > >>> $ qemu-img > >>> qemu-img: Not enough arguments > >>> Try 'qemu-img --help' for more information > > > > > > This is not user friendly, but unfortunately very common. > > It can be improved by

Re: [Qemu-block] interactive qemu-img

> On Jul 30, 2018, at 6:14 PM, Nir Soffer wrote: > > On Mon, Jul 30, 2018 at 11:09 PM Eric Blake wrote: > On 07/30/2018 02:54 PM, Nir Soffer wrote: > > >>> $ qemu-img > >>> qemu-img: Not enough arguments > >>> Try 'qemu-img --help' for more information > > > > > > This is not user

Re: [Qemu-block] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

On Sat, Jul 28, 2018 at 09:50:05AM +0200, Niels de Vos wrote: > On Sat, Jul 28, 2018 at 12:18:39AM -0400, Jeff Cody wrote: > > On Fri, Jul 27, 2018 at 08:24:05AM -0500, Eric Blake wrote: > > > On 07/27/2018 03:19 AM, Niels de Vos wrote: > > > >From: Prasanna Kumar Kalever > > > > > > > >New

[Qemu-block] [PATCH] qemu-img.c: increase spacing between commands in documentation

When the user uses the --help option in qemu-img, the output for the commands is very hard to read due to being so close to each other. With this patch the help for the commands is double spaced making things easier to read. Signed-off-by: John Arbuckle --- qemu-img.c | 2 +- 1 file changed,

[Qemu-block] [PATCH] qemu-img-cmds.hx: Add example usage for create command

Add an example on how to use the create command. I believe this will make qemu-img easier to use. Signed-off-by: John Arbuckle --- qemu-img-cmds.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index 69758fb6e8..92f7437944 100644 ---

Re: [Qemu-block] [PATCH 0/2] Refine some vdi code

Am 30.07.2018 um 04:46 schrieb yuchen...@synology.com: > From: yuchenlin > > This series refine some code in vdi.c, includes: > > * Remvoe CONFIG_VDI_WRITE because there is no reason to leave an always on > and cannot configure option in the code-side. > * decouple if else if chain to get

Re: [Qemu-block] [PATCH 0/2] Refine some vdi code

Hi, Stefan I agree that redundancy of If else may helps people to understand the code. However, CONFIG_VDI_WRITE only contributes: #if defined(CONFIG_VDI_WRITE) .bdrv_co_pwritev = vdi_co_pwritev, #endif I think we don't need CONFIG_VDI_WRITE to document the code. As its name implies,

Re: [Qemu-block] [Qemu-devel] [RFC PATCH] rbd: Don't convert keypairs to JSON and back

Jeff Cody writes: > On Wed, Jul 25, 2018 at 10:56:48AM -0500, Eric Blake wrote: >> On 07/25/2018 10:10 AM, Markus Armbruster wrote: >> >qemu_rbd_parse_filename() builds a keypairs QList, converts it to JSON, and >> >stores the resulting QString in a QDict. >> > >> >qemu_rbd_co_create_opts() and

Re: [Qemu-block] [PATCH 4/6] qcow2: Update total_sectors when resizing the image

Am 29.07.2018 um 23:27 hat Leonid Bloch geschrieben: > Signed-off-by: Leonid Bloch > --- > block/qcow2.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/block/qcow2.c b/block/qcow2.c > index ec9e6238a0..223d351e40 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -3646,6