Re: [Qemu-block] [PATCH] block: record new size in bdrv_dirty_bitmap_truncate

2015-06-09 Thread Kevin Wolf
Am 08.06.2015 um 22:49 hat John Snow geschrieben: ce1ffea8 neglected to update the BdrvDirtyBitmap structure itself for internal consistency. It's currently not an issue, but for migration and persistence series this will cause headaches. Signed-off-by: John Snow js...@redhat.com I know

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix: Fix .bdrv_co_get_block_status() for unaligned image size

2015-06-09 Thread Wen Congyang
On 06/09/2015 04:55 PM, Kevin Wolf wrote: Image files with an unaligned image size have a final hole that starts at EOF, i.e. in the middle of a sector. Currently, *pnum == 0 is returned when checking the status of this sector. In qemu-img, this triggers an assertion failure. In order to

Re: [Qemu-block] [PATCH v2 0/2] block: driver should override flags in bdrv_open()

2015-06-09 Thread Stefan Hajnoczi
On Thu, Mar 19, 2015 at 6:53 PM, Max Reitz mre...@redhat.com wrote: BDRV_O_PROTOCOL is an internal qemu flag which a user should be able to override by explicitly specifying a block driver. This series implements this and adds two iotests (one for NBD, one for file) to test it. v2 (rebase on

Re: [Qemu-block] [PATCH v2 0/2] block: driver should override flags in bdrv_open()

2015-06-09 Thread Kevin Wolf
Am 09.06.2015 um 10:41 hat Stefan Hajnoczi geschrieben: On Thu, Mar 19, 2015 at 6:53 PM, Max Reitz mre...@redhat.com wrote: BDRV_O_PROTOCOL is an internal qemu flag which a user should be able to override by explicitly specifying a block driver. This series implements this and adds two

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix: Fix .bdrv_co_get_block_status() for unaligned image size

2015-06-09 Thread Eric Blake
On 06/09/2015 02:55 AM, Kevin Wolf wrote: Image files with an unaligned image size have a final hole that starts at EOF, i.e. in the middle of a sector. Currently, *pnum == 0 is returned when checking the status of this sector. In qemu-img, this triggers an assertion failure. In order to

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block: driver should override flags in bdrv_open()

2015-06-09 Thread Eric Blake
On 06/09/2015 04:19 AM, Stefan Hajnoczi wrote: On Tue, Jun 09, 2015 at 10:59:42AM +0200, Kevin Wolf wrote: Am 09.06.2015 um 10:41 hat Stefan Hajnoczi geschrieben: On Thu, Mar 19, 2015 at 6:53 PM, Max Reitz mre...@redhat.com wrote: BDRV_O_PROTOCOL is an internal qemu flag which a user should be

Re: [Qemu-block] [PATCH v2 0/2] block: driver should override flags in bdrv_open()

2015-06-09 Thread Kevin Wolf
Am 09.06.2015 um 12:19 hat Stefan Hajnoczi geschrieben: On Tue, Jun 09, 2015 at 10:59:42AM +0200, Kevin Wolf wrote: Am 09.06.2015 um 10:41 hat Stefan Hajnoczi geschrieben: Please resend and CC Kevin (for qemu-iotests and block.c). It's only you who dropped me from CC. :-) For sanity,

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix: Fix .bdrv_co_get_block_status() for unaligned image size

2015-06-09 Thread Cole Robinson
On 06/09/2015 04:55 AM, Kevin Wolf wrote: Image files with an unaligned image size have a final hole that starts at EOF, i.e. in the middle of a sector. Currently, *pnum == 0 is returned when checking the status of this sector. In qemu-img, this triggers an assertion failure. In order to

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block: driver should override flags in bdrv_open()

2015-06-09 Thread Stefan Hajnoczi
On Tue, Jun 9, 2015 at 12:49 PM, Eric Blake ebl...@redhat.com wrote: On 06/09/2015 04:19 AM, Stefan Hajnoczi wrote: On Tue, Jun 09, 2015 at 10:59:42AM +0200, Kevin Wolf wrote: Am 09.06.2015 um 10:41 hat Stefan Hajnoczi geschrieben: On Thu, Mar 19, 2015 at 6:53 PM, Max Reitz mre...@redhat.com

Re: [Qemu-block] [PATCH] raw-posix: Fix .bdrv_co_get_block_status() for unaligned image size

2015-06-09 Thread Stefan Hajnoczi
On Tue, Jun 09, 2015 at 10:55:08AM +0200, Kevin Wolf wrote: Image files with an unaligned image size have a final hole that starts at EOF, i.e. in the middle of a sector. Currently, *pnum == 0 is returned when checking the status of this sector. In qemu-img, this triggers an assertion failure.

Re: [Qemu-block] [Qemu-devel] [PATCH] block: record new size in bdrv_dirty_bitmap_truncate

2015-06-09 Thread John Snow
On 06/09/2015 05:24 AM, Kevin Wolf wrote: Am 08.06.2015 um 22:49 hat John Snow geschrieben: ce1ffea8 neglected to update the BdrvDirtyBitmap structure itself for internal consistency. It's currently not an issue, but for migration and persistence series this will cause headaches.

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block: driver should override flags in bdrv_open()

2015-06-09 Thread Eric Blake
On 06/09/2015 08:48 AM, Stefan Hajnoczi wrote: I guess my @redhat.com email was received directly from Max because I was in CC list. It didn't pass through Mailman. I saw the original, unmodified list of CCs with Kevin included. The @gmail.com email was received from the mailing list.

Re: [Qemu-block] [Qemu-devel] [PATCH v3 23/38] blockdev: Pull out blockdev option extraction

2015-06-09 Thread Max Reitz
On 09.06.2015 02:37, Fam Zheng wrote: On Wed, 06/03 21:44, Max Reitz wrote: Extract some of the blockdev option extraction code from blockdev_init() into its own function. This simplifies blockdev_init() and will allow reusing the code in a different function added in a follow-up patch.

[Qemu-block] [PATCH v2 2/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

2015-06-09 Thread Peter Maydell
If a user requests an IF_VIRTIO drive on the command line, don't create the implicit PCI virtio device immediately, but wait until the rest of the command line has been processed and only create the device if the drive would otherwise be orphaned. This means that if the user said

Re: [Qemu-block] [Qemu-devel] [PATCH] block: allow write-threshold on device name

2015-06-09 Thread Eric Blake
On 06/06/2015 07:38 PM, Eric Blake wrote: Commit e2462113 allowed the ability to fire an event if a BDS node exceeds a threshold during a write, but limited the option to only work on node names. For convenience, expand this to allow a device name as a way to set the threshold on the BDS at