[Qemu-block] [PATCH] blockdev: fix missed target unref for drive-backup

If the bitmap can't be used for whatever reason, we skip putting down the reference. Fix that. In practice, this means that if you attempt to gracefully exit QEMU after a backup command being rejected, bdrv_close_all will fail and tell you some unpleasant things via assert(). Reported-by: aihua

Re: [Qemu-block] [PATCH] iotests: Filter 175's allocation information

On Sat, May 11, 2019 at 12:19 AM Max Reitz wrote: > It is possible for an empty file to take up blocks on a filesystem. > Make iotest 175 take this into account. > > Reported-by: Thomas Huth > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/175 | 15 +++ >

[Qemu-block] [PATCH] iotests: Filter 175's allocation information

It is possible for an empty file to take up blocks on a filesystem. Make iotest 175 take this into account. Reported-by: Thomas Huth Signed-off-by: Max Reitz --- tests/qemu-iotests/175 | 15 +++ tests/qemu-iotests/175.out | 8 2 files changed, 15 insertions(+), 8

Re: [Qemu-block] Failing QEMU iotest 175

On Sat, May 4, 2019 at 12:32 AM Nir Soffer wrote: > > > On Fri, May 3, 2019, 23:21 Eric Blake wrote: > >> ... >> >>> == creating image with preallocation off == >> >>> Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576 >> preallocation=off >> >>> -size=1048576, blocks=0 >> >>>

[Qemu-block] [PATCH] block/file-posix: Truncate in xfs_write_zeroes()

XFS_IOC_ZERO_RANGE does not increase the file length: $ touch foo $ xfs_io -c 'zero 0 65536' foo $ stat -c "size=%s, blocks=%b" foo size=0, blocks=128 We do want writes beyond the EOF to automatically increase the file length, however. This is evidenced by the fact that iotest 061 is broken on

[Qemu-block] [PATCH] blockdev: loosen restrictions on drive-backup source node

We mandate that the source node must be a root node; but there's no reason I am aware of that it needs to be restricted to such. In some cases, we need to make sure that there's a medium present, but in the general case we can allow the backup job itself to do the graph checking. This patch helps

[Qemu-block] [PATCH v2 1/4] blockdev-backup: don't check aio_context too early

in blockdev_backup_prepare, we check to make sure that the target is associated with a compatible aio context. However, do_blockdev_backup is called later and has some logic to move the target to a compatible aio_context. The transaction version will fail certain commands needlessly early as a

[Qemu-block] [PATCH v2 4/4] iotests: add iotest 250 for testing blockdev-backup across iothread contexts

Signed-off-by: John Snow --- tests/qemu-iotests/250 | 129 + tests/qemu-iotests/250.out | 119 ++ tests/qemu-iotests/group | 1 + 3 files changed, 249 insertions(+) create mode 100755 tests/qemu-iotests/250 create mode

[Qemu-block] [PATCH v2 2/4] iotests.py: do not use infinite waits

Cap waits to 60 seconds so that iotests can fail gracefully if something goes wrong. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index

[Qemu-block] [PATCH v2 3/4] iotests.py: rewrite run_job to be pickier

Don't pull events out of the queue that don't belong to us; be choosier so that we can use this method to drive jobs that were launched by transactions that may have more jobs. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 32 +++- 1 file changed, 15

[Qemu-block] [PATCH v2 0/4] blockdev-backup: don't check aio_context too early

See patch one's commit message for justification. v2: added patch 4, with iotest framework adjustments in patches 2/3. John Snow (4): blockdev-backup: don't check aio_context too early iotests.py: do not use infinite waits iotests.py: rewrite run_job to be pickier iotests: add iotest 250

Re: [Qemu-block] Failing QEMU iotest 175

On 10.05.19 18:42, Thomas Huth wrote: > On 10/05/2019 15.54, Max Reitz wrote: >> On 28.04.19 17:18, Thomas Huth wrote: >>> QEMU iotest 175 is failing for me when I run it with -raw: >>> >>> $ ./check -raw 175 >>> QEMU -- >>>

Re: [Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make check" again

On 10.05.19 18:20, Thomas Huth wrote: > On 10/05/2019 15.47, Max Reitz wrote: >> On 10.05.19 15:36, Thomas Huth wrote: >>> On 10/05/2019 15.34, Max Reitz wrote: On 10.05.19 06:29, Thomas Huth wrote: > On 09/05/2019 20.08, Max Reitz wrote: >> On 02.05.19 10:45, Thomas Huth wrote:

[Qemu-block] [PATCH] qcow2: Define and use QCOW2_COMPRESSED_SECTOR_SIZE

When an L2 table entry points to a compressed cluster the space used by the data is specified in 512-byte sectors. This size is independent from BDRV_SECTOR_SIZE and is specific to the qcow2 file format. The QCOW2_COMPRESSED_SECTOR_SIZE constant defined in this patch makes this explicit.

Re: [Qemu-block] Failing QEMU iotest 175

On 10/05/2019 15.54, Max Reitz wrote: > On 28.04.19 17:18, Thomas Huth wrote: >> QEMU iotest 175 is failing for me when I run it with -raw: >> >> $ ./check -raw 175 >> QEMU -- >> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" >> -nodefaults

Re: [Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make check" again

On 10/05/2019 15.47, Max Reitz wrote: > On 10.05.19 15:36, Thomas Huth wrote: >> On 10/05/2019 15.34, Max Reitz wrote: >>> On 10.05.19 06:29, Thomas Huth wrote: On 09/05/2019 20.08, Max Reitz wrote: > On 02.05.19 10:45, Thomas Huth wrote: >> People often forget to run the iotests

[Qemu-block] [PULL 11/15] block: Remove bdrv_read() and bdrv_write()

From: Alberto Garcia No one is using these functions anymore, all callers have switched to the byte-based bdrv_pread() and bdrv_pwrite() Signed-off-by: Alberto Garcia Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Kevin Wolf --- include/block/block.h | 4 block/io.c

[Qemu-block] [PULL 15/15] iotests: Add test for rebase without input base

From: Max Reitz This patch adds a test for rebasing an image that currently does not have a backing file. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/qemu-iotests/252 | 124 + tests/qemu-iotests/252.out | 39

[Qemu-block] [PULL 13/15] qemu-img: Allow rebase with no input base

From: Max Reitz Currently, without -u, you cannot add a backing file to an image when it currently has none: $ qemu-img rebase -b base.qcow2 foo.qcow2 qemu-img: Could not open old backing file '': The 'file' block driver requires a file name It is really simple to allow this, though

[Qemu-block] [PULL 14/15] qemu-img: Use zero writes after source backing EOF

From: Max Reitz Past the end of the source backing file, we memset() buf_old to zero, so it is clearly easy to use blk_pwrite_zeroes() instead of blk_pwrite() then. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- qemu-img.c | 11 +-- 1 file changed, 9

[Qemu-block] [PULL 06/15] test-block-iothread: Job coroutine thread after AioContext switch

This tests that a job coroutine always runs in the right iothread after the AioContext of its main node has changed. Signed-off-by: Kevin Wolf --- tests/test-block-iothread.c | 107 1 file changed, 107 insertions(+) diff --git a/tests/test-block-iothread.c

[Qemu-block] [PULL 12/15] qcow2: Remove BDRVQcow2State.cluster_sectors

From: Alberto Garcia The last user of this field disappeared when we replace the sector-based bdrv_write() with the byte-based bdrv_pwrite(). Signed-off-by: Alberto Garcia Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Kevin Wolf --- block/qcow2.h | 1 - block/qcow2.c | 1 - 2

[Qemu-block] [PULL 10/15] vvfat: Replace bdrv_{read, write}() with bdrv_{pread, pwrite}()

From: Alberto Garcia There's only a couple of bdrv_read() and bdrv_write() calls left in the vvfat code, and they can be trivially replaced with the byte-based bdrv_pread() and bdrv_pwrite(). Signed-off-by: Alberto Garcia Signed-off-by: Kevin Wolf --- block/vvfat.c | 12 +++- 1 file

[Qemu-block] [PULL 09/15] vdi: Replace bdrv_{read, write}() with bdrv_{pread, pwrite}()

From: Alberto Garcia There's only a couple of bdrv_read() and bdrv_write() calls left in the vdi code, and they can be trivially replaced with the byte-based bdrv_pread() and bdrv_pwrite(). Signed-off-by: Alberto Garcia Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Kevin Wolf ---

[Qemu-block] [PULL 07/15] qemu-img: Use IEC binary prefixes for size constants

From: Stefano Garzarella Using IEC binary prefixes in order to make the code more readable. Signed-off-by: Stefano Garzarella Signed-off-by: Kevin Wolf --- qemu-img.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index e6ad5978e0..71c92f142a

[Qemu-block] [PULL 02/15] MAINTAINERS: Downgrade status of block sections without "M:" to "Odd Fixes"

From: Thomas Huth Fixes might still get picked up via the qemu-block mailing list, so the status is not "Orphan" yet. Also add the gluster mailing list as suggested by Niels here: https://patchwork.kernel.org/patch/10613297/#22409943 Signed-off-by: Thomas Huth Reviewed-by: Philippe

[Qemu-block] [PULL 04/15] qemu-iotests: Fix cleanup for 192

Test case 192 calls _launch_qemu, so it also needs to _cleanup_qemu when it's done, otherwise the QMP FIFOs stay around in scratch/. It also creates a temporary NBD socket that needs to be removed as well at the end of the test case. Reported-by: Thomas Huth Signed-off-by: Kevin Wolf

[Qemu-block] [PULL 03/15] MAINTAINERS: Add an entry for the Parallel NOR Flash devices

From: Philippe Mathieu-Daudé Step in to maintain it, since I have some familiarity with the technology. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Laszlo Ersek Acked-by: Michael S. Tsirkin Reviewed-by: Thomas Huth Signed-off-by: Kevin Wolf --- MAINTAINERS | 7 +++ 1 file changed,

[Qemu-block] [PULL 08/15] qcow2: Replace bdrv_write() with bdrv_pwrite()

From: Alberto Garcia There's only one bdrv_write() call left in the qcow2 code, and it can be trivially replaced with the byte-based bdrv_pwrite(). Signed-off-by: Alberto Garcia Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 4 ++-- 1 file

[Qemu-block] [PULL 05/15] blockjob: Fix coroutine thread after AioContext change

Commit 463e0be10 ('blockjob: add AioContext attached callback') tried to make block jobs robust against AioContext changes of their main node, but it never made sure that the job coroutine actually runs in the new thread. Instead of waking up the job coroutine in whatever thread it ran before,

[Qemu-block] [PULL 01/15] block: remove bs from lists before closing

From: Anton Kuchin Close involves flush that can be performed asynchronously and bs must be protected from being referenced before it is deleted. Signed-off-by: Anton Kuchin Signed-off-by: Kevin Wolf --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c

[Qemu-block] [PULL 00/15] Block layer patches

The following changes since commit efb4f3b62c69383a7308d7b739a3193e7c0ccae8: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-05-10 14:49:36 +0100) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you

Re: [Qemu-block] [Qemu-devel] [PATCH v3 6/7] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run

Am 10.05.2019 um 17:29 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 10.05.2019 um 10:55 hat Thomas Huth geschrieben: > >> On 08/05/2019 07.47, Thomas Huth wrote: > >> > On 07/05/2019 17.50, Eric Blake wrote: > >> >> On 5/7/19 10:22 AM, Thomas Huth wrote: > >> >>> On

[Qemu-block] [PATCH v2] block/rbd: implement .bdrv_get_allocated_file_size callback

This patch allows 'qemu-img info' to show the 'disk size' for the RBD images that have the fast-diff feature enabled. If this feature is enabled, we use the rbd_diff_iterate2() API to calculate the allocated size for the image. Signed-off-by: Stefano Garzarella --- v2: - calculate the actual

Re: [Qemu-block] [Qemu-devel] [PATCH v3 6/7] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run

Kevin Wolf writes: > Am 10.05.2019 um 10:55 hat Thomas Huth geschrieben: >> On 08/05/2019 07.47, Thomas Huth wrote: >> > On 07/05/2019 17.50, Eric Blake wrote: >> >> On 5/7/19 10:22 AM, Thomas Huth wrote: >> >>> On 07/05/2019 15.22, Markus Armbruster wrote: >> Thomas Huth writes: >>

[Qemu-block] [PATCH] nbd/server: Nicer spelling of max BLOCK_STATUS reply length

Commit 3d068aff (3.0) introduced NBD_MAX_BITMAP_EXTENTS as a limit on how large we would allow a reply to NBD_CMD_BLOCK_STATUS to grow when it is visiting a qemu:dirty-bitmap: context. Later, commit fb7afc79 (3.1) reused the constant to limit base:allocation context replies, although the name is

Re: [Qemu-block] [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

Xiang Zheng writes: > On 2019/5/9 19:59, Markus Armbruster wrote: >> Xiang Zheng writes: >> >>> On 2019/5/8 21:20, Markus Armbruster wrote: Laszlo Ersek writes: > Hi Markus, > > On 05/07/19 20:01, Markus Armbruster wrote: >> The subject is slightly misleading. Holes

Re: [Qemu-block] [PULL 0/8] Block patches

On Fri, 10 May 2019 at 14:02, Stefan Hajnoczi wrote: > > The following changes since commit 812b835fb4d23dd108b2f9802158472d50b73579: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-05-07' > into staging (2019-05-09 16:31:12 +0100) > > are available in the Git

Re: [Qemu-block] [Qemu-devel] [PATCH v3 6/7] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run

Am 10.05.2019 um 10:55 hat Thomas Huth geschrieben: > On 08/05/2019 07.47, Thomas Huth wrote: > > On 07/05/2019 17.50, Eric Blake wrote: > >> On 5/7/19 10:22 AM, Thomas Huth wrote: > >>> On 07/05/2019 15.22, Markus Armbruster wrote: > Thomas Huth writes: > > > Currently, all tests

Re: [Qemu-block] [PATCH v3] tests/qemu-iotests: re-format output to for make check-block

Am 10.05.2019 um 12:29 hat Alex Bennée geschrieben: > This attempts to clean-up the output to better match the output of the > rest of the QEMU check system when called with -pretty. This includes: > > - formatting as " TESTiotest: nnn" > - calculating time diff at the end > - only

[Qemu-block] [PATCH v4] tests/qemu-iotests: re-format output to for make check-block

This attempts to clean-up the output to better match the output of the rest of the QEMU check system when called with -pretty. This includes: - formatting as " TESTiotest: nnn" - calculating time diff at the end - only dumping config on failure (when -pretty enabled) The existing

Re: [Qemu-block] Failing QEMU iotest 175

On 28.04.19 17:18, Thomas Huth wrote: > QEMU iotest 175 is failing for me when I run it with -raw: > > $ ./check -raw 175 > QEMU -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" > -nodefaults -machine accel=qtest > QEMU_IMG -- >

Re: [Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make check" again

On 10.05.19 15:36, Thomas Huth wrote: > On 10/05/2019 15.34, Max Reitz wrote: >> On 10.05.19 06:29, Thomas Huth wrote: >>> On 09/05/2019 20.08, Max Reitz wrote: On 02.05.19 10:45, Thomas Huth wrote: > People often forget to run the iotests before submitting patches or > pull requests

Re: [Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make check" again

On 10/05/2019 15.34, Max Reitz wrote: > On 10.05.19 06:29, Thomas Huth wrote: >> On 09/05/2019 20.08, Max Reitz wrote: >>> On 02.05.19 10:45, Thomas Huth wrote: People often forget to run the iotests before submitting patches or pull requests - this is likely due to the fact that we do

Re: [Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make check" again

On 10.05.19 06:29, Thomas Huth wrote: > On 09/05/2019 20.08, Max Reitz wrote: >> On 02.05.19 10:45, Thomas Huth wrote: >>> People often forget to run the iotests before submitting patches or >>> pull requests - this is likely due to the fact that we do not run the >>> tests during our mandatory

Re: [Qemu-block] [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

On 2019/5/9 19:59, Markus Armbruster wrote: > Xiang Zheng writes: > >> On 2019/5/8 21:20, Markus Armbruster wrote: >>> Laszlo Ersek writes: >>> Hi Markus, On 05/07/19 20:01, Markus Armbruster wrote: > The subject is slightly misleading. Holes read as zero. So do >

[Qemu-block] [PULL 8/8] docs: add Security chapter to the documentation

This new chapter in the QEMU documentation covers the security requirements that QEMU is designed to meet and principles for securely deploying QEMU. It is just a starting point that can be extended in the future with more information. Signed-off-by: Stefan Hajnoczi Acked-by: Stefano Garzarella

[Qemu-block] [PULL 6/8] aio-posix: ensure poll mode is left when aio_notify is called

From: Paolo Bonzini With aio=thread, adaptive polling makes latency worse rather than better, because it delays the execution of the ThreadPool's completion bottom half. event_notifier_poll() does run while polling, detecting that a bottom half was scheduled by a worker thread, but because

[Qemu-block] [PULL 3/8] util/readline: Add braces to fix checkpatch errors

From: Jules Irenge Add braces to fix errors issued by checkpatch.pl tool "ERROR: braces {} are necessary for all arms of this statement" Within "util/readline.c" file Message-Id: <20190330112142.14082-1-jbi.oct...@gmail.com> Signed-off-by: Stefan Hajnoczi --- util/readline.c | 50

[Qemu-block] [PULL 2/8] util: readline: replace tab indent by four spaces to fix checkpatch errors

From: Jules Irenge Replace tab indent by four spaces to fix errors issued by checkpatch.pl tool "ERROR: code indent should never use tabs" within "util/readline.c" file. Signed-off-by: Jules Irenge Reviewed-by: Thomas Huth Message-id: 20190401024406.10819-3-jbi.oct...@gmail.com Message-Id:

[Qemu-block] [PULL 7/8] docs: add Secure Coding Practices to developer docs

At KVM Forum 2018 I gave a presentation on security in QEMU: https://www.youtube.com/watch?v=YAdRf_hwxU8 (video) https://vmsplice.net/~stefan/stefanha-kvm-forum-2018.pdf (slides) This patch adds a guide to secure coding practices. This document covers things that developers should know about

[Qemu-block] [PULL 5/8] block/io.c: fix for the allocation failure

From: Andrey Shinkevich On a file system used by the customer, fallocate() returns an error if the block is not properly aligned. So, bdrv_co_pwrite_zeroes() fails. We can handle that case the same way as it is done for the unsupported cases, namely, call to bdrv_driver_pwritev() that writes

[Qemu-block] [PULL 4/8] block: Add coroutine_fn to bdrv_check_co_entry

From: Nikita Alekseev bdrv_check_co_entry calls bdrv_co_check, which is a coroutine function. Thus, it also needs to be marked as a coroutine. Signed-off-by: Nikita Alekseev Message-id: 20190401093051.16488-1-n.alekseev2...@gmail.com Message-Id:

[Qemu-block] [PULL 0/8] Block patches

The following changes since commit 812b835fb4d23dd108b2f9802158472d50b73579: Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-05-07' into staging (2019-05-09 16:31:12 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git

[Qemu-block] [PULL 1/8] util/readline: add a space to fix errors by checkpatch tool

From: Jules Irenge util/readline: add a space to fix errors reported by checkpatch.pl tool "ERROR: space required before the open parenthesis" "ERROR: space required after that ..." within "util/redline.c" file Signed-off-by: Jules Irenge Reviewed-by: Thomas Huth Message-id:

Re: [Qemu-block] [Qemu-devel] [PATCH v3] tests/qemu-iotests: re-format output to for make check-block

Thomas Huth writes: > On 10/05/2019 12.48, Thomas Huth wrote: > [...] >> >> I think the "make check" mode should only print out one time for each >> test, preferable at the end, like the other tests (like qtests) are >> doing it...? > > s/preferable at the end/preferably at the beginning/ > >

Re: [Qemu-block] [Qemu-devel] [PATCH v3 6/7] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run

Thomas Huth writes: > Thinking about this again, "make check" now runs quite a bit longer > indeed. So I now rather tend to remove the tests that run longer than 5s > from the auto group instead... I think I'll send a v4 of this patch > where I'll remove them from the auto group. Appreciated!

Re: [Qemu-block] [Qemu-devel] [PATCH v3] tests/qemu-iotests: re-format output to for make check-block

On 10/05/2019 12.48, Thomas Huth wrote: [...] > > I think the "make check" mode should only print out one time for each > test, preferable at the end, like the other tests (like qtests) are > doing it...? s/preferable at the end/preferably at the beginning/ ... I think the makefile rules for

Re: [Qemu-block] [Qemu-devel] [PATCH v3] tests/qemu-iotests: re-format output to for make check-block

On 10/05/2019 13.10, Alex Bennée wrote: > > Thomas Huth writes: > >> On 10/05/2019 12.29, Alex Bennée wrote: >>> This attempts to clean-up the output to better match the output of the >>> rest of the QEMU check system when called with -pretty. This includes: >>> >>> - formatting as " TEST

Re: [Qemu-block] [PATCH v3] tests/qemu-iotests: re-format output to for make check-block

Thomas Huth writes: > On 10/05/2019 12.29, Alex Bennée wrote: >> This attempts to clean-up the output to better match the output of the >> rest of the QEMU check system when called with -pretty. This includes: >> >> - formatting as " TESTiotest: nnn" >> - calculating time diff at the

Re: [Qemu-block] [PATCH v3] tests/qemu-iotests: re-format output to for make check-block

On 10/05/2019 12.29, Alex Bennée wrote: > This attempts to clean-up the output to better match the output of the > rest of the QEMU check system when called with -pretty. This includes: > > - formatting as " TESTiotest: nnn" > - calculating time diff at the end > - only dumping config

Re: [Qemu-block] [PATCH] tests: qpci_unplug_acpi_device_test() should not rely on global_qtest

On Wed, May 08, 2019 at 04:32:09PM +0200, Thomas Huth wrote: > libqos functions should not use functions that require global_qtest to > be set, since such library functions could also be used by tests that > deal with multiple test states. Add a parameter to this function to > explicitly specify

[Qemu-block] [PATCH v3] tests/qemu-iotests: re-format output to for make check-block

This attempts to clean-up the output to better match the output of the rest of the QEMU check system when called with -pretty. This includes: - formatting as " TESTiotest: nnn" - calculating time diff at the end - only dumping config on failure (when -pretty enabled) The existing

Re: [Qemu-block] [PATCH v3 0/3] qemu-img: Allow rebase with no input base

Am 09.05.2019 um 19:52 hat Max Reitz geschrieben: > This series allows using qemu-img rebase (without -u) on images that do > not have a backing file. Right now, this fails with the rather cryptic > error message: > > $ qemu-img rebase -b base.qcow2 foo.qcow2 > qemu-img: Could not open old

[Qemu-block] [PATCH v4] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run

Currently, all tests are in the "auto" group. This is a little bit pointless. OTOH, we need a group for the tests that we can automatically run during "make check" each time, too. Tests in this new group are supposed to run with every possible QEMU configuration, for example they must run with

Re: [Qemu-block] [Qemu-devel] [PATCH v3 6/7] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run

On 08/05/2019 07.47, Thomas Huth wrote: > On 07/05/2019 17.50, Eric Blake wrote: >> On 5/7/19 10:22 AM, Thomas Huth wrote: >>> On 07/05/2019 15.22, Markus Armbruster wrote: Thomas Huth writes: > Currently, all tests are in the "auto" group. This is a little bit > pointless.

Re: [Qemu-block] [Qemu-devel] Use of PreallocMode in block drivers

On Thu, May 09, 2019 at 02:07:34PM +0200, Markus Armbruster wrote: > Stefano Garzarella writes: > > > On Wed, May 08, 2019 at 01:44:27PM +0200, Markus Armbruster wrote: > >> Stefano Garzarella writes: > >> > >> > On Tue, May 07, 2019 at 08:34:51AM +0200, Markus Armbruster wrote: > >> >> Cc: