> as separate disks again.
>
> Signed-off-by: Kevin Wolf
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/scsi/scsi-disk.c | 14 --
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index 0e9027c8f
On 4/11/19 3:56 PM, Markus Armbruster wrote:
> The ARM virt machines put firmware in flash memory. To configure it,
> you use -drive if=pflash,unit=0,... and optionally -drive
> if=pflash,unit=1,...
>
> Why two -drive? This permits setting up one part of the flash memory
> read-only, and the
t;drive",
> +blk_by_legacy_dinfo(pflash_drv), _fatal);
> loc_pop();
> }
>
> +for (i = 0; i < ARRAY_SIZE(pcms->flash); i++) {
> +pflash_blk[i] = blk_by_legacy_dinfo(pflash_drv);
> +}
> +
> /* Reject gaps */
> for (i = 1; i < ARRAY_SIZE(pcms->flash); i++) {
> if (pflash_blk[i] && !pflash_blk[i - 1]) {
> -- 2.17.2
Works for me! Reviewed-by: Philippe Mathieu-Daudé
80,18 +278,8 @@ void pc_system_firmware_init(PCMachineState *pcms,
>
> /* Map legacy -drive if=pflash to machine properties */
> for (i = 0; i < ARRAY_SIZE(pcms->flash); i++) {
> -pflash_drv = drive_get(IF_PFLASH, 0, i);
> -if (pflash_drv) {
> -lo
th -machine");
> -exit(1);
> -}
> -pflash_blk[i] = blk_by_legacy_dinfo(pflash_drv);
> -qdev_prop_set_drive(DEVICE(pcms->flash[i]),
> - "drive", pflash_blk[i], _fatal);
> -loc_pop();
> +pflash_blk[i] = pflash_cfi01_get_blk(pcms->flash[i]);
> }
>
> /* Reject gaps */
>
Reviewed-by: Philippe Mathieu-Daudé
by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/mips/mips_malta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
> index 4dfe06a1a0..2f20f56458 100644
> --- a/hw/mips/mips_malta.c
> ++
On 6/7/19 12:08 PM, Daniel P. Berrangé wrote:
> On Thu, Jun 06, 2019 at 07:51:15PM +0200, Pino Toscano wrote:
>> On Thursday, 6 June 2019 13:12:32 CEST Daniel P. Berrangé wrote:
>>> On Wed, Jun 05, 2019 at 11:36:54PM +0200, Pino Toscano wrote:
Rewrite the implementation of the ssh block
On 6/13/19 8:18 PM, Paolo Bonzini wrote:
> On 13/06/19 19:15, Philippe Mathieu-Daudé wrote:
>>
>> On 6/13/19 6:24 PM, no-re...@patchew.org wrote:
>>> === TEST SCRIPT BEGIN ===
>>> #!/bin/bash
>>> time make docker-test-debug@fedora TARGET_LIST=x86_64-soft
On 6/14/19 4:30 PM, Peter Maydell wrote:
> On Fri, 14 Jun 2019 at 14:58, Alex Bennée wrote:
>
>> It would be nice to have a --static-user config flag and deprecate the
>> --static flag. I don't think there is a decent use case for system
>> emulation targets.
>
> It would be really tricky to
e testing is dropped for now, as there
>> are no packages for it.
>>
>> Signed-off-by: Pino Toscano
>> Tested-by: Philippe Mathieu-Daudé
>> Acked-by: Alex Bennée
>> ---
>
> Can confirm that this runs much faster than the last version I tested.
> 197 an
On 6/14/19 4:34 PM, Max Reitz wrote:
> On 14.06.19 16:29, Pino Toscano wrote:
>> On Thursday, 13 June 2019 21:31:40 CEST Max Reitz wrote:
>>> On 13.06.19 15:20, Pino Toscano wrote:
[...]
-case LIBSSH2_KNOWNHOST_CHECK_NOTFOUND:
+case SSH_KNOWN_HOSTS_OTHER:
ret =
On 6/14/19 4:30 PM, Max Reitz wrote:
> On 14.06.19 16:26, Philippe Mathieu-Daudé wrote:
>> On 6/13/19 9:31 PM, Max Reitz wrote:
>>> On 13.06.19 15:20, Pino Toscano wrote:
>>>> Rewrite the implementation of the ssh block driver to use libssh instead
>>>> o
On 6/14/19 2:29 PM, Stefan Weil wrote:
> On 14.06.19 12:13, Philippe Mathieu-Daudé wrote:
>> I agree with Kevin. The only user of the 'ssh' block driver that I am
>> aware of is the virt-v2v tool:
>>
>> http://libguestfs.org/virt-v2v.1.html#convert-from-esxi-hyperviso
Hi Stephen,
This series haven't fall through the cracks, however it is taking me
longer than expected to review it.
On 4/26/19 6:26 PM, Stephen Checkoway wrote:
> It's common for multiple narrow flash chips to be hooked up in parallel
> to support wider buses. For example, four 8-bit wide flash
On 6/22/19 2:25 PM, Philippe Mathieu-Daudé wrote:
> Hi Stephen,
>
> This series haven't fall through the cracks, however it is taking me
> longer than expected to review it.
>
> On 4/26/19 6:26 PM, Stephen Checkoway wrote:
>> It's common for multiple narrow fla
big-endian bus.
>>
>> Signed-off-by: Laurent Vivier
>> Tested-by: Hervé Poussineau
>> Reviewed-by: Philippe Mathieu-Daudé
>> Reviewed-by: Hervé Poussineau
>> ---
>> hw/net/dp8393x.c | 88 +++-
>> 1 f
Hi Pino,
Please Cc the different maintainers (doing that for you).
On 6/13/19 8:11 AM, Pino Toscano wrote:
> Rewrite the implementation of the ssh block driver to use libssh instead
> of libssh2. The libssh library has various advantages over libssh2:
> - easier API for authentication (for
Cc'ing Alex (Docker, Travis) and Stefan (MinGW)
On 6/5/19 11:36 PM, Pino Toscano wrote:
> Rewrite the implementation of the ssh block driver to use libssh instead
> of libssh2. The libssh library has various advantages over libssh2:
> - easier API for authentication (for example for using
ed25519) that are used by default with OpenSSH >= 6.7
> and libssh >= 0.7.0.
>
> Adjust the various Docker/Travis scripts to use libssh when available
> instead of libssh2. The mingw/mxe testing is dropped for now, as there
> are no packages for it.
>
> Signed-off-by
On 6/13/19 6:24 PM, no-re...@patchew.org wrote:
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
> === TEST SCRIPT END ===
> The full log is available at
>
Hi Pino,
On 6/12/19 4:48 PM, Pino Toscano wrote:
> Rewrite the implementation of the ssh block driver to use libssh instead
> of libssh2. The libssh library has various advantages over libssh2:
> - easier API for authentication (for example for using ssh-agent)
> - easier API for known_hosts
On 6/14/19 9:24 AM, Philippe Mathieu-Daudé wrote:
> Similarly to commit a73e82ef912, test the libraries link correctly
> before considering them as usable.
>
> This fixes using ./configure --static on Ubuntu 18.04:
>
> $ make subdir-aarch64-softmmu
> [...]
> LINK
On 6/14/19 9:24 AM, Philippe Mathieu-Daudé wrote:
> Hi,
>
> Apparently QEMU static linking is slowly bitroting. Obviously it
> depends the libraries an user has installed, anyway it seems there
> are not much testing done.
>
> This series fixes few issues, enough to b
> Signed-off-by: Pino Toscano
> Tested-by: Philippe Mathieu-Daudé
> Acked-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
> ---
>
> Changes from v10:
> - improve error message for key mismatch
> - integrate Max Reitz' fix to iotest 207 to detect the key type used by
g and this model slowly becomes another
Frankenstein. The SCC core is a monster anyway.
I'm glad you could resolve your issue with this easy fix.
> Signed-off-by: Laurent Vivier
> Reviewed-by: Hervé Poussineau
> Reviewed-by: Thomas Huth
Reviewed-by: Philippe Math
Hi Kenneth,
On 4/5/19 11:41 PM, Kenneth Heitke wrote:
> Signed-off-by: Kenneth Heitke
> ---
> hw/block/nvme.c | 120 +-
> hw/block/nvme.h | 3 ++
> hw/block/trace-events | 2 +
> include/block/nvme.h | 2 +
> 4 files changed, 125
t instead.
>
> Signed-off-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
> ---
> tests/qemu-iotests/check | 13 -
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> index f9c24b6753
On 4/28/19 5:54 PM, Thomas Huth wrote:
> We are going to enable the qemu-iotests during "make check" again,
> and for running the iotests, we need bash and gnu-sed.
>
> Signed-off-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
> ---
> .cirrus.yml | 4 ++--
>
On 4/29/19 6:02 PM, Thomas Huth wrote:
> On 29/04/2019 17.53, Peter Maydell wrote:
>> On Mon, 29 Apr 2019 at 16:34, Thomas Huth wrote:
>>>
>>> On 25/04/2019 17.53, Philippe Mathieu-Daudé wrote:
>>>> Hi Thomas,
>>>>
>>>> On 4
On 4/29/19 9:25 PM, Thomas Huth wrote:
> On 25/04/2019 23.41, Philippe Mathieu-Daudé wrote:
>> Hi Thomas,
>>
>> On 4/18/19 8:00 PM, Thomas Huth wrote:
>>> This patch is slightly based on earlier work by Ákos Kovács (i.e.
>>> his "hw/arm/Kconfig:
On 4/30/19 9:14 AM, Thomas Huth wrote:
> The PCI devices should be pulled in by default if PCI_DEVICES
> is set, so there is no need anymore to enforce them in the configs
> file.
>
> Tested-by: Philippe Mathieu-Daudé
> Signed-off-by: Thomas Huth
> ---
> default-con
On 4/30/19 9:13 AM, Thomas Huth wrote:
> This patch is slightly based on earlier work by Ákos Kovács (i.e.
> his "hw/arm/Kconfig: Add ARM Kconfig" patch).
>
> Tested-by: Philippe Mathieu-Daudé
> Signed-off-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
>
On 5/6/19 5:17 PM, Laszlo Ersek wrote:
> On 05/05/19 22:06, Philippe Mathieu-Daudé wrote:
>> The pflash device is a child of TYPE_DEVICE, so it can implement
>> the DeviceReset handler. Actually it has to implement it, else
>> on machine reset it might stay in an incohe
;
> We must only compile ich.c if CONFIG_PCI is available, too, so introduce a
> new config switch for this device.
>
> Signed-off-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/ide/Kconfig | 6 +-
> hw/ide/Makefile.objs | 2 +-
> 2 files chan
On 4/18/19 8:00 PM, Thomas Huth wrote:
> Add Kconfig dependencies for the emcraft-sf2 machine - we also
> distinguish between the machine (CONFIG_EMCRAFT_SF2) and the SoC
> (CONFIG_MSF2) now.
Thanks!
>
> Signed-off-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
> ---
On 4/26/19 6:26 PM, Stephen Checkoway wrote:
> Simplify and refactor for upcoming commits. In particular, pull out all
> of the code to modify the status into simple helper functions. Status
> handling becomes more complex once multiple chips are interleaved to
> produce a single device.
>
> No
: block/ssh.c
>
> CURL
> L: qemu-block@nongnu.org
> -S: Supported
> +S: Odd Fixes
> F: block/curl.c
Fair enough.
> GLUSTER
> L: qemu-block@nongnu.org
> -S: Supported
> +L: integrat...@gluster.org
> +S: Odd Fixes
> F: block/gluster.c
Reviewed-by: Philippe Mathieu-Daudé
On 5/6/19 4:39 PM, Laszlo Ersek wrote:
> On 05/05/19 22:05, Philippe Mathieu-Daudé wrote:
>> The 'CFI01' NOR flash was introduced in commit 29133e9a0fff, with
>> timing modelled. One year later, the CFI02 model was introduced
>> (commit 05ee37ebf630) based on the
On 5/6/19 4:57 PM, Laszlo Ersek wrote:
> On 05/05/19 22:06, Philippe Mathieu-Daudé wrote:
>> The reset() code is used in various places, refactor it.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> hw/block/pflash_cfi02.c | 25 +++--
the realize()
function.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1678713
Reported-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi01.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
by this series.
Regards,
Phil.
Philippe Mathieu-Daudé (5):
hw/block/pflash_cfi01: Removed an unused timer
hw/block/pflash_cfi01: Extract the pflash_reset() code
hw/block/pflash_cfi01: Add the DeviceReset() handler
hw/block/pflash_cfi02: Extract the pflash_reset() code
hw/block/pflash_cfi02
ings. Time to remove the unused timer,
we can still add it back if required.
Suggested-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daudé
---
Yes, I plan to model those timings later. Actually I have a series
working, but I'd rather first
1/ refactor common code between the both CFI implemen
The reset() code is used in various places, refactor it.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi01.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
index 6dc04f156a7..073cd14978f
The reset() code is used in various places, refactor it.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 25 +++--
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index f2c6201f813
the realize()
function.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1678713
Reported-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index f321b74433c
<< pfl->cfi_table[0x22]) * SCALE_MS);
> break;
> case 0x30:
> /* Sector erase */
>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
ter.
Regards,
Phil.
[*] https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg04595.html
Philippe Mathieu-Daudé (10):
tests/pflash-cfi02: Use the GLib API
tests/pflash-cfi02: Use IEC binary prefixes for size constants
hw/block/pflash_cfi02: Fix debug format string
hw/block/pflas
Checkoway
Message-Id: <20190426162624.55977-2-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: reworded the patch subject]
Signed-off-by: Philippe Mathieu-Daudé
---
tests/Makefile.include| 2 +
tests/pflash-cfi02-test.c
Signed-off-by: Philippe Mathieu-Daudé
---
tests/pflash-cfi02-test.c | 28 +---
1 file changed, 13 insertions(+), 15 deletions(-)
diff --git a/tests/pflash-cfi02-test.c b/tests/pflash-cfi02-test.c
index 40af1bb523e..ff775618c02 100644
--- a/tests/pflash-cfi02-test.c
+++ b
The load/store API eases code review.
Signed-off-by: Stephen Checkoway
Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Extracted from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
-
Signed-off-by: Stephen Checkoway
Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Extracted from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 6 +++---
Extract the code block in a new function, remove a goto statement.
Signed-off-by: Stephen Checkoway
Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Extracted from bigger patch, remove the XXX t
No change in functionality is intended with this commit.
Signed-off-by: Stephen Checkoway
Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Extracted from bigger patch]
Signed-off-by: Philippe M
Always compile the debug code to prevent format string to bitrot.
Signed-off-by: Stephen Checkoway
Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Extracted from bigger patch, use PRIx32]
Sign
The load/store API eases code review.
Signed-off-by: Stephen Checkoway
Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Extracted from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
-
Using IEC binary prefixes in order to make the code more readable.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/pflash-cfi02-test.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/pflash-cfi02-test.c b/tests/pflash-cfi02-test.c
index ff775618c02..3c37465499a
-by: Stephen Checkoway
Message-Id: <20190426162624.55977-11-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Prepend 'hw/' in patch subject]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 4 ++--
1 file chan
.55977-3-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Extracted from bigger patch to ease review]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 62 +++--
1 file ch
: <20190426162624.55977-3-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Extracted from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 39 ++-
1 file changed, 34 insertions
-by: Thomas Huth
Message-Id: <20190426162624.55977-4-stephen.checko...@oberlin.edu>
[PMD: Prepend 'hw/' in patch subject]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 8 +++-
tests/pflash-cfi02-test.c | 12 ++--
2 files changed, 17 insertions(+), 3 deletions(-)
Cc'ing PPC/taihu_405ep and ARM/Digic4 maintainers.
On 7/3/19 6:36 PM, Philippe Mathieu-Daudé wrote:
> On 7/3/19 6:20 PM, Stephen Checkoway wrote:
>>> On Jul 3, 2019, at 12:02, Philippe Mathieu-Daudé wrote:
>>> On 7/3/19 5:52 PM, Stephen Checkoway wrote:
>>>>
&g
not reset the status register error
bits, as a device reset would do.
Reviewed-by: John Snow
Reviewed-by: Alistair Francis
Regression-tested-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi01.c | 36
hw/block/trace-events | 1
for
migration of the 'cmd' field, and the updated commit description.
Regards,
Phil.
Philippe Mathieu-Daudé (9):
hw/block/pflash_cfi01: Removed an unused timer
hw/block/pflash_cfi01: Use the correct READ_ARRAY value
hw/block/pflash_cfi01: Extract pflash_mode_read_array()
hw/block/pflash_cfi01: Start
impact by this change.
Reference: Read Array Flowchart
"Common Flash Interface (CFI) and Command Sets"
(Intel Application Note 646)
Appendix B "Basic Command Set"
Reviewed-by: John Snow
Reviewed-by: Alistair Francis
Regression-tested-by: Laszlo Ersek
Signed-off-by: Ph
szlo Ersek
Signed-off-by: Philippe Mathieu-Daudé
---
v3: reword description
---
hw/block/pflash_cfi01.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
index 200bfd0ab8..c32c67d01d 100644
--- a/hw/block/pflash_cfi
Reviewed-by: Alistair Francis
Regression-tested-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi01.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
index e097d9260d..ba00e52923
Reviewed-by: Alistair Francis
Regression-tested-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi01.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
index ba00e52923..ab72af22a7 100644
Manufacturers are allowed to move the PRI table, this is why the
offset is queryable via fixed offsets 0x15/0x16.
Add a variable to hold the offset, so it will be easier to later
move the PRI table.
Reviewed-by: Alistair Francis
Regression-tested-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu
ce (CFI) and Command Sets"
(Intel Application Note 646)
Appendix B "Basic Command Set"
Reviewed-by: John Snow
Reviewed-by: Alistair Francis
Regression-tested-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daudé
---
v3: Handle migrating the 'cmd' field.
Since Laszlo s
ings. Time to remove the unused timer,
we can still add it back if required.
Suggested-by: Laszlo Ersek
Reviewed-by: Wei Yang
Reviewed-by: Laszlo Ersek
Reviewed-by: Alistair Francis
Regression-tested-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daudé
---
v2: Fixed commit description (Laszl
t commit 3ae0343db69,
and will clean the board code later.
Reported-by: Stephen Checkoway
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index 5392290c7
the write_cycle on CFI_QUERY,
the next command are processed as normal wcycle=0.
This matches the hardware datasheet (we do not enter the WRITE
state machine, thus no write cycle involved).
Reviewed-by: Alistair Francis
Regression-tested-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daudé
ot;, "connect"] as the supported formats.
>
> Signed-off-by: Max Reitz
Reviewed-by: Philippe Mathieu-Daudé
> ---
> tests/qemu-iotests/check | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/qemu-iotests/check b/tests/qemu-io
: <20190426162624.55977-3-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Extracted from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 40 ++--
1 file changed, 34 insertions
Signed-off-by: Stephen Checkoway
Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Extracted from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 6 +++---
-by: Thomas Huth
Message-Id: <20190426162624.55977-4-stephen.checko...@oberlin.edu>
[PMD: Prepend 'hw/' in patch subject]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 8 +++-
tests/pflash-cfi02-test.c | 12 ++--
2 files changed, 17 insertions(+), 3 deletions(-)
Signed-off-by: Stephen Checkoway
Message-Id: <20190426162624.55977-5-stephen.checko...@oberlin.edu>
[PMD: Extracted from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
---
TODO: Why? To respect the datasheet? Which model is this?
---
hw/block/pflash_cfi02.c | 4 ++--
1 file chan
` and `sector-length`, but that would make testing currently
impossible.
Signed-off-by: Stephen Checkoway
Acked-by: Thomas Huth
Message-Id: <20190426162624.55977-6-stephen.checko...@oberlin.edu>
[PMD: Rebased, add assert() on pri_offset]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash
.55977-3-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Extracted from bigger patch to ease review]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 60 +++--
1 file ch
The load/store API eases code review.
Signed-off-by: Stephen Checkoway
Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Extracted from bigger patch, simplified tracing]
Signed-off-by: Philippe M
Split the if() condition check and arrange the indentation to
ease the review of the next patches. No logical change.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/block/pflash_cfi02.c b/hw/block
Use a field width format to have a single function to log
the different width accesses.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi01.c | 6 ++
hw/block/pflash_cfi02.c | 6 ++
hw/block/trace-events | 6 ++
3 files changed, 6 insertions(+), 12 deletions(-)
diff
Introduce the FlashConfig structure, to be able to run the same set
of tests on different flash models/configurations.
Signed-off-by: Stephen Checkoway
Message-Id: <20190426162624.55977-6-stephen.checko...@oberlin.edu>
[PMD: Extracted from bigger patch]
Signed-off-by: Philippe Mathieu
Signed-off-by: Stephen Checkoway
Message-Id: <20190426162624.55977-6-stephen.checko...@oberlin.edu>
[PMD: Extracted from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/hw
cko...@oberlin.edu>
[PMD: Rebased]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 154 ++
tests/pflash-cfi02-test.c | 110 +++
2 files changed, 250 insertions(+), 14 deletions(-)
diff --git a/hw/block/pflash_cfi02.
is asserted during
erasure.
Signed-off-by: Stephen Checkoway
Acked-by: Thomas Huth
Message-Id: <20190426162624.55977-9-stephen.checko...@oberlin.edu>
[PMD: Rebased]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 94 +++
tests/pflash
Call the read() trace function after the value is set, so we can
log the returned value.
Rename the I/O trace functions with '_io_' in their name.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi01.c | 5 +++--
hw/block/pflash_cfi02.c | 6 ++
hw/block/trace-events | 4 ++--
3
No change in functionality is intended with this commit.
Signed-off-by: Stephen Checkoway
Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Extracted from bigger patch]
Signed-off-by: Philippe M
The load/store API eases code review.
Signed-off-by: Stephen Checkoway
Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Extracted from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
-
We can directly use pfl->total_len, remove the local 'chip_len'
variable.
Signed-off-by: Stephen Checkoway
Message-Id: <20190426162624.55977-6-stephen.checko...@oberlin.edu>
[PMD: Extracted from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi
Extract the code block in a new function, remove a goto statement.
Signed-off-by: Stephen Checkoway
Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Extracted from bigger patch, remove the XXX t
Extract the pflash_regions_count() function, the code will be
easier to review.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index 1f096ec185
: <20190426162624.55977-7-stephen.checko...@oberlin.edu>
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 22 ++
tests/pflash-cfi02-test.c | 39 +++
2 files changed, 57 insertions(+), 4 deletions(-)
diff --git a/hw/block/pflash_cfi
-by: Stephen Checkoway
Message-Id: <20190426162624.55977-11-stephen.checko...@oberlin.edu>
Signed-off-by: Philippe Mathieu-Daudé
---
TODO check not zero
---
hw/block/pflash_cfi02.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/block/pflash_cfi02.c b/hw
ed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index 23d05a6308..01d9c5d75a 100644
--- a/hw/block/pflash_cfi02.c
+++ b/hw/block/pflash_cfi02.c
@@ -637,7 +637,9 @@
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 40 +++-
1 file changed, 19 insertions(+), 21 deletions(-)
diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index e9519cbae8..db9dc7d8fb 100644
--- a/hw/block/pflash_cfi02.c
Always compile the debug code to prevent format string to bitrot.
Delete dead code.
Signed-off-by: Stephen Checkoway
Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: Extracted from bigger patc
Parallel NOR flashes are limited to 16-bit bus accesses.
Remove the 32-bit dead code.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi02.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index db9dc7d8fb
looking for real-world code stressing this flash model.
Regards,
Phil.
Philippe Mathieu-Daudé (20):
hw/block/pflash: Simplify trace_pflash_io_read/write()
hw/block/pflash: Simplify trace_pflash_data_read/write()
hw/block/pflash_cfi02: Fix debug format string
hw/block/pflash_cfi02: Add
Checkoway
Message-Id: <20190426162624.55977-2-stephen.checko...@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
[PMD: reworded the patch subject, g_assert_cmpint -> cmphex]
Signed-off-by: Philippe Mathieu-Daudé
---
tests/Makefile.include| 2
501 - 600 of 5545 matches
Mail list logo
