Re: [PATCH] block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK

On Mon 14 Oct 2019 12:11:52 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > 13.10.2019 23:48, Alberto Garcia wrote: >> The BDRV_REQ_NO_FALLBACK flag means that an operation should only be >> performed if it can be offloaded or otherwise performed efficiently. > > As I know, BDRV_REQ_NO_FALLBACK is

Re: [PATCH] block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK

14.10.2019 13:11, Vladimir Sementsov-Ogievskiy wrote: > 13.10.2019 23:48, Alberto Garcia wrote: >> The BDRV_REQ_NO_FALLBACK flag means that an operation should only be >> performed if it can be offloaded or otherwise performed efficiently. > > As I know, BDRV_REQ_NO_FALLBACK is for write-zeros

Re: [PATCH] block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK

13.10.2019 23:48, Alberto Garcia wrote: > The BDRV_REQ_NO_FALLBACK flag means that an operation should only be > performed if it can be offloaded or otherwise performed efficiently. As I know, BDRV_REQ_NO_FALLBACK is for write-zeros only, not about offloading.. > > However a misaligned write

[PATCH] block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK

The BDRV_REQ_NO_FALLBACK flag means that an operation should only be performed if it can be offloaded or otherwise performed efficiently. However a misaligned write request requires a RMW so we should return an error and let the caller decide how to proceed. This hits an assertion since commit