RE: [PATCH v7 10/11] hw/block/nvme: Separate read and write handlers

2020-10-20 Thread Dmitry Fomichev
qemu-block@nongnu.org; qemu-de...@nongnu.org; Alistair Francis > ; Matias Bjorling > Subject: Re: [PATCH v7 10/11] hw/block/nvme: Separate read and write > handlers > > On Tue, Oct 20, 2020 at 10:28:22AM +0200, Klaus Jensen wrote: > > On Oct 19 11:17, Dmitry Fomichev wrote: &g

Re: [PATCH v7 10/11] hw/block/nvme: Separate read and write handlers

2020-10-20 Thread Keith Busch
On Tue, Oct 20, 2020 at 10:28:22AM +0200, Klaus Jensen wrote: > On Oct 19 11:17, Dmitry Fomichev wrote: > > With ZNS support in place, the majority of code in nvme_rw() has > > become read- or write-specific. Move these parts to two separate > > handlers, nvme_read() and nvme_write() to make the

Re: [PATCH v7 10/11] hw/block/nvme: Separate read and write handlers

2020-10-20 Thread Klaus Jensen
On Oct 19 11:17, Dmitry Fomichev wrote: > With ZNS support in place, the majority of code in nvme_rw() has > become read- or write-specific. Move these parts to two separate > handlers, nvme_read() and nvme_write() to make the code more > readable and to remove multiple is_write checks that so far

[PATCH v7 10/11] hw/block/nvme: Separate read and write handlers

2020-10-18 Thread Dmitry Fomichev
With ZNS support in place, the majority of code in nvme_rw() has become read- or write-specific. Move these parts to two separate handlers, nvme_read() and nvme_write() to make the code more readable and to remove multiple is_write checks that so far existed in the i/o path. This is a refactoring