Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block latency histogram

2018-03-08 Thread Emilio G. Cota
On Thu, Mar 08, 2018 at 22:07:35 +0300, Vladimir Sementsov-Ogievskiy wrote: > 08.03.2018 21:56, Emilio G. Cota wrote: > > * Binning happens only at print time, so that we retain the flexibility to > > * choose the binning. This might not be ideal for workloads that do not > > care > > * much

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block latency histogram

2018-03-08 Thread Vladimir Sementsov-Ogievskiy
08.03.2018 21:56, Emilio G. Cota wrote: On Thu, Mar 08, 2018 at 14:42:29 +0300, Vladimir Sementsov-Ogievskiy wrote: Hi Emilio! Looked through qdist, if I understand correctly, it saves each added (with different value) element. It is not effective for disk io timing - we'll have too much

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block latency histogram

2018-03-08 Thread Emilio G. Cota
On Thu, Mar 08, 2018 at 14:42:29 +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi Emilio! > > Looked through qdist, if I understand correctly, it saves each added (with > different value) element. It is not effective for disk io timing - we'll > have too much elements. In my approach, histogram

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block latency histogram

2018-03-08 Thread Eric Blake
On 03/06/2018 10:00 AM, Stefan Hajnoczi wrote: On Wed, Feb 07, 2018 at 03:50:35PM +0300, Vladimir Sementsov-Ogievskiy wrote: v2: 01: add block_latency_histogram_clear() 02: fix spelling (sorry =() some rewordings remove histogram if latency parameter unspecified Vladimir

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block latency histogram

2018-03-08 Thread Vladimir Sementsov-Ogievskiy
Hi Emilio! Looked through qdist, if I understand correctly, it saves each added (with different value) element. It is not effective for disk io timing - we'll have too much elements. In my approach, histogram don't grow, it initially have several ranges and counts hits to each range.

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block latency histogram

2018-03-06 Thread Emilio G. Cota
On Tue, Mar 06, 2018 at 16:00:17 +, Stefan Hajnoczi wrote: > On Wed, Feb 07, 2018 at 03:50:35PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > Vladimir Sementsov-Ogievskiy (2): > > block/accounting: introduce latency histogram > > qapi: add block latency histogram interface (snip) > > 5

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block latency histogram

2018-03-06 Thread Stefan Hajnoczi
On Wed, Feb 07, 2018 at 03:50:35PM +0300, Vladimir Sementsov-Ogievskiy wrote: > v2: > > 01: add block_latency_histogram_clear() > 02: fix spelling (sorry =() > some rewordings > remove histogram if latency parameter unspecified > > Vladimir Sementsov-Ogievskiy (2): > block/accounting:

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block latency histogram

2018-02-07 Thread Vladimir Sementsov-Ogievskiy
looks strange and unrelated. 07.02.2018 16:20, no-re...@patchew.org wrote: Hi, This series failed build test on ppc host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH v2 0/2] block latency histogram Message-id: 20180207125037.13510-1-vsement...@virtuozzo.com ===

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/2] block latency histogram

2018-02-07 Thread no-reply
Hi, This series failed build test on ppc host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH v2 0/2] block latency histogram Message-id: 20180207125037.13510-1-vsement...@virtuozzo.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the