Re: [PATCH v8 03/27] ci: fixes msys2 build by upgrading capstone to 4.0.2

On 13/09/2020 00.44, Yonggang Luo wrote: > The currently random version capstone have the following compiling issue: > CC /c/work/xemu/qemu/build/slirp/src/arp_table.o > make[1]: *** No rule to make target > “/c/work/xemu/qemu/build/capstone/capstone.lib”。 Stop. > > Subproject commit

Re: qemu-img create with preallocation=full and cluster-size=2M produces a bad file

On 11.09.20 17:39, Alberto Garcia wrote: > On Fri 11 Sep 2020 04:55:08 PM CEST, Alberto Garcia wrote: >>> $ qemu-img check prealloc_4G_2M.qcow2 >>> ERROR: coffset=0x180a0: copied flag must never be set for >>> compressed clusters > > I see, this was fixed recently (QEMU 5.0.0 is still

Re: qemu-img create with preallocation=full and cluster-size=2M produces a bad file

On 14.09.20 10:22, Max Reitz wrote: > On 11.09.20 17:39, Alberto Garcia wrote: >> On Fri 11 Sep 2020 04:55:08 PM CEST, Alberto Garcia wrote: $ qemu-img check prealloc_4G_2M.qcow2 ERROR: coffset=0x180a0: copied flag must never be set for compressed clusters >> >> I see, this

Re: [PATCH v8 13/27] tests: Enable crypto tests under msys2/mingw

On Mon, Sep 14, 2020 at 3:23 PM Thomas Huth wrote: > > On 13/09/2020 00.44, Yonggang Luo wrote: > > Fixes following tests on msys2/mingw > > 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c', 'pkix_asn1_tab.c', > >tasn1, crypto], > >

Re: [PATCH v8 16/27] cirrus: Building freebsd in a single short

On 9/14/20 9:27 AM, Thomas Huth wrote: > On 13/09/2020 00.44, Yonggang Luo wrote: >> This reverts commit 45f7b7b9f38f5c4d1529a37c93dedfc26a231bba >> ("cirrus.yml: Split FreeBSD job into two parts"). >> >> freebsd 1 hour limit not hit anymore >> >> I think we going to a wrong direction, I think

Re: [PATCH] tests/check-block: Do not run the iotests with old versions of bash

On 12.09.20 14:14, Thomas Huth wrote: > macOS is shipped with a very old version of the bash (3.2), which > is currently not suitable for running the iotests anymore. Add > a check to skip the iotests in this case - if someone still wants > to run the iotests on macOS, they can install a newer

Re: [PATCH] tests/check-block: Do not run the iotests with old versions of bash

On 14.09.20 12:50, Thomas Huth wrote: > On 14/09/2020 11.19, Max Reitz wrote: >> On 12.09.20 14:14, Thomas Huth wrote: >>> macOS is shipped with a very old version of the bash (3.2), which >>> is currently not suitable for running the iotests anymore. Add >>> a check to skip the iotests in this

Re: [PATCH v8 03/27] ci: fixes msys2 build by upgrading capstone to 4.0.2

On Mon, Sep 14, 2020 at 3:10 PM Thomas Huth wrote: > > On 13/09/2020 00.44, Yonggang Luo wrote: > > The currently random version capstone have the following compiling issue: > > CC /c/work/xemu/qemu/build/slirp/src/arp_table.o > > make[1]: *** No rule to make target

Re: [PATCH v8 16/27] cirrus: Building freebsd in a single short

On 13/09/2020 00.44, Yonggang Luo wrote: > This reverts commit 45f7b7b9f38f5c4d1529a37c93dedfc26a231bba > ("cirrus.yml: Split FreeBSD job into two parts"). > > freebsd 1 hour limit not hit anymore > > I think we going to a wrong direction, I think there is some tests a stall > the test runner,

Re: [PATCH v8 02/27] block: Fixes nfs compiling error on msys2/mingw

How about using the following patch with +#if !defined (_WIN32) .bdrv_get_allocated_file_size = nfs_get_allocated_file_size, +#endif Also, +static blkcnt_t nfs_get_st_blocks(const struct nfs_stat *st) +{ +#if defined(_WIN32) +return (st->st_size + 511) / 512; +#else +return

Re: [PATCH] MAINTAINERS: add Stefan Hajnoczi as block/nvme.c maintainer

On Wed, Sep 09, 2020 at 02:51:50PM +0200, Philippe Mathieu-Daudé wrote: > On 9/7/20 1:16 PM, Stefan Hajnoczi wrote: > > Development of the userspace NVMe block driver picked up again recently. > > After talking with Fam I am stepping up as block/nvme.c maintainer. > > Patches will be merged

Re: [PATCH] tests/check-block: Do not run the iotests with old versions of bash

On 14/09/2020 11.19, Max Reitz wrote: > On 12.09.20 14:14, Thomas Huth wrote: >> macOS is shipped with a very old version of the bash (3.2), which >> is currently not suitable for running the iotests anymore. Add >> a check to skip the iotests in this case - if someone still wants >> to run the

Re: [PATCH v8 24/27] ci: Enable msys2 ci in cirrus

On 13/09/2020 00.44, Yonggang Luo wrote: > Install msys2 in a proper way refer to > https://github.com/cirruslabs/cirrus-ci-docs/issues/699 > The https://wiki.qemu.org/Hosts/W32#Native_builds_with_MSYS2 need to be > updated. I don't think that a request to update the wiki should be part of the

Re: [qemu-web PATCH] Add QEMU storage overview blog post

On 14/09/20 12:35, Stefan Hajnoczi wrote: >> >> Signed-off-by: Stefan Hajnoczi >> --- >> _posts/2020-09-07-qemu-storage-overview.md | 122 +++ >> screenshots/2020-09-07-block-device-io.svg | 366 + >> screenshots/2020-09-07-lifecycle.svg | 328 ++ >>

Re: [qemu-web PATCH] Add QEMU storage overview blog post

On 14/09/2020 12.35, Stefan Hajnoczi wrote: > On Mon, Sep 07, 2020 at 04:04:21PM +0100, Stefan Hajnoczi wrote: >> I want to kick of a series of posts about storage. The first post covers >> high-level concepts, features, and utilities in QEMU. Later posts will >> discuss configuration details,

Re: [PATCH v8 13/27] tests: Enable crypto tests under msys2/mingw

On 14/09/2020 10.19, 罗勇刚(Yonggang Luo) wrote: > > > On Mon, Sep 14, 2020 at 3:23 PM Thomas Huth > wrote: >> >> On 13/09/2020 00.44, Yonggang Luo wrote: >> > Fixes following tests on msys2/mingw >> >       'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c', >

Re: [PATCH v8 24/27] ci: Enable msys2 ci in cirrus

Am 14.09.20 um 09:38 schrieb Thomas Huth: > On 13/09/2020 00.44, Yonggang Luo wrote: >> Install msys2 in a proper way refer to >> https://github.com/cirruslabs/cirrus-ci-docs/issues/699 >> The https://wiki.qemu.org/Hosts/W32#Native_builds_with_MSYS2 need to be >> updated. > I don't think that a

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

On 13/09/20 18:14, 罗勇刚(Yonggang Luo) wrote: > I am hurry to revert --ninja option because when the meson are changed, the > make -j10 can not automatically re configure, that would raise ninja can > not found error  My understanding is that with 0.55.2 you don't need --ninja at all (the default

Re: [PATCH] qemu-img: Support bitmap --merge into backing image

On 11.09.20 17:17, Eric Blake wrote: > On 9/11/20 3:31 AM, Max Reitz wrote: >> On 09.09.20 14:33, Eric Blake wrote: >>> If you have the chain 'base.qcow2 <- top.qcow2' and want to merge a >>> bitmap from top into base, qemu-img was failing with: >>> >>> qemu-img: Could not open 'top.qcow2': Could

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

On Mon, Sep 14, 2020 at 4:45 PM Paolo Bonzini wrote: > > On 13/09/20 18:14, 罗勇刚(Yonggang Luo) wrote: > > I am hurry to revert --ninja option because when the meson are changed, the > > make -j10 can not automatically re configure, that would raise ninja can > > not found error > > My

Re: [PATCH v5 1/8] qapi: Restrict LostTickPolicy enum to machine code

+Laurent + qemu-block@ On 9/14/20 11:14 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Acked-by: Markus Armbruster >> Acked-by: Paolo Bonzini >> Signed-off-by: Philippe Mathieu-Daudé > > Unlike the other patches that move code out of misc.json, this one > doesn't say

Re: [PATCH] tests/check-block: Do not run the iotests with old versions of bash

On Sat, Sep 12, 2020 at 8:16 PM Thomas Huth wrote: > > macOS is shipped with a very old version of the bash (3.2), which > is currently not suitable for running the iotests anymore. Add > a check to skip the iotests in this case - if someone still wants > to run the iotests on macOS, they can

Re: [qemu-web PATCH] Add QEMU storage overview blog post

On Mon, Sep 07, 2020 at 04:04:21PM +0100, Stefan Hajnoczi wrote: > I want to kick of a series of posts about storage. The first post covers > high-level concepts, features, and utilities in QEMU. Later posts will > discuss configuration details, architecture, and performance. > > Signed-off-by:

Re: [PATCH v8 13/27] tests: Enable crypto tests under msys2/mingw

On 13/09/2020 00.44, Yonggang Luo wrote: > Fixes following tests on msys2/mingw > 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c', > 'pkix_asn1_tab.c', >tasn1, crypto], > 'test-crypto-tlssession': ['crypto-tls-x509-helpers.c', >

Re: [PATCH v8 16/27] cirrus: Building freebsd in a single short

On 14/09/2020 10.50, Philippe Mathieu-Daudé wrote: > On 9/14/20 9:27 AM, Thomas Huth wrote: >> On 13/09/2020 00.44, Yonggang Luo wrote: >>> This reverts commit 45f7b7b9f38f5c4d1529a37c93dedfc26a231bba >>> ("cirrus.yml: Split FreeBSD job into two parts"). >>> >>> freebsd 1 hour limit not hit

Re: [PATCH] tests/check-block: Do not run the iotests with old versions of bash

On 14/09/2020 11.36, 罗勇刚(Yonggang Luo) wrote: > > > On Sat, Sep 12, 2020 at 8:16 PM Thomas Huth > wrote: >> >> macOS is shipped with a very old version of the bash (3.2), which >> is currently not suitable for running the iotests anymore. Add >> a check to skip the

Re: [PATCH] tests/check-block: Do not run the iotests with old versions of bash

On 14/09/2020 13.13, Max Reitz wrote: > On 14.09.20 12:50, Thomas Huth wrote: >> On 14/09/2020 11.19, Max Reitz wrote: >>> On 12.09.20 14:14, Thomas Huth wrote: macOS is shipped with a very old version of the bash (3.2), which is currently not suitable for running the iotests anymore.

Re: [PATCH] iotests: Work around failing readlink -f

On 14/09/2020 13.38, Max Reitz wrote: > On macOS, (out of the box) readlink does not have -f. If the recent > "readlink -f" call introduced by b1cbc33a397 fails, just fall back to > the old behavior (which means you can run the iotests only from the > build tree, but that worked fine for six

Re: [PATCH] iotests: Work around failing readlink -f

On 14.09.20 14:31, Peter Maydell wrote: > On Mon, 14 Sep 2020 at 12:39, Max Reitz wrote: >> >> On macOS, (out of the box) readlink does not have -f. If the recent >> "readlink -f" call introduced by b1cbc33a397 fails, just fall back to >> the old behavior (which means you can run the iotests

Re: [PATCH] iotests: Work around failing readlink -f

On Mon, 14 Sep 2020 at 13:32, Max Reitz wrote: > > On 14.09.20 14:31, Peter Maydell wrote: > > On Mon, 14 Sep 2020 at 12:39, Max Reitz wrote: > >> > >> On macOS, (out of the box) readlink does not have -f. If the recent > >> "readlink -f" call introduced by b1cbc33a397 fails, just fall back to

[PATCH] iotests: Work around failing readlink -f

On macOS, (out of the box) readlink does not have -f. If the recent "readlink -f" call introduced by b1cbc33a397 fails, just fall back to the old behavior (which means you can run the iotests only from the build tree, but that worked fine for six years, so it should be fine still). Keep any

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

On Tue, Aug 11, 2020 at 09:54:08PM +0800, Zhenyu Ye wrote: > Hi Kevin, > > On 2020/8/10 23:38, Kevin Wolf wrote: > > Am 10.08.2020 um 16:52 hat Zhenyu Ye geschrieben: > >> Before doing qmp actions, we need to lock the qemu_global_mutex, > >> so the qmp actions should not take too long time. > >>

Re: [PATCH v2] iotests: Work around failing readlink -f

On 14.09.20 16:26, Peter Maydell wrote: > On Mon, 14 Sep 2020 at 15:17, Max Reitz wrote: >> >> On macOS, (out of the box) readlink does not have -f. If the recent >> "readlink -f" call introduced by b1cbc33a397 fails, just fall back to >> the old behavior (which means you can run the iotests

Re: [PATCH 2/2] qcow2: Convert qcow2_alloc_cluster_offset() into qcow2_alloc_host_offset()

On 11.09.20 16:09, Alberto Garcia wrote: > qcow2_alloc_cluster_offset() takes an (unaligned) guest offset and > returns the (aligned) offset of the corresponding cluster in the qcow2 > image. > > In practice none of the callers need to know where the cluster starts > so this patch makes the

Potential regression in 'qemu-img convert' to LVM

Hi list, following command fails since 5.1 (tested on kernel 5.4.60): # qemu-img convert -p -f raw -O raw /dev/zvol/pool/disk-1 /dev/vg/disk-1 qemu-img: error while writing at byte 2157968896: Device or resource busy (source is ZFS here, but doesn't matter in practice, it always fails the

Re: [PATCH] iotests: Work around failing readlink -f

On Mon, 14 Sep 2020 at 12:39, Max Reitz wrote: > > On macOS, (out of the box) readlink does not have -f. If the recent > "readlink -f" call introduced by b1cbc33a397 fails, just fall back to > the old behavior (which means you can run the iotests only from the > build tree, but that worked fine

Re: [PATCH v4 0/2] vhost-user reconnect issues during vhost initialization

On Thu, May 28, 2020 at 12:11:17PM +0300, Dima Stepanov wrote: > Before revising the vhost-user initialization code, we suggest adding > the sanity checks to be aware of the possible disconnect event and that > the vhost_dev structure can be in "uninitialized" state. > > The vhost-user-blk daemon

Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows

On 9/13/20 10:35 AM, Philippe Mathieu-Daudé wrote: On 9/13/20 12:44 AM, Yonggang Luo wrote: On windows, a difference in line endings causes testsuite failures complaining that every single line in files such as 'tests/qapi-schemadoc-good.texi' is wrong. Fix it by adding -b to diff. Isn't

Re: [PATCH 0/3] Add support for sequential backups

Friendly ping :) On 8/26/20 2:13 PM, Stefan Reiter wrote: Backups can already be done for multiple drives in a transaction. However, these jobs will start all at once, potentially hogging a lot of disk IO all at once. This problem is made worse, since IO throttling is only available on a

Re: [PATCH] iotests: Work around failing readlink -f

Max Reitz writes: > On macOS, (out of the box) readlink does not have -f. If the recent > "readlink -f" call introduced by b1cbc33a397 fails, just fall back to > the old behavior (which means you can run the iotests only from the > build tree, but that worked fine for six years, so it should

Re: [PATCH v2] iotests: Work around failing readlink -f

On Mon, 14 Sep 2020 at 15:17, Max Reitz wrote: > > On macOS, (out of the box) readlink does not have -f. If the recent > "readlink -f" call introduced by b1cbc33a397 fails, just fall back to > the old behavior (which means you can run the iotests only from the > build tree, but that worked fine

Re: [PATCH v5 0/5] fix & merge block_status_above and is_allocated_above

On Wed, Jun 10, 2020 at 03:04:21PM +0300, Vladimir Sementsov-Ogievskiy wrote: > v5: rebase on coroutine-wrappers series, 02 changed correspondingly > > Based on series "[PATCH v7 0/7] coroutines: generate wrapper code", or > in other words: > Based-on:

Re: [PATCH 1/2] qcow2: Make preallocate_co() resize the image to the correct size

On 11.09.20 16:09, Alberto Garcia wrote: > This function preallocates metadata structures and then extends the > image to its new size, but that new size calculation is wrong because > it doesn't take into account that the host_offset variable is always > cluster-aligned. > > This problem can be

[PATCH v3] iotests: Drop readlink -f

On macOS, (out of the box) readlink does not have -f. We do not really need readlink here, though, it was just a replacement for realpath (which is not available on our BSD test systems), which we needed to make the $(dirname) into an absolute path. Instead of using either, just use "cd; pwd"

Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows

On Sun, 13 Sep 2020 at 19:51, Philippe Mathieu-Daudé wrote: > > On 9/13/20 6:01 PM, 罗勇刚(Yonggang Luo) wrote: > > > > > > On Sun, Sep 13, 2020 at 11:35 PM Philippe Mathieu-Daudé > > mailto:phi...@redhat.com>> wrote: > > > > On 9/13/20 12:44 AM, Yonggang Luo wrote: > > > On windows, a

Re: [PATCH v3] iotests: Drop readlink -f

On 9/14/20 9:56 AM, Max Reitz wrote: On macOS, (out of the box) readlink does not have -f. We do not really need readlink here, though, it was just a replacement for realpath (which is not available on our BSD test systems), which we needed to make the $(dirname) into an absolute path. Instead

Re: [PATCH 2/2] block: file-posix: Replace posix_fallocate with fallocate

On Mon, Aug 31, 2020 at 05:01:27PM +0300, Nir Soffer wrote: > If fallocate() is not supported, posix_fallocate() falls back to > inefficient allocation, writing one byte for every 4k bytes[1]. This is > very slow compared with writing zeros. In oVirt we measured ~400% > improvement in allocation

Re: [PATCH] tests/check-block: Do not run the iotests with old versions of bash

On 9/12/20 7:14 AM, Thomas Huth wrote: macOS is shipped with a very old version of the bash (3.2), which is currently not suitable for running the iotests anymore. Add a check to skip the iotests in this case - if someone still wants to run the iotests on macOS, they can install a newer version

Re: [PATCH v3] iotests: Drop readlink -f

On 14/09/2020 16.56, Max Reitz wrote: > On macOS, (out of the box) readlink does not have -f. We do not really > need readlink here, though, it was just a replacement for realpath > (which is not available on our BSD test systems), which we needed to > make the $(dirname) into an absolute path. >

Re: [PATCH v7 08/13] qapi: Add a 'coroutine' flag for commands

Kevin Wolf writes: > This patch adds a new 'coroutine' flag to QMP command definitions that > tells the QMP dispatcher that the command handler is safe to be run in a > coroutine. > > The documentation of the new flag pretends that this flag is already > used as intended, which it isn't yet

Re: [PATCH v5 0/5] fix & merge block_status_above and is_allocated_above

14.09.2020 16:06, Stefan Hajnoczi wrote: On Wed, Jun 10, 2020 at 03:04:21PM +0300, Vladimir Sementsov-Ogievskiy wrote: v5: rebase on coroutine-wrappers series, 02 changed correspondingly Based on series "[PATCH v7 0/7] coroutines: generate wrapper code", or in other words: Based-on:

[PATCH v2] iotests: Work around failing readlink -f

On macOS, (out of the box) readlink does not have -f. If the recent "readlink -f" call introduced by b1cbc33a397 fails, just fall back to the old behavior (which means you can run the iotests only from the build tree, but that worked fine for six years, so it should be fine still). Suppress all

Re: [PATCH v3] iotests: Drop readlink -f

On Mon, 14 Sep 2020 at 17:03, Eric Blake wrote: > If CDPATH is set, this can produce wrong results. Do we care? Probably > not, since (as you point out), $source_iotests has the same bug, and no > one has complained yet. This has come up previously -- configure and probably most of our other

Re: [PATCH] MAINTAINERS: add Stefan Hajnoczi as block/nvme.c maintainer

On Mon, 14 Sep 2020 11:37:03 +0100 Stefan Hajnoczi wrote: > On Wed, Sep 09, 2020 at 02:51:50PM +0200, Philippe Mathieu-Daudé wrote: > > On 9/7/20 1:16 PM, Stefan Hajnoczi wrote: > > > Development of the userspace NVMe block driver picked up again recently. > > > After talking with Fam I am

Re: [PATCH v8 13/27] tests: Enable crypto tests under msys2/mingw

On Mon, Sep 14, 2020 at 11:58:24PM +0800, 罗勇刚(Yonggang Luo) wrote: > On Mon, Sep 14, 2020 at 7:07 PM Thomas Huth wrote: > > > > On 14/09/2020 10.19, 罗勇刚(Yonggang Luo) wrote: > > > > > > > > > On Mon, Sep 14, 2020 at 3:23 PM Thomas Huth > > > wrote: > > >> > > >> On

Re: [PATCH 2/2] qcow2: Convert qcow2_alloc_cluster_offset() into qcow2_alloc_host_offset()

On Mon 14 Sep 2020 02:14:36 PM CEST, Max Reitz wrote: > However, I wonder what you think about “cluster_offset” in > qcow2_alloc_host_offset. It isn’t a cluster offset anymore. > Can/should we rename it? That variable was not a cluster offset before this patch either (at least not during the

Re: [PATCH v7 09/13] qmp: Move dispatcher to a coroutine

Kevin Wolf writes: > This moves the QMP dispatcher to a coroutine and runs all QMP command > handlers that declare 'coroutine': true in coroutine context so they > can avoid blocking the main loop while doing I/O or waiting for other > events. > > For commands that are not declared safe to run

Re: [PATCH] tests/check-block: Do not run the iotests with old versions of bash

On 14/09/2020 17.03, Eric Blake wrote: > On 9/12/20 7:14 AM, Thomas Huth wrote: >> macOS is shipped with a very old version of the bash (3.2), which >> is currently not suitable for running the iotests anymore. Add >> a check to skip the iotests in this case - if someone still wants >> to run the

Re: [PATCH 0/2] Replace posix_fallocate() with falloate()

On Mon, Aug 31, 2020 at 5:01 PM Nir Soffer wrote: > > Change preallocation=falloc to use fallocate() instead of > posix_fallocte(), improving performance when legacy filesystem that do > not support fallocate, and avoiding issues seen with OFD locks. > > More work is needed to respect cache mode

Re: [PATCH v8 0/6] block: seriously improve savevm/loadvm performance

On Thu, Jul 09, 2020 at 04:26:38PM +0300, Denis V. Lunev wrote: > This series do standard basic things: > - it creates intermediate buffer for all writes from QEMU migration code > to QCOW2 image, > - this buffer is sent to disk asynchronously, allowing several writes to > run in parallel. >

Re: [PATCH] iotests: Work around failing readlink -f

On 14.09.20 14:51, Peter Maydell wrote: > On Mon, 14 Sep 2020 at 13:32, Max Reitz wrote: >> >> On 14.09.20 14:31, Peter Maydell wrote: >>> On Mon, 14 Sep 2020 at 12:39, Max Reitz wrote: On macOS, (out of the box) readlink does not have -f. If the recent "readlink -f" call

Re: [PATCH v3] iotests: Drop readlink -f

On 9/14/20 10:43 AM, Thomas Huth wrote: +++ b/tests/qemu-iotests/check @@ -44,7 +44,7 @@ then _init_error "failed to obtain source tree name from check symlink" fi source_iotests=$(cd "$source_iotests"; pwd) || _init_error "failed to enter source tree" -

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

On Tue, Aug 11, 2020 at 09:54:08PM +0800, Zhenyu Ye wrote: > Hi Kevin, > > On 2020/8/10 23:38, Kevin Wolf wrote: > > Am 10.08.2020 um 16:52 hat Zhenyu Ye geschrieben: > >> Before doing qmp actions, we need to lock the qemu_global_mutex, > >> so the qmp actions should not take too long time. > >>

Re: [PATCH v8 13/27] tests: Enable crypto tests under msys2/mingw

On Mon, Sep 14, 2020 at 7:07 PM Thomas Huth wrote: > > On 14/09/2020 10.19, 罗勇刚(Yonggang Luo) wrote: > > > > > > On Mon, Sep 14, 2020 at 3:23 PM Thomas Huth > > wrote: > >> > >> On 13/09/2020 00.44, Yonggang Luo wrote: > >> > Fixes following tests on msys2/mingw > >> >

Re: [PATCH v7 07/13] monitor: Make current monitor a per-coroutine property

Kevin Wolf writes: > This way, a monitor command handler will still be able to access the > current monitor, but when it yields, all other code code will correctly > get NULL from monitor_cur(). > > This uses a hash table to map the coroutine pointer to the current > monitor of that coroutine.

Re: [PATCH v7 06/13] qmp: Call monitor_set_cur() only in qmp_dispatch()

Kevin Wolf writes: > The correct way to set the current monitor for a coroutine handler will > be different than for a blocking handler, so monitor_set_cur() needs to > be called in qmp_dispatch(). > > Signed-off-by: Kevin Wolf > --- > include/qapi/qmp/dispatch.h | 3 ++- > monitor/qmp.c

Re: [PATCH v7 00/13] monitor: Optionally run handlers in coroutines

Stefan Hajnoczi writes: > On Wed, Sep 09, 2020 at 05:11:36PM +0200, Kevin Wolf wrote: >> Some QMP command handlers can block the main loop for a relatively long >> time, for example because they perform some I/O. This is quite nasty. >> Allowing such handlers to run in a coroutine where they can

[PATCH v1 6/6] iotests: Work around failing readlink -f

From: Max Reitz On macOS, (out of the box) readlink does not have -f. If the recent "readlink -f" call introduced by b1cbc33a397 fails, just fall back to the old behavior (which means you can run the iotests only from the build tree, but that worked fine for six years, so it should be fine

Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows

On Mon, Sep 14, 2020 at 10:41 PM Peter Maydell wrote: > On Sun, 13 Sep 2020 at 19:51, Philippe Mathieu-Daudé > wrote: > > > > On 9/13/20 6:01 PM, 罗勇刚(Yonggang Luo) wrote: > > > > > > > > > On Sun, Sep 13, 2020 at 11:35 PM Philippe Mathieu-Daudé > > > mailto:phi...@redhat.com>> wrote: > > > > >

Re: [PATCH] tests/check-block: Do not run the iotests with old versions of bash

On 9/14/20 10:33 AM, Thomas Huth wrote: On 14/09/2020 17.03, Eric Blake wrote: On 9/12/20 7:14 AM, Thomas Huth wrote: macOS is shipped with a very old version of the bash (3.2), which is currently not suitable for running the iotests anymore. Add a check to skip the iotests in this case - if

Re: [PATCH v3] iotests: Drop readlink -f

On Mon, 14 Sep 2020 at 16:43, Thomas Huth wrote: > > On 14/09/2020 16.56, Max Reitz wrote: > > On macOS, (out of the box) readlink does not have -f. We do not really > > need readlink here, though, it was just a replacement for realpath > > (which is not available on our BSD test systems), which

[PATCH v2] qemu-img: Support bitmap --merge into backing image

If you have the chain 'base.qcow2 <- top.qcow2' and want to merge a bitmap from top into base, qemu-img was failing with: qemu-img: Could not open 'top.qcow2': Could not open backing file: Failed to get shared "write" lock Is another process using the image [base.qcow2]? The easiest fix is to

Re: [PATCH] block/rbd: add 'namespace' to qemu_rbd_strong_runtime_opts[]

On Mon, Sep 14, 2020 at 3:06 PM Stefano Garzarella wrote: > > Commit 19ae9ae014 ("block/rbd: Add support for ceph namespaces") > introduced namespace support for RBD, but we forgot to add the > new 'namespace' options to qemu_rbd_strong_runtime_opts[]. > > The 'namespace' is used to identify the

Re: [PATCH v8 13/27] tests: Enable crypto tests under msys2/mingw

On Tue, Sep 15, 2020 at 12:14 AM Daniel P. Berrangé wrote: > > On Mon, Sep 14, 2020 at 11:58:24PM +0800, 罗勇刚(Yonggang Luo) wrote: > > On Mon, Sep 14, 2020 at 7:07 PM Thomas Huth wrote: > > > > > > On 14/09/2020 10.19, 罗勇刚(Yonggang Luo) wrote: > > > > > > > > > > > > On Mon, Sep 14, 2020 at 3:23

[PATCH] block/rbd: add 'namespace' to qemu_rbd_strong_runtime_opts[]

Commit 19ae9ae014 ("block/rbd: Add support for ceph namespaces") introduced namespace support for RBD, but we forgot to add the new 'namespace' options to qemu_rbd_strong_runtime_opts[]. The 'namespace' is used to identify the image, so it is a strong option since it can changes the data of a

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

On 13/09/2020 00.44, Yonggang Luo wrote: > It first introduce msys2 CI on cirrus by fixes nfs, capstone, curses and > disable partial test-char tests. > And then fixes all unit tests failure on msys2/mingw > This fixes the reviews suggested in the mailling list > All cirrus CI are passed Hi,

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

On Mon, Sep 14, 2020 at 2:10 PM Thomas Huth wrote: > On 13/09/2020 00.44, Yonggang Luo wrote: > > It first introduce msys2 CI on cirrus by fixes nfs, capstone, curses and > > disable partial test-char tests. > > And then fixes all unit tests failure on msys2/mingw > > This fixes the reviews

Re: [PATCH v3 05/15] hw/block/nvme: Define trace events related to NS Types

On 9/14/20 12:14 AM, Dmitry Fomichev wrote: > A few trace events are defined that are relevant to implementing > Namespace Types (NVMe TP 4056). > > Signed-off-by: Dmitry Fomichev > Reviewed-by: Klaus Jensen > --- > hw/block/trace-events | 10 ++ > 1 file changed, 10 insertions(+)

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

Am 14.09.20 um 08:27 schrieb 罗勇刚(Yonggang Luo): > > Thanks, I am learning how to submit patches properly, in old days,  > when I am using pull request on github have no such problems. easy to > follow up May I also ask you to send text-only e-mails? Your HTML e-mails are really hard to read.

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

On 9/14/20 8:27 AM, 罗勇刚(Yonggang Luo) wrote: > > > On Mon, Sep 14, 2020 at 2:10 PM Thomas Huth > wrote: > > On 13/09/2020 00.44, Yonggang Luo wrote: > > It first introduce msys2 CI on cirrus by fixes nfs, capstone, > curses and > > disable partial

Re: [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps

Vladimir Sementsov-Ogievskiy writes: > 11.09.2020 18:22, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 11.09.2020 14:21, Greg Kurz wrote: On Fri, 11 Sep 2020 13:18:32 +0300 Vladimir Sementsov-Ogievskiy wrote: [...] > Hmm.. With this series I understand

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

On Mon, Sep 14, 2020 at 2:38 PM Stefan Weil wrote: > > Am 14.09.20 um 08:27 schrieb 罗勇刚(Yonggang Luo): > > > Thanks, I am learning how to submit patches properly, in old days, when I am using pull request on github have no such problems. easy to follow up > > > May I also ask you to send

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

On Sun, Sep 13, 2020 at 7:07 AM wrote: > > Patchew URL: https://patchew.org/QEMU/20200912224431.1428-1-luoyongg...@gmail.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > N/A. Internal error while reading log file > > > > The

Re: [PATCH v5 4/7] tests/qtest/libqos/virtio-blk: add support for vhost-user-blk

On Fri, Sep 11, 2020 at 4:43 AM Dima Stepanov wrote: > > Add support for the vhost-user-blk-pci device. This node can be used by > the vhost-user-blk tests. Tests for the vhost-user-blk device are added > in the following patches. > > Signed-off-by: Dima Stepanov Reviewed-by: Raphael Norwitz