On Wed, 15 Jul 2015 16:45:52 +0200
Paolo Bonzini wrote:
> On 15/07/2015 16:28, Michael S. Tsirkin wrote:
> > On Wed, Jul 15, 2015 at 04:18:49PM +0200, Paolo Bonzini wrote:
> >>
> >>
> >> On 15/07/2015 16:14, Michael S. Tsirkin wrote:
> >>> On Wed, Jul 15, 2015 at 02:47:24PM +0200, Paolo Bonzini
r 2.5.
Signed-off-by: Cornelia Huck
---
Note: this is based upon my s390x series from 10/14, as I otherwise
could not test compat on s390x.
---
hw/block/virtio-blk.c | 2 +-
hw/s390x/s390-virtio-ccw.c | 4
include/hw/compat.h| 6 +-
3 files changed, 10 insertions(+), 2 dele
On Fri, 16 Oct 2015 10:46:31 +0200
Paolo Bonzini wrote:
>
>
> On 16/10/2015 10:41, Paolo Bonzini wrote:
> >
> >
> > On 16/10/2015 10:40, Cornelia Huck wrote:
> >> --- a/hw/s390x/s390-virtio-ccw.c
> >> +++ b/hw/s390x/s390-virtio-ccw.c
&g
r 2.5.
Signed-off-by: Cornelia Huck
---
hw/block/virtio-blk.c | 2 +-
include/hw/compat.h | 6 +-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 8beb26b..999dbd7 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -
Lightly tested on s390x.
Changes v1->v2:
- have the s390x compat hander include HW_COMPAT
- prepare the pseries 2.4 compat handler
- switch compat property at virtio-blk-device instead of the
transport level
Cornelia Huck (3):
s390x: include HW_COMPAT_* props
ppc/spapr: add 2.4 com
HW_COMPAT_2_4 will become non-empty: prepare for it.
Signed-off-by: Cornelia Huck
---
hw/ppc/spapr.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index d1b0e53..c216e2c 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -2224,7 +2224,11 @@ static
On Fri, 16 Oct 2015 12:32:52 +0200
Christian Borntraeger wrote:
> Am 16.10.2015 um 12:25 schrieb Cornelia Huck:
> > Devices that are compliant with virtio-1 do not support scsi
> > passthrough any more (and it has not been a recommended setup
> > anyway for quite some time
We want to inherit generic hw compat as well.
Signed-off-by: Cornelia Huck
---
hw/s390x/s390-virtio-ccw.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 20883ff..d09d867 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x
On Sun, 18 Oct 2015 10:59:59 +0300
"Michael S. Tsirkin" wrote:
> On Fri, Oct 16, 2015 at 01:07:28PM +0200, Christian Borntraeger wrote:
> > Lets keep this patch as is to have scsi=off as default for virtio 1.0
> >
> > (some iotests do fail because of this)
> >
> > Christian
>
> What fails, ex
On Mon, 19 Oct 2015 14:57:31 +0300
"Michael S. Tsirkin" wrote:
> On Mon, Oct 19, 2015 at 01:53:50PM +0200, Cornelia Huck wrote:
> > On Sun, 18 Oct 2015 10:59:59 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Fri, Oct 16, 201
On Mon, 7 Dec 2015 18:59:27 +0800
Fam Zheng wrote:
> The official way of enabling dataplane is through the "iothread"
> property that references an iothread object created by "-object
> iothread". Since the old "x-data-plane=on" way now even crashes, it's
> probably easier to just drop it:
>
>
For x-data-plane=true, we create an iothread automatically for
compatibility. Commit d21e877 ("iothread: include id in thread name")
exposed that this iothread missed correct parenthood: fix this.
Signed-off-by: Cornelia Huck
---
hw/block/dataplane/virtio-blk.c | 3 +++
1 file
On Mon, 7 Dec 2015 16:19:07 +0100
Paolo Bonzini wrote:
> The solution would be to add object_property_add_child to
> virtio_blk_data_plane_create, between object_initialize and
> user_creatable_complete. But I think this patch is ok for 2.5.
Just sent a patch that does this. If it is correct, I
On Mon, 7 Dec 2015 16:50:01 +0100
Cornelia Huck wrote:
> For x-data-plane=true, we create an iothread automatically for
> compatibility. Commit d21e877 ("iothread: include id in thread name")
> exposed that this iothread missed correct parenthood: fix this.
>
> Sig
On Mon, 7 Dec 2015 16:33:11 +
Peter Maydell wrote:
> On 7 December 2015 at 16:27, Cornelia Huck wrote:
> > On Mon, 7 Dec 2015 16:50:01 +0100
> > Cornelia Huck wrote:
> >
> >> For x-data-plane=true, we create an iothread automatically for
> >> c
On Tue, 8 Dec 2015 09:56:14 +0800
Fam Zheng wrote:
> On Mon, 12/07 21:02, Fam Zheng wrote:
> > On Mon, 12/07 12:29, Cornelia Huck wrote:
> > > No general objection to removing x-data-plane; but this probably wants
> > > a mention on the changelog as x-data-
al number. Otherwise qemu might fail with
> "cyls must be between 1 and 65535"
>
> Acked-by: Cornelia Huck
> Signed-off-by: Christian Borntraeger
> ---
> block/raw-posix.c | 7 ---
> 1 file changed, 7 deletions(-)
Maybe add cc:stable?
t_features in ->get_features() although the
> features argument already contains host_features. Make all devices
> consistent by dropping the unnecessary code.
I wonder whether we should add that explicitly to the contract for
get_features()?
>
> Cc: Cornelia Huck
> Signed-off-by: S
t_features in ->get_features() although the
> features argument already contains host_features. Make all devices
> consistent by dropping the unnecessary code.
>
> Cc: Cornelia Huck
> Signed-off-by: Stefan Hajnoczi
> ---
> hw/block/virtio-blk.c | 3 ---
> hw/char/virti
On Wed, Aug 03 2022, Stefan Hajnoczi wrote:
> Suggested-by: Cornelia Huck
> Signed-off-by: Stefan Hajnoczi
> ---
> include/hw/virtio/virtio.h | 20
> 1 file changed, 20 insertions(+)
>
> diff --git a/include/hw/virtio/virtio.h b/include/hw/vi
On Mon, 19 Nov 2018 20:07:58 +0800
Mao Zhongyi wrote:
> The SysBusDeviceClass::init() interface is considered
> as a legacy interface and there are currently some
> efforts going on to get rid of it. Thus convert
> SysBusDeviceClass::init to DeviceClass::realize.
In case my comment to the s390
On Thu, 11 Feb 2016 10:01:35 +0100
Markus Armbruster wrote:
> Sascha Silbe writes:
> > This leaves out
> > virtio-{gpu,input,input-hid,input-host,keyboard,mouse,tablet} because
> > they're currently only implemented using PCI, so there's no immediate
> > value in having them. It would neverthel
On Thu, 11 Feb 2016 17:18:32 +0100
Sascha Silbe wrote:
> Cornelia Huck writes:
>
> > On Thu, 11 Feb 2016 10:01:35 +0100
> > Markus Armbruster wrote:
> >
> >> Sascha Silbe writes:
> >
> >> > This leaves out
> >> > virtio
On Wed, 16 Mar 2016 13:49:10 +0100
Paolo Bonzini wrote:
> On 16/03/2016 13:42, Cornelia Huck wrote:
> > On Wed, 16 Mar 2016 13:32:59 +0100
> > Paolo Bonzini wrote:
> >
> >> On 16/03/2016 13:22, Cornelia Huck wrote:
> >>>>> Yeah, it doesn't h
On Wed, 16 Mar 2016 14:10:29 +0100
Paolo Bonzini wrote:
> On 16/03/2016 14:04, Cornelia Huck wrote:
> > > No, it would not. ioeventfd=off,vhost=on would mean: "when vhost is
> > > off, use vCPU thread notification".
> >
> > *confused*
> >
>
On Wed, 16 Mar 2016 12:09:02 +0100
Paolo Bonzini wrote:
> On 16/03/2016 11:49, Christian Borntraeger wrote:
> > #3 0x800b713e in virtio_blk_data_plane_start (s=0xba232d80) at
> > /home/cborntra/REPOS/qemu/hw/block/dataplane/virtio-blk.c:224
> > #4 0x800b4ea0 in virtio_blk_hand
On Wed, 16 Mar 2016 12:48:22 +0100
Paolo Bonzini wrote:
>
>
> On 16/03/2016 12:32, Cornelia Huck wrote:
> > On Wed, 16 Mar 2016 12:09:02 +0100
> > Paolo Bonzini wrote:
> >
> >> On 16/03/2016 11:49, Christian Borntraeger wrote:
> >
> >>>
On Wed, 16 Mar 2016 12:59:37 +0100
Paolo Bonzini wrote:
> On 16/03/2016 12:56, Cornelia Huck wrote:
> > On Wed, 16 Mar 2016 12:48:22 +0100
> > Paolo Bonzini wrote:
> >
> >>
> >>
> >> On 16/03/2016 12:32, Cornelia Huck wrote:
> >>> O
On Wed, 16 Mar 2016 13:32:59 +0100
Paolo Bonzini wrote:
> On 16/03/2016 13:22, Cornelia Huck wrote:
> >> > Yeah, it doesn't help that the functions are underdocumented (as in the
> >> > "assign" parameter above).
> > My understanding is:
>
On Thu, 17 Mar 2016 13:39:18 +0100
Christian Borntraeger wrote:
> On 03/17/2016 01:22 PM, tu bo wrote:
> >
> > On 03/16/2016 09:38 PM, Christian Borntraeger wrote:
> >> On 03/16/2016 01:55 PM, Paolo Bonzini wrote:
> >>>
> >>>
> >>> On 16/03/2016 12:24, Christian Borntraeger wrote:
> On 03/1
On Wed, 16 Mar 2016 12:32:13 +0100
Cornelia Huck wrote:
> On Wed, 16 Mar 2016 12:09:02 +0100
> Paolo Bonzini wrote:
>
> > On 16/03/2016 11:49, Christian Borntraeger wrote:
>
> > > #3 0x800b713e in virtio_blk_data_plane_start (s=0xba232d80) at
> > >
On Mon, 21 Mar 2016 18:57:18 +0800
Fam Zheng wrote:
> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index 08275a9..47f8043 100644
> --- a/hw/virtio/virtio.c
> +++ b/hw/virtio/virtio.c
> @@ -1098,7 +1098,14 @@ void virtio_queue_notify_vq(VirtQueue *vq)
>
> void virtio_queue_notify(VirtI
On Mon, 21 Mar 2016 17:42:06 +0800
Fam Zheng wrote:
> On Fri, 03/18 16:03, Paolo Bonzini wrote:
> >
> >
> > On 17/03/2016 17:08, Christian Borntraeger wrote:
> > > Good (or bad?) news is the assert also triggers on F23, it just seems
> > > to take longer.
> >
> > I guess good news, because we can
On Mon, 21 Mar 2016 20:45:27 +0800
Fam Zheng wrote:
> On Mon, 03/21 12:15, Cornelia Huck wrote:
> > On Mon, 21 Mar 2016 18:57:18 +0800
> > Fam Zheng wrote:
> >
> > > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> > > index 08275a9..47f804
On Mon, 21 Mar 2016 14:54:04 +0100
Paolo Bonzini wrote:
> On 21/03/2016 14:47, TU BO wrote:
> >> I'll see if I can produce something based on Conny's patches, which are
> >> already a start. Today I had a short day so I couldn't play with the
> >> bug; out of curiosity, does the bug reproduce wi
On Tue, 22 Mar 2016 07:45:19 +0800
Fam Zheng wrote:
> On Mon, 03/21 14:02, Cornelia Huck wrote:
> > On Mon, 21 Mar 2016 20:45:27 +0800
> > Fam Zheng wrote:
> >
> > > On Mon, 03/21 12:15, Cornelia Huck wrote:
> > > > On Mon, 21 Mar 20
(re-adding cc:s)
On Tue, 22 Mar 2016 15:18:05 +0800
Fam Zheng wrote:
> On Tue, 03/22 15:10, tu bo wrote:
> > Hi Fam:
> >
> > On 03/21/2016 06:57 PM, Fam Zheng wrote:
> > >On Thu, 03/17 19:03, tu bo wrote:
> > >>
> > >>On 03/17/2016 08:39 AM, Fam Zheng wrote:
> > >>>On Wed, 03/16 14:45, Paolo Bo
On Tue, 22 Mar 2016 10:46:58 +0100
Paolo Bonzini wrote:
> On 22/03/2016 10:07, Cornelia Huck wrote:
> > So far, we had the best results with my refactoring + the mutex/bh
> > change. Two problems:
> >
> > - We don't really understand yet why my refactoring h
On Tue, 22 Mar 2016 13:11:05 +0100
Paolo Bonzini wrote:
> On 22/03/2016 12:59, Cornelia Huck wrote:
> >> > They can be fixed with just an extra object_ref/object_unref.
> >> >
> >> > I didn't understand that Tu Bo also needed the BH fix, and with that
On Tue, 22 Mar 2016 19:05:09 +0100
Paolo Bonzini wrote:
> On 22/03/2016 13:52, Fam Zheng wrote:
> >> You're right. After unrealizing virtio_blk_data_plane_stop has set of
> >> vblk->dataplane_started = false, so that's covered. However, you still
> >> need an object_ref/object_object_unref pair
On Thu, 24 Mar 2016 16:19:41 +0800
tu bo wrote:
> Hi Christian:
>
> On 03/23/2016 05:12 PM, Christian Borntraeger wrote:
> > On 03/23/2016 10:08 AM, Paolo Bonzini wrote:
> >>
> >>
> >> On 23/03/2016 09:10, Cornelia Huck wrote:
> >>>> -
On Thu, 24 Mar 2016 09:32:30 +0100
Cornelia Huck wrote:
> I'll re-send my patches with some added interface doc in patch 1. Stay
> tuned.
Grr. Unfortunately, this fails for _me_ now (-EEXIST after reboot).
Debugging.
On Thu, 24 Mar 2016 09:47:56 +0100
Cornelia Huck wrote:
> On Thu, 24 Mar 2016 09:32:30 +0100
> Cornelia Huck wrote:
>
> > I'll re-send my patches with some added interface doc in patch 1. Stay
> > tuned.
>
> Grr. Unfortunately, this fails for _me_ now (-E
On Sun, 3 Apr 2016 23:13:28 +0200
Paolo Bonzini wrote:
> On 03/04/2016 21:59, Christian Borntraeger wrote:
> > Thread 1 (Thread 0x3ffad25bb90 (LWP 41685)):
> > ---Type to continue, or q to quit---
> > #0 0x03ffab5be2c0 in raise () at /lib64/libc.so.6
> > #1 0x03ffab5bfc26 in abort ()
On Mon, 4 Apr 2016 10:19:42 +0200
Paolo Bonzini wrote:
> On 04/04/2016 10:10, Cornelia Huck wrote:
> > > This will be fixed by Cornelia's rework, and is an example of why I
> > > think patch 1/9 is a good idea (IOW, assign=false is harmful).
> >
> > So
On Mon, 3 Jul 2017 09:38:36 +0200
QingFeng Hao wrote:
> Do not check kvm_eventfds_enabled() when KVM is disabled since it
> always returns 0. Since commit
> 8c56c1a592b5092d91da8d8943c1d6462a6f ("memory: emulate
> ioeventfd") it has been possible to use ioeventfds in qtest or TCG
> mode.
>
On Mon, 3 Jul 2017 12:20:03 +0200
Christian Borntraeger wrote:
> On 07/03/2017 10:51 AM, QingFeng Hao wrote:
>
> > diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
> > index a3d00196f4..c37f9c3b9e 100644
> > --- a/target/s390x/kvm.c
> > +++ b/target/s390x/kvm.c
> > @@ -2220,6 +2220,9 @@ int k
uint32_t sch_id, int vq,
>bool assign)
> {
> -return kvm_s390_assign_subch_ioeventfd(notifier, sch_id, vq, assign);
> + if (kvm_enabled()) {
> +return kvm_s390_assign_subch_ioeventfd(notifier, sch_id, vq, assign);
> +} else {
> +return 0;
> +}
> }
>
> static inline void s390_crypto_reset(void)
Reviewed-by: Cornelia Huck
On Mon, 13 Jul 2015 11:56:51 +0200
Kevin Wolf wrote:
> Am 13.07.2015 um 11:00 hat Jason Wang geschrieben:
> >
> >
> > On 07/13/2015 03:46 PM, Michael S. Tsirkin wrote:
> > > On Mon, Jul 13, 2015 at 01:46:48PM +0800, Jason Wang wrote:
> > >> VIRTIO_BLK_F_SCSI was no longer supported in 1.0. So d
On Mon, 13 Jul 2015 15:22:52 +0300
"Michael S. Tsirkin" wrote:
> On Mon, Jul 13, 2015 at 01:51:56PM +0200, Cornelia Huck wrote:
> > On Mon, 13 Jul 2015 11:56:51 +0200
> > Kevin Wolf wrote:
> >
> > > Am 13.07.2015 um 11:00 hat Jason Wang geschrieben:
&g
On Mon, 13 Jul 2015 15:36:00 +0300
"Michael S. Tsirkin" wrote:
> On Mon, Jul 13, 2015 at 02:30:24PM +0200, Cornelia Huck wrote:
> > On Mon, 13 Jul 2015 15:22:52 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Mon, Jul 13, 2015 at 01:51:56PM
On Mon, 13 Jul 2015 16:34:30 +0200
Paolo Bonzini wrote:
>
>
> On 13/07/2015 15:20, Cornelia Huck wrote:
> > This would imply that any transitional device cannot offer scsi,
> > doesn't it?
> >
> > We have two layers interacting here: virtio-blk which may
On Mon, 13 Jul 2015 18:35:53 +0300
"Michael S. Tsirkin" wrote:
> On Mon, Jul 13, 2015 at 03:20:59PM +0200, Cornelia Huck wrote:
> > On Mon, 13 Jul 2015 15:36:00 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Mon, Jul 13, 2015 at 02:30:24PM
On Wed, 15 Jul 2015 13:59:00 +0300
"Michael S. Tsirkin" wrote:
> On Tue, Jul 14, 2015 at 07:43:44PM +0200, Cornelia Huck wrote:
> > > Yes, and that's because as written, transitional devices must set
> > > ANY_LAYOUT, but that's incompatible with scs
On Wed, 15 Jul 2015 15:01:01 +0300
"Michael S. Tsirkin" wrote:
> On Wed, Jul 15, 2015 at 01:46:38PM +0200, Cornelia Huck wrote:
> > On Wed, 15 Jul 2015 13:59:00 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Tue, Jul 14, 2015 at 07:43:4
On Wed, 15 Jul 2015 16:16:07 +0300
"Michael S. Tsirkin" wrote:
> On Wed, Jul 15, 2015 at 02:43:51PM +0200, Cornelia Huck wrote:
> > On Wed, 15 Jul 2015 15:01:01 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Wed, Jul 15, 2015 at 01:46:38PM
On Wed, 15 Jul 2015 17:11:57 +0300
"Michael S. Tsirkin" wrote:
> > > > > Fine, but revision is negotiated way before features are
> > > > > probed so why does it make a practical difference?
> > > >
> > > > Legacy drivers (that don't know about the set-revision command) will
> > > > read feature
On Wed, 15 Jul 2015 17:39:18 +0300
"Michael S. Tsirkin" wrote:
> On Wed, Jul 15, 2015 at 04:30:51PM +0200, Cornelia Huck wrote:
> > On Wed, 15 Jul 2015 17:11:57 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > > > > > Fine, but revis
On Wed, 15 Jul 2015 21:51:32 +0300
"Michael S. Tsirkin" wrote:
> On Wed, Jul 15, 2015 at 05:38:53PM +0200, Cornelia Huck wrote:
> > On Wed, 15 Jul 2015 17:39:18 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Wed, Jul 15, 2015 at 04:30:51PM
On Thu, 16 Jul 2015 19:22:21 +0200
Paolo Bonzini wrote:
>
>
> On 16/07/2015 14:47, Michael S. Tsirkin wrote:
> > I think for 2.4 it's a good idea to avoid enabling modern interface
> > by default. Therefore, for 2.4 we can keep scsi enabled unless modern
> > is requested by user.
>
> I agree.
On Wed, 22 Jul 2015 12:36:22 +0300
"Michael S. Tsirkin" wrote:
> Virtio 1 requires this, and all devices are clean by now,
> so let's do it!
>
> Exceptions:
> - virtio-blk
> - compat machine types
>
> Signed-off-by: Michael S. Tsirkin
> ---
>
> Untested - consider this pseudo-code - i
On Mon, 27 Jul 2015 14:22:37 +0300
"Michael S. Tsirkin" wrote:
> On Mon, Jul 27, 2015 at 12:30:19PM +0200, Paolo Bonzini wrote:
> >
> >
> > On 27/07/2015 11:49, Jason Wang wrote:
> > > So this patch only clear VIRTIO_F_LAYOUT for legacy device.
> > >
> > > Cc: Stefan Hajnoczi
> > > Cc: Kevin
| 1 -
> hw/virtio/virtio-pci.c | 1 -
> hw/xen/xen_devconfig.c | 1 -
> hw/xtensa/xtfpga.c | 1 -
> 38 files changed, 39 deletions(-)
Acked-by: Cornelia Huck
k/m25p80.c | 1 -
> hw/block/onenand.c | 1 -
> hw/i386/xen/xen-mapcache.c | 1 -
> hw/s390x/virtio-ccw.c | 1 -
> hw/scsi/scsi-generic.c | 1 -
> hw/sd/sdhci.c | 1 -
> hw/usb/dev-storage.c | 1 -
> monitor.c | 1 -
> 8 files changed, 8 deletions(-)
Acked-by: Cornelia Huck
On Sun, 10 Jun 2018 22:14:21 -0300
Philippe Mathieu-Daudé wrote:
> Hi,
>
> This series:
>
> - split the byte-based definitions from "qemu/cutils.h" to "qemu/units.h"
> (this now triggers WARNING: 1 added file, does MAINTAINERS need updating?)
> - clean hw/ includes;
> - replace different cons
e the FIXME comment from
> the ones that are really supposed to be user-creatable. This is
> being done in separate patches because we still don't have an
> obvious list of devices that will be whitelisted by q35, and I
> would like to get each device reviewed individually.
>
>
On Fri, 5 May 2017 17:36:20 -0300
Eduardo Habkost wrote:
> Fixup will be included in v3, or can be applied by maintainer:
>
> Signed-off-by: Eduardo Habkost
> ---
> hw/core/sysbus.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/core/sysbus.c b/hw/core/sys
| 4 +---
> hw/ide/qdev.c | 4 +---
> hw/net/ne2000-isa.c | 4 +---
> hw/s390x/virtio-ccw.c | 28
> +++
For virtio-ccw:
Acked-by: Cornelia Huck
--
> hw/s390x/s390-virtio-ccw.c| 5 +
> hw/s390x/virtio-ccw.c | 28 +++-
For the two virtio-ccw files:
Acked-by: Cornelia Huck
> scripts/coccinelle/remove_local_err.cocci | 27 +++
> target-i
On Wed, 29 Jun 2016 13:37:15 +0200
Marc-André Lureau wrote:
> Hi
>
> On Fri, Jun 24, 2016 at 7:55 AM, Michael S. Tsirkin wrote:
> > From: Cornelia Huck
> >
> > Have vhost and dataplane use the new api for transports that
> > have been converted.
>
On Tue, 30 Aug 2016 11:06:50 +0800
Jason Wang wrote:
> Currently, all virtio devices bypass IOMMU completely. This is because
> address_space_memory is assumed and used during DMA emulation. This
> patch converts the virtio core API to use DMA API. This idea is
>
> - introducing a new transport
On Tue, 30 Aug 2016 13:21:23 +0300
"Michael S. Tsirkin" wrote:
> BTW downstreams are building with --disable-qom-cast-debug which drops
> all QOM casts on data path - one way is to say we just make this the
> default upstream as well. Another to say that we want to distinguish
> fast path calls f
On Tue, 30 Aug 2016 14:15:14 +0300
"Michael S. Tsirkin" wrote:
> On Tue, Aug 30, 2016 at 01:11:05PM +0200, Cornelia Huck wrote:
> > On Tue, 30 Aug 2016 13:21:23 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > BTW downstreams are building with
On Tue, 3 Jul 2018 13:32:29 +0200
Kevin Wolf wrote:
> > > > Has serial/gemoetry been fixed meanwhile and will it make it into the
> > > > next release?
> > >
> > > I cannot find an archive that has it, but it is on the libvirt mailing
> > > list as "[libvirt] [PATCH v3] qemu: format serial and
On Wed, 4 Jul 2018 15:34:40 +0200
Kevin Wolf wrote:
> Am 04.07.2018 um 15:02 hat Cornelia Huck geschrieben:
> > On Tue, 3 Jul 2018 13:32:29 +0200
> > Kevin Wolf wrote:
> >
> > > > > > Has serial/gemoetry been fixed meanwhile and will it make it into
&
On Wed, 4 Jul 2018 17:14:02 +0100
Peter Maydell wrote:
> On 4 July 2018 at 14:34, Kevin Wolf wrote:
> > Essentially, what is important to me isn't getting these options dropped
> > exactly in 3.0, but not setting a bad precedence that deprecation isn't
> > actually worth anything. We may easily
let's hold off removing the deprecated options for one more QEMU
release.
Reported-by: Christian Borntraeger
Signed-off-by: Cornelia Huck
---
blockdev.c | 12
1 file changed, 12 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 72f5347df5..37eb40670b 100644
--- a/b
evert the removal patches for 3.0; with 3.1, the then
released libvirt versions will be fine. While nobody complained about
the 'addr' option, it is reinstated again as well, but purely to make
all the reverts apply cleanly.
Cornelia Huck (4):
Revert "block: Remove dead depr
This reverts commit b0083267444a5e0f28391f6c2831a539f878d424.
Hold off removing this for one more QEMU release (current libvirt
release still uses it.)
Signed-off-by: Cornelia Huck
---
block/block-backend.c | 1 +
blockdev.c| 10 ++
hw/block/block.c | 13
This reverts commit eae3bd1eb7c6b105d30ec06008b3bc3dfc5f45bb.
Reverted to avoid conflicts for geometry options revert.
Signed-off-by: Cornelia Huck
---
blockdev.c| 17 -
device-hotplug.c | 4
include/sysemu/blockdev.h | 1 +
qemu-doc.texi
This reverts commit a7aff6dd10b16b67e8b142d0c94c5d92c3fe88f6.
Hold off removing this for one more QEMU release (current libvirt
release still uses it.)
Signed-off-by: Cornelia Huck
---
blockdev.c| 75 ++-
hmp-commands.hx
On Mon, 09 Jul 2018 08:33:05 +0200
Markus Armbruster wrote:
> Peter Maydell writes:
>
> > On 6 July 2018 at 15:56, Kevin Wolf wrote:
> >> Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben:
> >>> That way, we can still easily remove old cruft (case
On Mon, 9 Jul 2018 08:58:05 +0200
Thomas Huth wrote:
> On 06.07.2018 13:11, Cornelia Huck wrote:
> > On Wed, 4 Jul 2018 17:14:02 +0100
> > Peter Maydell wrote:
> >
> >> On 4 July 2018 at 14:34, Kevin Wolf wrote:
> >>> Essentially, what is i
Hi,
I recently noticed that iotest 147 was hanging on my laptop, but worked
fine on my s390x LPAR. Turned out that the architecture was a red
herring; on both platforms, things fail with the 'simple' trace backend
and work with e.g. the 'log' trace backend. Some details on the
failures with the 's
On Tue, 10 Jul 2018 07:59:15 +0200
Markus Armbruster wrote:
> In addition to actively pulling libvirt developers into review of
> deprecation patches, we should pursue the idea to optionally let QEMU
> fail on use of deprecated features, then have libvirt run its test suite
> that way.
What abou
On Tue, 10 Jul 2018 16:39:31 +0200
Peter Krempa wrote:
> On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote:
> > On Tue, 10 Jul 2018 07:59:15 +0200
> > Markus Armbruster wrote:
> >
> > > In addition to actively pulling libvirt developers into review of
On Wed, 11 Jul 2018 08:53:20 +0200
Thomas Huth wrote:
> On 10.07.2018 17:24, Peter Krempa wrote:
> > On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote:
> >> So, from that I gather that a hard failure would be the easiest for
> >> libvirt to detect (and e
On Wed, 11 Jul 2018 14:06:17 +0100
Stefan Hajnoczi wrote:
> On Mon, Jul 09, 2018 at 03:45:49PM +0200, Cornelia Huck wrote:
> > Hi,
> >
> > I recently noticed that iotest 147 was hanging on my laptop, but worked
> > fine on my s390x LPAR. Turned out that the archite
On Wed, 11 Jul 2018 15:15:45 +0200
Cornelia Huck wrote:
> On Wed, 11 Jul 2018 14:06:17 +0100
> Stefan Hajnoczi wrote:
>
> > On Mon, Jul 09, 2018 at 03:45:49PM +0200, Cornelia Huck wrote:
> > > Hi,
> > >
> > > I recently noticed that iotest 147 was h
On Thu, 12 Jul 2018 08:51:16 +0200
Markus Armbruster wrote:
> Markus Armbruster writes:
>
> > Kevin Wolf writes:
> >
> >> Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben:
> >>> On Tue, 10 Jul 2018 07:59:15 +0200
> >>> Markus Armbrust
On Thu, 12 Jul 2018 17:47:00 +0200
Thomas Huth wrote:
> On 12.07.2018 08:32, Markus Armbruster wrote:
> > Daniel P. Berrangé writes:
> [...]
> >> For libvirt, I think whenever something is proposed for deprecation
> >> we could just CC libvir-list, or ask one of the libvirt people to
> >> conf
@@ -58,7 +58,7 @@
> if (DEBUG_KVM) { \
> fprintf(stderr, fmt, ## __VA_ARGS__); \
> } \
> -} while (0);
> +} while (0)
>
> #define kvm_vm_check_mem_attr(s, attr) \
> kvm_vm_check_attr(s, KVM_S390_VM_MEM_CTRL, attr)
Acked-by: Cornelia Huck
On Wed, 20 Dec 2017 11:16:46 +0100
Markus Armbruster wrote:
> Jan Dakinevich writes:
>
> > On Tue, 19 Dec 2017 15:57:18 +0100
> > Markus Armbruster wrote:
> >> Jan Dakinevich writes:
> Taking a step back: what's the intended purpose of query-virtio? The
> cover letter doesn't really say:
>
On Mon, 29 Jul 2019 16:56:21 +0200
Damien Hedde wrote:
(...)
> 2. old's device_reset
>
> There was a few call to this function, I renamed it *device_legacy_reset* to
> handle the transition. This function allowed to reset only a given device
> (and not its eventual qbus subtree). This behavior
On Mon, 29 Jul 2019 16:56:22 +0200
Damien Hedde wrote:
(...)
> +/*
> + * ResettableClass:
> + * Interface for resettable objects.
> + *
> + * The reset operation is divided in several phases each represented by a
> + * method.
> + *
> + * Each Ressetable must maintain a reset counter in its stat
On Tue, 30 Jul 2019 14:44:21 +0100
Peter Maydell wrote:
> On Tue, 30 Jul 2019 at 14:42, Cornelia Huck wrote:
> >
> > On Mon, 29 Jul 2019 16:56:22 +0200
> > Damien Hedde wrote:
> >
> > (...)
> >
> > > +/*
> > > + * Re
On Tue, 30 Jul 2019 16:08:59 +0200
Damien Hedde wrote:
> On 7/30/19 3:59 PM, Peter Maydell wrote:
> > On Tue, 30 Jul 2019 at 14:56, Cornelia Huck wrote:
> >>
> >> On Tue, 30 Jul 2019 14:44:21 +0100
> >> Peter Maydell wrote:
> >>
> >&g
On Wed, 7 Aug 2019 16:24:30 +0100
Peter Maydell wrote:
> On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote:
> >
> > Replace deprecated qbus_reset_all by resettable_reset_cold_fn for
> > the ipl registration in the main reset handlers.
> >
> > This does not impact the behavior.
> >
> > Signed-off-
On Mon, 29 Jul 2019 16:56:35 +0200
Damien Hedde wrote:
> Replace deprecated qdev_reset_all by device_reset_warm.
>
> This does not impact the behavior.
Not so sure about that; see below.
>
> Signed-off-by: Damien Hedde
> ---
> hw/s390x/s390-virtio-ccw.c | 2 +-
> 1 file changed, 1 insertion
On Mon, 29 Jul 2019 16:56:47 +0200
Damien Hedde wrote:
> Replace S390PCIBusDevice legacy reset by device_reset_warm.
>
> The new function propagates also the reset to the sub-buses tree.
> I'm not sure whether S390PCIBusDevice has bus children or not.
This should be fine, I think.
>
> Signed-
1 - 100 of 195 matches
Mail list logo
