Re: [Qemu-block] [PATCH] migration: flush the bdrv before stopping VM

Li, Liang Z liang.z...@intel.com wrote: Right now, we don't have an interface to detect that cases and got back to the iterative stage. How about go back to the iterative stage when detect that the pending_size is larger Than max_size, like this: +/* do flush here

Re: [Qemu-block] [PATCH v12 22/36] qapi: Don't let implicit enum MAX member collide

you have done all the required changes (i.e. I haven't compiled it). Rest of the patch is as trivial as the commit log explains, so Reviewed-by: Juan Quintela <quint...@redhat.com> Thanks, Juan.

Re: [Qemu-block] [PATCH 07/17] qapi: add dirty-bitmaps migration capability

Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> wrote: > Reviewed-by: John Snow <js...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> Reviewed-by: Juan Quintela <quint...@redhat.com>

Re: [Qemu-block] [PATCH 04/17] migration: introduce postcopy-only pending

just out of control, this paramenters need to move to one struct, but as the code was already ugly, I will not put the burden on you O:-) But you need to document what means each of the new fields, please O:-) I really think that doing the rename of the fields in one patch, and then add the res_com

Re: [Qemu-block] [PATCH 03/17] migration: split common postcopy out of ram postcopy

mand_send(f, MIG_CMD_POSTCOPY_ADVISE, > + 16, (uint8_t *)tmp); > +} else { > +qemu_savevm_command_send(f, MIG_CMD_POSTCOPY_ADVISE, 0, NULL); > +} > } > > /* Sent prior to starting the destination running in postcopy, discard pages I haven't yet figured out why you are reusing this command with a different number of parameters. For this to pass, I need that Dave comment on this. So, Reviewed-by: Juan Quintela <quint...@redhat.com> conditioned that Dave agrees with this.

Re: [Qemu-block] [PATCH 11/17] migration: add is_active_iterate handler

>ops->is_active_iterate) { > +if (!se->ops->is_active_iterate(se->opaque)) { > +continue; > +} > +} > /* > * In the postcopy phase, any device that doesn't know how to > * do postcopy should have saved it's state in the _complete Reviewed-by: Juan

Re: [Qemu-block] [PATCH 12/17] migration: add postcopy migration of dirty bitmaps

ement...@virtuozzo.com> > diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c > new file mode 100644 > index 000..28e3732 I only did a fast look at this file, nothing obvious is wrong, but it was quick O:-) So Reviewed-by: Juan Quintela <quint...@redhat.com>

Re: [Qemu-block] ping2 Re: [PATCH v4 00/17] Dirty bitmaps postcopy migration

John Snow wrote: > I'm really sorry, but I personally don't have the time to review this > until February 6th. > > Juan, David, does this look all-ok from your end? Are we just waiting > for block reviews at this point? I think that I reviewed everything missed for the

Re: [Qemu-block] [PATCH 10/17] migration/qemu-file: add qemu_put_counted_string()

byte. > > Reviewed-by: John Snow <js...@redhat.com> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> Reviewed-by: Juan Quintela <quint...@redhat.com>

Re: [Qemu-block] [PATCH 09/17] migration: include migrate_dirty_bitmaps in migrate_postcopy

Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> wrote: > Enable postcopy if dirty bitmap migration is endabled. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> Reviewed-by: Juan Quintela <quint...@redhat.com>

Re: [Qemu-block] ping Re: [PATCH 00/18] Dirty bitmaps postcopy migration

"Denis V. Lunev" wrote: > On 11/02/2016 02:13 PM, Stefan Hajnoczi wrote: >> On Tue, Oct 25, 2016 at 04:04:35PM +0300, Vladimir Sementsov-Ogievskiy wrote: >>> ping >>> >>> For now there are some notes mostly about accessory patches. What about >>> migration itself? Is it ok? Has

Re: [Qemu-block] [PATCH 02/18] migration: fix ram_save_pending

ending. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> Reviewed-by: Juan Quintela <quint...@redhat.com>

Re: [Qemu-block] [PATCH 12/18] migration: add postcopy migration of dirty bitmaps

Vladimir Sementsov-Ogievskiy wrote: > Postcopy migration of dirty bitmaps. Only named dirty bitmaps, > associated with root nodes and non-root named nodes are migrated. > > If destination qemu is already containing a dirty bitmap with the same name > as a migrated bitmap

Re: [Qemu-block] [PATCH 03/18] migration: split common postcopy out of ram postcopy

Vladimir Sementsov-Ogievskiy wrote: > Split common postcopy staff from ram postcopy staff. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > diff --git a/migration/savevm.c b/migration/savevm.c > index d2efeeb..cce542f 100644 > ---

Re: [Qemu-block] [PATCH 04/18] migration: introduce postcopy-only pending

Vladimir Sementsov-Ogievskiy wrote: > There would be savevm states (dirty-bitmap) which can migrate only in > postcopy stage. The corresponding pending is introduced here. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

Re: [Qemu-block] [RFC] migration/block:limit the time used for block migration

Lidong Chen wrote: > when migration with quick speed, mig_save_device_bulk invoke > bdrv_is_allocated too frequently, and cause vnc reponse slowly. > this patch limit the time used for bdrv_is_allocated. > > Signed-off-by: Lidong Chen > --- >

Re: [Qemu-block] [RFC] migration/block:limit the time used for block migration

858585 jemmy <jemmy858...@gmail.com> wrote: > On Tue, Mar 28, 2017 at 5:47 PM, Juan Quintela <quint...@redhat.com> wrote: >> Lidong Chen <jemmy858...@gmail.com> wrote: >>> when migration with quick speed, mig_save_device_bulk invoke >>> bdrv_is_al

Re: [Qemu-block] [PATCH v1 1/1] vmstate: fix failed iotests case 68 and 91

QingFeng Hao wrote: > This problem affects s390x only if we are running without KVM. > Basically, S390CPU.irqstate is unused if we do not use KVM, > and thus no buffer is allocated. > This causes size=0, first_elem=NULL and n_elems=1 in > vmstate_load_state and

Re: [Qemu-block] [PATCH v2] migration/block: Avoid invoking blk_drain too frequently

Fam Zheng wrote: > On Wed, 03/15 17:31, Dr. David Alan Gilbert wrote: >> * Fam Zheng (f...@redhat.com) wrote: >> > On Wed, 03/15 11:37, Lidong Chen wrote: >> > > Increase bmds->cur_dirty after submit io, so reduce the frequency >> > > involve into blk_drain, and improve the

Re: [Qemu-block] migrate -b problems

Kevin Wolf wrote: > Hi all, Hi > after getting assertion failure reports for block migration in the last > minute, we just hacked around it by commenting out op blocker assertions > for the 2.9 release, but now we need to see how to fix things properly. > Luckily,

Re: [Qemu-block] migrate -b problems

"Dr. David Alan Gilbert" wrote: > * Kevin Wolf (kw...@redhat.com) wrote: >> Am 18.04.2017 um 16:47 hat Stefan Hajnoczi geschrieben: >> > On Wed, Apr 12, 2017 at 11:18:19AM +0200, Kevin Wolf wrote: >> > > after getting assertion failure reports for block migration in the last

Re: [Qemu-block] [PATCH 05/29] block: use QEMU_IS_ALIGNED macro

Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Juan Quintela <quint...@redhat.com>

Re: [Qemu-block] [PATCH 06/29] migration/block: use QEMU_IS_ALIGNED macro

uster_size)) { > cluster_size = bdi.cluster_size; > } else { > cluster_size = BLOCK_SIZE; Reviewed-by: Juan Quintela <quint...@redhat.com> Should I take this patch, or does it go through the block layer? Your call. Later, Juan.

Re: [Qemu-block] [PATCH v3 18/20] block: Make bdrv_is_allocated() byte-based

l offset. > > For ease of review, bdrv_is_allocated_above() will be tackled > separately. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> Reviewed-by: Juan Quintela <quint...@redhat.com>

Re: [Qemu-block] [RFC PATCH 15/56] migration: Make XBZRLE cache size unsigned in QAPI/QMP

rate_cache_size". HMP's "info migrate" already > reported the cache size correctly, because it printed the signed > integer with PRIu32. > Reviewed-by: Juan Quintela <quint...@redhat.com> > diff --git a/qapi-schema.json b/qapi-schema.json > index c8cceb9..ec

Re: [Qemu-block] [RFC PATCH 16/56] migration: Make XBZRLE transferred size unsigned in QAPI/QMP

> printed the signed integer with PRIu64. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Juan Quintela <quint...@redhat.com>

Re: [Qemu-block] [PATCH v2 09/12] dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes

; sub-sector requests. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> Reviewed-by: Juan Quintela <quint...@redhat.com> > + > assert(bdrv_dirty_bitmap_enabled(bitmap)); > -hbitmap_set(bitmap->bi

Re: [Qemu-block] [PATCH v2 08/12] dirty-bitmap: Change bdrv_get_dirty() to take bytes

d-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> Reviewed-by: Juan Quintela <quint...@redhat.com>

Re: [Qemu-block] [PATCH v2 07/12] dirty-bitmap: Change bdrv_get_dirty_count() to report bytes

Eric Blake <ebl...@redhat.com> wrote: > Thanks to recent cleanups, all callers were scaling a return value > of sectors into bytes; do the scaling internally instead. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> >

Re: [Qemu-block] [PATCH 1/4] block: Fix anonymous BBs in blk_root_inactivate()

Kevin Wolf <kw...@redhat.com> wrote: > blk->name isn't an array, but a pointer that can be NULL. Checking for > an anonymous BB must involve a NULL check first, otherwise we get > crashes. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Juan Quintela <quint...@redhat.com>

Re: [Qemu-block] [PATCH 2/4] migration: Inactivate images after .save_live_complete_precopy()

re is still a non-device BlockBackend using it, which includes the > BBs used by block migration. We want to give block migration a chance to > release the BBs before trying to inactivate the image (this will be done > in another patch). > > Signed-off-by: Kevin Wolf <kw...@redh

Re: [Qemu-block] [PULL 0/2] Block patches

Jeff Cody wrote: > On Wed, Jun 14, 2017 at 03:26:52PM -0700, no-re...@patchew.org wrote: >> Hi, >> >> This series failed automatic build test. Please find the testing commands and >> their output below. If you have docker installed, you can probably reproduce >> it >> locally.

Re: [Qemu-block] [PATCH] util: remove the obsolete non-blocking connect

ould > use the QIOChannel code, so we can drop NonBlockingConnectHandler Reviewed-by: Juan Quintela <quint...@redhat.com> ... > int inet_connect_saddr(InetSocketAddress *saddr, > - NonBlockingConnectHandler *callback, void *opaque, > Error **errp);

Re: [Qemu-block] [PATCH v2 1/1] qemu/migration: fix the double free problem on from_src_file

Kevin Wolf wrote: > Am 06.06.2017 um 07:24 hat QingFeng Hao geschrieben: >> In load_snapshot, mis->from_src_file is freed twice, the first free is by >> qemu_fclose, the second is by migration_incoming_state_destroy and >> it causes Illegal instruction exception. The fix is just

Re: [Qemu-block] ping Re: [PATCH v7 03/16] migration: split common postcopy out of ram postcopy

"Dr. David Alan Gilbert" wrote: > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: >> ping for 1-3 >> Can we merge them? > > I see all of them have R-b's; so lets try and put them in the next > migration merge. > > Quintela: Sound good? Yeap. Later, Juan.

Re: [Qemu-block] [PATCH] block: Cleanup BMDS in bdrv_close_all

...@nongnu.org > Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Juan Quintela <quint...@redhat.com> This stub stuff is crazy. Fam, you were right (a.k.a. I was wrong). Sorry, Juan.

Re: [Qemu-block] [PATCH] block: Cleanup BMDS in bdrv_close_all

Fam Zheng <f...@redhat.com> wrote: > On Wed, 08/30 13:49, Juan Quintela wrote: >> Fam Zheng <f...@redhat.com> wrote: >> > This fixes the assertion due to op blockers added by BMDS: >> > >> > block.c:3248: bdrv_delete: Assertion `bdrv_op_blocker_is

Re: [Qemu-block] [PATCH] block: Cleanup BMDS in bdrv_close_all

Fam Zheng wrote: > This fixes the assertion due to op blockers added by BMDS: > > block.c:3248: bdrv_delete: Assertion `bdrv_op_blocker_is_empty(bs)' failed. > > Reproducer: simply start block migration and quit QEMU before it ends. > > Cc: qemu-sta...@nongnu.org > Signed-off-by:

Re: [Qemu-block] [PATCH] block: Cleanup BMDS in bdrv_close_all

Kevin Wolf wrote: > Am 05.09.2017 um 10:54 hat Fam Zheng geschrieben: >> On Tue, 09/05 10:44, Kevin Wolf wrote: >> > Am 30.08.2017 um 12:06 hat Fam Zheng geschrieben: >> > > This fixes the assertion due to op blockers added by BMDS: >> > > >> > > block.c:3248: bdrv_delete:

Re: [Qemu-block] [PATCH v2 6/7] maint: Fix macros with broken 'do/while(0); ' usage

ornelia Huck <coh...@redhat.com> > Reviewed-by: Michael S. Tsirkin <m...@redhat.com> > Acked-by: Dr. David Alan Gilbert <dgilb...@redhat.com> Reviewed-by: Juan Quintela <quint...@redhat.com>

Re: [Qemu-block] [PATCH v3 01/46] Replace all occurances of __FUNCTION__ with __func__

> > Cc: Aurelien Jarno <aurel...@aurel32.net> > Cc: Yongbok Kim <yongbok@imgtec.com> > Cc: Peter Crosthwaite <crosthwaite.pe...@gmail.com> > Cc: Stefan Hajnoczi <stefa...@redhat.com> > Cc: Fam Zheng <f...@redhat.com> > Cc: Juan Quintela <quint...@redha

Re: [Qemu-block] [PATCH 16/67] migration: use local path for local headers

"Michael S. Tsirkin" wrote: > When pulling in headers that are in the same directory as C file (as > opposed to one in include/), we should use its relative path, without a > directory. Directory based path works more or less by accident. No, it is not by accident.

Re: [Qemu-block] [PATCH 16/67] migration: use local path for local headers

Eric Blake <ebl...@redhat.com> wrote: > On 05/08/2018 07:21 AM, Juan Quintela wrote: >> "Michael S. Tsirkin" <m...@redhat.com> wrote: >>> When pulling in headers that are in the same directory as C file (as >>> opposed to one in include/), we shou

Re: [Qemu-block] [PATCH 2/2] qemu-iotests: Remove MIG_SOCKET from non-migration tests

Kevin Wolf <kw...@redhat.com> wrote: > 185 and 191 define a MIG_SOCKET even though they don't do anything with > migration. Remove the useless variable. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Juan Quintela <quint...@redhat.com>

Re: [Qemu-block] [PATCH 1/2] qemu-iotests: Add more tests to "migration" group

Kevin Wolf <kw...@redhat.com> wrote: > grep for "migrate" turns up a few test cases which use migration, but > haven't been in the "migration" group so far. Add them to the group. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Juan Quintela <quint...@redhat.com> Thanks

Re: [Qemu-block] [PATCH v2 15/20] migration: use local path for local headers

't agree with the comment that they work by accident, it is "by-design". But if you want to change the design, I agree with removing "$ROOT" from the default include path. > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> Reviewed-by: Juan Quintela <quint...@redhat.com> Later, Juan.

Re: [Qemu-block] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

"Daniel P. Berrange" wrote: > On Thu, Jan 11, 2018 at 01:23:05PM +, Dr. David Alan Gilbert wrote: >> * Daniel P. Berrange (berra...@redhat.com) wrote: >> > On Thu, Jan 11, 2018 at 01:46:38PM +0100, Max Reitz wrote: >> > > On 2018-01-08 14:52, Eric Blake wrote: >> > > > On

Re: [Qemu-block] [PATCH 4/5] migration/block: limit the number of parallel I/O requests

Peter Lieven wrote: > the current implementation submits up to 512 I/O requests in parallel > which is much to high especially for a background task. > This patch adds a maximum limit of 16 I/O requests that can > be submitted in parallel to avoid monopolizing the I/O device. > >

Re: [Qemu-block] [PATCH 1/5] migration: do not transfer ram during bulk storage migration

p...@kamp.de> > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: Juan Quintela <quint...@redhat.com>

Re: [Qemu-block] [PATCH 2/5] migration/block: reset dirty bitmap before read in bulk phase

Peter Lieven <p...@kamp.de> wrote: > Reset the dirty bitmap before reading to make sure we don't miss > any new data. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Peter Lieven <p...@kamp.de> Reviewed-by: Juan Quintela <quint...@redhat.com>

Re: [Qemu-block] [PATCH 4/5] migration/block: limit the number of parallel I/O requests

ing the I/O device. > > Signed-off-by: Peter Lieven <p...@kamp.de> Reviewed-by: Juan Quintela <quint...@redhat.com> PD. I can't see a trivial way to change things without refactoring the whole code. > --- > migration/block.c | 2 ++ > 1 file changed, 2 insertions(+) > >

Re: [Qemu-block] [PATCH 5/5] migration/block: compare only read blocks against the rate limiter

Peter Lieven <p...@kamp.de> wrote: > only read_done blocks are in the queued to be flushed to the migration > stream. submitted blocks are still in flight. > > Signed-off-by: Peter Lieven <p...@kamp.de> Reviewed-by: Juan Quintela <quint...@redhat.com> > ---

Re: [Qemu-block] [PATCH 3/6] migration: add support for a "tls-authz" migration parameter

Daniel P. Berrangé wrote: > From: "Daniel P. Berrange" . It is not just the fault of this patch, but as you are the one doing the tls bits on migration... > @@ -1106,6 +1108,12 @@ static void migrate_params_apply(MigrateSetParameters > *params, Error **errp) >

Re: [Qemu-block] [PATCH 3/6] migration: add support for a "tls-authz" migration parameter

Daniel P. Berrangé wrote: > On Wed, Jun 20, 2018 at 12:03:45PM +0200, Juan Quintela wrote: >> Daniel P. Berrangé wrote: >> > From: "Daniel P. Berrange" >> >> . >> >> >> It is not just the fault of this patch,

Re: [Qemu-block] [PATCH v3 1/6] qemu-nbd: add support for authorization of TLS clients

ple,id=auth0,identity=CN=laptop.example.com,,\ > O=Example Org,,L=London,,ST=London,,C=GB \ >--tls-creds tls0 \ >--tls-authz authz0 > other qemu-nbd args... > > Signed-off-by: Daniel P. Berrange Reviewed-by: Juan Quintela

Re: [Qemu-block] [PATCH v3 2/6] nbd: allow authorization with nbd-server-start QMP command

ver-start', > 'arguments': { >'addr': { >'type': 'inet', >'host': '127.0.0.1', >'port': '9000' >}, >'tls-creds': 'tls0', >'tls-authz': 'authz0' > } >} > > Signed-off-by: Daniel P. Berrange Reviewed-by: Juan Quintela similar to previous patch in series.

Re: [Qemu-block] [PATCH v3 3/6] migration: add support for a "tls-authz" migration parameter

home/berrange/qemutls,\ > endpoint=server,verify-peer=yes \ > (qemu) object_add authz-simple,id=auth0,identity=CN=laptop.example.com,,\ > O=Example Org,,L=London,,ST=London,,C=GB \ > (qemu) migrate_incoming tcp:localhost:9000 > > Signed-off-by: Daniel P. Berrange Reviewed-by: Juan Quintela

Re: [Qemu-block] [PATCH v3 4/6] chardev: add support for authorization for TLS clients

le Org,,L=London,,ST=London,,C=GB \ > -chardev socket,host=127.0.0.1,port=9000,server,\ >tls-creds=tls0,tls-authz=authz0 \ > ...other qemu args... > > Signed-off-by: Daniel P. Berrange Reviewed-by: Juan Quintela

Re: [Qemu-block] [PATCH v3 5/6] vnc: allow specifying a custom authorization object name

match=j...@redhat.com,rules.0.policy=allow \ > -vnc 0.0.0.0:1,tls-creds=tls0,tls-authz=authz0, > sasl,sasl-authz=authz1 \ > ...other QEMU args... > > Signed-off-by: Daniel P. Berrange Reviewed-by: Juan Quintela

Re: [Qemu-block] [PATCH v3 6/6] monitor: deprecate acl_show, acl_reset, acl_policy, acl_add, acl_remove

ing 'object_add' together with > the 'tls-authz' or 'sasl-authz' parameters to the VNC server, and > equivalent for other network services. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela

[Qemu-block] [PATCH v3 0/5] Fix multifd with big number of channels

Hi In this version: - updated to latest upstream - moved trace to suggested position (danp) Please review. Later, Juan. Juan Quintela (5): socket: Add backlog parameter to socket_listen socket: Add num connections to qio_channel_socket_sync() socket: Add num connections

[Qemu-block] [PATCH v3 4/5] socket: Add num connections to qio_net_listener_open_sync()

Reviewed-by: Daniel P. Berrangé Signed-off-by: Juan Quintela --- blockdev-nbd.c| 2 +- chardev/char-socket.c | 2 +- include/io/net-listener.h | 2 ++ io/net-listener.c | 3 ++- migration/socket.c| 2 +- qemu-nbd.c| 2 +- ui/vnc.c

[Qemu-block] [PATCH v3 2/5] socket: Add num connections to qio_channel_socket_sync()

Reviewed-by: Daniel P. Berrangé Signed-off-by: Juan Quintela --- include/io/channel-socket.h| 2 ++ io/channel-socket.c| 7 --- io/net-listener.c | 2 +- io/trace-events| 2 +- scsi/qemu-pr-helper.c | 3 ++- tests/test-char.c

[Qemu-block] [PATCH v3 1/5] socket: Add backlog parameter to socket_listen

Current parameter was always one. We continue with that value for now in all callers. Signed-off-by: Juan Quintela --- Moved trace to socket_listen --- include/qemu/sockets.h| 2 +- io/channel-socket.c | 2 +- qga/channel-posix.c | 2 +- tests/test-util-sockets.c | 12

[Qemu-block] [PATCH v3 3/5] socket: Add num connections to qio_channel_socket_async()

Reviewed-by: Daniel P. Berrangé Signed-off-by: Juan Quintela --- include/io/channel-socket.h| 2 ++ io/channel-socket.c| 30 +++--- io/trace-events| 2 +- tests/test-io-channel-socket.c | 2 +- 4 files changed, 27 insertions(+), 9

[Qemu-block] [PATCH v3 5/5] multifd: Use number of channels as listen backlog

Reviewed-by: Daniel P. Berrangé Signed-off-by: Juan Quintela --- migration/socket.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/migration/socket.c b/migration/socket.c index e63f5e1612..97c9efde59 100644 --- a/migration/socket.c +++ b/migration/socket.c @@ -178,10

Re: [Qemu-block] [PATCH v2 1/5] socket: Add backlog parameter to socket_listen

Daniel P. Berrangé wrote: > On Tue, Aug 20, 2019 at 10:24:55AM +0200, Juan Quintela wrote: >> Current parameter was always one. We continue with that value for now >> in all callers. >> >> Signed-off-by: Juan Quintela >> @@ -309,7 +311,8 @@ static int in

[Qemu-block] [PATCH v2 0/5] Fix multifd with big number of channels

t; case, I just give an error if expected number of connections is bigger than 1. - All patches except the multifd one should be noops (i.e. I pass everywhere the number of expected channels as one). With this changes, I can migrate with 100 channels consistently. It always work. Please, rev

[Qemu-block] [PATCH v2 2/5] socket: Add num connections to qio_channel_socket_sync()

Signed-off-by: Juan Quintela --- include/io/channel-socket.h| 2 ++ io/channel-socket.c| 7 --- io/net-listener.c | 2 +- io/trace-events| 2 +- scsi/qemu-pr-helper.c | 2 +- tests/test-char.c | 4 ++-- tests/test-io-channel

[Qemu-block] [PATCH v2 4/5] socket: Add num connections to qio_net_listener_open_sync()

Signed-off-by: Juan Quintela --- blockdev-nbd.c| 2 +- chardev/char-socket.c | 2 +- include/io/net-listener.h | 2 ++ io/net-listener.c | 3 ++- migration/socket.c| 2 +- qemu-nbd.c| 2 +- scsi/qemu-pr-helper.c | 3 ++- ui/vnc.c

[Qemu-block] [PATCH v2 1/5] socket: Add backlog parameter to socket_listen

Current parameter was always one. We continue with that value for now in all callers. Signed-off-by: Juan Quintela --- include/qemu/sockets.h| 2 +- io/channel-socket.c | 2 +- qga/channel-posix.c | 2 +- tests/test-util-sockets.c | 12 ++-- util/qemu-sockets.c

[Qemu-block] [PATCH v2 3/5] socket: Add num connections to qio_channel_socket_async()

Signed-off-by: Juan Quintela --- include/io/channel-socket.h| 2 ++ io/channel-socket.c| 30 +++--- io/trace-events| 2 +- tests/test-io-channel-socket.c | 2 +- 4 files changed, 27 insertions(+), 9 deletions(-) diff --git a/include/io

[Qemu-block] [PATCH v2 5/5] multifd: Use number of channels as listen backlog

Signed-off-by: Juan Quintela --- migration/socket.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/migration/socket.c b/migration/socket.c index e63f5e1612..97c9efde59 100644 --- a/migration/socket.c +++ b/migration/socket.c @@ -178,10 +178,15 @@ static void

Re: [Qemu-block] [PATCH v3 1/5] socket: Add backlog parameter to socket_listen

Daniel P. Berrangé wrote: > On Tue, Aug 20, 2019 at 12:48:32PM +0200, Juan Quintela wrote: >> Current parameter was always one. We continue with that value for now >> in all callers. >> >> Signed-off-by: Juan Quintela >> >> --- >> Moved trace to so

[Qemu-block] [PULL 5/5] multifd: Use number of channels as listen backlog

Reviewed-by: Daniel P. Berrangé Signed-off-by: Juan Quintela --- migration/socket.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/migration/socket.c b/migration/socket.c index e63f5e1612..97c9efde59 100644 --- a/migration/socket.c +++ b/migration/socket.c @@ -178,10

[Qemu-block] [PULL 0/5] Fail patches

, danp told me to do the pull myself. Juan Quintela (5): socket: Add backlog parameter to socket_listen socket: Add num connections to qio_channel_socket_sync() socket: Add num connections to qio_channel_socket_async() socket: Add

[Qemu-block] [PULL 2/5] socket: Add num connections to qio_channel_socket_sync()

Reviewed-by: Daniel P. Berrangé Signed-off-by: Juan Quintela --- include/io/channel-socket.h| 2 ++ io/channel-socket.c| 7 --- io/net-listener.c | 2 +- io/trace-events| 2 +- scsi/qemu-pr-helper.c | 3 ++- tests/test-char.c

[Qemu-block] [PULL 1/5] socket: Add backlog parameter to socket_listen

Current parameter was always one. We continue with that value for now in all callers. Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrangé --- Moved trace to socket_listen --- include/qemu/sockets.h| 2 +- io/channel-socket.c | 2 +- qga/channel-posix.c | 2

[Qemu-block] [PULL 4/5] socket: Add num connections to qio_net_listener_open_sync()

Reviewed-by: Daniel P. Berrangé Signed-off-by: Juan Quintela --- blockdev-nbd.c| 2 +- chardev/char-socket.c | 2 +- include/io/net-listener.h | 2 ++ io/net-listener.c | 3 ++- migration/socket.c| 2 +- qemu-nbd.c| 2 +- ui/vnc.c

[Qemu-block] [PULL 3/5] socket: Add num connections to qio_channel_socket_async()

Reviewed-by: Daniel P. Berrangé Signed-off-by: Juan Quintela --- include/io/channel-socket.h| 2 ++ io/channel-socket.c| 30 +++--- io/trace-events| 2 +- tests/test-io-channel-socket.c | 2 +- 4 files changed, 27 insertions(+), 9

Re: [Qemu-block] [PATCH v2 2/2] block: Remove unused masks

Nir Soffer wrote: > Replace confusing usage: > > ~BDRV_SECTOR_MASK > > With more clear: > > (BDRV_SECTOR_SIZE - 1) > > Remove BDRV_SECTOR_MASK and the unused BDRV_BLOCK_OFFSET_MASK which was > it's last user. > > Signed-off-by: Nir Soffer Reviewed-by: Juan Quintela

Re: [Qemu-block] [PATCH v3 4/5] socket: Add num connections to qio_net_listener_open_sync()

Eric Blake wrote: > On 8/20/19 5:48 AM, Juan Quintela wrote: >> Reviewed-by: Daniel P. Berrangé >> Signed-off-by: Juan Quintela >> --- >> blockdev-nbd.c| 2 +- >> chardev/char-socket.c | 2 +- >> include/io/net-listener.h |

Re: [Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

Damien Hedde wrote: > On 8/9/19 12:32 PM, Peter Maydell wrote: >> On Fri, 9 Aug 2019 at 11:29, Damien Hedde wrote: >>> >>> One way to keep the feature without copy-pasting vmsd would be to add >>> a new vmstate_register with an additional argument to pass the base >>> class vmsd section and

Re: [Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

Peter Maydell wrote: > On Fri, 9 Aug 2019 at 11:29, Damien Hedde wrote: >> >> One way to keep the feature without copy-pasting vmsd would be to add >> a new vmstate_register with an additional argument to pass the base >> class vmsd section and handle the whole thing there. > > If we have a

Re: [PULL 5/5] multifd: Use number of channels as listen backlog

Wei Yang wrote: > On Wed, Sep 04, 2019 at 08:29:15AM +0200, Juan Quintela wrote: >>Reviewed-by: Daniel P. Berrangé >>Signed-off-by: Juan Quintela >>--- >> migration/socket.c | 7 ++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >>diff --

Re: [PATCH 1/2] cpu: use ROUND_UP() to define xxx_PAGE_ALIGN

Wei Yang wrote: > Use ROUND_UP() to define, which is a little bit easy to read. > > Signed-off-by: Wei Yang Reviewed-by: Juan Quintela

Re: Can we retire Python 2 now?

something that looks like > a Python script. > > [*] https://pythonclock.org/ I am pretty sure that I am not a python maintaainer at all. But anyways, python3 is only at python3.7. python3.0 debuted at 2008, so ... Acked-by: Juan Quintela Reviewed-by: Juan Quintela And anything els

[PULL 00/15] Pull migration patches

in vmstate_save_state_v() test-vmstate: Fix memleaks in test_load_qlist Hailiang Zhang (3): migration: fix COLO broken caused by a previous commit migration/colo: wrap incoming checkpoint process into new helper savevm: Don't call colo_init_ram_cache twice Juan Quintela (8): multifd: Add

[PULL 12/15] migration/block: rename BLOCK_SIZE macro

the macro now in case someone else stumbles on it in the meantime. Signed-off-by: Stefan Hajnoczi Reviewed-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Juan Quintela --- migration/block.c | 39 -

[PULL 11/15] migration/savevm: release gslist after dump_vmstate_json

/build/x86_64-softmmu/qemu-system-x86_64+0x27f020d) Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- migration/savevm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/savevm.c b

[PULL 01/15] multifd: Add multifd-compression parameter

This will store the compression method to use. We start with none. Signed-off-by: Juan Quintela Acked-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert --- Rename multifd-method to multifd-compression --- hw/core/qdev-properties.c| 13 + include/hw/qdev-properties.h

[PULL 03/15] multifd: Make no compression operations into its own structure

It will be used later. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- No comp value needs to be zero. --- migration/migration.c | 9 ++ migration/migration.h | 1 + migration/multifd.c | 185 -- migration/multifd.h | 26

[PULL 06/15] configure: Enable test and libs for zstd

Add it to several build systems to make testing good. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- .gitlab-ci.yml| 1 + .travis.yml | 1 + configure | 30

[PULL 04/15] multifd: Add multifd-zlib-level parameter

This parameter specifies the zlib compression level. The next patch will put it to use. Signed-off-by: Juan Quintela Acked-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 24 migration/migration.h | 1 + monitor/hmp-cmds.c

[PULL 02/15] migration: Add support for modules

So we don't have to compile everything in, or have ifdefs Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/qemu/module.h | 2 ++ softmmu/vl.c | 1 + 2 files changed, 3 insertions(+) diff --git a/include/qemu/module.h b/include/qemu/module.h index

[PULL 15/15] savevm: Don't call colo_init_ram_cache twice

From: zhanghailiang This helper has been called twice which is wrong. Left the one where called while get COLO enable message from source side. Signed-off-by: zhanghailiang Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c | 5 - 1 file changed, 5

[PULL 09/15] migration/vmstate: Remove redundant statement in vmstate_save_state_v()

uler Robot Signed-off-by: Chen Qun Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/vmstate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/vmstate.c b/migration/vmstate.c index 7dd8ef66c6..bafa890384 100644 --- a/migration/vmstate.c +++ b/migration/vmstate.c

[PULL 05/15] multifd: Add zlib compression multifd support

Signed-off-by: Juan Quintela Acked-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert --- hw/core/qdev-properties.c| 2 +- migration/Makefile.objs | 1 + migration/multifd-zlib.c | 325 +++ migration/multifd.c | 6 + migration

[PULL 07/15] multifd: Add multifd-zstd-level parameter

This parameter specifies the zstd compression level. The next patch will put it to use. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu Acked-by: Markus Armbruster --- migration/migration.c | 24 migration/migration.h | 1 + monitor/hmp-cmds.c| 4 qapi

[PULL 08/15] multifd: Add zstd compression multifd support

Signed-off-by: Juan Quintela Acked-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert --- hw/core/qdev-properties.c| 2 +- migration/Makefile.objs | 1 + migration/multifd-zstd.c | 339 +++ migration/multifd.h | 1 + migration

  1   2   3   4   5   6   7   8   9   10   >