Re: [PATCH 17/17] hw/block/nvme: change controller pci id

On Mon, Sep 07, 2020 at 01:02:16PM +0200, Klaus Jensen wrote: > On Sep 7 11:52, Dr. David Alan Gilbert wrote: > > > It may be best to turn it into a constant in include/hw/pci/pci_ids.h if > > it corresponds to some real Intel device. > > > > Yes, but that is just the thing - it does not

Re: [PATCH 17/17] hw/block/nvme: change controller pci id

On Sep 7 11:52, Dr. David Alan Gilbert wrote: > * Klaus Jensen (i...@irrelevant.dk) wrote: > > On Sep 7 11:37, Dr. David Alan Gilbert wrote: > > > * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > > > > +David in case > > > > > > > > On 9/4/20 4:19 PM, Klaus Jensen wrote: > > > > > From:

Re: [PATCH 17/17] hw/block/nvme: change controller pci id

* Klaus Jensen (i...@irrelevant.dk) wrote: > On Sep 7 11:37, Dr. David Alan Gilbert wrote: > > * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > > > +David in case > > > > > > On 9/4/20 4:19 PM, Klaus Jensen wrote: > > > > From: Klaus Jensen > > > > > > > > There are two reasons for

Re: [PATCH 17/17] hw/block/nvme: change controller pci id

On Sep 7 11:37, Dr. David Alan Gilbert wrote: > * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > > +David in case > > > > On 9/4/20 4:19 PM, Klaus Jensen wrote: > > > From: Klaus Jensen > > > > > > There are two reasons for changing this: > > > > > > 1. The nvme device currently uses

Re: [PATCH 17/17] hw/block/nvme: change controller pci id

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > +David in case > > On 9/4/20 4:19 PM, Klaus Jensen wrote: > > From: Klaus Jensen > > > > There are two reasons for changing this: > > > > 1. The nvme device currently uses an internal Intel device id. > > > > 2. Since commits "nvme:

Re: [PATCH 17/17] hw/block/nvme: change controller pci id

On 9/7/20 11:20 AM, Klaus Jensen wrote: > On Sep 7 10:58, Klaus Jensen wrote: >> On Sep 7 10:36, Philippe Mathieu-Daudé wrote: >>> On 9/7/20 9:23 AM, Klaus Jensen wrote: On Sep 7 04:28, Philippe Mathieu-Daudé wrote: > +David in case > > On 9/4/20 4:19 PM, Klaus Jensen wrote:

Re: [PATCH 17/17] hw/block/nvme: change controller pci id

On Sep 7 10:58, Klaus Jensen wrote: > On Sep 7 10:36, Philippe Mathieu-Daudé wrote: > > On 9/7/20 9:23 AM, Klaus Jensen wrote: > > > On Sep 7 04:28, Philippe Mathieu-Daudé wrote: > > >> +David in case > > >> > > >> On 9/4/20 4:19 PM, Klaus Jensen wrote: > > >>> From: Klaus Jensen > > >>> > >

Re: [PATCH 17/17] hw/block/nvme: change controller pci id

On Sep 7 10:36, Philippe Mathieu-Daudé wrote: > On 9/7/20 9:23 AM, Klaus Jensen wrote: > > On Sep 7 04:28, Philippe Mathieu-Daudé wrote: > >> +David in case > >> > >> On 9/4/20 4:19 PM, Klaus Jensen wrote: > >>> From: Klaus Jensen > >>> > >>> There are two reasons for changing this: > >>> > >>>

Re: [PATCH 17/17] hw/block/nvme: change controller pci id

On 9/7/20 9:23 AM, Klaus Jensen wrote: > On Sep 7 04:28, Philippe Mathieu-Daudé wrote: >> +David in case >> >> On 9/4/20 4:19 PM, Klaus Jensen wrote: >>> From: Klaus Jensen >>> >>> There are two reasons for changing this: >>> >>> 1. The nvme device currently uses an internal Intel device id.

Re: [PATCH 17/17] hw/block/nvme: change controller pci id

On Sep 7 04:28, Philippe Mathieu-Daudé wrote: > +David in case > > On 9/4/20 4:19 PM, Klaus Jensen wrote: > > From: Klaus Jensen > > > > There are two reasons for changing this: > > > > 1. The nvme device currently uses an internal Intel device id. > > > > 2. Since commits "nvme: fix

Re: [PATCH 17/17] hw/block/nvme: change controller pci id

+David in case On 9/4/20 4:19 PM, Klaus Jensen wrote: > From: Klaus Jensen > > There are two reasons for changing this: > > 1. The nvme device currently uses an internal Intel device id. > > 2. Since commits "nvme: fix write zeroes offset and count" and "nvme: > support multiple