Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-28 Thread Christoph Hellwig
On Wed, Oct 28, 2009 at 08:25:22PM +0100, Hannes Reinecke wrote: > I don't think we really need two modes. > My preferred interface here is to pass down scatter-gather lists down > with every xfer; this way it'll be the responsibility of the driver to > create the lists in the first place. If it ha

Re: [Qemu-devel] Re: [PATCH v3 22/25] ay8910: YM2608 core forked from MAME 0.59

2009-10-28 Thread Roy Tam
breemlib takes this file from AppleWin, and AppleWin may take this file from MAME. for AppleWin, it uses GPLv2 since 2006/02/25. 2009/10/29 Natalia Portillo : > This is interesting as well, first line says: > > /* borrowed from AppleWin */ > > I suppose it means that MAME took it from the apple //

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-28 Thread Scott Tsai
Excerpts from Dustin Kirkland's message of Thu Oct 29 03:22:43 +0800 2009: > We're tracking this issue at: > * https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/458521 > > I'll gladly review and test patches, or take pointers on where I might > look to solve this issue. Try the following p

Re: [Qemu-devel] Re: [PATCH v3 22/25] ay8910: YM2608 core forked from MAME 0.59

2009-10-28 Thread Natalia Portillo
This is interesting as well, first line says: /* borrowed from AppleWin */ I suppose it means that MAME took it from the apple // emulator called AppleWin. and. what's the AppleWin license? El 29/10/2009, a las 00:35, Roy Tam escribió: I did a google code search and I found this: http://www

Re: [Qemu-devel] Re: [PATCH v3 22/25] ay8910: YM2608 core forked from MAME 0.59

2009-10-28 Thread Roy Tam
I did a google code search and I found this: http://www.google.com/codesearch/p?hl=zh-TW&sa=N&cd=2&ct=rc#yVjp3hog9Qw/trunk/breemlib/apu/ay8910/ay8910.cpp&q=ay8910 // // From mame.txt (http://www.mame.net/readme.html) // // VI. Reuse of Source Code // -- //This chapter m

[Qemu-devel] Re: New password activation issue

2009-10-28 Thread Pablo Salinas
Hello there, Any help regarding this? I reset my password, but I cannot login to the user's forums. Are there any e-mails of the board administrator(s)? Thanks in advance. regards, Pablo S. On Fri, Oct 23, 2009 at 1:45 PM, Pablo Salinas wrote: > Hello there,

[Qemu-devel] Re: [PATCH v3 22/25] ay8910: YM2608 core forked from MAME 0.59

2009-10-28 Thread Paolo Bonzini
On 10/28/2009 09:08 PM, Stuart Brady wrote: On Thu, Oct 29, 2009 at 01:50:11AM +0900, TAKEDA, toshiya wrote: + +/* This version of ay8910.c is a fork of the MAME 0.59 one, relicensed under the LGPL. Where have you taken this from? More exactly, how is this not violating copyright, since MAM

Re: [Qemu-devel] [PATCH v3 3/25] i386: add private features for a20mask

2009-10-28 Thread Stuart Brady
On Thu, Oct 29, 2009 at 01:32:51AM +0900, TAKEDA, toshiya wrote: > This patch is to add private_features to i386. > It is like cpuid_ext*_features, but is used for any features not defined in > CPUID. > > And "a20mask" feature is defined in private_features. > It is for a20 adrdress mask of PC-98

Re: [Qemu-devel] [PATCH v3 22/25] ay8910: YM2608 core forked from MAME 0.59

2009-10-28 Thread Stuart Brady
On Thu, Oct 29, 2009 at 01:50:11AM +0900, TAKEDA, toshiya wrote: > + > +/* This version of ay8910.c is a fork of the MAME 0.59 one, relicensed under > the LGPL. Where have you taken this from? Cheers, -- Stuart Brady

[Qemu-devel] Re: qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-28 Thread Dustin Kirkland
On Wed, Oct 28, 2009 at 2:22 PM, Dustin Kirkland wrote: > I have not reproduced the problem: >  a) by saturating the guest's outgoing network >  b) with newer guests ( >= 2.6.27 ) >  c) on kvm-84 on the host d) or by using e1000, or rtl8139 NIC models. :-Dustin

Re: Handling merge conflicts [was Re: [Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO]

2009-10-28 Thread Gerd Hoffmann
On 10/28/09 17:24, Avi Kivity wrote: That would require a series to be merged within a very short time period which does not allow appropriate review on the list. Why? When you detect the conflict, ask the unlucky second to rebase (on top of some git branch). The rebased series doesn't need a r

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-28 Thread Hannes Reinecke
Am Wed 28 Oct 2009 02:58:33 PM CET schrieb Gerd Hoffmann : Hi, From a really quick view fixing up the data xfer code paths doesn't look too bad. Think I'll give it a try. Oh well. The interface pretty obviously designed for the esp, which is the oldest scsi adapter in qemu ... ESP: There

Re: Handling merge conflicts [was Re: [Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO]

2009-10-28 Thread Gerd Hoffmann
Hi, How about a simple "I've merged Gerd's into staging, yours conflicts, please re-base" on-list? Then I could reply with "Cool, re-base pushed to vnet-hdr.v2 in my tree" and you could merge that? Problem with that is that staging is a moving target (i.e. rebases frequently). I'll never e

[Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-28 Thread Dustin Kirkland
I believe that we have identified a regression in qemu-kvm-0.11.0. The kvm process crashes for older guests with virtio networking, when the guest's incoming network connection is saturated. The subject guest is Ubuntu 8.04 Hardy, 2.6.24 kernel with virtio backports. For your convenience, I have

Re: Handling merge conflicts [was Re: [Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO]

2009-10-28 Thread Gerd Hoffmann
Neither of these problems existed in the patches Gerd and I posted, so presumably they came about by trying to merge the two patch sets? It means I squashed the resolutions incorrectly. I could add a bisectability test but that would take a long time to run... Indeed. How can we avoid this h

Re: [Qemu-devel] [PATCH 3/4] scsi-disk: Factor out SCSI command emulation

2009-10-28 Thread Hannes Reinecke
Am Wed 28 Oct 2009 09:42:47 AM CET schrieb Christoph Hellwig : On Tue, Oct 27, 2009 at 04:28:59PM +0100, Hannes Reinecke wrote: Other drives might want to use SCSI command emulation without going through the SCSI disk abstraction, as this imposes too many limits on the emulation. Might be a

[Qemu-devel] [PATCH] hw/sd: Support SDHC size cards

2009-10-28 Thread Jason McMullan
This patch add SHDC support (-sd sd.img, where sd.img is larger than 1GB) to qemu. Comments welcome. Signed-off-by: Jason S. McMullan --- hw/sd.c | 153 ++- 1 files changed, 93 insertions(+), 60 deletions(-) diff --git a/hw/sd.c b/hw

[Qemu-devel] [PATCH v3 22/25] ay8910: YM2608 core forked from MAME 0.59

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/ay8910.c b/qemu/hw/ay8910.c new file mode 100644 index 000..d371023 --- /dev/null +++ b/qemu/hw/ay8910.c @@ -0,0 +1,733 @@ +/*** + + ay8910.c + + + Emulation of the AY-3-8910 / YM2149 sound chip. + +

[Qemu-devel] [PATCH v3 16/25] pc98kbd: add NEC PC-9821 family keyboard

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/pc98kbd.c b/qemu/hw/pc98kbd.c new file mode 100644 index 000..f4e4cdc --- /dev/null +++ b/qemu/hw/pc98kbd.c @@ -0,0 +1,395 @@ +/* + * QEMU NEC PC-9821 keyboard + * + * Copyright (c) 2009 TAKEDA, toshiya + * + * Permission is hereby granted, free of charge, to any person obt

[Qemu-devel] [PATCH v3 24/25] ym2608intf: YM2608 core forked from MAME 0.59

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/ym2608intf.c b/qemu/hw/ym2608intf.c new file mode 100644 index 000..35e1064 --- /dev/null +++ b/qemu/hw/ym2608intf.c @@ -0,0 +1,234 @@ +/* don't support sampling rythm sound yet */ +//#define YM2608_USE_SAMPLES +/*

[Qemu-devel] [PATCH v3 18/25] pc98mouse: add NEC PC-9821 family sysport

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/pc98sys.c b/qemu/hw/pc98sys.c new file mode 100644 index 000..d3f510c --- /dev/null +++ b/qemu/hw/pc98sys.c @@ -0,0 +1,425 @@ +/* + * QEMU NEC PC-9821 systemp port + * + * Copyright (c) 2009 TAKEDA, toshiya + * + * Permission is hereby granted, free of charge, to any person

[Qemu-devel] [PATCH v3 13/25] piix_pci: add NEC PC-9821 family interface

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/pci_ids.h b/qemu/hw/pci_ids.h index 63379c2..ca32656 100644 --- a/qemu/hw/pci_ids.h +++ b/qemu/hw/pci_ids.h @@ -57,6 +57,10 @@ #define PCI_VENDOR_ID_AMD0x1022 #define PCI_DEVICE_ID_AMD_LANCE 0x2000 +#define PCI_VENDOR_ID_NEC0x1033 +#

[Qemu-devel] [PATCH v3 12/25] pcspk: add NEC PC-9821 family interface

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/pcspk.c b/qemu/hw/pcspk.c index 26a0ecb..4a21aae 100644 --- a/qemu/hw/pcspk.c +++ b/qemu/hw/pcspk.c @@ -38,6 +38,7 @@ typedef struct { QEMUSoundCard card; SWVoiceOut *voice; PITState *pit; +int pit_ch; unsigned int pit_count; unsigned int samples;

[Qemu-devel] [PATCH v3 14/25] pc98: add NEC PC-9821 family init

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/pc98.c b/qemu/hw/pc98.c new file mode 100644 index 000..c4adce4 --- /dev/null +++ b/qemu/hw/pc98.c @@ -0,0 +1,1004 @@ +/* + * QEMU NEC PC-9821 System Emulator + * + * Copyright (c) 2009 TAKEDA, toshiya + * + * Permission is hereby granted, free of charge, to any person obta

[Qemu-devel] [PATCH v3 20/25] pc98sound: add NEC PC-9821 family sound (PC-9801-86)

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/pc98sound.c b/qemu/hw/pc98sound.c new file mode 100644 index 000..3ec36b0 --- /dev/null +++ b/qemu/hw/pc98sound.c @@ -0,0 +1,697 @@ +/* + * QEMU Proxy for YM2608 emulation by MAME team + * QEMU NEC PC-9821 Sound (PC-9801-86) + * + * Copyright (c) 2004-2005 Vassili Karpov (m

[Qemu-devel] [PATCH v3 10/25] ide/core: support CHS

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/ide/core.c b/qemu/hw/ide/core.c index fffcd00..6ccab35 100644 --- a/qemu/hw/ide/core.c +++ b/qemu/hw/ide/core.c @@ -1770,8 +1770,10 @@ void ide_ioport_write(void *opaque, uint32_t addr, uint32_t val) break; case 6: /* FIXME: HOB readback uses bit 7 */ -

[Qemu-devel] [PATCH v3 17/25] pc98mouse: add NEC PC-9821 family mouse

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/pc98mouse.c b/qemu/hw/pc98mouse.c new file mode 100644 index 000..27783a9 --- /dev/null +++ b/qemu/hw/pc98mouse.c @@ -0,0 +1,266 @@ +/* + * QEMU NEC PC-9821 mouse + * + * Copyright (c) 2009 TAKEDA, toshiya + * + * Permission is hereby granted, free of charge, to any person

[Qemu-devel] [PATCH v3 21/25] fm_def: definitions for MAME YM2608 core

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/fm_def.h b/qemu/hw/fm_def.h new file mode 100644 index 000..0382711 --- /dev/null +++ b/qemu/hw/fm_def.h @@ -0,0 +1,25 @@ +/* M.A.M.E. definitions used for YM2608 */ + +#ifndef __FM_DEF_H__ +#define __FM_DEF_H__ + +typedef unsigned char UINT8; /* unsigned 8bit */ +typede

[Qemu-devel] [PATCH v3 15/25] ide/pc98: add NEC PC-9821 family ide bus

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/ide.h b/qemu/hw/ide.h index 0e7d540..0a94bac 100644 --- a/qemu/hw/ide.h +++ b/qemu/hw/ide.h @@ -22,4 +22,7 @@ void mmio_ide_init (target_phys_addr_t membase, target_phys_addr_t membase2, qemu_irq irq, int shift, DriveInfo *hd0, DriveIn

[Qemu-devel] [PATCH v3 25/25] ymdeltat: YM2608 core forked from MAME 0.59

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/ymdeltat.c b/qemu/hw/ymdeltat.c new file mode 100644 index 000..5fa593c --- /dev/null +++ b/qemu/hw/ymdeltat.c @@ -0,0 +1,335 @@ +/* +** +** File: ymdeltat.c +** +** YAMAHA DELTA-T adpcm sound emulation subroutine +** used by fmopl.c(v0.37c-) and fm.c(v0.37a-) +** +** Base

Re: [Qemu-devel] Support for new target emulator

2009-10-28 Thread Stefan Weil
Boyapati, Anitha schrieb: > Hello, > > We have a proposal to add support for AVR32 target emulation in Qemu. So far, > we are able to build qemu from sources on windows using Mingw. > > Besides looking at sources for other targets in qemu tar ball, I have gone > through docs for information on ho

[Qemu-devel] [PATCH v3 7/25] fdc: add NEC PC-9821 family interface and support 1.23MB diskette

2009-10-28 Thread TAKEDA, toshiya
This patch includes the modifications for 1.23MB floppy diskette. Its sector size is 1024bytes, so I change the fifo buffer size to 1024, and add fifo_vmstate and fifo_size_vmstate for vmstate compatibility. hw/hw.h modification in this patch is by Mr.Juan Quintela, thanks! diff --git a/qemu/hw/h

[Qemu-devel] [PATCH v3 6/25] dma: add NEC PC-9821 family interface

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/isa.h b/qemu/hw/isa.h index 655ad62..10118b9 100644 --- a/qemu/hw/isa.h +++ b/qemu/hw/isa.h @@ -42,6 +42,7 @@ void DMA_hold_DREQ (int nchan); void DMA_release_DREQ (int nchan); void DMA_schedule(int nchan); void DMA_init (int high_page_enable); +void pc98_DMA_init (int high_

[Qemu-devel] [PATCH v3 11/25] ne2000-isa: add NEC PC-9821 family interface (MELCO LGY-98)

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/ne2000-isa.c b/qemu/hw/ne2000-isa.c index 729e8e2..7ec1f47 100644 --- a/qemu/hw/ne2000-isa.c +++ b/qemu/hw/ne2000-isa.c @@ -42,6 +42,23 @@ static void isa_ne2000_cleanup(VLANClientState *vc) s->vc = NULL; } +static void isa_ne2000_initfn_common(ISADevice *dev, +

[Qemu-devel] [PATCH v3 4/25] pc: extern i440fx_state and ferr_irq

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/pc.c b/qemu/hw/pc.c index 4cd8ec6..25eb6dc 100644 --- a/qemu/hw/pc.c +++ b/qemu/hw/pc.c @@ -64,7 +64,7 @@ static fdctrl_t *floppy_controller; static RTCState *rtc_state; static PITState *pit; -static PCII440FXState *i440fx_state; +PCII440FXState *i440fx_state; typedef str

[Qemu-devel] [PATCH v3 2/25] vl: add qemu_cpu_reset_request()

2009-10-28 Thread TAKEDA, toshiya
This patch is to add qemu_cpu_reset_request() function. It is like qemu_syste_reset_request(), but it resets only CPUs and does not reset other devices. diff --git a/qemu/sysemu.h b/qemu/sysemu.h index 17af024..79b28a3 100644 --- a/qemu/sysemu.h +++ b/qemu/sysemu.h @@ -44,13 +44,16 @@ void cpu_en

[Qemu-devel] [PATCH v3 5/25] cirrus_vga: add NEC PC-9821 family interface

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/cirrus_vga.c b/qemu/hw/cirrus_vga.c index 9dfe76a..e31dd75 100644 --- a/qemu/hw/cirrus_vga.c +++ b/qemu/hw/cirrus_vga.c @@ -2586,6 +2586,9 @@ static CPUWriteMemoryFunc * const cirrus_linear_bitblt_write[3] = { static void map_linear_vram(CirrusVGAState *s) { +if (!s->v

[Qemu-devel] [PATCH v3 1/25] Makefile.target: add pc98 objects

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/Makefile.target b/qemu/Makefile.target index fefd7ac..e647474 100644 --- a/qemu/Makefile.target +++ b/qemu/Makefile.target @@ -196,6 +196,8 @@ obj-i386-y += cirrus_vga.o apic.o ioapic.o parallel.o acpi.o piix_pci.o obj-i386-y += usb-uhci.o vmmouse.o vmport.o vmware_vga.o hpet.o

[Qemu-devel] [PATCH v3 0/25] Support NEC PC-9821 on target-i386

2009-10-28 Thread TAKEDA, toshiya
Dear members, This is the new v3 patch to support NEC PC-9821 on target-i386. New features: - FreeBSD/pc98 7.2-RELEASE ready !!! - IDE CD-ROM and Hard drives with CHS - 1.23MB floppy diskette (sector=1024bytes) - PC-9801-86 sound card - MELCO LGY-98 nic - CIRRUS CLGD5430 YM2608 is on PC-9801-86

[Qemu-devel] [PATCH v3 3/25] i386: add private features for a20mask

2009-10-28 Thread TAKEDA, toshiya
This patch is to add private_features to i386. It is like cpuid_ext*_features, but is used for any features not defined in CPUID. And "a20mask" feature is defined in private_features. It is for a20 adrdress mask of PC-98 family. --- a/qemu/target-i386/cpu.h +++ b/qemu/target-i386/cpu.h @@ -405,6

[Qemu-devel] [PATCH v3 9/25] i8259: add NEC PC-9821 family interface

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/i8259.c b/qemu/hw/i8259.c index 3de22e3..eaf75dd 100644 --- a/qemu/hw/i8259.c +++ b/qemu/hw/i8259.c @@ -59,6 +59,7 @@ struct PicState2 { /* XXX: better separation between the two pics */ PicState pics[2]; qemu_irq parent_irq; +uint8_t irq_cascade; void *

[Qemu-devel] [PATCH v3 8/25] i8254: add NEC PC-9821 family interface

2009-10-28 Thread TAKEDA, toshiya
diff --git a/qemu/hw/i8254.c b/qemu/hw/i8254.c index 5c49e6e..7b7bf63 100644 --- a/qemu/hw/i8254.c +++ b/qemu/hw/i8254.c @@ -47,6 +47,7 @@ typedef struct PITChannelState { uint8_t bcd; /* not supported */ uint8_t gate; /* timer start */ int64_t count_load_time; +uint64_t frequenc

Re: Handling merge conflicts [was Re: [Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO]

2009-10-28 Thread Anthony Liguori
Mark McLoughlin wrote: I could add a bisectability test but that would take a long time to run... Testing that each commit builds could be easily automated and quick to run. I try to do that before sending a series. It's certainly doable. I used to do that as part of my regular proce

[Qemu-devel] [PATCH] Added imlpementation for qemu_error for non-qemu executables

2009-10-28 Thread Naphtali Sprei
Now qemu_error can be called also from shared files, e.g. block.c. Signed-off-by: Naphtali Sprei --- qemu-tool.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/qemu-tool.c b/qemu-tool.c index ba24aa2..186c4f7 100644 --- a/qemu-tool.c +++ b/qemu-tool.c @@ -88,3

Re: Handling merge conflicts [was Re: [Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO]

2009-10-28 Thread Anthony Liguori
Avi Kivity wrote: Why? When you detect the conflict, ask the unlucky second to rebase (on top of some git branch). The rebased series doesn't need a re-review unless the submitter says he needed to rework it significantly. (IOW, the submitter's rebase doesn't need more review than your conf

Re: Handling merge conflicts [was Re: [Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO]

2009-10-28 Thread Anthony Liguori
Avi Kivity wrote: Why? When you detect the conflict, ask the unlucky second to rebase (on top of some git branch). The rebased series doesn't need a re-review unless the submitter says he needed to rework it significantly. (IOW, the submitter's rebase doesn't need more review than your conf

Re: Handling merge conflicts [was Re: [Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO]

2009-10-28 Thread Mark McLoughlin
On Wed, 2009-10-28 at 10:26 -0500, Anthony Liguori wrote: > Mark McLoughlin wrote: > > Hi Anthony, > > Thanks for merging this stuff ... > > > > In the process of merging it all into qemu-kvm, I noticed a couple of > > problems: > > > > 1) bb6e63644 lacked the change to add the type code

Re: [Qemu-devel] Re: [PATCH 07/10] ac97: sizeof returns unsigned long

2009-10-28 Thread malc
On Wed, 28 Oct 2009, Paolo Bonzini wrote: > On 10/28/2009 04:41 PM, malc wrote: > > > > > > sizeof returns size_t (%zX), so this is wrong > > > > > > > > size_t is long on all practical platforms except ia64-hpux and Win64, > > > so this > > > > is not more wrong than it was before. > > Yea ri

Re: Handling merge conflicts [was Re: [Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO]

2009-10-28 Thread Avi Kivity
On 10/28/2009 05:28 PM, Anthony Liguori wrote: Gerd Hoffmann wrote: Hi, Should either Gerd or I have merged the others' changes into our tree and asked you to pull? Should you just refuse conflicts and ask us to re-post? Or ...? I think the best way to deal with that would be to simply not

Re: [Qemu-devel] Re: [PATCH 07/10] ac97: sizeof returns unsigned long

2009-10-28 Thread Paolo Bonzini
On 10/28/2009 04:41 PM, malc wrote: > > sizeof returns size_t (%zX), so this is wrong > > size_t is long on all practical platforms except ia64-hpux and Win64, so this > is not more wrong than it was before. Yea right, except that's it's not long on any 32bit platform, at least not from gcc

Re: [Qemu-devel] Re: [PATCH 07/10] ac97: sizeof returns unsigned long

2009-10-28 Thread malc
On Wed, 28 Oct 2009, Paolo Bonzini wrote: > On 10/28/2009 01:53 PM, malc wrote: > > On Wed, 28 Oct 2009, Juan Quintela wrote: > > > > > This change makes DEBUG_AC97 to compile again > > > > sizeof returns size_t (%zX), so this is wrong > > size_t is long on all practical platforms except ia64-h

Re: Handling merge conflicts [was Re: [Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO]

2009-10-28 Thread Anthony Liguori
Mark McLoughlin wrote: Hi Anthony, Thanks for merging this stuff ... In the process of merging it all into qemu-kvm, I noticed a couple of problems: 1) bb6e63644 lacked the change to add the type code to qemu_new_vlan_client() so that and the subsequent 14 commits are

Re: Handling merge conflicts [was Re: [Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO]

2009-10-28 Thread Anthony Liguori
Gerd Hoffmann wrote: Hi, Should either Gerd or I have merged the others' changes into our tree and asked you to pull? Should you just refuse conflicts and ask us to re-post? Or ...? I think the best way to deal with that would be to simply not merge stuff which doesn't apply. Likewise for

Re: Handling merge conflicts [was Re: [Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO]

2009-10-28 Thread Gerd Hoffmann
Hi, Should either Gerd or I have merged the others' changes into our tree and asked you to pull? Should you just refuse conflicts and ask us to re-post? Or ...? I think the best way to deal with that would be to simply not merge stuff which doesn't apply. Likewise for stuff which doesn't b

Handling merge conflicts [was Re: [Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO]

2009-10-28 Thread Mark McLoughlin
Hi Anthony, Thanks for merging this stuff ... In the process of merging it all into qemu-kvm, I noticed a couple of problems: 1) bb6e63644 lacked the change to add the type code to qemu_new_vlan_client() so that and the subsequent 14 commits are unbuildable 2) 93d

[Qemu-devel] [PATCH] virtio-net: fix macaddr config regression

2009-10-28 Thread Mark McLoughlin
This commit: commit 97b15621 virtio: use qdev properties for configuration. Signed-off-by: Gerd Hoffmann Signed-off-by: Anthony Liguori makes a guest using virtio-net see an empty macaddr because we never copy the macaddr into the location that virtio_net_get_config() uses. Si

[Qemu-devel] Re: Usage of qemu_error withing shared object

2009-10-28 Thread Gerd Hoffmann
On 10/28/09 14:31, Naphtali Sprei wrote: Hi, I've added a call to qemu_error in block.c file, and got a link error on the qemu-utilities: qemu-img, qemu-nbd and qemu-io. Should there be a stub that implements a qemu_error to be linked with those apps ? Am I missing something ? There was no ne

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-28 Thread Gerd Hoffmann
Hi, From a really quick view fixing up the data xfer code paths doesn't look too bad. Think I'll give it a try. Oh well. The interface pretty obviously designed for the esp, which is the oldest scsi adapter in qemu ... ESP: There is no scatter-gather support in the hardware. So for larg

[Qemu-devel] Usage of qemu_error withing shared object

2009-10-28 Thread Naphtali Sprei
Hi, I've added a call to qemu_error in block.c file, and got a link error on the qemu-utilities: qemu-img, qemu-nbd and qemu-io. Should there be a stub that implements a qemu_error to be linked with those apps ? Am I missing something ? In my case, I couldn't let the caller report the error (and

[Qemu-devel] Re: [PATCH 07/10] ac97: sizeof returns unsigned long

2009-10-28 Thread Paolo Bonzini
On 10/28/2009 01:53 PM, malc wrote: On Wed, 28 Oct 2009, Juan Quintela wrote: This change makes DEBUG_AC97 to compile again sizeof returns size_t (%zX), so this is wrong size_t is long on all practical platforms except ia64-hpux and Win64, so this is not more wrong than it was before. Pa

[Qemu-devel] Re: [PATCH 07/10] ac97: sizeof returns unsigned long

2009-10-28 Thread malc
On Wed, 28 Oct 2009, Juan Quintela wrote: > This change makes DEBUG_AC97 to compile again sizeof returns size_t (%zX), so this is wrong -- mailto:av1...@comtv.ru

[Qemu-devel] [PATCH 04/10] es1370: port to vmstate

2009-10-28 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/es1370.c | 77 +++--- 1 files changed, 36 insertions(+), 41 deletions(-) diff --git a/hw/es1370.c b/hw/es1370.c index 9071a48..8e0eddd 100644 --- a/hw/es1370.c +++ b/hw/es1370.c @@ -924,48 +924,28 @@ stati

[Qemu-devel] [PATCH 01/10] audio: fix compilation of DEBUG_PLIVE

2009-10-28 Thread Juan Quintela
Signed-off-by: Juan Quintela --- audio/audio_template.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/audio/audio_template.h b/audio/audio_template.h index 14c648c..19cdb7f 100644 --- a/audio/audio_template.h +++ b/audio/audio_template.h @@ -445,9 +445,9 @@ SW *gl

[Qemu-devel] [PATCH 02/10] audio: port to vmstate

2009-10-28 Thread Juan Quintela
Signed-off-by: Juan Quintela --- audio/audio.c | 26 +- 1 files changed, 9 insertions(+), 17 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 80a717b..a5305c4 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1784,23 +1784,15 @@ static void audio_atexit (

[Qemu-devel] [PATCH 05/10] c4231a: port to vmstate

2009-10-28 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/cs4231a.c | 58 ++ 1 files changed, 30 insertions(+), 28 deletions(-) diff --git a/hw/cs4231a.c b/hw/cs4231a.c index e03c5d2..7c29aa8 100644 --- a/hw/cs4231a.c +++ b/hw/cs4231a.c @@ -596,45 +596,47 @@

[Qemu-devel] [PATCH v2 00/10] Port audio to vmstate

2009-10-28 Thread Juan Quintela
[v2] - rebased to top of qemu/master - removed IO_READ/WRITE_PROTO cleanups. - rest is the same that previous round. malc agreed to let them it. Later, Juan. [v1] THis patch series port audio to vmstate. - fix compliation with DEBUG_PLIVE and DEBUG_AC97 - unfold IO_READ_PROTO/IO_WRITE_PROTO and

[Qemu-devel] [PATCH 03/10] sb16: port to vmstate

2009-10-28 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/sb16.c | 168 ++--- 1 files changed, 61 insertions(+), 107 deletions(-) diff --git a/hw/sb16.c b/hw/sb16.c index 8654b7d..c72ef4c 100644 --- a/hw/sb16.c +++ b/hw/sb16.c @@ -1251,115 +1251,10 @@ static v

[Qemu-devel] [PATCH 10/10] ac97: port to vmstate

2009-10-28 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/ac97.c | 101 ++-- 1 files changed, 44 insertions(+), 57 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index 8064fc3..99a43f8 100644 --- a/hw/ac97.c +++ b/hw/ac97.c @@ -1167,68 +1167,31 @@ static void

[Qemu-devel] [PATCH 09/10] ac97: up savevm version and remove active from state

2009-10-28 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/ac97.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index b1a6395..8064fc3 100644 --- a/hw/ac97.c +++ b/hw/ac97.c @@ -1170,7 +1170,6 @@ static void po_callback (void *opaque, int free) static void

[Qemu-devel] [PATCH 08/10] ac97: recalculate active after loadvm

2009-10-28 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/ac97.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index e4ecbe9..b1a6395 100644 --- a/hw/ac97.c +++ b/hw/ac97.c @@ -1242,6 +1242,9 @@ static int ac97_load (QEMUFile *f, void *opaque, int version_id) V

[Qemu-devel] [PATCH 07/10] ac97: sizeof returns unsigned long

2009-10-28 Thread Juan Quintela
This change makes DEBUG_AC97 to compile again Signed-off-by: Juan Quintela --- hw/ac97.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index 610ca60..e4ecbe9 100644 --- a/hw/ac97.c +++ b/hw/ac97.c @@ -323,7 +323,7 @@ static void reset_bm_regs (

[Qemu-devel] [PATCH 06/10] gus: port to vmstate

2009-10-28 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/gus.c | 47 +-- 1 files changed, 17 insertions(+), 30 deletions(-) diff --git a/hw/gus.c b/hw/gus.c index c6b98b3..d35da0a 100644 --- a/hw/gus.c +++ b/hw/gus.c @@ -215,35 +215,22 @@ static int GUS_read_DMA (void *

[Qemu-devel] [PATCH 3/3] Documentation: Add options to image format descriptions

2009-10-28 Thread Kevin Wolf
Explain the existing format specific options that can be used with qemu-img create/convert -o ... Signed-off-by: Kevin Wolf --- qemu-img.texi | 46 +- 1 files changed, 45 insertions(+), 1 deletions(-) diff --git a/qemu-img.texi b/qemu-img.texi index

[Qemu-devel] [PATCH 2/3] Documentation: Don't mention old qemu-img options

2009-10-28 Thread Kevin Wolf
The old options are still supported for compatibility, but they are inconsistent (for example create -b vs. convert -B for backing files) and incomplete (-F only exists for create) which tends to confuse people. Remove all references to the old options from the documentation to guide users to the m

[Qemu-devel] [PATCH 0/3] Update qemu-img documentation

2009-10-28 Thread Kevin Wolf
Early this week, I received a request that qemu-img convert should support the -F option for the backing file format just like qemu-img create does. In fact, we already support this as -o backing_fmt=... So I came to the conclusion that we need to have another patch round for the documentation that

[Qemu-devel] [PATCH 1/3] Documentation: Move image format descriptions to own section

2009-10-28 Thread Kevin Wolf
The description of the image formats is too long to be a subitem of a parameter description. It will become even longer when we include the options provided by the respective format. Signed-off-by: Kevin Wolf --- qemu-img.texi | 78 ++--- 1 f

Re: [Qemu-devel] Re: How to use -acpitable to add a SLIC-table?

2009-10-28 Thread Stefan Hellermann
> Replying to an old email... > > Stefan, Was you able to actually specify an externa SLIC table with qemu? > The thread I'm replying to is quite old and it ends prematurely without > any definitive result. I tried it in qemu-0.11.0 and qemu-kvm-0.11.0, > but it looks like -acpitable gets ignored

Re: [Qemu-devel] [PATCH] scsi-disk: Inquiry with allocation length of CDB < 36

2009-10-28 Thread Artyom Tarasenko
2009/10/27 Artyom Tarasenko : > 2009/10/27 Anthony Liguori : >> Artyom Tarasenko wrote: >>> >>> According to SCSI-2 specification, >>> http://ldkelley.com/SCSI2/SCSI2/SCSI2/SCSI2-08.html#8.2.5 , >>> "if the allocation length of the command descriptor block (CDB) is too >>> small to transfer >>> all

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-28 Thread Gerd Hoffmann
Hi, In order to support SCSI command emulation I had to update / patch up the existing SCSI disk support. This might be not to everyones taste, so I'm open to alternative suggestions. But I certainly do _not_ want to update the SCSI disk emulation, as this is really quite tied to the SCSI par

[Qemu-devel] [PATCH] qemu-img: Allow creating zero sized images

2009-10-28 Thread Kevin Wolf
A size of 0 should be valid and cannot be treated as "missing value". Use -1 for this purpose instead. Signed-off-by: Kevin Wolf --- qemu-img.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 204f618..00fcade 100644 --- a/qemu-img.c

Re: [Qemu-devel] Re: How to use -acpitable to add a SLIC-table?

2009-10-28 Thread Michael Tokarev
Replying to an old email... Stefan Hellermann wrote at 30-Mar-2009: Gleb Natapov schrieb: On Thu, Mar 26, 2009 at 06:35:16PM +0100, Stefan Hellermann wrote: Hello, how can I use the -acpitable parameter to add a SLIC-table to the qemu-bios dynamically? I think I need a file with the SLIC-

Re: [Qemu-devel] accidental mistyping of command line kills networking

2009-10-28 Thread Gleb Natapov
On Wed, Oct 28, 2009 at 10:55:50AM +0200, Avi Kivity wrote: > On 10/28/2009 10:34 AM, Gleb Natapov wrote: > > > >>It shouldn't kill networking though. If a guest has two nics > >>connected to the same host bridge (a reasonable configuration), and > >>then connects these two nics through its own br

Re: [Qemu-devel] accidental mistyping of command line kills networking

2009-10-28 Thread Avi Kivity
On 10/28/2009 10:34 AM, Gleb Natapov wrote: It shouldn't kill networking though. If a guest has two nics connected to the same host bridge (a reasonable configuration), and then connects these two nics through its own bridge, it creates the same sort of loop. If that kills networking, we have

[Qemu-devel] Re: [PATCH 0/5] Fix packet queueing to allow full tap queue drain

2009-10-28 Thread Mark McLoughlin
On Wed, 2009-10-28 at 11:36 +0800, Scott Tsai wrote: > > Scott, Sven, if you could test the tap-drain-queue branch from > > my tree, that would be great: > > http://repo.or.cz/w/qemu/markmc.git > > > > Thanks, > > Mark. > > Mark, > I've tested http://repo.or.cz/w/qemu/markmc.git and it

[Qemu-devel] Re: [PATCH] qemu/msix: fix table access issues

2009-10-28 Thread Michael S. Tsirkin
BTW, Anthony, I think this is also stable-0.11 material. Patch seems to apply without changes there. ---> Fixes a couple of issues with msix table access: - With misbehaving guests, misaligned 4 byte access could overflow msix table and cause qemu to segfault. Since PCI spec requires host to

Re: [Qemu-devel] [PATCH 3/4] scsi-disk: Factor out SCSI command emulation

2009-10-28 Thread Christoph Hellwig
On Tue, Oct 27, 2009 at 04:28:59PM +0100, Hannes Reinecke wrote: > > Other drives might want to use SCSI command emulation without > going through the SCSI disk abstraction, as this imposes too > many limits on the emulation. Might be a good idea to move something like this first into the series

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-28 Thread Christoph Hellwig
On Wed, Oct 28, 2009 at 09:11:29AM +0100, Hannes Reinecke wrote: > The problem is I don't have any documentation for the LSI parallel > SCSI controller. So I don't know if and in what shape I/O is passed > down, nor anything else. And as the SCSI disk emulation is really > tied into the LSI paralle

Re: [Qemu-devel] [PATCH] Remove aio_ctx from paio_* interface

2009-10-28 Thread Christoph Hellwig
On Mon, Oct 26, 2009 at 01:03:08PM +0100, Kevin Wolf wrote: > The context parameter in paio_submit isn't used anyway, so there is no reason > why block drivers should need to remember it. This also avoids passing a Linux > AIO context to paio_submit (which doesn't do any harm as long as the paramet

[Qemu-devel] Re: [PATCH] raw/linux-aio: Also initialize POSIX AIO

2009-10-28 Thread Christoph Hellwig
On Mon, Oct 26, 2009 at 09:36:55AM +0100, Kevin Wolf wrote: > Well, my question was not if they are sub-modules of raw-posix - they > clearly are - but rather if they should be. linux-aio is just a trvial wrapper for the native Linux AIO abi to be used by QEMU, I can't see why it wouldn't. posix-

Re: [Qemu-devel] accidental mistyping of command line kills networking

2009-10-28 Thread Gleb Natapov
On Wed, Oct 28, 2009 at 08:29:42AM +0200, Avi Kivity wrote: > On 10/27/2009 11:44 PM, Anthony Liguori wrote: > > > >It's actually not okay. You're creating a bridge with two tap > >devices on the bridge that happen to be connected in qemu by a > >vlan. If one tap device receives a packet, qemu is

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-28 Thread Avi Kivity
On 10/28/2009 10:11 AM, Hannes Reinecke wrote: The problem is I don't have any documentation for the LSI parallel SCSI controller. So I don't know if and in what shape I/O is passed down, nor anything else. And as the SCSI disk emulation is really tied into the LSI parallel SCSI controller, any

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-28 Thread Hannes Reinecke
Am Tue 27 Oct 2009 05:47:21 PM CET schrieb Gerd Hoffmann : Hi, The device can be accessed by -drive if=raid,file=XXX Don't extend that qemu automagic please. The new way to handle this is: -drive if=none,id=mydisk,file=/path/to/some/disk.img -device megasas,id=raid -device scsi-di

RE: [Qemu-devel] Support for new target emulator

2009-10-28 Thread Boyapati, Anitha
> -Original Message- > From: Rabin Vincent [mailto:rabin.vinc...@gmail.com] On Behalf Of Rabin > Vincent > Sent: Tuesday, October 27, 2009 9:33 PM > To: Boyapati, Anitha > Cc: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] Support for new target emulator > > On Fri, Oct 23, 2009 at 12