Re: [Qemu-devel] TCG is hard to understand!

2009-12-10 Thread Laurent Desnogues
On Fri, Dec 11, 2009 at 4:18 AM, Jun Koi wrote: > > Another question: I look at tcg_gen_callN() to see how the helper is > executed. We put the helper opcode into the TCG code buffer, and put > helper's params into gen_opparam_buf. > > However, then when TCG generates code to actually call the hel

Re: [Qemu-devel] vmware video broken in git

2009-12-10 Thread Mark McLoughlin
Hi Dave, On Fri, 2009-12-11 at 14:59 +1000, Dave Airlie wrote: > Hi guys, > > Building 0.11.0, qemu -vga vmware -sdl works fine. > with git I just get a blank screen. > > I'm trying to bisect but I keep running into a big chunk of NIC changes > where none of the drivers compile, so I thought may

[Qemu-devel] [PATCH] vmware_vga: add rom file so that it boots.

2009-12-10 Thread Dave Airlie
From: Dave Airlie This just adds the rom file to the vmware SVGA chipset so it boots. Signed-off-by: Dave Airlie --- hw/vmware_vga.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index 240731a..a7e42c6 100644 --- a/hw/vmware_vga.c +

[Qemu-devel] qemu architecture

2009-12-10 Thread pei duan
Hi guy, I am not very clear qemu architecture,and the relationship between modules. who can help me?

[Qemu-devel] vmware video broken in git

2009-12-10 Thread Dave Airlie
Hi guys, Building 0.11.0, qemu -vga vmware -sdl works fine. with git I just get a blank screen. I'm trying to bisect but I keep running into a big chunk of NIC changes where none of the drivers compile, so I thought maybe someone could make an educated guess. Dave.

Re: [Qemu-devel] TCG is hard to understand!

2009-12-10 Thread Jun Koi
Hi Alex, >> However, I still dont understand what the line (3) does. Could you >> give some hints? >> static TCGv_i32 cpu_tmp2_i32;                                      // 1 ... gen_ldst_modrm(s, modrm, OT_WORD, OR_TMP0, 0);   // 2 gen_jmp_im(pc_start - s->cs_base);            

Re: [Qemu-devel] TCG is hard to understand!

2009-12-10 Thread Alexander Graf
On 11.12.2009, at 03:34, Jun Koi wrote: > On Fri, Dec 11, 2009 at 7:21 AM, Andreas Färber > wrote: >> Hi, >> >> Am 10.12.2009 um 17:44 schrieb Jun Koi: >> >>> I am trying to understand how TCG works. For example, I look at the >>> LLDT insn on x86. >>> >>> In target-i386/translate.c, we tran

Re: [Qemu-devel] TCG is hard to understand!

2009-12-10 Thread Jun Koi
On Fri, Dec 11, 2009 at 7:21 AM, Andreas Färber wrote: > Hi, > > Am 10.12.2009 um 17:44 schrieb Jun Koi: > >> I am trying to understand how TCG works. For example, I look at the >> LLDT insn on x86. >> >> In target-i386/translate.c, we translate LLDT to TCG code, like below: >> >> >> static TCGv_i

[Qemu-devel] Re: [PATCHv2][SEABIOS] Make SMBIOS table pass MS SVVP test

2009-12-10 Thread Kevin O'Connor
On Mon, Nov 23, 2009 at 02:03:18PM +0200, Gleb Natapov wrote: > Microsoft SVVP (Server Virtualization Validation Program) expects > arbitrary SMBIOS field to have certain values otherwise it fails. > We all want to make Microsoft happy don't we? So lets put values MS > expects in there. Thanks - S

Re: [Qemu-devel] Guest bridge setup variations

2009-12-10 Thread Anthony Liguori
Arnd Bergmann wrote: 3) given an fd, treat a vhost-style interface This could mean two things, not sure which one you mean. Either the file descriptor could be the vhost file descriptor, or the socket or tap file descriptor from above, with qemu operating on the vhost interface itself. Ei

Re: [Qemu-devel] TCG is hard to understand!

2009-12-10 Thread Andreas Färber
Hi, Am 10.12.2009 um 17:44 schrieb Jun Koi: I am trying to understand how TCG works. For example, I look at the LLDT insn on x86. In target-i386/translate.c, we translate LLDT to TCG code, like below: static TCGv_i32 cpu_tmp2_i32; // 1 ... gen_ldst_mod

Re: [Qemu-devel] Current state of qemu-system-mips

2009-12-10 Thread Andreas Färber
Hi, Am 10.12.2009 um 18:51 schrieb Palle Lyckegaard: what is the current state of the qemu-system-malta? When I try to run a NetBSD or Linux kernel the following message appears: ./git/qemu/mips-softmmu/qemu-system-mips -kernel ./netbsd_malta -m 64 -nographic qemu: hardware error: Unkn

Re: [Qemu-devel] Re: Guest bridge setup variations

2009-12-10 Thread Alexander Graf
On 10.12.2009, at 21:20, Arnd Bergmann wrote: > On Thursday 10 December 2009 19:14:28 Alexander Graf wrote: >>> This is something I also have been thinking about, but it is not what >>> I was referring to above. I think it would be good to keep the three >>> cases (macvlan, VMDq, SR-IOV) as simil

Re: [Qemu-devel] [PATCH] vnc: improve capslock handling.

2009-12-10 Thread Gerd Hoffmann
On 12/10/09 15:05, Alexander Graf wrote: Gerd Hoffmann wrote: When capslock is toggled while the vnc window hasn't the focus qemu will miss the state change. Add sanity checks for the capslock state and toggle it if needed, so hosts and guests idea of capslock state stay in sync. Simliar logic

Re: [Qemu-devel] Re: Guest bridge setup variations

2009-12-10 Thread Arnd Bergmann
On Thursday 10 December 2009 19:14:28 Alexander Graf wrote: > > This is something I also have been thinking about, but it is not what > > I was referring to above. I think it would be good to keep the three > > cases (macvlan, VMDq, SR-IOV) as similar as possible from the user > > perspective, so u

[Qemu-devel] [PATCH 20/20] VNC: Convert do_info_vnc() to QObject

2009-12-10 Thread Luiz Capitulino
Return a QDict with server information. Connected clients are returned as a QList of QDicts. The new functions (vnc_qdict_remote_addr(), vnc_qdict_local_addr() and put_addr_qdict()) are used to insert 'host' and 'service' information in the returned QDict. This patch is big, but I don't see how t

[Qemu-devel] [PATCH 19/20] PCI: Convert pci_device_hot_add() to QObject

2009-12-10 Thread Luiz Capitulino
Return a QDict with information about the just added device. This commit should not change user output. Please, note that this patch does not do error handling conversion. In error conditions the handler still calls monitor_printf(). Signed-off-by: Luiz Capitulino --- hw/pci-hotplug.c | 40 +

[Qemu-devel] [PATCH 18/20] char: Convert qemu_chr_info() to QObject

2009-12-10 Thread Luiz Capitulino
Each device is represented by a QDict. The returned QObject is a QList of all devices. This commit should not change user output. Signed-off-by: Luiz Capitulino --- monitor.c |3 ++- qemu-char.c | 43 +-- qemu-char.h |4 +++- 3 files changed,

[Qemu-devel] [PATCH 17/20] block: Convert bdrv_info_stats() to QObject

2009-12-10 Thread Luiz Capitulino
Each device statistic information is stored in a QDict and the returned QObject is a QList of all devices. This commit should not change user output. Signed-off-by: Luiz Capitulino --- block.c | 82 block.h |3 +- monitor.c

[Qemu-devel] [PATCH 16/20] block: Convert bdrv_info() to QObject

2009-12-10 Thread Luiz Capitulino
Each block device information is stored in a QDict and the returned QObject is a QList of all devices. This commit should not change user output. Signed-off-by: Luiz Capitulino --- Makefile |6 +- block.c | 123 +++-- block.h |

[Qemu-devel] [PATCH 15/20] migration: Convert do_info_migrate() to QObject

2009-12-10 Thread Luiz Capitulino
Return a QDict, which may contain up to more two QDicts, depending on the type of migration we're performing. IMPORTANT: as a QInt stores a int64_t integer, RAM values are going to be stored as int64_t and not as uint64_t as they are today. If this is a problem QInt will have to be changed. This

[Qemu-devel] [PATCH 14/20] monitor: Convert do_info_mice() to QObject

2009-12-10 Thread Luiz Capitulino
Each mouse is represented by a QDict, the returned QObject is a QList of all mice. This commit should not change user output. Signed-off-by: Luiz Capitulino --- console.h |3 +- monitor.c |3 +- vl.c | 62 ++-- 3 files chang

[Qemu-devel] [PATCH 12/20] monitor: Convert do_info_hpet() to QObject

2009-12-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c | 24 +--- 1 files changed, 21 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index a2433e9..a824648 100644 --- a/monitor.c +++ b/monitor.c @@ -597,10 +597,27 @@ static void do_info_commands(Monitor *mon, QObjec

[Qemu-devel] [PATCH 13/20] monitor: Convert do_info_uuid() to QObject

2009-12-10 Thread Luiz Capitulino
snprintf() is used because the UUID_FMT is too complex for qobject_from_jsonf(). Signed-off-by: Luiz Capitulino --- monitor.c | 26 +++--- 1 files changed, 23 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index a824648..0163c07 100644 --- a/monitor.c +++

[Qemu-devel] [PATCH 11/20] monitor: Convert do_info_name() to QObject

2009-12-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c | 32 1 files changed, 28 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 3f26c5a..a2433e9 100644 --- a/monitor.c +++ b/monitor.c @@ -514,10 +514,33 @@ static void do_info_version(Monitor *mon,

[Qemu-devel] [PATCH 10/20] monitor: Convert do_info_kvm() to QObject

2009-12-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c | 41 + 1 files changed, 33 insertions(+), 8 deletions(-) diff --git a/monitor.c b/monitor.c index 01d5827..3f26c5a 100644 --- a/monitor.c +++ b/monitor.c @@ -1806,16 +1806,40 @@ static void tlb_info(Monitor *

[Qemu-devel] [PATCH 09/20] monitor: Convert do_info_status() to QObject

2009-12-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c | 44 +++- 1 files changed, 35 insertions(+), 9 deletions(-) diff --git a/monitor.c b/monitor.c index 481a0fa..01d5827 100644 --- a/monitor.c +++ b/monitor.c @@ -1933,16 +1933,41 @@ static void do_inject_nmi(M

[Qemu-devel] [PATCH 08/20] monitor: do_info_version(): Use QDict

2009-12-10 Thread Luiz Capitulino
All 'info' commands should use QDict, this commit also kills monitor_print_qobject() as do_info_version() doesn't use it anymore (and no handler will). Signed-off-by: Luiz Capitulino --- monitor.c | 42 ++ 1 files changed, 22 insertions(+), 20 deletions(

[Qemu-devel] [PATCH 07/20] monitor: do_info_cpus(): Use QBool

2009-12-10 Thread Luiz Capitulino
While there update the documentation as well. Signed-off-by: Luiz Capitulino --- monitor.c | 38 +- 1 files changed, 25 insertions(+), 13 deletions(-) diff --git a/monitor.c b/monitor.c index 5010ce4..49db7cf 100644 --- a/monitor.c +++ b/monitor.c @@ -635,8

[Qemu-devel] [PATCH 06/20] monitor: Fix do_info_commands() output

2009-12-10 Thread Luiz Capitulino
Should return a QDict and should not print the user protocol bits (eg. "c|cont"). Signed-off-by: Luiz Capitulino --- monitor.c | 30 +++--- 1 files changed, 27 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index aa56ec7..5010ce4 100644 --- a/monitor.

[Qemu-devel] [PATCH 05/20] monitor: Fix do_info_balloon() output

2009-12-10 Thread Luiz Capitulino
Monitor commands should always return values in bytes and info commands should always return a QDict. Signed-off-by: Luiz Capitulino --- monitor.c | 19 --- 1 files changed, 16 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index a38a103..aa56ec7 100644 --- a

[Qemu-devel] [PATCH 04/20] QDict: Introduce qdict_get_qlist()

2009-12-10 Thread Luiz Capitulino
A helper function to get a QList from a QDict. Signed-off-by: Luiz Capitulino --- Makefile |2 +- qdict.c | 13 + qdict.h |2 ++ 3 files changed, 16 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index b4356ae..f1b0131 100644 --- a/Makefile +++ b/Makefile

[Qemu-devel] [PATCH 03/20] QDict: Introduce qdict_get_qbool()

2009-12-10 Thread Luiz Capitulino
This is a helper function that does type checking before retrieving a QBool from the dictionary. Signed-off-by: Luiz Capitulino --- Makefile |2 +- qdict.c | 15 +++ qdict.h |1 + 3 files changed, 17 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index ea

[Qemu-devel] [PATCH 02/20] Makefile: move QObject objs to their own entry

2009-12-10 Thread Luiz Capitulino
Other subsystems will need to link against them. Signed-off-by: Luiz Capitulino --- Makefile |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 85ad688..ea90c23 100644 --- a/Makefile +++ b/Makefile @@ -82,6 +82,12 @@ ALL_SUBDIRS=$(TARGET_DI

[Qemu-devel] [PATCH 01/20] Introduce qemu-objects.h header file

2009-12-10 Thread Luiz Capitulino
An easy way to include all QEMU objects. Signed-off-by: Luiz Capitulino --- qemu-objects.h | 24 1 files changed, 24 insertions(+), 0 deletions(-) create mode 100644 qemu-objects.h diff --git a/qemu-objects.h b/qemu-objects.h new file mode 100644 index 000..e1d1e

[Qemu-devel] [FOR 0.12 v5 00/20]: info handlers conversions to QObject

2009-12-10 Thread Luiz Capitulino
Hi, This submission is the most important one. :-) changelog - v4 -> v5 - Coding style fixes v3 -> v4 - do_info_name(): Return an empty dict if name == NULL - do_info_commands(): Return a dict - Don't use spaces nor '-' in json-object keys - Minor documention fixes v2 -> v3 - Chan

[Qemu-devel] Re: Guest bridge setup variations

2009-12-10 Thread Alexander Graf
On 10.12.2009, at 15:18, Arnd Bergmann wrote: > On Thursday 10 December 2009, Fischer, Anna wrote: >>> >>> 3. Doing the bridging in the NIC using macvlan in passthrough >>> mode. This lowers the CPU utilization further compared to 2, >>> at the expense of limiting throughput by the performance o

Re: [Qemu-devel] Re: [FOR 0.12 PATCH 2/4] pci: don't hw_error() when no slot is available.

2009-12-10 Thread Gleb Natapov
On Thu, Dec 10, 2009 at 08:04:56PM +0200, Michael S. Tsirkin wrote: > On Thu, Dec 10, 2009 at 03:22:52PM +0200, Gleb Natapov wrote: > > On Thu, Dec 10, 2009 at 02:23:05PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Dec 10, 2009 at 01:19:10PM +0100, Gerd Hoffmann wrote: > > > > Hi, > > > > > >

Re: [Qemu-devel] [PATCH 20/20] VNC: Convert do_info_vnc() to QObject

2009-12-10 Thread Luiz Capitulino
On Thu, 10 Dec 2009 09:30:16 -0600 Anthony Liguori wrote: > malc wrote: > > On Thu, 10 Dec 2009, Luiz Capitulino wrote: > > > > > >> Return a QDict with server information. Connected clients are returned > >> as a QList of QDicts. > >> > >> The new functions (vnc_qdict_remote_addr(), vnc_qdict

Re: [Qemu-devel] [PATCH 00/17] pci: switch a ton of drivers to symbolic names

2009-12-10 Thread Paul Brook
On Thursday 10 December 2009, Michael S. Tsirkin wrote: > The recent e1000 bug made the important of using > symbolic macros for pci config access clear for me. > So I started going over drivers and converting > to symbolic constants instead of hard-coded ones. > I did a large part until I run out

[Qemu-devel] Re: [PATCH] sparc32 fix carry flag handling (Solaris bootblk fix)

2009-12-10 Thread Artyom Tarasenko
2009/11/13 Blue Swirl : > On Fri, Nov 13, 2009 at 4:28 PM, Artyom Tarasenko > wrote: Could you describe the steps how to boot Solaris with OBP? I'm sure there are a lot of people who'd like to test if their favorite Sparc Solaris programs work on QEMU. >> >> Gathered things for whic

Re: [Qemu-devel] [PATCH 00/17] pci: switch a ton of drivers to symbolic names

2009-12-10 Thread Glauber Costa
On Thu, Dec 10, 2009 at 4:09 PM, Michael S. Tsirkin wrote: > The recent e1000 bug made the important of using > symbolic macros for pci config access clear for me. > So I started going over drivers and converting > to symbolic constants instead of hard-coded ones. > I did a large part until I run

[Qemu-devel] Re: [PATCH] e1000: fix init values for command register

2009-12-10 Thread Michael S. Tsirkin
On Wed, Dec 09, 2009 at 10:35:37PM +0200, Michael S. Tsirkin wrote: > Command register for e1000 was initialized to > values out of spec: all of bus master, > io, memory and interrupt disable bits were set. > > This breaks the device now that we actually respect > the interrupt disable bit, unless

[Qemu-devel] [PATCH 17/17] pci: remove unused macro

2009-12-10 Thread Michael S. Tsirkin
PCI_STATUS_DEVSEL is unused, and it also has a different name in pci_regs.h Remove. Signed-off-by: Michael S. Tsirkin --- hw/pci.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/pci.h b/hw/pci.h index 4015d45..475b044 100644 --- a/hw/pci.h +++ b/hw/pci.h @@ -167,7 +1

[Qemu-devel] [PATCH 16/17] usb-uhci: symbolic names for pci registers

2009-12-10 Thread Michael S. Tsirkin
No functional changes. I verified that the generated binary does not change. Signed-off-by: Michael S. Tsirkin --- hw/usb-ohci.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/usb-ohci.c b/hw/usb-ohci.c index 7ab3a98..deab7f3 100644 --- a/hw/usb-ohci.c +++ b/hw/

[Qemu-devel] [PATCH 15/17] usb-uhci: symbolic names for pci registers

2009-12-10 Thread Michael S. Tsirkin
No functional changes. I verified that the generated binary does not change. Signed-off-by: Michael S. Tsirkin --- hw/usb-uhci.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index ba26a4e..70a98c6 100644 --- a/hw/usb-uhci.c +++ b/hw

[Qemu-devel] [PATCH 14/17] ac97: symbolic names for pci registers

2009-12-10 Thread Michael S. Tsirkin
No functional changes. I verified that the generated binary does not change. Signed-off-by: Michael S. Tsirkin --- hw/ac97.c | 57 +++-- 1 files changed, 31 insertions(+), 26 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index 62e349a..431

[Qemu-devel] [PATCH 13/17] wdt_i6300esb: symbolic names for pci registers

2009-12-10 Thread Michael S. Tsirkin
No functional changes. I verified that the generated binary does not change. Signed-off-by: Michael S. Tsirkin --- hw/wdt_i6300esb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/wdt_i6300esb.c b/hw/wdt_i6300esb.c index 805b302..be0e89e 100644 --- a/hw/wdt_i6300esb

[Qemu-devel] [PATCH 12/17] es1370: symbolic names for pci registers

2009-12-10 Thread Michael S. Tsirkin
No functional changes. I verified that the generated binary does not change. Signed-off-by: Michael S. Tsirkin --- hw/es1370.c | 29 +++-- 1 files changed, 15 insertions(+), 14 deletions(-) diff --git a/hw/es1370.c b/hw/es1370.c index c358253..40cb48c 100644 --- a/hw/e

[Qemu-devel] [PATCH 11/17] pci: add another devsel macro

2009-12-10 Thread Michael S. Tsirkin
will be used by ensoniq emulation Signed-off-by: Michael S. Tsirkin --- hw/pci.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci.h b/hw/pci.h index 738506c..4015d45 100644 --- a/hw/pci.h +++ b/hw/pci.h @@ -166,6 +166,7 @@ typedef struct PCIIORegion { #define PCI_

[Qemu-devel] [PATCH 10/17] lsi: symbolic names for pci registers

2009-12-10 Thread Michael S. Tsirkin
No functional changes. I verified that the generated binary does not change. Signed-off-by: Michael S. Tsirkin --- hw/lsi53c895a.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c index 014c85d..463a889 100644 --- a/hw/lsi53c895a

[Qemu-devel] [PATCH 09/17] vmware_vga: symbolic names for pci registers

2009-12-10 Thread Michael S. Tsirkin
No functional changes. I verified that the generated binary does not change. Signed-off-by: Michael S. Tsirkin --- hw/vmware_vga.c | 20 +++- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index 240731a..d63306c 100644 --- a/hw

[Qemu-devel] [PATCH 08/17] cmd646: symbolic names for pci registers

2009-12-10 Thread Michael S. Tsirkin
No functional changes. I verified that the generated binary does not change. Signed-off-by: Michael S. Tsirkin --- hw/ide/cmd646.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index 3b7c606..086ff62 100644 --- a/hw/ide/cmd646.c

[Qemu-devel] [PATCH 07/17] piix: symbolic constants

2009-12-10 Thread Michael S. Tsirkin
No functional changes. I verified that the generated binary does not change. Signed-off-by: Michael S. Tsirkin --- hw/ide/piix.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index ec93f29..b1f66a5 100644 --- a/hw/ide/piix.c ++

[Qemu-devel] [PATCH 06/17] eepro100: symbolic names for pci registers

2009-12-10 Thread Michael S. Tsirkin
No functional changes. I verified that the generated binary does not change in meaningful ways. Survived light usage with linux guest. Signed-off-by: Michael S. Tsirkin --- hw/eepro100.c | 49 - 1 files changed, 32 insertions(+), 17 deletions(-)

[Qemu-devel] [PATCH 05/17] pci: add more status bits

2009-12-10 Thread Michael S. Tsirkin
will be used by eepro100. Signed-off-by: Michael S. Tsirkin --- hw/pci.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/pci.h b/hw/pci.h index dd61fa1..738506c 100644 --- a/hw/pci.h +++ b/hw/pci.h @@ -167,6 +167,8 @@ typedef struct PCIIORegion { #define PCI_STATUS_

[Qemu-devel] [PATCH 04/17] pcnet: switch to symbolic names for pci registers

2009-12-10 Thread Michael S. Tsirkin
No functional changes. I verified that the generated binary does not change. Signed-off-by: Michael S. Tsirkin --- hw/pci.h |1 + hw/pcnet.c | 26 +- 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/hw/pci.h b/hw/pci.h index d279e3f..dd61fa1 100644

[Qemu-devel] [PATCH 03/17] rtl: switch to symbolic names for pci registers

2009-12-10 Thread Michael S. Tsirkin
No functional changes. I verified that the generated binary does not change. Signed-off-by: Michael S. Tsirkin --- hw/rtl8139.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/rtl8139.c b/hw/rtl8139.c index 9fd05a8..2b2910d 100644 --- a/hw/rtl8139.c ++

[Qemu-devel] [PATCH 02/17] ne2000: switch to symbolic names for pci registers

2009-12-10 Thread Michael S. Tsirkin
No functional changes. I verified that the generated binary does not change. Signed-off-by: Michael S. Tsirkin --- hw/ne2000.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/ne2000.c b/hw/ne2000.c index d1416cf..78fe14f 100644 --- a/hw/ne2000.c +++ b/hw/ne2000.c @@

[Qemu-devel] [PATCH 01/17] e1000: switch to symbolic names for pci registers

2009-12-10 Thread Michael S. Tsirkin
No functional changes. I verified that the generated object binary does not change. Signed-off-by: Michael S. Tsirkin --- hw/e1000.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index ad7a267..300b11d 100644 --- a/hw/e1000.c +++ b/hw/

[Qemu-devel] [PATCH 00/17] pci: switch a ton of drivers to symbolic names

2009-12-10 Thread Michael S. Tsirkin
The recent e1000 bug made the important of using symbolic macros for pci config access clear for me. So I started going over drivers and converting to symbolic constants instead of hard-coded ones. I did a large part until I run out of steam. Maybe some brave soul will take up converting the rest o

Re: [Qemu-devel] Re: [FOR 0.12 PATCH 2/4] pci: don't hw_error() when no slot is available.

2009-12-10 Thread Michael S. Tsirkin
On Thu, Dec 10, 2009 at 03:22:52PM +0200, Gleb Natapov wrote: > On Thu, Dec 10, 2009 at 02:23:05PM +0200, Michael S. Tsirkin wrote: > > On Thu, Dec 10, 2009 at 01:19:10PM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > >>> +if (pci_dev == NULL) { > > >>> +hw_error("PCI: can't register

Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject

2009-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2009 at 03:49:20PM -0200, Luiz Capitulino wrote: > On Thu, 10 Dec 2009 17:38:13 + > "Daniel P. Berrange" wrote: > > > On Thu, Dec 10, 2009 at 02:54:57PM -0200, Luiz Capitulino wrote: > > > > An option we have is: libvirt actually uses four or five of those > > > info command

[Qemu-devel] Current state of qemu-system-mips

2009-12-10 Thread Palle Lyckegaard
Hi, what is the current state of the qemu-system-malta? When I try to run a NetBSD or Linux kernel the following message appears: ./git/qemu/mips-softmmu/qemu-system-mips -kernel ./netbsd_malta -m 64 -nographic qemu: hardware error: Unknown device 'smbus-eeprom' for bus 'I2C' CPU #0: pc=0xb

Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject

2009-12-10 Thread Luiz Capitulino
On Thu, 10 Dec 2009 17:38:13 + "Daniel P. Berrange" wrote: > On Thu, Dec 10, 2009 at 02:54:57PM -0200, Luiz Capitulino wrote: > > An option we have is: libvirt actually uses four or five of those > > info commands. So, we could drop all the rest and guarantee that > > only those libvirt one

[Qemu-devel] RE: Guest bridge setup variations

2009-12-10 Thread Fischer, Anna
> Subject: Guest bridge setup variations > > As promised, here is my small writeup on which setups I feel > are important in the long run for server-type guests. This > does not cover -net user, which is really for desktop kinds > of applications where you do not want to connect into the > guest f

Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject

2009-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2009 at 02:54:57PM -0200, Luiz Capitulino wrote: > On Thu, 10 Dec 2009 18:24:38 +0200 > Avi Kivity wrote: > > > > Let me put it another way, I don't think adding null to the json > > > parser and incorporating it into this command is a good idea at this > > > stage in the releas

Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject

2009-12-10 Thread Luiz Capitulino
On Thu, 10 Dec 2009 19:02:37 +0200 Avi Kivity wrote: > On 12/10/2009 06:54 PM, Luiz Capitulino wrote: > > On Thu, 10 Dec 2009 18:24:38 +0200 > > Avi Kivity wrote: > > > > > >>> Let me put it another way, I don't think adding null to the json > >>> parser and incorporating it into this comman

Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject

2009-12-10 Thread Avi Kivity
On 12/10/2009 06:54 PM, Luiz Capitulino wrote: On Thu, 10 Dec 2009 18:24:38 +0200 Avi Kivity wrote: Let me put it another way, I don't think adding null to the json parser and incorporating it into this command is a good idea at this stage in the release so if we want to do something like

Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject

2009-12-10 Thread Luiz Capitulino
On Thu, 10 Dec 2009 18:24:38 +0200 Avi Kivity wrote: > > Let me put it another way, I don't think adding null to the json > > parser and incorporating it into this command is a good idea at this > > stage in the release so if we want to do something like this, we need > > to defer it to 0.13.

Re: [Qemu-devel] [PATCH 0/7] Improve alpha-linux userspace emulation

2009-12-10 Thread Richard Henderson
On 12/09/2009 11:11 PM, Laurent Desnogues wrote: I don't know what FPU instructions gcc emits, but QEMU doesn't handle the rounding mode encoding. Ah yes, GCC does make use of those. If you're interested I started implementing that, though it's not complete (and it didn't fix the SPEC2k equak

Re: [Qemu-devel] [PATCH] Fixes a bug that tries to use the unimplemented function fdatasync on Mac OS X.

2009-12-10 Thread Pierre Riteau
On 9 déc. 2009, at 00:01, Alexander Graf wrote: > > Am 08.12.2009 um 19:35 schrieb Blue Swirl : > >> On Tue, Dec 8, 2009 at 4:35 PM, Pierre Riteau wrote: >>> On 1 oct. 2009, at 18:13, Blue Swirl wrote: >>> On Thu, Oct 1, 2009 at 6:30 PM, G 3 wrote: > On Sep 30, 2009, at 3:16 PM, Anth

[Qemu-devel] TCG is hard to understand!

2009-12-10 Thread Jun Koi
Hi, I am trying to understand how TCG works. For example, I look at the LLDT insn on x86. In target-i386/translate.c, we translate LLDT to TCG code, like below: static TCGv_i32 cpu_tmp2_i32; // 1 ... gen_ldst_modrm(s, modrm, OT_WORD, OR_TMP0, 0); // 2 gen_

Re: [Qemu-devel] [PATCH 3/3] qemu-img rebase

2009-12-10 Thread malc
On Thu, 10 Dec 2009, Kevin Wolf wrote: > This adds a rebase subcommand to qemu-img which allows to change the backing > file of an image. [..snip..] > +if ((optind >= argc) || !out_baseimg) > +help(); Coding style.. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject

2009-12-10 Thread Avi Kivity
On 12/10/2009 06:20 PM, Anthony Liguori wrote: By the same token, wouldn't you probably do: name = hpet_info.get('name', None) For name, yes. For an optional feature where you're interested in knowing both its existence and its value (if it exists), no. Let me put it another way, I don't

Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject

2009-12-10 Thread Anthony Liguori
Avi Kivity wrote: But we have two null conditions to check for, in an extendible dictionary: 1. The feature is unknown to qemu 2. The feature is known to qemu, but disabled So, "if 'field' in result:" tests the former, and "if result['field']:" tests the latter. In your example, a period of

Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject

2009-12-10 Thread Avi Kivity
On 12/10/2009 06:03 PM, Anthony Liguori wrote: Avi Kivity wrote: On 12/10/2009 02:56 PM, Anthony Liguori wrote: I'd prefer an empty dict. I actually prefer that over null. Depends. Key not present suggests the feature is not implemented. Value is null suggests the feature is not used.

Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject

2009-12-10 Thread Anthony Liguori
Avi Kivity wrote: On 12/10/2009 02:56 PM, Anthony Liguori wrote: I'd prefer an empty dict. I actually prefer that over null. Depends. Key not present suggests the feature is not implemented. Value is null suggests the feature is not used. Both key and value present suggest the feature

Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject

2009-12-10 Thread Avi Kivity
On 12/10/2009 05:55 PM, Avi Kivity wrote: On 12/10/2009 02:56 PM, Anthony Liguori wrote: I'd prefer an empty dict. I actually prefer that over null. Depends. Key not present suggests the feature is not implemented. Value is null suggests the feature is not used. Both key and value pres

Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject

2009-12-10 Thread Avi Kivity
On 12/10/2009 02:56 PM, Anthony Liguori wrote: I'd prefer an empty dict. I actually prefer that over null. Depends. Key not present suggests the feature is not implemented. Value is null suggests the feature is not used. Both key and value present suggest the feature is in implemented a

Re: [Qemu-devel] Re: [FOR 0.12 PATCH 0/4] misc bugfixes

2009-12-10 Thread Anthony Liguori
Michael S. Tsirkin wrote: On Thu, Dec 10, 2009 at 11:11:04AM +0100, Gerd Hoffmann wrote: Hi, A bunch of fixes for various bugs, mostly hotplug stuff found by Daniel. please apply, Gerd I am kind of confused by the FOR 0.12 prefix - these patches are not on master yet, are they?

[Qemu-devel] [PATCH 3/3] qemu-img rebase

2009-12-10 Thread Kevin Wolf
This adds a rebase subcommand to qemu-img which allows to change the backing file of an image. In default mode, both the current and the new backing file need to exist, and after the rebase, the COW image is guaranteed to have the same guest visible content as before. To achieve this, old and new

[Qemu-devel] [PATCH 2/3] block: Add bdrv_change_backing_file

2009-12-10 Thread Kevin Wolf
Introduce the functions needed to change the backing file of an image. The function is implemented for qcow2. Signed-off-by: Kevin Wolf --- block.c | 20 ++ block.h |2 + block/qcow2.c | 82 + block_int.h |

[Qemu-devel] [PATCH 0/3] Change the backing file of images

2009-12-10 Thread Kevin Wolf
This patch series adds the functionality to change the backing file of existing images. This includes simple renaming of a backing file without converting the COW image as well as safe rebasing onto a different backing file that has some changes compared to the current backing file. Kevin Wolf (3)

[Qemu-devel] [PATCH 1/3] block: Introduce BDRV_O_NO_BACKING

2009-12-10 Thread Kevin Wolf
If an image references a backing file that doesn't exist, qemu-img info fails to open this image. Exactly in this case the info would be valuable, though: the user might want to find out which file is missing. This patch introduces a BDRV_O_NO_BACKING flag to ignore the backing file when opening t

Re: [Qemu-devel] [PATCH 20/20] VNC: Convert do_info_vnc() to QObject

2009-12-10 Thread Anthony Liguori
malc wrote: On Thu, 10 Dec 2009, Luiz Capitulino wrote: Return a QDict with server information. Connected clients are returned as a QList of QDicts. The new functions (vnc_qdict_remote_addr(), vnc_qdict_local_addr() and put_addr_qdict()) are used to insert 'host' and 'service' information i

Re: [Qemu-devel] Using qemu-thread for synchronization

2009-12-10 Thread Glauber Costa
On Thu, Dec 10, 2009 at 12:46 PM, Liran Schour wrote: > > I want to be able to synchronize between the code that is running the live > migration with the code that call fro the completion callback of async IO. > For that I am using qemu-thread.c (i.e QemuCond). I see that I have > problems while l

Re: [Qemu-devel] [PATCH 20/20] VNC: Convert do_info_vnc() to QObject

2009-12-10 Thread malc
On Thu, 10 Dec 2009, Luiz Capitulino wrote: > Return a QDict with server information. Connected clients are returned > as a QList of QDicts. > > The new functions (vnc_qdict_remote_addr(), vnc_qdict_local_addr() and > put_addr_qdict()) are used to insert 'host' and 'service' information > in the

[Qemu-devel] Using qemu-thread for synchronization

2009-12-10 Thread Liran Schour
I want to be able to synchronize between the code that is running the live migration with the code that call fro the completion callback of async IO. For that I am using qemu-thread.c (i.e QemuCond). I see that I have problems while linking if I do not use --enable-io-thread. Can someone explain m

[Qemu-devel] [PATCH 20/20] VNC: Convert do_info_vnc() to QObject

2009-12-10 Thread Luiz Capitulino
Return a QDict with server information. Connected clients are returned as a QList of QDicts. The new functions (vnc_qdict_remote_addr(), vnc_qdict_local_addr() and put_addr_qdict()) are used to insert 'host' and 'service' information in the returned QDict. This patch is big, but I don't see how t

[Qemu-devel] [PATCH 19/20] PCI: Convert pci_device_hot_add() to QObject

2009-12-10 Thread Luiz Capitulino
Return a QDict with information about the just added device. This commit should not change user output. Please, note that this patch does not do error handling conversion. In error conditions the handler still calls monitor_printf(). Signed-off-by: Luiz Capitulino --- hw/pci-hotplug.c | 40 +

[Qemu-devel] [PATCH 18/20] char: Convert qemu_chr_info() to QObject

2009-12-10 Thread Luiz Capitulino
Each device is represented by a QDict. The returned QObject is a QList of all devices. This commit should not change user output. Signed-off-by: Luiz Capitulino --- monitor.c |3 ++- qemu-char.c | 43 +-- qemu-char.h |4 +++- 3 files changed,

[Qemu-devel] [PATCH 17/20] block: Convert bdrv_info_stats() to QObject

2009-12-10 Thread Luiz Capitulino
Each device statistic information is stored in a QDict and the returned QObject is a QList of all devices. This commit should not change user output. Signed-off-by: Luiz Capitulino --- block.c | 82 block.h |3 +- monitor.c

[Qemu-devel] [PATCH 16/20] block: Convert bdrv_info() to QObject

2009-12-10 Thread Luiz Capitulino
Each block device information is stored in a QDict and the returned QObject is a QList of all devices. This commit should not change user output. Signed-off-by: Luiz Capitulino --- Makefile |6 +- block.c | 123 +++-- block.h |

[Qemu-devel] [PATCH 15/20] migration: Convert do_info_migrate() to QObject

2009-12-10 Thread Luiz Capitulino
Return a QDict, which may contain up to more two QDicts, depending on the type of migration we're performing. IMPORTANT: as a QInt stores a int64_t integer, RAM values are going to be stored as int64_t and not as uint64_t as they are today. If this is a problem QInt will have to be changed. This

[Qemu-devel] [PATCH 14/20] monitor: Convert do_info_mice() to QObject

2009-12-10 Thread Luiz Capitulino
Each mouse is represented by a QDict, the returned QObject is a QList of all mice. This commit should not change user output. Signed-off-by: Luiz Capitulino --- console.h |3 +- monitor.c |3 +- vl.c | 62 ++-- 3 files chang

[Qemu-devel] [PATCH 13/20] monitor: Convert do_info_uuid() to QObject

2009-12-10 Thread Luiz Capitulino
snprintf() is used because the UUID_FMT is too complex for qobject_from_jsonf(). Signed-off-by: Luiz Capitulino --- monitor.c | 26 +++--- 1 files changed, 23 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index a824648..0163c07 100644 --- a/monitor.c +++

[Qemu-devel] [PATCH 12/20] monitor: Convert do_info_hpet() to QObject

2009-12-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c | 24 +--- 1 files changed, 21 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index a2433e9..a824648 100644 --- a/monitor.c +++ b/monitor.c @@ -597,10 +597,27 @@ static void do_info_commands(Monitor *mon, QObjec

[Qemu-devel] [PATCH 11/20] monitor: Convert do_info_name() to QObject

2009-12-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c | 32 1 files changed, 28 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 3f26c5a..a2433e9 100644 --- a/monitor.c +++ b/monitor.c @@ -514,10 +514,33 @@ static void do_info_version(Monitor *mon,

[Qemu-devel] [PATCH 10/20] monitor: Convert do_info_kvm() to QObject

2009-12-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c | 41 + 1 files changed, 33 insertions(+), 8 deletions(-) diff --git a/monitor.c b/monitor.c index 01d5827..3f26c5a 100644 --- a/monitor.c +++ b/monitor.c @@ -1806,16 +1806,40 @@ static void tlb_info(Monitor *

  1   2   >