[Qemu-devel] [PATCH 1/2] qemu-kvm: Introduce wrapper functions to access phys_ram_dirty.

2010-03-17 Thread Yoshiaki Tamura
Adds wrapper functions to prevent direct access to the phys_ram_dirty bitmap. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Signed-off-by: OHMURA Kei ohmura@lab.ntt.co.jp --- cpu-all.h | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff

Re: [Qemu-devel] Re: [PATCH, RFC] Replace assert(0) with abort() or cpu_abort()

2010-03-17 Thread Paolo Bonzini
On 03/16/2010 06:55 PM, Jamie Lokier wrote: A guest program is also allowed to trap SIGABRT with a signal handler, and that does have some uses. E.g. cleaning up temporary files and shmem segments following a crash when calling 3rd party code. Whatever the guest does with SIGABRT, it should

[Qemu-devel] Re: 2 serial ports?

2010-03-17 Thread Gerd Hoffmann
On 03/17/10 09:38, Michael Tokarev wrote: Since 0.12, it appears that kvm does not allow more than 2 serial ports for a guest: $ kvm \ -serial unix:s1,server,nowait \ -serial unix:s2,server,nowait \ -serial unix:s3,server,nowait isa irq 4 already assigned Is there a work-around for this?

[Qemu-devel] Re: 2 serial ports?

2010-03-17 Thread Michael Tokarev
Gerd Hoffmann wrote: On 03/17/10 09:38, Michael Tokarev wrote: Since 0.12, it appears that kvm does not allow more than 2 serial ports for a guest: $ kvm \ -serial unix:s1,server,nowait \ -serial unix:s2,server,nowait \ -serial unix:s3,server,nowait isa irq 4 already assigned Is

[Qemu-devel] Re: [PATCHv5 11/11] virtio-net: vhost net support

2010-03-17 Thread Michael S. Tsirkin
On Tue, Mar 16, 2010 at 07:57:51PM +0100, Juan Quintela wrote: Michael S. Tsirkin m...@redhat.com wrote: This connects virtio-net to vhost net backend. The code is structured in a way analogous to what we have with vnet header capability in tap. We start/stop backend on driver

[Qemu-devel] Re: [PATCHv5 04/11] virtio: notifier support + APIs for queue fields

2010-03-17 Thread Michael S. Tsirkin
On Wed, Mar 17, 2010 at 09:44:05AM +0530, Amit Shah wrote: On (Tue) Mar 16 2010 [19:10:58], Michael S. Tsirkin wrote: diff --git a/hw/virtio.c b/hw/virtio.c index 7c020a3..f54129f 100644 --- a/hw/virtio.c +++ b/hw/virtio.c @@ -73,6 +73,9 @@ struct VirtQueue int inuse;

[Qemu-devel] [PATCHv6 00/11] vhost-net: upstream integration

2010-03-17 Thread Michael S. Tsirkin
Here's a patchset with vhost support for upstream qemu, rebased to latest bits, and with all comments I'm aware of addressed. Please consider for merging. Changes from v5: address minor comments by Amit and Juan Changes from v4: address amit's style comments: mostly renaming for clarity

[Qemu-devel] [PATCHv6 01/11] tap: add interface to get device fd

2010-03-17 Thread Michael S. Tsirkin
Will be used by vhost to attach/detach to backend. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- net/tap.c |7 +++ net/tap.h |2 ++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index 7a7320c..fc59fd4 100644 --- a/net/tap.c +++

Re: [Qemu-devel] Re: 2 serial ports?

2010-03-17 Thread Paul Brook
Oh, well, yes, I remember. qemu is more strict on ISA irq sharing now. A bit too strict. /me goes dig out a old patch which never made it upstream for some reason I forgot. Attached. This is wrong. Two devices should never be manipulating the same qemu_irq object. If you want multiple

[Qemu-devel] [PATCHv6 09/11] tap: add vhost/vhostfd options

2010-03-17 Thread Michael S. Tsirkin
This adds vhost binary option to tap, to enable vhost net accelerator. Default is off for now, we'll be able to make default on long term when we know it's stable. vhostfd option can be used by management, to pass in the fd. Assigning vhostfd implies vhost=on. Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PATCHv6 11/11] virtio-net: vhost net support

2010-03-17 Thread Michael S. Tsirkin
This connects virtio-net to vhost net backend. The code is structured in a way analogous to what we have with vnet header capability in tap. We start/stop backend on driver start/stop as well as on save and vm start (for migration). Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PATCHv6 10/11] tap: add API to retrieve vhost net header

2010-03-17 Thread Michael S. Tsirkin
will be used by virtio-net for vhost net support Signed-off-by: Michael S. Tsirkin m...@redhat.com --- net/tap.c |7 +++ net/tap.h |3 +++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index 19c4fa2..35c05d7 100644 --- a/net/tap.c +++

[Qemu-devel] [PATCHv6 04/11] virtio: notifier support + APIs for queue fields

2010-03-17 Thread Michael S. Tsirkin
vhost needs physical addresses for ring and other queue fields, so add APIs for these. In particular, add binding API to set host/guest notifiers. Will be used by vhost. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.c | 80

[Qemu-devel] [PATCHv6 03/11] notifier: event notifier implementation

2010-03-17 Thread Michael S. Tsirkin
event notifiers are slightly generalized eventfd descriptors. Current implementation depends on eventfd because vhost is the only user, and vhost depends on eventfd anyway, but a stub is provided for non-eventfd case. We'll be able to further generalize this when another user comes along and we

[Qemu-devel] [PATCHv6 05/11] virtio: add set_status callback

2010-03-17 Thread Michael S. Tsirkin
vhost net backend needs to be notified when frontend status changes. Add a callback, similar to set_features. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/s390-virtio-bus.c |2 +- hw/syborg_virtio.c |2 +- hw/virtio-pci.c |5 +++-- hw/virtio.h |9

[Qemu-devel] [PATCHv6 07/11] virtio-pci: fill in notifier support

2010-03-17 Thread Michael S. Tsirkin
Support host/guest notifiers in virtio-pci. The last one only with kvm, that's okay because vhost relies on kvm anyway. Note on kvm usage: kvm ioeventfd API is implemented on non-kvm systems as well, this is the reason we don't need if (kvm_enabled()) around it. Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PATCHv6 08/11] vhost: vhost net support

2010-03-17 Thread Michael S. Tsirkin
This adds vhost net device support in qemu. Will be tied to tap device and virtio by following patches. Raw backend is currently missing, will be worked on/submitted separately. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Makefile.target |2 + configure | 37 +++

[Qemu-devel] [PATCHv6 06/11] virtio: move typedef to qemu-common

2010-03-17 Thread Michael S. Tsirkin
make it possible to use type without header include, simplifying header dependencies. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.h |1 - qemu-common.h |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/virtio.h b/hw/virtio.h index

Re: [Qemu-devel] [PATCH 0/6] Multi-level page tables and userland mapping fixes, v3

2010-03-17 Thread Riku Voipio
On Mon, Mar 15, 2010 at 04:08:46PM +0100, Jan-Simon Möller wrote: Am Montag, 15. März 2010 15:48:03 schrieb Riku Voipio: On Mon, Mar 15, 2010 at 01:46:10PM +0100, Jan-Simon Möller wrote: r...@frodo:/# qemu-arm -strace /sbin/ldconfig.real 16359 uname(0x403fef78) = 0 16359 brk(NULL) =

[Qemu-devel] Re: virtio-serial NULL deference

2010-03-17 Thread Amit Shah
On (Tue) Mar 09 2010 [20:59:58], Amit Shah wrote: On (Tue) Mar 09 2010 [14:15:45], Juan Quintela wrote: Hi Amit Hey Juan, Checking migration, I just found this problem: I don't know what to put there. a return -EINVAL or continue? Looking more at the code, I am not sure what

Re: [Qemu-devel] [PATCH] pcnet: make subsystem vendor id match hardware

2010-03-17 Thread Michael S. Tsirkin
On Tue, Mar 16, 2010 at 10:29:43PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: Real pcnet device (AT2450) apparently has subsystem device and vendor id set to 0, this is out of spec (which requires that vendor id is obtained from PCI SIG) but windows xp driver seems to need this

[Qemu-devel] [PATCH 001/399] target-arm: Fix handling of AL condition in IT instruction

2010-03-17 Thread Johan Bengtsson
Do not try to insert a conditional jump over next instruction when the condition code is AL as this will trigger an internal error. Signed-off-by: Johan Bengtsson teofrast...@gmail.com --- target-arm/translate.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 0/6] Multi-level page tables and userland mapping fixes, v3

2010-03-17 Thread Richard Henderson
On 03/17/2010 04:48 AM, Riku Voipio wrote: page_check_range: -if (start + len start) -/* we've wrapped around */ ... +if (start + len - 1 start) { +/* We've wrapped around. */ This now blows up with len = 0; Confirmed. A quick test with if (len 0) around

Re: [Qemu-devel] [PATCH 4/4] tcg-hppa: Compute is_write in cpu_signal_handler.

2010-03-17 Thread Richard Henderson
On 03/16/2010 07:23 PM, Stuart Brady wrote: On Wed, Mar 17, 2010 at 02:10:43AM +, Stuart Brady wrote: Argh. It just seems mind bogglingly silly that is_write doesn't seem to be included in the siginfo on archs where doing so would make sense... It's at least something I'd have hoped

Re: [Qemu-devel] [PATCH 3/4] tcg-hppa: Finish the port.

2010-03-17 Thread Richard Henderson
On 03/16/2010 06:58 PM, Stuart Brady wrote: The tcg_reg_free() calls worry me slightly, but I assume they're safe... Yeah, that one's rather gross. Since Aurelien's generic div/rem patch I could simply remove all that millicode stuff, including that tcg_reg_free, and let the generic code handle

[Qemu-devel] [PATCH QEMU] Transparent Hugepage Support #3

2010-03-17 Thread Andrea Arcangeli
From: Andrea Arcangeli aarca...@redhat.com This will allow proper alignment so NPT/EPT can take advantage of linux host backing the guest memory with hugepages. It also ensures that when KVM isn't used the first 2M of guest physical memory are backed by a large TLB. To complete it, it will also

Re: [Qemu-devel] [PATCH QEMU] Transparent Hugepage Support #3

2010-03-17 Thread Paul Brook
+ if (size = PREFERRED_RAM_ALIGN) + new_block-host = qemu_memalign(PREFERRED_RAM_ALIGN, size); Is this deliberately bigger-than rather than multiple-of? Having the size not be a multiple of alignment seems somewhat strange, it's always going to be wrong at one end...

Re: [Qemu-devel] [PATCH QEMU] Transparent Hugepage Support #3

2010-03-17 Thread Andrea Arcangeli
On Wed, Mar 17, 2010 at 03:05:57PM +, Paul Brook wrote: + if (size = PREFERRED_RAM_ALIGN) + new_block-host = qemu_memalign(PREFERRED_RAM_ALIGN, size); Is this deliberately bigger-than rather than multiple-of? Having the size not be a multiple of alignment seems

Re: [Qemu-devel] [PATCH QEMU] Transparent Hugepage Support #3

2010-03-17 Thread Paul Brook
On Wed, Mar 17, 2010 at 03:05:57PM +, Paul Brook wrote: + if (size = PREFERRED_RAM_ALIGN) + new_block-host = qemu_memalign(PREFERRED_RAM_ALIGN, size); Is this deliberately bigger-than rather than multiple-of? Having the size not be a multiple of alignment

Re: [Qemu-devel] [PULL] e100/pci fixes

2010-03-17 Thread Anthony Liguori
On 03/16/2010 09:56 AM, Michael S. Tsirkin wrote: The following changes since commit cb66ffcf9e298dc1bfc11682172ff9472bcd4495: Kevin Wolf (1): qemu-img rebase: Document -f option are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git

Re: [Qemu-devel] [PULL v2] Convert device_add to QObject / QError

2010-03-17 Thread Anthony Liguori
On 03/16/2010 01:31 PM, Markus Armbruster wrote: Anthony ran into conflicts and asked me to rebase and send out a pull request. Complete list of conflicts: * qdev: Improve diagnostics for bad property values commit 6bf38816df80a3b50529119c5458b151b3e2c728 Adds two new errors to

Re: [Qemu-devel] [PATCH] better describe -net options

2010-03-17 Thread Anthony Liguori
On 03/05/2010 03:07 PM, Brian Thomason wrote: The manpage reflects that multiple -net user calls may be made, but if this is done, it can cause the program to hang. Instead, multiple -net calls can be combined into one, and this patch adds that information to qemu-options.hx. Also, -net user may

Re: [Qemu-devel] [PATCH QEMU] Transparent Hugepage Support #3

2010-03-17 Thread Andrea Arcangeli
On Wed, Mar 17, 2010 at 03:21:26PM +, Paul Brook wrote: On Wed, Mar 17, 2010 at 03:05:57PM +, Paul Brook wrote: + if (size = PREFERRED_RAM_ALIGN) + new_block-host = qemu_memalign(PREFERRED_RAM_ALIGN, size); Is this deliberately bigger-than rather

Re: [Qemu-devel] [PATCH] Use snapshots from backing disks

2010-03-17 Thread Anthony Liguori
On 03/08/2010 07:13 PM, Rob Earhart wrote: Modify the snapshot load path to find and load snapshots contained in backing disks, useful when the current disk is a differencing disk. Add the source of a snapshot when listing snapshots. This should only break backwards compatibility for scenarios

Re: [Qemu-devel] [PATCH QEMU] Transparent Hugepage Support #3

2010-03-17 Thread Paul Brook
Size not multiple I think is legitimate, the below-4G chunk isn't required to end 2M aligned, all it matters is that the above-4G then starts aligned. In short one thing to add in the future as parameter to qemu_ram_alloc is the physical address that the host virtual address

Re: [Qemu-devel] [PATCH QEMU] Transparent Hugepage Support #3

2010-03-17 Thread Andrea Arcangeli
On Wed, Mar 17, 2010 at 03:52:15PM +, Paul Brook wrote: Size not multiple I think is legitimate, the below-4G chunk isn't required to end 2M aligned, all it matters is that the above-4G then starts aligned. In short one thing to add in the future as parameter to qemu_ram_alloc

Re: [Qemu-devel] [PATCH] block: add logical_block_size property

2010-03-17 Thread Anthony Liguori
On 03/04/2010 07:20 AM, Christoph Hellwig wrote: Add a logical block size attribute as various guest side tools only increase the filesystem sector size based on it, not the advisory physical block size. For scsi we already have support for a different logical block size in place for CDROMs

Re: [Qemu-devel] [PATCH] sdl: improve error message on fatal error

2010-03-17 Thread Anthony Liguori
On 03/08/2010 06:07 AM, Bjørn Mork wrote: The SDL_SetVideoMode() error condition is easily triggered by a user by simply configure a guest with a host unsupported display resolution and attempting to enable fullscreen. Since the error is fatal, adding a bit of debugging help can't harm. Sample

Re: [Qemu-devel] [PATCH] [TRIVIAL] usb-linux: remove unreachable default in switch statement

2010-03-17 Thread Anthony Liguori
On 03/08/2010 06:58 AM, Paul Bolle wrote: Signed-off-by: Paul Bollepebo...@tiscali.nl Applied. Thanks. Regards, Anthony Liguori --- usb-linux.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index a9c15c6..23155dd 100644 ---

Re: [Qemu-devel] [PATCH] Fix SIGFPE for vnc display of width/height = 1

2010-03-17 Thread Anthony Liguori
On 03/08/2010 08:34 AM, Chris Webb wrote: During boot, the screen gets resized to height 1 and a mouse click at this point will cause a division by zero when calculating the absolute pointer position from the pixel (x, y). Return a click in the middle of the screen instead in this case.

Re: [Qemu-devel] [PATCH] balloon: Do not save VM state wrt asynchronous virtio operations

2010-03-17 Thread Anthony Liguori
On 03/09/2010 12:54 PM, Adam Litke wrote: When working with the VM state (for loadvm/savevm and migration), it is not valid to load and store pointers since the validity of those pointers cannot be assured in the new qemu address space. Therefore, virtio_balloon_save() and virtio_balloon_load()

Re: [Qemu-devel] Re: [PATCH 2/6] qemu-kvm: Modify and introduce wrapper functions to access phys_ram_dirty.

2010-03-17 Thread Paul Brook
On 03/16/2010 10:10 PM, Blue Swirl wrote: Yes, and is what tlb_protect_code() does and it's called from tb_alloc_page() which is what's code when a TB is created. Just a tangential note: a long time ago, I tried to disable self modifying code detection for Sparc. On most RISC

Re: [Qemu-devel] [PATCH QEMU] Transparent Hugepage Support #3

2010-03-17 Thread Paul Brook
On Wed, Mar 17, 2010 at 03:52:15PM +, Paul Brook wrote: Size not multiple I think is legitimate, the below-4G chunk isn't required to end 2M aligned, all it matters is that the above-4G then starts aligned. In short one thing to add in the future as parameter to

Re: [Qemu-devel] [PATCH 1/2] QError: New QERR_DEVICE_NOT_ENCRYPTED

2010-03-17 Thread Anthony Liguori
On 03/05/2010 04:25 PM, Shahar Havivi wrote: Signed-off-by: Shahar Havivishah...@redhat.com Applied. Thanks. Regards, Anthony Liguori --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index

Re: [Qemu-devel] [PATCH QEMU] Transparent Hugepage Support #3

2010-03-17 Thread Andrea Arcangeli
On Wed, Mar 17, 2010 at 04:07:09PM +, Paul Brook wrote: On Wed, Mar 17, 2010 at 03:52:15PM +, Paul Brook wrote: Size not multiple I think is legitimate, the below-4G chunk isn't required to end 2M aligned, all it matters is that the above-4G then starts aligned. In

Re: [Qemu-devel] [PATCH] [TRIVIAL] usb-linux: remove unreachable default in switch statement

2010-03-17 Thread Paul Bolle
On Wed, 2010-03-17 at 10:59 -0500, Anthony Liguori wrote: On 03/08/2010 06:58 AM, Paul Bolle wrote: Signed-off-by: Paul Bollepebo...@tiscali.nl Applied. Thanks. Paul Brook was tempted to replace it by an abort() (about one and a half week ago). Did you perhaps miss that message or

Re: [Qemu-devel] [PATCH] better describe -net options

2010-03-17 Thread Jamie Lokier
Anthony Liguori wrote: On 03/05/2010 03:07 PM, Brian Thomason wrote: The manpage reflects that multiple -net user calls may be made, but if this is done, it can cause the program to hang. Instead, multiple -net calls can be combined into one, and this patch adds

Re: [Qemu-devel] Re: [PATCH 2/6] qemu-kvm: Modify and introduce wrapper functions to access phys_ram_dirty.

2010-03-17 Thread Avi Kivity
On 03/17/2010 06:06 PM, Paul Brook wrote: On 03/16/2010 10:10 PM, Blue Swirl wrote: Yes, and is what tlb_protect_code() does and it's called from tb_alloc_page() which is what's code when a TB is created. Just a tangential note: a long time ago, I tried to disable self

Re: [Qemu-devel] [PATCH] [TRIVIAL] usb-linux: remove unreachable default in switch statement

2010-03-17 Thread Anthony Liguori
On 03/17/2010 11:14 AM, Paul Bolle wrote: On Wed, 2010-03-17 at 10:59 -0500, Anthony Liguori wrote: On 03/08/2010 06:58 AM, Paul Bolle wrote: Signed-off-by: Paul Bollepebo...@tiscali.nl Applied. Thanks. Paul Brook was tempted to replace it by an abort() (about one

Re: [Qemu-devel] [PATCH] better describe -net options

2010-03-17 Thread Anthony Liguori
On 03/17/2010 11:13 AM, Jamie Lokier wrote: Anthony Liguori wrote: On 03/05/2010 03:07 PM, Brian Thomason wrote: The manpage reflects that multiple -net user calls may be made, but if this is done, it can cause the program to hang. Instead, multiple -net calls can be

[Qemu-devel] [PATCH] monitor: convert do_device_del() to QObject, QError

2010-03-17 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qdev.c |7 --- hw/qdev.h |2 +- qemu-monitor.hx |3 ++- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 17a46a7..35460eb 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@

Re: [Qemu-devel] [PATCH] Fix SIGFPE for vnc display of width/height = 1

2010-03-17 Thread Alexander Graf
Anthony Liguori wrote: On 03/08/2010 08:34 AM, Chris Webb wrote: During boot, the screen gets resized to height 1 and a mouse click at this point will cause a division by zero when calculating the absolute pointer position from the pixel (x, y). Return a click in the middle of the screen

Re: [Qemu-devel] [PATCH 1/2] migration: Clear fd also in error cases

2010-03-17 Thread Anthony Liguori
On 03/09/2010 05:10 PM, Juan Quintela wrote: Not clearing the fd and closing the file makes qemu spin using 100%CPU after incoming migration error. See for instance bug: https://bugzilla.redhat.com/show_bug.cgi?id=518032 Signed-off-by: Juan Quintelaquint...@redhat.com Applied all.

Re: [Qemu-devel] [PATCH] hw/usb-msd: fix some usb requests

2010-03-17 Thread Anthony Liguori
On 03/10/2010 03:45 AM, Arnaud Patard (Rtp) wrote: The usb-msd device emulation needs some small tweaks in the requests emulations. For instance, the reset/maxlun requests are class/interface specific so requests for them with the type class and recipient interface bits sets have to be handled.

Re: [Qemu-devel] [PATCH 01/18] avoid dubiously clever code in win32_start_timer

2010-03-17 Thread Anthony Liguori
On 03/10/2010 04:38 AM, Paolo Bonzini wrote: The code is initializing an unsigned int to UINT_MAX using -1, so that the following always-true comparison seems to be always-false at a first look. Since alarm timer initializations are never nested, it is simpler to unconditionally store the

Re: [Qemu-devel] [PATCH] vnc: add no-lock-key-sync option

2010-03-17 Thread Anthony Liguori
On 03/10/2010 10:12 AM, Gerd Hoffmann wrote: Add an option to disable the heuristics which try to keep capslock and numlock state for guest and host in sync. Signed-off-by: Gerd Hoffmannkra...@redhat.com Applied. Thanks. Regards, Anthony Liguori --- vnc.c | 16

Re: [Qemu-devel] [PATCH] scsi-disk: fix buffer overflow

2010-03-17 Thread Anthony Liguori
On 03/10/2010 10:47 AM, Gerd Hoffmann wrote: In case s-version is shorter than 4 bytes we overflow the memcpy src buffer. Fix it by clearing the target buffer, then copy only the amount of bytes we actually have. Signed-off-by: Gerd Hoffmannkra...@redhat.com Applied. Thanks. Regards,

Re: [Qemu-devel] [PATCH v2 1/2] read-only: minor cleanup

2010-03-17 Thread Anthony Liguori
On 03/14/2010 08:19 AM, Naphtali Sprei wrote: Really use read-only flags for opening the file when asked for read-only Signed-off-by: Naphtali Spreinsp...@redhat.com Applied all. Thanks. Regards, Anthony Liguori --- qemu-nbd.c |1 + 1 files changed, 1 insertions(+), 0

Re: [Qemu-devel] [PATCH 3/4] tcg-hppa: Finish the port.

2010-03-17 Thread Richard Henderson
On 03/17/2010 07:56 AM, Richard Henderson wrote: Since Aurelien's generic div/rem patch I could simply remove all that millicode stuff, including that tcg_reg_free, and let the generic code handle this instead. Which would get to the same millicode routine via one or two extra levels of

Re: [Qemu-devel] [PATCH] [TRIVIAL] usb-linux: remove unreachable default in switch statement

2010-03-17 Thread Paul Brook
On 03/17/2010 11:14 AM, Paul Bolle wrote: On Wed, 2010-03-17 at 10:59 -0500, Anthony Liguori wrote: On 03/08/2010 06:58 AM, Paul Bolle wrote: Signed-off-by: Paul Bollepebo...@tiscali.nl Applied. Thanks. Paul Brook was tempted to replace it by an abort() (about one and a half week

Re: [Qemu-devel] [PATCH] [TRIVIAL] usb-linux: remove unreachable default in switch statement

2010-03-17 Thread Anthony Liguori
On 03/17/2010 12:08 PM, Paul Brook wrote: On 03/17/2010 11:14 AM, Paul Bolle wrote: On Wed, 2010-03-17 at 10:59 -0500, Anthony Liguori wrote: On 03/08/2010 06:58 AM, Paul Bolle wrote: Signed-off-by: Paul Bollepebo...@tiscali.nl Applied. Thanks.

Re: [Qemu-devel] [PATCH] [TRIVIAL] usb-linux: remove unreachable default in switch statement

2010-03-17 Thread Paul Brook
If something should never happen (as in this case) then an abort/assert is completely appropriate. Once things get that screwed up there's no right answer, and the best thing we can do is terminate immediately to try and avoid further damage. This case was: switch (foo 0x03) { case

Re: [Qemu-devel] [PATCH 08/16] tap: insert tap_can_send() into tap_send()

2010-03-17 Thread Anthony Liguori
On 03/11/2010 10:55 AM, Juan Quintela wrote: This way we can remove the poll test Signed-off-by: Juan Quintelaquint...@redhat.com Won't this cause unnecessary wake ups? Right now, we use the can_read() poll function to determine whether to add an fd to a fdset. With this patch, we

Re: [Qemu-devel] [PATCH] Support for multiple keyboard device

2010-03-17 Thread Anthony Liguori
On 03/11/2010 03:57 PM, Shahar Havivi wrote: Currently qemu use the last keyboard device that added, When removing keyboard (via device_del kbd) you get segfault next time you try to write in the client. i.e. start qemu x86_64-softmmu/qemu-system-x86_64 -usb -device usb-kbd,id=kbd switch to

[Qemu-devel] [PATCH 3/6] error: Trim includes after Infrastructure to track locations...

2010-03-17 Thread Markus Armbruster
Missed in commit 827b0813. Signed-off-by: Markus Armbruster arm...@redhat.com --- monitor.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/monitor.h b/monitor.h index bd4ae34..5bdeed1 100644 --- a/monitor.h +++ b/monitor.h @@ -3,7 +3,6 @@ #include qemu-common.h

[Qemu-devel] [PATCH 0/6] error: Clean up after recent changes

2010-03-17 Thread Markus Armbruster
Cleaner integration of location tracking with qemu-tool.c. Move qerror_report() where it belongs. Markus Armbruster (6): error: Trim includes after Move qemu_error friends... error: Trim includes in qerror.c error: Trim includes after Infrastructure to track locations... error: Make use

[Qemu-devel] [PATCH 1/6] error: Trim includes after Move qemu_error friends...

2010-03-17 Thread Markus Armbruster
Missed in commit 2f792016. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qdev-properties.c |1 + monitor.c|2 -- sysemu.h |2 -- 3 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index

[Qemu-devel] [PATCH 6/6] error: Move qerror_report() from qemu-error.[ch] to qerror.[ch]

2010-03-17 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-error.c | 18 -- qemu-error.h |6 -- qerror.c | 20 qerror.h |5 + 4 files changed, 25 insertions(+), 24 deletions(-) diff --git a/qemu-error.c b/qemu-error.c index

[Qemu-devel] [PATCH 4/6] error: Make use of error_set_progname() optional

2010-03-17 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-error.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-error.c b/qemu-error.c index 5d5fe37..9b9c0a1 100644 --- a/qemu-error.c +++ b/qemu-error.c @@ -167,7 +167,7 @@ void error_print_loc(void) int i;

[Qemu-devel] [PATCH 2/6] error: Trim includes in qerror.c

2010-03-17 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qerror.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/qerror.c b/qerror.c index d0aba61..ff2fbd5 100644 --- a/qerror.c +++ b/qerror.c @@ -11,9 +11,7 @@ */ #include qjson.h #include qerror.h -#include

Re: [Qemu-devel] [PATCH] Use snapshots from backing disks

2010-03-17 Thread Rob Earhart
On Wed, Mar 17, 2010 at 8:35 AM, Anthony Liguori anth...@codemonkey.wswrote: On 03/08/2010 07:13 PM, Rob Earhart wrote: Modify the snapshot load path to find and load snapshots contained in backing disks, useful when the current disk is a differencing disk. Add the source of a snapshot

[Qemu-devel] Re: guest kernel debugging through serial port

2010-03-17 Thread Neo Jia
Here is what I have asked before. The problem that I want to assign a real serial port to the guest is that the debugging through network becomes really slow. Thanks, Neo On Thu, Mar 11, 2010 at 2:44 AM, Neo Jia neo...@gmail.com wrote: hi, I have followed the windows guest debugging procedure

[Qemu-devel] Locking block devices for concurrent access?

2010-03-17 Thread Michael Tokarev
I remember quite long discussion about this issue a while back. But unfortunately, a) I can't find it now, and b) as far as I remember, there was no definitive solution presented at that time. So I thought it's Ok to ask again to get more conclusive answer... The original problem is that

Re: [Qemu-devel] Re: [PATCH, RFC] Replace assert(0) with abort() or cpu_abort()

2010-03-17 Thread Blue Swirl
On 3/17/10, Paolo Bonzini pbonz...@redhat.com wrote: On 03/16/2010 06:55 PM, Jamie Lokier wrote: A guest program is also allowed to trap SIGABRT with a signal handler, and that does have some uses. E.g. cleaning up temporary files and shmem segments following a crash when calling 3rd

Re: [Qemu-devel] [PATCH 5/6] error: Link qemu-img, qemu-nbd, qemu-io with qemu-error.o

2010-03-17 Thread Blue Swirl
On 3/17/10, Markus Armbruster arm...@redhat.com wrote: The location tracking interface is used by code shared with qemi-img, qemu-nbd and qemu-io, so it needs to be available there. Commit 827b0813 provides it in a rather hamfisted way: it adds a dummy implementation to qemu-tool.c.

Re: [Qemu-devel] [PATCH 3/4] tcg-hppa: Finish the port.

2010-03-17 Thread Stuart Brady
On Wed, Mar 17, 2010 at 07:56:12AM -0700, Richard Henderson wrote: On 03/16/2010 06:58 PM, Stuart Brady wrote: The tcg_reg_free() calls worry me slightly, but I assume they're safe... Yeah, that one's rather gross. Since Aurelien's generic div/rem patch I could simply remove all that

Re: [Qemu-devel] [PATCH] [TRIVIAL] usb-linux: remove unreachable default in switch statement

2010-03-17 Thread Blue Swirl
On 3/17/10, Paul Brook p...@codesourcery.com wrote: If something should never happen (as in this case) then an abort/assert is completely appropriate. Once things get that screwed up there's no right answer, and the best thing we can do is terminate immediately to try and avoid

Re: [Qemu-devel] [PATCH] [TRIVIAL] usb-linux: remove unreachable default in switch statement

2010-03-17 Thread Anthony Liguori
On 03/17/2010 03:15 PM, Blue Swirl wrote: On 3/17/10, Paul Brookp...@codesourcery.com wrote: If something should never happen (as in this case) then an abort/assert is completely appropriate. Once things get that screwed up there's no right answer, and the best thing

Re: [Qemu-devel] [PATCH] [TRIVIAL] usb-linux: remove unreachable default in switch statement

2010-03-17 Thread Paul Bolle
On Wed, 2010-03-17 at 15:41 -0500, Anthony Liguori wrote: On 03/17/2010 03:15 PM, Blue Swirl wrote: This breaks build (gcc 4.3.2): CCusb-linux.o cc1: warnings being treated as errors /src/qemu/usb-linux.c: In function 'usb_linux_update_endp_table': /src/qemu/usb-linux.c:759:

Re: [Qemu-devel] [PATCH] [TRIVIAL] usb-linux: remove unreachable default in switch statement

2010-03-17 Thread Anthony Liguori
On 03/17/2010 03:56 PM, Paul Bolle wrote: On Wed, 2010-03-17 at 15:41 -0500, Anthony Liguori wrote: On 03/17/2010 03:15 PM, Blue Swirl wrote: This breaks build (gcc 4.3.2): CCusb-linux.o cc1: warnings being treated as errors /src/qemu/usb-linux.c: In function

Re: [Qemu-devel] [PATCH] [TRIVIAL] usb-linux: remove unreachable default in switch statement

2010-03-17 Thread Blue Swirl
On 3/17/10, Anthony Liguori anth...@codemonkey.ws wrote: On 03/17/2010 03:56 PM, Paul Bolle wrote: On Wed, 2010-03-17 at 15:41 -0500, Anthony Liguori wrote: On 03/17/2010 03:15 PM, Blue Swirl wrote: This breaks build (gcc 4.3.2): CCusb-linux.o cc1: warnings

Re: [Qemu-devel] [PATCH 5/6] error: Link qemu-img, qemu-nbd, qemu-io with qemu-error.o

2010-03-17 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: On 3/17/10, Markus Armbruster arm...@redhat.com wrote: The location tracking interface is used by code shared with qemi-img, qemu-nbd and qemu-io, so it needs to be available there. Commit 827b0813 provides it in a rather hamfisted way: it adds a

[Qemu-devel] patches

2010-03-17 Thread Edgar E. Iglesias
Hi, I usually mail out negative test reults but this time I've just pulled and merged to my 4 different CRIS, PPC and MicroBlaze trees from upstream and things Just Worked. Good work to everybody involved! Cheers, Edgar

[Qemu-devel] [PATCH 7/8] target-alpha: Use non-inverted arguments to gen_{f}cmov.

2010-03-17 Thread Richard Henderson
The inverted conditions as argument to the function looks wrong at a glance inside translate_one. Since we have an easy function to produce the inversion now, use it. Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/translate.c | 37 +++-- 1

[Qemu-devel] [PATCH 0/8] target-alpha improvements, v2

2010-03-17 Thread Richard Henderson
Changes from v1: * Use setcond and goto_tb. r~ Richard Henderson (8): target-alpha: Add flags markups to helpers.h. target-alpha: Implement cpys{,n,e} inline. target-alpha: Implement rs/rc properly. target-alpha: Implement cvtql inline. target-alpha: Implement cvtlq inline.

[Qemu-devel] [PATCH 1/8] target-alpha: Add flags markups to helpers.h.

2010-03-17 Thread Richard Henderson
Almost all alpha helpers are at least TCG_CALL_CONST and a fair few are also TCG_CALL_PURE. Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/helper.h | 184 1 files changed, 92 insertions(+), 92 deletions(-) diff --git

[Qemu-devel] [PATCH 5/8] target-alpha: Implement cvtlq inline.

2010-03-17 Thread Richard Henderson
It's a simple shift and mask sequence. Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/helper.h|1 - target-alpha/op_helper.c |7 --- target-alpha/translate.c | 21 - 3 files changed, 20 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCH 3/8] target-alpha: Implement rs/rc properly.

2010-03-17 Thread Richard Henderson
This is a per-cpu flag; there's no need for a spinlock of any kind. We were also failing to manipulate the flag with $31 as a target reg and failing to clear the flag on execution of a return-from-interrupt instruction. Signed-off-by: Richard Henderson r...@twiddle.net --- linux-user/main.c

[Qemu-devel] [PATCH 2/8] target-alpha: Implement cpys{, n, e} inline.

2010-03-17 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/helper.h|4 -- target-alpha/op_helper.c | 18 -- target-alpha/translate.c | 78 +++-- 3 files changed, 74 insertions(+), 26 deletions(-) diff --git

[Qemu-devel] [PATCH 4/8] target-alpha: Implement cvtql inline.

2010-03-17 Thread Richard Henderson
It's a simple mask and shift sequence. Also, fix a typo in the actual masks used. Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/helper.h|4 target-alpha/op_helper.c | 20 target-alpha/translate.c | 45

[Qemu-devel] [PATCH 8/8] target-alpha: Emit goto_tb opcodes.

2010-03-17 Thread Richard Henderson
Use an ExitStatus enumeration instead of magic numbers as the return value from translate_one. Emit goto_tb opcodes when ending a TB via a direct branch. Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/translate.c | 339 ++ 1 files

[Qemu-devel] [PATCH 6/8] target-alpha: Use setcond for int comparisons.

2010-03-17 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/translate.c | 43 ++- 1 files changed, 22 insertions(+), 21 deletions(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index c52cac3..3fa32b3 100644 ---

[Qemu-devel] virtio_blk_load() question

2010-03-17 Thread OHMURA Kei
Hi, I have a question regarding virtio_blk_load(). (qemu-kvm.git d1fa468c1cc03ea362d8fe3ed9269bab4d197510) VirtIOBlockReq structure is linked list of requests, but it doesn't seem to be properly linked in virtio_blk_load(). ... req-next = s-rq; s-rq = req-next; ... In this case, we're losing

[Qemu-devel] qemu-dm writing garbage into PCI BAR registers in HVM guest in XEN 3.3.1 on SLES11

2010-03-17 Thread Dan Gora
Hi All, I've found a problem in qemu-dm from xen 3.3.1_18546_12-3.1 from SLES11. I've posted this question to xen-devel as well, but I thought that I'd post it here since the problem appears to be in qemu-dm. I began investigating this problem when we found that if we pass two instances of our