Re: [Qemu-devel] Re: QEMU-KVM and video performance

2010-05-11 Thread Gerhard Wiesinger
On Mon, 10 May 2010, Avi Kivity wrote: On 05/09/2010 10:35 PM, Gerhard Wiesinger wrote: For 256 color more the first priority is to find out why direct mapping is not used. I'd suggest tracing the code that makes this decision (in hw/*vga.c) and seeing if it's right or not. I think this

Re: [Qemu-devel] [PATCH 2/2] acpi: remove static gpe and pci0_status variables

2010-05-11 Thread Isaku Yamahata
On Tue, May 11, 2010 at 11:48:24PM +0300, Blue Swirl wrote: > On 5/11/10, Isaku Yamahata wrote: > > Hi Blue. > > I send out very similar patches before and got acked-by from Gerd. > > But they haven't been merged yet. Please look at them. > > Instead of reinventing similar patches, those patche

[Qemu-devel] [PATCH][RESEND] vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc

2010-05-11 Thread TeLeMan
cirrus_post_load() will be executed twice when loading vm states and then the wrong physical memory will be registered. This issue may lead to crash qemu. Signed-off-by: TeLeMan --- hw/cirrus_vga.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirr

[Qemu-devel] [PATCH-V2 7/7] virtio-9p: Implemented security model for chown and chgrp.

2010-05-11 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |4 ++-- hw/virtio-9p-local.c | 18 ++ hw/virtio-9p.c | 15 --- 3 files changed, 28 insertions(+), 9 deletions(-) diff --git a/hw/file-op-9p.h b/hw/file-op-9p.h index 0a9c10a..b3a320c 100644

[Qemu-devel] [PATCH-V2 4/7] virtio-9p: Implement Security model for mknod related files

2010-05-11 Thread Venkateswararao Jujjuri (JV)
In the mapped security model all the special files are created as regular files on the fileserver and appropriate mode bits are added to the extended attributes. These extended attributes are used to present this file as special file to the client. Signed-off-by: Venkateswararao Jujjuri --- hw/f

[Qemu-devel] [PATCH-V2 3/7] virtio-9p: modify create/open2 and mkdir for new security model.

2010-05-11 Thread Venkateswararao Jujjuri (JV)
Add required infrastructure and modify create/open2 and mkdir per the new security model. Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h | 23 +- hw/virtio-9p-local.c | 115 -- hw/virtio-9p.c | 42 +--

[Qemu-devel] [PATCH-V2 6/7] virtio-9p: Implemented Security model for lstat and fstat

2010-05-11 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p-local.c | 67 +++--- 1 files changed, 63 insertions(+), 4 deletions(-) diff --git a/hw/virtio-9p-local.c b/hw/virtio-9p-local.c index 992ad09..2e24dbe 100644 --- a/hw/virtio-9p-local.c +++ b/hw/

[Qemu-devel] [PATCH-V2 5/7] virtio-9p: Implemented security model for symlink and link.

2010-05-11 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |4 +- hw/virtio-9p-local.c | 75 ++ hw/virtio-9p.c | 24 +++ 3 files changed, 76 insertions(+), 27 deletions(-) diff --git a/hw/file-op-9p.h b/hw/file-op-9p.

[Qemu-devel] [PATCH-V2 0/7] virtio-9p:Introducing security model for VirtFS

2010-05-11 Thread Venkateswararao Jujjuri (JV)
This patch series introduces the security model for VirtFS. Brief description of this patch series: It introduces two type of security models for VirtFS. They are: mapped and passthrough. The following is common to both security models. * Client's VFS determines/enforces the access control. L

[Qemu-devel] [PATCH-V2 1/7] virtio-9p: Introduces an option to specify the security model.

2010-05-11 Thread Venkateswararao Jujjuri (JV)
The new option is: -fsdev local,id=jvrao,path=/tmp/,security_model=[mapped|passthrough] -virtfs local,path=/tmp/,security_model=[mapped|passthrough],mnt_tag=v_tmp. In the case of mapped security model, files are created with QEMU user credentials and the client-user's credentials are saved in ext

[Qemu-devel] [PATCH-V2 2/7] virtio-9p: Rearrange fileop structures

2010-05-11 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p.c | 185 ++-- hw/virtio-9p.h | 92 2 files changed, 138 insertions(+), 139 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index 8ecd39c..fda3c4a

Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

2010-05-11 Thread chen huacai
On Wed, May 12, 2010 at 3:52 AM, Blue Swirl wrote: > On 5/11/10, chen huacai wrote: >> >>  +    s->pci = qemu_mallocz(sizeof(*s->pci)); >>  >>  +    assert(s->pci != NULL); >>  >>  +    bonito_state = s; >>  >>  + >>  >>  +    /* get the north bridge pci bus */ >>  >>  +    s->pci->bus = pci_regi

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] Support for booting from virtio disks

2010-05-11 Thread Kevin O'Connor
On Tue, May 11, 2010 at 03:47:40PM +0300, Gleb Natapov wrote: > On Tue, May 11, 2010 at 08:45:29AM -0400, Kevin O'Connor wrote: > > On Tue, May 11, 2010 at 10:04:25AM +0100, Stefan Hajnoczi wrote: > > > From what I can tell SeaBIOS is reading CMOS_BIOS_BOOTFLAG1 and > > > CMOS_BIOS_BOOTFLAG2 from n

[Qemu-devel] Re: Qemu-KVM Livate Migration 0.12.2 -> 0.12.3/4 broken?

2010-05-11 Thread Juan Quintela
Peter Lieven wrote: > Hi Qemu/KVM Devel Team, > > Live Migration from a 0.12.2 qemu-kvm to a 0.12.3 (and 0.12.4) > does not work: "load of migration failed" > > Is there any way to find out, why exactly it fails? I have > a lot of VMs running on 0.12.2 and would like to migrate > them to 0.12.4 >

[Qemu-devel] Re: [PATCH v2] pci: cleanly backout of pci_qdev_init()

2010-05-11 Thread Michael S. Tsirkin
On Tue, May 11, 2010 at 06:44:21AM -0400, Alex Williamson wrote: > If the init function of a device fails, as might happen with device > assignment, we never undo the work done by do_pci_register_device(). > This not only causes a bit of a memory leak, but also leaves a bogus > pointer in the bus d

Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-05-11 Thread Jamie Lokier
Anthony Liguori wrote: > QMP should insult users from underlying platform quirks. We should > translate errnos to appropriate QMP error types. Fair enough. What should it do when the platform returns an errno value that qemu doesn't know about, and wants to pass to the QMP caller? -- Jamie

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Paul Brook
> On 05/11/2010 10:53 AM, Paul Brook wrote: > >>> I disagree. We should not be removing or rejecting features just > >>> because they allow you to shoot yourself in the foot. We probably > >>> shouldn't be enabling them by default, but that's a whole different > >>> question. > >> > >> I disagre

Re: [Qemu-devel] [RFC] default mac address issue

2010-05-11 Thread Jamie Lokier
Anthony Liguori wrote: > Hi Bruce, > > On 05/10/2010 02:07 PM, Bruce Rogers wrote: > >I know this behavior has worked this way all along, but I wanted to bring > >up the following concern and float a few ideas about possible solutions. > >Please provide your perspective, opinion, etc. > > > >qem

Re: [Qemu-devel] qemu-kvm problem with DOS/4GW extender and EMM386.EXE

2010-05-11 Thread Andy Walls
On Wed, 2010-05-12 at 00:09 +0300, Mohammed Gamal wrote: > On Tue, May 11, 2010 at 11:56 PM, Andy Walls wrote: > > Running an MS-DOS 6.22 image with qemu-kvm on a RedHat Linux OS, I > > noticed the guest OS becomes hung and my dmesg gets spammed with > > > >set_cr0: #GP, set PG flag with a

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Paul Brook
> > Paul Brook wrote: > > > cache=none: > > > No host caching. Reads and writes both go directly to underlying > > > storage. > > > > > > Useful to avoid double-caching. > > > > > > cache=writethrough > > > > > > Reads are cached. Writes go directly to underlying storage. Useful > > > f

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Paul Brook
> Paul Brook wrote: > > cache=none: > > No host caching. Reads and writes both go directly to underlying > > storage. > > > > Useful to avoid double-caching. > > > > cache=writethrough > > > > Reads are cached. Writes go directly to underlying storage. Useful for > > broken guests that ar

Re: [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-11 Thread Jamie Lokier
Anthony Liguori wrote: > There's got to be a better place to fix this. Disable barriers in your > guests? If only it were that easy. OS installs are the thing that this feature would most help. They take ages, do a huge amount of writing with lots of seeking, and if the host fails you're going

Re: [Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation; fix ADDX carry generation.

2010-05-11 Thread Artyom Tarasenko
2010/5/11 Richard Henderson : > Use int32 types instead of target_ulong when computing ICC.  This > simplifies the generated code for 32-bit host and 64-bit guest. > Use the same simplified expressions for ICC as were already used > for XCC in carry flag generation. > > ADDX ICC carry generation wa

Re: [Qemu-devel] qemu-kvm problem with DOS/4GW extender and EMM386.EXE

2010-05-11 Thread Avi Kivity
On 05/11/2010 11:56 PM, Andy Walls wrote: Running an MS-DOS 6.22 image with qemu-kvm on a RedHat Linux OS, I noticed the guest OS becomes hung and my dmesg gets spammed with set_cr0: #GP, set PG flag with a clear PE flag That message appears to be the linux kernel's kvm emulator griping

Re: [Qemu-devel] qemu-kvm problem with DOS/4GW extender and EMM386.EXE

2010-05-11 Thread Mohammed Gamal
On Tue, May 11, 2010 at 11:56 PM, Andy Walls wrote: > Running an MS-DOS 6.22 image with qemu-kvm on a RedHat Linux OS, I > noticed the guest OS becomes hung and my dmesg gets spammed with > >        set_cr0: #GP, set PG flag with a clear PE flag > > That message appears to be the linux kernel's kv

[Qemu-devel] qemu-kvm problem with DOS/4GW extender and EMM386.EXE

2010-05-11 Thread Andy Walls
Running an MS-DOS 6.22 image with qemu-kvm on a RedHat Linux OS, I noticed the guest OS becomes hung and my dmesg gets spammed with set_cr0: #GP, set PG flag with a clear PE flag That message appears to be the linux kernel's kvm emulator griping about Paging Enable bit being enabled while

Re: [Qemu-devel] [PATCH 2/2] acpi: remove static gpe and pci0_status variables

2010-05-11 Thread Blue Swirl
On 5/11/10, Isaku Yamahata wrote: > Hi Blue. > I send out very similar patches before and got acked-by from Gerd. > But they haven't been merged yet. Please look at them. > Instead of reinventing similar patches, those patches should be merged. > If necessary, I'm willing to rebase them and re

[Qemu-devel] [PATCH 2/2] all vga: fail graicefully when vga ports are taken

2010-05-11 Thread Gerd Hoffmann
Try to pci hotplug a vga card, watch qemu die with hw_error(). This patch fixes it. Signed-off-by: Gerd Hoffmann --- hw/cirrus_vga.c |3 +++ hw/vga-pci.c|3 +++ hw/vmware_vga.c |3 +++ 3 files changed, 9 insertions(+), 0 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.

[Qemu-devel] [PATCH 1/2] ioport: add function to check whenever a port is assigned or not

2010-05-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ioport.c |5 + ioport.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/ioport.c b/ioport.c index 53dd87a..b718047 100644 --- a/ioport.c +++ b/ioport.c @@ -190,6 +190,11 @@ void isa_unassign_ioport(pio_addr_t start, int length)

[Qemu-devel] [PATCH] ahci: use interface type IF_SATA

2010-05-11 Thread Sebastian Herbszt
Use interface type IF_SATA instead of IF_SCSI. Signed-off-by: Sebastian Herbszt diff --git a/hw/ahci.c b/hw/ahci.c index 2763075..6f7b807 100644 --- a/hw/ahci.c +++ b/hw/ahci.c @@ -1160,7 +1160,7 @@ static AHCIState *ahci_new(void) s->timer = qemu_new_timer(vm_clock, ahci_timer_function,

[Qemu-devel] Re: [PATCH v2] QMP: Add "Downstream extension of QMP" to spec

2010-05-11 Thread Luiz Capitulino
On Mon, 10 May 2010 09:16:05 +0200 Markus Armbruster wrote: > Signed-off-by: Markus Armbruster Looks good to me. > --- > v2: Clarify use of __RFQDN (Thanks, Luiz!) > > QMP/qmp-spec.txt | 55 > ++ > 1 files changed, 55 insertions(+), 0 d

Re: [Qemu-devel] [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-11 Thread Michael S. Tsirkin
On Tue, May 11, 2010 at 10:27:22PM +0300, Avi Kivity wrote: > On 05/07/2010 06:23 AM, Rusty Russell wrote: >> On Thu, 6 May 2010 07:30:00 pm Avi Kivity wrote: >> >>> On 05/05/2010 11:58 PM, Michael S. Tsirkin wrote: >>> + /* We publish the last-seen used index at the end of the avai

[Qemu-devel] Re: [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-11 Thread Michael S. Tsirkin
On Tue, May 11, 2010 at 01:46:08PM -0500, Ryan Harper wrote: > * Michael S. Tsirkin [2010-05-05 16:37]: > > Generally, the Host end of the virtio ring doesn't need to see where > > Guest is up to in consuming the ring. However, to completely understand > > what's going on from the outside, this i

Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

2010-05-11 Thread Blue Swirl
On 5/11/10, chen huacai wrote: > >> +s->pci = qemu_mallocz(sizeof(*s->pci)); > >> +assert(s->pci != NULL); > >> +bonito_state = s; > >> + > >> +/* get the north bridge pci bus */ > >> +s->pci->bus = pci_register_bus(NULL, "pci", pci_bonito_set_irq, > >> +

Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg stub (tcg_out_reloc)

2010-05-11 Thread Alexander Graf
Am 11.05.2010 um 19:26 schrieb Richard Henderson : On 05/11/2010 09:47 AM, Stefan Weil wrote: Won't you get another warning about unreachable code because tcg_abort never returns? We don't enable that warning. What about condition compilation for tcg_out_reloc (don't compile it for hosts w

[Qemu-devel] Re: [PATCH 3/3] target-sparc: Inline some generation of carry for ADDX/SUBX.

2010-05-11 Thread Blue Swirl
On 5/11/10, Richard Henderson wrote: > Computing carry is trivial for some inputs. By avoiding an > external function call, we generate near-optimal code for > the common cases of add+addx (double-word arithmetic) and > cmp+addx (a setcc pattern). > > Signed-off-by: Richard Henderson > ---

Re: [Qemu-devel] [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-11 Thread Avi Kivity
On 05/07/2010 06:23 AM, Rusty Russell wrote: On Thu, 6 May 2010 07:30:00 pm Avi Kivity wrote: On 05/05/2010 11:58 PM, Michael S. Tsirkin wrote: + /* We publish the last-seen used index at the end of the available ring. +* It is at the end for backwards compatibility. */

[Qemu-devel] Re: [PATCH 2/3] target-sparc: Simplify ICC generation; fix ADDX carry generation.

2010-05-11 Thread Blue Swirl
On 5/11/10, Richard Henderson wrote: > Use int32 types instead of target_ulong when computing ICC. This > simplifies the generated code for 32-bit host and 64-bit guest. > Use the same simplified expressions for ICC as were already used > for XCC in carry flag generation. > > ADDX ICC carry g

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Avi Kivity
On 05/11/2010 06:40 PM, Anthony Liguori wrote: But if the goal is to make sure that fsync's don't result in data actually being on disk, there are many other ways to accomplish this. First, for the vast majority of users, this is already the case because ext3 defaults to disabling barriers.

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Avi Kivity
On 05/11/2010 11:36 AM, Kevin Wolf wrote: Am 10.05.2010 23:51, schrieb Alexander Graf: Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep everything in cache. So let's add a new parameter to -drive that allows us to set th

[Qemu-devel] Re: [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-11 Thread Ryan Harper
* Michael S. Tsirkin [2010-05-05 16:37]: > Generally, the Host end of the virtio ring doesn't need to see where > Guest is up to in consuming the ring. However, to completely understand > what's going on from the outside, this information must be exposed. > For example, host can reduce the number

[Qemu-devel] [PATCH v2] pci: cleanly backout of pci_qdev_init()

2010-05-11 Thread Alex Williamson
If the init function of a device fails, as might happen with device assignment, we never undo the work done by do_pci_register_device(). This not only causes a bit of a memory leak, but also leaves a bogus pointer in the bus devices array that can cause a segfault or garbage data from 'info pci'.

Re: [Qemu-devel] [PATCH] pci: cleanly backout of pci_qdev_init()

2010-05-11 Thread Alex Williamson
On Tue, 2010-05-11 at 21:17 +0300, Blue Swirl wrote: > On 5/10/10, Alex Williamson wrote: > > > > hw/pci.c | 17 - > > 1 files changed, 12 insertions(+), 5 deletions(-) > > > > diff --git a/hw/pci.c b/hw/pci.c > > index f167436..3d3560e 100644 > > --- a/hw/pci.c > > +++ b/

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Jamie Lokier
Paul Brook wrote: > cache=none: > No host caching. Reads and writes both go directly to underlying storage. > Useful to avoid double-caching. > > cache=writethrough > Reads are cached. Writes go directly to underlying storage. Useful for > broken guests that aren't aware of drive caches. T

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Anthony Liguori
On 05/11/2010 11:39 AM, Cam Macdonell wrote: Most of the people I hear from who are using my patch are using a peer model to share data between applications (simulations, JVMs, etc). But guest-to-host applications work as well of course. I think "transparent migration" can be achieved by making

Re: [Qemu-devel] [RFC][MIPS][PATCH 3/6] Initial support of VIA IDE controller used by fulong mini pc

2010-05-11 Thread Blue Swirl
On 5/11/10, Markus Armbruster wrote: > Blue Swirl writes: > > > On 5/9/10, chen huacai wrote: > >> This patch add initial support of VIA IDE controller used by fulong mini > pc > >> > >> Signed-off-by: Huacai Chen > >> - > [...] > > >> diff --git a/hw/ide/via.c b/hw/ide/via.c > >

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Jamie Lokier
Anthony Liguori wrote: > qemu-img create -f raw foo.img 10G > mkfs.ext3 foo.img > mount -oloop,rw,barrier=1 -t ext3 foo.img mnt > > Works perfectly fine. Hmm, interesting. Didn't know loop propagated barriers. So you're suggesting to use qemu with a loop device, and ext2 (bit faster than ext3)

Re: [Qemu-devel] [PATCH] pci: cleanly backout of pci_qdev_init()

2010-05-11 Thread Blue Swirl
On 5/10/10, Alex Williamson wrote: > If the init function of a device fails, as might happen with device > assignment, we never undo the work done by do_pci_register_device(). > This not only causes a bit of a memory leak, but also leaves a bogus > pointer in the bus devices array that can caus

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Avi Kivity
On 05/11/2010 08:05 PM, Anthony Liguori wrote: On 05/11/2010 11:39 AM, Cam Macdonell wrote: Most of the people I hear from who are using my patch are using a peer model to share data between applications (simulations, JVMs, etc). But guest-to-host applications work as well of course. I think "

Re: [Qemu-devel] forking i386 binaries on arm linux user mode

2010-05-11 Thread Richard Henderson
On 05/11/2010 10:08 AM, Damion Yates wrote: > Also is there some magic in gnemul-x86 beyond being a set of x86 libs? No. > Does it do any shortcutting to system calls in native rather than > sticking with the libs under emulation more? No. > Could you explain what you did? I've tried the follo

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Avi Kivity
On 05/11/2010 06:51 PM, Anthony Liguori wrote: On 05/11/2010 09:53 AM, Avi Kivity wrote: On 05/11/2010 05:17 PM, Cam Macdonell wrote: The master is the shared memory area. It's a completely separate entity that is represented by the backing file (or shared memory server handing out the fd

Re: [Qemu-devel] forking i386 binaries on arm linux user mode

2010-05-11 Thread Damion Yates
On Wed, 10 Feb 2010, Laurent Desnogues wrote: > On Wed, Feb 10, 2010 at 10:38 PM, Damion Yates > wrote: > > > I can now run loads of linux binaries on my armlinux system (a Nokia > > n900). I've tried tower toppler (http://toppler.sourceforge.net/) > > which uses SDL (via X11) and this was surpr

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Cam Macdonell
On Tue, May 11, 2010 at 11:05 AM, Anthony Liguori wrote: > On 05/11/2010 11:39 AM, Cam Macdonell wrote: >> >> Most of the people I hear from who are using my patch are using a peer >> model to share data between applications (simulations, JVMs, etc). >> But guest-to-host applications work as well

Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg stub (tcg_out_reloc)

2010-05-11 Thread Richard Henderson
On 05/11/2010 09:47 AM, Stefan Weil wrote: > Won't you get another warning about unreachable code > because tcg_abort never returns? We don't enable that warning. > What about condition compilation for tcg_out_reloc > (don't compile it for hosts which don't need it)? All hosts should need it. S

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Anthony Liguori
On 05/11/2010 11:32 AM, Jamie Lokier wrote: Anthony Liguori wrote: On 05/11/2010 08:12 AM, Paul Brook wrote: cache=always (or a more scary name like cache=lie to defend against idiots) Reads and writes are cached. Guest flushes are ignored. Useful for dumb guests in non-crit

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Anthony Liguori
On 05/11/2010 10:53 AM, Paul Brook wrote: I disagree. We should not be removing or rejecting features just because they allow you to shoot yourself in the foot. We probably shouldn't be enabling them by default, but that's a whole different question. I disagree and think the mentality

Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg stub (tcg_out_reloc)

2010-05-11 Thread Stefan Weil
Am 11.05.2010 18:23, schrieb Alexander Graf: On S390 we don't have a real TCG implementation but use a stub instead. This stub obviously doesn't call any of the TCG helper functions that are usually used by the other TCG targets. If such a helper function is static though, we end up getting a

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Cam Macdonell
On Tue, May 11, 2010 at 9:51 AM, Anthony Liguori wrote: > On 05/11/2010 09:53 AM, Avi Kivity wrote: >> >> On 05/11/2010 05:17 PM, Cam Macdonell wrote: >>> The master is the shared memory area.  It's a completely separate entity that is represented by the backing file (or shared memory se

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-11 Thread Alexander Graf
Jan Kiszka wrote: > Alexander Graf wrote: > >> Jan Kiszka wrote: >> >>> Move the buffer flush from mux_chr_read to mux_chr_can_read. While the >>> latter is called periodically, the former will only be invoked when new >>> characters arrive at the back-end. This caused problems to front-end

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Jamie Lokier
Anthony Liguori wrote: > On 05/11/2010 08:12 AM, Paul Brook wrote: > >>>cache=always (or a more scary name like cache=lie to defend against > >>>idiots) > >>> > >>>Reads and writes are cached. Guest flushes are ignored. Useful for > >>>dumb guests in non-critical environments. > >>>

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-11 Thread Jan Kiszka
Alexander Graf wrote: > Jan Kiszka wrote: >> Move the buffer flush from mux_chr_read to mux_chr_can_read. While the >> latter is called periodically, the former will only be invoked when new >> characters arrive at the back-end. This caused problems to front-end >> drivers whenever they were unable

[Qemu-devel] [PATCH] [S390] Remove warning in tcg stub (tcg_out_reloc)

2010-05-11 Thread Alexander Graf
On S390 we don't have a real TCG implementation but use a stub instead. This stub obviously doesn't call any of the TCG helper functions that are usually used by the other TCG targets. If such a helper function is static though, we end up getting a warning that turns into an error thanks to Werror

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-11 Thread Alexander Graf
Jan Kiszka wrote: > Move the buffer flush from mux_chr_read to mux_chr_can_read. While the > latter is called periodically, the former will only be invoked when new > characters arrive at the back-end. This caused problems to front-end > drivers whenever they were unable to read data immediately, e

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Paul Brook
> > I disagree. We should not be removing or rejecting features just because > > they allow you to shoot yourself in the foot. We probably shouldn't be > > enabling them by default, but that's a whole different question. > > I disagree and think the mentality severely hurts usability. QEMU's >

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Anthony Liguori
On 05/11/2010 09:53 AM, Avi Kivity wrote: On 05/11/2010 05:17 PM, Cam Macdonell wrote: The master is the shared memory area. It's a completely separate entity that is represented by the backing file (or shared memory server handing out the fd to mmap). It can exists independently of any gu

Re: [Qemu-devel] [RFC] default mac address issue

2010-05-11 Thread Bruce Rogers
>>> On 5/10/2010 at 01:33 PM, Anthony Liguori wrote: ... >> 1) have qemu print a warning to stdout/stderr that the default mac address > is being used and that it will interfere with other vms running the same way > on a common network segment >> > > This is definitely reasonable. I'll c

[Qemu-devel] [PPC] Can't boot iso images

2010-05-11 Thread Alexander Graf
Howdy, While trying to boot an openSUSE 11.1 iso I always get "/packages/elf-loader is missing". Apparently that bug was fixed in a more recent version of OpenBIOS. According to git log the version in pc-bios is r721. Could we please pull in a more recent version? Alex

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Anthony Liguori
On 05/11/2010 08:50 AM, Paul Brook wrote: In a development environment the rules can be a bit different. For example if you're testing an OS installer then you really don't want to be passing magic mount options. If the host machine dies then you don't care about the state of the guest because yo

[Qemu-devel] [PATCH] Fix leul_to_cpu on big endian hosts

2010-05-11 Thread Alexander Graf
Commit 213acd2e introduced leul_to_cpu with a special code path for big endian hosts. Unfortunately that code used preprocessor magic that didn't work. This patch replaces the explicit ##s by glue() which is proven to work reliably, enabling me to compile qemu on ppc again. Signed-off-by: Alexand

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Alexander Graf
Paul Brook wrote: >>> What about another cache=... value instead of adding more options? I'm >>> quite sure you'll only ever need this with writeback caching. So we >>> could have cache=none|writethrough|writeback|wb-noflush or something >>> like that. >>> > > I agree. > > >> The cache

[Qemu-devel] Re: [SeaBIOS] About cpu_set, CPU hotplug and related subjects

2010-05-11 Thread Carl-Daniel Hailfinger
On 28.04.2010 12:45, Gleb Natapov wrote: > On Wed, Apr 28, 2010 at 12:41:51PM +0200, Jes Sorensen wrote: > >> The CPU declarations are particularly tricky as they get pretty big and >> complex and need to live in the DSDT, whereas a lot of other things we >> can shift off to separate SSDT tables

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Avi Kivity
On 05/11/2010 05:17 PM, Cam Macdonell wrote: The master is the shared memory area. It's a completely separate entity that is represented by the backing file (or shared memory server handing out the fd to mmap). It can exists independently of any guest. I think the master/peer idea woul

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Cam Macdonell
On Tue, May 11, 2010 at 8:03 AM, Avi Kivity wrote: > On 05/11/2010 04:10 PM, Anthony Liguori wrote: >> >> On 05/11/2010 02:59 AM, Avi Kivity wrote: (Replying again to list) What data structure would you use?  For a lockless ring queue, you can only support a single produce

[Qemu-devel] [PATCH v2] sh: sm501: add 2D engine support

2010-05-11 Thread Shin-ichiro KAWASAKI
Hello Blue Swirl, and thank you for the review. Here's the patch modified according to your comments. abort() is used instead of assert(), and const modifier added for CPU*MemoryFunc. Best Regards, Shin-ichiro KAWASAKI ---

Re: [Qemu-devel] qemu-system-sh4 broken again.

2010-05-11 Thread Shin-ichiro KAWASAKI
Hello, Aurelian, Thank you for clarification. I've understood the situation. My comment is not the solution for Rob's problem. Best Regards, Shin-ichiro KAWASAKI (2010/05/11 0:48), Aurelien Jarno wrote: Shin-ichiro KAWASAKI a écrit : Hello, Rob, This mail might be too late, but I want to r

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Avi Kivity
On 05/11/2010 04:10 PM, Anthony Liguori wrote: On 05/11/2010 02:59 AM, Avi Kivity wrote: (Replying again to list) What data structure would you use? For a lockless ring queue, you can only support a single producer and consumer. To achieve bidirectional communication in virtio, we always us

Re: [Qemu-devel] KVM call agenda for May 11

2010-05-11 Thread Luiz Capitulino
On Tue, 11 May 2010 15:57:10 +0200 Jes Sorensen wrote: > On 05/11/10 15:53, Luiz Capitulino wrote: > > On Tue, 11 May 2010 15:50:32 +0200 > > Alexander Graf wrote: > > > >> Luiz Capitulino wrote: > >>> On Mon, 10 May 2010 08:02:50 -0700 > >>> Chris Wright wrote: > >>> > >>> > Please se

Re: [Qemu-devel] KVM call agenda for May 11

2010-05-11 Thread Jes Sorensen
On 05/11/10 15:53, Luiz Capitulino wrote: > On Tue, 11 May 2010 15:50:32 +0200 > Alexander Graf wrote: > >> Luiz Capitulino wrote: >>> On Mon, 10 May 2010 08:02:50 -0700 >>> Chris Wright wrote: >>> >>> Please send in any agenda items you are interested in covering. >>> >>> - Ex

Re: [Qemu-devel] KVM call agenda for May 11

2010-05-11 Thread Luiz Capitulino
On Tue, 11 May 2010 15:50:32 +0200 Alexander Graf wrote: > Luiz Capitulino wrote: > > On Mon, 10 May 2010 08:02:50 -0700 > > Chris Wright wrote: > > > > > >> Please send in any agenda items you are interested in covering. > >> > > > > - Exposing named errno in QMP errors > > > > - fl

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Paul Brook
> > In a development environment the rules can be a bit different. For > > example if you're testing an OS installer then you really don't want to > > be passing magic mount options. If the host machine dies then you don't > > care about the state of the guest because you're going to start from > >

Re: [Qemu-devel] KVM call agenda for May 11

2010-05-11 Thread Alexander Graf
Luiz Capitulino wrote: > On Mon, 10 May 2010 08:02:50 -0700 > Chris Wright wrote: > > >> Please send in any agenda items you are interested in covering. >> > > - Exposing named errno in QMP errors > - flush=on Alex

Re: [Qemu-devel] KVM call agenda for May 11

2010-05-11 Thread Luiz Capitulino
On Mon, 10 May 2010 08:02:50 -0700 Chris Wright wrote: > Please send in any agenda items you are interested in covering. - Exposing named errno in QMP errors (hope it's not too late)

[Qemu-devel] [PATCH] Fix regression for "-drive file="

2010-05-11 Thread Markus Armbruster
Empty file used to create an empty drive (no media). Since commit 9dfd7c7a, it's an error: "qemu: could not open disk image : No such file or directory". Older versions of libvirt can choke on this. Signed-off-by: Markus Armbruster --- If this goes in, I'll prepare a patch for stable as well.

[Qemu-devel] Re: KVM call agenda for May 11

2010-05-11 Thread Chris Wright
* Chris Wright (chr...@redhat.com) wrote: > Please send in any agenda items you are interested in covering. > > If we have a lack of agenda items I'll cancel the week's call. No agenda, so no call this week. thanks, -chris

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Anthony Liguori
On 05/11/2010 08:12 AM, Paul Brook wrote: cache=always (or a more scary name like cache=lie to defend against idiots) Reads and writes are cached. Guest flushes are ignored. Useful for dumb guests in non-critical environments. I really don't believe that we should support a cac

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Paul Brook
> > cache=always (or a more scary name like cache=lie to defend against > > idiots) > > > >Reads and writes are cached. Guest flushes are ignored. Useful for > >dumb guests in non-critical environments. > > I really don't believe that we should support a cache=lie. There are > many othe

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-11 Thread Anthony Liguori
On 05/11/2010 02:59 AM, Avi Kivity wrote: (Replying again to list) What data structure would you use? For a lockless ring queue, you can only support a single producer and consumer. To achieve bidirectional communication in virtio, we always use two queues. You don't have to use a lockles

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] Support for booting from virtio disks

2010-05-11 Thread Gleb Natapov
On Tue, May 11, 2010 at 08:45:29AM -0400, Kevin O'Connor wrote: > On Tue, May 11, 2010 at 10:04:25AM +0100, Stefan Hajnoczi wrote: > > From what I can tell SeaBIOS is reading CMOS_BIOS_BOOTFLAG1 and > > CMOS_BIOS_BOOTFLAG2 from non-volatile memory. The values index into > > bev[], which contains I

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] Support for booting from virtio disks

2010-05-11 Thread Kevin O'Connor
On Tue, May 11, 2010 at 10:04:25AM +0100, Stefan Hajnoczi wrote: > From what I can tell SeaBIOS is reading CMOS_BIOS_BOOTFLAG1 and > CMOS_BIOS_BOOTFLAG2 from non-volatile memory. The values index into > bev[], which contains IPL entries (the drives). > > Is the order of bev[] entries well-defined

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Anthony Liguori
On 05/11/2010 07:15 AM, Paul Brook wrote: What about another cache=... value instead of adding more options? I'm quite sure you'll only ever need this with writeback caching. So we could have cache=none|writethrough|writeback|wb-noflush or something like that. I think this table is misle

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-11 Thread Gleb Natapov
On Tue, May 11, 2010 at 10:04:25AM +0100, Stefan Hajnoczi wrote: > >From what I can tell SeaBIOS is reading CMOS_BIOS_BOOTFLAG1 and > CMOS_BIOS_BOOTFLAG2 from non-volatile memory. The values index into > bev[], which contains IPL entries (the drives). > > Is the order of bev[] entries well-define

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-11 Thread Gleb Natapov
On Tue, May 11, 2010 at 11:19:07AM +0300, Avi Kivity wrote: > On 05/10/2010 06:48 PM, Anthony Liguori wrote: > >On 05/10/2010 03:11 AM, Gleb Natapov wrote: > >>This patch adds native support for booting from virtio disks to Seabios. > >> > >>Signed-off-by: Gleb Natapov > > > >A related problem that

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-11 Thread Paul Brook
> > What about another cache=... value instead of adding more options? I'm > > quite sure you'll only ever need this with writeback caching. So we > > could have cache=none|writethrough|writeback|wb-noflush or something > > like that. I agree. > The cache option really isn't too useful. There's

[Qemu-devel] Re: [PATCH 1/2] Create shared-obj-y

2010-05-11 Thread Juan Quintela
Kevin Wolf wrote: > Am 11.05.2010 13:13, schrieb Juan Quintela: >> This variable contains the objects shared between tools and qemu binary. >> Add qemu-error.o only in one place, it "could" be built in two places >> depending of make ordering. >> >> Signed-off-by: Juan Quintela > >> --- a/Makefi

Re: [Qemu-devel] [PATCH 1/2] Create shared-obj-y

2010-05-11 Thread Markus Armbruster
Kevin Wolf writes: > Am 11.05.2010 13:13, schrieb Juan Quintela: >> This variable contains the objects shared between tools and qemu binary. >> Add qemu-error.o only in one place, it "could" be built in two places >> depending of make ordering. >> >> Signed-off-by: Juan Quintela > >> --- a/Make

[Qemu-devel] [PATCH v2] Fix -device help and documentation

2010-05-11 Thread Markus Armbruster
Commit 6616b2ad reverted commit 40ea285c. Looks like a mismerge to me. Signed-off-by: Markus Armbruster --- v2: rebased (v1 fell through the cracks apparently) qemu-options.hx | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/qemu-options.hx b/qemu-options.

Re: [Qemu-devel] [PATCH 1/2] Create shared-obj-y

2010-05-11 Thread Kevin Wolf
Am 11.05.2010 13:13, schrieb Juan Quintela: > This variable contains the objects shared between tools and qemu binary. > Add qemu-error.o only in one place, it "could" be built in two places > depending of make ordering. > > Signed-off-by: Juan Quintela > --- a/Makefile.objs > +++ b/Makefile.obj

Re: [Qemu-devel] [PATCH 1/2] Create shared-obj-y

2010-05-11 Thread Markus Armbruster
Juan Quintela writes: > This variable contains the objects shared between tools and qemu binary. > Add qemu-error.o only in one place, it "could" be built in two places > depending of make ordering. Yup, that's what I should've done when I added qemu-error.c.

Re: [Qemu-devel] [PATCH 2/2] acpi: remove static gpe and pci0_status variables

2010-05-11 Thread Isaku Yamahata
Hi Blue. I send out very similar patches before and got acked-by from Gerd. But they haven't been merged yet. Please look at them. Instead of reinventing similar patches, those patches should be merged. If necessary, I'm willing to rebase them and resend them. As for code iteself, the hotplug call

[Qemu-devel] [PATCH 2/2] state that fsdev depends on LINUX only once

2010-05-11 Thread Juan Quintela
Signed-off-by: Juan Quintela --- Makefile.objs |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 95d864b..f963c3f 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -35,8 +35,8 @@ net-nested-$(CONFIG_SLIRP) += slirp.o net-nested-$(C

  1   2   >