Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Paolo Bonzini
On 05/15/2011 05:40 PM, Alon Levy wrote: -ln -s $source_path/libcacard/Makefile libcacard/Makefile +ln -s -f $source_path/libcacard/Makefile libcacard/Makefile Use the symlink function rather than ln -s -f for portability to broken platforms, please. Note that this requires libtool

Re: [Qemu-devel] Why does -device qxl-vga not suppress default vga?

2011-05-16 Thread Gerd Hoffmann
On 05/13/11 16:18, Markus Armbruster wrote: VGA, cirrus-vga and vmware-svga do. Gerd, you added it (commit a19cbfb3), care to explain? Just forgot to add it to the list when merging. I'll go stuff a patch into the spice patch queue. Does -device VGA work these days btw? Last time I tries it

Re: [Qemu-devel] Why does -device qxl-vga not suppress default vga?

2011-05-16 Thread Jan Kiszka
On 2011-05-16 09:28, Gerd Hoffmann wrote: On 05/13/11 16:18, Markus Armbruster wrote: VGA, cirrus-vga and vmware-svga do. Gerd, you added it (commit a19cbfb3), care to explain? Just forgot to add it to the list when merging. I'll go stuff a patch into the spice patch queue. Does -device

Re: [Qemu-devel] [RFC] live snapshot, live merge, live block migration

2011-05-16 Thread Dor Laor
On 05/16/2011 12:38 AM, Jagane Sundar wrote: Hello Dor, One important advantage of live snapshot over live backup is support of multiple (consecutive) live snapshots while there can be only a single live backup at one time. This is why I tend to think that although live backup carry some

Re: [Qemu-devel] Should new USB devices such as usb-ccid support legacy -usbdevice?

2011-05-16 Thread Gerd Hoffmann
On 05/13/11 18:47, Anthony Liguori wrote: On 05/13/2011 11:36 AM, Markus Armbruster wrote: When Gerd qdevified USB, he kept legacy -usbdevice working (commit 0958b4cc...). What about new USB devices? Should they get a legacy syntax, too? Any reason to do that? We already have a number of

Re: [Qemu-devel] Why is qdev vga-isa no_user?

2011-05-16 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: On Fri, May 13, 2011 at 4:36 PM, Markus Armbruster arm...@redhat.com wrote: Blue, you did the conversion (commit 7435b791), care to explain? Because I/O ports of VGA are fixed, so there can be only zero (which is handled by -vga none) or one devices.

Re: [Qemu-devel] Why does -device qxl-vga not suppress default vga?

2011-05-16 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: On 05/13/11 16:18, Markus Armbruster wrote: VGA, cirrus-vga and vmware-svga do. Gerd, you added it (commit a19cbfb3), care to explain? Just forgot to add it to the list when merging. I'll go stuff a patch into the spice patch queue. Does -device

Re: [Qemu-devel] [PATCH v2] Add an isa device for SGA

2011-05-16 Thread Brad Hards
On Thu, 12 May 2011 10:55:13 pm Glauber Costa wrote: This patch adds a dummy legacy ISA device whose responsibility is to deploy sgabios, an option rom for a serial graphics adapter. The proposal is that this device is always-on when -nographics, but can otherwise be enable in any setup when

Re: [Qemu-devel] [RFC] live snapshot, live merge, live block migration

2011-05-16 Thread Jagane Sundar
Hello Dor, Let me see if I understand live snapshot correctly: If I want to configure a VM for daily backup, then I would do the following: - Create a snapshot s1. s0 is marked read-only. - Do a full backup of s0 on day 0. - On day 1, I would create a new snapshot s2, then copy over the

Re: [Qemu-devel] Should new USB devices such as usb-ccid support legacy -usbdevice?

2011-05-16 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 05/13/2011 11:36 AM, Markus Armbruster wrote: When Gerd qdevified USB, he kept legacy -usbdevice working (commit 0958b4cc...). What about new USB devices? Should they get a legacy syntax, too? The only existing new device is usb-ccid, and

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-05-16 Thread Peter Maydell
On 14 May 2011 22:32, Aurelien Jarno aurel...@aurel32.net wrote: On Fri, May 06, 2011 at 03:32:27PM +0100, Peter Maydell wrote: I just spoke with Paul on IRC about this. In summary:  * for a helper to cause an exception then it has (a) to make sure CPU state (pc, condflags) is sync'd before

[Qemu-devel] KVM call agenda for May 17th

2011-05-16 Thread Juan Quintela
Please send in any agenda items you are interested in covering. From two weeks ago, we have already: - import kvm headers into qemu, drop #ifdef maze (Jan) Thanks, Juan.

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Alon Levy
On Mon, May 16, 2011 at 09:00:10AM +0200, Paolo Bonzini wrote: On 05/15/2011 05:40 PM, Alon Levy wrote: -ln -s $source_path/libcacard/Makefile libcacard/Makefile +ln -s -f $source_path/libcacard/Makefile libcacard/Makefile Use the symlink function rather than ln -s -f for portability

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Paolo Bonzini
On 05/16/2011 12:25 PM, Alon Levy wrote: Note that this requires libtool at build time rather than only for maintainers. This is unlike all other software using it. However, I believe this is not too bad given that a special make invocation is required. I was under the impression this

Re: [Qemu-devel] Add option to disable Cocoa on Mac OS X

2011-05-16 Thread Ben Leslie
On Wed, May 11, 2011 at 23:54, Peter Maydell peter.mayd...@linaro.org wrote: On 7 May 2011 12:40, Alexander Graf ag...@suse.de wrote: So I suppose the only thing missing is a --disable-cocoa option, yup. I've just noticed that some of the code in block/raw-posix.c uses the CONFIG_COCOA

[Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Jonathan Nieder
Hi, Kevin Wolf wrote: This pulls the request completion for error cases from the caller to scsi_disk_emulate_command. This should not change semantics, but allows to reuse scsi_handle_write_error() for flushes in the next patch. Today I tried out qemu-system-arm for the first time. It's

[Qemu-devel] [PATCH] Abort on attempts to load out-of-range ROMs

2011-05-16 Thread Ben Leslie
Abort on attempts to load out-of-range ROMs Change ROM loading behaviour so that attempts to load ROMs that fall outside valid memory ranges causing an abort with a useful error message, rather than silently ignoring the problem. Signed-off-by: Ben Leslie be...@benno.id.au --- exec.c |2 +-

[Qemu-devel] [PATCH] piix_pci: fix piix3_set_irq_pic()

2011-05-16 Thread TeLeMan
If pic_irq is greater than 7, the irq level is always 0 on 32bits. Signed-off-by: TeLeMan gele...@gmail.com --- hw/piix_pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 7f1c4cc..85a320e 100644 --- a/hw/piix_pci.c +++

Re: [Qemu-devel] [Qemu-trivial] [PATCH] piix_pci: fix piix3_set_irq_pic()

2011-05-16 Thread Stefan Hajnoczi
On Mon, May 16, 2011 at 12:50 PM, TeLeMan gele...@gmail.com wrote: If pic_irq is greater than 7, the irq level is always 0 on 32bits. Signed-off-by: TeLeMan gele...@gmail.com ---  hw/piix_pci.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Gerd Hoffmann
Hi, Usually programs that are fully autoconf-iscated will ship a subset of libtool sources in the tarball, build a custom version at configure time, and invoke it from the Makefile via ./libtool. This has the advantage that only the maintainer needs to have libtool installed. OTOH we do not

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Paolo Bonzini
On 05/16/2011 02:06 PM, Gerd Hoffmann wrote: Usually programs that are fully autoconf-iscated will ship a subset of libtool sources in the tarball, build a custom version at configure time, and invoke it from the Makefile via ./libtool. This has the advantage that only the maintainer needs to

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Alon Levy
On Mon, May 16, 2011 at 02:07:55PM +0200, Paolo Bonzini wrote: On 05/16/2011 02:06 PM, Gerd Hoffmann wrote: Usually programs that are fully autoconf-iscated will ship a subset of libtool sources in the tarball, build a custom version at configure time, and invoke it from the Makefile via

[Qemu-devel] [PATCH v2 00/21] SCSI subsystem improvements

2011-05-16 Thread Paolo Bonzini
This series includes the following improvements to the SCSI subsystem: 1) introduction of SCSIBusOps that generalize the existing command_complete callback; 2) widespread use of the SCSIRequest abstraction, with simpler memory management (refcounting) and with various common idioms converted

[Qemu-devel] [PATCH v2 02/21] scsi-generic: Remove bogus double complete

2011-05-16 Thread Paolo Bonzini
scsi-generic scsi_read_complete() should not -both- call the client complete callback with SCSI_REASON_DATA -and- call scsi_command_complete(). The former will cause the client to queue a new read or write request, while the later will free the request data structure, thus causing the new read or

[Qemu-devel] [PATCH v2 03/21] scsi: introduce scsi_req_data

2011-05-16 Thread Paolo Bonzini
This abstracts calling the command_complete callback, reducing churn in the following patches. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c |6 ++ hw/scsi-disk.c|8 hw/scsi-generic.c |6 +++--- hw/scsi.h |1 + trace-events |

Re: [Qemu-devel] KVM call agenda for May 17th

2011-05-16 Thread Paolo Bonzini
On 05/16/2011 12:07 PM, Juan Quintela wrote: From two weeks ago, we have already: - import kvm headers into qemu, drop #ifdef maze (Jan) SCSI patches merge plan Paolo

[Qemu-devel] [PATCH v2 01/21] scsi: add tracing of scsi requests

2011-05-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c |6 ++ trace-events |6 ++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index ceeb4ec..0fd85fc 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@ -4,6 +4,7 @@

[Qemu-devel] [PATCH v2 11/21] scsi: use scsi_req_complete

2011-05-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-generic.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c index 5bfbb8a..e1f8a8a 100644 --- a/hw/scsi-generic.c +++ b/hw/scsi-generic.c @@ -288,7 +288,6 @@ static

[Qemu-devel] [PATCH v2 06/21] lsi: extract lsi_find_by_tag

2011-05-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/lsi53c895a.c | 63 +- 1 files changed, 38 insertions(+), 25 deletions(-) diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c index ccea6ad..3b67155 100644 --- a/hw/lsi53c895a.c +++

[Qemu-devel] [PATCH v2 14/21] scsi: introduce scsi_req_new

2011-05-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/esp.c |2 +- hw/lsi53c895a.c |3 +-- hw/scsi-bus.c|5 + hw/scsi.h|1 + hw/spapr_vscsi.c |2 +- hw/usb-msd.c |2 +- 6 files changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/esp.c

[Qemu-devel] [PATCH v2 04/21] scsi: introduce SCSIBusOps

2011-05-16 Thread Paolo Bonzini
There are more operations than a SCSI bus can handle, besides completing commands. One example, which this series will introduce, is cleaning up after a request is cancelled. More long term, a SCSI bus can represent the LUNs attached to a target; in this case, while all commands will ultimately

[Qemu-devel] [PATCH v2 12/21] scsi: Update sense code handling

2011-05-16 Thread Paolo Bonzini
From: Hannes Reinecke h...@suse.de The SCSI spec has a quite detailed list of sense codes available. It even mandates the use of specific ones for some failure cases. The current implementation just has one type of generic error which is actually a violation of the spec in certain cases. This

[Qemu-devel] [PATCH v2 21/21] scsi: split command_complete callback in two

2011-05-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/esp.c | 60 +--- hw/lsi53c895a.c | 48 +++--- hw/scsi-bus.c|4 +- hw/scsi.h|9 + hw/spapr_vscsi.c | 101

[Qemu-devel] [PATCH v2 07/21] scsi: Use 'SCSIRequest' directly

2011-05-16 Thread Paolo Bonzini
From: Hannes Reinecke h...@suse.de Currently the SCSIRequest structure is abstracted away and cannot accessed directly from the driver. This requires the handler to do a lookup on an abstract 'tag' which identifies the SCSIRequest structure. With this patch the SCSIRequest structure is exposed

[Qemu-devel] [PATCH v2 05/21] scsi: reference-count requests

2011-05-16 Thread Paolo Bonzini
With the next patch, a device may hold SCSIRequest for an indefinite time. Split a rather big patch, and protect against access errors, by reference counting them. There is some ugliness in scsi_send_command implementation due to the need to unref the request when it fails. This will go away

[Qemu-devel] [PATCH v2 16/21] scsi: introduce scsi_req_get_buf

2011-05-16 Thread Paolo Bonzini
... and remove some SCSIDevice variables or fields that now become unused. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/esp.c |2 +- hw/lsi53c895a.c |2 +- hw/scsi-bus.c|5 + hw/scsi.h|1 + hw/spapr_vscsi.c |8 ++-- hw/usb-msd.c |

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Paolo Bonzini
On 05/16/2011 02:14 PM, Alon Levy wrote: On Mon, May 16, 2011 at 02:07:55PM +0200, Paolo Bonzini wrote: On 05/16/2011 02:06 PM, Gerd Hoffmann wrote: Usually programs that are fully autoconf-iscated will ship a subset of libtool sources in the tarball, build a custom version at configure time,

[Qemu-devel] [PATCH v2 10/21] scsi: introduce scsi_req_cancel

2011-05-16 Thread Paolo Bonzini
This is for when the request must be dropped in the void, but still memory should be freed. To this end, the devices register a second callback in SCSIBusOps. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/esp.c | 16 ++-- hw/lsi53c895a.c | 30

[Qemu-devel] [PATCH v2 09/21] scsi: introduce scsi_req_abort

2011-05-16 Thread Paolo Bonzini
This covers the case of canceling a request's I/O and still completing it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c|9 + hw/scsi.h|1 + hw/spapr_vscsi.c |8 ++-- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH v2 19/21] scsi: make write_data return void

2011-05-16 Thread Paolo Bonzini
The return value is unused anyway. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-disk.c|6 ++ hw/scsi-generic.c |7 ++- hw/scsi.h |2 +- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index

[Qemu-devel] [PATCH v2 13/21] scsi: do not call send_command directly

2011-05-16 Thread Paolo Bonzini
Move the common part of scsi-disk.c and scsi-generic.c to the SCSI layer. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/esp.c |2 +- hw/lsi53c895a.c |2 +- hw/scsi-bus.c |3 ++- hw/scsi-disk.c|1 - hw/scsi-generic.c |1 - hw/scsi.h |2

[Qemu-devel] [PATCH v2 08/21] scsi: commonize purging requests

2011-05-16 Thread Paolo Bonzini
The code for canceling requests upon reset is already the same. Clean it up and move it to scsi-bus.c. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c | 12 hw/scsi-disk.c| 18 ++ hw/scsi-generic.c | 18 ++ hw/scsi.h

[Qemu-devel] [PATCH v2 20/21] scsi-generic: Handle queue full

2011-05-16 Thread Paolo Bonzini
The sg driver currently has a hardcoded limit of commands it can handle simultaneously. When this limit is reached the driver will return -EDOM. So we need to capture this to enable proper return values here. Signed-off-by: Hannes Reinecke h...@suse.de Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH v2 17/21] scsi: Implement 'get_sense' callback

2011-05-16 Thread Paolo Bonzini
From: Hannes Reinecke h...@suse.de The get_sense callback copies existing sense information into the provided buffer. This is required if sense information should be transferred together with the command response. Signed-off-by: Hannes Reinecke h...@suse.de Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH v2 15/21] scsi: introduce scsi_req_kick

2011-05-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/esp.c | 26 ++ hw/lsi53c895a.c | 22 -- hw/scsi-bus.c| 10 ++ hw/scsi.h|1 + hw/spapr_vscsi.c | 26 ++ hw/usb-msd.c | 15

[Qemu-devel] [PATCH v2 18/21] scsi-disk: add data direction checking

2011-05-16 Thread Paolo Bonzini
From: Hannes Reinecke h...@suse.de scsi_req_parse() already provides for a data direction setting, so we should be using it to check for correct direction. And we should return the sense code 'INVALID FIELD IN CDB' in these cases. Signed-off-by: Hannes Reinecke h...@suse.de Signed-off-by: Paolo

Re: [Qemu-devel] [RESEND][PATCH 3/9] microdrive: qdevify

2011-05-16 Thread andrzej zaborowski
On 16 May 2011 06:54, Dmitry Eremin-Solenikov dbarysh...@gmail.com wrote: Hello, On 5/16/11, andrzej zaborowski balr...@gmail.com wrote: On 25 April 2011 11:06, Dmitry Eremin-Solenikov dbarysh...@gmail.com wrote: Switch dscm1 microdrive driver to use qdev infrastructure. ---  

[Qemu-devel] [PATCH] qed: support for growing images

2011-05-16 Thread Stefan Hajnoczi
The .bdrv_truncate() operation resizes images and growing is easy to implement in QED. Simply check that the new size is valid and then update the image_size header field to reflect the new size. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block/qed.c | 22

[Qemu-devel] [PATCH][qemu-iotests] add qed support to 025 image resize test

2011-05-16 Thread Stefan Hajnoczi
QED now supports the truncate (aka resize) operation for growing images. Update test 025 so it runs for QED. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- 025 |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/025 b/025 index 691b6da..7062aa6 100755 ---

[Qemu-devel] [PATCH v4 6/6] block: Remove type hint, it's guest matter, doesn't belong here

2011-05-16 Thread Markus Armbruster
No users of bdrv_get_type_hint() left. bdrv_set_type_hint() can make the media removable by side effect. Make that explicit. Signed-off-by: Markus Armbruster arm...@redhat.com --- block.c | 12 block.h |5 - block_int.h |1 - blockdev.c |4 ++-- 4 files

[Qemu-devel] [PATCH v4 4/6] block QMP: Deprecate query-block's type, drop info block's type=

2011-05-16 Thread Markus Armbruster
query-block's specification documents response member type with values hd, cdrom, floppy, unknown. Its value is unreliable: a block device used as floppy has type floppy if created with if=floppy, but type hd if created with if=none. That's because with if=none, the type is at best a declaration

[Qemu-devel] [PATCH v4 5/6] blockdev: Store -drive option media in DriveInfo

2011-05-16 Thread Markus Armbruster
DriveInfo is closely tied to -drive, and like -drive, it mixes information about host and guest part of the block device. Unlike DriveInfo, BlockDriverState should be about the host part only. One of the remaining guest bits there is the type hint. -drive option media sets it, and qdevs

[Qemu-devel] [PATCH v4 2/6] scsi: Split qdev scsi-disk into scsi-hd and scsi-cd

2011-05-16 Thread Markus Armbruster
A scsi-disk is either a hard disk or a CD-ROM, depending on the associated BlockDriverState's type hint. Unclean; disk vs. CD belongs to the guest part, not the host part. Have separate qdevs scsi-hd and scsi-cd to model disk vs. CD in the guest part. Keep scsi-disk for backward compatibility.

[Qemu-devel] [PATCH v4 3/6] defaults: ide-cd and scsi-cd devices suppress default CD-ROM

2011-05-16 Thread Markus Armbruster
ide-hd does *not* suppress the default CD-ROM, unlike legacy ide-drive. scsi-cd *does* suppress it, unlike legacy scsi-disk. Signed-off-by: Markus Armbruster arm...@redhat.com --- vl.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index bffba69..e271c0b

[Qemu-devel] [PATCH v4 0/6] Split ide-drive and scsi-disk qdevs, and more

2011-05-16 Thread Markus Armbruster
This patch series is about purging the type hint from the block layer. My previous series cleaned up improper uses it. Remaining uses are info block and qdevs ide-drive, scsi-disk. ide-drive and scsi-disk can either act as disk or as CD drive. They use their drive's type hint to decide between

[Qemu-devel] [PATCH v4 1/6] ide: Split qdev ide-drive into ide-hd and ide-cd

2011-05-16 Thread Markus Armbruster
An ide-drive is either a hard disk or a CD-ROM, depending on the associated BlockDriverState's type hint. Unclean; disk vs. CD belongs to the guest part, not the host part. Have separate qdevs ide-hd and ide-cd to model disk vs. CD in the guest part. Keep ide-drive for backward compatibility.

Re: [Qemu-devel] [RESEND][PATCH 3/9] microdrive: qdevify

2011-05-16 Thread Dmitry Eremin-Solenikov
On 5/16/11, andrzej zaborowski balr...@gmail.com wrote: On 16 May 2011 06:54, Dmitry Eremin-Solenikov dbarysh...@gmail.com wrote: Hello, On 5/16/11, andrzej zaborowski balr...@gmail.com wrote: On 25 April 2011 11:06, Dmitry Eremin-Solenikov dbarysh...@gmail.com wrote: Switch dscm1

[Qemu-devel] [PATCH] libcacard: add libcacard.la target

2011-05-16 Thread Alon Levy
No flag to configure is required. Instead, added a libcacard.la target that is not built by default, only when requested explicitly via: mkdir build cd build ../configure make libcacard.la make install-libcacard Uses libtool to do actual linking of object files and shared library, and

Re: [Qemu-devel] [PATCH] libcacard: add libcacard.la target

2011-05-16 Thread Anthony Liguori
On 05/16/2011 08:25 AM, Alon Levy wrote: No flag to configure is required. Instead, added a libcacard.la target that is not built by default, only when requested explicitly via: mkdir build cd build ../configure make libcacard.la make install-libcacard Uses libtool to do actual linking of

Re: [Qemu-devel] [PATCH] libcacard: add libcacard.la target

2011-05-16 Thread Paolo Bonzini
On 05/16/2011 03:28 PM, Anthony Liguori wrote: *** Warning: Linking the shared library libcacard.la against the non-libtool *** objects ../trace-dtrace.o is not portable! I don't think slipping in libtool like this is such a good idea. I disagree but, the warning is indeed legitimate,

Re: [Qemu-devel] -net interface association behavior change in current -git.

2011-05-16 Thread Markus Armbruster
Rob Landley r...@landley.net writes: On 05/13/2011 07:19 AM, Markus Armbruster wrote: Rob Landley r...@landley.net writes: On 05/13/2011 01:54 AM, Markus Armbruster wrote: Rob Landley r...@landley.net writes: On 05/12/2011 09:10 AM, Markus Armbruster wrote: Rob Landley r...@landley.net

Re: [Qemu-devel] KVM Forum 2011: Call For Participation

2011-05-16 Thread Dor Laor
The abstract submission deadline was originally set for today. The forum committee agreed to extend the deadline period until next Sunday, May 22. The notification date remains the same (May 31). Thanks, your KVM Forum 2011 Program Committee On 04/21/2011 08:21 PM,

Re: [Qemu-devel] [PATCH] libcacard: add libcacard.la target

2011-05-16 Thread Alon Levy
On Mon, May 16, 2011 at 03:59:53PM +0200, Paolo Bonzini wrote: On 05/16/2011 03:28 PM, Anthony Liguori wrote: *** Warning: Linking the shared library libcacard.la against the non-libtool *** objects ../trace-dtrace.o is not portable! I don't think slipping in libtool like this is

Re: [Qemu-devel] [PATCH] libcacard: add libcacard.la target

2011-05-16 Thread Alon Levy
On Mon, May 16, 2011 at 08:28:49AM -0500, Anthony Liguori wrote: On 05/16/2011 08:25 AM, Alon Levy wrote: No flag to configure is required. Instead, added a libcacard.la target that is not built by default, only when requested explicitly via: mkdir build cd build ../configure make

Re: [Qemu-devel] [PATCH] libcacard: add libcacard.la target

2011-05-16 Thread Paolo Bonzini
On 05/16/2011 07:37 PM, Alon Levy wrote: I've settled on libtool as the linker solution since it seems to be the de facto standard, please correct me on this point if I'm wrong. We are not using autoconf, so I've called it directly in it's various modes, compile, link and install. I agree. I

Re: [Qemu-devel] [PATCH] libcacard: add libcacard.la target

2011-05-16 Thread Alon Levy
On Mon, May 16, 2011 at 04:44:03PM +0200, Paolo Bonzini wrote: On 05/16/2011 07:37 PM, Alon Levy wrote: I've settled on libtool as the linker solution since it seems to be the de facto standard, please correct me on this point if I'm wrong. We are not using autoconf, so I've called it

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Kevin Wolf
Hi Jonathan, Am 16.05.2011 13:23, schrieb Jonathan Nieder: Hi, Kevin Wolf wrote: This pulls the request completion for error cases from the caller to scsi_disk_emulate_command. This should not change semantics, but allows to reuse scsi_handle_write_error() for flushes in the next patch.

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Jonathan Nieder
Kevin Wolf wrote: I also reviewed the patch that you mentioned and I can't find anything suspicious there. I'm afraid you'll have to bite the bullet and run it with some debugging code yourself (if it's really related to that patch, you'll want to enable DPRINTF in hw/scsi-disk.c as a first

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Jonathan Nieder
Kevin Wolf wrote: Your instructions seemed clear enough, so I tried to reproduce your problem. Now I have an ARM VM with a Debian installation that works just fine and I have no idea what to use it for. ;-) So I was puzzled about this for a while, but then I had a flash of inspiration:

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Kevin Wolf
Am 16.05.2011 17:43, schrieb Jonathan Nieder: Kevin Wolf wrote: Your instructions seemed clear enough, so I tried to reproduce your problem. Now I have an ARM VM with a Debian installation that works just fine and I have no idea what to use it for. ;-) So I was puzzled about this for a

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-05-16 Thread Paul Brook
I just spoke with Paul on IRC about this. In summary: * for a helper to cause an exception then it has (a) to make sure CPU state (pc, condflags) is sync'd before the call to the helper and (b) the helper has to be in a file with access to global env, because it needs to call

Re: [Qemu-devel] TCG: AREG0 removal planning

2011-05-16 Thread Paul Brook
For changes to the TCG side we want to consider how we can provide useful aliasing information, rather than a naive replacement of TCG_AREG0 with a variable. What aliasing information? Aliasing of cpu state accesses between tcg_global_mem_new_* variables, qemu_ld/st ops, and helper

Re: [Qemu-devel] AHCI broken in current git, bisected.

2011-05-16 Thread Anthony Liguori
On 05/15/2011 03:03 PM, Michael S. Tsirkin wrote: On Sun, May 15, 2011 at 10:20:23PM +0300, Michael S. Tsirkin wrote: On Sun, May 15, 2011 at 07:14:42PM +0200, Jan Kiszka wrote: Pity I missed this the first time. Thanks! Ah, I see, I didn't miss it, just back from vacation and didn't get so

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Paolo Bonzini
On 05/16/2011 05:58 PM, Kevin Wolf wrote: Thanks. Still doesn't make much sense to me, the patch shouldn't change anything with respect to a malloc, but I can reproduce a segfault now. I think I'll have a closer look tomorrow. This fixes it on top of my SCSI refactoring series. Should I send

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-05-16 Thread Peter Maydell
On 16 May 2011 17:10, Paul Brook p...@codesourcery.com wrote: I just spoke with Paul on IRC about this. In summary:  * for a helper to cause an exception then it has (a) to make sure CPU state (pc, condflags) is sync'd before the call to the helper and (b) the helper has to be in a file

[Qemu-devel] segfault with VNC and --enable-debug

2011-05-16 Thread Anthony PERARD
Hi, I found a segfault when I use VNC with qemu compiled with --enable-debug. Without debug mode, that works fine. The segfault happen usualy when the debian (guest) is ready to be used, or a little bit after I'm logged in, in console mode. Here is few detail: HEAD 711c212 Merge remote-tracking

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-05-16 Thread Aurelien Jarno
On Mon, May 16, 2011 at 05:37:03PM +0100, Peter Maydell wrote: On 16 May 2011 17:10, Paul Brook p...@codesourcery.com wrote: I just spoke with Paul on IRC about this. In summary:  * for a helper to cause an exception then it has (a) to make sure CPU state (pc, condflags) is sync'd

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-05-16 Thread Aurelien Jarno
On Mon, May 16, 2011 at 10:59:47AM +0100, Peter Maydell wrote: On 14 May 2011 22:32, Aurelien Jarno aurel...@aurel32.net wrote: On Fri, May 06, 2011 at 03:32:27PM +0100, Peter Maydell wrote: I just spoke with Paul on IRC about this. In summary:  * for a helper to cause an exception then it

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-05-16 Thread Peter Maydell
On 16 May 2011 18:29, Aurelien Jarno aurel...@aurel32.net wrote: On Mon, May 16, 2011 at 05:37:03PM +0100, Peter Maydell wrote: You can do this by calling GETPC() from the top level helper function though, right? [OK, we'd need to move the definition out of dyngen-exec.h.] No we don't need to

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-05-16 Thread Peter Maydell
On 16 May 2011 18:29, Aurelien Jarno aurel...@aurel32.net wrote: That said given this patch is more or less an extension of an existing code, we may want to apply it anyway. That is the conclusion I'm hoping to persuade you to, yes :-) -- PMM

[Qemu-devel] Regression Warning: more nics requested than this machine supports

2011-05-16 Thread Markus Armbruster
Watch this: $ qemu-system-x86_64 -nodefaults -enable-kvm -m 384 -vnc :0 -S -netdev user,id=net0 -device e1000,netdev=net0 Warning: more nics requested than this machine supports; some have been ignored (qemu) info network Devices not on any VLAN: net0: net=10.0.2.0,

[Qemu-devel] [RFC Patch 0/3]Qemu: Enable dynamic cache change through qemu monitor

2011-05-16 Thread Supriya Kannery
 Currently cache setting of a block device cannot be changed without restarting a running VM. Following patchset is for enabling dynamic change of cache setting for block devices through qemu monitor. Code changes are based on patches from Christoph Hellwig and Prerna Saxena. Monitor

[Qemu-devel] [RFC Patch 1/3]Qemu: Enhance info block to display cache setting

2011-05-16 Thread Supriya Kannery
Enhance info block to display cache setting Example: (qemu) info block ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2 encrypted=0 Enhanced to include cache setting: (qemu) info block ide0-hd0: type=hd removable=0 cache=none file=../rhel6-32.qcow2 ro=0 drv=qcow2 encrypted=0

[Qemu-devel] [RFC Patch 2/3]Qemu: New error classes for file reopen and device insertion

2011-05-16 Thread Supriya Kannery
New errors defined for device insertion and file reopen Signed-off-by: Supriya Kannery supri...@in.ibm.com --- qerror.c |8 qerror.h |6 ++ 2 files changed, 14 insertions(+) Index: qemu/qerror.c === ---

[Qemu-devel] [RFC Patch 3/3]Qemu: Add command cache_set for dynamic cache change

2011-05-16 Thread Supriya Kannery
Add monitor command cache_set for dynamic cache change Signed-off-by: Christoph Hellwig h...@lst.de Signed-off-by: Supriya Kannery supri...@in.ibm.com --- block.c | 53 + block.h |2 ++ blockdev.c | 20

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-05-16 Thread Aurelien Jarno
On Mon, May 16, 2011 at 06:47:42PM +0100, Peter Maydell wrote: On 16 May 2011 18:29, Aurelien Jarno aurel...@aurel32.net wrote: On Mon, May 16, 2011 at 05:37:03PM +0100, Peter Maydell wrote: You can do this by calling GETPC() from the top level helper function though, right? [OK, we'd need

Re: [Qemu-devel] BUG: 0.14.0 -device usb-host supports only one device

2011-05-16 Thread Erik Rull
Gerd Hoffmann wrote: Hi, When enabling the -device usb-host option support for adding automatically USB devices from the host to the guest, only one device gets detected. Yes. -device usb-host creates a *single* virtual usb device instance. When a matching device on the host is found the

Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command

2011-05-16 Thread Jonathan Nieder
Paolo Bonzini wrote: This fixes it on top of my SCSI refactoring series. Thanks! Works here, too, for what it's worth. I squashed the following in when applying the scsi: introduce scsi_req_cancel patch, for easier reading and to get a little closer to warning-free compilation with gcc 4.6.

[Qemu-devel] [PATCH v3] Add an isa device for SGA

2011-05-16 Thread Glauber Costa
This patch adds a dummy legacy ISA device whose responsibility is to deploy sgabios, an option rom for a serial graphics adapter. The proposal is that this device is always-on when -nographics, but can otherwise be enable in any setup when -device sga is used. [v2: suggestions on qdev by Markus ]

Re: [Qemu-devel] KVM call agenda for May 17th

2011-05-16 Thread Anthony Liguori
On 05/16/2011 07:17 AM, Paolo Bonzini wrote: On 05/16/2011 12:07 PM, Juan Quintela wrote: From two weeks ago, we have already: - import kvm headers into qemu, drop #ifdef maze (Jan) SCSI patches merge plan - libtool usage Regards, Anthony Liguori Paolo

Re: [Qemu-devel] TCG: AREG0 removal planning

2011-05-16 Thread Blue Swirl
On Mon, May 16, 2011 at 7:16 PM, Paul Brook p...@codesourcery.com wrote: For changes to the TCG side we want to consider how we can provide useful aliasing information, rather than a naive replacement of TCG_AREG0 with a variable. What aliasing information? Aliasing of cpu state

[Qemu-devel] [PATCH 00/18] usb patch queue: add usb 2.0

2011-05-16 Thread Gerd Hoffmann
Hi, Here is the current usb patch queue. Patches 1-9 have been on the list already, the other ones are new. I plan to send a pull request for this stuff next week. The major new feature added is USB 2.0 support: A bunch of fixes and improvements for the usb passthrough code. The EHCI host

[Qemu-devel] [PATCH 06/18] usb: Pass the packet to the device's handle_control callback

2011-05-16 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com This allows using the generic usb_generic_handle_packet function from device code which does ASYNC control requests (such as the linux host pass through code). Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com

[Qemu-devel] [PATCH 01/18] usb: Add Interface Association Descriptor descriptor type

2011-05-16 Thread Gerd Hoffmann
From: Brad Hards br...@frogmouth.net Signed-off-by: Brad Hards br...@frogmouth.net Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/usb.h b/hw/usb.h index 7e46141..ca06bf8 100644 --- a/hw/usb.h +++ b/hw/usb.h

[Qemu-devel] [PATCH 11/18] usb-linux: walk async urb list in cancel

2011-05-16 Thread Gerd Hoffmann
Lookup async urbs which are to be canceled using the linked list instead of the direct opaque pointer. There are two reasons we are doing that: First, to avoid the opaque poiner to the callback, which is needed for upcoming cleanups. Second, because we might need multiple urbs per request for

[Qemu-devel] [PATCH 03/18] usb: remove fallback to bNumInterfaces if no .nif

2011-05-16 Thread Gerd Hoffmann
From: Brad Hards br...@frogmouth.net All callers have been updated. Signed-off-by: Brad Hards br...@frogmouth.net Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-desc.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/usb-desc.c b/hw/usb-desc.c index

[Qemu-devel] [PATCH 13/18] usb-linux: fix max_packet_size for highspeed.

2011-05-16 Thread Gerd Hoffmann
Calculate the max packet size correctly. Only bits 0..11 specify the size, bits 11+12 specify the number of (highspeed) microframes the endpoint wants to use. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- usb-linux.c | 19 +-- 1 files changed, 17 insertions(+), 2

[Qemu-devel] [PATCH 09/18] usb-linux: add hostport property

2011-05-16 Thread Gerd Hoffmann
This patch adds a hostport property which allows to specify the host usb devices to pass through by bus number and physical port. This means you can basically hand over one (or more) of the usb plugs on your host to the guest and whatever device is plugged in there will show up in the guest.

[Qemu-devel] [PATCH 05/18] Bug #757654: UHCI fails to signal stall response patch

2011-05-16 Thread Gerd Hoffmann
From: Jan Vesely jano.ves...@gmail.com UHCI host controller status register indicates error and an interrupt is triggered on BABBLE and STALL errors. Signed-off-by: Jan Vesely jano.ves...@gmail.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-uhci.c |4 1 files changed, 4

[Qemu-devel] [PATCH 10/18] usb-linux: track aurbs in list

2011-05-16 Thread Gerd Hoffmann
This patch adds code to track all async urbs in a linked list, so we can find them without having to pass around a opaque pointer to them. Prerequisite for the cleanups. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- usb-linux.c | 18 +++--- 1 files changed, 11 insertions(+),

  1   2   >