Re: [Qemu-devel] Is realview-pb-a8 fully supported ?

2011-10-12 Thread Francis Moreau
On Wed, Oct 12, 2011 at 10:46 PM, Peter Maydell wrote: > On 12 October 2011 20:39, Francis Moreau wrote: >> On Wed, Oct 12, 2011 at 11:23 AM, Peter Maydell >> wrote: >>> I think the mainline kernel sources should in theory work >>> (in particular if they work with 512MB then that's a good >>> si

Re: [Qemu-devel] balloon driver on winxp guest start failed

2011-10-12 Thread hkran
On 10/12/2011 07:09 PM, hkran wrote: Hi, I used balloon driver for windows virtio-win-0.1-15.iso (from http://alt.fedoraproject.org/pub/alt/virtio-win/latest/images/bin/) following the install guard , I installed the balloon driver like this: devcon.exe install d:\wxp\x86\balloon.inf "PCI\

Re: [Qemu-devel] [PATCH] qemu-char: Fix use of free() instead of g_free()

2011-10-12 Thread Dong Xu Wang
于 10/07/2011 01:38 PM, Stefan Weil 写道: > cppcheck reported these errors: > > qemu-char.c:1667: error: Mismatching allocation and deallocation: s > qemu-char.c:1668: error: Mismatching allocation and deallocation: chr > qemu-char.c:1769: error: Mismatching allocation and deallocation: s > qemu-char

Re: [Qemu-devel] [PATCH] usb-hid: activate usb tablet / mouse after migration.

2011-10-12 Thread TeLeMan
On Wed, Oct 12, 2011 at 19:30, Gerd Hoffmann wrote: > qemu uses the ps/2 mouse by default.  The usb tablet (or mouse) is > activated as soon as qemu sees some guest activity on the device, > i.e. polling for HID events.  That used to work fine for both fresh > boot and migration. It does not fix u

[Qemu-devel] [PATCH V4] Add AACI audio playback support to the ARM Versatile/PB platform

2011-10-12 Thread Mathieu Sonet
This driver emulates the ARM AACI interface (PL041) connected to a LM4549 codec. It enables audio playback for the Versatile/PB platform. Limitations: - Supports only a playback on one channel (Versatile/Vexpress) - Supports only one TX FIFO in compact-mode or non-compact mode. - Supports playbac

Re: [Qemu-devel] 2 MiB alignment in qemu_vmalloc()

2011-10-12 Thread Alexander Graf
On 12.10.2011, at 23:19, Stefan Weil wrote: > Am 12.10.2011 22:47, schrieb Alexander Graf: >> Well, yes, my point is that it's a bug in valgrind that should be fixed. I >> don't think we should special-case QEMU because of bugs in debugging >> software :) >> >> Alex > > Yes, the valgrind bug

Re: [Qemu-devel] 2 MiB alignment in qemu_vmalloc()

2011-10-12 Thread Stefan Weil
Am 12.10.2011 22:47, schrieb Alexander Graf: Well, yes, my point is that it's a bug in valgrind that should be fixed. I don't think we should special-case QEMU because of bugs in debugging software :) Alex Yes, the valgrind bug should be fixed. I don't know why it isn't, but that's not the p

[Qemu-devel] Buggy SDL Zoom

2011-10-12 Thread Stefan Weil
Hi, the SDL zoom feature which is implemented in sdl_zoom_template.h (and the SDL_rotozoom version which it is based on) accesses memory beyond the allocated limits. This can be easily reproduced using Valgrind and some Linux desktop which resizes QEMU's window to fill the whole screen (I did ru

Re: [Qemu-devel] [PATCH 3/6] trace: Add trace events group implementation in the backend "simple"

2011-10-12 Thread Ryan Harper
* Mark Wu [2011-10-12 12:26]: > > Signed-off-by: Mark Wu > --- > trace/simple.c | 30 ++ > trace/simple.h |7 +++ > 2 files changed, 37 insertions(+), 0 deletions(-) > > diff --git a/trace/simple.c b/trace/simple.c > index b639dda..7aa4c0b 100644 > --- a/t

Re: [Qemu-devel] 2 MiB alignment in qemu_vmalloc()

2011-10-12 Thread Alexander Graf
On 12.10.2011, at 22:41, Stefan Weil wrote: > Am 12.10.2011 22:02, schrieb Alexander Graf: >> Actually, I'd much rather prefer to keep the differences between KVM and >> non-KVM low here. THP can potentially also work on TCG, so the alignment >> isn't completely moot here. Though it's certainly

Re: [Qemu-devel] Is realview-pb-a8 fully supported ?

2011-10-12 Thread Peter Maydell
On 12 October 2011 20:39, Francis Moreau wrote: > On Wed, Oct 12, 2011 at 11:23 AM, Peter Maydell > wrote: >> I think the mainline kernel sources should in theory work >> (in particular if they work with 512MB then that's a good >> sign...) but I'm not a kernel expert; mostly I use other peoples'

Re: [Qemu-devel] 2 MiB alignment in qemu_vmalloc()

2011-10-12 Thread Stefan Weil
Am 12.10.2011 22:02, schrieb Alexander Graf: Actually, I'd much rather prefer to keep the differences between KVM and non-KVM low here. THP can potentially also work on TCG, so the alignment isn't completely moot here. Though it's certainly a lot less useful, as code isn't directly executed fro

Re: [Qemu-devel] 2 MiB alignment in qemu_vmalloc()

2011-10-12 Thread Alexander Graf
On 12.10.2011, at 20:05, Stefan Weil wrote: > Hello Avi, > > commit 36b58628 increased the alignment for some large memory > blocks (typically the system RAM) to 2 MiB (QEMU_VMALLOC_ALIGN) > on x86_64 Linux hosts. > > As far as I know, this was only required for KVM. > > There is a bad side ef

Re: [Qemu-devel] Is realview-pb-a8 fully supported ?

2011-10-12 Thread Francis Moreau
On Wed, Oct 12, 2011 at 11:23 AM, Peter Maydell wrote: > On 10 October 2011 14:48, Francis Moreau wrote: >> On Mon, Oct 10, 2011 at 10:42 AM, Peter Maydell >> wrote: >>> On 10 October 2011 08:35, Francis Moreau wrote: I noticed another point for the realview platofrm: if I boot with "-M >>

[Qemu-devel] 2 MiB alignment in qemu_vmalloc()

2011-10-12 Thread Stefan Weil
Hello Avi, commit 36b58628 increased the alignment for some large memory blocks (typically the system RAM) to 2 MiB (QEMU_VMALLOC_ALIGN) on x86_64 Linux hosts. As far as I know, this was only required for KVM. There is a bad side effect of this increase: the Valgrind tool only supports an align

[Qemu-devel] [PATCH 4/6] trace: Add trace events group implementation in the backend "stderr"

2011-10-12 Thread Mark Wu
Signed-off-by: Mark Wu --- trace/stderr.c | 32 trace/stderr.h |7 +++ 2 files changed, 39 insertions(+), 0 deletions(-) diff --git a/trace/stderr.c b/trace/stderr.c index 7107c4a..c409840 100644 --- a/trace/stderr.c +++ b/trace/stderr.c @@ -12,6 +12,1

[Qemu-devel] [PATCHv2] ps2: migrate ledstate

2011-10-12 Thread Christophe Fergeau
Make the ps2 device track its ledstate so that we can migrate it. Otherwise it gets lost across migration, and spice-server gets confused about the actual keyboard state and sends bogus caps/scroll/num key events. This fixes RH bug #729294 Signed-off-by: Christophe Fergeau --- hw/ps2.c | 15 ++

[Qemu-devel] [PATCH 6/6] trace: Update doc for trace events group

2011-10-12 Thread Mark Wu
Signed-off-by: Mark Wu --- docs/tracing.txt | 29 ++--- 1 files changed, 26 insertions(+), 3 deletions(-) diff --git a/docs/tracing.txt b/docs/tracing.txt index 95ca16c..2bd4824 100644 --- a/docs/tracing.txt +++ b/docs/tracing.txt @@ -16,6 +16,7 @@ for debugging, profi

[Qemu-devel] [PATCH 5/6] trace: Enable "-trace events" argument to control initial state of groups

2011-10-12 Thread Mark Wu
A group of trace events can be enabled in early running stage through adding its group name prefixed with "group:" to trace events list file which is passed to "-trace events". Signed-off-by: Mark Wu --- trace/control.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 3/6] trace: Add trace events group implementation in the backend "simple"

2011-10-12 Thread Mark Wu
Signed-off-by: Mark Wu --- trace/simple.c | 30 ++ trace/simple.h |7 +++ 2 files changed, 37 insertions(+), 0 deletions(-) diff --git a/trace/simple.c b/trace/simple.c index b639dda..7aa4c0b 100644 --- a/trace/simple.c +++ b/trace/simple.c @@ -321,6 +321,1

[Qemu-devel] [PATCH 1/6] trace: Make "tracetool" generate a group list

2011-10-12 Thread Mark Wu
Each trace events group starts with a line containing "group_start: GroupName" and end with a line containing "group_end". The range of a trace events group is determined by the "tracetool" script when it processes the "trace-events" file. Signed-off-by: Mark Wu --- scripts/tracetool | 94

[Qemu-devel] [PATCH 2/6] trace: Add HMP monitor commands for trace events group

2011-10-12 Thread Mark Wu
Add monitor commands 'trace-group NAME on|off' and 'info trace-groups' to set and query the state of a given group of trace events. Signed-off-by: Mark Wu --- hmp-commands.hx | 14 ++ monitor.c | 22 ++ trace/control.h |9 + trace/default.c |

[Qemu-devel] [PATCH 0/6] trace: Add support for trace events grouping

2011-10-12 Thread Mark Wu
This series add support for trace events grouping. The state of a given group of trace events can be queried or changed in bulk by the following monitor commands: * info trace-groups View available trace event groups and their state. State 1 means enabled, state 0 means disabled. * trace-gro

Re: [Qemu-devel] [PATCH RFC V1 01/11] Introduce HostPCIDevice to access a pci device on the host.

2011-10-12 Thread Anthony PERARD
On Tue, Oct 4, 2011 at 19:21, Jan Kiszka wrote: > This wasn't run through checkpatch.pl, I bet. > > On 2011-10-04 16:51, Anthony PERARD wrote: >> Signed-off-by: Anthony PERARD >> --- >>  hw/host-pci-device.c |  192 >> ++ >>  hw/host-pci-device.h |

[Qemu-devel] [ANNOUNCE] QEMU 0.15.1.tar.gz is available

2011-10-12 Thread Justin M. Forbes
The QEMU team is pleased to announce the availability of the 0.15.1 stable release. Download instructions are available at http://wiki.qemu.org/Download A detailed change log is available at http://wiki.qemu.org/Changelog/0.15 On behalf of the QEMU team, I'd like to thank everyone who contribute

Re: [Qemu-devel] [PATCH] hw/9pfs: Handle Security model parsing

2011-10-12 Thread Aneesh Kumar K.V
On Wed, 12 Oct 2011 09:28:00 +0100, "Daniel P. Berrange" wrote: > On Wed, Oct 12, 2011 at 01:24:16PM +0530, M. Mohan Kumar wrote: > > Security model is needed only for 'local' fs driver. > > > > Signed-off-by: M. Mohan Kumar > > --- > > fsdev/qemu-fsdev.c |6 + > > fsdev/qemu-f

Re: [Qemu-devel] [PATCH] ps2: migrate ledstate

2011-10-12 Thread Christophe Fergeau
Hey, On Wed, Oct 12, 2011 at 06:35:28PM +0200, Christophe Fergeau wrote: > Make the ps2 device track its ledstate so that we can migrate it. > Otherwise it gets lost across migration, and spice-server gets > confused about the actual keyboard state and sends bogus > caps/scroll/num key events. Th

Re: [Qemu-devel] [PATCH] ps2: migrate ledstate

2011-10-12 Thread Anthony Liguori
On 10/12/2011 11:35 AM, Christophe Fergeau wrote: Make the ps2 device track its ledstate so that we can migrate it. Otherwise it gets lost across migration, and spice-server gets confused about the actual keyboard state and sends bogus caps/scroll/num key events. Signed-off-by: Christophe Fergea

[Qemu-devel] [PATCH] ps2: migrate ledstate

2011-10-12 Thread Christophe Fergeau
Make the ps2 device track its ledstate so that we can migrate it. Otherwise it gets lost across migration, and spice-server gets confused about the actual keyboard state and sends bogus caps/scroll/num key events. Signed-off-by: Christophe Fergeau --- hw/ps2.c | 13 +++-- 1 files chang

Re: [Qemu-devel] qemu-0.15.1 stable call for patches

2011-10-12 Thread Justin M. Forbes
On Wed, 2011-10-12 at 05:41 -0400, Brad wrote: > On 26/09/11 9:16 AM, Justin M. Forbes wrote: > > With the current patch queue I would like to start getting qemu-0.15.1 > > stable into shape. With this in mind, the plan is to tag the release on > > Monday Oct 3rd. If you have patches pending for

[Qemu-devel] [PATCH v3] add add-cow file format

2011-10-12 Thread Dong Xu Wang
Add add-cow file format Signed-off-by: Dong Xu Wang --- Makefile.objs |1 + block.c|2 +- block.h|1 + block/add-cow.c| 412 block_int.h|1 + docs/specs/add-cow.txt |

[Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail

2011-10-12 Thread Peter Maydell
Improve the configure test for presence of ucontext functions by making linker warnings fatal; this allows us to detect when we are linked with a glibc which implements makecontext() to always return ENOSYS. Signed-off-by: Peter Maydell --- Compiling on an Ubuntu Natty ARM host will hit this. (An

Re: [Qemu-devel] [PATCH 1/2] Add opt_set_bool function

2011-10-12 Thread Andreas Färber
Am 12.10.2011 09:53, schrieb M. Mohan Kumar: In addition to qemu_opt_set function, we need a function to set bool value also. Signed-off-by: M. Mohan Kumar --- qemu-option.c | 35 +++ qemu-option.h |1 + 2 files changed, 36 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH v2 16/23] i8259: PREP: Replace pic_intack_read with pic_read_irq

2011-10-12 Thread Jan Kiszka
On 2011-10-12 18:02, Andreas Färber wrote: > Hello Jan, > > Since the last round of pulls, PReP magically boots again. :) > > Am 07.10.2011 09:19, schrieb Jan Kiszka: >> There is nothing in the i8259 spec that justifies the special >> pic_intack_read. At least the Linux PREP kernels configure the

Re: [Qemu-devel] [PATCH] hw/9pfs: Handle Security model parsing

2011-10-12 Thread Daniel P. Berrange
On Wed, Oct 12, 2011 at 09:05:50PM +0530, M. Mohan Kumar wrote: > -- > Regards, > M. Mohan Kumar > On Wednesday, October 12, 2011 01:58:00 PM Daniel P. Berrange wrote: > > On Wed, Oct 12, 2011 at 01:24:16PM +0530, M. Mohan Kumar wrote: > > > Security model is needed only for 'local' fs driver. > >

Re: [Qemu-devel] [PATCH v2 16/23] i8259: PREP: Replace pic_intack_read with pic_read_irq

2011-10-12 Thread Andreas Färber
Hello Jan, Since the last round of pulls, PReP magically boots again. :) Am 07.10.2011 09:19, schrieb Jan Kiszka: > There is nothing in the i8259 spec that justifies the special > pic_intack_read. At least the Linux PREP kernels configure the PICs > properly so that pic_read_irq returns identical

Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA

2011-10-12 Thread David Gibson
On Thu, Oct 13, 2011 at 02:43:06AM +1100, David Gibson wrote: > On Wed, Oct 12, 2011 at 09:22:01AM +0200, Michael S. Tsirkin wrote: > > On Wed, Oct 12, 2011 at 02:07:46PM +1100, David Gibson wrote: > > > Um.. why? PCI is defined by the spec to be LE, so I don't see that we > > > need explicit endi

Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA

2011-10-12 Thread David Gibson
On Wed, Oct 12, 2011 at 09:22:01AM +0200, Michael S. Tsirkin wrote: > On Wed, Oct 12, 2011 at 02:07:46PM +1100, David Gibson wrote: > > Um.. why? PCI is defined by the spec to be LE, so I don't see that we > > need explicit endianness versions for PCI helpers. > > LE in the spec only applies to s

Re: [Qemu-devel] [PATCH] hw/9pfs: Handle Security model parsing

2011-10-12 Thread M. Mohan Kumar
-- Regards, M. Mohan Kumar On Wednesday, October 12, 2011 01:58:00 PM Daniel P. Berrange wrote: > On Wed, Oct 12, 2011 at 01:24:16PM +0530, M. Mohan Kumar wrote: > > Security model is needed only for 'local' fs driver. > > > > Signed-off-by: M. Mohan Kumar > > --- > > > > fsdev/qemu-fsdev.c

[Qemu-devel] [PATCH 02/10] scsi-generic: remove scsi_req_fixup

2011-10-12 Thread Paolo Bonzini
This is not needed anymore, since asynchronous ioctls were introduced by commit 221f715 (new scsi-generic abstraction, use SG_IO, 2009-03-28). Signed-off-by: Paolo Bonzini --- hw/scsi-generic.c | 15 --- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/hw/scsi-generi

[Qemu-devel] [PATCH 04/10] scsi-generic: look at host status

2011-10-12 Thread Paolo Bonzini
Pass down the host status so that failing transport can be detected by the guest. Similar treatment of host status could be done in virtio-blk, too. Signed-off-by: Paolo Bonzini --- hw/scsi-generic.c | 20 1 files changed, 16 insertions(+), 4 deletions(-) diff --git a/hw

Re: [Qemu-devel] [PATCH 1/2] hw/9pfs: Add new virtfs option cache=writethrough to skip host page cache

2011-10-12 Thread Aneesh Kumar K.V
On Wed, 12 Oct 2011 15:32:36 +0100, Stefan Hajnoczi wrote: > On Wed, Oct 12, 2011 at 2:19 PM, Aneesh Kumar K.V > wrote: > > On Wed, 12 Oct 2011 10:55:21 +0100, Stefan Hajnoczi > > wrote: > >> On Mon, Oct 10, 2011 at 10:06 AM, Aneesh Kumar K.V > >> wrote: > >> > diff --git a/hw/9pfs/virtio-9p-h

Re: [Qemu-devel] [PATCH V4 2/2] hw/9pfs: Add readonly support for 9p export

2011-10-12 Thread M. Mohan Kumar
On Wednesday, October 12, 2011 07:38:25 PM Aneesh Kumar K.V wrote: > On Wed, 12 Oct 2011 13:23:34 +0530, "M. Mohan Kumar" wrote: > > A new fsdev parameter "readonly" is introduced to control accessing 9p > > export. readonly=on|off can be used to specify the access type. By > > default rw access

[Qemu-devel] [PATCH 09/10] scsi: pass cdb to alloc_req

2011-10-12 Thread Paolo Bonzini
This will let scsi-block choose between passthrough and emulation. Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c |2 +- hw/scsi-disk.c|4 ++-- hw/scsi-generic.c |2 +- hw/scsi.h |2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/scsi-bus.c b

[Qemu-devel] [PATCH 01/10] scsi-generic: drop SCSIGenericState

2011-10-12 Thread Paolo Bonzini
It is not needed, because s->bs is already stored in SCSIDevice, and can be reached from the conf.bs member. Signed-off-by: Paolo Bonzini --- hw/scsi-generic.c | 85 +++-- 1 files changed, 37 insertions(+), 48 deletions(-) diff --git a/hw/scsi-g

[Qemu-devel] [PATCH 10/10] scsi-disk: add scsi-block for device passthrough

2011-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 116 1 files changed, 116 insertions(+), 0 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 835cc7f..c97ef52 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -39,6 +39,10

[Qemu-devel] [PATCH 08/10] scsi: export scsi_generic_reqops

2011-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi-generic.c |2 +- hw/scsi.h |3 +++ 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c index 9c9f64a..eb066ba 100644 --- a/hw/scsi-generic.c +++ b/hw/scsi-generic.c @@ -432,7 +432,7 @@ static

[Qemu-devel] [PATCH 05/10] scsi-disk: do not duplicate BlockDriverState member

2011-10-12 Thread Paolo Bonzini
Same as for scsi-generic, avoid duplication even if it causes longer lines. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 94 +++ 1 files changed, 46 insertions(+), 48 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 860a3

[Qemu-devel] [PATCH 07/10] scsi: make reqops const

2011-10-12 Thread Paolo Bonzini
Also delete a stale occurrence of SCSIReqOps inside SCSIDeviceInfo. Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c | 10 +- hw/scsi-disk.c|2 +- hw/scsi-generic.c |2 +- hw/scsi.h |7 +++ 4 files changed, 10 insertions(+), 11 deletions(-) diff --git a/h

Re: [Qemu-devel] [RFC PATCH v2] Specification for qcow2 version 3

2011-10-12 Thread Kevin Wolf
Am 12.10.2011 16:37, schrieb Stefan Hajnoczi: > On Wed, Oct 12, 2011 at 2:31 PM, Kevin Wolf wrote: >> Am 12.10.2011 14:51, schrieb Stefan Hajnoczi: Also a bit in l2 offset to say "there is no l2 table" cause all clusters in l2 are contiguous so we avoid entirely l2. Obviously this r

Re: [Qemu-devel] [v7 Patch 5/5]Qemu: New struct 'BDRVReopenState' for image files reopen

2011-10-12 Thread Kevin Wolf
Am 11.10.2011 05:11, schrieb Supriya Kannery: > Struct BDRVReopenState introduced for handling reopen state of images. > This can be extended by each of the block drivers to reopen respective > image files. Implementation for raw-posix is done here. > > Signed-off-by: Supriya Kannery Maybe it

Re: [Qemu-devel] [PATCH V5] Add stdio char device on windows

2011-10-12 Thread Fabien Chouteau
On 06/10/2011 16:37, Fabien Chouteau wrote: > Simple implementation of an stdio char device on Windows. > Any comments? -- Fabien Chouteau

Re: [Qemu-devel] [RFC PATCH v2] Specification for qcow2 version 3

2011-10-12 Thread Stefan Hajnoczi
On Wed, Oct 12, 2011 at 2:31 PM, Kevin Wolf wrote: > Am 12.10.2011 14:51, schrieb Stefan Hajnoczi: >>> Also a bit in l2 offset to say "there is no l2 table" cause all >>> clusters in l2 are contiguous so we avoid entirely l2. Obviously this >>> require an optimization step to detect or create such

Re: [Qemu-devel] [PATCH 1/2] hw/9pfs: Add new virtfs option cache=writethrough to skip host page cache

2011-10-12 Thread Stefan Hajnoczi
On Wed, Oct 12, 2011 at 2:19 PM, Aneesh Kumar K.V wrote: > On Wed, 12 Oct 2011 10:55:21 +0100, Stefan Hajnoczi > wrote: >> On Mon, Oct 10, 2011 at 10:06 AM, Aneesh Kumar K.V >> wrote: >> > diff --git a/hw/9pfs/virtio-9p-handle.c b/hw/9pfs/virtio-9p-handle.c >> > index 5c8b5ed..441a37f 100644 >>

Re: [Qemu-devel] [v7 Patch 4/5]Qemu: Add commandline -drive option 'hostcache'

2011-10-12 Thread Kevin Wolf
Am 11.10.2011 05:11, schrieb Supriya Kannery: > qemu command option 'hostcache' added to -drive for block devices. > While starting a VM from qemu commandline, this option can be used > for setting host cache usage for block data access. Simultaneous > use of 'hostcache' and 'cache' options not al

[Qemu-devel] [PATCH 06/10] scsi-disk: small clean up to INQUIRY

2011-10-12 Thread Paolo Bonzini
Set s->removable, s->qdev.blocksize and s->qdev.type in the callers of scsi_initfn. With this in place, s->qdev.type is allowed, and we can just reuse it as the first byte in VPD data (just like we do in standard INQUIRY data). Also set s->removable is set consistently and we can use it. Signed-o

[Qemu-devel] [PATCH 00/10] scsi: add specialized block device passthrough

2011-10-12 Thread Paolo Bonzini
This series adds a new scsi-block device that is able to do SCSI passthrough for block devices only, but at the same time does not suffer the limitations of scsi-generic. In particular it does not need a bounce buffer that is as big as the request, and will be able to support s/g lists. This puts

[Qemu-devel] [PATCH 03/10] scsi-generic: check ioctl statuses when SG_IO succeeds

2011-10-12 Thread Paolo Bonzini
A succeeding ioctl does not imply that the SCSI command succeeded. Signed-off-by: Paolo Bonzini --- hw/scsi-generic.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c index 5130e9a..04549aa 100644 --- a/hw/scsi-generic.c +++ b/hw/s

Re: [Qemu-devel] [PATCH] hw/9pfs: Handle Security model parsing

2011-10-12 Thread Aneesh Kumar K.V
On Wed, 12 Oct 2011 13:24:16 +0530, "M. Mohan Kumar" wrote: > Security model is needed only for 'local' fs driver. Can you also cleanup that fstype -> fsdriver rename ? fsdriver seems more appropriate. > > Signed-off-by: M. Mohan Kumar > --- > fsdev/qemu-fsdev.c |6 + > fsdev/

Re: [Qemu-devel] [PATCH 1/2] ppc: Generalize the kvmppc_get_clockfreq() function

2011-10-12 Thread Alexander Graf
On 10/11/2011 06:31 AM, David Gibson wrote: Currently the kvmppc_get_clockfreq() function reads the host's clock frequency from /proc/device-tree, which is useful to past to the guest in KVM setups. However, there are some other host properties advertised in the device tree which can also be rel

Re: [Qemu-devel] [PATCH V4 2/2] hw/9pfs: Add readonly support for 9p export

2011-10-12 Thread Aneesh Kumar K.V
On Wed, 12 Oct 2011 13:23:34 +0530, "M. Mohan Kumar" wrote: > A new fsdev parameter "readonly" is introduced to control accessing 9p export. > readonly=on|off can be used to specify the access type. By default rw > access is given. > > Signed-off-by: M. Mohan Kumar > --- > Changes from previous

Re: [Qemu-devel] [PATCH 2/2] pseries: Add device tree properties for VMX/VSX and DFP under kvm

2011-10-12 Thread Alexander Graf
On 10/11/2011 06:31 AM, David Gibson wrote: Sufficiently recent PAPR specifications define properties "ibm,vmx" and "ibm,dfp" on the CPU node which advertise whether the VMX vector extensions (or the later VSX version) and/or the Decimal Floating Point operations from IBM's recent POWER CPUs are

Re: [Qemu-devel] [v7 Patch 1/5]Qemu: Enhance "info block" to display host cache setting

2011-10-12 Thread Kevin Wolf
Am 11.10.2011 05:10, schrieb Supriya Kannery: > Enhance "info block" to display hostcache setting for each > block device. > > Example: > (qemu) info block > ide0-hd0: removable=0 file=../sles11-32.raw ro=0 drv=raw encrypted=0 > > Enhanced to display "hostcache" setting: > (qemu) info block > ide

Re: [Qemu-devel] [RFC PATCH v2] Specification for qcow2 version 3

2011-10-12 Thread Kevin Wolf
Am 12.10.2011 14:51, schrieb Stefan Hajnoczi: >> Also a bit in l2 offset to say "there is no l2 table" cause all >> clusters in l2 are contiguous so we avoid entirely l2. Obviously this >> require an optimization step to detect or create such condition. > > There are several reserved L1 entry bits

Re: [Qemu-devel] [PATCH 1/2] hw/9pfs: Add new virtfs option cache=writethrough to skip host page cache

2011-10-12 Thread Aneesh Kumar K.V
On Wed, 12 Oct 2011 10:55:21 +0100, Stefan Hajnoczi wrote: > On Mon, Oct 10, 2011 at 10:06 AM, Aneesh Kumar K.V > wrote: > > diff --git a/hw/9pfs/virtio-9p-handle.c b/hw/9pfs/virtio-9p-handle.c > > index 5c8b5ed..441a37f 100644 > > --- a/hw/9pfs/virtio-9p-handle.c > > +++ b/hw/9pfs/virtio-9p-hand

Re: [Qemu-devel] [PATCH 0/6] block: do request processing in a coroutine

2011-10-12 Thread Kevin Wolf
Am 05.10.2011 18:17, schrieb Stefan Hajnoczi: > Block layer features like dirty block tracing, I/O throttling, and live block > copy are forced to duplicate code due to the three different interfaces: > synchronous, asynchronous, and coroutines. > > Since there are bdrv_read(), bdrv_aio_readv(), a

Re: [Qemu-devel] [PATCH 4/6] block: switch bdrv_aio_readv() to coroutines

2011-10-12 Thread Kevin Wolf
Am 05.10.2011 18:17, schrieb Stefan Hajnoczi: > More sync, aio, and coroutine unification. Make bdrv_aio_readv() go > through coroutine request processing. > > Signed-off-by: Stefan Hajnoczi > --- > block.c | 48 +++- > 1 files changed, 35 insertion

Re: [Qemu-devel] [RFC PATCH v2] Specification for qcow2 version 3

2011-10-12 Thread Stefan Hajnoczi
On Tue, Jun 28, 2011 at 10:38 AM, Frediano Ziglio wrote: > 2011/6/27 Kevin Wolf : >> This is the second draft for what I think could be added when we increase >> qcow2's >> version number to 3. This includes points that have been made by several >> people >> over the past few months. We're proba

Re: [Qemu-devel] [PATCH 3/6] block: switch bdrv_read()/bdrv_write() to coroutines

2011-10-12 Thread Kevin Wolf
Am 05.10.2011 18:17, schrieb Stefan Hajnoczi: > The bdrv_read()/bdrv_write() functions call .bdrv_read()/.bdrv_write(). > They should go through bdrv_co_do_readv() and bdrv_co_do_writev() > instead in order to unify request processing code across sync, aio, and > coroutine interfaces. This is also

Re: [Qemu-devel] PCI 64-bit BAR access with qemu

2011-10-12 Thread Francois WELLENREITER
Hi Max, thank you for your answer. Actually, I hadn't confused. I already thought to your proposal but I found that it was a really ugly solution (essentially because of the uint32_t to uint64_t silent conversion). Isn't there any other (current or future) development that may fix it ?

Re: [Qemu-devel] [PATCH 0/3] block: zero write detection

2011-10-12 Thread Stefan Hajnoczi
On Wed, Oct 12, 2011 at 12:03 PM, Kevin Wolf wrote: > Am 12.10.2011 12:39, schrieb Stefan Hajnoczi: >> On Tue, Oct 11, 2011 at 03:46:28PM +0200, Kevin Wolf wrote: >>> Am 07.10.2011 17:49, schrieb Stefan Hajnoczi: Image streaming copies data from the backing file into the image file.  It

[Qemu-devel] [PATCH] usb-hid: activate usb tablet / mouse after migration.

2011-10-12 Thread Gerd Hoffmann
qemu uses the ps/2 mouse by default. The usb tablet (or mouse) is activated as soon as qemu sees some guest activity on the device, i.e. polling for HID events. That used to work fine for both fresh boot and migration. Remote wakeup support changed the picture though: There will be no polling af

Re: [Qemu-devel] [BUG] USB assertion triggers in usb_packet_complete()

2011-10-12 Thread Thomas Huth
Am Wed, 12 Oct 2011 11:02:42 +0100 schrieb Stefan Hajnoczi : > On Tue, Oct 11, 2011 at 8:35 AM, Thomas Huth wrote: > > Am Mon, 10 Oct 2011 15:03:41 +0200 > > schrieb Thomas Huth : > >> > >> I am currently facing a problem when running QEMU (up-to-date git > >> version) with OHCI and a lot of virt

[Qemu-devel] balloon driver on winxp guest start failed

2011-10-12 Thread hkran
Hi, I used balloon driver for windows virtio-win-0.1-15.iso (from http://alt.fedoraproject.org/pub/alt/virtio-win/latest/images/bin/) following the install guard , I installed the balloon driver like this: devcon.exe install d:\wxp\x86\balloon.inf "PCI\VEN_1AF4&DEV_1002&SUBSYS_00051AF4&REV_

Re: [Qemu-devel] [PATCH 0/3] block: zero write detection

2011-10-12 Thread Kevin Wolf
Am 12.10.2011 12:39, schrieb Stefan Hajnoczi: > On Tue, Oct 11, 2011 at 03:46:28PM +0200, Kevin Wolf wrote: >> Am 07.10.2011 17:49, schrieb Stefan Hajnoczi: >>> Image streaming copies data from the backing file into the image file. It >>> is >>> important to represent zero regions from the backin

Re: [Qemu-devel] PCI 64-bit BAR access with qemu

2011-10-12 Thread Max Filippov
>    I've read a few days ago that it was possible to emulate PCI device with > 64-bit BARs and have a real 64-bit memory access. > Thus, I've created a virtual device named toto accessible through a 64-bit > BAR You've probably confused an ability to locate BAR anywhere in 64-bit address space (s

Re: [Qemu-devel] [PATCH 0/3] block: zero write detection

2011-10-12 Thread Stefan Hajnoczi
On Tue, Oct 11, 2011 at 03:46:28PM +0200, Kevin Wolf wrote: > Am 07.10.2011 17:49, schrieb Stefan Hajnoczi: > > Image streaming copies data from the backing file into the image file. It > > is > > important to represent zero regions from the backing file efficiently during > > streaming, otherwis

[Qemu-devel] PCI 64-bit BAR access with qemu

2011-10-12 Thread Francois WELLENREITER
Hi there, I've read a few days ago that it was possible to emulate PCI device with 64-bit BARs and have a real 64-bit memory access. Thus, I've created a virtual device named toto accessible through a 64-bit BAR ___ static const MemoryRegionOps bxi_common_mmio_ops = { .read = toto_m

Re: [Qemu-devel] [BUG] USB assertion triggers in usb_packet_complete()

2011-10-12 Thread Stefan Hajnoczi
On Tue, Oct 11, 2011 at 8:35 AM, Thomas Huth wrote: > Am Mon, 10 Oct 2011 15:03:41 +0200 > schrieb Thomas Huth : >> >> I am currently facing a problem when running QEMU (up-to-date git >> version) with OHCI and a lot of virtual USB devices. >> The emulator dies with the following assertion: >> >>

Re: [Qemu-devel] [PATCH 1/2] hw/9pfs: Add new virtfs option cache=writethrough to skip host page cache

2011-10-12 Thread Stefan Hajnoczi
On Mon, Oct 10, 2011 at 10:06 AM, Aneesh Kumar K.V wrote: > diff --git a/hw/9pfs/virtio-9p-handle.c b/hw/9pfs/virtio-9p-handle.c > index 5c8b5ed..441a37f 100644 > --- a/hw/9pfs/virtio-9p-handle.c > +++ b/hw/9pfs/virtio-9p-handle.c > @@ -202,6 +202,15 @@ static ssize_t handle_pwritev(FsContext *ctx

Re: [Qemu-devel] qemu-0.15.1 stable call for patches

2011-10-12 Thread Brad
On 26/09/11 9:16 AM, Justin M. Forbes wrote: With the current patch queue I would like to start getting qemu-0.15.1 stable into shape. With this in mind, the plan is to tag the release on Monday Oct 3rd. If you have patches pending for stable, now would be the time to send them. Please CC jmfor

Re: [Qemu-devel] Is realview-pb-a8 fully supported ?

2011-10-12 Thread Peter Maydell
On 10 October 2011 14:48, Francis Moreau wrote: > On Mon, Oct 10, 2011 at 10:42 AM, Peter Maydell > wrote: >> On 10 October 2011 08:35, Francis Moreau wrote: >>> I noticed another point for the realview platofrm: if I boot with "-M >>> 512", it works however if I set "-M 256" then it doesn't. >>

Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA

2011-10-12 Thread Michael S. Tsirkin
On Wed, Oct 12, 2011 at 02:09:26PM +1100, David Gibson wrote: > On Mon, Oct 03, 2011 at 08:17:05AM -0500, Anthony Liguori wrote: > > On 10/02/2011 07:14 AM, Michael S. Tsirkin wrote: > > >On Sun, Oct 02, 2011 at 02:01:10PM +0200, Avi Kivity wrote: > > >>>Hmm, not entirely virtio specific, some devi

Re: [Qemu-devel] [PATCH 3/6] block: switch bdrv_read()/bdrv_write() to coroutines

2011-10-12 Thread Zhi Yong Wu
On Wed, Oct 12, 2011 at 5:03 PM, Stefan Hajnoczi wrote: > On Tue, Oct 11, 2011 at 7:44 AM, Zhi Yong Wu wrote: >> On Thu, Oct 6, 2011 at 12:17 AM, Stefan Hajnoczi >> wrote: >>> @@ -1101,36 +1144,7 @@ static void set_dirty_bitmap(BlockDriverState *bs, >>> int64_t sector_num, >>>  int bdrv_write(B

Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA

2011-10-12 Thread Gerd Hoffmann
Hi, Yes.. as do the stX_pci_dma() helpers. They assume LE, rather than having two variants, because PCI is an LE spec, and all normal PCI devices work in LE. IMO, not really. PCI devices do DMA any way they like. LE is probably more common because both ARM and x86 processors are LE. Also

Re: [Qemu-devel] [PATCH 3/6] block: switch bdrv_read()/bdrv_write() to coroutines

2011-10-12 Thread Stefan Hajnoczi
On Tue, Oct 11, 2011 at 7:44 AM, Zhi Yong Wu wrote: > On Thu, Oct 6, 2011 at 12:17 AM, Stefan Hajnoczi > wrote: >> @@ -1101,36 +1144,7 @@ static void set_dirty_bitmap(BlockDriverState *bs, >> int64_t sector_num, >>  int bdrv_write(BlockDriverState *bs, int64_t sector_num, >>                const

Re: [Qemu-devel] [PATCH 01/36] ds1225y: Use stdio instead of QEMUFile

2011-10-12 Thread Zhi Hui Li
On 10/11/2011 06:00 PM, Juan Quintela wrote: QEMUFile * is only intended for migration nowadays. Using it for anything else just adds pain and a layer of buffers for no good reason. Signed-off-by: Juan Quintela --- hw/ds1225y.c | 28 1 files changed, 16 inserti

Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA

2011-10-12 Thread Michael S. Tsirkin
On Wed, Oct 12, 2011 at 02:11:37PM +1100, David Gibson wrote: > On Sun, Oct 02, 2011 at 12:52:39PM +0200, Michael S. Tsirkin wrote: > > On Sun, Oct 02, 2011 at 12:29:08PM +0200, Avi Kivity wrote: > > > On 10/02/2011 12:25 PM, Michael S. Tsirkin wrote: > > > >On Mon, Sep 05, 2011 at 02:34:56PM +1000

Re: [Qemu-devel] [PATCH] hw/9pfs: Handle Security model parsing

2011-10-12 Thread Daniel P. Berrange
On Wed, Oct 12, 2011 at 01:24:16PM +0530, M. Mohan Kumar wrote: > Security model is needed only for 'local' fs driver. > > Signed-off-by: M. Mohan Kumar > --- > fsdev/qemu-fsdev.c |6 + > fsdev/qemu-fsdev.h |1 + > hw/9pfs/virtio-9p-device.c | 47 +++

[Qemu-devel] [PATCH] hw/9pfs: Handle Security model parsing

2011-10-12 Thread M. Mohan Kumar
Security model is needed only for 'local' fs driver. Signed-off-by: M. Mohan Kumar --- fsdev/qemu-fsdev.c |6 + fsdev/qemu-fsdev.h |1 + hw/9pfs/virtio-9p-device.c | 47 ++- vl.c | 20 +++--

Re: [Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-10-12 Thread Stefan Hajnoczi
On Tue, Oct 11, 2011 at 04:22:11PM +0200, Kevin Wolf wrote: > Am 30.09.2011 17:49, schrieb Amit Shah: > > On (Fri) 30 Sep 2011 [16:23:30], Stefan Hajnoczi wrote: > >> On Fri, Sep 30, 2011 at 12:27 PM, Amit Shah wrote: > >>> On (Fri) 30 Sep 2011 [11:39:11], Stefan Hajnoczi wrote: > QED's metad

[Qemu-devel] [PATCH V4 2/2] hw/9pfs: Add readonly support for 9p export

2011-10-12 Thread M. Mohan Kumar
A new fsdev parameter "readonly" is introduced to control accessing 9p export. readonly=on|off can be used to specify the access type. By default rw access is given. Signed-off-by: M. Mohan Kumar --- Changes from previous version V3: * Use opt_set_bool function to set readonly option * Change the

[Qemu-devel] [PATCH 1/2] Add opt_set_bool function

2011-10-12 Thread M. Mohan Kumar
In addition to qemu_opt_set function, we need a function to set bool value also. Signed-off-by: M. Mohan Kumar --- qemu-option.c | 35 +++ qemu-option.h |1 + 2 files changed, 36 insertions(+), 0 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index

Re: [Qemu-devel] [PATCH] spice-input: migrate ledstate

2011-10-12 Thread Gerd Hoffmann
Hi, There is no ledstate in a PS/2 keyboard (or I'm reading too much into the implementation in qemu). There is. It isn't explicitly stored into the state struct though because the ps/2 keyboard itself doesn't use it, it just calls kbd_put_ledstate() to inform others about it. cheers,

Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA

2011-10-12 Thread Michael S. Tsirkin
On Wed, Oct 12, 2011 at 02:07:46PM +1100, David Gibson wrote: > Um.. why? PCI is defined by the spec to be LE, so I don't see that we > need explicit endianness versions for PCI helpers. LE in the spec only applies to structures defined by the spec, that is pci configuration and msix tables in de

Re: [Qemu-devel] [PATCH 1/1 V2] kernel/kvm: fix improper nmi emulation

2011-10-12 Thread Kenji Kaneshige
(2011/10/12 2:00), Lai Jiangshan wrote: > From: Kenji Kaneshige > > Currently, NMI interrupt is blindly sent to all the vCPUs when NMI > button event happens. This doesn't properly emulate real hardware on > which NMI button event triggers LINT1. Because of this, NMI is sent to > the processor eve

Re: [Qemu-devel] [PATCH] kernel/kvm: fix improper nmi emulation

2011-10-12 Thread Kenji Kaneshige
(2011/10/10 19:26), Avi Kivity wrote: > On 10/10/2011 08:06 AM, Lai Jiangshan wrote: >> From: Kenji Kaneshige >> >> Currently, NMI interrupt is blindly sent to all the vCPUs when NMI >> button event happens. This doesn't properly emulate real hardware on >> which NMI button event triggers LINT1. Be