Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-04-24 Thread Jan Kiszka
On 2012-04-23 22:02, Eduardo Habkost wrote: > On Mon, Apr 23, 2012 at 06:31:25PM +0200, Jan Kiszka wrote: >> On 2012-04-23 16:48, Eduardo Habkost wrote: >>> Trying to summarize the points above: >>> >>> Groups (A) and (B) are: >>> >>> A) a feature that KVM supports and emulate by itself and can be

Re: [Qemu-devel] Spice vdagent on SLED 11

2012-04-24 Thread Andrew Cathrow
do you have the configuration ? is there a libvirt xml, or a command line in a script? - Original Message - > From: "Raj Rajasekaran" > To: "Andrew Cathrow" > Cc: qemu-devel@nongnu.org > Sent: Tuesday, April 24, 2012 11:59:07 AM > Subject: Re: [Qemu-devel] Spice vdagent on SLED 11 > >

Re: [Qemu-devel] [PATCH v2 3/6] block: change block-job-set-speed argument from 'value' to 'speed'

2012-04-24 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 4:03 PM, Eric Blake wrote: > On 04/24/2012 07:53 AM, Stefan Hajnoczi wrote: >> Signed-off-by: Stefan Hajnoczi >> --- >>  block.c          |    6 +++--- >>  block/stream.c   |    8 >>  block_int.h      |    4 ++-- >>  blockdev.c       |    4 ++-- >>  hmp-commands.h

Re: [Qemu-devel] Spice vdagent on SLED 11

2012-04-24 Thread Raj Rajasekaran
Yes. On Tue, Apr 24, 2012 at 10:48 AM, Andrew Cathrow wrote: > > > - Original Message - > > From: "Raj Rajasekaran" > > To: "Andrew Cathrow" > > Cc: qemu-devel@nongnu.org > > Sent: Tuesday, April 24, 2012 11:43:12 AM > > Subject: Re: [Qemu-devel] Spice vdagent on SLED 11 > > > > > > Whe

Re: [Qemu-devel] [PATCH v2 4/6] block: add 'speed' optional parameter to block-stream

2012-04-24 Thread Eric Blake
On 04/24/2012 07:53 AM, Stefan Hajnoczi wrote: > Allow streaming operations to be started with an initial speed limit. > This eliminates the window of time between starting streaming and > issuing block-job-set-speed. Users should use the new optional 'speed' > parameter instead so that speed limi

[Qemu-devel] [PATCH 07/14] usb-xhci: Use PCI DMA helper functions

2012-04-24 Thread Gerd Hoffmann
From: David Gibson Shortly before 1.0, we added helper functions / wrappers for doing PCI DMA from individual devices. This makes what's going on clearer and means that when we add IOMMU support somewhere in the future, only the general PCI code will have to change, not every device that uses PC

Re: [Qemu-devel] [PATCH 1/3] qemu-iotests: Many parallel allocating I/O requests

2012-04-24 Thread Eric Blake
On 04/24/2012 09:16 AM, Kevin Wolf wrote: > Am 24.04.2012 16:38, schrieb Kevin Wolf: >> This test case manages to let qcow2 abort because its cache is used up >> and it can't find free cache entries for new requests any more. >> >> Signed-off-by: Kevin Wolf >> --- >> tests/qemu-iotests/035 |

[Qemu-devel] [PATCH 01/14] usb-ehci: remove hack

2012-04-24 Thread Gerd Hoffmann
To answer the question in the comment removed by this patch: I think this was needed because several places in the ehci emulation did not check the T bit of link entries correctly and thus might have followed invalid references. See commit 2a5ff735dc1074171a0cbb1dc228d6d6e907f571 Signed-off-by:

[Qemu-devel] [PATCH 04/14] usb-storage: fix request canceling

2012-04-24 Thread Gerd Hoffmann
Little fix for usb packet handling on i/o cancelation. The usb packet pointer (s->packet) is cleared at the wrong place: The scsi request cancel handler does it. When a usb packet is canceled the usb-storage emulation canceles the scsi request if present. In most cases there is one, so usually s

[Qemu-devel] [PATCH 09/14] usb-redir: An interface count of 0 is a valid value

2012-04-24 Thread Gerd Hoffmann
From: Hans de Goede An interface-count of 0 happens when a device is in unconfigured state when it gets redirected. So we should not use 0 to detect not having received interface info from our peer. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c |5 +++--

[Qemu-devel] [PULL 00/14] usb patch queue

2012-04-24 Thread Gerd Hoffmann
Hi, Nothing major, just a bag of bugfixes. please pull, Gerd The following changes since commit 092dfc7714ad7983aeb0cada5d5983e9fde8d84c: Merge remote-tracking branch 'origin/master' into staging (2012-04-23 15:02:53 -0500) are available in the git repository at: git://git.kraxel.org

Re: [Qemu-devel] [PATCH v2 5/6] qemu-iotests: add block-stream with invalid speed value test

2012-04-24 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 4:22 PM, Eric Blake wrote: > On 04/24/2012 07:53 AM, Stefan Hajnoczi wrote: >> Add a test to exercise the BlockJobSpeedInvalid error code path in the >> block-stream command.  The 'speed' parameter allows the speed limit of >> the job to be applied immediately when the job

Re: [Qemu-devel] Spice vdagent on SLED 11

2012-04-24 Thread Andrew Cathrow
- Original Message - > From: "Raj Rajasekaran" > To: "Andrew Cathrow" > Cc: qemu-devel@nongnu.org > Sent: Tuesday, April 24, 2012 11:43:12 AM > Subject: Re: [Qemu-devel] Spice vdagent on SLED 11 > > > Where do I check whether VM is configured to expose this virtio > serial device? If

Re: [Qemu-devel] [PATCH v2 4/6] block: add 'speed' optional parameter to block-stream

2012-04-24 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 4:17 PM, Eric Blake wrote: > On 04/24/2012 07:53 AM, Stefan Hajnoczi wrote: >> Allow streaming operations to be started with an initial speed limit. >> This eliminates the window of time between starting streaming and >> issuing block-job-set-speed.  Users should use the ne

Re: [Qemu-devel] Spice vdagent on SLED 11

2012-04-24 Thread Raj Rajasekaran
Where do I check whether VM is configured to expose this virtio serial device? If not how to configure it. On Mon, Apr 23, 2012 at 7:45 PM, Andrew Cathrow wrote: > > > - Original Message - > > From: "Raj Rajasekaran" > > To: qemu-devel@nongnu.org > > Sent: Monday, April 23, 2012 11:35:5

Re: [Qemu-devel] [PATCHv2 3/3] virtio: order index/descriptor reads

2012-04-24 Thread Paolo Bonzini
Il 24/04/2012 17:11, Michael S. Tsirkin ha scritto: > On Tue, Apr 24, 2012 at 05:01:07PM +0200, Paolo Bonzini wrote: >> Il 24/04/2012 16:38, Michael S. Tsirkin ha scritto: > I think it is prudent to address this theoretical race condition. I think your fix is right, but it is not need

[Qemu-devel] [PATCHv3 1/3] virtio: add missing mb() on notification

2012-04-24 Thread Michael S. Tsirkin
During normal operation, virtio first writes a used index and then checks whether it should interrupt the guest by reading guest avail index/flag values. Guest does the reverse: writes the index/flag, then checks the used ring. The ordering is important: if host avail flag read bypasses the used

[Qemu-devel] [PATCHv3 2/3] virtio: add missing mb() on enable notification

2012-04-24 Thread Michael S. Tsirkin
This fixes an issue dual to the one fixed by patch 'virtio: add missing mb() on notification' and applies on top. In this case, to enable vq kick to exit to host, qemu writes out used flag then reads the avail index. if these are reordered we get a race: host avail index read: ring is empty

[Qemu-devel] [PATCHv3 0/3] virtio: fix memory access races

2012-04-24 Thread Michael S. Tsirkin
This is a follow-up to my previous patch: it turns out that a single mb() isn't sufficient as network loss could still be triggered under stress. Changes from v2: Fix up GCC detection: reported by malc. Fix barriers on PPC: reported by paolo. Fix typo breaking bisect: reported by paolo. Changes f

Re: [Qemu-devel] [PATCH v2 5/6] qemu-iotests: add block-stream with invalid speed value test

2012-04-24 Thread Eric Blake
On 04/24/2012 07:53 AM, Stefan Hajnoczi wrote: > Add a test to exercise the BlockJobSpeedInvalid error code path in the > block-stream command. The 'speed' parameter allows the speed limit of > the job to be applied immediately when the job starts instead of issuing > a separate block-job-set-spee

Re: [Qemu-devel] [PATCH 1/3] qemu-iotests: Many parallel allocating I/O requests

2012-04-24 Thread Kevin Wolf
Am 24.04.2012 16:38, schrieb Kevin Wolf: > This test case manages to let qcow2 abort because its cache is used up > and it can't find free cache entries for new requests any more. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/035 | 72 > tests/qemu-iotests/035.out | 39

Re: [Qemu-devel] [PATCHv2 3/3] virtio: order index/descriptor reads

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 05:01:07PM +0200, Paolo Bonzini wrote: > Il 24/04/2012 16:38, Michael S. Tsirkin ha scritto: > >>> I think it is prudent to address this theoretical race condition. > >> > >> I think your fix is right, but it is not needed on x86. lfence is only > >> required for weakly-ord

Re: [Qemu-devel] [PATCH 1/3] qemu-iotests: Many parallel allocating I/O requests

2012-04-24 Thread Paolo Bonzini
Il 24/04/2012 16:38, Kevin Wolf ha scritto: > +wrote 512/512 bytes at offset XXX > +512.00 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) One patch in my posted queue fixes the useless ".00" (and another related bug where decimals are *missing*); just a heads-up. Otherwise the ser

Re: [Qemu-devel] [PATCH v2 3/6] block: change block-job-set-speed argument from 'value' to 'speed'

2012-04-24 Thread Eric Blake
On 04/24/2012 07:53 AM, Stefan Hajnoczi wrote: > Signed-off-by: Stefan Hajnoczi > --- > block.c |6 +++--- > block/stream.c |8 > block_int.h |4 ++-- > blockdev.c |4 ++-- > hmp-commands.hx |4 ++-- > qapi-schema.json |4 ++-- > qmp-command

Re: [Qemu-devel] [PATCHv2 3/3] virtio: order index/descriptor reads

2012-04-24 Thread Paolo Bonzini
Il 24/04/2012 16:38, Michael S. Tsirkin ha scritto: >>> I think it is prudent to address this theoretical race condition. >> >> I think your fix is right, but it is not needed on x86. lfence is only >> required for weakly-ordered memory types, so says Intel, > > I see this in spec: > > The LFENC

[Qemu-devel] [PATCH 3/3] qcow2: Don't hold cache references across yield

2012-04-24 Thread Kevin Wolf
If cache references are held while the coroutine has yielded, the cache may get used up and abort() when it can't find a free entry. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 21 + 1 files changed, 13 insertions(+), 8 deletions(-) diff --git a/block/qcow2-clust

[Qemu-devel] [PATCH 2/3] qcow2: Remove unused parameter in do_alloc_cluster_offset

2012-04-24 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index a747a88..7edc043 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-cluster.c @@ -759,7 +759,7 @@ out: * restarte

[Qemu-devel] [PATCH v2 2/6] block: use Error mechanism instead of -errno for block_job_set_speed()

2012-04-24 Thread Stefan Hajnoczi
There are at least two different errors that can occur in block_job_set_speed(): the job might not support setting speeds or the value might be invalid. Use the Error mechanism to report the error where it occurs. Cc: Luiz Capitulino Signed-off-by: Stefan Hajnoczi --- block.c | 17 +

Re: [Qemu-devel] [PATCHv2 2/3] virtio: add missing mb() on enable notification

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 04:03:16PM +0200, Paolo Bonzini wrote: > Il 23/04/2012 15:19, Michael S. Tsirkin ha scritto: > > @@ -694,7 +698,7 @@ static bool vring_notify(VirtIODevice *vdev, VirtQueue > > *vq) > > uint16_t old, new; > > bool v; > > /* We need to expose used array entries

[Qemu-devel] [PATCH v2 5/6] qemu-iotests: add block-stream with invalid speed value test

2012-04-24 Thread Stefan Hajnoczi
Add a test to exercise the BlockJobSpeedInvalid error code path in the block-stream command. The 'speed' parameter allows the speed limit of the job to be applied immediately when the job starts instead of issuing a separate block-job-set-speed command later. If the parameter has an invalid value

Re: [Qemu-devel] [PATCH v2 1/6] block: use Error mechanism instead of -errno for block_job_create()

2012-04-24 Thread Eric Blake
On 04/24/2012 07:53 AM, Stefan Hajnoczi wrote: > The block job API uses -errno return values internally and we convert > these to Error in the QMP functions. This is ugly because the Error > should be created at the point where we still have all the relevant > information. More importantly, it is

Re: [Qemu-devel] [PATCHv2 1/3] virtio: add missing mb() on notification

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 06:24:14PM +0400, malc wrote: > On Tue, 24 Apr 2012, Paolo Bonzini wrote: > > > Il 24/04/2012 16:20, Michael S. Tsirkin ha scritto: > > > On Tue, Apr 24, 2012 at 03:46:25PM +0200, Paolo Bonzini wrote: > > >> Il 23/04/2012 15:19, Michael S. Tsirkin ha scritto: > > >>> During

Re: [Qemu-devel] [PATCHv2 3/3] virtio: order index/descriptor reads

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 03:48:27PM +0200, Paolo Bonzini wrote: > Il 23/04/2012 15:19, Michael S. Tsirkin ha scritto: > > virtio has the equivalent of: > > > > if (vq->last_avail_index != vring_avail_idx(vq)) { > > read descriptor head at vq->last_avail_index; > > } > > > > In

Re: [Qemu-devel] [RFC 07/14] Drop darwin-user

2012-04-24 Thread Peter Maydell
On 16 April 2012 15:31, Andreas Färber wrote: > It's been orphaned, not compiling for a long time and despite Apple's > drop of their Rosetta ppc emulation technology with Mac OS X Lion no one > has stepped up to fix it. > > Testing necessary changes wrt QOM'ification thus is impossible, so we > m

Re: [Qemu-devel] [PATCH 1/5] hw/ac97: Fix log message in mixer_load

2012-04-24 Thread Anthony Liguori
On 04/20/2012 06:03 AM, Hans de Goede wrote: Fix a small copy and paste error in logging. Signed-off-by: Hans de Goede Please CC malc for audio changes. For what it's worth, the whole series: Tested-by: Anthony Liguori Regards, Anthony Liguori --- hw/ac97.c |2 +- 1 file changed,

[Qemu-devel] [PATCH 1/3] qemu-iotests: Many parallel allocating I/O requests

2012-04-24 Thread Kevin Wolf
This test case manages to let qcow2 abort because its cache is used up and it can't find free cache entries for new requests any more. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/035 | 72 tests/qemu-iotests/035.out | 392 tests/q

[Qemu-devel] [PATCH 0/3] qcow2: Don't hold cache references across yield

2012-04-24 Thread Kevin Wolf
This fixes an abort() condition during heavy AIO involving different L2 tables. Kevin Wolf (3): qemu-iotests: Many parallel allocating I/O requests qcow2: Remove unused parameter in do_alloc_cluster_offset qcow2: Don't hold cache references across yield block/qcow2-cluster.c | 25 ++

Re: [Qemu-devel] [PATCH 4/5] implement -no-user-config command-line option

2012-04-24 Thread Anthony Liguori
On 04/18/2012 03:02 PM, Eduardo Habkost wrote: Signed-off-by: Eduardo Habkost --- arch_init.c | 10 +++--- arch_init.h |2 +- qemu-options.hx | 16 +--- vl.c|6 +- 4 files changed, 26 insertions(+), 8 deletions(-) diff --git a/arch_init.c

Re: [Qemu-devel] [PATCH v2 0/2] Updated fixes for block job cancellation

2012-04-24 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 2:26 PM, Paolo Bonzini wrote: > These patches fix the existing problems with synchronous job > cancellation without adding a bdrv_drain_all in the asynchronous > block_job_cancel. > > Paolo Bonzini (2): >  block: add block_job_sleep_ns >  block: wait for job callback in blo

Re: [Qemu-devel] [PATCHv2 1/3] virtio: add missing mb() on notification

2012-04-24 Thread malc
On Tue, 24 Apr 2012, Paolo Bonzini wrote: > Il 24/04/2012 16:20, Michael S. Tsirkin ha scritto: > > On Tue, Apr 24, 2012 at 03:46:25PM +0200, Paolo Bonzini wrote: > >> Il 23/04/2012 15:19, Michael S. Tsirkin ha scritto: > >>> During normal operation, virtio first writes a used index > >>> and then

Re: [Qemu-devel] [PATCHv2 1/3] virtio: add missing mb() on notification

2012-04-24 Thread Paolo Bonzini
Il 24/04/2012 16:20, Michael S. Tsirkin ha scritto: > On Tue, Apr 24, 2012 at 03:46:25PM +0200, Paolo Bonzini wrote: >> Il 23/04/2012 15:19, Michael S. Tsirkin ha scritto: >>> During normal operation, virtio first writes a used index >>> and then checks whether it should interrupt the guest >>> by

[Qemu-devel] [PATCH v3 01/15] target-i386: Fix x86_cpuid_set_model_id()

2012-04-24 Thread Andreas Färber
Don't assume zeroed cpuid_model[] fields. This didn't break anything yet but QOM properties should be able to set the value to something else without setting an intermediate zero string. Signed-off-by: Andreas Färber --- Since I managed to screw this change up on first try (using size 12), let

[Qemu-devel] [PATCH v2 6/6] qemu-iotests: fix missing 'result' variable assignment in 030

2012-04-24 Thread Stefan Hajnoczi
We test this value after block-job-cancel but forget to actually assign it. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/030 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030 index fdd7b3e..88a9b58 100755 --- a/tests/q

Re: [Qemu-devel] [PATCHv2 1/3] virtio: add missing mb() on notification

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 03:46:25PM +0200, Paolo Bonzini wrote: > Il 23/04/2012 15:19, Michael S. Tsirkin ha scritto: > > During normal operation, virtio first writes a used index > > and then checks whether it should interrupt the guest > > by reading guest avail index/flag values. > > > > Guest d

Re: [Qemu-devel] [PATCH] xen_disk: remove syncwrite option

2012-04-24 Thread Kevin Wolf
Am 24.04.2012 13:55, schrieb Stefano Stabellini: > On Tue, 24 Apr 2012, Kevin Wolf wrote: >> Am 24.04.2012 13:22, schrieb Stefano Stabellini: >>> Use the BDRV_O_CACHE_* flags instead. >>> >>> Signed-off-by: Stefano Stabellini >> >> Doesn't apply to qemu.git because... >> >>> --- >>> hw/xen_disk.c

[Qemu-devel] [PATCH v2 1/6] block: use Error mechanism instead of -errno for block_job_create()

2012-04-24 Thread Stefan Hajnoczi
The block job API uses -errno return values internally and we convert these to Error in the QMP functions. This is ugly because the Error should be created at the point where we still have all the relevant information. More importantly, it is hard to add new error cases to this case since we quic

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: > From: Alon Levy > > guest_connected should be false before guest driver initialization, and > true after, both for multiport aware and non multiport aware drivers. > > Don't set it before the guest_features are available; instead use >

Re: [Qemu-devel] [PATCH 00/15] QOM'ify x86 CPU, part 2: properties

2012-04-24 Thread Eduardo Habkost
On Tue, Apr 24, 2012 at 11:00:49AM +0200, Andreas Färber wrote: > Am 19.04.2012 20:27, schrieb Eduardo Habkost: > > By the way, do you still plan to make cpudefs register new > > classes/types? I remember that you did that on a previous series. > > Generally I do, yes. However the CPU QOM'ificatio

[Qemu-devel] [PATCH] usb-host: add timeout handler

2012-04-24 Thread Gerd Hoffmann
Add a timeout handler. In case bulk transfers take too long to finish the request will be canceled. The timeout is tunable via property, by default it is 5 seconds. Signed-off-by: Gerd Hoffmann --- hw/usb/host-linux.c | 27 +++ trace-events|1 + 2 files ch

[Qemu-devel] [RFC PATCH 1/1] virtio-serial-bus: Unset guest_connected at reset and driver reset

2012-04-24 Thread Amit Shah
When a guest driver resets the virtio status to not ready, or when qemu is reset, reset the guest_connected bit and let ports know if they have the guest_close() callback registered. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 28 1 files changed, 28 inse

Re: [Qemu-devel] [PATCH v2 00/15] QOM'ify x86 CPU, part 2: properties

2012-04-24 Thread Igor Mammedov
Series looks good to me. Reviewed-By: Igor Mammedov On 04/24/2012 11:33 AM, Andreas Färber wrote: Hello, This series introduces some QOM properties for X86CPU, so that our built-in init code exercises the same code paths as QMP, as suggested by Eduardo: * "family", * "model", * "stepping" and

Re: [Qemu-devel] Assertion after chaning display resolution

2012-04-24 Thread Alon Levy
On Tue, Apr 24, 2012 at 03:24:31PM +0200, Peter Lieven wrote: > Hi all, > > I saw the following assert after chaning display resolution. This might be > the cause, but i am not sure. Threaded VNC is enabled. > Anyone ever seen this? > > qemu-kvm-1.0: malloc.c:3096: sYSMALLOc: Assertion `(old_top

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 05:10:23PM +0530, Amit Shah wrote: > > Sure. So fix it for single port now and for multiport in a > > separate patch. Alon's patch is a single line and it made sense, yours > > differs in that you have added more code to implement a bug. > > Disagree; it was not obvious in

Re: [Qemu-devel] [PATCHv2 2/3] virtio: add missing mb() on enable notification

2012-04-24 Thread Paolo Bonzini
Il 23/04/2012 15:19, Michael S. Tsirkin ha scritto: > @@ -694,7 +698,7 @@ static bool vring_notify(VirtIODevice *vdev, VirtQueue > *vq) > uint16_t old, new; > bool v; > /* We need to expose used array entries before checking used event. */ > -mb(); > +smp_mb(); This mb() is

Re: [Qemu-devel] KVM call agenda for April, Tuesday 24

2012-04-24 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda items you are interested in covering. > > Thanks, Juan. As there are no topic, call is cancelled. Happy hacking, Juan.

Re: [Qemu-devel] [PATCH] qxl: don't assert on guest create_guest_primary

2012-04-24 Thread Gerd Hoffmann
>> Allowing guests to do that without giving them a way to figure whenever >> it will work or not doesn't look that useful to me. > > OK - so maybe just have this as a guest_bug instead of an assert? Yes, please. thanks, Gerd

[Qemu-devel] [PATCH v2 3/6] block: change block-job-set-speed argument from 'value' to 'speed'

2012-04-24 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- block.c |6 +++--- block/stream.c |8 block_int.h |4 ++-- blockdev.c |4 ++-- hmp-commands.hx |4 ++-- qapi-schema.json |4 ++-- qmp-commands.hx |2 +- 7 files changed, 16 insertions(+), 16 deletions(

[Qemu-devel] [PATCH v2 4/6] block: add 'speed' optional parameter to block-stream

2012-04-24 Thread Stefan Hajnoczi
Allow streaming operations to be started with an initial speed limit. This eliminates the window of time between starting streaming and issuing block-job-set-speed. Users should use the new optional 'speed' parameter instead so that speed limits are in effect immediately when the job starts. Sign

[Qemu-devel] [PATCH v2 0/6] block: add optional 'speed' parameter to block-stream

2012-04-24 Thread Stefan Hajnoczi
Eric Blake raised concerns about the inability to start block jobs with a speed limit. Current the user needs to follow up the block-stream command with block-job-set-speed. There is a window of time while the new block job is running but block-job-set-speed has not been processed yet. This seri

Re: [Qemu-devel] [PATCHv2 3/3] virtio: order index/descriptor reads

2012-04-24 Thread Paolo Bonzini
Il 23/04/2012 15:19, Michael S. Tsirkin ha scritto: > virtio has the equivalent of: > > if (vq->last_avail_index != vring_avail_idx(vq)) { > read descriptor head at vq->last_avail_index; > } > > In theory, processor can reorder descriptor head > read to happen speculativ

Re: [Qemu-devel] [PATCH v6 5/5] FreeSCALE i.MX31 support: KZM-ARM11-01 evaluation board

2012-04-24 Thread Peter Maydell
On 23 April 2012 23:21, Peter Chubb wrote: > Peter> Are these two devices really on the same IRQ? > > Yes.  A single interrupt line comes from the FPGA into the AVIC. > Inside the FPGA the interrupts for the UARTs, SD card and NAND flash > are connected to that single interrupt line. > The non-tou

Re: [Qemu-devel] [PATCHv2 1/3] virtio: add missing mb() on notification

2012-04-24 Thread Paolo Bonzini
Il 23/04/2012 15:19, Michael S. Tsirkin ha scritto: > During normal operation, virtio first writes a used index > and then checks whether it should interrupt the guest > by reading guest avail index/flag values. > > Guest does the reverse: writes the index/flag, > then checks the used ring. > > T

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Kevin Wolf
Am 24.04.2012 11:55, schrieb Pavel Hrdina: > On 04/24/2012 11:32 AM, Kevin Wolf wrote: >> Am 23.04.2012 18:06, schrieb Pavel Hrdina: >>> Hi, >>> this is the patch to fix incorrect handling of IDE floppy drive controller >>> emulation >>> when no media is present. If the guest is booted without a m

Re: [Qemu-devel] [PATCH] qxl: don't assert on guest create_guest_primary

2012-04-24 Thread Gerd Hoffmann
On 04/18/12 13:00, Alon Levy wrote: > initiate the implicit destroy ourselves. What is the use case? Allowing guests to do that without giving them a way to figure whenever it will work or not doesn't look that useful to me. cheers, Gerd

Re: [Qemu-devel] [RFC] qxl: don't panic on phys2virt

2012-04-24 Thread Gerd Hoffmann
On 03/30/12 21:27, Alon Levy wrote: > On Fri, Mar 30, 2012 at 10:09:42AM +0200, Gerd Hoffmann wrote: >> On 03/29/12 22:56, Alon Levy wrote: >>> Issues a qxl_guest_bug from qxl_phys2virt. Everywhere else will fail. >> >> Nice start (there are more guest-triggerable asserts to be fixed this way). >>

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Pavel Hrdina
On 04/24/2012 01:38 PM, Stefan Hajnoczi wrote: On Tue, Apr 24, 2012 at 10:46 AM, Pavel Hrdina wrote: On 04/24/2012 11:06 AM, Stefan Hajnoczi wrote: On Mon, Apr 23, 2012 at 5:06 PM, Pavel Hrdina wrote: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation

Re: [Qemu-devel] Assertion after chaning display resolution

2012-04-24 Thread Peter Lieven
On 24.04.2012 15:34, Alon Levy wrote: On Tue, Apr 24, 2012 at 03:24:31PM +0200, Peter Lieven wrote: Hi all, I saw the following assert after chaning display resolution. This might be the cause, but i am not sure. Threaded VNC is enabled. Anyone ever seen this? qemu-kvm-1.0: malloc.c:3096: sY

[Qemu-devel] [PATCH v2 1/2] block: add block_job_sleep_ns

2012-04-24 Thread Paolo Bonzini
This function abstracts the pretty complex semantics of the "busy" member of BlockJob. Signed-off-by: Paolo Bonzini --- block.c| 11 +++ block/stream.c | 22 -- block_int.h| 22 +++--- 3 files changed, 34 insertions(+), 21 deletions(-

[Qemu-devel] [PATCH v2 2/2] block: wait for job callback in block_job_cancel_sync

2012-04-24 Thread Paolo Bonzini
The limitation on not having I/O after cancellation cannot really be honored. Even streaming has a very small race window where you could cancel a job and have it report completion. If this window is hit, bdrv_change_backing_file() will yield and possibly cause accesses to dangling pointers etc.

[Qemu-devel] [PATCH v2 0/2] Updated fixes for block job cancellation

2012-04-24 Thread Paolo Bonzini
These patches fix the existing problems with synchronous job cancellation without adding a bdrv_drain_all in the asynchronous block_job_cancel. Paolo Bonzini (2): block: add block_job_sleep_ns block: wait for job callback in block_job_cancel_sync block.c| 47 +++

[Qemu-devel] Assertion after chaning display resolution

2012-04-24 Thread Peter Lieven
Hi all, I saw the following assert after chaning display resolution. This might be the cause, but i am not sure. Threaded VNC is enabled. Anyone ever seen this? qemu-kvm-1.0: malloc.c:3096: sYSMALLOc: Assertion `(old_top == (((mbinptr) (((char *) &((av)->bins[((1) - 1) * 2])) - __builtin_of

Re: [Qemu-devel] copy benchmarks onto qemu

2012-04-24 Thread Xin Tong
i got it working with libguestfs. libguestfs is awesome at manipulating guest VM images. Xin On Tue, Apr 24, 2012 at 4:45 AM, Mulyadi Santosa wrote: > On Tue, Apr 24, 2012 at 02:09, Xin Tong wrote: >> I am not too sure what you mean by raw image. what i have is an *.img >> file that is bootabl

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Alon Levy
On Tue, Apr 24, 2012 at 01:23:53PM +0200, Andreas Färber wrote: > Am 24.04.2012 12:26, schrieb Amit Shah: > > On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: > >> On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: > >>> From: Alon Levy > >>> > >>> guest_connected should be false

Re: [Qemu-devel] [PATCH] qxl: don't assert on guest create_guest_primary

2012-04-24 Thread Alon Levy
On Tue, Apr 24, 2012 at 12:17:15PM +0200, Gerd Hoffmann wrote: > On 04/18/12 13:00, Alon Levy wrote: > > initiate the implicit destroy ourselves. > > What is the use case? Don't let guest crash the machine with bad driver. i.e. during testing I did this inadvertently. > > Allowing guests to do

Re: [Qemu-devel] [PATCH] xen_disk: remove syncwrite option

2012-04-24 Thread Stefano Stabellini
On Tue, 24 Apr 2012, Kevin Wolf wrote: > > That's because it is based on top of the following two patches: > > > > xen_disk: use bdrv_aio_flush instead of bdrv_flush > > http://marc.info/?l=qemu-devel&m=133434258008959&w=2 > > > > xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRIT

[Qemu-devel] [PATCH] usb-uhci: update irq line on reset

2012-04-24 Thread Gerd Hoffmann
uhci_reset() clears irq mask and irq status registers, but doesn't update the irq line. Which may result in suspious IRQs after uhci reset. Fix it. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-uhci.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Pavel Hrdina
On 04/24/2012 12:23 PM, Kevin Wolf wrote: Am 24.04.2012 11:55, schrieb Pavel Hrdina: On 04/24/2012 11:32 AM, Kevin Wolf wrote: Am 23.04.2012 18:06, schrieb Pavel Hrdina: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation when no media is present. If the

Re: [Qemu-devel] [PATCH 2/4] block: use Error mechanism instead of -errno for block_job_set_speed()

2012-04-24 Thread Eric Blake
On 04/24/2012 03:01 AM, Paolo Bonzini wrote: > Il 24/04/2012 10:49, Stefan Hajnoczi ha scritto: >> "The error is specific to >> block job speeds so we can add a speed argument to block-stream in the >> future and clearly identify the invalid parameter." >> >> I added the new error to avoid having t

Re: [Qemu-devel] [PATCH] qcow2: Fix refcount block allocation during qcow2_allocate_cluster_at()

2012-04-24 Thread Kevin Wolf
Am 23.04.2012 20:30, schrieb Marcelo Tosatti: > On Mon, Apr 23, 2012 at 02:33:49PM +0200, Kevin Wolf wrote: >> Am 23.04.2012 01:35, schrieb Marcelo Tosatti: >>> On Sun, Apr 22, 2012 at 08:18:49PM -0300, Marcelo Tosatti wrote: On Fri, Apr 20, 2012 at 03:56:01PM +0200, Kevin Wolf wrote: > Re

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Kevin Wolf
Am 24.04.2012 12:28, schrieb Pavel Hrdina: > On 04/24/2012 12:23 PM, Kevin Wolf wrote: >> Am 24.04.2012 11:55, schrieb Pavel Hrdina: >>> On 04/24/2012 11:32 AM, Kevin Wolf wrote: Am 23.04.2012 18:06, schrieb Pavel Hrdina: > Hi, > this is the patch to fix incorrect handling of IDE flopp

Re: [Qemu-devel] [PATCH v3] spice_info: add mouse_mode

2012-04-24 Thread Gerd Hoffmann
On 03/29/12 23:23, Alon Levy wrote: > Add mouse_mode, either server or mouse, to qmp and hmp commands, based > on spice_server_is_server_mouse added in spice-server 0.10.3. Patch added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] xen_disk: remove syncwrite option

2012-04-24 Thread Kevin Wolf
Am 24.04.2012 13:22, schrieb Stefano Stabellini: > Use the BDRV_O_CACHE_* flags instead. > > Signed-off-by: Stefano Stabellini Doesn't apply to qemu.git because... > --- > hw/xen_disk.c |8 +--- > 1 files changed, 1 insertions(+), 7 deletions(-) > > diff --git a/hw/xen_disk.c b/hw/xen

Re: [Qemu-devel] [PATCH] xen_disk: remove syncwrite option

2012-04-24 Thread Stefano Stabellini
On Tue, 24 Apr 2012, Kevin Wolf wrote: > Am 24.04.2012 13:22, schrieb Stefano Stabellini: > > Use the BDRV_O_CACHE_* flags instead. > > > > Signed-off-by: Stefano Stabellini > > Doesn't apply to qemu.git because... > > > --- > > hw/xen_disk.c |8 +--- > > 1 files changed, 1 insertions(

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Amit Shah
On (Tue) 24 Apr 2012 [14:21:36], Michael S. Tsirkin wrote: > On Tue, Apr 24, 2012 at 04:44:10PM +0530, Amit Shah wrote: > > On (Tue) 24 Apr 2012 [13:49:53], Michael S. Tsirkin wrote: > > > On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote: > > > > On (Tue) 24 Apr 2012 [13:17:16], Michael S.

Re: [Qemu-devel] [PATCH v2 01/15] target-i386: Fix x86_cpuid_set_model_id()

2012-04-24 Thread Andreas Färber
Am 24.04.2012 13:32, schrieb Igor Mammedov: > On 04/24/2012 11:33 AM, Andreas Färber wrote: >> Don't assume zeroed cpuid_model[] fields. >> >> This doesn't break anything yet but QOM properties should be able to set Should've read "didn't". I sure hope it doesn't. :) >> the value to something els

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 10:46 AM, Pavel Hrdina wrote: > > On 04/24/2012 11:06 AM, Stefan Hajnoczi wrote: > > On Mon, Apr 23, 2012 at 5:06 PM, Pavel Hrdina wrote: > > Hi, > this is the patch to fix incorrect handling of IDE floppy drive controller > emulation > > s/IDE// > > It's unrelated to IDE.

Re: [Qemu-devel] [PATCH v2 01/15] target-i386: Fix x86_cpuid_set_model_id()

2012-04-24 Thread Igor Mammedov
On 04/24/2012 11:33 AM, Andreas Färber wrote: Don't assume zeroed cpuid_model[] fields. This doesn't break anything yet but QOM properties should be able to set the value to something else without setting an intermediate zero string. Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Andreas Färber
Am 24.04.2012 12:26, schrieb Amit Shah: > On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: >> On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: >>> From: Alon Levy >>> >>> guest_connected should be false before guest driver initialization, and >>> true after, both for multiport

[Qemu-devel] [PULL] xen patches

2012-04-24 Thread Stefano Stabellini
Hi Anthony, please pull: git://xenbits.xen.org/people/sstabellini/qemu-dm.git for_anthony it contains a couple of xen_disk improvements and Xen HVM reboot support. John V. Baboval (1): xen: Support guest reboots Stefano Stabellini (2): xen_disk: use bdrv_aio_flush instead of bdrv_fl

[Qemu-devel] [PATCH] xen_disk: remove syncwrite option

2012-04-24 Thread Stefano Stabellini
Use the BDRV_O_CACHE_* flags instead. Signed-off-by: Stefano Stabellini --- hw/xen_disk.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/hw/xen_disk.c b/hw/xen_disk.c index 4a6d89c..3e4a47b 100644 --- a/hw/xen_disk.c +++ b/hw/xen_disk.c @@ -48,7 +48,6 @@ /* --

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 04:44:10PM +0530, Amit Shah wrote: > On (Tue) 24 Apr 2012 [13:49:53], Michael S. Tsirkin wrote: > > On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote: > > > On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: > > > > On Tue, Apr 24, 2012 at 02:55:26PM +0530, A

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Amit Shah
On (Tue) 24 Apr 2012 [13:49:53], Michael S. Tsirkin wrote: > On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote: > > On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: > > > On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: > > > > From: Alon Levy > > > > > > > > guest_con

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Pavel Hrdina
On 04/24/2012 09:48 AM, Andreas Färber wrote: Am 23.04.2012 18:06, schrieb Pavel Hrdina: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation when no media is present. If the guest is booted without a media then the drive was not being emulated at all but thi

Re: [Qemu-devel] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-24 Thread Avi Kivity
On 04/24/2012 10:21 AM, Gleb Natapov wrote: > > > > I was thinking about not having tons of 128MB slots, so we don't have a > > configuration that is far from reality. But maybe this thinking is too > > conservative. > > > I think it is good interface to make memory that is specified with -m to

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote: > On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: > > On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: > > > From: Alon Levy > > > > > > guest_connected should be false before guest driver initialization, and > > > tr

[Qemu-devel] [PATCH v2 13/15] target-i386: Introduce "xlevel" property for X86CPU

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --- target-i386/cpu.c | 38 +- 1 files changed, 37 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f2df8d0..89a1855 100644 --- a/target-i386/cpu.c +++ b/target

[Qemu-devel] [PATCH v2 08/15] target-i386: Add property getter for CPU family

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --- target-i386/cpu.c | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 1b8053a..9479717 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -599,6

[Qemu-devel] [PATCH v2 01/15] target-i386: Fix x86_cpuid_set_model_id()

2012-04-24 Thread Andreas Färber
Don't assume zeroed cpuid_model[] fields. This doesn't break anything yet but QOM properties should be able to set the value to something else without setting an intermediate zero string. Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --- target-i386/cpu.c |3 +++ 1 files chang

Re: [Qemu-devel] [PATCH v2 00/15] QOM'ify x86 CPU, part 2: properties

2012-04-24 Thread Andreas Färber
Am 24.04.2012 11:33, schrieb Andreas Färber: > Hello, > > This series introduces some QOM properties for X86CPU, so that our built-in > init code exercises the same code paths as QMP, as suggested by Eduardo: > * "family", > * "model", > * "stepping" and > * "model-id" (rather than "model_id") > T

[Qemu-devel] [PATCH v2 11/15] target-i386: Add property getter for CPU model-id

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost --- target-i386/cpu.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f1d3827..490db76 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -711,6

<    1   2   3   >