Re: [Qemu-devel] Semantics of DeviceState::realized and BlockDriverState

2012-06-12 Thread Paolo Bonzini
Il 12/06/2012 00:05, Anthony Liguori ha scritto: opened = true attached = true This means that the device is in-use by something in QEMU. Requests may be in flight as read/write requests are now allowed to be issued. Most properties cannot be changed in this state (presumably). So

Re: [Qemu-devel] [PATCH v4 4/7] trace: [monitor] Use new event control interface

2012-06-12 Thread Stefan Hajnoczi
On Mon, Jun 11, 2012 at 6:20 PM, Lluís Vilanova vilan...@ac.upc.edu wrote: Lluís Vilanova writes: Stefan Hajnoczi writes: On Tue, May 8, 2012 at 3:38 PM, Lluís Vilanova vilan...@ac.upc.edu wrote: Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu ---  monitor.c |   15 ---  1

Re: [Qemu-devel] [PATCH] kvm: notify host when guest panicked

2012-06-12 Thread Wen Congyang
Hi, Avi Do you have any comment to this patch? Thanks Wen Congyang At 05/21/2012 02:46 PM, Wen Congyang Wrote: We can know the guest is panicked when the guest runs on xen. But we do not have such feature on kvm. Another purpose of this feature is: management app(for example: libvirt) can

Re: [Qemu-devel] USB hardware simulation in external process

2012-06-12 Thread Gerd Hoffmann
On 06/11/12 16:48, Daniel Mack wrote: Hey, I'm thinking about adding a USB hardware proxy that allows communication with an external server process which in turn simulates USB devices. It's already there. Have a look at usbredir. http://hansdegoede.livejournal.com/11006.html usbredir a

Re: [Qemu-devel] [PATCH 3/3] deal with guest panicked event

2012-06-12 Thread Wen Congyang
At 05/31/2012 03:23 AM, Luiz Capitulino Wrote: On Mon, 21 May 2012 14:50:51 +0800 Wen Congyang we...@cn.fujitsu.com wrote: When the guest is panicked, it will write 0x1 to the port 0x505. So if qemu reads 0x1 from this port, we can do the folloing three things according to the parameter

Re: [Qemu-devel] [PATCH, v3] qemu/xendisk: set maximum number of grants to be used

2012-06-12 Thread Jan Beulich
On 31.05.12 at 13:27, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Thu, 31 May 2012, Jan Beulich wrote: Legacy (non-pvops) gntdev drivers may require this to be done when the number of grants intended to be used simultaneously exceeds a certain driver specific default limit.

Re: [Qemu-devel] [PATCH] w32: Fix broken build (missing include file)

2012-06-12 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 11/06/2012 03:57, Wen Congyang ha scritto: dump.* use GPL2 instead of GPL2+. Please fix that! Wen, do you have permissions to release your new files under GPLv2 or later? Don't we require GPLv2+ for all contributions now? If not, we should.

Re: [Qemu-devel] [PATCH 1/3] start vm after reseting it

2012-06-12 Thread Wen Congyang
At 05/31/2012 03:17 AM, Luiz Capitulino Wrote: On Mon, 21 May 2012 14:49:32 +0800 Wen Congyang we...@cn.fujitsu.com wrote: The guest should run after reseting it, but it does not run if its old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED. Signed-off-by: Wen Congyang

Re: [Qemu-devel] CoW image commit+shrink(= make_empty) support

2012-06-12 Thread Zhi Hui Li
On 2012年06月12日 03:12, Paolo Bonzini wrote: Il 11/06/2012 17:37, Jeff Cody ha scritto: It sounds like Zhi Hui is working on live block commit patches, and Supriya is working on the bdrv_reopen() portion - I don't want to duplicate any effort, but if there is anything I can do to help with either

Re: [Qemu-devel] [PATCH] kvm: notify host when guest panicked

2012-06-12 Thread Christian Borntraeger
We have three solutions to implement this feature: 1. use vmcall 2. use I/O port 3. use virtio-serial. We have decided to avoid touching hypervisor. The reason why I choose choose the I/O port is: 1. it is easier to implememt 2. it does not depend any virtual device 3. it can work when

[Qemu-devel] [PATCH 04/10] hw/qxl: ignore guest from guestbug until reset

2012-06-12 Thread Gerd Hoffmann
From: Alon Levy al...@redhat.com soft_reset is called from any of: * QXL_IO_RESET * vga io * pci reset handler Signed-off-by: Alon Levy al...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl.c | 13 - hw/qxl.h |3 +++ 2 files changed, 15 insertions(+), 1

[Qemu-devel] [PATCH 02/10] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/

2012-06-12 Thread Gerd Hoffmann
From: Alon Levy al...@redhat.com Signed-off-by: Alon Levy al...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl.c | 49 +++-- hw/qxl.h |3 ++- 2 files changed, 29 insertions(+), 23 deletions(-) diff --git a/hw/qxl.c

[Qemu-devel] [PATCH 10/10] vga: raise default vgamem size

2012-06-12 Thread Gerd Hoffmann
Old size: 8 MB (traditional upstream qemu value). New size: 16 MB (traditional qemu-kvm value). Also adds compat properties so old machine types keep the old default values. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/pc_piix.c| 24 hw/qxl.c|

[Qemu-devel] [PATCH 5/5] usb-host: live migration support

2012-06-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/host-linux.c | 47 ++- 1 files changed, 46 insertions(+), 1 deletions(-) diff --git a/hw/usb/host-linux.c b/hw/usb/host-linux.c index 06b6ed3..5479fb5 100644 --- a/hw/usb/host-linux.c +++

[Qemu-devel] [PATCH 4/5] usb-host: attach only to running guest

2012-06-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/host-linux.c | 32 +--- 1 files changed, 17 insertions(+), 15 deletions(-) diff --git a/hw/usb/host-linux.c b/hw/usb/host-linux.c index a95b0ed..06b6ed3 100644 --- a/hw/usb/host-linux.c +++

[Qemu-devel] [PATCH 1/5] ehci: add live migration support

2012-06-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-ehci.c | 62 +++- 1 files changed, 56 insertions(+), 6 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 5298204..45b774d 100644 --- a/hw/usb/hcd-ehci.c +++

[Qemu-devel] [PATCH 2/5] usb: restore USBDevice-attached on vmload

2012-06-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/bus.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/hw/usb/bus.c b/hw/usb/bus.c index 2068640..77b2b99 100644 --- a/hw/usb/bus.c +++ b/hw/usb/bus.c @@ -27,10 +27,23 @@ static struct BusInfo

Re: [Qemu-devel] USB hardware simulation in external process

2012-06-12 Thread Dor Laor
On 06/11/2012 05:48 PM, Daniel Mack wrote: Hey, I'm thinking about adding a USB hardware proxy that allows communication with an external server process which in turn simulates USB devices. I'm new to the internals of QEMU, so what I'm sharing here might already have been discussed a gazillion

Re: [Qemu-devel] [RFC] QOMification of AXI stream

2012-06-12 Thread Edgar E. Iglesias
On Tue, Jun 12, 2012 at 10:33:51AM +1000, Peter Crosthwaite wrote: Hi, IIRC the word array thing is device specific, not really AXI stream. I think the whole connection to AXI is a bit unfortunate, Yes, so I think we can summaries the confusion here with AXI stream is completely

Re: [Qemu-devel] Semantics of DeviceState::realized and BlockDriverState

2012-06-12 Thread Kevin Wolf
Am 12.06.2012 00:05, schrieb Anthony Liguori: To me, realized represents Vcc. When realized=true, the guest has power and is active. When realized=false, the guest has lost power. The realize() event is the rising edge of Vcc, unrealized() is the falling edge. realize() should be

Re: [Qemu-devel] [PATCH] kvm: notify host when guest panicked

2012-06-12 Thread Wen Congyang
At 06/12/2012 03:49 PM, Christian Borntraeger Wrote: We have three solutions to implement this feature: 1. use vmcall 2. use I/O port 3. use virtio-serial. We have decided to avoid touching hypervisor. The reason why I choose choose the I/O port is: 1. it is easier to implememt 2. it does

Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

2012-06-12 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 06/07/2012 06:05 PM, Markus Armbruster wrote: [cc: Dan to give him a chance to correct whatever underinformed nonsense I might spout on libvirt] Don't see Dan on CC so I'll add him... Anthony Liguorialigu...@us.ibm.com writes: I think we

Re: [Qemu-devel] Semantics of DeviceState::realized and BlockDriverState

2012-06-12 Thread Kevin Wolf
Am 12.06.2012 08:10, schrieb Paolo Bonzini: Il 12/06/2012 00:05, Anthony Liguori ha scritto: opened = true attached = true This means that the device is in-use by something in QEMU. Requests may be in flight as read/write requests are now allowed to be issued. Most properties cannot be

[Qemu-devel] [PATCH 3/5] ehci: tracing improvements

2012-06-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-ehci.c |7 +-- trace-events |5 +++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 45b774d..6d2d549 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c

Re: [Qemu-devel] [Bug 1011142] [NEW] Arm emulation do a crash

2012-06-12 Thread Andreas Färber
嗨, Am 12.06.2012 06:58, schrieb 陳韋任 (Wei-Ren Chen): I don't know why, with kvm it say: KVM not supported for this target No accelerator found! Unless you're running on ARM with a patched kernel you can't get KVM for ARM guests. That's no error. Linux/ARM starts to support kvm? Note

[Qemu-devel] [PATCH 00/10] spice/vga: make vga memory size configurable.

2012-06-12 Thread Gerd Hoffmann
Hi, This is the spice patch queue, including a bunch of vga bits this time. The patch series makes the vga memory size configurable using a property for standard vga, vmware vga and qxl. It also raises the default memory size to 16 MB (qemu-kvm has this for years) and adds a compat property

[Qemu-devel] [PATCH 06/10] vga: raise xres+yres limits

2012-06-12 Thread Gerd Hoffmann
The vgabios will check whenever any given video mode will fit into the given video memory before adding it to the list of available modes, so there is no need to keep xmax * ymax * 32bpp lower than VGA_RAM_SIZE. Lets raise the limits a bit. Should be good for a few years, display sizes are not

Re: [Qemu-devel] [PATCH] kvm: notify host when guest panicked

2012-06-12 Thread Wen Congyang
At 06/12/2012 03:49 PM, Christian Borntraeger Wrote: We have three solutions to implement this feature: 1. use vmcall 2. use I/O port 3. use virtio-serial. We have decided to avoid touching hypervisor. The reason why I choose choose the I/O port is: 1. it is easier to implememt 2. it does

Re: [Qemu-devel] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-06-12 Thread Andreas Färber
Am 29.05.2012 15:35, schrieb Stefano Stabellini: qemu_rearm_alarm_timer partially duplicates the code in qemu_next_alarm_deadline to figure out if it needs to rearm the timer. If it calls qemu_next_alarm_deadline, it always rearms the timer even if the next deadline is INT64_MAX. This patch

Re: [Qemu-devel] [PATCH] Fix for qemu crash on assertion error when adding PCI passthru device.

2012-06-12 Thread Michael S. Tsirkin
On Tue, Jun 12, 2012 at 04:31:20AM +, Ma, Stephen B. wrote: diff --git a/hw/qdev.c b/hw/qdev.c index 6a8f6bd..d2dc28b 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -139,7 +139,7 @@ DeviceState *qdev_try_create(BusState *bus, const char *type) /* Initialize a device. Device properties

[Qemu-devel] [PATCH 09/10] add pc-1.2

2012-06-12 Thread Gerd Hoffmann
--- hw/pc_piix.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index f49b0aa..4f35bf8 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -347,8 +347,8 @@ static void pc_xen_hvm_init(ram_addr_t ram_size, } #endif -static

[Qemu-devel] [PATCH 01/10] ui/spice-display.c: add missing initialization for valgrind

2012-06-12 Thread Gerd Hoffmann
From: Alon Levy al...@redhat.com We can't initialize QXLDevSurfaceCreate field by field because it has a pa hole, and so 4 bytes remain uninitialized when building on x86-64, so just memset. Signed-off-by: Alon Levy al...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

[Qemu-devel] one question on the makefile

2012-06-12 Thread Wei Yang
All, I saw a makefile rule which confused. This is in the tests/Makefile .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: $(check-qtest-y) $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \

[Qemu-devel] [PATCH 03/10] qxl: stop dirty loging when not in vga mode

2012-06-12 Thread Gerd Hoffmann
From: Alon Levy al...@redhat.com Tested with linux guest. Not sure how to check actual performance affect of this. Checked with the previously send traceevent that the kvm ioctl to start/stop dirty logging is being called. (KVM_SET_USER_MEMORY_REGION). Signed-off-by: Alon Levy al...@redhat.com

Re: [Qemu-devel] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-06-12 Thread Andreas Färber
Am 12.06.2012 10:24, schrieb Andreas Färber: Am 29.05.2012 15:35, schrieb Stefano Stabellini: The check-qtest-i386 qemu-system-i386 process now hangs at ~98% CPU, just as with my INT64_MAX hack before. How would I best debug this qtest scenario, and what should I be looking for? Since my 1.1

[Qemu-devel] [PATCH 07/10] vga: make vram size configurable

2012-06-12 Thread Gerd Hoffmann
Zap the global VGA_RAM_SIZE #define, make the vga ram size configurable for standard vga and vmware vga. cirrus and qxl are left with a fixed size (and private VGA_RAM_SIZE #define) for now. qxl needs some non-trivial adjustments in the mode list handling deal with a runtime-configurable size,

[Qemu-devel] [PATCH 08/10] qxl: add vgamem_size_mb and vgamem_size

2012-06-12 Thread Gerd Hoffmann
From: Alon Levy al...@redhat.com In preperation for supporting a larger framebuffer for multiple monitors on a single card, add a property to qxl vgamem_size_mb, and corresponding byte sized vgamem_size, and use instead of VGA_RAM_SIZE. [ kraxel: simplify property handling, add sanity checks ] [

[Qemu-devel] [PATCH 05/10] qxl: reset current_async on qxl_soft_reset

2012-06-12 Thread Gerd Hoffmann
From: Alon Levy al...@redhat.com Signed-off-by: Alon Levy al...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index b5e53ce..4be9462 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@

Re: [Qemu-devel] one question on the makefile

2012-06-12 Thread Paolo Bonzini
Il 12/06/2012 10:33, Wei Yang ha scritto: .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: $(check-qtest-y) $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ gtester $(GTESTER_OPTIONS)

[Qemu-devel] [PATCH 0/5] usb: live migration bits

2012-06-12 Thread Gerd Hoffmann
Hi, This patch series adds live migration support to ehci and usb-host. Also has some little fixes improvements. please review, Gerd Gerd Hoffmann (5): ehci: add live migration support usb: restore USBDevice-attached on vmload ehci: tracing improvements usb-host: attach only to

[Qemu-devel] [Bug 1002121] Re: disk error when guest boot up via qcow2 image

2012-06-12 Thread Yongjie Ren
reply to Jan Kiszka: I looked at the patch in uq/master branch in qemu-kvm.git as you mentioned. There's another issue in uq/master branch, so I can't conclude whether your patch will make a difference. The issue is Windows(e.g. win7) will get a BSOD with a message STOP: ox005D. RAW

[Qemu-devel] [Bug 1002121] Re: disk error when guest boot up via qcow2 image

2012-06-12 Thread Yongjie Ren
reply to Michael Tokarev: Windows qcow2 image will be more easier for reproducing the issue I reported. And there's a great chance to reproduce it when you do the first try after rebooting the system. -- You received this bug notification because you are a member of qemu- devel-ml, which

Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private

2012-06-12 Thread Alexander Graf
Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com By default qemu will use MAP_PRIVATE for guest pages. This will write protect pages and thus break on s390 systems that dont support this feature. Therefore qemu has a hack to always use MAP_SHARED for s390. But

Re: [Qemu-devel] [RFC] QOMification of AXI stream

2012-06-12 Thread Avi Kivity
On 06/11/2012 09:35 PM, Anthony Liguori wrote: The other direction is currently cpu_physical_memory_rw(). Right, and with benh's proposal, it's dma_memory_rw(). It also adds a DMAContext parameter. I can't help think that the contents of DMAContext is awfully similar to MemoryRegionOps.

Re: [Qemu-devel] [PATCH 4/8] s390: stop target cpu on sigp initial reset

2012-06-12 Thread Alexander Graf
Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com We must not run the target cpu after an initial reset. This makes system_reset more reliable for smp guests. Why? Alex Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- target-s390x/kvm.c |1 +

Re: [Qemu-devel] [PATCH 08/10] qxl: add vgamem_size_mb and vgamem_size

2012-06-12 Thread Daniel P. Berrange
On Tue, Jun 12, 2012 at 09:51:12AM +0200, Gerd Hoffmann wrote: From: Alon Levy al...@redhat.com In preperation for supporting a larger framebuffer for multiple monitors on a single card, add a property to qxl vgamem_size_mb, and corresponding byte sized vgamem_size, and use instead of

Re: [Qemu-devel] [RFC] QOMification of AXI stream

2012-06-12 Thread Edgar E. Iglesias
On Tue, Jun 12, 2012 at 12:31:58PM +0300, Avi Kivity wrote: On 06/11/2012 09:35 PM, Anthony Liguori wrote: The other direction is currently cpu_physical_memory_rw(). Right, and with benh's proposal, it's dma_memory_rw(). It also adds a DMAContext parameter. I can't help think

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Install 'bepo' keymap already included in Qemu source

2012-06-12 Thread Stefan Hajnoczi
On Fri, Jun 08, 2012 at 08:06:25PM +0200, fboit...@free.fr wrote: From: Frédéric Boiteux fboit...@free.fr The 'bepo' layout (a french dvorak-like keyboard layout) was added about one year ago, (see commit 2a3c633c1eb8692716220195b6d3fe78b7e411d0), but I missed to declare to install it.

Re: [Qemu-devel] [PATCH 1/2] Makefile: Remove BUILD_DIR from qapi-dir

2012-06-12 Thread Stefan Hajnoczi
On Sat, Jun 09, 2012 at 09:08:38AM +0200, Stefan Weil wrote: qapi-dir does not need an absolute path. All other build directories are relative. When BUILD_DIR is removed, the build output looks better (no long lines with absolute paths when everything else uses short lines): GEN

[Qemu-devel] [PATCH v5 0/7] trace: Generic event state description

2012-06-12 Thread Lluís Vilanova
NOTE: Not sure if compilation of files in trace/ should be moved from Makefile.objs to trace/Makefile.objs Provides a generic event state description structure (TraceEvent) and a more detailed event control and query interface. This is achieved by creating a new non-public tracing backend

[Qemu-devel] [PATCH v5 2/7] trace: Provide a generic tracing event descriptor

2012-06-12 Thread Lluís Vilanova
Uses tracetool to generate a backend-independent tracing event description (struct TraceEvent). The values for such structure are generated with the non-public events backend (events-c frontend). The generation of the defines to check if an event is statically enabled is also moved to the events

[Qemu-devel] [PATCH v5 3/7] trace: Provide a detailed event control interface

2012-06-12 Thread Lluís Vilanova
This interface decouples event obtention from interaction. Events can be obtained through three different methods: * identifier * name * simple wildcard pattern Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- docs/tracing.txt | 42 -- trace/control-internal.h | 67

Re: [Qemu-devel] [PATCH] kvm: notify host when guest panicked

2012-06-12 Thread Gleb Natapov
On Tue, Jun 12, 2012 at 04:26:35PM +0800, Wen Congyang wrote: At 06/12/2012 03:49 PM, Christian Borntraeger Wrote: We have three solutions to implement this feature: 1. use vmcall 2. use I/O port 3. use virtio-serial. We have decided to avoid touching hypervisor. The reason why I

Re: [Qemu-devel] [PATCH 1/2] Makefile: Remove BUILD_DIR from qapi-dir

2012-06-12 Thread Stefan Hajnoczi
On Sat, Jun 09, 2012 at 09:08:38AM +0200, Stefan Weil wrote: qapi-dir does not need an absolute path. All other build directories are relative. When BUILD_DIR is removed, the build output looks better (no long lines with absolute paths when everything else uses short lines): GEN

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile.user: Define CONFIG_USER_ONLY for libuser/

2012-06-12 Thread Stefan Hajnoczi
On Sat, Jun 09, 2012 at 01:56:42PM +0200, Andreas Färber wrote: In *-*-user/ build dirs CONFIG_USER_ONLY is defined via config-target.h. In libuser/ it is not defined. Add it via QEMU_CFLAGS. Signed-off-by: Andreas Färber afaer...@suse.de --- Soon needed for cpu.c. Makefile.user |

Re: [Qemu-devel] [RFC] QOMification of AXI stream

2012-06-12 Thread Avi Kivity
On 06/11/2012 09:36 PM, Anthony Liguori wrote: cpu_physical_memory_rw() would be implemented as memory_region_rw(system_memory, ...) while pci_dma_rw() would be implemented as memory_region_rw(pcibm, ...). This would allow different address transformations for the two accesses. BTW, the

Re: [Qemu-devel] [PATCH for-1.1] libqtest: Fix socket_accept() to pass address_len

2012-06-12 Thread Stefan Hajnoczi
On Mon, May 28, 2012 at 12:53:20AM +0200, Andreas Färber wrote: accept() expects address_len to point to the length of the sockaddr on input. Initialize it accordingly. Resolves an assertion due to EFAULT on illumos. Signed-off-by: Andreas Färber andreas.faer...@web.de ---

Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

2012-06-12 Thread Alexander Graf
Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com The sclp facility on s390 is a hardware that is external to the cpu. Lets cleanup the definitions and move the functionality into a separate file under hw/. Phew. I'm not sure this is a great idea. At least not the

[Qemu-devel] [PATCH v5 4/7] trace: [monitor] Use new event control interface

2012-06-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- monitor.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index a3bc2c7..83ce956 100644 --- a/monitor.c +++ b/monitor.c @@ -589,10 +589,19 @@ static void

Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

2012-06-12 Thread Christian Borntraeger
On 12/06/12 11:58, Alexander Graf wrote: Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com The sclp facility on s390 is a hardware that is external to the cpu. Lets cleanup the definitions and move the functionality into a separate file under hw/. Phew. I'm not

[Qemu-devel] [PATCH v5 5/7] trace: [default] Port to generic event information and new control interface

2012-06-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- trace/default.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/trace/default.c b/trace/default.c index c9b27a2..6e07a47 100644 --- a/trace/default.c +++ b/trace/default.c @@ -1,7 +1,7 @@ /* * Default

Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

2012-06-12 Thread Alexander Graf
On 12.06.2012, at 12:07, Christian Borntraeger borntrae...@de.ibm.com wrote: On 12/06/12 11:58, Alexander Graf wrote: Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com The sclp facility on s390 is a hardware that is external to the cpu. Lets cleanup the definitions

Re: [Qemu-devel] [RFC] QOMification of AXI streams

2012-06-12 Thread Avi Kivity
On 06/12/2012 01:29 AM, Anthony Liguori wrote: So it makes some amount of sense to use the same structure. For example, if a device issues accesses, those could be caught by a sibling device memory region... or go upstream. Let's just look at downstream transformation for a minute... We do

Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

2012-06-12 Thread Alexander Graf
On 12.06.2012, at 12:07, Christian Borntraeger borntrae...@de.ibm.com wrote: On 12/06/12 11:58, Alexander Graf wrote: Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com The sclp facility on s390 is a hardware that is external to the cpu. Lets cleanup the definitions

[Qemu-devel] [PATCH v5 1/7] tracetool: Explicitly identify public backends

2012-06-12 Thread Lluís Vilanova
Public backends are those printed by --list-backends and thus considered valid by the configure script. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- scripts/tracetool.py |4 ++-- scripts/tracetool/backend/__init__.py | 16 +++-

Re: [Qemu-devel] [PATCH 4/8] s390: stop target cpu on sigp initial reset

2012-06-12 Thread Christian Borntraeger
On 12/06/12 11:42, Alexander Graf wrote: Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com We must not run the target cpu after an initial reset. This makes system_reset more reliable for smp guests. Why? After an initial reset, the cpu is in a state (PSW=0) that

[Qemu-devel] [PATCH v5 7/7] trace: [stderr] Port to generic event information and new control interface

2012-06-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- scripts/tracetool/backend/stderr.py | 27 --- trace/stderr.c | 34 ++ 2 files changed, 14 insertions(+), 47 deletions(-) diff --git

[Qemu-devel] [PATCH v5 6/7] trace: [simple] Port to generic event information and new control interface

2012-06-12 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- scripts/tracetool/backend/simple.py | 12 +--- trace/simple.c | 36 --- trace/simple.h |6 +- trace/stderr.h | 11 ---

Re: [Qemu-devel] [PULL] qemu/xendisk fix

2012-06-12 Thread Stefano Stabellini
On Mon, 11 Jun 2012, Anthony Liguori wrote: On 06/11/2012 05:14 AM, Stefano Stabellini wrote: Hi Anthony, please pull one fix for xen_disk from here: git://xenbits.xen.org/people/sstabellini/qemu-dm.git for_1.1.1 The fix should be applied to the 1.1.x stable tree too. Pulled.

[Qemu-devel] [PATCH 0/2] qemu-ga: Add guest-fstrim command.

2012-06-12 Thread Paolo Bonzini
FITRIM is a mounted filesystem feature to discard (or trim) blocks which are not in use by the filesystem. This is useful for solid-state drives (SSDs) and thinly-provisioned storage. Provide access to the feature from the host so that filesystems can be trimmed periodically or before migration.

[Qemu-devel] [PATCH 1/2] qemu-ga: make names more generic for mount list functions

2012-06-12 Thread Paolo Bonzini
We will use these functions and types for more than FSFREEZE, so rename them. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qga/commands-posix.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/qga/commands-posix.c

[Qemu-devel] [PATCH 2/2] qemu-ga: add guest-fstrim command

2012-06-12 Thread Paolo Bonzini
FITRIM is a mounted filesystem feature to discard (or trim) blocks which are not in use by the filesystem. This is useful for solid-state drives (SSDs) and thinly-provisioned storage. Provide access to the feature from the host so that filesystems can be trimmed periodically or before migration.

Re: [Qemu-devel] CoW image commit+shrink(= make_empty) support

2012-06-12 Thread Stefan Hajnoczi
On Mon, Jun 11, 2012 at 4:37 PM, Jeff Cody jc...@redhat.com wrote: On 06/11/2012 10:24 AM, Stefan Hajnoczi wrote: On Mon, Jun 11, 2012 at 1:50 PM, Kevin Wolf kw...@redhat.com wrote: Am 11.06.2012 14:09, schrieb Stefan Hajnoczi: On Fri, Jun 8, 2012 at 6:46 PM, Jeff Cody jc...@redhat.com wrote:

[Qemu-devel] [PATCH v3 0/4] fdc: fix/rewrite seek, media_changed and interrupt handling

2012-06-12 Thread Pavel Hrdina
The fd_seek will return 'track is invalid' if there is no media in drive. Implied seek should have the same behavior as normal seek. We will use the fd_seek function instead of a direct modification of head, track and sector values. The result value is used only while read/write commands were

[Qemu-devel] [PATCH v3 3/4] fdc: rewrite seek and DSKCHG bit handling

2012-06-12 Thread Pavel Hrdina
This bit is cleared on every successful seek to a different track (cylinder). The seek is also called on revalidate or on read/write/format commands which also clear the DSKCHG bit. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- hw/fdc.c | 66

[Qemu-devel] [PATCH v3 4/4] fdc: fix interrupt handling

2012-06-12 Thread Pavel Hrdina
If you call the SENSE INTERRUPT STATUS commad while there is no interrupt waiting you get as reasult unknown command. Fixed status0 register handling for read/write/format commands. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- hw/fdc.c | 30 -- 1 files

Re: [Qemu-devel] [PATCH v2 2/3] Simpletrace v2: Add support for multiple args, strings.

2012-06-12 Thread Harsh Bora
On 06/11/2012 08:25 PM, Stefan Hajnoczi wrote: On Mon, Jun 11, 2012 at 1:31 PM, Harsh Boraha...@linux.vnet.ibm.com wrote: On 06/07/2012 08:02 PM, Stefan Hajnoczi wrote: On Thu, May 24, 2012 at 10:50 AM, Harsh Prateek Bora ha...@linux.vnet.ibm.comwrote: @@ -75,16 +96,22 @@ static char

[Qemu-devel] [PATCH v3 2/3] Simpletrace v2: Support multiple arguments, strings.

2012-06-12 Thread Harsh Prateek Bora
Existing simpletrace backend allows to trace at max 6 args and does not support strings. This newer tracelog format gets rid of fixed size records and therefore allows to trace variable number of args including strings. Sample trace with strings: v9fs_version 0.000 tag=0x id=0x64 msize=0x2000

[Qemu-devel] [PATCH v3 1/4] fdc: fix implied seek while there is no medina in drive

2012-06-12 Thread Pavel Hrdina
The Windows uses 'READ' command at the start of an instalation without checking the 'dir' register. We have to abort the transfer with an abnormal termination if there is no media in the drive. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- hw/fdc.c |3 +++ 1 files changed, 3

Re: [Qemu-devel] [PATCH 6/8] s390: sclp event facility and signal quiesce support via system_powerdown

2012-06-12 Thread Alexander Graf
On 06/06/2012 02:05 PM, Jens Freimann wrote: From: Heinz Graalfsgraa...@linux.vnet.ibm.com This patch implements a subset of the sclp event facility as well as the signal quiesce event. This allows to gracefully shutdown a guest by using system_powerdown. This sends a signal quiesce signal that

Re: [Qemu-devel] [PATCH 7/8] s390: Add SCLP vt220 console support

2012-06-12 Thread Alexander Graf
On 06/06/2012 02:05 PM, Jens Freimann wrote: From: Heinz Graalfsgraa...@linux.vnet.ibm.com Adds console support (in vt220 mode). In order to run qemu exploiting the SCLP's console functionality in vt220 mode the user has to specify the following console related parameters: -chardev

Re: [Qemu-devel] [PATCH 8/8] s390: Fix the storage increment size calculation

2012-06-12 Thread Alexander Graf
On 06/06/2012 02:05 PM, Jens Freimann wrote: From: Nick Wangjfw...@us.ibm.com To comply with the SCLP architecture, the number of storage increments should be 512 or fewer. The increment size is a multiple of 1M and is a power of 2. Signed-off-by: Nick Wangjfw...@us.ibm.com Signed-off-by: Jens

Re: [Qemu-devel] [PATCH] configure: Fix build for some versions of glibc (9pfs)

2012-06-12 Thread Stefano Stabellini
On Fri, 8 Jun 2012, Stefano Stabellini wrote: On Thu, 7 Jun 2012, Stefan Weil wrote: Some versions declare open_by_handle_at, but don't define AT_EMPTY_PATH. Extend the check in configure to test both preconditions. Signed-off-by: Stefan Weil s...@weilnetz.de I have just noticed that

Re: [Qemu-devel] [PATCH 08/10] qxl: add vgamem_size_mb and vgamem_size

2012-06-12 Thread Gerd Hoffmann
On 06/12/12 11:37, Daniel P. Berrange wrote: On Tue, Jun 12, 2012 at 09:51:12AM +0200, Gerd Hoffmann wrote: From: Alon Levy al...@redhat.com In preperation for supporting a larger framebuffer for multiple monitors on a single card, add a property to qxl vgamem_size_mb, and corresponding byte

Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private

2012-06-12 Thread Christian Borntraeger
Is there any way we can move the above code to target-s390x? Having the branch below is already invasive enough for generic code, but we really don't need all the special s390 quirks to live here. Hmm, we have to have a special hook somehow. What about this approach? ---

[Qemu-devel] [PATCH v3 1/3] monitor: remove unused do_info_trace

2012-06-12 Thread Harsh Prateek Bora
Going forward with simpletrace v2 variable size trace records, we cannot have a generic function to print trace event info and therefore this interface becomes invalid. As per Stefan Hajnoczi: This command is only available from the human monitor. It's not very useful because it historically

Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private

2012-06-12 Thread Alexander Graf
On 06/12/2012 01:20 PM, Christian Borntraeger wrote: Is there any way we can move the above code to target-s390x? Having the branch below is already invasive enough for generic code, but we really don't need all the special s390 quirks to live here. Hmm, we have to have a special hook somehow.

[Qemu-devel] [PATCH v3 3/3] Update simpletrace.py for new log format

2012-06-12 Thread Harsh Prateek Bora
Support new tracelog format for multiple arguments and strings. Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com --- scripts/simpletrace.py | 116 +++- 1 file changed, 75 insertions(+), 41 deletions(-) diff --git a/scripts/simpletrace.py

[Qemu-devel] [PATCH v3 0/3] Simpletrace v2: Support multiple args, strings.

2012-06-12 Thread Harsh Prateek Bora
Existing simpletrace backend allows to trace at max 6 args and does not support strings. This newer tracelog format gets rid of fixed size records and therefore allows to trace variable number of args including strings. Sample trace: v9fs_version 0.000 tag=0x id=0x64 msize=0x2000

[Qemu-devel] [PATCH v3 2/4] fdc-test: introduced qtest read_without_media

2012-06-12 Thread Pavel Hrdina
If you try to read from a floppy drive without a media, you should get an abnormal termination error. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- tests/fdc-test.c | 63 ++ 1 files changed, 63 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private

2012-06-12 Thread Christian Borntraeger
On 12/06/12 13:57, Alexander Graf wrote: Since it lives in an s390 specific branch, the function name should probably be called s390 specific. If we ever need another architecture to have a kvm specific ram allocator, we can make it generic when that time comes. Until then, let's treat s390

Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private

2012-06-12 Thread Alexander Graf
On 06/12/2012 02:02 PM, Christian Borntraeger wrote: On 12/06/12 13:57, Alexander Graf wrote: Since it lives in an s390 specific branch, the function name should probably be called s390 specific. If we ever need another architecture to have a kvm specific ram allocator, we can make it generic

Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

2012-06-12 Thread Christian Borntraeger
Yes we will re-split the sclp patches. besides that, some comments: On 12/06/12 11:58, Alexander Graf wrote: +#include hw/s390-sclp.h No need for hw/. will fix. +void sclp_service_interrupt(CPUS390XState *env, uint32_t sccb) +{ +if (!sccb) { +return; +} + +

Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

2012-06-12 Thread Alexander Graf
On 06/12/2012 02:24 PM, Christian Borntraeger wrote: Yes we will re-split the sclp patches. besides that, some comments: On 12/06/12 11:58, Alexander Graf wrote: +#include hw/s390-sclp.h No need for hw/. will fix. +void sclp_service_interrupt(CPUS390XState *env, uint32_t sccb) +{ +

Re: [Qemu-devel] [PATCH 3/3] deal with guest panicked event

2012-06-12 Thread Luiz Capitulino
On Tue, 12 Jun 2012 14:55:37 +0800 Wen Congyang we...@cn.fujitsu.com wrote: +static void panicked_perform_action(void) +{ +switch(panicked_action) { +case PANICKED_REPORT: +panicked_mon_event(report); +break; + +case PANICKED_PAUSE: +

Re: [Qemu-devel] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-06-12 Thread Stefano Stabellini
On Tue, 12 Jun 2012, Andreas Färber wrote: Am 12.06.2012 10:24, schrieb Andreas Färber: Am 29.05.2012 15:35, schrieb Stefano Stabellini: The check-qtest-i386 qemu-system-i386 process now hangs at ~98% CPU, Does this mean that increasing the timeout caused a busy loop somewhere in the test?

Re: [Qemu-devel] [PATCH 3/3] deal with guest panicked event

2012-06-12 Thread Daniel P. Berrange
On Tue, Jun 12, 2012 at 09:35:04AM -0300, Luiz Capitulino wrote: On Tue, 12 Jun 2012 14:55:37 +0800 Wen Congyang we...@cn.fujitsu.com wrote: +static void panicked_perform_action(void) +{ +switch(panicked_action) { +case PANICKED_REPORT: +

Re: [Qemu-devel] [RFC] QOMification of AXI stream

2012-06-12 Thread Peter Maydell
On 11 June 2012 18:31, Avi Kivity a...@redhat.com wrote: On 06/11/2012 06:01 PM, Anthony Liguori wrote: Perhaps we should just make MemoryRegion work in both directions? The other direction is currently cpu_physical_memory_rw().  We do need to support issuing transactions from arbitrary

Re: [Qemu-devel] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX

2012-06-12 Thread Andreas Färber
Am 12.06.2012 14:37, schrieb Stefano Stabellini: On Tue, 12 Jun 2012, Andreas Färber wrote: Am 12.06.2012 10:24, schrieb Andreas Färber: Am 29.05.2012 15:35, schrieb Stefano Stabellini: The check-qtest-i386 qemu-system-i386 process now hangs at ~98% CPU, Does this mean that increasing the

Re: [Qemu-devel] [PATCH v3 4/4] fdc: fix interrupt handling

2012-06-12 Thread Paolo Bonzini
Il 12/06/2012 13:19, Pavel Hrdina ha scritto: } else { -/* XXX: status0 handling is broken for read/write - commands, so we do this hack. It should be suppressed - ASAP */ -fdctrl-fifo[0] = -FD_SR0_SEEK | (cur_drv-head 2) |

  1   2   3   >