Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-05 Thread Paolo Bonzini
Il 05/07/2012 05:29, Wayne Xia ha scritto: + + Note: When qemu-nbd was used to export a disk that would be used by QEMU +block device, -t or --persistent must be set for that QEMU nbd client would try +connect more than one time. For eg: + qemu-nbd ./simple.img -p 10809 -t + qemu -hdb

Re: [Qemu-devel] [PATCH 08/14] megasas: LSI Megaraid SAS HBA emulation

2012-07-05 Thread Hannes Reinecke
On 07/04/2012 09:33 AM, Paolo Bonzini wrote: Il 04/07/2012 07:52, Hannes Reinecke ha scritto: +const char *mfi_frame_desc[] = { Missing 'static'. If you insist ... [ .. ] Hey, cool. Just one issue. Paolo, can you fix it up in your tree or should I re-send the patch? Neither. Send

Re: [Qemu-devel] [PATCH] cpu: smp_wmb before lauching cpus.

2012-07-05 Thread Jan Kiszka
On 2012-07-05 04:18, Liu Ping Fan wrote: Vcpu state must be set completely before receiving INIT-IPI,SIPI Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- kvm.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kvm.h b/kvm.h index 9c7b0ea..5b3c228

Re: [Qemu-devel] [PATCH 04/32] vvfat: Do not clobber the user's geometry

2012-07-05 Thread Kevin Wolf
Am 04.07.2012 18:25, schrieb Paolo Bonzini: Il 04/07/2012 17:23, Kevin Wolf ha scritto: optsLCHSdef. PCHS :floppy: 80, 2,36 5,16,63 :32:floppy: 80, 2,36 5,16,63 :16:floppy: 80, 2,36 5,16,63 :12:floppy: 80, 2,18 2,16,63 Silly thing to do

Re: [Qemu-devel] [PATCH] usb: selective endpoint initialization

2012-07-05 Thread Erik Rull
Gerd Hoffmann wrote: Add support for (re-)initializing endpoints which belong to a specific interface only. Use this in usb-host when changing altsetting for an interface, so other interfaces are not disturbed. Hi Gerd, I tested it on my AMD test system where the issue didn't appear with

Re: [Qemu-devel] VirtIO 9p2000.L `locale-gen` fail; cache=loose

2012-07-05 Thread C Anthony Risinger
On Thu, Feb 23, 2012 at 12:08 PM, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: On Tue, 21 Feb 2012 21:58:39 -0600, C Anthony Risinger anth...@xtfx.me wrote: On Sat, Feb 18, 2012 at 11:38 AM, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: On Thu, 16 Feb 2012 06:20:21

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-05 Thread Michael Tokarev
On 05.07.2012 10:42, Paolo Bonzini wrote: Il 05/07/2012 05:29, Wayne Xia ha scritto: [] Hi Paolo, should I make a patch to make persistent the default for qemu-nbd? Yes, why not. However, as mentioned above client mode should still be non-persistent. I don't think this makes sense or is

Re: [Qemu-devel] race between kvm-kmod-3.0 and kvm-kmod-3.3 // was: race condition in qemu-kvm-1.0.1

2012-07-05 Thread Xiao Guangrong
On 07/05/2012 07:12 AM, Peter Lieven wrote: On 07/03/12 15:13, Avi Kivity wrote: On 07/03/2012 04:01 PM, Peter Lieven wrote: Further output from my testing. Working: Linux 2.6.38 with included kvm module Linux 3.0.0 with included kvm module Not-Working: Linux 3.2.0 with included kvm

Re: [Qemu-devel] [PATCH 05/32] qtest: Tidy up temporary files properly

2012-07-05 Thread Kevin Wolf
Am 29.06.2012 17:34, schrieb Markus Armbruster: Each test litters /tmp with several files: a pid file and two sockets. Tidy up. Signed-off-by: Markus Armbruster arm...@redhat.com Thanks! Still leaves the files around if a test case fails, but much better than before. Kevin

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-05 Thread Paolo Bonzini
Il 05/07/2012 10:13, Michael Tokarev ha scritto: Hi Paolo, should I make a patch to make persistent the default for qemu-nbd? Yes, why not. However, as mentioned above client mode should still be non-persistent. I don't think this makes sense or is good: now we'll need to have an

[Qemu-devel] KVM VMenter/exit cost

2012-07-05 Thread chenwj
Hi Xin Tong, Do you get any estimation on that? Regards, chenwj

Re: [Qemu-devel] race between kvm-kmod-3.0 and kvm-kmod-3.3 // was: race condition in qemu-kvm-1.0.1

2012-07-05 Thread Xiao Guangrong
On 06/28/2012 05:11 PM, Peter Lieven wrote: that here is bascially whats going on: qemu-kvm-1.0-2506 [010] 60996.908000: kvm_mmio: mmio read len 3 gpa 0xa val 0x10ff qemu-kvm-1.0-2506 [010] 60996.908000: vcpu_match_mmio: gva 0xa gpa 0xa Read GPA

Re: [Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges

2012-07-05 Thread Michael S. Tsirkin
On Wed, Jul 04, 2012 at 04:38:03PM -0500, Anthony Liguori wrote: On 07/04/2012 04:26 PM, Michael S. Tsirkin wrote: On Thu, Jul 05, 2012 at 12:17:17AM +0300, Michael S. Tsirkin wrote: On Wed, Jul 04, 2012 at 07:19:33PM +0200, Andreas Färber wrote: Uglify the parent field to enforce QOM-style

Re: [Qemu-devel] [PATCH 13/32] hd-geometry: Clean up confusing use of prior translation hint

2012-07-05 Thread Kevin Wolf
Am 29.06.2012 17:34, schrieb Markus Armbruster: When hd_geometry_guess() picks a geometry, it also picks the appropriate translation, but only when the prior translation hint is BIOS_ATA_TRANSLATION_AUTO. Looks wrong, because such a prior translation would be passed to the BIOS whether it's

Re: [Qemu-devel] [PATCH 04/32] vvfat: Do not clobber the user's geometry

2012-07-05 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 04.07.2012 18:25, schrieb Paolo Bonzini: Il 04/07/2012 17:23, Kevin Wolf ha scritto: optsLCHSdef. PCHS :floppy: 80, 2,36 5,16,63 :32:floppy: 80, 2,36 5,16,63 :16:floppy: 80, 2,36 5,16,63 :12:floppy:

Re: [Qemu-devel] [PATCH 03/32] vvfat: Fix partition table

2012-07-05 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 29.06.2012 22:33, schrieb Blue Swirl: On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster arm...@redhat.com wrote: Unless parameter :floppy: is given, vvfat creates a virtual image with DOS MBR defining a single partition which holds the FAT file system.

Re: [Qemu-devel] [PATCH 05/32] qtest: Tidy up temporary files properly

2012-07-05 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 29.06.2012 17:34, schrieb Markus Armbruster: Each test litters /tmp with several files: a pid file and two sockets. Tidy up. Signed-off-by: Markus Armbruster arm...@redhat.com Thanks! Still leaves the files around if a test case fails, but much

Re: [Qemu-devel] [PATCH 13/32] hd-geometry: Clean up confusing use of prior translation hint

2012-07-05 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 29.06.2012 17:34, schrieb Markus Armbruster: When hd_geometry_guess() picks a geometry, it also picks the appropriate translation, but only when the prior translation hint is BIOS_ATA_TRANSLATION_AUTO. Looks wrong, because such a prior translation

[Qemu-devel] [PATCH] msix: Drop tracking of used vectors

2012-07-05 Thread Jan Kiszka
This optimization was once used in qemu-kvm to keep KVM route usage low. But now we solved that problem via lazy updates. It also tried to handle the case of vectors shared between different sources of the same device. However, this never really worked and will have to be addressed differently

Re: [Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges

2012-07-05 Thread Paolo Bonzini
Il 05/07/2012 10:59, Michael S. Tsirkin ha scritto: Field accesses are better. If there is a user error, code does not compile. They are also self-documenting to some level: you look at a struct you see all its fields. How do you know which casts will succeed on a given type? There's no easy

Re: [Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges

2012-07-05 Thread Paolo Bonzini
Il 05/07/2012 00:34, Andreas Färber ha scritto: Just to clarify: replacing upcasts which are always safe with downcasts which can fail is what I consider especially ugly. As per Anthony the parent field in the QOM instance structs is not supposed to be touched (cf. object.h). We mark it /*

Re: [Qemu-devel] [PATCH 03/32] vvfat: Fix partition table

2012-07-05 Thread Kevin Wolf
Am 05.07.2012 11:23, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 29.06.2012 22:33, schrieb Blue Swirl: On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster arm...@redhat.com wrote: Unless parameter :floppy: is given, vvfat creates a virtual image with DOS MBR defining

Re: [Qemu-devel] [PATCH v14 02/13] Add migration capabilities

2012-07-05 Thread Orit Wasserman
On 07/03/2012 09:36 PM, Eric Blake wrote: On 07/03/2012 07:52 AM, Orit Wasserman wrote: Add migration capabilities that can be queried by the management. The management can query the source QEMU and the destination QEMU in order to verify both support some migration capability (currently only

Re: [Qemu-devel] [PATCH] cpu: smp_wmb before lauching cpus.

2012-07-05 Thread liu ping fan
On Thu, Jul 5, 2012 at 2:46 PM, Jan Kiszka jan.kis...@web.de wrote: On 2012-07-05 04:18, Liu Ping Fan wrote: Vcpu state must be set completely before receiving INIT-IPI,SIPI Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- kvm.h |1 + 1 files changed, 1 insertions(+), 0

Re: [Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges

2012-07-05 Thread Andreas Färber
Am 05.07.2012 11:53, schrieb Paolo Bonzini: Il 05/07/2012 00:34, Andreas Färber ha scritto: Just to clarify: replacing upcasts which are always safe with downcasts which can fail is what I consider especially ugly. As per Anthony the parent field in the QOM instance structs is not supposed to

Re: [Qemu-devel] [PATCH] cpu: smp_wmb before lauching cpus.

2012-07-05 Thread Jan Kiszka
On 2012-07-05 12:10, liu ping fan wrote: On Thu, Jul 5, 2012 at 2:46 PM, Jan Kiszka jan.kis...@web.de wrote: On 2012-07-05 04:18, Liu Ping Fan wrote: Vcpu state must be set completely before receiving INIT-IPI,SIPI Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- kvm.h |1 +

Re: [Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges

2012-07-05 Thread Paolo Bonzini
Not entirely true, being at the beginning of the struct is already enforced by using DO_UPCAST (which is admittedly a strange name for a downcast macro) instead of container_of. If you look at the patchset you will find that it was not properly enforced! Well, what *is* enforced? :)

Re: [Qemu-devel] [PATCH] cpu: smp_wmb before lauching cpus.

2012-07-05 Thread liu ping fan
On Thu, Jul 5, 2012 at 6:16 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-07-05 12:10, liu ping fan wrote: On Thu, Jul 5, 2012 at 2:46 PM, Jan Kiszka jan.kis...@web.de wrote: On 2012-07-05 04:18, Liu Ping Fan wrote: Vcpu state must be set completely before receiving INIT-IPI,SIPI

Re: [Qemu-devel] [PATCH 03/32] vvfat: Fix partition table

2012-07-05 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 05.07.2012 11:23, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 29.06.2012 22:33, schrieb Blue Swirl: On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster arm...@redhat.com wrote: Unless parameter :floppy: is given, vvfat creates a

Re: [Qemu-devel] [PATCH 04/32] vvfat: Do not clobber the user's geometry

2012-07-05 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 29.06.2012 17:34, schrieb Markus Armbruster: [...] @@ -1067,19 +1074,16 @@ DLOG(if (stderr == NULL) { else dirname += i+1; -bs-total_sectors=bs-cyls*bs-heads*bs-secs; +bs-total_sectors = cyls * heads * secs; -

Re: [Qemu-devel] [PATCH 03/32] vvfat: Fix partition table

2012-07-05 Thread Kevin Wolf
Am 05.07.2012 13:10, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 05.07.2012 11:23, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 29.06.2012 22:33, schrieb Blue Swirl: On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster arm...@redhat.com wrote: +

[Qemu-devel] [PATCH] target-arm: Fix TCG temp handling in 64 bit cp writes

2012-07-05 Thread Peter Maydell
Fix errors in the TCG temp handling in the 64 bit coprocessor write path: we were reusing a 32 bit temp after it had been freed by store_reg(), and failing to free a 64 bit temp. This bug has no visible effect at this point because there aren't any non-NOP 64 bit registers yet; it needs to be

Re: [Qemu-devel] [PATCH 22/32] qtest: Cover qdev properties for disk geometry

2012-07-05 Thread Kevin Wolf
Am 29.06.2012 17:34, schrieb Markus Armbruster: Signed-off-by: Markus Armbruster arm...@redhat.com --- tests/hd-geo-test.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c index 0ab573c..02eb5c2 100644 ---

Re: [Qemu-devel] [PATCH] cpu: smp_wmb before lauching cpus.

2012-07-05 Thread Jan Kiszka
On 2012-07-05 13:02, liu ping fan wrote: On Thu, Jul 5, 2012 at 6:16 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-07-05 12:10, liu ping fan wrote: On Thu, Jul 5, 2012 at 2:46 PM, Jan Kiszka jan.kis...@web.de wrote: On 2012-07-05 04:18, Liu Ping Fan wrote: Vcpu state must be set

Re: [Qemu-devel] [PATCH 22/32] qtest: Cover qdev properties for disk geometry

2012-07-05 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 29.06.2012 17:34, schrieb Markus Armbruster: Signed-off-by: Markus Armbruster arm...@redhat.com --- tests/hd-geo-test.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c index

Re: [Qemu-devel] race between kvm-kmod-3.0 and kvm-kmod-3.3 // was: race condition in qemu-kvm-1.0.1

2012-07-05 Thread Peter Lieven
On 05.07.2012 10:51, Xiao Guangrong wrote: On 06/28/2012 05:11 PM, Peter Lieven wrote: that here is bascially whats going on: qemu-kvm-1.0-2506 [010] 60996.908000: kvm_mmio: mmio read len 3 gpa 0xa val 0x10ff qemu-kvm-1.0-2506 [010] 60996.908000: vcpu_match_mmio:

[Qemu-devel] [PATCH v4 1/6] fix doc of using raw values with sendkey

2012-07-05 Thread Amos Kong
(qemu) sendkey a (qemu) sendkey 0x1e (qemu) sendkey #0x1e unknown key: '#0x1e' The last command doesn't work, '#' is not requested before raw values. And the raw value in decimal format is also not supported. Signed-off-by: Amos Kong ak...@redhat.com --- hmp-commands.hx |6 +++--- 1 files

[Qemu-devel] [PATCH v15 0/9] XBZRLE delta for live migration of large memory app

2012-07-05 Thread Orit Wasserman
Changes from v14: - rebase on top on Juan's patches - Use clz64 to calculate pow2floor (round down to power of 2) - Fix xbzrle_encode_buffer and xbzrle_decode_buffer - Fix QMP commands documentation Changes from v13: - Fix round to power of 2 of cache size

[Qemu-devel] [PATCH v15 1/9] Add migration capabilities

2012-07-05 Thread Orit Wasserman
Add migration capabilities that can be queried by the management. The management can query the source QEMU and the destination QEMU in order to verify both support some migration capability (currently only XBZRLE). The management can enable a capability for the next migration by using

[Qemu-devel] [PATCH v15 4/9] Add uleb encoding/decoding functions

2012-07-05 Thread Orit Wasserman
Implement Unsigned Little Endian Base 128. Signed-off-by: Orit Wasserman owass...@redhat.com --- cutils.c | 33 + qemu-common.h |8 2 files changed, 41 insertions(+), 0 deletions(-) diff --git a/cutils.c b/cutils.c index 02d5bd0..7d99fe0

Re: [Qemu-devel] [PATCH v4 4/6] qapi: generate list struct and visit_list for enum

2012-07-05 Thread Eric Blake
On 07/05/2012 06:48 AM, Amos Kong wrote: Currently, if define an 'enum' and use it in one command's data, List struct for enum could not be generated, but it's used in qmp function. For example: KeyCodesList could not be generated. qapi-schema.json: { 'enum': 'KeyCodes', 'data': [

[Qemu-devel] [PATCH v15 7/9] Add XBZRLE to ram_save_block and ram_save_live

2012-07-05 Thread Orit Wasserman
In the outgoing migration check to see if the page is cached and changed than send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is set and decompress the page (by using load_xbrle function). Signed-off-by: Benoit Hudzia

[Qemu-devel] [PATCH v15 8/9] Add set_cachesize command

2012-07-05 Thread Orit Wasserman
Change XBZRLE cache size in bytes (the size should be a power of 2). If XBZRLE cache size is too small there will be many cache miss. Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard pett...@cs.umu.se Signed-off-by: Aidan Shribman aidan.shrib...@sap.com

[Qemu-devel] [PATCH v15 9/9] Add XBZRLE statistics

2012-07-05 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard pett...@cs.umu.se Signed-off-by: Aidan Shribman aidan.shrib...@sap.com Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 68 +- hmp.c

Re: [Qemu-devel] [PATCH] msix: Drop tracking of used vectors

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 11:42:14AM +0200, Jan Kiszka wrote: This optimization was once used in qemu-kvm to keep KVM route usage low. But now we solved that problem via lazy updates. What if we are using vhost which AFAIK can't use the lazy path? It also tried to handle the case of vectors

[Qemu-devel] [PATCH v4 3/6] hmp: rename arguments

2012-07-05 Thread Amos Kong
Rename 'string' to 'keys', rename 'hold_time' to 'hold-time'. Signed-off-by: Amos Kong ak...@redhat.com --- hmp-commands.hx |2 +- monitor.c | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 30243b6..e336251

Re: [Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 12:15:04PM +0200, Andreas Färber wrote: Am 05.07.2012 11:53, schrieb Paolo Bonzini: Il 05/07/2012 00:34, Andreas Färber ha scritto: Just to clarify: replacing upcasts which are always safe with downcasts which can fail is what I consider especially ugly. As per

Re: [Qemu-devel] [PATCH v8 01/16] target-or32: Add target stubs and QOM cpu

2012-07-05 Thread Andreas Färber
Am 01.07.2012 04:45, schrieb Jia Liu: Add OpenRISC target stubs and cpu support. Signed-off-by: Jia Liu pro...@gmail.com --- arch_init.c |2 + arch_init.h |1 + configure| 14 +- cpu-exec.c

[Qemu-devel] [RFC][PATCH v2 0/4] tcg: enhance code generation quality for qemu_ld/st IRs

2012-07-05 Thread Yeongkyoon Lee
Hi, all. I think the generated codes from qemu_ld/st IRs are relatively heavy, which are up to 12 instructions for TLB hit case on i386 host. This patch series enhances the code quality of TCG qemu_ld/st IRs by reducing jump and enhancing locality. Main idea is simple and has been already

[Qemu-devel] [RFC][PATCH v2 1/4] tcg: add declarations and templates of extended MMU helpers

2012-07-05 Thread Yeongkyoon Lee
Add declarations and templates of extended MMU helpers which can take return address argument to what helper functions return. These extended helper functions are called only by generated code. Signed-off-by: Yeongkyoon Lee yeongkyoon@samsung.com --- softmmu_defs.h | 13 +

[Qemu-devel] [RFC][PATCH v2 2/4] tcg: add extended MMU helpers to softmmu targets

2012-07-05 Thread Yeongkyoon Lee
Add extended MMU helpers to softmmu targets, where the targets are alpha, arm, cris, i386, lm32, m68k, microblaze, mips, ppc, s390x, sh4, sparc and xtensa. Signed-off-by: Yeongkyoon Lee yeongkyoon@samsung.com --- target-alpha/mem_helper.c | 22 ++

[Qemu-devel] [RFC][PATCH v2 4/4] configure: add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization

2012-07-05 Thread Yeongkyoon Lee
Add an option --enable-ldst-optimization to enable CONFIG_QEMU_LDST_OPTIMIZATION macro for TCG qemu_ld/st optimization. It only works with CONFIG_SOFTMMU and doesn't work with CONFIG_TCG_PASS_AREG0. Signed-off-by: Yeongkyoon Lee yeongkyoon@samsung.com --- configure | 15 +++

[Qemu-devel] [PATCH v15 5/9] Change ram_save_block to return -1 if there are no more changes

2012-07-05 Thread Orit Wasserman
It will return 0 if the page is unmodifed. Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/arch_init.c b/arch_init.c index 9fd6346..e36899e 100644 --- a/arch_init.c +++ b/arch_init.c @@ -188,7

[Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey

2012-07-05 Thread Amos Kong
Convert 'sendkey' to use QAPI. do_sendkey() depends on some variables/functions in monitor.c, so reserve qmp_sendkey() to monitor.c key_defs[] in console.h is the mapping of key name to keycode, Keys' index in the enmu and key_defs[] is same. 'send-key' of QMP doesn't support key in hexadecimal

[Qemu-devel] [PATCH] tests: Makefile: include dependency files

2012-07-05 Thread Eduardo Habkost
Otherwise 'make check' won't recompile files that need to be recompiled because of header changes. To reproduce the bug, run: $ make check # succeeds $ echo B0RKED hw/mc146818rtc_regs.h $ make check # is supposed to try to rebuild tests/rtc-test.o and fail Signed-off-by: Eduardo Habkost

[Qemu-devel] [PATCH v15 3/9] Add cache handling functions

2012-07-05 Thread Orit Wasserman
Add LRU page cache mechanism. The page are accessed by their address. Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard pett...@cs.umu.se Signed-off-by: Aidan Shribman aidan.shrib...@sap.com Signed-off-by: Orit Wasserman owass...@redhat.com --- Makefile.objs

[Qemu-devel] [PATCH v15 2/9] Add XBZRLE documentation

2012-07-05 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- docs/xbzrle.txt | 136 +++ 1 files changed, 136 insertions(+), 0 deletions(-) create mode 100644 docs/xbzrle.txt diff --git a/docs/xbzrle.txt b/docs/xbzrle.txt new file mode 100644 index

Re: [Qemu-devel] [PATCH v8 01/16] target-or32: Add target stubs and QOM cpu

2012-07-05 Thread Paolo Bonzini
Il 05/07/2012 15:22, Andreas Färber ha scritto: +static void openrisc_any_initfn(Object *obj) +{ +OpenRISCCPU *cpu = OPENRISC_CPU(obj); + +set_feature(cpu, OPENRISC_FEATURE_OB32S); +set_feature(cpu, OPENRISC_FEATURE_OF32S); + +cpu_reset(CPU(cpu)); +} Paolo, could

[Qemu-devel] [PATCH] Replace 'struct siginfo' with 'siginfo_t'.

2012-07-05 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com glibc 2.16 will remove the undocumented definition of 'struct siginfo' from bits/siginfo.h. This change is already present in glibc 2.15.90, so qemu compilation of certain targets (eg. cris-user) breaks. This struct was always typedef'd to be the same

Re: [Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 12:34:20AM +0200, Andreas Färber wrote: Am 04.07.2012 23:26, schrieb Michael S. Tsirkin: On Thu, Jul 05, 2012 at 12:17:17AM +0300, Michael S. Tsirkin wrote: On Wed, Jul 04, 2012 at 07:19:33PM +0200, Andreas Färber wrote: Uglify the parent field to enforce QOM-style

Re: [Qemu-devel] [RFC][PATCH v2 1/4] tcg: add declarations and templates of extended MMU helpers

2012-07-05 Thread Peter Maydell
On 5 July 2012 14:23, Yeongkyoon Lee yeongkyoon@samsung.com wrote: Add declarations and templates of extended MMU helpers which can take return address argument to what helper functions return. These extended helper functions are called only by generated code. It's not entirely clear

[Qemu-devel] [PATCH v4 4/6] qapi: generate list struct and visit_list for enum

2012-07-05 Thread Amos Kong
Currently, if define an 'enum' and use it in one command's data, List struct for enum could not be generated, but it's used in qmp function. For example: KeyCodesList could not be generated. qapi-schema.json: { 'enum': 'KeyCodes', 'data': [ 'shift', 'alt' ... ] } { 'command': 'sendkey',

[Qemu-devel] [PATCH v15 6/9] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-07-05 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard pett...@cs.umu.se Signed-off-by: Aidan Shribman aidan.shrib...@sap.com Signed-off-by: Orit Wasserman owass...@redhat.com --- migration.h |4 ++ savevm.c| 157

Re: [Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges

2012-07-05 Thread Andreas Färber
Am 05.07.2012 15:34, schrieb Michael S. Tsirkin: On Thu, Jul 05, 2012 at 12:34:20AM +0200, Andreas Färber wrote: Am 04.07.2012 23:26, schrieb Michael S. Tsirkin: On Thu, Jul 05, 2012 at 12:17:17AM +0300, Michael S. Tsirkin wrote: On Wed, Jul 04, 2012 at 07:19:33PM +0200, Andreas Färber wrote:

Re: [Qemu-devel] [RFC][PATCH v2 2/4] tcg: add extended MMU helpers to softmmu targets

2012-07-05 Thread Peter Maydell
On 5 July 2012 14:23, Yeongkyoon Lee yeongkyoon@samsung.com wrote: Add extended MMU helpers to softmmu targets, where the targets are alpha, arm, cris, i386, lm32, m68k, microblaze, mips, ppc, s390x, sh4, sparc and xtensa. Signed-off-by: Yeongkyoon Lee yeongkyoon@samsung.com ---

[Qemu-devel] [PATCH v4 6/6] ps2: output warning when event queue full

2012-07-05 Thread Amos Kong
Event would be ignored if ps2 queue is full, this patch added a warning in ignore path. Signed-off-by: Amos Kong ak...@redhat.com --- hw/ps2.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/ps2.c b/hw/ps2.c index f93cd24..799c36b 100644 --- a/hw/ps2.c +++

Re: [Qemu-devel] [PATCH v15 2/9] Add XBZRLE documentation

2012-07-05 Thread Eric Blake
On 07/05/2012 06:51 AM, Orit Wasserman wrote: Signed-off-by: Orit Wasserman owass...@redhat.com --- docs/xbzrle.txt | 136 +++ 1 files changed, 136 insertions(+), 0 deletions(-) create mode 100644 docs/xbzrle.txt + +Example +old

Re: [Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges

2012-07-05 Thread Anthony Liguori
On 07/05/2012 08:34 AM, Michael S. Tsirkin wrote: On Thu, Jul 05, 2012 at 12:34:20AM +0200, Andreas Färber wrote: Am 04.07.2012 23:26, schrieb Michael S. Tsirkin: On Thu, Jul 05, 2012 at 12:17:17AM +0300, Michael S. Tsirkin wrote: On Wed, Jul 04, 2012 at 07:19:33PM +0200, Andreas Färber

Re: [Qemu-devel] [RFC][PATCH v2 4/4] configure: add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization

2012-07-05 Thread Andreas Färber
Am 05.07.2012 15:23, schrieb Yeongkyoon Lee: Add an option --enable-ldst-optimization to enable CONFIG_QEMU_LDST_OPTIMIZATION macro for TCG qemu_ld/st optimization. It only works with CONFIG_SOFTMMU and doesn't work with CONFIG_TCG_PASS_AREG0. Signed-off-by: Yeongkyoon Lee

Re: [Qemu-devel] [PATCH v15 6/9] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-07-05 Thread Eric Blake
On 07/05/2012 06:51 AM, Orit Wasserman wrote: This commit message is a bit sparse. I'd document at least the fact that our nzrun detection code in xbzrle_encode_buffer borrows long-word-at-a-time NUL-detection tricks from strcmp(), as it is not an intuitive trick known by all developers.

[Qemu-devel] [RFC][PATCH v2 3/4] tcg: add optimized TCG qemu_ld/st generation

2012-07-05 Thread Yeongkyoon Lee
Add optimized TCG qemu_ld/st generation which generates the code for TLB miss case handling at the end of TB after generating other IRs. Signed-off-by: Yeongkyoon Lee yeongkyoon@samsung.com --- tcg/i386/tcg-target.c | 328 + tcg/tcg.c

[Qemu-devel] [PATCH v4 0/6] convert sendkey to qapi

2012-07-05 Thread Amos Kong
This series converted 'sendkey' command to qapi. The raw value in hexadecimal format is not supported by 'send-key' of qmp. Amos Kong (6): fix doc of using raw values with sendkey monitor: rename keyname '' to 'less' hmp: rename arguments qapi: generate list struct and visit_list for enum

[Qemu-devel] [PATCH v4 2/6] monitor: rename keyname '' to 'less'

2012-07-05 Thread Amos Kong
There are many maps of keycode 0x56 in pc-bios/keymaps/* pc-bios/keymaps/common:less 0x56 pc-bios/keymaps/common:greater 0x56 shift pc-bios/keymaps/common:bar 0x56 altgr pc-bios/keymaps/common:brokenbar 0x56 shift altgr This patch just renames '' to 'less', QAPI would add new variable by

Re: [Qemu-devel] [RFC][PATCH v2 3/4] tcg: add optimized TCG qemu_ld/st generation

2012-07-05 Thread Peter Maydell
On 5 July 2012 14:23, Yeongkyoon Lee yeongkyoon@samsung.com wrote: Add optimized TCG qemu_ld/st generation which generates the code for TLB miss case handling at the end of TB after generating other IRs. Signed-off-by: Yeongkyoon Lee yeongkyoon@samsung.com --- tcg/i386/tcg-target.c

Re: [Qemu-devel] [PATCH v15 7/9] Add XBZRLE to ram_save_block and ram_save_live

2012-07-05 Thread Eric Blake
On 07/05/2012 06:51 AM, Orit Wasserman wrote: In the outgoing migration check to see if the page is cached and changed than send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is set and decompress the page (by using load_xbrle

Re: [Qemu-devel] [RFC][PATCH v2 4/4] configure: add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization

2012-07-05 Thread Peter Maydell
On 5 July 2012 14:23, Yeongkyoon Lee yeongkyoon@samsung.com wrote: Add an option --enable-ldst-optimization to enable CONFIG_QEMU_LDST_OPTIMIZATION macro for TCG qemu_ld/st optimization. It only works with CONFIG_SOFTMMU and doesn't work with CONFIG_TCG_PASS_AREG0. This shouldn't be a

Re: [Qemu-devel] q35 and ahci

2012-07-05 Thread Jason Baron
On Wed, Jul 04, 2012 at 10:33:18AM +0200, Alexander Graf wrote: On 04.07.2012, at 03:29, Jason Baron wrote: On Tue, Jul 03, 2012 at 10:54:37PM +0200, Alexander Graf wrote: On 03.07.2012, at 22:37, Jason Baron wrote: On Tue, Jul 03, 2012 at 08:52:50PM +0200, Alexander Graf wrote: On

Re: [Qemu-devel] [PATCH v15 8/9] Add set_cachesize command

2012-07-05 Thread Eric Blake
On 07/05/2012 06:51 AM, Orit Wasserman wrote: Change XBZRLE cache size in bytes (the size should be a power of 2). If XBZRLE cache size is too small there will be many cache miss. Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard pett...@cs.umu.se Signed-off-by:

Re: [Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 08:54:21AM -0500, Anthony Liguori wrote: On 07/05/2012 08:34 AM, Michael S. Tsirkin wrote: On Thu, Jul 05, 2012 at 12:34:20AM +0200, Andreas Färber wrote: Am 04.07.2012 23:26, schrieb Michael S. Tsirkin: On Thu, Jul 05, 2012 at 12:17:17AM +0300, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] Replace 'struct siginfo' with 'siginfo_t'.

2012-07-05 Thread Peter Maydell
On 5 July 2012 14:32, Richard W.M. Jones rjo...@redhat.com wrote: From: Richard W.M. Jones rjo...@redhat.com glibc 2.16 will remove the undocumented definition of 'struct siginfo' from bits/siginfo.h. Progress marches on, trampling all in its wake. This change is already present in glibc

Re: [Qemu-devel] [PATCH v15 9/9] Add XBZRLE statistics

2012-07-05 Thread Eric Blake
On 07/05/2012 06:51 AM, Orit Wasserman wrote: Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard pett...@cs.umu.se Signed-off-by: Aidan Shribman aidan.shrib...@sap.com Signed-off-by: Orit Wasserman owass...@redhat.com +++ b/arch_init.c @@ -202,8 +202,66 @@

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-05 Thread Corey Bryant
On 07/04/2012 04:00 AM, Kevin Wolf wrote: Am 03.07.2012 19:03, schrieb Eric Blake: 2. drive_add file=/dev/fdset/1 - qemu_open uses the first fd from the set that has access flags matching the qemu_open action flags. qemu_open increments refcount for this fd. 3. add-fd /dev/fdset/1 FDSET={M} -

Re: [Qemu-devel] [PATCH] Replace 'struct siginfo' with 'siginfo_t'.

2012-07-05 Thread Richard W.M. Jones
On Thu, Jul 05, 2012 at 03:16:12PM +0100, Peter Maydell wrote: On 5 July 2012 14:32, Richard W.M. Jones rjo...@redhat.com wrote: From: Richard W.M. Jones rjo...@redhat.com glibc 2.16 will remove the undocumented definition of 'struct siginfo' from bits/siginfo.h. Progress marches on,

Re: [Qemu-devel] [RFC][PATCH v2 4/4] configure: add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization

2012-07-05 Thread Laurent Desnogues
On Thu, Jul 5, 2012 at 4:06 PM, Peter Maydell peter.mayd...@linaro.org wrote: [...] case $target_arch2 in alpha | sparc* | xtensa* | ppc*) echo CONFIG_TCG_PASS_AREG0=y $config_target_mak +# qemu_ld/st optimization is not available with CONFIG_TCG_PASS_AREG0 +

Re: [Qemu-devel] [PATCH] msix: Drop tracking of used vectors

2012-07-05 Thread Jan Kiszka
On 2012-07-05 15:17, Michael S. Tsirkin wrote: On Thu, Jul 05, 2012 at 11:42:14AM +0200, Jan Kiszka wrote: This optimization was once used in qemu-kvm to keep KVM route usage low. But now we solved that problem via lazy updates. What if we are using vhost which AFAIK can't use the lazy path?

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-05 Thread Kevin Wolf
Am 05.07.2012 16:22, schrieb Corey Bryant: For some examples: 1. client calls 'add-fd', qemu is now tracking fd=4 with refcount 1, in use by monitor, as member of fdset1 2. client crashes, so all tracked fds are visited; fd=4 had not yet been passed to 'remove-fd', so qemu decrements

Re: [Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges

2012-07-05 Thread Andreas Färber
(Dropping some borked CCs) Am 05.07.2012 16:15, schrieb Michael S. Tsirkin: On Thu, Jul 05, 2012 at 08:54:21AM -0500, Anthony Liguori wrote: On 07/05/2012 08:34 AM, Michael S. Tsirkin wrote: On Thu, Jul 05, 2012 at 12:34:20AM +0200, Andreas Färber wrote: Am 04.07.2012 23:26, schrieb Michael

Re: [Qemu-devel] q35 and ahci

2012-07-05 Thread Alexander Graf
On 07/05/2012 04:06 PM, Jason Baron wrote: On Wed, Jul 04, 2012 at 10:33:18AM +0200, Alexander Graf wrote: On 04.07.2012, at 03:29, Jason Baron wrote: On Tue, Jul 03, 2012 at 10:54:37PM +0200, Alexander Graf wrote: On 03.07.2012, at 22:37, Jason Baron wrote: On Tue, Jul 03, 2012 at

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-05 Thread Corey Bryant
On 07/04/2012 04:09 AM, Kevin Wolf wrote: Am 03.07.2012 20:21, schrieb Corey Bryant: On 07/03/2012 02:00 PM, Eric Blake wrote: On 07/03/2012 11:46 AM, Corey Bryant wrote: Yes, I think adding a +1 to the refcount for the monitor makes sense. I'm a bit unsure how to increment the refcount

[Qemu-devel] [PATCH uq/master 0/9] remove event_notifier_get_fd from non-KVM code

2012-07-05 Thread Paolo Bonzini
This is part 1 of a three-part series that expands usage of EventNotifier in QEMU (including AIO and the main loop). I started working on this when playing with the threaded block layer; the part of that work that I hope will be in 1.2 is generalizing posix-aio-compat.c to be a generic portable

[Qemu-devel] [PATCH uq/master 1/9] event_notifier: add event_notifier_set

2012-07-05 Thread Paolo Bonzini
EventNotifier right now cannot be used as an inter-thread communication primitive. It only works if something else (the kernel) sets the eventfd. Add a primitive to signal an EventNotifier that another thread is waiting on. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- event_notifier.c |

[Qemu-devel] [PATCH uq/master 6/9] memory: pass EventNotifier, not eventfd

2012-07-05 Thread Paolo Bonzini
Under Win32, EventNotifiers will not have event_notifier_get_fd, so we cannot call it in common code such as hw/virtio-pci.c. Pass a pointer to the notifier, and only retrieve the file descriptor in kvm-specific code. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- exec.c |8

Re: [Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 05:00:00PM +0200, Andreas Färber wrote: (Dropping some borked CCs) Am 05.07.2012 16:15, schrieb Michael S. Tsirkin: On Thu, Jul 05, 2012 at 08:54:21AM -0500, Anthony Liguori wrote: On 07/05/2012 08:34 AM, Michael S. Tsirkin wrote: On Thu, Jul 05, 2012 at

Re: [Qemu-devel] [PATCH v3 01/14] pci: Make host bridge TypeInfos const

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 12:51:12AM +0200, Andreas Färber wrote: Am 04.07.2012 23:20, schrieb Michael S. Tsirkin: On Wed, Jul 04, 2012 at 07:19:20PM +0200, Andreas Färber wrote: Also give the sPAPR host bridge type registration functions a unique name. Signed-off-by: Andreas Färber

Re: [Qemu-devel] [PATCH 32/32] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255

2012-07-05 Thread Kevin Wolf
Am 29.06.2012 17:34, schrieb Markus Armbruster: New limits straight from ATA4 6.2 Register delivered data transfer command sector addressing. I figure the old sector limit 63 was blindly copied from the BIOS int 13 limit. Doesn't apply to the hardware. No idea where the old cylinder limit

Re: [Qemu-devel] [PATCH v8 01/16] target-or32: Add target stubs and QOM cpu

2012-07-05 Thread Andreas Färber
Am 05.07.2012 15:31, schrieb Paolo Bonzini: Il 05/07/2012 15:22, Andreas Färber ha scritto: +static void openrisc_any_initfn(Object *obj) +{ +OpenRISCCPU *cpu = OPENRISC_CPU(obj); + +set_feature(cpu, OPENRISC_FEATURE_OB32S); +set_feature(cpu, OPENRISC_FEATURE_OF32S); + +

[Qemu-devel] [PATCH uq/master 8/9] virtio: move common ioeventfd handling out of virtio-pci

2012-07-05 Thread Paolo Bonzini
All transports can use the same event handler for the ioeventfd, though the exact setup (address/memory region) will be specific. This lets virtio use event_notifier_set_handler. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/virtio-pci.c | 36 ++--

[Qemu-devel] [PATCH uq/master 4/9] ivshmem: use EventNotifier and memory API

2012-07-05 Thread Paolo Bonzini
All of ivshmem's usage of eventfd now has a corresponding API in EventNotifier. Simplify the code by using it, and also use the memory API consistently to set up and tear down the ioeventfds. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/ivshmem.c | 63

[Qemu-devel] [PATCH uq/master 5/9] ivshmem: wrap ivshmem_del_eventfd loops with transaction

2012-07-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/ivshmem.c |4 1 file changed, 4 insertions(+) diff --git a/hw/ivshmem.c b/hw/ivshmem.c index 3cdbea2..19e164a 100644 --- a/hw/ivshmem.c +++ b/hw/ivshmem.c @@ -369,8 +369,12 @@ static void close_guest_eventfds(IVShmemState *s, int

Re: [Qemu-devel] [PATCH 32/32] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255

2012-07-05 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 29.06.2012 17:34, schrieb Markus Armbruster: New limits straight from ATA4 6.2 Register delivered data transfer command sector addressing. I figure the old sector limit 63 was blindly copied from the BIOS int 13 limit. Doesn't apply to the hardware.

  1   2   >