Re: [Qemu-devel] [PATCH] flatload: fix bss clearing

2012-07-10 Thread Mike Frysinger
On Monday 09 July 2012 09:21:52 Andreas Färber wrote: Am 09.07.2012 15:04, schrieb Mike Frysinger: The current bss clear logic assumes the target mmap address and host address are the same. Use g2h to translate from the target address space to the host so we can call memset on it. Patch

Re: [Qemu-devel] [PATCH] megasas: Fix compilation for 32 bit hosts

2012-07-10 Thread Hannes Reinecke
Hi Stefan, you might've seen that Anthony objected to this in general. Apparently I'm not allowed to use the instance address to seed the SAS address. So yes, your fix is valid, but might be pointless as I might have to re-do this section anyway. But wait and see what Anthony has to say here.

Re: [Qemu-devel] [PATCH] megasas: Fix compilation for 32 bit hosts

2012-07-10 Thread Stefan Weil
Am 10.07.2012 08:00, schrieb Hannes Reinecke: Hi Stefan, you might've seen that Anthony objected to this in general. Apparently I'm not allowed to use the instance address to seed the SAS address. So yes, your fix is valid, but might be pointless as I might have to re-do this section anyway.

[Qemu-devel] make apic hot-plugable

2012-07-10 Thread Liu Ping Fan
The previous effort to make apic hot-plugable is thread: [PATCH V3] Introduce a new bus ICC to connect APIC refer to : http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg00413.html But now, we are with qom. So remodeling the apic as a kid of CPUState (neglect the dependent apic, which

Re: [Qemu-devel] [PATCH v2 0/2] QOMify AXI stream for Xilinx AXI ethernet/DMA

2012-07-10 Thread Peter Crosthwaite
Ping^2 On Wed, Jul 4, 2012 at 10:28 AM, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: Ping! On Thu, Jun 28, 2012 at 8:41 PM, Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com wrote: Next revision of the series for AXI-stream, rebased on anthonys refactoring of the

[Qemu-devel] [PATCH 3/5] qdev: export the bus reset interface

2012-07-10 Thread Liu Ping Fan
Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/qdev.c | 17 - hw/qdev.h |2 ++ 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index d2100a1..f7983e4 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -249,11 +249,9 @@ static int

Re: [Qemu-devel] [PATCH 4/6] device_tree: Add support for reading device tree properties

2012-07-10 Thread Peter Crosthwaite
On Sat, Jul 7, 2012 at 1:34 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 6 July 2012 02:56, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: Can we generalise and get functionality for reading cells with offsets as well? Your function assumes (and asserts) that the property is

[Qemu-devel] [PATCH 2/5] qom: introduce object_is_type_str(), so we can judge its type.

2012-07-10 Thread Liu Ping Fan
Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- include/qemu/object.h |2 ++ qom/object.c |6 ++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/include/qemu/object.h b/include/qemu/object.h index 8b17776..a66e996 100644 --- a/include/qemu/object.h

[Qemu-devel] [PATCH 5/5] apic: create apic as a child of cpu, not system_bus any longer

2012-07-10 Thread Liu Ping Fan
Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/pc.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index c7e9ab3..8df58c9 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -886,17 +886,17 @@ DeviceState *cpu_get_current_apic(void) } }

Re: [Qemu-devel] [PULL 00/14] SCSI updates for 2012-07-02

2012-07-10 Thread Paolo Bonzini
Il 10/07/2012 07:57, Hannes Reinecke ha scritto: This will make migration impossible not to mention the fact that casting a pointer to a uint64_t is really broken. Hey, this is _NOT_ an address. It's a simple way of generating a system-wide unique SAS address. The whole thing is

[Qemu-devel] [PATCH 4/5] qom-cpu: during cpu reset, it will reset its child

2012-07-10 Thread Liu Ping Fan
This will give the embeded logic module, such as apic has the opportunity to reset. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- qom/cpu.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/qom/cpu.c b/qom/cpu.c index 5b36046..6aea8e6 100644

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-10 Thread Paolo Bonzini
Il 10/07/2012 07:04, Wenchao Xia ha scritto: 于 2012-7-9 17:13, Paolo Bonzini 写道: Il 09/07/2012 10:54, Wenchao Xia ha scritto: Following is my implementing plan draft: 1 introduce libqblock.so in sub directory in qemu. 2 write a nbd client in libqblock, similar to qemu nbd client. Then

[Qemu-devel] [PATCH 1/5] qdev: introduce qdev_create_kid(Object *parent, const char *type)

2012-07-10 Thread Liu Ping Fan
DeviceState can be created as kid of DeviceState/CPUState, not neccesary attached to bus. This will be helpful to simulate the real hardware submodule which sits inside package. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/qdev.c | 28 hw/qdev.h |

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-10 Thread Paolo Bonzini
Il 10/07/2012 07:37, Wenchao Xia ha scritto: For getting the other metadata about the disk image you mention, another possibility to is just make 'qemu-img info' return the data in a machine parseable format, ie JSON make a client API for extracting data from this JSON document. Thank u

Re: [Qemu-devel] [PATCH] pseries: Add support for new KVM hash table control call

2012-07-10 Thread Benjamin Herrenschmidt
On Wed, 2012-06-27 at 22:10 +1000, Benjamin Herrenschmidt wrote: From: David Gibson da...@gibson.dropbear.id.au This adds support for then new reset htab ioctl which allows qemu to properly cleanup the MMU hash table when the guest is reset. With the corresponding kernel support, reset of a

Re: [Qemu-devel] [PATCH] megasas: disable due to build breakage

2012-07-10 Thread Gerd Hoffmann
On 07/10/12 01:18, Anthony Liguori wrote: The Buildbot has detected a new failure on builder default_i386_rhel61 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_i386_rhel61/builds/304 The proper fix is non-trivial so let's disable

Re: [Qemu-devel] [PATCH 23/25] fdc: Move floppy geometry guessing back from block.c

2012-07-10 Thread Kevin Wolf
Am 09.07.2012 19:01, schrieb Anthony Liguori: On 07/09/2012 11:46 AM, Eric Blake wrote: On 07/09/2012 10:07 AM, Markus Armbruster wrote: This is an unconditional use of fd_type[0]. If floppy == NULL, this is dereferencing an uninitialized value. I'm not sure why the explicit initialization

Re: [Qemu-devel] [PATCH 4/6] device_tree: Add support for reading device tree properties

2012-07-10 Thread Peter Maydell
On 10 July 2012 07:54, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: If user care about efficiency over safety, then your get_prop + cast + endian_swap approach will always be available to them. I just think a single idx arg at the end creates more options for users. We could vararg

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-10 Thread Kevin Wolf
Am 09.07.2012 19:35, schrieb Corey Bryant: On 07/09/2012 11:46 AM, Kevin Wolf wrote: Am 09.07.2012 17:05, schrieb Corey Bryant: I'm not sure this is an issue with current design. I know things have changed a bit as the email threads evolved, so I'll paste the current design that I am

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-10 Thread Kevin Wolf
Am 09.07.2012 20:40, schrieb Anthony Liguori: On 06/26/2012 04:10 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 02:36:07PM -0400, Corey Bryant wrote: libvirt's sVirt security driver provides SELinux MAC isolation for Qemu guest processes and their corresponding image files. In other

Re: [Qemu-devel] [PATCH 1/5] qdev: introduce qdev_create_kid(Object *parent, const char *type)

2012-07-10 Thread Andreas Färber
Am 10.07.2012 08:16, schrieb Liu Ping Fan: DeviceState can be created as kid of DeviceState/CPUState, not neccesary attached to bus. This will be helpful to simulate the real hardware submodule which sits inside package. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com ---

[Qemu-devel] [Bug 1018530] Re: No write access in a 9p/virtfs shared folder

2012-07-10 Thread Georg Poppe
qemu is running with user libvirt-qemu, not root. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1018530 Title: No write access in a 9p/virtfs shared folder Status in QEMU: New Status in

Re: [Qemu-devel] [PATCH] pseries: Add support for new KVM hash table control call

2012-07-10 Thread Benjamin Herrenschmidt
On Tue, 2012-07-10 at 17:25 +1000, Benjamin Herrenschmidt wrote: On Wed, 2012-06-27 at 22:10 +1000, Benjamin Herrenschmidt wrote: From: David Gibson da...@gibson.dropbear.id.au This adds support for then new reset htab ioctl which allows qemu to properly cleanup the MMU hash table when

Re: [Qemu-devel] [PATCH 0/3] apic: Fixes for userspace model

2012-07-10 Thread Avi Kivity
On 07/09/2012 05:42 PM, Jan Kiszka wrote: As Avi noted recently, there is a problem in way we inject interrupts into the userspace APIC under KVM: The TRP check over the iothread may race with the VCPU raising the TPR value while in KVM mode. Patch 3 addresses this issue. The other two

Re: [Qemu-devel] [PATCH 2/5] qom: introduce object_is_type_str(), so we can judge its type.

2012-07-10 Thread Paolo Bonzini
Il 10/07/2012 08:16, Liu Ping Fan ha scritto: Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- include/qemu/object.h |2 ++ qom/object.c |6 ++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/include/qemu/object.h b/include/qemu/object.h

Re: [Qemu-devel] [PATCH] megasas: Fix compilation for 32 bit hosts

2012-07-10 Thread Hannes Reinecke
On 07/10/2012 08:03 AM, Stefan Weil wrote: Am 10.07.2012 08:00, schrieb Hannes Reinecke: Hi Stefan, you might've seen that Anthony objected to this in general. Apparently I'm not allowed to use the instance address to seed the SAS address. So yes, your fix is valid, but might be pointless

Re: [Qemu-devel] [PATCH 3/5] qdev: export the bus reset interface

2012-07-10 Thread Paolo Bonzini
Il 10/07/2012 08:16, Liu Ping Fan ha scritto: Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/qdev.c | 17 - hw/qdev.h |2 ++ 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index d2100a1..f7983e4 100644 ---

Re: [Qemu-devel] [PATCH 4/5] qom-cpu: during cpu reset, it will reset its child

2012-07-10 Thread Paolo Bonzini
Il 10/07/2012 08:16, Liu Ping Fan ha scritto: This will give the embeded logic module, such as apic has the opportunity to reset. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- qom/cpu.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 5/5] apic: create apic as a child of cpu, not system_bus any longer

2012-07-10 Thread Paolo Bonzini
Il 10/07/2012 08:16, Liu Ping Fan ha scritto: Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/pc.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index c7e9ab3..8df58c9 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -886,17

Re: [Qemu-devel] [PATCH 1/5] qdev: introduce qdev_create_kid(Object *parent, const char *type)

2012-07-10 Thread Paolo Bonzini
Il 10/07/2012 08:16, Liu Ping Fan ha scritto: DeviceState can be created as kid of DeviceState/CPUState, not neccesary attached to bus. This will be helpful to simulate the real hardware submodule which sits inside package. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com ---

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-10 Thread Daniel P. Berrange
On Mon, Jul 09, 2012 at 04:00:37PM -0300, Luiz Capitulino wrote: On Mon, 09 Jul 2012 13:40:34 -0500 Anthony Liguori aligu...@us.ibm.com wrote: On 06/26/2012 04:10 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 02:36:07PM -0400, Corey Bryant wrote: libvirt's sVirt security driver

Re: [Qemu-devel] [RFC][PATCH v2 0/4] tcg: enhance code generation quality for qemu_ld/st IRs

2012-07-10 Thread Yeongkyoon Lee
On 2012년 07월 05일 22:23, Yeongkyoon Lee wrote: Summarized feature is as following. - All the changes are wrapped by macro CONFIG_QEMU_LDST_OPTIMIZATION and disabled by default. - They are enabled by configure --enable-ldst-optimization and need CONFIG_SOFTMMU. - They do not work with

[Qemu-devel] [PATCH v3 00/29] Disk geometry cleanup

2012-07-10 Thread Markus Armbruster
29 patches may look discouraging, but most patches are small, and the ones that aren't just move code around. Goals of this series: 1. One more step towards a clean separation block device host and guest part. 2. Purge CHS geometry from the block layer Part I[PATCH01/29]: Floppy

[Qemu-devel] [PATCH v3 16/29] scsi-hd: qdev properties for disk geometry

2012-07-10 Thread Markus Armbruster
Geometry needs to be qdev properties, because it belongs to the disk's guest part. Maintain backward compatibility exactly like for serial: fall back to DriveInfo's geometry, set with -drive cyls=... Do this only for scsi-hd. scsi-disk is legacy. scsi-cd doesn't have a geometry. scsi-block

Re: [Qemu-devel] [PATCH 3/9] isa: Add a way to query for a free interrupt

2012-07-10 Thread Paolo Bonzini
Il 09/07/2012 21:17, miny...@acm.org ha scritto: From: Corey Minyard cminy...@mvista.com This lets devices that don't care about their interrupt number, like IPMI, just grab any unused interrupt. I would try to avoid this. It is too dependent on the actual initialization order and command

Re: [Qemu-devel] [PATCH 5/9] IPMI: Add a PC ISA type structure

2012-07-10 Thread Paolo Bonzini
Il 09/07/2012 21:17, miny...@acm.org ha scritto: From: Corey Minyard cminy...@mvista.com This provides the base infrastructure to tie IPMI low-level interfaces into a PC ISA bus. Signed-off-by: Corey Minyard cminy...@mvista.com --- default-configs/i386-softmmu.mak |1 +

Re: [Qemu-devel] [PATCH 4/9] Add a base IPMI interface

2012-07-10 Thread Daniel P. Berrange
On Mon, Jul 09, 2012 at 02:17:04PM -0500, miny...@acm.org wrote: diff --git a/qemu-options.hx b/qemu-options.hx index 125a4da..823f6bc 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2204,6 +2204,41 @@ Three button serial mouse. Configure the guest to use Microsoft protocol. @end

[Qemu-devel] [PATCH v3 05/29] hd-geometry: Move disk geometry guessing back from block.c

2012-07-10 Thread Markus Armbruster
Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible, except it was put into block.c. Device-specific functionality should be kept in device code, not the block layer. Move it to hw/hd-geometry.c, and make stylistic changes required to keep checkpatch.pl happy. Signed-off-by: Markus

[Qemu-devel] [PATCH v3 23/29] qtest: Cover qdev property for BIOS CHS translation

2012-07-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- tests/hd-geo-test.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c index a47b945..5d9d2e4 100644 --- a/tests/hd-geo-test.c +++ b/tests/hd-geo-test.c @@ -321,15

[Qemu-devel] [PATCH v3 21/29] qdev: New property type chs-translation

2012-07-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qdev-properties.c | 15 +++ hw/qdev.h|3 +++ 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 002c7f9..0b18f8c 100644 ---

Re: [Qemu-devel] [PATCH 4/9] Add a base IPMI interface

2012-07-10 Thread Paolo Bonzini
Il 09/07/2012 21:17, miny...@acm.org ha scritto: + +/* Phyical interface types. */ +#define IPMI_KCS 1 +#define IPMI_BT 2 +#define IPMI_SMIC3 The code is not 100% consistent for values that are defined in hardware specs (enums are preferred for new code, but that's not

Re: [Qemu-devel] [PATCH 5/9] IPMI: Add a PC ISA type structure

2012-07-10 Thread Paolo Bonzini
Il 09/07/2012 21:17, miny...@acm.org ha scritto: + +static Property ipmi_isa_properties[] = { +DEFINE_PROP_HEX32(type, ISAIPMIState, type, IPMI_KCS), You can add an enum property. There is one example called LostTickPolicy in the tree. Please do not use the generic type name; use

Re: [Qemu-devel] First shot at adding IPMI to qemu

2012-07-10 Thread Paolo Bonzini
Il 09/07/2012 21:17, miny...@acm.org ha scritto: I had asked about getting an IPMI device into qemu and received some interest, and it's useful to me, so I've done some work to add it. The following patch set has a set of patches to add an IPMI KCS device, and IPMI BT device, a built-in BMC

[Qemu-devel] [PATCH v17 0/9] XBZRLE delta for live migration of large memory app

2012-07-10 Thread Orit Wasserman
Changes from v16: - Change QMP migrate_set_cachesize to migrate-set-cache-size Changes from v15: - Fix example in documentation - Fix identation in qmp-commands.hx - Fix missing comments from v13 - Fix other comments by Eric Blake Changes from v14:

[Qemu-devel] [PATCH v17 1/9] Add migration capabilities

2012-07-10 Thread Orit Wasserman
Add migration capabilities that can be queried by the management. The management can query the source QEMU and the destination QEMU in order to verify both support some migration capability (currently only XBZRLE). The management can enable a capability for the next migration by using

[Qemu-devel] [PATCH v17 4/9] Add uleb encoding/decoding functions

2012-07-10 Thread Orit Wasserman
Implement Unsigned Little Endian Base 128. Signed-off-by: Orit Wasserman owass...@redhat.com --- cutils.c | 33 + qemu-common.h |8 2 files changed, 41 insertions(+), 0 deletions(-) diff --git a/cutils.c b/cutils.c index b0bdd4b..700f943

[Qemu-devel] [PATCH v17 6/9] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-07-10 Thread Orit Wasserman
For performance we are encoding long word at a time. For nzrun we use long-word-at-a-time NULL-detection tricks from strcmp(): using ((lword - 0x0101010101010101) (~lword) 0x8080808080808080) test to find out if any byte in the long word is zero. Signed-off-by: Benoit Hudzia

[Qemu-devel] [PATCH v17 8/9] Add migrate_set_cachesize command

2012-07-10 Thread Orit Wasserman
Change XBZRLE cache size in bytes (the size should be a power of 2, it will be rounded down to the nearest power of 2). If XBZRLE cache size is too small there will be many cache miss. Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard pett...@cs.umu.se Signed-off-by:

[Qemu-devel] [PATCH v17 7/9] Add XBZRLE to ram_save_block and ram_save_live

2012-07-10 Thread Orit Wasserman
In the outgoing migration check to see if the page is cached and changed than send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_SAVE_FLAG_XBZRLE is set and decompress the page (by using load_xbrle function). Signed-off-by: Benoit Hudzia

[Qemu-devel] [PATCH v3 11/29] hd-geometry: Cut out block layer translation middleman

2012-07-10 Thread Markus Armbruster
hd_geometry_guess() picks geometry and translation. Callers can get the geometry directly, via parameters, but for translation they need to go through the block layer. Add a parameter for translation, so it can optionally be gotten just like geometry. In preparation of purging translation from

[Qemu-devel] [PATCH v3 12/29] ide pc: Cut out the block layer geometry middleman

2012-07-10 Thread Markus Armbruster
PC BIOS setup needs IDE geometry information. Get it directly from the device model rather than through the block layer. In preparation of purging geometry from the block layer, which will happen later in this series. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide.h |

[Qemu-devel] [PATCH v17 3/9] Add cache handling functions

2012-07-10 Thread Orit Wasserman
Add LRU page cache mechanism. The page are accessed by their address. Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard pett...@cs.umu.se Signed-off-by: Aidan Shribman aidan.shrib...@sap.com Signed-off-by: Orit Wasserman owass...@redhat.com --- Makefile.objs |1 +

[Qemu-devel] [PATCH v3 17/29] virtio-blk: qdev properties for disk geometry

2012-07-10 Thread Markus Armbruster
Geometry needs to be qdev properties, because it belongs to the disk's guest part. Maintain backward compatibility exactly like for serial: fall back to DriveInfo's geometry, set with -drive cyls=... Bonus: info qtree now shows the geometry. Signed-off-by: Markus Armbruster arm...@redhat.com

[Qemu-devel] [PATCH v3 10/29] hd-geometry: Clean up confusing use of prior translation hint

2012-07-10 Thread Markus Armbruster
When hd_geometry_guess() picks a geometry, it also picks the appropriate translation, but only when the prior translation hint is BIOS_ATA_TRANSLATION_AUTO. Looks wrong, because such a prior translation would be passed to the BIOS whether it's suitable for the geometry or not. Fortunately, that

[Qemu-devel] [PATCH v3 25/29] ide pc: Put hard disk info into CMOS only for hard disks

2012-07-10 Thread Markus Armbruster
In particular, don't set disk type and geometry when a CD-ROM on bus ide.0 has media during CMOS initialization. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/qdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c index

[Qemu-devel] [PATCH v3 19/29] qtest: Cover qdev properties for disk geometry

2012-07-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- tests/hd-geo-test.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c index cc447a2..a47b945 100644 --- a/tests/hd-geo-test.c +++ b/tests/hd-geo-test.c @@ -321,13 +321,15

[Qemu-devel] [PATCH v3 01/29] fdc: Move floppy geometry guessing back from block.c

2012-07-10 Thread Markus Armbruster
Commit 5bbdbb46 moved it to block.c because other geometry guessing functions already reside in block.c. Device-specific functionality should be kept in device code, not the block layer. Move it back. Disk geometry guessing is still in block.c. To be moved out in a later patch series. Bonus:

[Qemu-devel] [PATCH v3 20/29] qdev: Collect private helpers in one place

2012-07-10 Thread Markus Armbruster
Just code motion, with one long line wrapped to keep checkpatch.pl happy. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qdev-properties.c | 144 +- 1 files changed, 72 insertions(+), 72 deletions(-) diff --git a/hw/qdev-properties.c

[Qemu-devel] [PATCH v3 15/29] hd-geometry: Switch to uint32_t to match BlockConf

2012-07-10 Thread Markus Armbruster
Best to use the same type, to avoid unwanted truncation or sign extension. BlockConf can't use plain int for cyls, heads and secs, because integer properties require an exact width. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/block-common.h |2 +- hw/hd-geometry.c |4 ++--

Re: [Qemu-devel] [PATCH 4/5] qom-cpu: during cpu reset, it will reset its child

2012-07-10 Thread Andreas Färber
Am 10.07.2012 10:41, schrieb Paolo Bonzini: Il 10/07/2012 08:16, Liu Ping Fan ha scritto: This will give the embeded logic module, such as apic has the opportunity to reset. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- qom/cpu.c | 16 1 files changed, 16

Re: [Qemu-devel] [PATCH V2] Use clean shutdown request for ctrl-a x

2012-07-10 Thread Fabien Chouteau
On 07/09/2012 02:18 PM, Andreas Färber wrote: Am 09.07.2012 12:19, schrieb Fabien Chouteau: Any comment? On 07/04/2012 01:04 PM, Fabien Chouteau wrote: The goal is to make ctrl-a x to close Qemu in a clean way. The current exit(0) skips a lot of cleanup/close functions, for example in block

[Qemu-devel] [PATCH v3 26/29] qtest: Test we don't put hard disk info into CMOS for a CD-ROM

2012-07-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- tests/hd-geo-test.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c index 5d9d2e4..9a31e85 100644 --- a/tests/hd-geo-test.c +++ b/tests/hd-geo-test.c @@

[Qemu-devel] [PATCH v17 2/9] Add XBZRLE documentation

2012-07-10 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- docs/xbzrle.txt | 136 +++ 1 files changed, 136 insertions(+), 0 deletions(-) create mode 100644 docs/xbzrle.txt diff --git a/docs/xbzrle.txt b/docs/xbzrle.txt new file mode 100644 index

[Qemu-devel] [PATCH v3 18/29] ide: qdev properties for disk geometry

2012-07-10 Thread Markus Armbruster
Geometry needs to be qdev properties, because it belongs to the disk's guest part. Maintain backward compatibility exactly like for serial: fall back to DriveInfo's geometry, set with -drive cyls=... Do this only for ide-hd. ide-drive is legacy. ide-cd doesn't have a geometry. Bonus: info

[Qemu-devel] [PATCH v3 08/29] hd-geometry: Factor out guess_chs_for_size()

2012-07-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/hd-geometry.c | 32 1 files changed, 20 insertions(+), 12 deletions(-) diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c index db47846..1a58894 100644 --- a/hw/hd-geometry.c +++ b/hw/hd-geometry.c @@

Re: [Qemu-devel] KVM call agenda for Tuesday, July 10th

2012-07-10 Thread Andreas Färber
Hi, Am 09.07.2012 22:37, schrieb Juan Quintela: Please send in any agenda items you are interested in covering. Steps towards CPU hotplug: * how to model CPUState as a DeviceState * coordination of APIC-related x86 CPU remodelling Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5,

Re: [Qemu-devel] [PATCH] pseries: Add support for new KVM hash table control call

2012-07-10 Thread Alexander Graf
On 10.07.2012, at 10:16, Benjamin Herrenschmidt wrote: On Tue, 2012-07-10 at 17:25 +1000, Benjamin Herrenschmidt wrote: On Wed, 2012-06-27 at 22:10 +1000, Benjamin Herrenschmidt wrote: From: David Gibson da...@gibson.dropbear.id.au This adds support for then new reset htab ioctl which

[Qemu-devel] [PATCH v3 22/29] ide: qdev property for BIOS CHS translation

2012-07-10 Thread Markus Armbruster
This isn't quite orthodox. CHS translation is firmware configuration, communicated via the RTC's CMOS RAM, not a property of the disk. But it's best to treat it just like geometry anyway. Maintain backward compatibility exactly like for geometry: fall back to DriveInfo's translation, set with

[Qemu-devel] [PATCH v3 24/29] block: Geometry and translation hints are now useless, purge them

2012-07-10 Thread Markus Armbruster
There are two producers of these hints: drive_init() on behalf of -drive, and hd_geometry_guess(). The only consumer of the hint is hd_geometry_guess(). The callers of hd_geometry_guess() call it only when drive_init() didn't set the hints. Therefore, drive_init()'s hints are never used. Thus,

[Qemu-devel] [PATCH v3 27/29] hd-geometry: Compute BIOS CHS translation in one place

2012-07-10 Thread Markus Armbruster
Currently, it is split between hd_geometry_guess() and pc_cmos_init_late(). Confusing. info qtree shows the result of the former. Also confusing. Fold the part done in pc_cmos_init_late() into hd_geometry_guess(). Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/block-common.h |

[Qemu-devel] [PATCH v17 5/9] Change ram_save_block to return -1 if there are no more changes

2012-07-10 Thread Orit Wasserman
It will return 0 if the page is unmodifed. Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/arch_init.c b/arch_init.c index 5b0f562..91e583f 100644 --- a/arch_init.c +++ b/arch_init.c @@ -188,7

[Qemu-devel] [PATCH v3 02/29] vvfat: Fix partition table

2012-07-10 Thread Markus Armbruster
Unless parameter :floppy: is given, vvfat creates a virtual image with DOS MBR defining a single partition which holds the FAT file system. The size of the virtual image depends on the width of the FAT: 32 MiB (CHS 64, 16, 63) for 12 bit FAT, 504 MiB (CHS 1024, 16, 63) for 16 and 32 bit FAT,

[Qemu-devel] [PATCH v3 28/29] blockdev: Drop redundant CHS validation for if=ide

2012-07-10 Thread Markus Armbruster
Leave it to ide_init_drive(). Signed-off-by: Markus Armbruster arm...@redhat.com --- blockdev.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 06c997e..5f8677e 100644 --- a/blockdev.c +++ b/blockdev.c @@ -330,15 +330,15 @@ DriveInfo

Re: [Qemu-devel] [PATCH 5/5] apic: create apic as a child of cpu, not system_bus any longer

2012-07-10 Thread Andreas Färber
Am 10.07.2012 10:45, schrieb Paolo Bonzini: Il 10/07/2012 08:16, Liu Ping Fan ha scritto: Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/pc.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index c7e9ab3..8df58c9 100644

Re: [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access

2012-07-10 Thread Jan Kiszka
On 2012-07-02 11:07, Avi Kivity wrote: On 06/29/2012 07:37 PM, Jan Kiszka wrote: Instead of flushing pending coalesced MMIO requests on every vmexit, this provides a mechanism to selectively flush when memory regions related to the coalesced one are accessed. This first of all includes the

[Qemu-devel] [PATCH v3 03/29] vvfat: Do not clobber the user's geometry

2012-07-10 Thread Markus Armbruster
vvfat creates a virtual VFAT filesystem with a certain logical geometry that depends on its options. It sets the geometry hint to this geometry. It is the only block driver to do this. The geometry hint is about about *physical* geometry, and used only by certain hard disk device models.

[Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-10 Thread Fabien Chouteau
Bridge helper uses ioctl's not available on old Linux versions, we add this flag to disable the build. Signed-off-by: Fabien Chouteau chout...@adacore.com --- Makefile |2 +- configure |8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-10 Thread Paolo Bonzini
Il 10/07/2012 12:43, Fabien Chouteau ha scritto: Bridge helper uses ioctl's not available on old Linux versions, we add this flag to disable the build. Which ioctls? Please detect them, so that we can also work around them perhaps. Paolo

[Qemu-devel] [PATCH v3 07/29] hd-geometry: Unnest conditional in hd_geometry_guess()

2012-07-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/hd-geometry.c | 84 +++--- 1 files changed, 42 insertions(+), 42 deletions(-) diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c index f0dd021..db47846 100644 --- a/hw/hd-geometry.c +++

[Qemu-devel] [PATCH v3 04/29] qtest: Add hard disk geometry test

2012-07-10 Thread Markus Armbruster
So far covers only IDE and tests only CMOS contents. Signed-off-by: Markus Armbruster arm...@redhat.com --- tests/Makefile |2 + tests/hd-geo-test.c | 403 +++ 2 files changed, 405 insertions(+), 0 deletions(-) create mode 100644

[Qemu-devel] [PATCH v3 14/29] qdev: Introduce block geometry properties

2012-07-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- block.h |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/block.h b/block.h index 993894e..1cd8a01 100644 --- a/block.h +++ b/block.h @@ -426,6 +426,8 @@ typedef struct BlockConf { uint32_t opt_io_size;

[Qemu-devel] [PATCH v3 13/29] blockdev: Save geometry in DriveInfo

2012-07-10 Thread Markus Armbruster
In preparation of purging it from the block layer, which will happen later in this series. Signed-off-by: Markus Armbruster arm...@redhat.com --- blockdev.c |4 blockdev.h |1 + 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index

[Qemu-devel] [PATCH v3 06/29] hd-geometry: Add tracepoints

2012-07-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/hd-geometry.c |7 +++ trace-events |4 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c index c45eafd..f0dd021 100644 --- a/hw/hd-geometry.c +++ b/hw/hd-geometry.c @@

[Qemu-devel] [PATCH] uhci: initialize expire_time when loading v1 vmstate

2012-07-10 Thread Gerd Hoffmann
$subject says all: when loading old (v1) vmstate which doesn't contain expire_time initialize it with a reasonable default (current time). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-uhci.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v3] sheepdog: do not blindly memset all read buffers

2012-07-10 Thread Kevin Wolf
Am 09.07.2012 20:23, schrieb MORITA Kazutaka: At Mon, 9 Jul 2012 16:34:13 +0200, Christoph Hellwig wrote: Only buffers that map to unallocated blocks need to be zeroed. Signed-off-by: Christoph Hellwig h...@lst.de --- block/sheepdog.c | 37 ++--- 1 file

[Qemu-devel] [PATCH v3 29/29] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255

2012-07-10 Thread Markus Armbruster
New limits straight from ATA4 6.2 Register delivered data transfer command sector addressing. I figure the old sector limit 63 was blindly copied from the BIOS int 13 limit. Doesn't apply to the hardware. No idea where the old cylinder limit comes from. Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-10 Thread Fabien Chouteau
On 07/10/2012 12:44 PM, Paolo Bonzini wrote: Il 10/07/2012 12:43, Fabien Chouteau ha scritto: Bridge helper uses ioctl's not available on old Linux versions, we add this flag to disable the build. Which ioctls? Please detect them, so that we can also work around them perhaps. There

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-10 Thread Paolo Bonzini
Il 10/07/2012 13:02, Fabien Chouteau ha scritto: Bridge helper uses ioctl's not available on old Linux versions, we add this flag to disable the build. Which ioctls? Please detect them, so that we can also work around them perhaps. There SIOCBRADDIF at least, maybe it's the only

[Qemu-devel] [PATCH v3 09/29] hd-geometry: Clean up gratuitous goto in hd_geometry_guess()

2012-07-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/hd-geometry.c | 22 -- 1 files changed, 8 insertions(+), 14 deletions(-) diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c index 1a58894..fb849a3 100644 --- a/hw/hd-geometry.c +++ b/hw/hd-geometry.c @@ -119,8 +119,7

Re: [Qemu-devel] [PATCH 4/9] Add a base IPMI interface

2012-07-10 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Mon, Jul 09, 2012 at 02:17:04PM -0500, miny...@acm.org wrote: diff --git a/qemu-options.hx b/qemu-options.hx index 125a4da..823f6bc 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2204,6 +2204,41 @@ Three button serial mouse.

[Qemu-devel] [PATCH v17 9/9] Add XBZRLE statistics

2012-07-10 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard pett...@cs.umu.se Signed-off-by: Aidan Shribman aidan.shrib...@sap.com Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 66 ++ hmp.c

[Qemu-devel] [PATCH] Fix xen pci passthrough

2012-07-10 Thread Wei Wang
Hi, I find a passthrough issue in qemu when pci device has multiple mmio regions. In this case, the last few bytes of qmp response string are trimmed and then passthru fails with following output. *** glibc detected *** xl: realloc(): invalid pointer: 0x02163f90 *** === Backtrace:

[Qemu-devel] [PATCH] hw/imx_avic.c: Avoid format error when target_phys_addr_t is 64 bits

2012-07-10 Thread Peter Maydell
Add a missing cast to avoid gcc complaining about format string errors when printing an expression based on a target_phys_addr_t. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/imx_avic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/imx_avic.c

Re: [Qemu-devel] [PULL 00/14] SCSI updates for 2012-07-02

2012-07-10 Thread Anthony Liguori
On 07/10/2012 12:57 AM, Hannes Reinecke wrote: On 07/10/2012 01:19 AM, Anthony Liguori wrote: On 07/09/2012 06:09 PM, Alexander Graf wrote: On 09.07.2012, at 18:48, Anthony Liguori wrote: On 07/02/2012 04:41 AM, Paolo Bonzini wrote: Anthony, The following changes since commit

Re: [Qemu-devel] [PULL 00/14] SCSI updates for 2012-07-02

2012-07-10 Thread Hannes Reinecke
On 07/10/2012 02:52 PM, Anthony Liguori wrote: On 07/10/2012 12:57 AM, Hannes Reinecke wrote: On 07/10/2012 01:19 AM, Anthony Liguori wrote: On 07/09/2012 06:09 PM, Alexander Graf wrote: On 09.07.2012, at 18:48, Anthony Liguori wrote: On 07/02/2012 04:41 AM, Paolo Bonzini wrote: Anthony,

Re: [Qemu-devel] [PATCH 4/6] device_tree: Add support for reading device tree properties

2012-07-10 Thread Peter Maydell
On 10 July 2012 07:54, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: Constantly bouncing back is safer however. If you hang on to an in-place pointer into the FDT (as returned by get_prop) and someone comes along and set_props() then your pointer is corrupted. Ive been snagged

Re: [Qemu-devel] [PATCH] Fix xen pci passthrough

2012-07-10 Thread Anthony PERARD
On 10/07/12 12:43, Wei Wang wrote: Hi, I find a passthrough issue in qemu when pci device has multiple mmio regions. In this case, the last few bytes of qmp response string are trimmed and then passthru fails with following output. Could you compile libxl with DEBUG_RECEIVED (uncomment the

[Qemu-devel] [PATCH 1/2] target-i386: move cpu halted decision into x86_cpu_reset

2012-07-10 Thread Igor Mammedov
MP initialization protocol differs between cpu families, and for P6 and onward models it is up to CPU to decide if it will be BSP using this protocol, so try to model this. However there is no point in implementing MP initialization protocol in qemu. Thus first CPU is always marked as BSP. This

[Qemu-devel] [PATCH 0/2 v2] target-i386: refactor reset handling and move it into cpu.c

2012-07-10 Thread Igor Mammedov
v2: ommited moving of x86_cpu_realize() from cpu_x86_init() to pc_new_cpu(), to keep cpu_init implementation in -softmmu and -user targets the same in single place and maintanable. tree for testing: https://github.com/imammedo/qemu/tree/x86_reset comiple run tested with

[Qemu-devel] [PATCH 2/2] target-i386: move cpu_reset and reset callback to cpu.c

2012-07-10 Thread Igor Mammedov
Moving reset callback into cpu object from board level and resetting cpu at the end of x86_cpu_realize() will allow properly create cpu object during run-time (hotplug) without calling reset exteraly. When reset over QOM hierarchy is implemented, reset callback should be removed. v2: leave

  1   2   3   >