Re: [Qemu-devel] [Bug 893956] Re: qemu-img bug with dynamic vhd

2012-09-04 Thread Stefan Hajnoczi
On Mon, Sep 3, 2012 at 10:41 AM, franxico <893...@bugs.launchpad.net> wrote: > Hi, > > I'm having the same problem. I'm using qemu-img 1.0, running from a > Ubuntu Server 12.04 x64 on a SW RAID, ext4. > > The .VHD has 29GB and was made using disk2vhd. > > Here is the command and the results: > sudo

Re: [Qemu-devel] boot device order has no effect for virtio-scsi devices

2012-09-04 Thread Paolo Bonzini
Il 05/09/2012 00:13, ching ha scritto: >>> Ah, ok. libvirt for now supports only booting from LUN 0. You can use ^^^ Oops, should have been SeaBIOS. >>> multiple targets instead of multiple units. >>> >>> Paolo >>> >>> >> it works. thanks a lot. >>

Re: [Qemu-devel] [Bug 893956] Re: qemu-img bug with dynamic vhd

2012-09-04 Thread Stefan Hajnoczi
On Tue, Sep 4, 2012 at 4:00 PM, Serge Hallyn <893...@bugs.launchpad.net> wrote: > Though that commit and the comments were about 127G images. HIs is only > 27G. The 127 GB limit applies to the virtual disk size, not to the size of the image file itself. > Also, 'qemu-img info' is also showing th

Re: [Qemu-devel] [PATCH] Versatile Express: add modelling of NOR flash

2012-09-04 Thread Stefan Weil
Am 04.09.2012 19:08, schrieb Francesco Lavra: This patch adds modelling of the two NOR flash banks found in the Versatile Express motherboard. Tested with U-Boot running on an emulated Versatile Express A9. The alias of the first NOR flash in the Cortex-A Series memory map is not modelled. Signe

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Matthew Ogilvie
On Tue, Sep 04, 2012 at 04:42:35PM +0200, Paolo Bonzini wrote: > Il 04/09/2012 16:29, Maciej W. Rozycki ha scritto: > > So first of all, the *output* of the 8259A is always edge triggered, > > regardless of whether it's the master or one of the slaves (only one slave > > is used in the PC/AT arc

Re: [Qemu-devel] [PATCH 02/21] target-s390x: split FPU ops

2012-09-04 Thread Alexander Graf
On 04.09.2012, at 18:03, Richard Henderson wrote: > On 09/04/2012 12:40 PM, Blue Swirl wrote: >> On Tue, Sep 4, 2012 at 6:42 PM, Richard Henderson wrote: >>> On 09/02/2012 10:33 AM, Blue Swirl wrote: +/* fpu_helper.c */ +uint32_t set_cc_f32(float32 v1, float32 v2); +uint32_t set_c

Re: [Qemu-devel] [PATCH v2] ahci: properly reset PxCMD on HBA reset

2012-09-04 Thread Alexander Graf
On 04.09.2012, at 16:08, Jason Baron wrote: > While testing q35, I found that windows 7 (specifically, windows 7 ultimate > with sp1 x64), wouldn't install because it can't find the cdrom or disk drive. > The failure message is: 'A required cd/dvd device driver is missing. If you > have a driver

Re: [Qemu-devel] boot device order has no effect for virtio-scsi devices

2012-09-04 Thread ching
On 09/04/2012 07:55 PM, Eric Blake wrote: > On 09/04/2012 04:53 AM, ching wrote: >> On 09/04/2012 02:23 PM, Paolo Bonzini wrote: >>> Il 04/09/2012 02:03, ching ha scritto: i add boot order and the virtual machine still boot from hard disk instead of cd-rom

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-09-04 Thread Amos Kong
On Thu, Aug 30, 2012 at 12:04 AM, Amos Kong wrote: > On Wed, Aug 29, 2012 at 11:15 PM, Amos Kong wrote: > > On Thu, Feb 23, 2012 at 4:15 PM, Markus Armbruster > wrote: > >> > >> Anthony Liguori writes: > >> > >> > On 02/15/2012 07:33 AM, Markus Armbruster wrote: > >> >> Anthony Liguori writes

[Qemu-devel] [PATCH V9 6/8] hw/serial.c: replace register_ioport*

2012-09-04 Thread Julien Grall
This patch replaces all register_ioport* with a MemoryRegion. It permits to use the new Memory stuff like listener. For more flexibility, the IO address space is passed as an argument. Signed-off-by: Julien Grall --- hw/mips_mipssim.c |3 ++- hw/pc.h |2 +- hw/serial.c |

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Maciej W. Rozycki
On Tue, 4 Sep 2012, Jan Kiszka wrote: > >> What I'm trying to understand and translate from the description is > >> rather "note that for inputs a high-to-low transition cancels the > >> interrupt as in the level-triggered mode." This is surely not what we do > >> right now. OTOH, I'm afraid that

[Qemu-devel] [PATCH V9 8/8] hw/dma.c: replace register_ioport*

2012-09-04 Thread Julien Grall
This patch replaces all register_ioport* be the new memory API functions. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/dma.c | 108 + 1 files changed, 72 insertions(+), 36 deletions(-) diff

[Qemu-devel] [PATCH] Versatile Express: add modelling of NOR flash

2012-09-04 Thread Francesco Lavra
This patch adds modelling of the two NOR flash banks found in the Versatile Express motherboard. Tested with U-Boot running on an emulated Versatile Express A9. The alias of the first NOR flash in the Cortex-A Series memory map is not modelled. Signed-off-by: Francesco Lavra --- hw/vexpress.c |

[Qemu-devel] [PATCH V9 1/8] isa: add isa_address_space_io

2012-09-04 Thread Julien Grall
This function permits to retrieve ISA IO address space. It will be usefull when we need to pass IO address space as argument. Signed-off-by: Julien Grall --- hw/isa-bus.c |9 + hw/isa.h |1 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/isa-bus.c b/hw/is

[Qemu-devel] [Bug 1044727] Re: -kernel does not work for multiboot ELF kernels

2012-09-04 Thread Kevin Wolf
Henning, please submit your patch to the qemu-devel mailing list. See http://wiki.qemu.org/Contribute/SubmitAPatch for more details on how patch submission works for qemu. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.l

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Maciej W. Rozycki
On Mon, 3 Sep 2012, Jan Kiszka wrote: > > - Qemu output (without this patch): > > elcr=0c00 cmdRead ummask mask sti irq15 unmask DONE > > > > But on real hardware, the master seems to treat IRQ2 as level triggered, That is not universally true, however in reality it does not matter, m

[Qemu-devel] [PATCH V9 0/8] memory: unify ioport registration

2012-09-04 Thread Julien Grall
This is the nineth version of patch series about ioport registration. Some part of QEMU still use register_ioport* functions to register ioport. These functions doesn't allow to use Memory Listener on it. Modifications between V1 and V2: - Remove the use of get_system_io. Instead of use isa an

[Qemu-devel] [PATCH V9 2/8] hw/apm.c: replace register_ioport*

2012-09-04 Thread Julien Grall
This patch replaces all register_ioport* by a MemorySection. It permits to use the new Memory stuff like listener. Moreover, the PCI is added as an argument for apm_init, so we can register IO inside the pci IO address space. Signed-off-by: Julien Grall --- hw/acpi_piix4.c |2 +- hw/apm.c

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Maciej W. Rozycki
On Tue, 4 Sep 2012, Jan Kiszka wrote: > What I'm trying to understand and translate from the description is > rather "note that for inputs a high-to-low transition cancels the > interrupt as in the level-triggered mode." This is surely not what we do > right now. OTOH, I'm afraid that switching to

[Qemu-devel] Help needed to run Exynos 4210 linux kernel on qemu?

2012-09-04 Thread Jean-Christophe DUBOIS
Hi, I am trying to run linux over qemu-system-arm emulating a nuri or smdkc210 Exynos 4210 based board. To do this I fetched the last qemu (from git://git.qemu.org/qemu.git) and built it with "./configure --target-list=arm-softmmu. Then I fetched the latest linux image for samsung processor

[Qemu-devel] [PATCH V9 7/8] hw/pc.c: replace register_ioport*

2012-09-04 Thread Julien Grall
This patch replaces all register_ioport* with portio_* or isa_register_portio_list. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/pc.c | 58 +++--- 1 files changed, 43 insertions(+), 15 deletions(-)

[Qemu-devel] [PATCH V9 3/8] smb: replace_register_ioport*

2012-09-04 Thread Julien Grall
This patch fix smb_ioport_* to be compliant with read/write memory callback. Moreover it replaces all register_ioport* which use theses functions by the new Memory API. Signed-off-by: Julien Grall --- hw/acpi_piix4.c | 18 -- hw/pm_smbus.c |7 --- hw/pm_smbus.h |

[Qemu-devel] [PATCH V9 4/8] hw/acpi_piix4.c: replace register_ioport*

2012-09-04 Thread Julien Grall
This patch replaces all register_ioport* with the new memory API. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/acpi_piix4.c | 145 +++ 1 files changed, 113 insertions(+), 32 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 02/21] target-s390x: split FPU ops

2012-09-04 Thread Richard Henderson
On 09/04/2012 12:40 PM, Blue Swirl wrote: > On Tue, Sep 4, 2012 at 6:42 PM, Richard Henderson wrote: >> On 09/02/2012 10:33 AM, Blue Swirl wrote: >>> +/* fpu_helper.c */ >>> +uint32_t set_cc_f32(float32 v1, float32 v2); >>> +uint32_t set_cc_f64(float64 v1, float64 v2); >>> +uint32_t set_cc_nz_f32(

Re: [Qemu-devel] [PATCH V9 0/8] memory: unify ioport registration

2012-09-04 Thread Julien Grall
My apologies for this double post, I made a typing error on Jan's email. On 09/04/2012 04:13 PM, Julien Grall wrote: This is the nineth version of patch series about ioport registration. Some part of QEMU still use register_ioport* functions to register ioport. These functions doesn't allow to

[Qemu-devel] [PATCH V9 5/8] hw/cirrus_vga.c: replace register_ioport*

2012-09-04 Thread Julien Grall
This patch replaces all register_ioport* with portio_*. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/cirrus_vga.c | 50 ++ 1 files changed, 30 insertions(+), 20 deletions(-) diff --git a/hw/cirrus_vga.

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-04 Thread Michael S. Tsirkin
On Tue, Sep 04, 2012 at 07:27:32PM +, Blue Swirl wrote: > On Tue, Sep 4, 2012 at 8:32 AM, Avi Kivity wrote: > > On 09/03/2012 10:32 PM, Blue Swirl wrote: > >> On Mon, Sep 3, 2012 at 4:14 PM, Avi Kivity wrote: > >>> On 08/29/2012 11:27 AM, Markus Armbruster wrote: > > I don't see a p

[Qemu-devel] [PATCH 2/2] slirp: Fix error reported by static code analysis

2012-09-04 Thread Stefan Weil
Report from smatch: slirp/tcp_subr.c:127 tcp_respond(17) error: we previously assumed 'tp' could be null (see line 124) Return if 'tp' is NULL. Signed-off-by: Stefan Weil --- slirp/tcp_subr.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp/tcp_subr.c b/slirp/tcp_s

[Qemu-devel] [PATCH 1/2] slirp: Remove wrong type casts ins debug statements

2012-09-04 Thread Stefan Weil
The type casts of pointers to long are not allowed when sizeof(pointer) != sizeof(long). Signed-off-by: Stefan Weil --- slirp/tcp_subr.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c index 025b374..5890d7a 100644 --- a/slirp/tcp_

[Qemu-devel] [PATCH 0/2] slirp fixes

2012-09-04 Thread Stefan Weil
These patches replace http://patchwork.ozlabs.org/patch/181411/. I modified the code as suggested by Jan Kiska and separated the original patch in two patches. [PATCH 1/2] slirp: Remove wrong type casts ins debug statements [PATCH 2/2] slirp: Fix error reported by static code analysis Regards,

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-04 Thread Anthony Liguori
Andreas Färber writes: > Am 28.08.2012 14:57, schrieb Anthony Liguori: >> Andreas Färber writes: >> >>> Hi, >>> >>> Am 27.08.2012 08:28, schrieb Jan Kiszka: From: Jan Kiszka This adds PCI device assignment for i386 targets using the classic KVM interfaces. This version is 1

Re: [Qemu-devel] [PATCH] hw/xics: Fix one-bit signed bitfields

2012-09-04 Thread Peter Maydell
On 4 September 2012 21:30, Stefan Weil wrote: > Report from smatch: > > xics.c:169:19: error: dubious one-bit signed bitfield > xics.c:170:15: error: dubious one-bit signed bitfield > xics.c:171:19: error: dubious one-bit signed bitfield > xics.c:172:25: error: dubious one-bit signed bitfield > >

Re: [Qemu-devel] [PATCH 3/3] target-arm: final conversion to AREG0 free mode

2012-09-04 Thread Peter Maydell
On 4 September 2012 21:37, Blue Swirl wrote: > Convert code load functions and switch to AREG0 free mode. > > Signed-off-by: Blue Swirl Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH 2/3] target-arm: convert remaining helpers

2012-09-04 Thread Peter Maydell
On 4 September 2012 21:37, Blue Swirl wrote: > Convert remaining helpers to AREG0 free mode: add an explicit > CPUState parameter instead of relying on AREG0. > > Signed-off-by: Blue Swirl Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH 1/3] target-arm: convert void helpers

2012-09-04 Thread Peter Maydell
On 4 September 2012 21:37, Blue Swirl wrote: > Add an explicit CPUState parameter instead of relying on AREG0. > > For easier review, convert only op helpers which don't return any value. > > Signed-off-by: Blue Swirl Reviewed-by: Peter Maydell Thanks for splitting these up, it helped a lot.

Re: [Qemu-devel] [PATCH] linux-user: Remove redundant null check and replace free by g_free

2012-09-04 Thread Peter Maydell
On 4 September 2012 21:14, Stefan Weil wrote: > Report from smatch: > > linux-user/syscall.c:3632 do_ioctl_dm(220) info: > redundant null check on big_buf calling free() > > 'big_buf' was allocated by g_malloc0, therefore free was also > replaced by g_free. > > Signed-off-by: Stefan Weil Review

[Qemu-devel] [PATCH 3/3] target-arm: final conversion to AREG0 free mode

2012-09-04 Thread Blue Swirl
Convert code load functions and switch to AREG0 free mode. Signed-off-by: Blue Swirl --- configure|2 +- target-arm/Makefile.objs |2 -- target-arm/cpu.h | 10 ++ target-arm/helper.c |9 + target-arm/op_helper.c |8 +--- target

[Qemu-devel] [PATCH 2/3] target-arm: convert remaining helpers

2012-09-04 Thread Blue Swirl
Convert remaining helpers to AREG0 free mode: add an explicit CPUState parameter instead of relying on AREG0. Signed-off-by: Blue Swirl --- target-arm/helper.h| 52 +- target-arm/op_helper.c | 64 +++--- target-arm/translate.c | 134 ++

[Qemu-devel] [PATCH 1/3] target-arm: convert void helpers

2012-09-04 Thread Blue Swirl
Add an explicit CPUState parameter instead of relying on AREG0. For easier review, convert only op helpers which don't return any value. Signed-off-by: Blue Swirl --- target-arm/helper.h|8 target-arm/op_helper.c | 20 ++-- target-arm/translate.c |8 --

[Qemu-devel] [PATCH] hw/xics: Fix one-bit signed bitfields

2012-09-04 Thread Stefan Weil
Report from smatch: xics.c:169:19: error: dubious one-bit signed bitfield xics.c:170:15: error: dubious one-bit signed bitfield xics.c:171:19: error: dubious one-bit signed bitfield xics.c:172:25: error: dubious one-bit signed bitfield Instead of replacing 'int' by 'unsigned', 'bool' was used bec

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.2.0-rc3 release

2012-09-04 Thread Anthony Liguori
Blue Swirl writes: > On Tue, Sep 4, 2012 at 7:42 PM, Peter Maydell > wrote: >> On 4 September 2012 20:29, Blue Swirl wrote: >>> On Tue, Sep 4, 2012 at 12:54 PM, Anthony Liguori >>> wrote: The release plan for the 1.2 release is available at: http://wiki.qemu.org/Planning/1.2 >

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.2.0-rc3 release

2012-09-04 Thread Anthony Liguori
Blue Swirl writes: > On Tue, Sep 4, 2012 at 12:54 PM, Anthony Liguori wrote: >> Hi, >> >> On behalf of the QEMU Team, I'd like to announce the availability of the >> third and final release candidate for the QEMU 1.2 release. This >> release is meant for testing purposes and should not be used

Re: [Qemu-devel] [PATCH 2/2 v2] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2012-09-04 Thread Jason Baron
On Fri, Aug 31, 2012 at 11:43:31AM -0400, Jason Baron wrote: > On Fri, Aug 31, 2012 at 06:35:13PM +0300, Michael S. Tsirkin wrote: > > On Fri, Aug 31, 2012 at 10:45:52AM -0400, Jason Baron wrote: > > > On Fri, Aug 31, 2012 at 11:42:27AM +0300, Michael S. Tsirkin wrote: > > > > Some minor nits below

[Qemu-devel] [PATCH] linux-user: Remove redundant null check and replace free by g_free

2012-09-04 Thread Stefan Weil
Report from smatch: linux-user/syscall.c:3632 do_ioctl_dm(220) info: redundant null check on big_buf calling free() 'big_buf' was allocated by g_malloc0, therefore free was also replaced by g_free. Signed-off-by: Stefan Weil --- linux-user/syscall.c |4 +--- 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-09-04 Thread Jason Baron
On Fri, Aug 31, 2012 at 11:25:52PM -0700, Alexander Graf wrote: > On 31.08.2012, at 13:54, Jason Baron wrote: > > > On Fri, Aug 31, 2012 at 01:29:46PM -0700, Alexander Graf wrote: > >> On 31.08.2012, at 12:15, Jason Baron wrote: > >> > >>> On Fri, Aug 31, 2012 at 12:04:59PM -0700, Alexander Gra

[Qemu-devel] Dynamic Binary Instrumentation

2012-09-04 Thread Lluís Vilanova
Hi there, Given that right now I don't have enough time to write the paper that should accompany this work, I've decided to open it up so that whoever is interested can have access to it. You can get some instructions here: https://projects.gso.ac.upc.edu/projects/qemu-dbi/wiki Code is split

[Qemu-devel] [PATCH v2] ahci: properly reset PxCMD on HBA reset

2012-09-04 Thread Jason Baron
While testing q35, I found that windows 7 (specifically, windows 7 ultimate with sp1 x64), wouldn't install because it can't find the cdrom or disk drive. The failure message is: 'A required cd/dvd device driver is missing. If you have a driver floppy disk, CD, DVD, or USB flash drive, please inser

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.2.0-rc3 release

2012-09-04 Thread Blue Swirl
On Tue, Sep 4, 2012 at 7:42 PM, Peter Maydell wrote: > On 4 September 2012 20:29, Blue Swirl wrote: >> On Tue, Sep 4, 2012 at 12:54 PM, Anthony Liguori wrote: >>> The release plan for the 1.2 release is available at: >>> >>> http://wiki.qemu.org/Planning/1.2 >> >> The plan does not mention rc3 >

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.2.0-rc3 release

2012-09-04 Thread Peter Maydell
On 4 September 2012 20:29, Blue Swirl wrote: > On Tue, Sep 4, 2012 at 12:54 PM, Anthony Liguori wrote: >> The release plan for the 1.2 release is available at: >> >> http://wiki.qemu.org/Planning/1.2 > > The plan does not mention rc3 Clearly Anthony should add something like the following to his

Re: [Qemu-devel] [PATCH 02/21] target-s390x: split FPU ops

2012-09-04 Thread Blue Swirl
On Tue, Sep 4, 2012 at 6:42 PM, Richard Henderson wrote: > On 09/02/2012 10:33 AM, Blue Swirl wrote: >> +/* fpu_helper.c */ >> +uint32_t set_cc_f32(float32 v1, float32 v2); >> +uint32_t set_cc_f64(float64 v1, float64 v2); >> +uint32_t set_cc_nz_f32(float32 v); >> +uint32_t set_cc_nz_f64(float64 v)

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.2.0-rc3 release

2012-09-04 Thread Blue Swirl
On Tue, Sep 4, 2012 at 12:54 PM, Anthony Liguori wrote: > Hi, > > On behalf of the QEMU Team, I'd like to announce the availability of the > third and final release candidate for the QEMU 1.2 release. This > release is meant for testing purposes and should not be used in a > production environmen

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-04 Thread Blue Swirl
On Tue, Sep 4, 2012 at 8:32 AM, Avi Kivity wrote: > On 09/03/2012 10:32 PM, Blue Swirl wrote: >> On Mon, Sep 3, 2012 at 4:14 PM, Avi Kivity wrote: >>> On 08/29/2012 11:27 AM, Markus Armbruster wrote: I don't see a point in making contributors avoid non-problems that might conceivab

Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines

2012-09-04 Thread Blue Swirl
On Tue, Sep 4, 2012 at 7:38 AM, Paolo Bonzini wrote: > Il 04/09/2012 09:19, Wenchao Xia ha scritto: +struct QBlockOption_prot_file { >>> >>> QBlockOptionProtFile >>> +char *filename; >>> >>> 'const' >>> >> There is a problem, this member would be used in information >> retriev

Re: [Qemu-devel] [PATCH V6 2/2] qemu-img: Add json output option to the info command.

2012-09-04 Thread Benoît Canet
Thanks for reviewing. I will correct the series tomorow. Benoît Le Tuesday 04 Sep 2012 à 14:54:18 (+0200), Kevin Wolf a écrit : > Am 27.08.2012 09:15, schrieb Benoît Canet: > > This option --output=[human|json] make qemu-img info output on > > human or JSON representation at the choice of the use

Re: [Qemu-devel] [PATCH 00/21] AREG0 patches, final round

2012-09-04 Thread Richard Henderson
On 09/02/2012 10:33 AM, Blue Swirl wrote: > target-s390x: fix style > target-s390x: split FPU ops > target-s390x: split condition code helpers > target-s390x: split integer helpers > target-s390x: split memory access helpers > target-s390x: rename op_helper.c to misc_helper.c > target

Re: [Qemu-devel] [PATCH 02/21] target-s390x: split FPU ops

2012-09-04 Thread Richard Henderson
On 09/02/2012 10:33 AM, Blue Swirl wrote: > +/* fpu_helper.c */ > +uint32_t set_cc_f32(float32 v1, float32 v2); > +uint32_t set_cc_f64(float64 v1, float64 v2); > +uint32_t set_cc_nz_f32(float32 v); > +uint32_t set_cc_nz_f64(float64 v); > + I think that the CC handling should stay together, regardl

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Jan Kiszka
On 2012-09-04 20:27, Maciej W. Rozycki wrote: > On Tue, 4 Sep 2012, Jan Kiszka wrote: > What I'm trying to understand and translate from the description is rather "note that for inputs a high-to-low transition cancels the interrupt as in the level-triggered mode." This is surely not

Re: [Qemu-devel] [PATCH] hw/mcf5206: Fix buffer overflow for MBAR read / write

2012-09-04 Thread Peter Maydell
On 4 September 2012 19:16, Stefan Weil wrote: > Am 04.09.2012 20:12, schrieb Stefan Weil: >> Am 04.09.2012 19:57, schrieb Peter Maydell: >>> Checked against the data sheet -- last documented register is at >>> offset $1F0, so correcting the offset check rather than the array >>> length is the corr

Re: [Qemu-devel] [PATCH] hw/mcf5206: Fix buffer overflow for MBAR read / write

2012-09-04 Thread Stefan Weil
Am 04.09.2012 20:12, schrieb Stefan Weil: Am 04.09.2012 19:57, schrieb Peter Maydell: On 4 September 2012 18:37, Stefan Weil wrote: Report from smatch: mcf5206.c:384 m5206_mbar_readb(7) error: buffer overflow 'm5206_mbar_width' 128 <= 128 mcf5206.c:403 m5206_mbar_readw(8) error: buffer overf

Re: [Qemu-devel] [KVM][Kemari]:Kemari slows down the VM user experience

2012-09-04 Thread Brian Jackson
On Tuesday, September 04, 2012 12:01:31 AM Harshita wrote: > Hello, > > As part of implementing Fault Tolerant solution, we are exploring > Kemari. In the process of understanding it, we tested the branch "next" > of git repository. It is working fine. But, once we trigger sync > command, VM respo

Re: [Qemu-devel] [PATCH] hw/mcf5206: Fix buffer overflow for MBAR read / write

2012-09-04 Thread Stefan Weil
Am 04.09.2012 19:57, schrieb Peter Maydell: On 4 September 2012 18:37, Stefan Weil wrote: Report from smatch: mcf5206.c:384 m5206_mbar_readb(7) error: buffer overflow 'm5206_mbar_width' 128 <= 128 mcf5206.c:403 m5206_mbar_readw(8) error: buffer overflow 'm5206_mbar_width' 128 <= 128 mcf5206.

Re: [Qemu-devel] [PATCH] hw/mcf5206: Fix buffer overflow for MBAR read / write

2012-09-04 Thread Peter Maydell
On 4 September 2012 18:37, Stefan Weil wrote: > Report from smatch: > > mcf5206.c:384 m5206_mbar_readb(7) error: buffer overflow 'm5206_mbar_width' > 128 <= 128 > mcf5206.c:403 m5206_mbar_readw(8) error: buffer overflow 'm5206_mbar_width' > 128 <= 128 > mcf5206.c:427 m5206_mbar_readl(8) error: b

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Jan Kiszka
On 2012-09-04 19:41, Maciej W. Rozycki wrote: > On Tue, 4 Sep 2012, Jan Kiszka wrote: > >> What I'm trying to understand and translate from the description is >> rather "note that for inputs a high-to-low transition cancels the >> interrupt as in the level-triggered mode." This is surely not what

Re: [Qemu-devel] [PATCH] win32: provide separate macros for weak decls and definitions

2012-09-04 Thread Richard Henderson
On 08/14/2012 08:17 PM, Anthony Liguori wrote: > Strangely, gcc on Linux absolutely does not want the declaration to be marked > as weak. Err... that's incorrect. > +CpuDefinitionInfoList GCC_WEAK_DECL *arch_query_cpu_definitions(Error > **errp); ... and probably seen because you put the attrib

[Qemu-devel] [PATCH] hw/mcf5206: Fix buffer overflow for MBAR read / write

2012-09-04 Thread Stefan Weil
Report from smatch: mcf5206.c:384 m5206_mbar_readb(7) error: buffer overflow 'm5206_mbar_width' 128 <= 128 mcf5206.c:403 m5206_mbar_readw(8) error: buffer overflow 'm5206_mbar_width' 128 <= 128 mcf5206.c:427 m5206_mbar_readl(8) error: buffer overflow 'm5206_mbar_width' 128 <= 128 mcf5206.c:451

Re: [Qemu-devel] [PATCH V8 4/8] hw/acpi_piix4.c: replace register_ioport*

2012-09-04 Thread Jan Kiszka
On 2012-09-04 18:51, Jan Kiszka wrote: > On 2012-09-04 18:33, Julien Grall wrote: >> On 09/04/2012 04:15 PM, Jan Kiszka wrote: >>> On 2012-09-04 09:28, Julien Grall wrote: >>> This patch replaces all register_ioport* with the new memory API. It permits to use the new Memory stuf

Re: [Qemu-devel] [PATCH V8 4/8] hw/acpi_piix4.c: replace register_ioport*

2012-09-04 Thread Jan Kiszka
On 2012-09-04 18:33, Julien Grall wrote: > On 09/04/2012 04:15 PM, Jan Kiszka wrote: >> On 2012-09-04 09:28, Julien Grall wrote: >> >>> This patch replaces all register_ioport* with the new memory API. It permits >>> to use the new Memory stuff like listener. >>> >>> Signed-off-by: Julien Grall

Re: [Qemu-devel] [PATCH] target-cris: Fix buffer overflow

2012-09-04 Thread Edgar E. Iglesias
Thanks Stefan. Ill apply this when i get back to swe in a couple of days. Cheers --- Sent from my phone On Sep 3, 2012 10:46 PM, "Stefan Weil" wrote: > Report from smatch: > > target-cris/translate.c:3464 cpu_dump_state(32) error: > buffer overflow 'env->sregs' 4 <= 255 > > sregs is declared '

[Qemu-devel] [PATCH v2 2/4] s390: Add a mechanism to get the subchannel id.

2012-09-04 Thread Cornelia Huck
This will be needed by the new virtio-ccw transport. Signed-off-by: Cornelia Huck --- Changes v1->v2: - make it EXPORT_SYMBOL_GPL to get in line with other interfaces --- arch/s390/include/asm/ccwdev.h | 5 + drivers/s390/cio/device_ops.c | 12 2 files changed, 17 insertions

Re: [Qemu-devel] [PATCH V8 4/8] hw/acpi_piix4.c: replace register_ioport*

2012-09-04 Thread Julien Grall
On 09/04/2012 04:15 PM, Jan Kiszka wrote: On 2012-09-04 09:28, Julien Grall wrote: This patch replaces all register_ioport* with the new memory API. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/acpi_piix4.c | 145 +++

[Qemu-devel] [PATCH v2 1/5] Update headers for upcoming s390 changes.

2012-09-04 Thread Cornelia Huck
Signed-off-by: Cornelia Huck --- Changes v1->v2: - update to latest kvm interface changes --- linux-headers/asm-generic/kvm_para.h | 5 +++ linux-headers/asm-x86/kvm.h | 1 + linux-headers/linux/kvm.h| 80 ++-- 3 files changed, 83 insertion

Re: [Qemu-devel] [PATCH V8 4/8] hw/acpi_piix4.c: replace register_ioport*

2012-09-04 Thread Jan Kiszka
On 2012-09-04 09:28, Julien Grall wrote: > This patch replaces all register_ioport* with the new memory API. It permits > to use the new Memory stuff like listener. > > Signed-off-by: Julien Grall > --- > hw/acpi_piix4.c | 145 > +++ > 1 file

[Qemu-devel] [PATCH v2 2/7] s390/kvm: Add support for machine checks.

2012-09-04 Thread Cornelia Huck
Add support for injecting machine checks (only repressible conditions for now). This is a bit more involved than I/O interrupts, for these reasons: - Machine checks come in both floating and cpu varieties. - We don't have a bit for machine checks enabling, but have to use a roundabout approach

[Qemu-devel] [PATCH v2 5/7] s390: Make some css-related structures usable by non-cio code.

2012-09-04 Thread Cornelia Huck
kvm will need to use some css-related structures (pmcw, schib, orb), so let's move the definitions from drivers/s390/cio/ to include/asm/. Signed-off-by: Cornelia Huck --- arch/s390/include/asm/orb.h | 69 +++ arch/s390/include/asm/schib.h | 52 +

[Qemu-devel] [RFC PATCH v2 0/4] s390: virtio-ccw guest kernel support.

2012-09-04 Thread Cornelia Huck
Hi, here's the second revision of the guest support for virtio-ccw. The first patch has gotten several changes and now handles checking for s390-virtio support much more nicely. The third patch has been adapted to the changed virtio-ccw interface. Cornelia Huck (4): s390/kvm: Handle hosts not

[Qemu-devel] [PATCH v2 4/4] s390/kvm: Split out early console code.

2012-09-04 Thread Cornelia Huck
This code is transport agnostic and can be used by both the legacy virtio code and virtio_ccw. Signed-off-by: Cornelia Huck --- drivers/s390/kvm/Makefile | 2 +- drivers/s390/kvm/early_printk.c | 42 + drivers/s390/kvm/kvm_virtio.c | 29 ++

[Qemu-devel] [PATCH v2 6/7] s390/kvm: Base infrastructure for enabling capabilities.

2012-09-04 Thread Cornelia Huck
Signed-off-by: Cornelia Huck --- Documentation/virtual/kvm/api.txt | 2 +- arch/s390/kvm/kvm-s390.c | 26 ++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt index b91bfd4..9c71a

[Qemu-devel] [RFC PATCH v2 0/7] s390: virtual css host support.

2012-09-04 Thread Cornelia Huck
Hi, here's the second revision of the virtual channel subsystem support for s390. I changed the representation of the channel subsystem, introducing channel subsystem images, which brings it closer to the actual implementation. A new ioctl for adding a new channel subsystem image has also been in

[Qemu-devel] [PATCH v2 1/4] s390/kvm: Handle hosts not supporting s390-virtio.

2012-09-04 Thread Cornelia Huck
Running under a kvm host does not necessarily imply the presence of a page mapped above the main memory with the virtio information; however, the code includes a hard coded access to that page. Instead, check for the presence of the page and exit gracefully before we hit an addressing exception if

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Jan Kiszka
On 2012-09-04 16:42, Paolo Bonzini wrote: > Il 04/09/2012 16:29, Maciej W. Rozycki ha scritto: >> So first of all, the *output* of the 8259A is always edge triggered, >> regardless of whether it's the master or one of the slaves (only one slave >> is used in the PC/AT architecture, but up to eig

[Qemu-devel] [PATCH v2 5/5] [HACK] Handle multiple virtio aliases.

2012-09-04 Thread Cornelia Huck
This patch enables using both virtio-xxx-s390 and virtio-xxx-ccw by making the alias lookup code verify that a driver is actually registered. (Only included in order to allow testing of virtio-ccw; should be replaced by cleaning up the virtio bus model.) Not-signed-off-by: Cornelia Huck --- blo

[Qemu-devel] [PATCH v2 3/7] s390/kvm: In-kernel handling of I/O instructions.

2012-09-04 Thread Cornelia Huck
Explicitely catch all channel I/O related instructions intercepts in the kernel and set condition code 3 for them. This paves the way for properly handling these instructions later on. Note: This is not architecture compliant (the previous code wasn't either) since setting cc 3 is not the correct

[Qemu-devel] [PATCH v2 1/7] s390/kvm: Support for I/O interrupts.

2012-09-04 Thread Cornelia Huck
Add support for handling I/O interrupts (standard, subchannel-related ones and rudimentary adapter interrupts). The subchannel-identifying parameters are encoded into the interrupt type. I/O interrupts are floating, so they can't be injected on a specific vcpu. Signed-off-by: Cornelia Huck ---

[Qemu-devel] [RFC PATCH v2] Update virtio spec for virtio-ccw.

2012-09-04 Thread Cornelia Huck
Hi, this is the second revision of the virtio-ccw spec. The interface has been improved to support more than 32 feature bits as well as allocating less that the requested queue size and specifying alignment. (Note: I folded the changes with git into my initial spec; I hope LyX can handle this :)

[Qemu-devel] [RFC PATCH v2 0/5] qemu: s390: virtual css and virtio-ccw.

2012-09-04 Thread Cornelia Huck
Hi, here's the second version of virtual channel I/O and the new virtio-ccw transport. Changes to the first version include coding style fixes, changes in the organization of objects (not quite finished yet), adaptions to changes in the kernel interface and implementation of the improved virtio-c

[Qemu-devel] [PATCH v2] virtio-spec: Add virtio-ccw spec.

2012-09-04 Thread Cornelia Huck
Add specifications for the new s390 specific virtio-ccw transport. Signed-off-by: Cornelia Huck --- Changes v1->v2: - support more than 32 feature bits - allow to allocate less than requested queue size - allow to transfer alignment --- virtio-spec.lyx | 534 ++

[Qemu-devel] [PATCH v2 4/7] s390: Move css limits from drivers/s390/cio/ to include/asm/.

2012-09-04 Thread Cornelia Huck
There's no need to keep __MAX_SUBCHANNEL and __MAX_SSID private to the common I/O layer when __MAX_CSSID is usable by everybody. Signed-off-by: Cornelia Huck --- arch/s390/include/asm/cio.h | 2 ++ drivers/s390/cio/css.h | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v2 2/5] s390: Virtual channel subsystem support.

2012-09-04 Thread Cornelia Huck
Provide a mechanism for qemu to provide fully virtual subchannels to the guest. In the KVM case, this relies on the kernel's css support. The !KVM case is not yet supported. Signed-off-by: Cornelia Huck --- Changes v1 -> v2: - coding style - re-organization of hardware structures (channel subsys

[Qemu-devel] [PATCH v2 3/4] s390/kvm: Add a channel I/O based virtio transport driver.

2012-09-04 Thread Cornelia Huck
Add a driver for kvm guests that matches virtual ccw devices provided by the host as virtio bridge devices. These virtio-ccw devices use a special set of channel commands in order to perform virtio functions. Signed-off-by: Cornelia Huck --- Changes v1->v2: - adapt to improved virtio-ccw channe

[Qemu-devel] [PATCH v2 3/5] s390: Add new channel I/O based virtio transport.

2012-09-04 Thread Cornelia Huck
Add a new virtio transport that uses channel commands to perform virtio operations. Add a new machine type s390-ccw that uses this virtio-ccw transport and make it the default machine for s390. Signed-off-by: Cornelia Huck --- Changes v1->v2: - update to virtio-ccw interface changes --- hw/qd

[Qemu-devel] [RFC v2] s390: virtual channel subsystem and new virtio transport.

2012-09-04 Thread Cornelia Huck
Hi, I have incorporated the feedback I received to my first RFC for virtio-ccw (http://marc.info/?l=kvm&m=134435141402140&w=2) and will post the updates shortly. Patches will again be sorted into kernel host and guest, qemu, and virtio spec. Feedback is still welcome. Cornelia

[Qemu-devel] [Bug 893956] Re: qemu-img bug with dynamic vhd

2012-09-04 Thread Serge Hallyn
Though that commit and the comments were about 127G images. HIs is only 27G. Also, 'qemu-img info' is also showing the error, which shows that this is not being done on vpc_create(). So I think this is a case of qemu-img actually failing to properly parse the FHD file. -- You received this bug

Re: [Qemu-devel] [PATCH 01/21] target-s390x: fix style

2012-09-04 Thread Richard Henderson
On 2012-09-03 12:10, Blue Swirl wrote: > I missed that one. He's rewriting translate.c, while I'm mostly > touching op_helper.c. I'd expect it would be simpler for Richard to > rebase on my series, because they only change helper calls but don't > otherwise touch code. His series rearranges the cod

Re: [Qemu-devel] [PATCH 1/1] block: fix block tray status

2012-09-04 Thread Kevin Wolf
Am 09.08.2012 12:44, schrieb Pavel Hrdina: > The tray status should change also if you eject empty block device. > > Signed-off-by: Pavel Hrdina Thanks, applied to block-next. Kevin

Re: [Qemu-devel] [PATCH 1/2] qxl: Add set_client_capabilities() interface to QXLInterface

2012-09-04 Thread Gerd Hoffmann
Hi, > +static void interface_set_client_capabilities(QXLInstance *sin, > + uint8_t client_present, > + uint8_t caps[58]) Please don't use tabs for intention in qemu patches. Fixed it up this time, added both pa

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 16:29, Maciej W. Rozycki ha scritto: > So first of all, the *output* of the 8259A is always edge triggered, > regardless of whether it's the master or one of the slaves (only one slave > is used in the PC/AT architecture, but up to eight are supported; the > PC/XT had none). I

Re: [Qemu-devel] [PATCH] vdi: Fix warning from clang

2012-09-04 Thread Kevin Wolf
Am 17.08.2012 15:23, schrieb Stefan Weil: > ccc-analyzer reports these warnings: > > block/vdi.c:704:13: warning: Dereference of null pointer > bmap[i] = VDI_UNALLOCATED; > ^ > block/vdi.c:702:13: warning: Dereference of null pointer > bmap[i] = i; >

[Qemu-devel] [PATCH V8 1/8] isa: add isa_address_space_io

2012-09-04 Thread Julien Grall
This function permits to retrieve ISA IO address space. It will be usefull when we need to pass IO address space as argument. Signed-off-by: Julien Grall --- hw/isa-bus.c |9 + hw/isa.h |1 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/isa-bus.c b/hw/is

[Qemu-devel] [PATCH V8 2/8] hw/apm.c: replace register_ioport*

2012-09-04 Thread Julien Grall
This patch replaces all register_ioport* by a MemorySection. It permits to use the new Memory stuff like listener. Moreover, the PCI is added as an argument for apm_init, so we can register IO inside the pci IO address space. Signed-off-by: Julien Grall --- hw/acpi_piix4.c |2 +- hw/apm.c

Re: [Qemu-devel] [PATCH] Don't require encryption password for 'qemu-img info' command

2012-09-04 Thread Kevin Wolf
Am 31.08.2012 19:30, schrieb Eric Blake: > On 08/31/2012 10:26 AM, Daniel P. Berrange wrote: >> From: "Daniel P. Berrange" >> >> The encryption password is only required if I/O is going to be >> performed on a disk image. The 'qemu-img info' command merely >> reports metadata, so it should not ask

  1   2   >