Re: [Qemu-devel] [RFC v2] Migration thread

2012-09-07 Thread Juan Quintela
Paolo Bonzini pbonz...@redhat.com wrote: Il 07/09/2012 18:23, Juan Quintela ha scritto: Hi here is v2 of the migration thread series. There is still some issues with locking in the error paths (they are at 54 patches now). Changes from v1: - migration stats series are included -

Re: [Qemu-devel] [PATCH 2/3] g3beige: add a video card only when requested

2012-09-07 Thread Alexander Graf
On 07.09.2012, at 17:27, Aurelien Jarno aurel...@aurel32.net wrote: The g3beige machine always add a video card, even when the -vga none is passed. Fix that by checking if it is enabled or not before instanciating it. Cc: Alexander Graf ag...@suse.de Signed-off-by: Aurelien Jarno

Re: [Qemu-devel] [PATCH] target-xtensa: fix missing errno codes for mingw32

2012-09-07 Thread Stefan Weil
Am 06.09.2012 14:48, schrieb Max Filippov: On Thu, Sep 6, 2012 at 8:45 AM, Stefan Weils...@weilnetz.de wrote: Am 06.09.2012 02:36, schrieb Max Filippov: Put the following errno value mappings under #ifdef: xtensa-semi.c: In function 'errno_h2g': xtensa-semi.c:113: error: 'ENOTBLK'

Re: [Qemu-devel] [RFC v2] Migration thread

2012-09-07 Thread Paolo Bonzini
Il 07/09/2012 21:52, Juan Quintela ha scritto: This is the breakpoint. buffered_file: Move from using a timer to use a thread Everything before this could be integrated Today, from there, it needs still more 'thought. True, on the other hand, the split ramlist mutex etc. would be

Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-07 Thread Paolo Bonzini
Il 07/09/2012 21:23, Nicholas A. Bellinger ha scritto: Please create a completely separate device vhost-scsi-pci instead (or virtio-scsi-tcm-pci, or something like that). It is used completely differently from virtio-scsi-pci, it does not make sense to conflate the two. Ok, I need to

[Qemu-devel] [PATCH v2] target-cris: Fix buffer overflow

2012-09-07 Thread Stefan Weil
Report from smatch: target-cris/translate.c:3464 cpu_dump_state(32) error: buffer overflow 'env-sregs' 4 = 255 sregs is declared 'uint32_t sregs[4][16]', so the first index must be less than 4 or ARRAY_SIZE(env-sregs). Signed-off-by: Stefan Weil s...@weilnetz.de --- I did not fix tabs,

Re: [Qemu-devel] [PATCH 2/3] g3beige: add a video card only when requested

2012-09-07 Thread Aurelien Jarno
On Fri, Sep 07, 2012 at 08:58:06PM +0200, Alexander Graf wrote: On 07.09.2012, at 17:27, Aurelien Jarno aurel...@aurel32.net wrote: The g3beige machine always add a video card, even when the -vga none is passed. Fix that by checking if it is enabled or not before instanciating it.

Re: [Qemu-devel] [PATCH 2/3] g3beige: add a video card only when requested

2012-09-07 Thread Alexander Graf
On 07.09.2012, at 22:45, Aurelien Jarno wrote: On Fri, Sep 07, 2012 at 08:58:06PM +0200, Alexander Graf wrote: On 07.09.2012, at 17:27, Aurelien Jarno aurel...@aurel32.net wrote: The g3beige machine always add a video card, even when the -vga none is passed. Fix that by checking if it

Re: [Qemu-devel] [PATCH 2/3] g3beige: add a video card only when requested

2012-09-07 Thread Alexander Graf
On 07.09.2012, at 22:45, Aurelien Jarno wrote: On Fri, Sep 07, 2012 at 08:58:06PM +0200, Alexander Graf wrote: On 07.09.2012, at 17:27, Aurelien Jarno aurel...@aurel32.net wrote: The g3beige machine always add a video card, even when the -vga none is passed. Fix that by checking if it

[Qemu-devel] [PATCH 21/22] target-i386: move default init of cpuid_kvm_features bitmap into CPU initializer from cpudef

2012-09-07 Thread Igor Mammedov
Moving it inside CPU initializer from cpudef will help to split cpu_x86_find_by_name() into default init and user settable properties. [ehabkost: rebase on top of latest qemu.git master, where the bitmap initialization is now different] [imammedo: fix whitespace Signed-off-by: Igor Mammedov

[Qemu-devel] [PATCH 16/22] target-i386: use define for cpuid vendor string size

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 6 +++--- target-i386/cpu.h | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 5362fe6..8b021a2 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@

[Qemu-devel] [PATCH 03/22] target-i386: if x86_cpu_realize() failed report error and do cleanup

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com Acked-by: Andreas Färber afaer...@suse.de --- target-i386/helper.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index 8a5da3d..a0e4c89 100644 --- a/target-i386/helper.c +++

Re: [Qemu-devel] [PATCH 00/22 v2] target-i386: convert CPU features into properties

2012-09-07 Thread Igor Mammedov
On Fri, 7 Sep 2012 22:54:49 +0200 Igor Mammedov imamm...@redhat.com wrote: git tree for testing: https://github.com/imammedo/qemu/tree/x86-cpu-properties.v2 here are series it depends on: [Qemu-devel] [PATCH 0/7] x86 CPU patches that didn't get into 1.2

[Qemu-devel] [PATCH 04/22] target-i386: filter out not TCG features if running without kvm at realize time

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/target-i386/cpu.c

[Qemu-devel] [PATCH 17/22] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

2012-09-07 Thread Igor Mammedov
Vendor property setter takes string as vendor value but cpudefs use uint32_t vendor[123] fields to define vendor value. It makes it difficult to unify and use property setter for values from cpudefs. To allow simplify code by using vendor property setter, vendor[123] fields are converted into

[Qemu-devel] [PATCH 13/22] add visitor for parsing hz[KMG] input string

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com Acked-by: Andreas Färber afaer...@suse.de -- v2: * replaced _hz suffix for frequency visitor by _freq suffix suggested-by: Andreas Färber * fixed typo extra space spotted-by: Andreas Färber --- qapi/qapi-visit-core.c | 11 +++

Re: [Qemu-devel] [PATCH] target-xtensa: fix missing errno codes for mingw32

2012-09-07 Thread Max Filippov
On Sat, Sep 8, 2012 at 12:22 AM, Stefan Weil s...@weilnetz.de wrote: Am 06.09.2012 14:48, schrieb Max Filippov: On Thu, Sep 6, 2012 at 8:45 AM, Stefan Weils...@weilnetz.de wrote: Am 06.09.2012 02:36, schrieb Max Filippov: Put the following errno value mappings under #ifdef:

[Qemu-devel] [PATCH 02/22] target-i386: cpu_x86_register(): report error from property setter

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index a89bdc4..3f80069 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1415,6 +1415,7 @@ int cpu_x86_register(X86CPU *cpu,

[Qemu-devel] [PATCH 00/22 v2] target-i386: convert CPU features into properties

2012-09-07 Thread Igor Mammedov
Build and run tested in FC17 host with x86_64-linux-user, x86_64-softmmu targets git tree for testing: https://github.com/imammedo/qemu/tree/x86-cpu-properties.v2 Igor Mammedov (22): target-i386: return Error from cpu_x86_find_by_name() target-i386: cpu_x86_register(): report error from

[Qemu-devel] [PATCH 11/22] target-i386: convert 'hv_vapic' feature into property

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 6331eab..3b802ea 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1247,6 +1247,26 @@ static

[Qemu-devel] [PATCH 20/22] target-i386: move init of hypervisor feature into CPU initializer from cpudef

2012-09-07 Thread Igor Mammedov
hypervisor CPU feature is unconditionally enabled/overridden even if it's cleared in cpudef. Moving it inside CPU initializer from cpudef will help to split cpu_x86_find_by_name() into default init and user settable properties. Signed-off-by: Igor Mammedov imamm...@redhat.com ---

[Qemu-devel] [PATCH 18/22] target-i386: parse cpu_model string into set of stringified properties

2012-09-07 Thread Igor Mammedov
cpu_model string does represent features in following format: ([+-]feat)|(feat=foo)|(feat) which makes it impossible directly use property infrastructure to set features on CPU. This patch introduces parser that splits CPU name from cpu_model and converts legacy features string into canonized set

[Qemu-devel] [PATCH 14/22] target-i386: use visit_type_hz to parse tsc_freq property value

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com v2: * use visit_type_freq() which replaced visit_type_hz() --- target-i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 7ff9645..1e10388 100644 --- a/target-i386/cpu.c +++

[Qemu-devel] [PATCH 06/22] target-i386: xlevel should be more than 0x80000000, move fixup into setter

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index ff8c78e..cac9024 100644 --- a/target-i386/cpu.c

[Qemu-devel] [PATCH 22/22] target-i386: cleanup cpu_x86_find_by_name(), only fill x86_def_t in it

2012-09-07 Thread Igor Mammedov
Do in cpu_x86_find_by_name() only what name implies. i.e. leave only cpudef search and copy/fill passed in x86_def_t structure. and move out of it cpu_model parsing and CPU initializing into cpu_x86_register(). Plus add hints to where blocks should go when cpu_x86_register() is disbanded.

[Qemu-devel] [PATCH 10/22] target-i386: convert 'hv_relaxed' feature into property

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 7d45c6c..6331eab 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1227,6 +1227,26 @@ static

[Qemu-devel] [PATCH 15/22] target-i386: introduce vendor-override property

2012-09-07 Thread Igor Mammedov
currently 'cpuid_vendor_override' can be set only via cmd line cpu_model string. But setting it in 'vendor' property prevents using 'vendor' property on its own without setting cpuid_vendor_override. So fix/remove enabling cpuid_vendor_override from vendor property setter. It's up-to cpu_model

[Qemu-devel] [PATCH 19/22] target-i386: use properties to set/unset user specified features on CPU

2012-09-07 Thread Igor Mammedov
[ehabkost: rebase on top of latest qemu.git master, where default KVM features are set differently Signed-off-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com -- v2: * fix error of initializing from incorrect cpu model definition use x86_cpu_def

[Qemu-devel] [PATCH 05/22] target-i386: move out CPU features initialization in separate func

2012-09-07 Thread Igor Mammedov
later it could be used in cpu_x86_find_by_name() to init CPU from found cpu_def Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com -- v2: - rebased on top of i386: cpu: remove duplicate feature names

[Qemu-devel] [PATCH 01/22] target-i386: return Error from cpu_x86_find_by_name()

2012-09-07 Thread Igor Mammedov
it will allow to use property setters there later. Signed-off-by: Igor Mammedov imamm...@redhat.com -- v2: style change, add braces (reqested by Blue Swirl) --- target-i386/cpu.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c

[Qemu-devel] [PATCH 12/22] target-i386: convert 'check' and 'enforce' features into properties

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com -- v2: * restore original behavior, check features against host before they might be filtered out by TCG masks. spotted-by: Eduardo Habkost --- target-i386/cpu.c | 68 ++- 1 file changed, 57

[Qemu-devel] [PATCH 09/22] target-i386: convert 'hv_spinlocks' feature into property

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index ae3bc9d..7d45c6c 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1203,6 +1203,32 @@

[Qemu-devel] [PATCH 08/22] target-i386: add stubs for hyperv_(vapic_recommended|relaxed_timing_enabled|get_spinlock_retries)()

2012-09-07 Thread Igor Mammedov
It's needed for the next 3 patches to avoid build breakage when qemu is built with --disable-kvm option. Signed-off-by: Igor Mammedov imamm...@redhat.com Reported-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/hyperv.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH 07/22] target-i386: convert cpuid features into properties

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com -- v2: * replaced mask/ffs tricks by plain 'for (bit = 0; bit 32; bit++)' as suggested by Eduardo Habkost v3: * check if property exists before adding it * rebased on top of i386: cpu: remove duplicate feature names

Re: [Qemu-devel] [PATCH 18/22] target-i386: parse cpu_model string into set of stringified properties

2012-09-07 Thread Don Slutz
On 09/07/12 16:55, Igor Mammedov wrote: cpu_model string does represent features in following format: ([+-]feat)|(feat=foo)|(feat) which makes it impossible directly use property infrastructure to set features on CPU. This patch introduces parser that splits CPU name from cpu_model and

Re: [Qemu-devel] [PATCH 13/22] add visitor for parsing hz[KMG] input string

2012-09-07 Thread Don Slutz
On 09/07/12 16:55, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com Acked-by: Andreas Färber afaer...@suse.de -- v2: * replaced _hz suffix for frequency visitor by _freq suffix suggested-by: Andreas Färber * fixed typo extra space spotted-by: Andreas Färber ---

Re: [Qemu-devel] [PATCH 13/22] add visitor for parsing hz[KMG] input string

2012-09-07 Thread Igor Mammedov
On Fri, 7 Sep 2012 18:12:00 -0400 Don Slutz d...@cloudswitch.com wrote: On 09/07/12 16:55, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com Acked-by: Andreas Färber afaer...@suse.de -- v2: * replaced _hz suffix for frequency visitor by _freq suffix

Re: [Qemu-devel] [PATCH 13/22] add visitor for parsing hz[KMG] input string

2012-09-07 Thread Don Slutz
On 09/07/12 18:47, Igor Mammedov wrote: On Fri, 7 Sep 2012 18:12:00 -0400 Don Slutz d...@cloudswitch.com wrote: On 09/07/12 16:55, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com Acked-by: Andreas Färber afaer...@suse.de -- v2: * replaced _hz suffix for frequency

Re: [Qemu-devel] [PATCH] iSCSI: We dont need to explicitely call qemu_notify_event() any more

2012-09-07 Thread ronnie sahlberg
Ping? On Thu, Aug 30, 2012 at 4:56 PM, Ronnie Sahlberg ronniesahlb...@gmail.com wrote: We no longer need to explicitely call qemu_notify_event() any more since this is now done automatically any time the filehandles we listen to change. Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com

[Qemu-devel] [Bug 1047470] Re: qemu/kvm hangs reading from serial console

2012-09-07 Thread Buck
** Description changed: This is for a qemu-kvm running on RHEL 5, so it's pretty old, but i think the problem still exists in 1.2 We have conman running on our hosts, connecting to the kvm/qemu's using - virsh console + virsh console which just opens up the console

[Qemu-devel] [Bug 1047470] [NEW] qemu/kvm hangs reading from serial console

2012-09-07 Thread Buck
Public bug reported: This is for a qemu-kvm running on RHEL 5, so it's pretty old, but i think the problem still exists in 1.2 We have conman running on our hosts, connecting to the kvm/qemu's using virsh console which just opens up the console /dev/pts/slave that qemu opens up when run with

Re: [Qemu-devel] [PATCH] iSCSI: We need to support SG_IO also from iscsi_ioctl()

2012-09-07 Thread ronnie sahlberg
ping? On Thu, Aug 30, 2012 at 5:28 PM, Ronnie Sahlberg ronniesahlb...@gmail.com wrote: We need to support SG_IO from the synchronous iscsi_ioctl() since scsi-block uses this to do an INQ to the device to discover its properties This patch makes scsi-block work with iscsi. Signed-off-by:

[Qemu-devel] [Bug 1047576] Re: qemu unittest emulator failure on latest git master

2012-09-07 Thread Lucas Meneghel Rodrigues
/kvm/qemu 16:01:30 INFO | -S 16:01:30 INFO | -name 'unittest_vm' 16:01:30 INFO | -nodefaults 16:01:30 INFO | -chardev socket,id=hmp_id_humanmonitor1,path=/tmp/monitor-humanmonitor1-20120907-155940-WomlFZY3,server,nowait 16:01:30 INFO | -mon chardev

[Qemu-devel] [Bug 1047576] Re: qemu unittest emulator failure on latest git master

2012-09-07 Thread Lucas Meneghel Rodrigues
:01:30 INFO | -chardev socket,id=hmp_id_humanmonitor1,path=/tmp/monitor-humanmonitor1-20120907-155940-WomlFZY3,server,nowait 16:01:30 INFO | -mon chardev=hmp_id_humanmonitor1,mode=readline 16:01:30 INFO | -chardev socket,id=serial_id_20120907-155940-WomlFZY3,path=/tmp/serial

[Qemu-devel] [Bug 1047576] [NEW] qemu unittest emulator failure on latest git master

2012-09-07 Thread Lucas Meneghel Rodrigues
'unittest_vm' 16:01:30 INFO | -nodefaults 16:01:30 INFO | -chardev socket,id=hmp_id_humanmonitor1,path=/tmp/monitor-humanmonitor1-20120907-155940-WomlFZY3,server,nowait 16:01:30 INFO | -mon chardev=hmp_id_humanmonitor1,mode=readline 16:01:30 INFO | -chardev socket,id=serial_id_20120907

[Qemu-devel] buildbot failure in qemu on default_x86_64_rhel61

2012-09-07 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_rhel61 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/369 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61

Re: [Qemu-devel] [PATCH] MIPS/user: Fix reset CPU state initialization

2012-09-07 Thread Aurelien Jarno
On Fri, Jun 08, 2012 at 02:04:40AM +0100, Maciej W. Rozycki wrote: This change updates the CPU reset sequence to use a common piece of code that figures out CPU state flags, fixing the problem with MIPS_HFLAG_COP1X not being set where applicable that causes floating-point MADD family

Re: [Qemu-devel] [PATCH 13/22] add visitor for parsing hz[KMG] input string

2012-09-07 Thread Don Slutz
Don Slutz wrote: On 09/07/12 18:47, Igor Mammedov wrote: On Fri, 7 Sep 2012 18:12:00 -0400 Don Slutz d...@cloudswitch.com wrote: On 09/07/12 16:55, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com Acked-by: Andreas Färber afaer...@suse.de -- v2: * replaced _hz suffix

Re: [Qemu-devel] [PATCH v2] target-mips: Implement Loongson Multimedia Instructions

2012-09-07 Thread Aurelien Jarno
On Fri, Mar 30, 2012 at 01:13:13PM -0400, Richard Henderson wrote: Implements all of the COP2 instructions except for the Scond family of comparisons. The documentation is unclear for those. Signed-off-by: Richard Henderson r...@twiddle.net --- v2: Rebased vs master. Makefile.target

[Qemu-devel] Qemu (no kvm) Win7 (64bit) boot error

2012-09-07 Thread Clemens Kolbitsch
Hi guys, I need to run Win7 64bit in Qemu without KVM support. I found a few messages concerning the unsupported architecture problem (Windows shows a BSOD with STOP 0x005D ... on boot), for example http://lists.gnu.org/archive/html/qemu-devel/2011-03/msg01623.html or

[Qemu-devel] buildbot failure in qemu on block_mingw32

2012-09-07 Thread qemu
The Buildbot has detected a new failure on builder block_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/318 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason:

Re: [Qemu-devel] [PATCH 18/21] target-cris: switch to AREG0 free mode

2012-09-07 Thread Edgar E. Iglesias
case 6: Similarly to what I reported for the microblaze and sh4 target, I think we should not start using cpu_single_env (a global variable) to replace env (a global variable stored in a register). It is possible to pass env through the subroutine, though

Re: [Qemu-devel] QEMU (no kvm) Win7 (64bit) boot error

2012-09-07 Thread Stefan Weil
Am 08.09.2012 02:48, schrieb Clemens Kolbitsch: Hi guys, I need to run Win7 64bit in Qemu without KVM support. I found a few messages concerning the unsupported architecture problem (Windows shows a BSOD with STOP 0x005D ... on boot), for example

Re: [Qemu-devel] [PATCH v2] target-cris: Fix buffer overflow

2012-09-07 Thread Edgar E. Iglesias
On Fri, Sep 07, 2012 at 10:36:08PM +0200, Stefan Weil wrote: Report from smatch: target-cris/translate.c:3464 cpu_dump_state(32) error: buffer overflow 'env-sregs' 4 = 255 sregs is declared 'uint32_t sregs[4][16]', so the first index must be less than 4 or ARRAY_SIZE(env-sregs). Thanks

<    1   2