Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Paolo Bonzini
Il 18/11/2012 23:00, Stefan Priebe ha scritto: Hi Paolo, Am 06.11.2012 23:42, schrieb Paolo Bonzini: i wantes to use scsi unmap with rbd. rbd documention says you need to set discard_granularity=512 for the device. I'm using qemu 1.2. If i set this and send an UNMAP command i get this

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event when vm is running

2012-11-19 Thread Paolo Bonzini
Il 18/11/2012 20:17, Blue Swirl ha scritto: +struct { Please add a name, for example PostLoad. Why? This is not C++ and the namespace would be global. It's just to have a nice grouping. Otherwise the structure will be anonymous and those were only added to C11, not C99. No,

Re: [Qemu-devel] buildbot failure in qemu on default_i386_debian_6_0

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 07:50, Stefan Weil ha scritto: Am 19.11.2012 00:43, schrieb q...@buildbot.b1-systems.de: The Buildbot has detected a new failure on builder default_i386_debian_6_0 while building qemu. Full details are available at:

Re: [Qemu-devel] [PATCH] iscsi: do not assume device is zero initialized

2012-11-19 Thread Paolo Bonzini
Il 17/11/2012 16:20, Peter Lieven ha scritto: Without any complex checks we can't assume that an iscsi target is initialized to zero. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c

Re: [Qemu-devel] [PATCH] iscsi: add iscsi_create support

2012-11-19 Thread Paolo Bonzini
Il 17/11/2012 16:13, Peter Lieven ha scritto: This patch adds support for bdrv_create. This allows e.g. to use qemu-img to convert from any supported device to an iscsi backed storage as destination. Signed-off-by: Peter Lieven p...@kamp.de diff --git a/block/iscsi.c b/block/iscsi.c

Re: [Qemu-devel] [PATCH v2] iscsi: fix deadlock during login

2012-11-19 Thread Paolo Bonzini
Il 17/11/2012 14:37, Peter Lieven ha scritto: If the connection is interrupted before the first login is successfully completed qemu-kvm is waiting forever in qemu_aio_wait(). This is fixed by performing an sync login to the target. If the connection breaks after the first successful login

Re: [Qemu-devel] [PATCH] arm: a9mpcore: remove un-used ptimer_iomem field

2012-11-19 Thread Peter Maydell
On 19 November 2012 05:13, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: I'm guessing this is a hangover from a previous coreification of the mptimer sub-module. This field is completely unused - removed. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Reviewed-by: Peter

Re: [Qemu-devel] QOMification of SCU in a9mpcore

2012-11-19 Thread Peter Maydell
On 19 November 2012 05:23, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Im currently doing some re-factoring in and around the A9mpcore for our work on dynamic machine model creation. Id like to change the SCU component currently implemented in a9mpcore to be its own QOM object, just

Re: [Qemu-devel] [PATCH] Fix spelling (prefered - preferred)

2012-11-19 Thread Stefan Hajnoczi
On Sun, Nov 18, 2012 at 08:35:24PM +0100, Stefan Weil wrote: Am 02.11.2012 08:14, schrieb Stefan Weil: Signed-off-by: Stefan Weils...@weilnetz.de --- configure |2 +- net/tap-win32.c |7 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/configure

Re: [Qemu-devel] [PATCH] Fix comments (adress - address, layed - laid, wierd - weird)

2012-11-19 Thread Stefan Hajnoczi
On Sun, Nov 18, 2012 at 08:34:11PM +0100, Stefan Weil wrote: Am 02.11.2012 08:29, schrieb Stefan Weil: Remove also a duplicated 'the'. Signed-off-by: Stefan Weils...@weilnetz.de --- slirp/ip_icmp.c |2 +- tcg/tcg.h |4 ++-- uri.c |4 ++-- 3 files changed,

Re: [Qemu-devel] [Qemu-trivial] [PATCH] s390x: Spelling fixes (endianess - endianness, occured - occurred)

2012-11-19 Thread Stefan Hajnoczi
On Fri, Nov 02, 2012 at 08:35:54AM +0100, Stefan Weil wrote: Replace also write into by write to. Signed-off-by: Stefan Weil s...@weilnetz.de --- I think write to is better, but I am not sure about this, so please wait until a native speaker has reviewed that patch. write to is better.

Re: [Qemu-devel] QOMification of SCU in a9mpcore

2012-11-19 Thread Peter Crosthwaite
On Mon, Nov 19, 2012 at 6:35 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 19 November 2012 05:23, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Im currently doing some re-factoring in and around the A9mpcore for our work on dynamic machine model creation. Id like to change the

Re: [Qemu-devel] TCP based PCIE request forwarding

2012-11-19 Thread Stefan Hajnoczi
On Fri, Nov 16, 2012 at 02:05:29PM +0100, lementec fabien wrote: Actually, I wanted to be independant of the QEMU event loop. Plus, some proprietary simulation environment provides a closed socket based interface to 'stimulate' the emulated device, at the PCIE level for instance. These

Re: [Qemu-devel] [PATCH] vnc: added initial websockets support

2012-11-19 Thread Gerd Hoffmann
On 11/19/12 00:29, Tim Hardeck wrote: Hi Stefan, thanks for your input but how should it be implemented? I personally would like activating Websockets as a VNC option like: -vnc :0 -vnc :1,websockets I have already tested this locally and it does work but only for one protocol since QEMU

[Qemu-devel] Fwd: buildbot failure in qemu on fedora-mingw32

2012-11-19 Thread Gerd Hoffmann
Original Message Subject: buildbot failure in qemu on fedora-mingw32 Date: Sun, 18 Nov 2012 22:55:08 +0100 From: build...@spunk.home.kraxel.org To: kraxel...@gmail.com The Buildbot has detected a failed build on builder fedora-mingw32 while building qemu. Full details are

Re: [Qemu-devel] QOMification of SCU in a9mpcore

2012-11-19 Thread Peter Maydell
On 19 November 2012 08:44, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: I had a look at a11 SCU and it seems to have functional overlap. Could parameterise the differences to remove some code replication in the process. QOM string property for versions a9 a11 etc? I don't think that's

Re: [Qemu-devel] [PATCH] vnc: added initial websockets support

2012-11-19 Thread Stefan Hajnoczi
On Mon, Nov 19, 2012 at 12:29:44AM +0100, Tim Hardeck wrote: Hi Stefan, thanks for your input but how should it be implemented? I personally would like activating Websockets as a VNC option like: -vnc :0 -vnc :1,websockets I have already tested this locally and it does work but only for

Re: [Qemu-devel] [PULL 00/26] Block patches

2012-11-19 Thread Kevin Wolf
Am 14.11.2012 19:47, schrieb Kevin Wolf: The following changes since commit ce34cf72fe508b27a78f83c184142e8d1e6a048a: Merge remote-tracking branch 'awilliam/tags/vfio-pci-for-qemu-1.3.0-rc0' into staging (2012-11-14 08:53:40 -0600) are available in the git repository at:

[Qemu-devel] [PATCH] Fix the inconsistency in x509-dh-key-file parameter

2012-11-19 Thread Lei Li
Commit c448e8552b0f6135dabddf944a7110f929c08320 (spice: tls support) added options to the -spice command line. But there is an inconsistency between the declaration of the option 'x509-dh-key-file' to -spice command line and its parameter parsing 'x509-dh-file' in function qemu_spice_init.

[Qemu-devel] [PATCH] curses: Remove OpenBSD workaround

2012-11-19 Thread Brad Smith
I removed the same sort of workaround for OpenBSD within the configure script with commit 4dcc3f5876fa638d5c35bd47be3b717ea74cc2e7 but didn't bother to grep further to come across this same chunk of code in the curses code itself. So the following diff removes the same workaround chunk within the

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Stefan Priebe - Profihost AG
Hi Paolo, Am 19.11.2012 09:10, schrieb Paolo Bonzini: I'm sorry the discard requests aren't failing. Qemu / Block driver starts to cancel a bunch of requests. That is being done in the kernel (the guest, I think) because the UNMAPs are taking too long. That makes sense. RBD handles discards

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 10:36, Stefan Priebe - Profihost AG ha scritto: Hi Paolo, Am 19.11.2012 09:10, schrieb Paolo Bonzini: I'm sorry the discard requests aren't failing. Qemu / Block driver starts to cancel a bunch of requests. That is being done in the kernel (the guest, I think) because the

[Qemu-devel] [PULL urgent 0/4] build system fixes for 1.3

2012-11-19 Thread Paolo Bonzini
Anyone, the following changes since commit e24dc9feb0d68142d54dc3c097f57588836d1338: tci: Support deposit operations (2012-11-18 20:40:08 +) are available in the git repository at: git://github.com/bonzini/qemu.git build-urgent for you to fetch changes up to

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Stefan Priebe - Profihost AG
Am 19.11.2012 10:54, schrieb Paolo Bonzini: Il 19/11/2012 10:36, Stefan Priebe - Profihost AG ha scritto: Hi Paolo, Am 19.11.2012 09:10, schrieb Paolo Bonzini: I'm sorry the discard requests aren't failing. Qemu / Block driver starts to cancel a bunch of requests. That is being done in the

Re: [Qemu-devel] [PATCH] Fix the inconsistency in x509-dh-key-file parameter

2012-11-19 Thread Gerd Hoffmann
On 11/19/12 10:15, Lei Li wrote: Commit c448e8552b0f6135dabddf944a7110f929c08320 (spice: tls support) added options to the -spice command line. But there is an inconsistency between the declaration of the option 'x509-dh-key-file' to -spice command line and its parameter parsing

Re: [Qemu-devel] [PATCH] rng-egd: don't use gslist_free_full

2012-11-19 Thread Kevin Wolf
Am 16.11.2012 20:10, schrieb Anthony Liguori: This function was only introduced in glib 2.28.0. Signed-off-by: Anthony Liguori aligu...@us.ibm.com In fact it seems that this file should use typesafe qemu-queue.h lists instead of GSList. Kevin

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 10:59, Stefan Priebe - Profihost AG ha scritto: Do you know what is the correct way? I think the correct fix is to serialize them in the kernel. So you mean this is not a bug in rbd or qemu this is a general bug in the linux kernel since they implemented discard? Yes.

Re: [Qemu-devel] [PATCH] iscsi: do not assume device is zero initialized

2012-11-19 Thread Peter Lieven
Am 19.11.2012 um 09:25 schrieb Paolo Bonzini pbonz...@redhat.com: Il 17/11/2012 16:20, Peter Lieven ha scritto: Without any complex checks we can't assume that an iscsi target is initialized to zero. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c |6 ++ 1 file

Re: [Qemu-devel] [PATCH] vnc: added initial websockets support

2012-11-19 Thread Tim Hardeck
On 11/19/2012 09:56 AM, Gerd Hoffmann wrote: On 11/19/12 00:29, Tim Hardeck wrote: Hi Stefan, thanks for your input but how should it be implemented? I personally would like activating Websockets as a VNC option like: -vnc :0 -vnc :1,websockets I have already tested this locally and it

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Stefan Priebe - Profihost AG
Am 19.11.2012 11:06, schrieb Paolo Bonzini: Il 19/11/2012 10:59, Stefan Priebe - Profihost AG ha scritto: Do you know what is the correct way? I think the correct fix is to serialize them in the kernel. So you mean this is not a bug in rbd or qemu this is a general bug in the linux kernel

[Qemu-devel] [PATCH 4/4] Makefile: Add missing dependency (fix parallel builds)

2012-11-19 Thread Paolo Bonzini
From: Stefan Weil s...@weilnetz.de The executables in i386-softmmu, i386-linux-user, ... depend on the recently added libqemustub.a. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile | 2 ++ 1 file modificato, 2 inserzioni(+) diff --git

[Qemu-devel] [BUG] qemu crash when using lsilogic

2012-11-19 Thread Wanlong Gao
Hi all and Avi, I met the upstream qemu crash when using lsilogic, my first sight is that I can't access the VNC view, it gave me a black screen, here is my command line, /work/git/qemu/x86_64-softmmu/qemu-system-x86_64 -name f17 -m 3096 -M pc-0.15 -enable-kvm -smp 4,sockets=4,cores=1,threads=1

[Qemu-devel] [PATCH 1/4] libcacard: make unnesting rules available to Makefile.objs

2012-11-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- libcacard/Makefile | 2 +- 1 file modificato, 1 inserzione(+). 1 rimozione(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index 487f434..f501cec 100644 --- a/libcacard/Makefile +++ b/libcacard/Makefile @@ -1,6 +1,6 @@ -include

[Qemu-devel] [PATCH 3/4] tests: link in stubs

2012-11-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- tests/Makefile | 4 ++-- 1 file modificato, 2 inserzioni(+), 2 rimozioni(-) diff --git a/tests/Makefile b/tests/Makefile index 9bf0765..ca680e5 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -48,7 +48,7 @@ tests/check-qdict$(EXESUF):

[Qemu-devel] [PATCH 3/5] virtio-9p: use symbolic constant, add to pci-ids.txt

2012-11-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- docs/specs/pci-ids.txt | 1 + hw/9pfs/virtio-9p-device.c | 2 +- hw/pci.h | 1 + 3 file modificati, 3 inserzioni(+). 1 rimozione(-) diff --git a/docs/specs/pci-ids.txt b/docs/specs/pci-ids.txt index 445b293..28dcf90

[Qemu-devel] [PATCH 4/5] ivshmem: use symbolic constant for PCI ID, add to pci-ids.txt

2012-11-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- docs/specs/pci-ids.txt | 2 ++ hw/ivshmem.c | 2 +- hw/pci.h | 1 + 3 file modificati, 4 inserzioni(+). 1 rimozione(-) diff --git a/docs/specs/pci-ids.txt b/docs/specs/pci-ids.txt index 28dcf90..6b5cf42 100644 ---

Re: [Qemu-devel] [PATCH v3] DSDT: Fix HPET _CRS Method

2012-11-19 Thread Alexander Graf
On 16.11.2012, at 19:46, Kevin O'Connor wrote: On Fri, Nov 16, 2012 at 01:02:18PM -0500, Gabriel L. Somlo wrote: ping On Thu, Nov 08, 2012 at 12:35:17PM -0500, Gabriel L. Somlo wrote: Updated _CRS method for HPET, bringing it in line with the way it is presented on recent hardware (e.g.

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 11:13, Stefan Priebe - Profihost AG ha scritto: So you mean this is not a bug in rbd or qemu this is a general bug in the linux kernel since they implemented discard? Yes. As you're known in the linux dev community ;-) Might you open a thread / discussion in the linux

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Stefan Priebe - Profihost AG
Am 19.11.2012 11:23, schrieb Paolo Bonzini: Il 19/11/2012 11:13, Stefan Priebe - Profihost AG ha scritto: So you mean this is not a bug in rbd or qemu this is a general bug in the linux kernel since they implemented discard? Yes. As you're known in the linux dev community ;-) Might you

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 11:30, Stefan Priebe - Profihost AG ha scritto: But do you have any idea why it works with an iscsi / libiscsi backend? In that case the kernel does not cancel the I/O. It tries to, but the command ultimately succeeds and the success response undoes the cancel.

Re: [Qemu-devel] [PATCH 7/7] virtio-blk: add x-data-plane=on|off performance feature

2012-11-19 Thread Kevin Wolf
Am 16.11.2012 07:22, schrieb Stefan Hajnoczi: On Thu, Nov 15, 2012 at 10:08 PM, Anthony Liguori aligu...@us.ibm.com wrote: Stefan Hajnoczi stefa...@redhat.com writes: The virtio-blk-data-plane feature is easy to integrate into hw/virtio-blk.c. The data plane can be started and stopped

[Qemu-devel] [PATCH 1/5] docs: move pci-ids.txt to docs/specs/

2012-11-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- pci-ids.txt = docs/specs/pci-ids.txt | 0 1 file modificato, 0 inserzioni(+), 0 rimozioni(-) rename pci-ids.txt = docs/specs/pci-ids.txt (100%) diff --git a/pci-ids.txt b/docs/specs/pci-ids.txt similarity index 100% rename from pci-ids.txt

Re: [Qemu-devel] [PATCH] vnc: added initial websockets support

2012-11-19 Thread Tim Hardeck
On 11/19/2012 10:07 AM, Stefan Hajnoczi wrote: On Mon, Nov 19, 2012 at 12:29:44AM +0100, Tim Hardeck wrote: Hi Stefan, thanks for your input but how should it be implemented? I personally would like activating Websockets as a VNC option like: -vnc :0 -vnc :1,websockets I have already

[Qemu-devel] [PATCH 2/5] reorganize pci-ids.txt

2012-11-19 Thread Paolo Bonzini
Some devices were missing, and we're using two PCI vendor ids. This patch only adds devices that are already documented in hw/pci.h. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- docs/specs/pci-ids.txt | 26 +- 1 file modificato, 13 inserzioni(+), 13 rimozioni(-)

Re: [Qemu-devel] [PATCH 0/5] Improve consistency of pci-ids.txt, use symbolic constants for QEMU devices

2012-11-19 Thread Gerd Hoffmann
On 11/19/12 11:21, Paolo Bonzini wrote: Five small, boring patches. Inspired by Gerd's patch at http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg05229.html which unfortunately is already out of date. Thanks for picking this up, series looks good. cheers, Gerd

[Qemu-devel] [PATCH 2/4] libcacard: link in stubs

2012-11-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- libcacard/Makefile | 2 +- 1 file modificato, 1 inserzione(+). 1 rimozione(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index f501cec..c26aac6 100644 --- a/libcacard/Makefile +++ b/libcacard/Makefile @@ -7,7 +7,7 @@

Re: [Qemu-devel] [Qemu-ppc] [PATCH] free the memory malloced by load_at()

2012-11-19 Thread Alexander Graf
On 16.11.2012, at 07:47, Olivia Yin wrote: Signed-off-by: Olivia Yin hong-hua@freescale.com --- hw/elf_ops.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/elf_ops.h b/hw/elf_ops.h index db4630e..4495932 100644 --- a/hw/elf_ops.h +++ b/hw/elf_ops.h @@

[Qemu-devel] [PATCH 5/5] pci: use constants for devices under the 1B36 device ID, document them

2012-11-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- docs/specs/pci-ids.txt | 15 +++ hw/pci.h | 7 +++ hw/pci_bridge_dev.c| 8 ++-- hw/serial-pci.c| 12 ++-- 4 file modificati, 30 inserzioni(+), 12 rimozioni(-) diff --git

[Qemu-devel] [PATCH 0/5] Improve consistency of pci-ids.txt, use symbolic constants for QEMU devices

2012-11-19 Thread Paolo Bonzini
Five small, boring patches. Inspired by Gerd's patch at http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg05229.html which unfortunately is already out of date. Paolo Bonzini (5): docs: move pci-ids.txt to docs/specs/ reorganize pci-ids.txt virtio-9p: use symbolic constant, add to

Re: [Qemu-devel] [PATCH 7/7] virtio-blk: add x-data-plane=on|off performance feature

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 11:38, Kevin Wolf ha scritto: Am 16.11.2012 07:22, schrieb Stefan Hajnoczi: On Thu, Nov 15, 2012 at 10:08 PM, Anthony Liguori aligu...@us.ibm.com wrote: Stefan Hajnoczi stefa...@redhat.com writes: The virtio-blk-data-plane feature is easy to integrate into hw/virtio-blk.c.

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Stefan Priebe - Profihost AG
Yeah thats my old thread regarding iscsi und unmap but this works fine now since you patched qemu. Stefan Am 19.11.2012 11:36, schrieb Paolo Bonzini: Il 19/11/2012 11:30, Stefan Priebe - Profihost AG ha scritto: But do you have any idea why it works with an iscsi / libiscsi backend? In

Re: [Qemu-devel] [PATCH 2/3] hd-geometry.c/s390: Disable geometry translation

2012-11-19 Thread Christian Borntraeger
On 18/11/12 20:14, Blue Swirl wrote: On Sun, Nov 18, 2012 at 4:10 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 17/11/2012 17:07, Blue Swirl ha scritto: On Tue, Nov 13, 2012 at 8:50 AM, Christian Borntraeger borntrae...@de.ibm.com wrote: From: Einar Lueck elelu...@linux.vnet.ibm.com This

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 11:57, Stefan Priebe - Profihost AG ha scritto: Yeah thats my old thread regarding iscsi und unmap but this works fine now since you patched qemu. It still causes hangs no? Though it works apart from that. Paolo Stefan Am 19.11.2012 11:36, schrieb Paolo Bonzini: Il

Re: [Qemu-devel] [PATCH 2/3] hd-geometry.c/s390: Disable geometry translation

2012-11-19 Thread Alexander Graf
On 19.11.2012, at 11:59, Christian Borntraeger wrote: On 18/11/12 20:14, Blue Swirl wrote: On Sun, Nov 18, 2012 at 4:10 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 17/11/2012 17:07, Blue Swirl ha scritto: On Tue, Nov 13, 2012 at 8:50 AM, Christian Borntraeger borntrae...@de.ibm.com

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v4 2/3] use uimage_reset to reload uimage

2012-11-19 Thread Alexander Graf
On 16.11.2012, at 07:11, Yin Olivia-R63875 wrote: Hi Stuart, load_uimage() is a public function which is called by below files: hw/dummy_m68k.c:kernel_size = load_uimage(kernel_filename, entry, NULL, NULL); hw/an5206.c:kernel_size =

Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: Fix regression for MinGW (assertion caused by short string)

2012-11-19 Thread Stefan Hajnoczi
On Sun, Nov 18, 2012 at 09:26:15AM +0100, Stefan Weil wrote: The local string tmp_filename is passed to function get_tmp_filename which expects a string with minimum size MAX_PATH for w32 hosts. MAX_PATH is 260 and PATH_MAX is 259, so tmp_filename was too short. Commit

Re: [Qemu-devel] [PATCH v3] DSDT: Fix HPET _CRS Method

2012-11-19 Thread Gleb Natapov
On Mon, Nov 19, 2012 at 11:22:48AM +0100, Alexander Graf wrote: On 16.11.2012, at 19:46, Kevin O'Connor wrote: On Fri, Nov 16, 2012 at 01:02:18PM -0500, Gabriel L. Somlo wrote: ping On Thu, Nov 08, 2012 at 12:35:17PM -0500, Gabriel L. Somlo wrote: Updated _CRS method for HPET,

Re: [Qemu-devel] [Bug 1080086] Re: MC146818 RTC breaks when SET bit in Register B is on.

2012-11-19 Thread Alex Horn
[...] the patch is almost good for inclusion. I'd ask for two changes: 1) please test == 0, not != REG_B_SET; 2) please leave the fuzzicsng test last I have attached a new patch with the requested changes. This patch also improves the quality of the functional test by checking that

Re: [Qemu-devel] [PATCH v3] DSDT: Fix HPET _CRS Method

2012-11-19 Thread Alexander Graf
On 19.11.2012, at 12:33, Gleb Natapov wrote: On Mon, Nov 19, 2012 at 11:22:48AM +0100, Alexander Graf wrote: On 16.11.2012, at 19:46, Kevin O'Connor wrote: On Fri, Nov 16, 2012 at 01:02:18PM -0500, Gabriel L. Somlo wrote: ping On Thu, Nov 08, 2012 at 12:35:17PM -0500, Gabriel L. Somlo

Re: [Qemu-devel] [PATCH] virtio-blk: Remove duplicate property definition

2012-11-19 Thread Stefan Hajnoczi
On Thu, Nov 15, 2012 at 01:12:14PM +1100, David Gibson wrote: For the virtio-blk device (via virtio-pci) the property config-wce is defined in two places. First, it's defined from the DEFINE_VIRTIO_BLK_FEATURES macro, second it's defined directly in virtio-pci, just two lines above the call

Re: [Qemu-devel] [PATCH v2 000/147] target-s390 reorg

2012-11-19 Thread Alexander Graf
Hey Richard, On 16.11.2012, at 01:09, Richard Henderson wrote: Ping. I've updated the branch at git://repo.or.cz/qemu/rth.git s390-reorg to rebase vs mainline (ce34cf72fe508b27a78f83c184142e8d1e6a048a). There are minor changes due to Aurel's TCG_CALL_NO_* rewrite, but is otherwise

Re: [Qemu-devel] [PATCH] block: vpc initialize the uuid footer field

2012-11-19 Thread Stefan Hajnoczi
On Fri, Nov 02, 2012 at 09:54:24AM -0600, Charles Arnold wrote: block/vpc: Initialize the uuid field in the footer with a generated uuid. Signed-off-by: Charles Arnold carn...@suse.com Thanks, applied to the block-next tree: https://github.com/stefanha/qemu/commits/block-next Stefan

Re: [Qemu-devel] [Bug 1080086] Re: MC146818 RTC breaks when SET bit in Register B is on.

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 12:34, Alex Horn ha scritto: [...] the patch is almost good for inclusion. I'd ask for two changes: 1) please test == 0, not != REG_B_SET; 2) please leave the fuzzicsng test last I have attached a new patch with the requested changes. This patch also improves the quality of

Re: [Qemu-devel] [Bug 1080086] Re: MC146818 RTC breaks when SET bit in Register B is on.

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 12:34, Alex Horn ha scritto: I have attached a new patch with the requested changes. Could you please resend it using git send-email, so that it has a commit message and a Signed-off-by: Alex Horn ...@... line? Thanks! Paolo

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Stefan Priebe - Profihost AG
Am 19.11.2012 12:16, schrieb Paolo Bonzini: Il 19/11/2012 11:57, Stefan Priebe - Profihost AG ha scritto: Yeah thats my old thread regarding iscsi und unmap but this works fine now since you patched qemu. It still causes hangs no? Though it works apart from that. iscsi/libiscsi and

Re: [Qemu-devel] [PATCH] block: vpc support for ~2 TB disks

2012-11-19 Thread Stefan Hajnoczi
On Tue, Oct 30, 2012 at 08:59:32PM -0600, Charles Arnold wrote: The VHD specification allows for up to a 2 TB disk size. The current implementation in qemu emulates EIDE and ATA-2 hardware which only allows for up to 127 GB. This disk size limitation can be overridden by allowing up to 255

Re: [Qemu-devel] [PATCH v3] DSDT: Fix HPET _CRS Method

2012-11-19 Thread Gleb Natapov
On Mon, Nov 19, 2012 at 12:35:47PM +0100, Alexander Graf wrote: On 19.11.2012, at 12:33, Gleb Natapov wrote: On Mon, Nov 19, 2012 at 11:22:48AM +0100, Alexander Graf wrote: On 16.11.2012, at 19:46, Kevin O'Connor wrote: On Fri, Nov 16, 2012 at 01:02:18PM -0500, Gabriel L. Somlo

Re: [Qemu-devel] [PATCH] raw-posix: inline paio_ioctl into hdev_aio_ioctl

2012-11-19 Thread Stefan Hajnoczi
On Fri, Nov 02, 2012 at 04:14:20PM +0100, Paolo Bonzini wrote: clang now warns about an unused function: CCblock/raw-posix.o block/raw-posix.c:707:26: warning: unused function paio_ioctl [-Wunused-function] static BlockDriverAIOCB *paio_ioctl(BlockDriverState *bs, int fd,

Re: [Qemu-devel] [PATCH v3] DSDT: Fix HPET _CRS Method

2012-11-19 Thread Alexander Graf
On 19.11.2012, at 12:51, Gleb Natapov wrote: On Mon, Nov 19, 2012 at 12:35:47PM +0100, Alexander Graf wrote: On 19.11.2012, at 12:33, Gleb Natapov wrote: On Mon, Nov 19, 2012 at 11:22:48AM +0100, Alexander Graf wrote: On 16.11.2012, at 19:46, Kevin O'Connor wrote: On Fri, Nov 16,

Re: [Qemu-devel] buildbot failure in qemu on rhel5-default

2012-11-19 Thread Alexander Graf
On 15.11.2012, at 12:28, Peter Maydell wrote: On 15 November 2012 08:22, Gerd Hoffmann kra...@redhat.com wrote: CCs390x-softmmu/hw/s390x/event-facility.o cc1: warnings being treated as errors /home/buildbot/slave-spunk/rhel5-default/build/hw/s390x/event-facility.c: In function

Re: [Qemu-devel] [PATCH v3] DSDT: Fix HPET _CRS Method

2012-11-19 Thread Gleb Natapov
On Mon, Nov 19, 2012 at 01:00:56PM +0100, Alexander Graf wrote: On 19.11.2012, at 12:51, Gleb Natapov wrote: On Mon, Nov 19, 2012 at 12:35:47PM +0100, Alexander Graf wrote: On 19.11.2012, at 12:33, Gleb Natapov wrote: On Mon, Nov 19, 2012 at 11:22:48AM +0100, Alexander Graf wrote:

[Qemu-devel] [Bug 1080086] Re: MC146818 RTC breaks when SET bit in Register B is on.

2012-11-19 Thread Alex Horn
Cross reference: https://lists.gnu.org/archive/html/qemu-devel/2012-11/msg01759.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1080086 Title: MC146818 RTC breaks when SET bit in Register B

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 12:49, Stefan Priebe - Profihost AG ha scritto: It still causes hangs no? Though it works apart from that. iscsi/libiscsi and discards works fine since your latest patches: 1bd075f29ea6d11853475c7c42734595720c3ac6 cfb3f5064af2d2e29c976e292c9472dfe9d61e31

[Qemu-devel] KVM call agenda for 2012-11-20

2012-11-19 Thread Juan Quintela
Hi Please send in any agenda topics you are interested in. Later, Juan.

[Qemu-devel] [Bug 1080086] Re: MC146818 RTC breaks when SET bit in Register B is on.

2012-11-19 Thread Alex Horn
** Attachment added: register_b_set_flag_v2.patch https://bugs.launchpad.net/bugs/1080086/+attachment/3438594/+files/register_b_set_flag_v2.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Stefan Priebe - Profihost AG
Am 19.11.2012 13:24, schrieb Paolo Bonzini: Il 19/11/2012 12:49, Stefan Priebe - Profihost AG ha scritto: It still causes hangs no? Though it works apart from that. iscsi/libiscsi and discards works fine since your latest patches: 1bd075f29ea6d11853475c7c42734595720c3ac6

[Qemu-devel] [PATCH] m25p80: Fix wrong jedec id for Numonyx n25q128

2012-11-19 Thread Liming Wang
The jedec id of n25q128 should be 0x20bb18, not 0x20ba18. Signed-off-by: Liming Wang walimis...@gmail.com --- hw/m25p80.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/m25p80.c b/hw/m25p80.c index 3895e73..58ae754 100644 --- a/hw/m25p80.c +++ b/hw/m25p80.c @@ -177,7

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 14:01, Stefan Priebe - Profihost AG ha scritto: The right behavior is to return only after the target says whether the cancellation was done or not. For libiscsi, it was implemented by the commits you mention. So the whole bunch of changes is needed for rbd? Something like the

Re: [Qemu-devel] [PATCH 06/24] Remove local ram_size that hides global one

2012-11-19 Thread Alexander Graf
On 13.11.2012, at 13:11, Christian Borntraeger wrote: From: Heinz Graalfs graa...@linux.vnet.ibm.com The global variable 'ram_size' is hidden by the local variable declaration in s390_init() That's the point of Eduardo's patch, no? Or do we need access to the global to change its value

Re: [Qemu-devel] [PATCH 06/24] Remove local ram_size that hides global one

2012-11-19 Thread Peter Maydell
On 19 November 2012 13:14, Alexander Graf ag...@suse.de wrote: On 13.11.2012, at 13:11, Christian Borntraeger wrote: From: Heinz Graalfs graa...@linux.vnet.ibm.com The global variable 'ram_size' is hidden by the local variable declaration in s390_init() That's the point of Eduardo's

[Qemu-devel] no monitor after disable vnc

2012-11-19 Thread Peter Cheung
Dear All When i compile qemu in ubuntu 12.10 with ./configure --target-list=i386-softmmu --prefix=/root/qemu --enable-debug --disable-vnc --disable-werror , after i start qemu, no screen output, how to enable it? Thanksfrom Peter

Re: [Qemu-devel] [PATCH 2/3] s390: Virtual channel subsystem support.

2012-11-19 Thread Alexander Graf
On 31.10.2012, at 17:24, Cornelia Huck wrote: Provide a mechanism for qemu to provide fully virtual subchannels to the guest. In the KVM case, this relies on the kernel's css support for I/O and machine check interrupt handling. The !KVM case handles interrupts on its own. Signed-off-by:

Re: [Qemu-devel] [PATCH 06/24] Remove local ram_size that hides global one

2012-11-19 Thread Eduardo Habkost
On Mon, Nov 19, 2012 at 02:14:27PM +0100, Alexander Graf wrote: On 13.11.2012, at 13:11, Christian Borntraeger wrote: From: Heinz Graalfs graa...@linux.vnet.ibm.com The global variable 'ram_size' is hidden by the local variable declaration in s390_init() That's the point of

Re: [Qemu-devel] [PATCH 1/1] Support default block interfaces per QEMUMachine

2012-11-19 Thread Alexander Graf
On 12.11.2012, at 09:22, Christian Borntraeger wrote: There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a default/standard interface to their block devices / drives. Therfore, this patch introduces a new field default_block per QEMUMachine struct. The prior use_scsi field

Re: [Qemu-devel] no monitor after disable vnc

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 14:25, Peter Cheung ha scritto: Dear All When i compile qemu in ubuntu 12.10 with ./configure --target-list=i386-softmmu --prefix=/root/qemu --enable-debug --disable-vnc --disable-werror , after i start qemu, no screen output, how to enable it? Please attach your config.log.

Re: [Qemu-devel] [PATCH 1/1] Support default block interfaces per QEMUMachine

2012-11-19 Thread Christian Borntraeger
On 19/11/12 14:36, Alexander Graf wrote: On 12.11.2012, at 09:22, Christian Borntraeger wrote: There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a default/standard interface to their block devices / drives. Therfore, this patch introduces a new field default_block per

Re: [Qemu-devel] [PATCH 06/24] Remove local ram_size that hides global one

2012-11-19 Thread Alexander Graf
On 19.11.2012, at 14:35, Eduardo Habkost wrote: On Mon, Nov 19, 2012 at 02:14:27PM +0100, Alexander Graf wrote: On 13.11.2012, at 13:11, Christian Borntraeger wrote: From: Heinz Graalfs graa...@linux.vnet.ibm.com The global variable 'ram_size' is hidden by the local variable

Re: [Qemu-devel] [PATCH 1/1] Support default block interfaces per QEMUMachine

2012-11-19 Thread Alexander Graf
On 19.11.2012, at 14:44, Christian Borntraeger wrote: On 19/11/12 14:36, Alexander Graf wrote: On 12.11.2012, at 09:22, Christian Borntraeger wrote: There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a default/standard interface to their block devices / drives. Therfore,

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-19 Thread Peter Lieven
On 13.11.2012 17:33, Michael S. Tsirkin wrote: On Tue, Nov 13, 2012 at 06:22:56PM +0200, Michael S. Tsirkin wrote: On Tue, Nov 13, 2012 at 12:49:03PM +0100, Peter Lieven wrote: On 09.11.2012 19:03, Peter Lieven wrote: Remark: If i disable interrupts on CPU1-3 for virtio the performance is ok

Re: [Qemu-devel] [PATCH 1/1] Support default block interfaces per QEMUMachine

2012-11-19 Thread Markus Armbruster
Alexander Graf ag...@suse.de writes: On 19.11.2012, at 14:44, Christian Borntraeger wrote: On 19/11/12 14:36, Alexander Graf wrote: On 12.11.2012, at 09:22, Christian Borntraeger wrote: There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a default/standard interface to their

Re: [Qemu-devel] [Bug 1080086] Re: MC146818 RTC breaks when SET bit in Register B is on.

2012-11-19 Thread Alex Horn
Out of curiosity, does anyone know how long this particular bug has been undetected or how/when it was introduced? Probably it was introduced last September when the model was rewritten. But it's really unlikely that the bug would have been detected. Thanks for that quick assessment. On

[Qemu-devel] [PATCH 1/2] slirp: Don't crash on packets from 0.0.0.0/8.

2012-11-19 Thread Jan Kiszka
From: Nickolai Zeldovich nicko...@csail.mit.edu LWIP can generate packets with a source of 0.0.0.0, which triggers an assertion failure in arp_table_add(). Instead of crashing, simply return to avoid adding an invalid ARP table entry. Signed-off-by: Nickolai Zeldovich nicko...@csail.mit.edu

[Qemu-devel] [PATCH 2/2] slirp: Add domain-search option to slirp's DHCP server

2012-11-19 Thread Jan Kiszka
From: Klaus Stengel klaus.sten...@asamnet.de This patch will allow the user to include the domain-search option in replies from the built-in DHCP server. The domain suffixes can be specified by adding dnssearch= entries to the -net user parameter. [Jan: tiny style adjustments] Signed-off-by:

[Qemu-devel] [PATCH 0/2] [PULL] slirp: Fix for ARP assert and DSN search DHCP option

2012-11-19 Thread Jan Kiszka
The following changes since commit ce34cf72fe508b27a78f83c184142e8d1e6a048a: Merge remote-tracking branch 'awilliam/tags/vfio-pci-for-qemu-1.3.0-rc0' into staging (2012-11-14 08:53:40 -0600) are available in the git repository at: git://git.kiszka.org/qemu.git queues/slirp Klaus Stengel

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Stefan Priebe - Profihost AG
Hi Paolo, Hi Josh, i started to port the iscsi fixes to rbd. The one think i'm missing is. How to tell / call rbd to cancel I/O on the server side? I grepped librbd source code for abort / cancel but didn't find anything. Qemu must be able to tell rbd to cancel a specific I/O request.

[Qemu-devel] [PATCH 0/2] i2c: Add AT24Cxx EEPROM model

2012-11-19 Thread Jan Kiszka
See patches for details. Jan Kiszka (2): i2c: Introduce device address mask Add AT24Cxx I2C EEPROM device model hw/Makefile.objs |2 +- hw/at24.c| 363 ++ hw/ds1338.c |2 +- hw/i2c.c |9 +- hw/i2c.h

[Qemu-devel] [PATCH 2/2] Add AT24Cxx I2C EEPROM device model

2012-11-19 Thread Jan Kiszka
This implements I2C EEPROMs of the AT24Cxx series. Sizes from 1Kbit to 1024Kbit are supported. Each EEPROM is backed by a block device. Its size can be explicitly specified by the size property (required for sizes 512, the blockdev sector size) or is derived from the size of the backing block

[Qemu-devel] [PATCH 1/2] i2c: Introduce device address mask

2012-11-19 Thread Jan Kiszka
Some devices react on multiple addresses. To emulate this, we could register them multiple times, but that is cumbersome. The AT24C16, e.g. listens on 8 different addresses. Instead, introduce a device address mask that is applied on the transmitted address before matching it against the stored

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Stefan Priebe - Profihost AG
Hi Paolo, this is my current work status on porting these fixes to rbd. Right now the discards get still canceled by the client kernel. Might you have a look what i have forgotten? Thanks! Stefan Am 19.11.2012 14:06, schrieb Paolo Bonzini: Il 19/11/2012 14:01, Stefan Priebe - Profihost AG

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 15:16, Stefan Priebe - Profihost AG ha scritto: Hi Paolo, Hi Josh, i started to port the iscsi fixes to rbd. The one think i'm missing is. How to tell / call rbd to cancel I/O on the server side? I grepped librbd source code for abort / cancel but didn't find anything.

  1   2   >