[Qemu-devel] [PATCH V2 02/20] net: introduce qemu_get_nic()

2013-01-25 Thread Jason Wang
To support multiqueue, this patch introduces a helper qemu_get_nic() to get NICState from a NetClientState. The following patches would refactor this helper to support multiqueue. Signed-off-by: Jason Wang jasow...@redhat.com --- hw/cadence_gem.c|8 hw/dp8393x.c|

[Qemu-devel] [PATCH V2 03/20] net: intorduce qemu_del_nic()

2013-01-25 Thread Jason Wang
To support multiqueue nic, this patch separate the nic destructor from qemu_del_net_client() to a new helper qemu_del_nic() since the mapping bettween NiCState and NetClientState were not 1:1 in multiqueue. The following patches would refactor this function to support multiqueue nic.

Re: [Qemu-devel] [PATCH v3 05/12] qdev: add reference count to a device for the BusChild

2013-01-25 Thread Andreas Färber
Am 25.01.2013 12:46, schrieb Paolo Bonzini: Each device has a reference through the BusChild. This reference was not accounted for, add it now. Signed-off-by: Paolo Bonzini pbonz...@redhat.com I don't understand the comments about ownership. As far as I understand, there's one ref for the

Re: [Qemu-devel] [PATCH v3 05/12] qdev: add reference count to a device for the BusChild

2013-01-25 Thread Paolo Bonzini
Il 25/01/2013 13:08, Andreas Färber ha scritto: Signed-off-by: Paolo Bonzini pbonz...@redhat.com I don't understand the comments about ownership. As far as I understand, there's one ref for the child list entry and one additional ref for the property but no transfer of ownership. The

Re: [Qemu-devel] [PATCH v3 12/12] qom: remove object_delete

2013-01-25 Thread Paolo Bonzini
Il 25/01/2013 12:56, Andreas Färber ha scritto: - * This function will initialize a new object using heap allocated memory. This - * function should be paired with object_delete() to free the resources - * associated with the object. + * This function will initialize a new object using

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-25 Thread Luiz Capitulino
On Thu, 24 Jan 2013 13:12:08 -0500 Peter Feiner pe...@gridcentric.ca wrote: What about converting 'info registers' to QMP (ie. having query-cpu-registers)? We had thought about it, but we decided to go with this lower hanging fruit because it provides immediately useful functionality at

[Qemu-devel] [PATCH v3 08/12] qdev: add reference for the bus while it is referred to by the DeviceState

2013-01-25 Thread Paolo Bonzini
Now that the unparent callbacks are complete, we can correctly account more missing references. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/qdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/qdev.c b/hw/qdev.c index b3c1e65..37a3542 100644 --- a/hw/qdev.c +++

[Qemu-devel] [PATCH v3 03/12] qom: preserve object while unparenting it

2013-01-25 Thread Paolo Bonzini
Avoid that the object disappears after it's deleted from the QOM composition tree, in case that was the only reference to it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qom/object.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qom/object.c b/qom/object.c index 03e6f24..1a123da

[Qemu-devel] [PATCH v3 02/12] pci: use qbus_create in pci_bus_new

2013-01-25 Thread Paolo Bonzini
Remove knowledge of QOM innards. The common part of pci_bus_new and pci_bus_new_inplace is moved to a new function pci_bus_init. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/pci/pci.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH v3 04/12] qom: document reference counting of link properties

2013-01-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/qom/object.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/qom/object.h b/include/qom/object.h index 8e16ea8..5e8e528 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -1033,6 +1033,11 @@ void

[Qemu-devel] [PATCH v3 05/12] qdev: add reference count to a device for the BusChild

2013-01-25 Thread Paolo Bonzini
Each device has a reference through the BusChild. This reference was not accounted for, add it now. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/qdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/qdev.c b/hw/qdev.c index 59dce62..78eedf0 100644 --- a/hw/qdev.c +++

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-25 Thread Eduardo Habkost
On Fri, Jan 25, 2013 at 10:14:43AM -0200, Luiz Capitulino wrote: On Thu, 24 Jan 2013 13:12:08 -0500 Peter Feiner pe...@gridcentric.ca wrote: What about converting 'info registers' to QMP (ie. having query-cpu-registers)? We had thought about it, but we decided to go with this lower

[Qemu-devel] [PATCH for-1.4 v3 00/12] qdev: correct reference counting

2013-01-25 Thread Paolo Bonzini
This series makes the ref_count field of device and bus objects actually match the number of references that the objects have. Once this is done, the question how do I delete an object? has a simple answer: use object_unparent if the object is reachable from the QOM tree, else use object_unref.

Re: [Qemu-devel] [PATCH v8 0/2] s390: virtio-ccw transport.

2013-01-25 Thread Cornelia Huck
On Thu, 24 Jan 2013 17:17:46 +0100 Alexander Graf ag...@suse.de wrote: On 24.01.2013, at 17:08, Cornelia Huck wrote: Hi, patches against s390-next again, with coding style fixes. Thanks, applied to s390-next. Hm, did you forget to apply 2/2? Alex

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-25 Thread Paolo Bonzini
Il 25/01/2013 13:34, Eduardo Habkost ha scritto: On Fri, Jan 25, 2013 at 10:14:43AM -0200, Luiz Capitulino wrote: On Thu, 24 Jan 2013 13:12:08 -0500 Peter Feiner pe...@gridcentric.ca wrote: What about converting 'info registers' to QMP (ie. having query-cpu-registers)? We had thought

Re: [Qemu-devel] [PATCH v8 0/2] s390: virtio-ccw transport.

2013-01-25 Thread Alexander Graf
On 25.01.2013, at 13:37, Cornelia Huck wrote: On Thu, 24 Jan 2013 17:17:46 +0100 Alexander Graf ag...@suse.de wrote: On 24.01.2013, at 17:08, Cornelia Huck wrote: Hi, patches against s390-next again, with coding style fixes. Thanks, applied to s390-next. Hm, did you forget to

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-25 Thread Luiz Capitulino
On Fri, 25 Jan 2013 13:38:18 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 25/01/2013 13:34, Eduardo Habkost ha scritto: On Fri, Jan 25, 2013 at 10:14:43AM -0200, Luiz Capitulino wrote: On Thu, 24 Jan 2013 13:12:08 -0500 Peter Feiner pe...@gridcentric.ca wrote: What about

[Qemu-devel] [PULL 00/15] s390 patch queue 2013-01-25

2013-01-25 Thread Alexander Graf
Hi Blue / Aurelien, This is my current patch queue for s390. Please pull. Alex The following changes since commit 11c29918be32be5b00f367c7da9724a5cddbbb0f: Anthony Liguori (1): Merge remote-tracking branch 'bonzini/scsi-next' into staging are available in the git repository at:

[Qemu-devel] [PATCH 04/15] s390: Channel I/O basic definitions.

2013-01-25 Thread Alexander Graf
From: Cornelia Huck cornelia.h...@de.ibm.com Basic channel I/O structures and helper function. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Alexander Graf ag...@suse.de --- target-s390x/Makefile.objs |2 +- target-s390x/cpu.h |1 + target-s390x/ioinst.c

[Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions.

2013-01-25 Thread Alexander Graf
From: Cornelia Huck cornelia.h...@de.ibm.com Provide handlers for (most) channel I/O instructions. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Alexander Graf ag...@suse.de --- target-s390x/cpu.h| 100 +++ target-s390x/ioinst.c | 716

[Qemu-devel] [PATCH 03/15] s390: Add mapping helper functions.

2013-01-25 Thread Alexander Graf
From: Cornelia Huck cornelia.h...@de.ibm.com Add s390_cpu_physical_memory_{map,unmap} with special handling for the lowcore. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Alexander Graf ag...@suse.de --- target-s390x/cpu.h|4 target-s390x/helper.c | 25

[Qemu-devel] [PATCH 10/15] s390: Add new channel I/O based virtio transport.

2013-01-25 Thread Alexander Graf
From: Cornelia Huck cornelia.h...@de.ibm.com Add a new virtio transport that uses channel commands to perform virtio operations. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Alexander Graf ag...@suse.de --- hw/s390x/Makefile.objs |1 + hw/s390x/virtio-ccw.c | 960

[Qemu-devel] [PATCH v3 09/12] qdev: inline object_delete into qbus_free/qdev_free

2013-01-25 Thread Paolo Bonzini
We want object_delete to disappear, and we will do this one class at a time. Inline it for the qdev case, which we will tackle first. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/qdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c

[Qemu-devel] [PULL 00/21] ppc patch queue 2013-01-25

2013-01-25 Thread Alexander Graf
Hi Blue / Aurelien, This is my current patch queue for ppc. Please pull. Alex The following changes since commit 11c29918be32be5b00f367c7da9724a5cddbbb0f: Anthony Liguori (1): Merge remote-tracking branch 'bonzini/scsi-next' into staging are available in the git repository at:

[Qemu-devel] [PATCH 02/21] macio: QOM'ify some more

2013-01-25 Thread Alexander Graf
From: Andreas Färber afaer...@suse.de Move bar MemoryRegion initialization to an instance_init. Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Alexander Graf ag...@suse.de --- hw/macio.c | 25 +++-- 1 files changed, 19 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PATCH 03/21] macio: Delay qdev init until all fields are initialized

2013-01-25 Thread Alexander Graf
From: Andreas Färber afaer...@suse.de This turns macio_bar_setup() into an implementation detail of the qdev initfn, to be removed step by step. Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Alexander Graf ag...@suse.de --- hw/macio.c | 11 --- 1 files changed, 8

[Qemu-devel] [PATCH 18/21] openpic: add basic support for MPIC v4.2

2013-01-25 Thread Alexander Graf
From: Scott Wood scottw...@freescale.com Besides the new value in the version register, this provides: - ILR support, which includes: - IDR becoming a pure CPU bitmap, allowing 32 CPUs - machine check output support (though other parts of QEMU need to be fixed for it to do something other

[Qemu-devel] [PATCH 20/21] PPC: e500: Select MPIC v4.2 on ppce500 platform

2013-01-25 Thread Alexander Graf
From: Scott Wood scottw...@freescale.com The compatible string is changed to fsl,mpic on all e500 platforms, to advertise the existence of BRR1. This matches what the device tree will have on real hardware. With MPIC v4.2 max_cpu can be increased from 15 to 32. Signed-off-by: Scott Wood

[Qemu-devel] [PATCH 14/21] pseries: Improve handling of multiple PCI host bridges

2013-01-25 Thread Alexander Graf
From: David Gibson da...@gibson.dropbear.id.au Multiple - even many - PCI host bridges (i.e. PCI domains) are very common on real PAPR compliant hardware. For reasons related to the PAPR specified IOMMU interfaces, PCI device assignment with VFIO will generally require at least two (virtual)

Re: [Qemu-devel] [PATCH 3/6] vpc: Fix bdrv_open() error handling

2013-01-25 Thread Kevin Wolf
Am 24.01.2013 14:09, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Return -errno instead of -1 on errors. While touching the code, fix a memory leak. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vpc.c | 36 +--- 1 files changed,

Re: [Qemu-devel] [PATCH 5/5] PPC: e500: Select MPIC v4.2 on ppce500 platform

2013-01-25 Thread Alexander Graf
On 22.01.2013, at 02:53, Scott Wood wrote: The compatible string is changed to fsl,mpic on all e500 platforms, to advertise the existence of BRR1. This matches what the device tree will have on real hardware. With MPIC v4.2 max_cpu can be increased from 15 to 32. Signed-off-by: Scott

[Qemu-devel] [PATCH 04/21] macio: Split MacIO in two

2013-01-25 Thread Alexander Graf
From: Andreas Färber afaer...@suse.de Let the machines create two different types. This prepares to move knowledge about sub-devices from the machines into the devices. Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Alexander Graf ag...@suse.de --- hw/macio.c| 97

[Qemu-devel] [PATCH 14/15] s390-virtio: Check for NULL device in reset hypercall

2013-01-25 Thread Alexander Graf
From: Andreas Färber afaer...@suse.de s390_virtio_bus_find_mem() may return a NULL VirtIOS390Device. If called with, e.g., args[0] == 0, this leads to a segfault. Fix this by adding error handling as done for other hypercalls. Present since baf0b55a9e57b909b1f8b0f732c0b10242867418 (Implement

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-25 Thread Andreas Färber
Am 25.01.2013 13:45, schrieb Luiz Capitulino: On Fri, 25 Jan 2013 13:38:18 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 25/01/2013 13:34, Eduardo Habkost ha scritto: We already have CPU QOM objects, we just need to add a methods/properties so each per-architecture subclass will

[Qemu-devel] [PATCH v3 06/12] qdev: move deletion of children from finalize to unparent

2013-01-25 Thread Paolo Bonzini
A device will never be finalized as long as it has a reference from other devices that sit on its buses. To ensure that the references go away, deassociate a bus from its children in the unparent callback for the bus. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/qdev.c | 37

[Qemu-devel] [PATCH v4 11/13] qdev: drop extra references at creation time

2013-01-25 Thread Paolo Bonzini
qdev_free and qbus_free have to do unparent+unref, because nobody else drops the initial reference (the one included by object_initialize) before them. For device_init_func and do_device_add, this is trivially correct, since the DeviceState goes out of scope. For qdev_create, qdev_try_create and

[Qemu-devel] [PATCH v4 10/13] qdev: inline object_delete into qbus_free/qdev_free

2013-01-25 Thread Paolo Bonzini
We want object_delete to disappear, and we will do this one class at a time. Inline it for the qdev case, which we will tackle first. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/qdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c

[Qemu-devel] [PATCH v4 13/13] qom: remove object_delete

2013-01-25 Thread Paolo Bonzini
This is now unused. Document the initial reference count of an object and when it will be freed/finalized. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/qom/object.h | 27 ++- qom/object.c | 7 --- 2 files changed, 10 insertions(+), 24

[Qemu-devel] [PATCH 12/15] virtio-s390: add a reset function to virtio-s390 devices

2013-01-25 Thread Alexander Graf
From: Paolo Bonzini pbonz...@redhat.com virtio-s390 devices are not being reset when their bus is. To fix this, add a reset method that forwards to virtio_reset. This is only needed because of the strange modeling of virtio devices; the -vdev link is being handled manually rather than through

[Qemu-devel] [PATCH v3 07/12] qdev: move unrealization of devices from finalize to unparent

2013-01-25 Thread Paolo Bonzini
Similarly, a bus holds a reference back to the device, and this will prevent the device from going away as soon as this reference is counted properly. To avoid this, move the unrealization of devices to the unparent callback. This includes recursively unparenting all the buses and (after the

[Qemu-devel] [PATCH 08/15] s390: Wire up channel I/O in kvm.

2013-01-25 Thread Alexander Graf
From: Cornelia Huck cornelia.h...@de.ibm.com Trigger the code for our virtual css in case of instruction intercepts for I/O instructions. Handle the tsch exit for the subchannel-related part of tsch. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Alexander Graf

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-25 Thread Andreas Färber
Am 25.01.2013 13:14, schrieb Luiz Capitulino: On Thu, 24 Jan 2013 13:12:08 -0500 Peter Feiner pe...@gridcentric.ca wrote: What about converting 'info registers' to QMP (ie. having query-cpu-registers)? We had thought about it, but we decided to go with this lower hanging fruit because it

[Qemu-devel] [PATCH v3 10/12] qdev: drop extra references at creation time

2013-01-25 Thread Paolo Bonzini
qdev_free and qbus_free have to do unparent+unref, because nobody else drops the initial reference (the one included by object_initialize) before them. For device_init_func and do_device_add, this is trivially correct, since the DeviceState goes out of scope. For qdev_create, qdev_try_create and

[Qemu-devel] [PATCH v3 12/12] qom: remove object_delete

2013-01-25 Thread Paolo Bonzini
This is now unused. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/qom/object.h | 17 ++--- qom/object.c | 7 --- 2 files changed, 2 insertions(+), 22 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h index 5e8e528..2ac35a5 100644 ---

[Qemu-devel] [PATCH] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema

2013-01-25 Thread Michal Privoznik
Currently, we are using 'tray_open' in QMP and 'tray-open' in HMP. However, the QMP documentation was mistakenly using the HMP version. --- qmp-commands.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index cbf1280..870ee54 100644 ---

[Qemu-devel] [PATCH v4 08/13] qdev: move unrealization of devices from finalize to unparent

2013-01-25 Thread Paolo Bonzini
Similarly, a bus holds a reference back to the device, and this will prevent the device from going away as soon as this reference is counted properly. To avoid this, move the unrealization of devices to the unparent callback. This includes recursively unparenting all the buses and (after the

[Qemu-devel] [PATCH v4 12/13] cpu: do not use object_delete

2013-01-25 Thread Paolo Bonzini
CPUs are never added to the composition tree, so delete is achieved simply by removing the last references to them. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- linux-user/syscall.c| 2 +- target-i386/helper.c| 4 ++-- target-ppc/translate_init.c | 2 +-

Re: [Qemu-devel] [PATCH for-1.4 v4 01/12] ppc: Move Mac machines to hw/ppc/

2013-01-25 Thread Peter Maydell
On 25 January 2013 12:49, Andreas Färber afaer...@suse.de wrote: Am 25.01.2013 11:43, schrieb Peter Maydell: ...so why is a big code movement patch 1.4 material? I would prefer us to wait for 1.5, and then we have a reasonable chance of saying release goal for 1.5 is to have moved all the

Re: [Qemu-devel] [PATCH 3/6] vpc: Fix bdrv_open() error handling

2013-01-25 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 24.01.2013 14:09, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Return -errno instead of -1 on errors. While touching the code, fix a memory leak. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vpc.c | 36

Re: [Qemu-devel] [Openstack][Sheepdog][Libvirt][Qemu]Add a new block storage driver by Libvirt/Qemu way for Openstack

2013-01-25 Thread MORITA Kazutaka
At Fri, 25 Jan 2013 19:05:06 +0800, harryxiyou wrote: On Sat, Jan 19, 2013 at 10:04 PM, MORITA Kazutaka morita.kazut...@gmail.com wrote: [...] If you do the above work, I think you can use your file system with OpenStack. But I suggest doing them step by step. If your file system is

Re: [Qemu-devel] [PATCH for-1.4 v4 01/12] ppc: Move Mac machines to hw/ppc/

2013-01-25 Thread Alexander Graf
On 25.01.2013, at 14:33, Peter Maydell wrote: On 25 January 2013 12:49, Andreas Färber afaer...@suse.de wrote: Am 25.01.2013 11:43, schrieb Peter Maydell: ...so why is a big code movement patch 1.4 material? I would prefer us to wait for 1.5, and then we have a reasonable chance of saying

[Qemu-devel] [PATCH v4 04/13] qom: preserve object while unparenting it

2013-01-25 Thread Paolo Bonzini
Avoid that the object disappears after it's deleted from the QOM composition tree, in case that was the only reference to it. Acked-by: Andreas Färber afaer...@suse.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qom/object.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Qemu-devel] [PULL 00/21] ppc patch queue 2013-01-25

2013-01-25 Thread Andreas Färber
Am 25.01.2013 13:52, schrieb Alexander Graf: Hi Blue / Aurelien, This is my current patch queue for ppc. Please pull. Alex The following changes since commit 11c29918be32be5b00f367c7da9724a5cddbbb0f: Anthony Liguori (1): Merge remote-tracking branch 'bonzini/scsi-next'

Re: [Qemu-devel] [PATCH for-1.4 v4 01/12] ppc: Move Mac machines to hw/ppc/

2013-01-25 Thread Peter Maydell
On 25 January 2013 13:37, Alexander Graf ag...@suse.de wrote: On 25.01.2013, at 14:33, Peter Maydell wrote: On 25 January 2013 12:49, Andreas Färber afaer...@suse.de wrote: Am 25.01.2013 11:43, schrieb Peter Maydell: You so far refused to have new SoCs/devices put in hw/arm/. Doing so does

[Qemu-devel] [PATCH 08/21] ide/macio: QOM'ify MacIO IDE

2013-01-25 Thread Alexander Graf
From: Andreas Färber afaer...@suse.de It was not qdev'ified before. Turn it into a SysBusDevice. Embed them into the MacIO devices. Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Alexander Graf ag...@suse.de --- hw/ide.h |4 -- hw/ide/macio.c| 78

[Qemu-devel] [PATCH 21/21] PPC: Move ppc specific hw emulation to hw/ppc

2013-01-25 Thread Alexander Graf
This patch moves all PowerPC specific hardware emulation except for PREP to hw/ppc. Signed-off-by: Alexander Graf ag...@suse.de --- MAINTAINERS | 16 hw/Makefile.objs | 16 +--- hw/ppc/Makefile.objs | 38

Re: [Qemu-devel] [PATCH 3/3] QAPI: Introduce memchar-read QMP command

2013-01-25 Thread Luiz Capitulino
On Fri, 25 Jan 2013 00:03:21 +0800 Lei Li li...@linux.vnet.ibm.com wrote: +MemCharRead *qmp_memchar_read(const char *device, int64_t size, + bool has_format, enum DataFormat format, + Error **errp) +{ +CharDriverState *chr; +

Re: [Qemu-devel] [PULL 00/21] ppc patch queue 2013-01-25

2013-01-25 Thread Alexander Graf
On 25.01.2013, at 14:40, Andreas Färber wrote: Am 25.01.2013 13:52, schrieb Alexander Graf: Hi Blue / Aurelien, This is my current patch queue for ppc. Please pull. Alex The following changes since commit 11c29918be32be5b00f367c7da9724a5cddbbb0f: Anthony Liguori (1):

Re: [Qemu-devel] [RESEND PATCH for 1.4 v11 0/3] char: Add CirMemCharDriver and provide QMP interface

2013-01-25 Thread Luiz Capitulino
On Fri, 25 Jan 2013 00:03:18 +0800 Lei Li li...@linux.vnet.ibm.com wrote: Hi Anthony, Resubmit this series with your comments squashed in and Luiz's new comments fixed up. I will push console command part in another thread. Applied to the qmp branch, thanks.

Re: [Qemu-devel] [PATCH for-1.4 v4 01/12] ppc: Move Mac machines to hw/ppc/

2013-01-25 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 25.01.2013 14:33, schrieb Peter Maydell: On 25 January 2013 12:49, Andreas Färber afaer...@suse.de wrote: Am 25.01.2013 11:43, schrieb Peter Maydell: ...so why is a big code movement patch 1.4 material? I would prefer us to wait for 1.5, and

Re: [Qemu-devel] [PATCH for-1.4 v4 01/12] ppc: Move Mac machines to hw/ppc/

2013-01-25 Thread Alexander Graf
On 25.01.2013, at 14:40, Peter Maydell wrote: On 25 January 2013 13:37, Alexander Graf ag...@suse.de wrote: On 25.01.2013, at 14:33, Peter Maydell wrote: On 25 January 2013 12:49, Andreas Färber afaer...@suse.de wrote: Am 25.01.2013 11:43, schrieb Peter Maydell: You so far refused to have

[Qemu-devel] [PATCH v4 02/13] qdev: change first argument of qbus_create_inplace to void *

2013-01-25 Thread Paolo Bonzini
Make it clear that no BUS() macro is needed in the callers (in fact it wouldn't work because the object has not been initialized yet with the right class). Suggested-by: Andreas Faerber afaer...@suse.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/qdev-core.h | 2 +- hw/qdev.c |

Re: [Qemu-devel] [PATCH] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema

2013-01-25 Thread Eric Blake
On 01/25/2013 06:27 AM, Michal Privoznik wrote: Currently, we are using 'tray_open' in QMP and 'tray-open' in HMP. However, the QMP documentation was mistakenly using the HMP version. --- qmp-commands.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v4 05/13] qom: document reference counting of link properties

2013-01-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/qom/object.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/qom/object.h b/include/qom/object.h index 8e16ea8..5e8e528 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -1033,6 +1033,11 @@ void

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.4 v4 01/12] ppc: Move Mac machines to hw/ppc/

2013-01-25 Thread Alexander Graf
On 25.01.2013, at 14:51, Alexander Graf wrote: On 25.01.2013, at 14:40, Peter Maydell wrote: On 25 January 2013 13:37, Alexander Graf ag...@suse.de wrote: On 25.01.2013, at 14:33, Peter Maydell wrote: On 25 January 2013 12:49, Andreas Färber afaer...@suse.de wrote: Am 25.01.2013 11:43,

[Qemu-devel] [PATCH 11/15] s390: Make typeinfo const

2013-01-25 Thread Alexander Graf
All TypeInfo definitions should be const. Signed-off-by: Alexander Graf ag...@suse.de --- hw/s390x/ipl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index 7cbbf99..86e8415 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -159,7

Re: [Qemu-devel] [PATCH] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema

2013-01-25 Thread Markus Armbruster
Michal Privoznik mpriv...@redhat.com writes: Currently, we are using 'tray_open' in QMP and 'tray-open' in HMP. However, the QMP documentation was mistakenly using the HMP version. Could you point me to where we're using tray_open?

Re: [Qemu-devel] [PATCH for-1.4 v4 01/12] ppc: Move Mac machines to hw/ppc/

2013-01-25 Thread Andreas Färber
Am 25.01.2013 11:43, schrieb Peter Maydell: On 24 January 2013 09:03, Andreas Färber afaer...@suse.de wrote: [PATCH for-1.4 v4 01/12] ppc: Move Mac machines to hw/ppc/ ...so why is a big code movement patch 1.4 material? I would prefer us to wait for 1.5, and then we have a reasonable

[Qemu-devel] [PATCH 11/21] adb: QOM'ify ADB devices

2013-01-25 Thread Alexander Graf
From: Andreas Färber afaer...@suse.de They were not qdev'ified before. Derive ADBDevice from DeviceState and convert reset callbacks to DeviceClass::reset, ADBDevice::opaque pointer to ADBDevice subtypes for mouse and keyboard and adb_{kbd,mouse}_init() to regular qdev functions. Fixing Coding

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.4 v4 01/12] ppc: Move Mac machines to hw/ppc/

2013-01-25 Thread Peter Maydell
On 25 January 2013 13:53, Alexander Graf ag...@suse.de wrote: On 25.01.2013, at 14:51, Alexander Graf wrote: On 25.01.2013, at 14:40, Peter Maydell wrote: Well, I do care, because we should be aiming for some consistency across architectures, whether we do that by moving more files into

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-25 Thread Eduardo Habkost
On Fri, Jan 25, 2013 at 10:45:11AM -0200, Luiz Capitulino wrote: [...] The obvious suggestion is to add query-cpu-registers. I understand this has a few problems (see questions below), but I think the following incremental approach could work: 1. Add a CPURegisters union 2.

Re: [Qemu-devel] [PATCH v4 02/13] qdev: change first argument of qbus_create_inplace to void *

2013-01-25 Thread Andreas Färber
Am 25.01.2013 14:12, schrieb Paolo Bonzini: Make it clear that no BUS() macro is needed in the callers (in fact it wouldn't work because the object has not been initialized yet with the right class). Suggested-by: Andreas Faerber afaer...@suse.de Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 05/21] mac_nvram: Clean up public API

2013-01-25 Thread Alexander Graf
From: Andreas Färber afaer...@suse.de The state data field is accessed in uint8_t quantities, so switch from uint32_t argument and return value to uint8_t. Fix debug format specifiers while at it. Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Alexander Graf ag...@suse.de ---

Re: [Qemu-devel] [PATCH] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema

2013-01-25 Thread Michal Privoznik
On 25.01.2013 14:55, Markus Armbruster wrote: Michal Privoznik mpriv...@redhat.com writes: Currently, we are using 'tray_open' in QMP and 'tray-open' in HMP. However, the QMP documentation was mistakenly using the HMP version. Could you point me to where we're using tray_open? qemu.git

[Qemu-devel] [PATCH 19/21] PPC: e500: fix mpic_iack address

2013-01-25 Thread Alexander Graf
From: Scott Wood scottw...@freescale.com MPIC+0xa0 is IACK for the current CPU. MPIC+0x200a0 is IACK for CPU 0. This fix allows EPR to work with an SMP target. Signed-off-by: Scott Wood scottw...@freescale.com Signed-off-by: Alexander Graf ag...@suse.de --- hw/ppc/e500.c |2 +- 1 files

[Qemu-devel] [PATCH 12/21] cuda: Move ADB bus into CUDA state

2013-01-25 Thread Alexander Graf
From: Andreas Färber afaer...@suse.de Replace the global adb_bus with a CUDA-internal one, accessed using regular qdev child bus accessor. Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Alexander Graf ag...@suse.de --- hw/adb.h |1 - hw/cuda.c |8

[Qemu-devel] [PATCH 15/21] pseries: Adjust default VIO address allocations to play better with libvirt

2013-01-25 Thread Alexander Graf
From: David Gibson da...@gibson.dropbear.id.au Currently, if VIO devices for pseries don't have addresses explicitly allocated, they get automatically numbered from 0x1000. This is in the same general range that libvirt will typically assign VIO device addresses. That means that if there is a

[Qemu-devel] [PATCH v4 09/13] qdev: add reference for the bus while it is referred to by the DeviceState

2013-01-25 Thread Paolo Bonzini
Now that the unparent callbacks are complete, we can correctly account more missing references. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/qdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/qdev.c b/hw/qdev.c index 6f1b311..1dabcad 100644 --- a/hw/qdev.c +++

[Qemu-devel] [PULL 7/7] QAPI: Introduce memchar-read QMP command

2013-01-25 Thread Luiz Capitulino
From: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hmp-commands.hx | 21 + hmp.c| 21 + hmp.h| 1 + qapi-schema.json | 36

[Qemu-devel] [PULL 5/7] qemu-char: Add new char backend CirMemCharDriver

2013-01-25 Thread Luiz Capitulino
From: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-char.c | 114 qemu-options.hx | 10 + 2 files changed, 124 insertions(+) diff

Re: [Qemu-devel] [PATCH v2] s390: Add default support for SCLP console

2013-01-25 Thread Anthony Liguori
Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error, please ignore it or respond here with an explanation. Otherwise, please correct the coding

[Qemu-devel] [PULL 6/7] QAPI: Introduce memchar-write QMP command

2013-01-25 Thread Luiz Capitulino
From: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hmp-commands.hx | 18 ++ hmp.c| 13 + hmp.h| 1 + qapi-schema.json | 38

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-25 Thread Luiz Capitulino
On Fri, 25 Jan 2013 13:51:14 +0100 Andreas Färber afaer...@suse.de wrote: Am 25.01.2013 13:14, schrieb Luiz Capitulino: On Thu, 24 Jan 2013 13:12:08 -0500 Peter Feiner pe...@gridcentric.ca wrote: What about converting 'info registers' to QMP (ie. having query-cpu-registers)? We

Re: [Qemu-devel] [PATCH 3/6] vpc: Fix bdrv_open() error handling

2013-01-25 Thread Kevin Wolf
Am 25.01.2013 14:37, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 24.01.2013 14:09, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Return -errno instead of -1 on errors. While touching the code, fix a memory leak. Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH v4 03/13] pci: use qbus_create in pci_bus_new

2013-01-25 Thread Paolo Bonzini
Remove knowledge of QOM innards. The common part of pci_bus_new and pci_bus_new_inplace is moved to a new function pci_bus_init. Acked-by: Andreas Färber afaer...@suse.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/pci/pci.c | 21 +++-- 1 file changed, 15

Re: [Qemu-devel] [PATCH 0/6] bdrv_open() error return fixes

2013-01-25 Thread Anthony Liguori
Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error, please ignore it or respond here with an explanation. Otherwise, please correct the coding

Re: [Qemu-devel] [PATCH 00/57] target-i386 eflags cleanup and bmi/adx extensions

2013-01-25 Thread Anthony Liguori
Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error, please ignore it or respond here with an explanation. Otherwise, please correct the coding

Re: [Qemu-devel] [PATCH v3] PIIX3: reset the VM when the Reset Control Register's RCPU bit gets set

2013-01-25 Thread Anthony Liguori
Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error, please ignore it or respond here with an explanation. Otherwise, please correct the coding

Re: [Qemu-devel] [PATCH V15 0/9] libqblock qemu block layer library

2013-01-25 Thread Anthony Liguori
Hi, Thank you for submitting your patch series. This patch breaks the build by causing make to fail. Here's the output: GEN i386-softmmu/config-devices.mak GEN x86_64-softmmu/config-devices.mak GEN alpha-softmmu/config-devices.mak GEN arm-softmmu/config-devices.mak GEN

Re: [Qemu-devel] [PATCH 0/7] usb-host: switch to libusb

2013-01-25 Thread Hans de Goede
Hi, On 01/24/2013 04:41 PM, Gerd Hoffmann wrote: Hi, This is the usb patch queue for review. It features a new usb-host implementation which is based on libusb now (patch #7). The other patches are small cleanups and preparations. Cool stuff I esp. like 5/7 and 6/7 as those were on my

Re: [Qemu-devel] [PATCH] add fd limitations for avoiding a buffer overflow

2013-01-25 Thread Stefan Hajnoczi
On Fri, Jan 25, 2013 at 04:14:49PM +0800, Amos Kong wrote: FD_SET() and FD_CLR() are used to add and remove one descriptor from a set, the 'fd' should be less than FD_SETSIZE. Glibc will give a warning and crash the qemu when we set a fd (1024) to a set. # qemu -device

[Qemu-devel] [PULL for-1.4 0/7] QMP queue

2013-01-25 Thread Luiz Capitulino
The changes (since 11c29918be32be5b00f367c7da9724a5cddbbb0f) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Jeff Cody (1): block: Monitor command commit neglects to report some errors Lei Li (3): qemu-char: Add new char backend

[Qemu-devel] Bug with qxl vga memory settings

2013-01-25 Thread Fabio Fantoni
Debugging qxl problem with xen I tested first qemu without xen and I found that qxl memory mapping problem is not only xen related. After some tests with qemu-only I found that -global qxl-vga.vram_size=N and -global qxl-vga.ram_size=N (where N is for example 16384 or 65536) are bugged. Qxl

Re: [Qemu-devel] [PATCH 0/7] usb-host: switch to libusb

2013-01-25 Thread Andreas Färber
Hi, Am 25.01.2013 15:26, schrieb Hans de Goede: On 01/24/2013 04:41 PM, Gerd Hoffmann wrote: This is the usb patch queue for review. It features a new usb-host implementation which is based on libusb now (patch #7). The other patches are small cleanups and preparations. Cool stuff I esp.

Re: [Qemu-devel] [PATCH] vmware_vga: fix out of bounds and invalid rects updating

2013-01-25 Thread Michael Tokarev
25.01.2013 18:15, Anthony Liguori wrote: Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error, please ignore it or respond here with an

[Qemu-devel] [PATCH 01/15] s390: Add default support for SCLP console

2013-01-25 Thread Alexander Graf
The current s390 machine uses the virtio console as default console, but this doesn't mean that we always want to keep it that way for new machines. This patch introduces a way for a machine type to specify that it wants the default console to be an SCLP console, which is a lot closer to what

[Qemu-devel] [PATCH 13/21] target-ppc: Give a meaningful error if too many threads are specified

2013-01-25 Thread Alexander Graf
From: Mike Qiu qiud...@linux.vnet.ibm.com Currently the target-ppc tcg code only supports a single thread. You can specify more, but they're treated identically to multiple cores. On KVM we obviously can't support more threads than the hardware; if more are specified it will cause strange and

Re: [Qemu-devel] [RFC 1/3] qtest: Prepare hypercall support

2013-01-25 Thread Andreas Färber
Am 25.01.2013 12:27, schrieb Alexander Graf: On 23.01.2013, at 11:01, Andreas Färber wrote: diff --git a/include/sysemu/qtest.h b/include/sysemu/qtest.h index 723a4f9..75ab29d 100644 --- a/include/sysemu/qtest.h +++ b/include/sysemu/qtest.h @@ -32,6 +32,8 @@ static inline int

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.4 v4 01/12] ppc: Move Mac machines to hw/ppc/

2013-01-25 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes: On 25 January 2013 13:53, Alexander Graf ag...@suse.de wrote: On 25.01.2013, at 14:51, Alexander Graf wrote: On 25.01.2013, at 14:40, Peter Maydell wrote: Well, I do care, because we should be aiming for some consistency across architectures,

Re: [Qemu-devel] Bug with qxl vga memory settings

2013-01-25 Thread Michael Tokarev
[Adding spice-devel@ back - I don't think we should drop this list, even if it will be a repost there.] I've just a small comment below, -- I haven't gotten to testing it myself yet, was too busy today to do anything useful. 25.01.2013 18:37, Fabio Fantoni wrote: Debugging qxl problem with xen

<    1   2   3   4   >