[Qemu-devel] [PULL 2/7] balloon: drop old stats code API

2013-01-25 Thread Luiz Capitulino
Next commit will re-enable balloon stats with a different interface, but this old code conflicts with it. Let's drop it. It's important to note that the QMP and HMP interfaces are also dropped by this commit. That shouldn't be a problem though, because: 1. All QMP fields are optional 2. This

Re: [Qemu-devel] [PATCH] vmware_vga: fix out of bounds and invalid rects updating

2013-01-25 Thread Anthony Liguori
Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error, please ignore it or respond here with an explanation. Otherwise, please correct the coding

[Qemu-devel] [PATCH v4 07/13] qdev: move deletion of children from finalize to unparent

2013-01-25 Thread Paolo Bonzini
A device will never be finalized as long as it has a reference from other devices that sit on its buses. To ensure that the references go away, deassociate a bus from its children in the unparent callback for the bus. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/qdev.c | 37

[Qemu-devel] [PATCH 01/21] ppc: Move Mac machines to hw/ppc/

2013-01-25 Thread Alexander Graf
From: Andreas Färber afaer...@suse.de Signed-off-by: Andreas Färber afaer...@suse.de [agraf: squash in MAINTAINERS fix] Signed-off-by: Alexander Graf ag...@suse.de --- MAINTAINERS |4 ++-- hw/cuda.c |2 +- hw/grackle_pci.c

[Qemu-devel] [PATCH for-1.4 v4 00/12] qdev: correct reference counting

2013-01-25 Thread Paolo Bonzini
This series makes the ref_count field of device and bus objects actually match the number of references that the objects have. Once this is done, the question how do I delete an object? has a simple answer: use object_unparent if the object is reachable from the QOM tree, else use object_unref.

[Qemu-devel] [PULL 1/7] block: Monitor command commit neglects to report some errors

2013-01-25 Thread Luiz Capitulino
From: Jeff Cody jc...@redhat.com The non-live bdrv_commit() function may return one of the following errors: -ENOTSUP, -EBUSY, -EACCES, -EIO. The only error that is checked in the HMP handler is -EBUSY, so the monitor command 'commit' silently fails for all error cases other than 'Device is in

[Qemu-devel] [PULL 4/7] docs: document virtio-balloon stats

2013-01-25 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- docs/virtio-balloon-stats.txt | 104 ++ 1 file changed, 104 insertions(+) create mode 100644 docs/virtio-balloon-stats.txt diff --git

[Qemu-devel] [PATCH 10/21] adb: QOM'ify Apple Desktop Bus

2013-01-25 Thread Alexander Graf
From: Andreas Färber afaer...@suse.de It was not a qbus before, turn it into a first-class bus and initialize it properly from CUDA. Leave it a global variable as long as devices are not QOM'ified yet. Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Alexander Graf ag...@suse.de ---

[Qemu-devel] [PATCH 05/15] s390: I/O interrupt and machine check injection.

2013-01-25 Thread Alexander Graf
From: Cornelia Huck cornelia.h...@de.ibm.com I/O interrupts are queued per isc. Only crw pending machine checks are supported. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Alexander Graf ag...@suse.de --- target-s390x/cpu.h| 69 +++-

[Qemu-devel] [PATCH 17/21] openpic: fix timer address decoding

2013-01-25 Thread Alexander Graf
From: Scott Wood scottw...@freescale.com The timer memory range begins at 0x10f0, so that address 0x1120 shows up as 0x30, 0x1130 shows up as 0x40, etc. However, the address decoding (other than TFRR) is not adjusted for this, causing the wrong registers to be accessed. Signed-off-by: Scott

[Qemu-devel] [PATCH 09/15] s390-virtio: Factor out some initialization code.

2013-01-25 Thread Alexander Graf
From: Cornelia Huck cornelia.h...@de.ibm.com Some of the machine initialization for s390-virtio will be reused by virtio-ccw. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Alexander Graf ag...@suse.de --- hw/s390-virtio.c | 118

Re: [Qemu-devel] Bug with qxl vga memory settings

2013-01-25 Thread Michael Tokarev
25.01.2013 18:51, Michael Tokarev wrote: I saw also that qemu 1.3 debian package use vgabios from vgabios 0.7 package instead of seabios 1.7.2 package. Can be a problem with qxl? This is wrong. qemu-1.3, and current qemu git tree, uses vgabios 0.7a from http://www.nongnu.org/vgabios/ .

[Qemu-devel] [PATCH qom-cpu for-1.4] cpu: Unconditionalize CPUState fields

2013-01-25 Thread Andreas Färber
Commits fc8c5b8c41ee5ba69d7a2be63b02a08c7b0b155b (Makefile.user: Define CONFIG_USER_ONLY for libuser/) and dd83b06ae61cfa2dc4381ab49f365bd0995fc930 (qom: Introduce CPU class) specifically prepared the qom/cpu.c file to be compiled differently for softmmu and *-user. This broke as part of build

Re: [Qemu-devel] [PATCH qom-cpu for-1.4] cpu: Unconditionalize CPUState fields

2013-01-25 Thread Andreas Färber
Am 25.01.2013 16:27, schrieb Andreas Färber: Commits fc8c5b8c41ee5ba69d7a2be63b02a08c7b0b155b (Makefile.user: Define CONFIG_USER_ONLY for libuser/) and dd83b06ae61cfa2dc4381ab49f365bd0995fc930 (qom: Introduce CPU class) specifically prepared the qom/cpu.c file to be compiled differently for

Re: [Qemu-devel] [PATCH V11 0/4] replace QEMUOptionParameter with QemuOpts parser

2013-01-25 Thread Markus Armbruster
You screwed up your e-mail address: vnet.linux.ibm.com doesn't exist. My review bounced. Please find it on the list.

Re: [Qemu-devel] [PATCH v3 06/12] qdev: move deletion of children from finalize to unparent

2013-01-25 Thread Andreas Färber
Am 25.01.2013 12:46, schrieb Paolo Bonzini: A device will never be finalized as long as it has a reference from other devices that sit on its buses. To ensure that the references go away, deassociate a bus from its children in the unparent callback for the bus. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 07/15] s390: Virtual channel subsystem support.

2013-01-25 Thread Alexander Graf
From: Cornelia Huck cornelia.h...@de.ibm.com Provide a mechanism for qemu to provide fully virtual subchannels to the guest. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Alexander Graf ag...@suse.de --- hw/s390x/Makefile.objs |1 + hw/s390x/css.c | 1277

[Qemu-devel] [PATCH 06/21] mac_nvram: Mark as Big Endian

2013-01-25 Thread Alexander Graf
From: Andreas Färber afaer...@suse.de Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Alexander Graf ag...@suse.de --- hw/mac_nvram.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/mac_nvram.c b/hw/mac_nvram.c index bcde07d..0a22e66 100644 ---

Re: [Qemu-devel] [PATCH] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema

2013-01-25 Thread Eric Blake
On 01/25/2013 07:07 AM, Michal Privoznik wrote: On 25.01.2013 14:55, Markus Armbruster wrote: Michal Privoznik mpriv...@redhat.com writes: Currently, we are using 'tray_open' in QMP and 'tray-open' in HMP. However, the QMP documentation was mistakenly using the HMP version. Could you point

[Qemu-devel] [PATCH 0/4] Fix misuse of atomics in trace/simple.c

2013-01-25 Thread Markus Armbruster
More old news: casting pointers considered harmful, and atomics considered hard to use correctly. Markus Armbruster (4): trace: Fix simple trace dropped event record for big endian trace: Direct access of atomics is verboten, use the API trace: Clean up the try to update atomic until it

[Qemu-devel] [PATCH 1/4] trace: Fix simple trace dropped event record for big endian

2013-01-25 Thread Markus Armbruster
We use atomic operations to keep track of dropped events. Inconveniently, GLib supports only int and void * atomics, but the counter dropped_events is uint64_t. Can't stop commit 62bab732: a quick (gint *)dropped_events bludgeons the compiler into submission. That cast is okay only when int is

[Qemu-devel] [PATCH 2/4] trace: Direct access of atomics is verboten, use the API

2013-01-25 Thread Markus Armbruster
The GLib Reference Manual says: It is very important that all accesses to a particular integer or pointer be performed using only this API and that different sizes of operation are not mixed or used on overlapping memory regions. Never read or assign directly from or to a value --

Re: [Qemu-devel] [PATCH] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema

2013-01-25 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 01/25/2013 07:07 AM, Michal Privoznik wrote: On 25.01.2013 14:55, Markus Armbruster wrote: Michal Privoznik mpriv...@redhat.com writes: Currently, we are using 'tray_open' in QMP and 'tray-open' in HMP. However, the QMP documentation was mistakenly

[Qemu-devel] [PATCH qom-cpu for-1.4?] kvm: Pass CPUState to kvm_on_sigbus_vcpu()

2013-01-25 Thread Andreas Färber
Since commit 20d695a9254c1b086a456d3b79a3c311236643ba (kvm: Pass CPUState to kvm_arch_*) CPUArchState is no longer needed. Allows to change qemu_kvm_eat_signals() argument as well. Signed-off-by: Andreas Färber afaer...@suse.de --- Extracted from my qom-cpu-8 queue. cpus.c |

[Qemu-devel] [PATCH v4 06/13] qdev: add reference count to a device for the BusChild

2013-01-25 Thread Paolo Bonzini
Each device has a reference through the BusChild. This reference was not accounted for, add it now. Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/qdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/qdev.c b/hw/qdev.c index

[Qemu-devel] [PATCH 0/1] sclp default fix

2013-01-25 Thread Christian Borntraeger
Alex, here is a small fix for the sclp console default to make it work with libvirt. Christian Borntraeger (1): sclpconsole: Dont instantiate sclpconsole with nodefaults vl.c | 1 + 1 file changed, 1 insertion(+) -- 1.7.11.4

[Qemu-devel] [PATCH 1/1] sclpconsole: Dont instantiate sclpconsole with nodefaults

2013-01-25 Thread Christian Borntraeger
libvirt specifies nodefaults and creates an sclp console with special parameters. Let qemu follow nodefaults and dont create an sclp console if nodefaults is specified. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/vl.c

[Qemu-devel] [PATCH v4 01/13] qdev: remove duplication between qbus_create and qbus_create_inplace

2013-01-25 Thread Paolo Bonzini
Move the common part to qbus_realize. Acked-by: Andreas Färber afaer...@suse.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/qdev.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 9761016..59dce62 100644 ---

[Qemu-devel] [PATCH 13/15] s390: Move hw files to hw/s390x

2013-01-25 Thread Alexander Graf
This moves all files only used by s390 system emulation to hw/s390x. Signed-off-by: Alexander Graf ag...@suse.de Acked-by: Christian Borntraeger borntrae...@de.ibm.com --- hw/s390x/Makefile.objs |2 -- hw/{ = s390x}/s390-virtio-bus.c |8 hw/{ = s390x}/s390-virtio-bus.h

[Qemu-devel] [PATCH 02/15] s390: Lowcore mapping helper.

2013-01-25 Thread Alexander Graf
From: Cornelia Huck cornelia.h...@de.ibm.com Create a lowcore mapping helper that includes a check for sufficient length. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Alexander Graf ag...@suse.de --- target-s390x/helper.c | 34 +- 1

[Qemu-devel] [PATCH 3/4] trace: Clean up the try to update atomic until it worked loops

2013-01-25 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- trace/simple.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/trace/simple.c b/trace/simple.c index 592ff48..74701e3 100644 --- a/trace/simple.c +++ b/trace/simple.c @@ -171,13 +171,10 @@ static

[Qemu-devel] [PATCH v2 0/6] bdrv_open() error return fixes

2013-01-25 Thread Kevin Wolf
Kevin Wolf (6): bochs: Fix bdrv_open() error handling cloop: Fix bdrv_open() error handling vpc: Fix bdrv_open() error handling dmg: Fix bdrv_open() error handling dmg: Use g_free instead of free parallels: Fix bdrv_open() error handling block/bochs.c | 22 +---

[Qemu-devel] [PATCH v2 4/6] dmg: Fix bdrv_open() error handling

2013-01-25 Thread Kevin Wolf
Return -errno instead of -1 on errors and add error checks in some places that didn't have one. Passing things by reference requires more correct typing, replaced a few off_ts therefore - with a 32-bit off_t this is even a fix for truncation bugs. While touching the code, fix even some more

[Qemu-devel] [PATCH v2 1/6] bochs: Fix bdrv_open() error handling

2013-01-25 Thread Kevin Wolf
Return -errno instead of -1 on errors. While touching the code, fix a memory leak. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/bochs.c | 22 +++--- 1 files changed, 15 insertions(+), 7 deletions(-) diff --git a/block/bochs.c b/block/bochs.c index 3737583..a6eb33d

[Qemu-devel] [PATCH v2 5/6] dmg: Use g_free instead of free

2013-01-25 Thread Kevin Wolf
The buffers are allocated with g_(re)alloc, so use g_free to free them. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/dmg.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/block/dmg.c b/block/dmg.c index 53be25d..6d85801 100644 --- a/block/dmg.c

Re: [Qemu-devel] [PATCH 1/1] sclpconsole: Dont instantiate sclpconsole with nodefaults

2013-01-25 Thread Andreas Färber
Am 25.01.2013 17:00, schrieb Christian Borntraeger: libvirt specifies nodefaults and creates an sclp console with special parameters. Let qemu follow nodefaults and dont create an sclp console if nodefaults is specified. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com don't,

[Qemu-devel] [PATCH v2 3/6] vpc: Fix bdrv_open() error handling

2013-01-25 Thread Kevin Wolf
Return -errno instead of -1 on errors. While touching the code, fix a memory leak. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vpc.c | 42 ++ 1 files changed, 30 insertions(+), 12 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index

[Qemu-devel] [PATCH v2 6/6] parallels: Fix bdrv_open() error handling

2013-01-25 Thread Kevin Wolf
Return -errno instead of -1 on errors. Hey, no memory leak to fix here while we're touching it! Signed-off-by: Kevin Wolf kw...@redhat.com --- block/parallels.c | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git a/block/parallels.c b/block/parallels.c

[Qemu-devel] [PATCH 15/15] s390: Add s390-ccw-virtio machine.

2013-01-25 Thread Alexander Graf
From: Cornelia Huck cornelia.h...@de.ibm.com Add a new machine type, s390-ccw-virtio, making use of the virtio-ccw transport to present virtio devices as channel devices. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Alexander Graf ag...@suse.de --- hw/s390x/Makefile.objs

Re: [Qemu-devel] [PATCHv3 1/2] qemu-img: find the highest offset in use during check

2013-01-25 Thread Eric Blake
On 01/21/2013 10:52 AM, Eric Blake wrote: On 01/21/2013 10:03 AM, Kevin Wolf wrote: Am 21.01.2013 17:27, schrieb Eric Blake: On 01/21/2013 07:25 AM, Federico Simoncelli wrote: This patch adds the support for reporting the highest offset in use by an image. This is particularly useful after a

[Qemu-devel] [PATCH 09/21] cuda: QOM'ify CUDA

2013-01-25 Thread Alexander Graf
From: Andreas Färber afaer...@suse.de It was not qdev'ified before. Turn it into a SysBusDevice and embed it in MacIO. Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Alexander Graf ag...@suse.de --- hw/cuda.c | 95 +

[Qemu-devel] [PATCH 07/21] mac_nvram: QOM'ify MacIO NVRAM

2013-01-25 Thread Alexander Graf
From: Andreas Färber afaer...@suse.de It was not qdev'ified before. Turn it into a SysBusDevice and initialize it via static properties. Prepare Old World specific MacIO state and embed the NVRAM state there. Drop macio_nvram_setup_bar() in favor of sysbus_mmio_map() or direct use of Memory

[Qemu-devel] [PATCH 4/4] trace: Fix location of simpletrace.py in docs

2013-01-25 Thread Markus Armbruster
Missed when commit 4c3b5a48 moved it. Signed-off-by: Markus Armbruster arm...@redhat.com --- docs/tracing.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/tracing.txt b/docs/tracing.txt index 453cc4a..14db3bf 100644 --- a/docs/tracing.txt +++ b/docs/tracing.txt @@

[Qemu-devel] [PATCH v2 2/6] cloop: Fix bdrv_open() error handling

2013-01-25 Thread Kevin Wolf
Return -errno instead of -1 on errors. While touching the code, fix a memory leak. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/cloop.c | 29 +++-- 1 files changed, 19 insertions(+), 10 deletions(-) diff --git a/block/cloop.c b/block/cloop.c index

[Qemu-devel] [PULL 3/7] balloon: re-enable balloon stats

2013-01-25 Thread Luiz Capitulino
The statistics are now available through device properties via a polling mechanism. First a client has to enable polling, then it can query available stats. Polling is enabled by setting an update interval (in seconds) to a property named guest-stats-polling-interval, like this: { execute:

Re: [Qemu-devel] [PATCH v6 00/11] s390: channel I/O support in qemu.

2013-01-25 Thread Anthony Liguori
Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error, please ignore it or respond here with an explanation. Otherwise, please correct the coding

[Qemu-devel] [PATCH 16/21] openpic: fix remaining issues from idr-to-destmask conversion

2013-01-25 Thread Alexander Graf
From: Scott Wood scottw...@freescale.com openpic_update_irq() was checking idr rather than destmask, treating it as if it were a simple bitmap of cpus. Changed to use destmask. IPI delivery was removing bits directly from .idr, without calling write_IRQreg_idr so that the change could be

[Qemu-devel] [PATCH v10 7/7] trace: [stderr] Port to generic event information and new control interface

2013-01-25 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- scripts/tracetool/backend/stderr.py | 27 --- trace/stderr.c | 34 ++ trace/stderr.h | 11 --- 3 files changed, 14 insertions(+),

[Qemu-devel] [PATCH v10 4/7] trace: [monitor] Use new event control interface

2013-01-25 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- monitor.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 9cf419b..dda7cf2 100644 --- a/monitor.c +++ b/monitor.c @@ -735,9 +735,18 @@ static void

[Qemu-devel] [PATCH v10 3/7] trace: Provide a detailed event control interface

2013-01-25 Thread Lluís Vilanova
This interface decouples event obtaining from interaction. Events can be obtained through three different methods: * identifier * name * simple wildcard pattern Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- docs/tracing.txt | 44 --- trace/control-internal.h | 67

[Qemu-devel] [PATCH v10 6/7] trace: [simple] Port to generic event information and new control interface

2013-01-25 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- scripts/tracetool/backend/simple.py | 18 +- trace/simple.c | 32 +--- trace/simple.h |6 +- 3 files changed, 11 insertions(+), 45 deletions(-)

[Qemu-devel] [PATCH v10 1/7] trace: [tracetool] Explicitly identify public backends

2013-01-25 Thread Lluís Vilanova
Public backends are those printed by --list-backends and thus considered valid by the configure script. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- scripts/tracetool.py |4 ++-- scripts/tracetool/backend/__init__.py | 16 +++-

[Qemu-devel] [PATCH v10 0/7] trace: Generic event state description

2013-01-25 Thread Lluís Vilanova
Provides a generic event state description structure (TraceEvent) and a more detailed event control and query interface. This is achieved by creating a new non-public tracing backend (i.e., not selectable by the user at configure time) that will generate the appropriate event description

Re: [Qemu-devel] [PATCH 5/5] PPC: e500: Select MPIC v4.2 on ppce500 platform

2013-01-25 Thread Scott Wood
On 01/25/2013 07:03:02 AM, Alexander Graf wrote: On 22.01.2013, at 02:53, Scott Wood wrote: The compatible string is changed to fsl,mpic on all e500 platforms, to advertise the existence of BRR1. This matches what the device tree will have on real hardware. With MPIC v4.2 max_cpu

[Qemu-devel] [PATCH v10 2/7] trace: Provide a generic tracing event descriptor

2013-01-25 Thread Lluís Vilanova
Uses tracetool to generate a backend-independent tracing event description (struct TraceEvent). The values for such structure are generated with the non-public events backend (events-c frontend). The generation of the defines to check if an event is statically enabled is also moved to the events

[Qemu-devel] [PATCH v10 5/7] trace: [default] Port to generic event information and new control interface

2013-01-25 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- trace/default.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/trace/default.c b/trace/default.c index c9b27a2..6e07a47 100644 --- a/trace/default.c +++ b/trace/default.c @@ -1,7 +1,7 @@ /* * Default

Re: [Qemu-devel] [PATCH 5/5] PPC: e500: Select MPIC v4.2 on ppce500 platform

2013-01-25 Thread Scott Wood
On 01/25/2013 10:38:39 AM, Scott Wood wrote: On 01/25/2013 07:03:02 AM, Alexander Graf wrote: On 22.01.2013, at 02:53, Scott Wood wrote: The compatible string is changed to fsl,mpic on all e500 platforms, to advertise the existence of BRR1. This matches what the device tree will have

Re: [Qemu-devel] [PATCH 1/1] sclpconsole: Dont instantiate sclpconsole with nodefaults

2013-01-25 Thread Alexander Graf
On 25.01.2013, at 17:00, Christian Borntraeger wrote: libvirt specifies nodefaults and creates an sclp console with special parameters. Let qemu follow nodefaults and dont create an sclp console if nodefaults is specified. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com

Re: [Qemu-devel] [PATCH v2 1/3] move socket_set_nodelay to osdep.c

2013-01-25 Thread Blue Swirl
On Tue, Jan 22, 2013 at 9:36 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Jan 21, 2013 at 09:23:28AM +0900, MORITA Kazutaka wrote: diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c index 1542e43..abc6662 100644 --- a/slirp/tcp_subr.c +++ b/slirp/tcp_subr.c @@ -429,8 +429,7 @@

Re: [Qemu-devel] [PATCH] vmware_vga: fix out of bounds and invalid rects updating

2013-01-25 Thread Anthony Liguori
Michael Tokarev m...@tls.msk.ru writes: 25.01.2013 18:15, Anthony Liguori wrote: Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error,

Re: [Qemu-devel] trace: weird issues with makefile dependencies

2013-01-25 Thread Blue Swirl
On Tue, Jan 22, 2013 at 4:40 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 22/01/2013 15:59, Stefan Hajnoczi ha scritto: Why not seriously default to ./build/ for build products and get rid of class in-tree builds? The build still happens inside the working tree by default but it will be

[Qemu-devel] [PATCH] target-cris/helper.c: Update Coding Style

2013-01-25 Thread Andreas Färber
Reindent, add missing braces and drop/adjust whitespace. Prepares for CPUArchState-to-CPUState field movements in cpu_cris_handle_mmu_fault(), do_interruptv10() and do_interrupt(). The remaining functions were so minor that they can be fixed in one go. Signed-off-by: Andreas Färber

Re: [Qemu-devel] [PATCH] vmware_vga: fix out of bounds and invalid rects updating

2013-01-25 Thread Michael Tokarev
25.01.2013 21:08, Anthony Liguori wrote: Michael Tokarev m...@tls.msk.ru writes: 25.01.2013 18:15, Anthony Liguori wrote: WARNING: __func__ should be used instead of gcc specific __FUNCTION__ #73: FILE: hw/vmware_vga.c:300: +fprintf(stderr, %s: update x was 0 (%d)\n, __FUNCTION__,

Re: [Qemu-devel] [PATCH v3] PIIX3: reset the VM when the Reset Control Register's RCPU bit gets set

2013-01-25 Thread Laszlo Ersek
Hi, On 01/25/13 15:18, Anthony Liguori wrote: If you believe this message was sent in error, please ignore it or respond here with an explanation. Otherwise, please correct the coding style issues and resubmit a new version of the patch. For more information about QEMU coding style,

Re: [Qemu-devel] [PATCH for-1.4 qom-cpu 6/9] pc: Set fw_cfg data based on APIC ID calculation

2013-01-25 Thread Blue Swirl
On Wed, Jan 23, 2013 at 5:09 PM, Eduardo Habkost ehabk...@redhat.com wrote: On Wed, Jan 23, 2013 at 05:33:25PM +0100, Andreas Färber wrote: Am 22.01.2013 21:25, schrieb Eduardo Habkost: This changes FW_CFG_MAX_CPUS and FW_CFG_NUMA to use apic_id_for_cpu(), so the NUMA table can be based on

[Qemu-devel] (no subject)

2013-01-25 Thread Michael Tokarev
--- v2: change __FUNCTION__ to __func__ according to qemu coding style

[Qemu-devel] [PATCH v2] vmware_vga: fix out of bounds and invalid rects updating

2013-01-25 Thread Michael Tokarev
This is a follow up for several attempts to fix this issue. Previous incarnations: 1. http://thread.gmane.org/gmane.linux.ubuntu.bugs.general/3156089 https://bugs.launchpad.net/bugs/918791 qemu-kvm dies when using vmvga driver and unity in the guest bug. Fix by Serge Hallyn:

Re: [Qemu-devel] [PATCH v3] PIIX3: reset the VM when the Reset Control Register's RCPU bit gets set

2013-01-25 Thread Peter Maydell
On 25 January 2013 17:20, Laszlo Ersek ler...@redhat.com wrote: The subscript operator [] is used here in the type name of a compound literal which is probably not what the script intends to catch. 1945 # check for spacing round square brackets; allowed: 1946 # 1. with a type on the

Re: [Qemu-devel] [PATCH for-1.4 qom-cpu 6/9] pc: Set fw_cfg data based on APIC ID calculation

2013-01-25 Thread Eduardo Habkost
On Fri, Jan 25, 2013 at 05:22:33PM +, Blue Swirl wrote: On Wed, Jan 23, 2013 at 5:09 PM, Eduardo Habkost ehabk...@redhat.com wrote: On Wed, Jan 23, 2013 at 05:33:25PM +0100, Andreas Färber wrote: [...] -numa_fw_cfg = g_new0(uint64_t, 1 + max_cpus + nb_numa_nodes); +numa_fw_cfg

Re: [Qemu-devel] [PATCH for-1.4 qom-cpu 8/9 v6] target-i386: Topology APIC ID utility functions

2013-01-25 Thread Blue Swirl
On Thu, Jan 24, 2013 at 12:07 PM, Eduardo Habkost ehabk...@redhat.com wrote: On Wed, Jan 23, 2013 at 08:49:58PM +0100, Andreas Färber wrote: Am 23.01.2013 18:58, schrieb Eduardo Habkost: This introduces utility functions for the APIC ID calculation, based on: Intel® 64 Architecture

Re: [Qemu-devel] [PATCH V2 2/6] hw/mdio: Generalize etraxfs MDIO bitbanging emulation (fwd)

2013-01-25 Thread Paul Brook
To be able to create generic GPIO devices or other devices that have GPIO like pins (e.g MDIO), and hook those up to external buses through common frameworks, we need agreement on how to model tristate pins. A tristate pin model, or at least agreement on how to model these with multiple

Re: [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions

2013-01-25 Thread Blue Swirl
On Thu, Jan 24, 2013 at 5:17 PM, Andreas Färber afaer...@suse.de wrote: Am 17.01.2013 21:13, schrieb Blue Swirl: On Mon, Jan 14, 2013 at 9:09 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Tell me what you consider the correct tab width for readers and I'll find a piece of QEMU code that was

Re: [Qemu-devel] [PATCH] block: Create proper size file for disk mirror

2013-01-25 Thread Vishvananda Ishaya
On Jan 25, 2013, at 1:18 AM, Kevin Wolf kw...@redhat.com wrote: Am 24.01.2013 19:00, schrieb Vishvananda Ishaya: The qmp monitor command to mirror a disk was passing -1 for size along with the disk's backing file. This size of the resulting disk is the size of the backing file, which is

Re: [Qemu-devel] [PATCH 00/57] target-i386 eflags cleanup and bmi/adx extensions

2013-01-25 Thread Richard Henderson
On 2013-01-25 06:18, Anthony Liguori wrote: Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error, please ignore it or respond here with an

Re: [Qemu-devel] [PATCH v2] vmware_vga: fix out of bounds and invalid rects updating

2013-01-25 Thread BALATON Zoltan
On Fri, 25 Jan 2013, Michael Tokarev wrote: But since vmsvga_update_rect() has other sanity checks already, I'm adding the missing ones there as well. Cc'ing BALATON Zoltan and Andrzej Zaborowski who shows in `git blame' output and may know something in this area. I've proposed this patch

Re: [Qemu-devel] [PATCH V5 03/13] block: add bdrv_can_read_snapshot() function

2013-01-25 Thread Eric Blake
On 01/23/2013 07:57 PM, Wenchao Xia wrote: Compared to bdrv_can_snapshot(), this function return whether bs* is ready to read snapshot info from instead of write. If yes, caller can then query snapshot information, but taking snapshot is not always possible for that *bs may be read only.

Re: [Qemu-devel] [PATCH] block: Create proper size file for disk mirror

2013-01-25 Thread Eric Blake
On 01/25/2013 11:10 AM, Vishvananda Ishaya wrote: On Jan 25, 2013, at 1:18 AM, Kevin Wolf kw...@redhat.com wrote: Am 24.01.2013 19:00, schrieb Vishvananda Ishaya: The qmp monitor command to mirror a disk was passing -1 for size along with the disk's backing file. This size of the resulting

Re: [Qemu-devel] [PATCH V11 2/4] Create four opts list related functions

2013-01-25 Thread Blue Swirl
On Thu, Jan 24, 2013 at 6:59 PM, Markus Armbruster arm...@redhat.com wrote: Dong Xu Wang wdon...@vnet.linux.ibm.com writes: This patch will create 4 functions, count_opts_list, append_opts_list, free_opts_list and print_opts_list, they will used in following commits. Signed-off-by: Dong Xu

Re: [Qemu-devel] [PATCH 00/57] target-i386 eflags cleanup and bmi/adx extensions

2013-01-25 Thread Eric Blake
On 01/25/2013 11:10 AM, Richard Henderson wrote: Checkpatch doesn't work well with the pattern #ifdef SOMETHING if (foo) { bar(); } else #endif { baz1(); baz2(); } Which is exactly the case for all three errors reported in this series. I

Re: [Qemu-devel] [PATCH for-1.4 qom-cpu 8/9 v6] target-i386: Topology APIC ID utility functions

2013-01-25 Thread Blue Swirl
On Fri, Jan 25, 2013 at 6:01 PM, Eduardo Habkost ehabk...@redhat.com wrote: On Fri, Jan 25, 2013 at 05:47:46PM +, Blue Swirl wrote: On Thu, Jan 24, 2013 at 12:07 PM, Eduardo Habkost ehabk...@redhat.com wrote: On Wed, Jan 23, 2013 at 08:49:58PM +0100, Andreas Färber wrote: Am 23.01.2013

Re: [Qemu-devel] [PATCH] block: Create proper size file for disk mirror

2013-01-25 Thread Kevin Wolf
Am 25.01.2013 19:13, schrieb Eric Blake: On 01/25/2013 11:10 AM, Vishvananda Ishaya wrote: On Jan 25, 2013, at 1:18 AM, Kevin Wolf kw...@redhat.com wrote: Am 24.01.2013 19:00, schrieb Vishvananda Ishaya: The qmp monitor command to mirror a disk was passing -1 for size along with the disk's

Re: [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions

2013-01-25 Thread Andreas Färber
Am 25.01.2013 19:07, schrieb Blue Swirl: On Thu, Jan 24, 2013 at 5:17 PM, Andreas Färber afaer...@suse.de wrote: Am 17.01.2013 21:13, schrieb Blue Swirl: On Mon, Jan 14, 2013 at 9:09 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Tell me what you consider the correct tab width for readers and

Re: [Qemu-devel] [PATCH 00/57] target-i386 eflags cleanup and bmi/adx extensions

2013-01-25 Thread Richard Henderson
On 2013-01-25 10:16, Eric Blake wrote: Which is exactly the case for all three errors reported in this series. I know of no other good way to arrange this pattern. #ifdef SOMETHING # define SOMETHING_WITNESS 1 #else # define SOMETHING_WITNESS 0 #endif if (foo SOMETHING_WITNESS) { bar();

[Qemu-devel] [PATCH 01/24] host-utils: add ffsl

2013-01-25 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com We can provide fast versions based on the other functions defined by host-utils.h. Some care is required on glibc, which provides ffsl already. Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin

[Qemu-devel] [PULL 00/24] Block patches

2013-01-25 Thread Kevin Wolf
The following changes since commit 11c29918be32be5b00f367c7da9724a5cddbbb0f: Merge remote-tracking branch 'bonzini/scsi-next' into staging (2013-01-24 12:56:02 -0600) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Jason Baron (2): ahci: Remove

[Qemu-devel] [PATCH 08/24] mirror: allow customizing the granularity

2013-01-25 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com The desired granularity may be very different depending on the kind of operation (e.g. continuous replication vs. collapse-to-raw) and whether the VM is expected to perform lots of I/O while mirroring is in progress. Allow the user to customize it, while

[Qemu-devel] [PATCH 13/24] block: Add special error code for wrong format

2013-01-25 Thread Kevin Wolf
From: Stefan Weil s...@weilnetz.de The block drivers need a special error code for wrong format. From the available error codes EMEDIUMTYPE fits best. It is not available on all platforms, so a definition in qemu-common.h and a specific error report are needed. Signed-off-by: Stefan Weil

[Qemu-devel] [PATCH 16/24] block/vdi: Improved return values from vdi_open

2013-01-25 Thread Kevin Wolf
From: Stefan Weil s...@weilnetz.de vdi_open returned -1 in case of any error, but it should return an error code (negative value of errno or -EMEDIUMTYPE). Signed-off-by: Stefan Weil s...@weilnetz.de Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com ---

Re: [Qemu-devel] [PATCH 00/57] target-i386 eflags cleanup and bmi/adx extensions

2013-01-25 Thread Eric Blake
On 01/25/2013 11:40 AM, Richard Henderson wrote: On 2013-01-25 10:16, Eric Blake wrote: Which is exactly the case for all three errors reported in this series. I know of no other good way to arrange this pattern. #ifdef SOMETHING # define SOMETHING_WITNESS 1 #else # define SOMETHING_WITNESS

[Qemu-devel] [PATCH 24/24] ide: Add fall through annotations

2013-01-25 Thread Kevin Wolf
Add comments to help static analysers detect that these cases are intentional, and clean up some whitespace in the environment of these comments. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Markus Armbruster arm...@redhat.com --- hw/ide/core.c | 33 +

Re: [Qemu-devel] [PATCH for-1.4 qom-cpu 8/9 v6] target-i386: Topology APIC ID utility functions

2013-01-25 Thread Andreas Färber
Am 23.01.2013 18:58, schrieb Eduardo Habkost: diff --git a/tests/Makefile b/tests/Makefile index d86e95a..4b98d4f 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -45,6 +45,10 @@ gcov-files-test-aio-$(CONFIG_WIN32) = aio-win32.c gcov-files-test-aio-$(CONFIG_POSIX) = aio-posix.c

Re: [Qemu-devel] [PATCH V2 6/6] hw/mdio: Use bitbang core for smc91c111 network device

2013-01-25 Thread Paul Brook
@@ -44,6 +45,10 @@ typedef struct { uint8_t int_level; uint8_t int_mask; MemoryRegion mmio; + +/* MDIO bus and the attached phy */ +struct qemu_mdio mdio_bus; +struct qemu_phy phy; } smc91c111_state; static const VMStateDescription vmstate_smc91c111 = { @@

[Qemu-devel] [PATCH] block: Adds mirroring tests for resized images

2013-01-25 Thread Vishvananda Ishaya
This test verifies two mirroring issues are fixed with resized images: * sync='top' creates an image that is the proper size * sync='full' doesn't cause an assertion failure and crash qemu --- These are tests for my patches for the following bugs: https://bugs.launchpad.net/qemu/+bug/1103868

Re: [Qemu-devel] [RFC] Virtio-desktop: Virtio-based virtual desktop

2013-01-25 Thread Blue Swirl
On Thu, Jan 24, 2013 at 6:10 AM, Anup Patel anup.pa...@linaro.org wrote: Hi All, How about having a generic Virtio-based machine for emulating a virtual desktop ? I have also thought about this, current virtio design is not very clean. On the downside, pure no-legacy approach might not work

Re: [Qemu-devel] [PATCH] PPC: Move ppc specific hw emulation to hw/ppc

2013-01-25 Thread Blue Swirl
On Fri, Jan 25, 2013 at 1:12 AM, Alexander Graf ag...@suse.de wrote: This patch moves all PowerPC specific hardware emulation except for PREP to hw/ppc. Signed-off-by: Alexander Graf ag...@suse.de --- MAINTAINERS | 20 ++-- hw/Makefile.objs |

Re: [Qemu-devel] (change __FUNCTION__ to __func__ according to qemu coding style)

2013-01-25 Thread Luigi Rizzo
On Fri, Jan 25, 2013 at 9:23 AM, Michael Tokarev m...@tls.msk.ru wrote: --- v2: change __FUNCTION__ to __func__ according to qemu coding style will do. However it does not seem a highly followed standard :) lrizzo@netmap:~/work-qemu/qemu-git-head-20130121$ grep -r __FUNCTION__ . | wc

[Qemu-devel] [PATCH 23/24] block: Create proper size file for disk mirror

2013-01-25 Thread Kevin Wolf
From: Vishvananda Ishaya vishvana...@gmail.com The qmp monitor command to mirror a disk was passing -1 for size along with the disk's backing file. This size of the resulting disk is the size of the backing file, which is incorrect if the disk has been resized. Therefore we should always pass in

Re: [Qemu-devel] [PATCH V2 11/20] tap: support enabling or disabling a queue

2013-01-25 Thread Blue Swirl
On Fri, Jan 25, 2013 at 10:35 AM, Jason Wang jasow...@redhat.com wrote: This patch introduce a new bit - enabled in TAPState which tracks whether a specific queue/fd is enabled. The tap/fd is enabled during initialization and could be enabled/disabled by tap_enalbe() and tap_disable() which

[Qemu-devel] [PATCH 10/24] mirror: add buf-size argument to drive-mirror

2013-01-25 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com This makes sense when the next commit starts using the extra buffer space to perform many I/O operations asynchronously. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/mirror.c |8

[Qemu-devel] [PATCH 11/24] mirror: support more than one in-flight AIO operation

2013-01-25 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com With AIO support in place, we can start copying more than one chunk in parallel. This patch introduces the required infrastructure for this: the buffer is split into multiple granularity-sized chunks, and there is a free list to access them. Because of

<    1   2   3   4   >