Re: [Qemu-devel] [Qemu-ppc] real cdrom access failure

2013-06-10 Thread Kevin Wolf
Am 10.06.2013 um 16:45 hat Andreas Färber geschrieben: Am 10.06.2013 16:33, schrieb Kevin Wolf: Am 10.06.2013 um 16:22 hat Andreas Färber geschrieben: Am 10.06.2013 15:41, schrieb Alexander Graf: On 06/10/2013 03:39 PM, Programmingkid wrote: On Jun 9, 2013, at 12:34 PM, Alexander Graf

Re: [Qemu-devel] latest qemu with gdb remote not working

2013-06-10 Thread Peter Cheung
Hi Peter I just git pull the latest code, the gdb still fail to run after sending a c command. Thanksfrom Peter Date: Mon, 3 Jun 2013 09:47:41 +0200 From: pbonz...@redhat.com To: peter.crosthwa...@xilinx.com CC: peter.mayd...@linaro.org; qemu-devel@nongnu.org; mcheun...@hotmail.com

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 1/3] char/serial: cosmetic fixes.

2013-06-10 Thread Michael Tokarev
03.06.2013 09:12, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Some cosmetic fixes to char/serial fixing some checkpatch errors. These are all cosmetic fixes indeed. I weren't sure we're applying stylistic changes by its own. But apparently people

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 1/3] char/serial: cosmetic fixes.

2013-06-10 Thread Michael Tokarev
10.06.2013 19:17, Michael Tokarev пишет: 03.06.2013 09:12, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Some cosmetic fixes to char/serial fixing some checkpatch errors. These are all cosmetic fixes indeed. I weren't sure we're applying

Re: [Qemu-devel] [PATCH 5/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Introduce post-cpu-init function

2013-06-10 Thread Jason J. Herne
On 06/08/2013 06:10 PM, Andreas Färber wrote: Am 07.06.2013 19:28, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com In preparation for treating cpus as devices CPUs *are* devices since multiple releases now, so this is badly put. we need to separate machine initialization

Re: [Qemu-devel] [Qemu-trivial] [PATCH] curl: Don't set curl options on the handle just before it's going to be deleted.

2013-06-10 Thread Michael Tokarev
10.06.2013 17:19, Richard W.M. Jones wrote: From: Richard W.M. Jones rjo...@redhat.com (Found by Kamil Dudka) Signed-off-by: Richard W.M. Jones rjo...@redhat.com --- block/curl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/curl.c b/block/curl.c index b634ccf..bf31efe

Re: [Qemu-devel] [PATCH qom-cpu 00/59] QOM CPUState, part 10: CPU loops

2013-06-10 Thread Stefano Stabellini
On Mon, 10 Jun 2013, Andreas Färber wrote: Am 10.06.2013 16:17, schrieb Stefano Stabellini: On Sun, 9 Jun 2013, Andreas Färber wrote: Hello, Based on my guest-memory-dump cleanup patches, this large series changes cpu_single_env, first_cpu, next_cpu and thread_env to CPUState. As a

Re: [Qemu-devel] [Qemu-trivial] [PATCH] audio: Replace macro GCC_ATTR by GCC_FMT_ATTR and use inline functions

2013-06-10 Thread Michael Tokarev
09.06.2013 16:22, Stefan Weil wrote: GCC_ATTR was only used in audio_int.h, so it is now unused and the definition can be removed from compiler.h. Thanks, applied to the trivial patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] gtk: implement -full-screen and -no-frame

2013-06-10 Thread Michael Tokarev
09.06.2013 14:30, Peter Wu wrote: Aiming for GTK as replacement for SDL, features like -full-screen and -no-frame should also be implemented. I'm not sure both options really should be implemented. I think -no-frame makes little sense actually. But -full-screen is very useful, and hiding

Re: [Qemu-devel] [Qemu-trivial] [PATCH] block/m25p80: Update Micron entries

2013-06-10 Thread Michael Tokarev
07.06.2013 07:51, Peter Crosthwaite wrote: [] Id like to give it a few days to see what they say before we merge this. Ideally we have agreement between the two source trees, so we can continue the copy-paste based update strategy. Do we have any agreement yet? :) Thanks, /mjt

Re: [Qemu-devel] [PATCHv2 1/2] Revert migration: do not sent zero pages in bulk stage

2013-06-10 Thread mdroth
On Mon, Jun 10, 2013 at 12:14:19PM +0200, Peter Lieven wrote: Not sending zero pages breaks migration if a page is zero at the source but not at the destination. This can e.g. happen if different BIOS versions are used at source and destination. It has also been reported that migration on

[Qemu-devel] [PATCH v7 10/12] rdma: introduce capability x-rdma-pin-all

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com This capability allows you to disable dynamic chunk registration for better throughput on high-performance links. For example, using an 8GB RAM virtual machine with all 8GB of memory in active use and the VM itself is completely idle using a 40 gbps

[Qemu-devel] [PATCH v7 07/12] rdma: introduce ram_handle_compressed()

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com This gives RDMA shared access to madvise() on the destination side when an entire chunk is found to be zero. Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- arch_init.c | 24

[Qemu-devel] [PATCH v7 04/12] rdma: export throughput w/ MigrationStats QMP

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com This exposes throughput (in megabits/sec) through QMP. Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- hmp.c |2 ++ include/migration/migration.h |1 + migration.c |6 ++ qapi-schema.json

[Qemu-devel] [PATCH v7 01/12] rdma: add documentation

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com docs/rdma.txt contains full documentation, wiki links, github url and contact information. Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- docs/rdma.txt | 404 + 1 file changed, 404

[Qemu-devel] [PATCH v7 05/12] rdma: introduce qemu_file_mode_is_not_valid()

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com QEMUFileRDMA also has read and write modes. This function is now shared to reduce code duplication. Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- include/migration/qemu-file.h |1 + savevm.c | 20 +---

[Qemu-devel] [PATCH v7 09/12] rdma: new QEMUFileOps hooks

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com These are the prototypes and implementation of new hooks that RDMA takes advantage of to perform dynamic page registration. An optional hook is also introduced for a custom function to be able to override the default save_page function. Also included

[Qemu-devel] [PATCH v7 12/12] rdma: send pc.ram

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com This takes advantages of the previous patches: 1. use the new QEMUFileOps hook 'save_page' 2. call out to the right accessor methods to invoke the iteration hooks defined in QEMUFileOps Signed-off-by: Michael R. Hines mrhi...@us.ibm.com ---

[Qemu-devel] [PATCH v7 00/12] rdma: migration support

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com Please pull. Changes since v6: - added signed-off bys - *Major* bug testing: - In-depth regression testing, several bug fixes. - Over 1000+ back-to-back migrations performed without error. - rdma: introduce qemu_update_position(), since RDMA writes

[Qemu-devel] [PATCH v7 08/12] rdma: introduce qemu_ram_foreach_block()

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com This is used during RDMA initialization in order to transmit a description of all the RAM blocks to the peer for later dynamic chunk registration purposes. Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- exec.c|9 +

Re: [Qemu-devel] [PATCHv2 2/2] migration: do not overwrite zero pages

2013-06-10 Thread mdroth
On Mon, Jun 10, 2013 at 12:14:20PM +0200, Peter Lieven wrote: on incoming migration do not memset pages to zero if they already read as zero. this will allocate a new zero page and consume memory unnecessarily. even if we madvise a MADV_DONTNEED later this will only deallocate the memory

Re: [Qemu-devel] [PATCH 7/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Infrastructure for Cpu Devices

2013-06-10 Thread Jason J. Herne
On 06/08/2013 06:50 PM, Andreas Färber wrote: Hi, Am 07.06.2013 19:28, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Add infrastructure for treating cpus as devices. This patch allows cpus to be specified using a combination of '-smp' and '-device cpu'. This approach forces

[Qemu-devel] [PATCH v7 03/12] rdma: export yield_until_fd_readable()

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com The RDMA event channel can be made non-blocking just like a TCP socket. Exporting this function allows us to yield so that the QEMU monitor remains available. Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- include/block/coroutine.h |6 ++

Re: [Qemu-devel] [PATCHv2 2/2] migration: do not overwrite zero pages

2013-06-10 Thread mdroth
On Mon, Jun 10, 2013 at 11:10:29AM -0500, mdroth wrote: On Mon, Jun 10, 2013 at 12:14:20PM +0200, Peter Lieven wrote: on incoming migration do not memset pages to zero if they already read as zero. this will allocate a new zero page and consume memory unnecessarily. even if we madvise a

[Qemu-devel] [PATCH v7 06/12] rdma: export qemu_fflush()

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com RDMA uses this to flush the control channel before sending its own message to handle page registrations. Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- include/migration/qemu-file.h |1 + savevm.c |2 +- 2 files

[Qemu-devel] [PATCH v7 02/12] rdma: introduce qemu_update_position()

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com RDMA writes happen asynchronously, and thus the performance accounting also needs to be able to occur asynchronously. This allows anybody to call into savevm.c to update both f-pos as well as into arch_init.c to update the acct_info structure with

[Qemu-devel] [PATCH RFC] pci: add pci_for_each_bus

2013-06-10 Thread Michael S. Tsirkin
This will be useful for bridge ACPI hotplug. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/pci/pci.c | 17 + include/hw/pci/pci.h | 4 2 files changed, 21 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index d5257ed..130b5ad 100644 ---

Re: [Qemu-devel] [Qemu-trivial] [PATCH] curl: Don't set curl options on the handle just before it's going to be deleted.

2013-06-10 Thread Richard W.M. Jones
On Mon, Jun 10, 2013 at 07:34:52PM +0400, Michael Tokarev wrote: 10.06.2013 17:19, Richard W.M. Jones wrote: From: Richard W.M. Jones rjo...@redhat.com (Found by Kamil Dudka) Signed-off-by: Richard W.M. Jones rjo...@redhat.com --- block/curl.c | 1 - 1 file changed, 1

[Qemu-devel] [PATCH v2] curl: Don't set curl options on the handle just before it's going to be deleted.

2013-06-10 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com (Found by Kamil Dudka) Signed-off-by: Richard W.M. Jones rjo...@redhat.com Cc: Michael Tokarev m...@tls.msk.ru --- block/curl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/block/curl.c b/block/curl.c index b634ccf..8d0d45d 100644 ---

[Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Michael S. Tsirkin
This adds support for device hotplug behind pci bridges. Bridge devices themselves need to be pre-configured on qemu command line. One of the goals of this project was to demonstrate the advantages of generating ACPI tables in QEMU. In my opinion, it does this successfully. * This saves

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-06-10 Thread Jason J. Herne
On 06/08/2013 09:11 PM, Andreas Färber wrote: Am 07.06.2013 19:28, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Modify cpu initialization and QOM routines associated with s390-cpu such that all cpus on S390 are now created via the QOM device creation code path.

Re: [Qemu-devel] KVM call agenda for 2013-06-11

2013-06-10 Thread Michael S. Tsirkin
On Tue, Jun 04, 2013 at 04:24:31PM +0300, Michael S. Tsirkin wrote: Juan is not available now, and Anthony asked for agenda to be sent early. So here comes: Agenda for the meeting Tue, June 11: - Generating acpi tables, redux I've just posted a proof of concept patch on list, as

Re: [Qemu-devel] [PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-10 Thread Michael S. Tsirkin
On Mon, Jun 10, 2013 at 11:53:04AM +0200, fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com This fix a bug with scsi hotplug on virtio-scsi-pci: As virtio-scsi-pci doesn't have any scsi bus, we need to forward scsi-hot-add to the virtio-scsi-device plugged on

[Qemu-devel] [PATCH 2/9] rng-random: use error_setg_file_open()

2013-06-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- backends/rng-random.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/backends/rng-random.c b/backends/rng-random.c index 830360c..68dfc8a 100644 --- a/backends/rng-random.c +++ b/backends/rng-random.c @@ -78,9 +78,8

[Qemu-devel] [PATCH 7/9] savevm: qmp_xen_save_devices_state(): use error_setg_file_open()

2013-06-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/savevm.c b/savevm.c index 2ce439f..ff5ece6 100644 --- a/savevm.c +++ b/savevm.c @@ -2410,7 +2410,7 @@ void qmp_xen_save_devices_state(const char *filename, Error

[Qemu-devel] [PATCH 9/9] qerror: drop QERR_OPEN_FILE_FAILED macro

2013-06-10 Thread Luiz Capitulino
Not used since the last commit. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- include/qapi/qmp/qerror.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h index 6c0a18d..c30c2f6 100644 --- a/include/qapi/qmp/qerror.h +++

[Qemu-devel] [PATCH 8/9] block: bdrv_reopen_prepare(): don't use QERR_OPEN_FILE_FAILED

2013-06-10 Thread Luiz Capitulino
The call to drv-bdrv_reopen_prepare() can fail due to reasons other than an open failure. Unfortunately, we can't use errno nor -ret, cause they are not always set. Stick to a generic error message then. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- block.c | 4 ++-- 1 file changed,

[Qemu-devel] [PATCH 3/9] block: mirror_complete(): use error_setg_file_open()

2013-06-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 8b07dec..1ae724f 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -512,7 +512,7 @@ static void

Re: [Qemu-devel] [Qemu-trivial] [PATCH] ioport/memory: check that both .read and .write callbacks are defined

2013-06-10 Thread Michael S. Tsirkin
On Mon, Jun 10, 2013 at 07:14:45PM +1000, Peter Crosthwaite wrote: Hi, On Mon, Jun 10, 2013 at 3:27 PM, Gerd Hoffmann kra...@redhat.com wrote: Hi, Maybe instead (or in addition to), we should provide a dummy read or write functions -- instead of fixing each such occurence to use

[Qemu-devel] [PATCH 6/9] dump: qmp_dump_guest_memory(): use error_setg_file_open()

2013-06-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dump.c b/dump.c index c0d3da5..28fd296 100644 --- a/dump.c +++ b/dump.c @@ -847,7 +847,7 @@ void qmp_dump_guest_memory(bool paging, const char *file, bool

Re: [Qemu-devel] [PATCHv2 1/2] Revert migration: do not sent zero pages in bulk stage

2013-06-10 Thread Orit Wasserman
On 06/10/2013 01:14 PM, Peter Lieven wrote: Not sending zero pages breaks migration if a page is zero at the source but not at the destination. This can e.g. happen if different BIOS versions are used at source and destination. It has also been reported that migration on pseries is completely

Re: [Qemu-devel] [PATCHv2 2/2] migration: do not overwrite zero pages

2013-06-10 Thread Orit Wasserman
On 06/10/2013 01:14 PM, Peter Lieven wrote: on incoming migration do not memset pages to zero if they already read as zero. this will allocate a new zero page and consume memory unnecessarily. even if we madvise a MADV_DONTNEED later this will only deallocate the memory asynchronously.

Re: [Qemu-devel] [PATCH qom-cpu 11/59] monitor: Simplify do_inject_mce()

2013-06-10 Thread Luiz Capitulino
On Sun, 9 Jun 2013 21:12:38 +0200 Andreas Färber afaer...@suse.de wrote: Use qemu_get_cpu() to avoid open-coded CPU loop. Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 14 +- 1 file changed, 5

[Qemu-devel] [PATCH RESEND v7 06/12] rdma: export qemu_fflush()

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com RDMA uses this to flush the control channel before sending its own message to handle page registrations. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- include/migration/qemu-file.h |1 +

[Qemu-devel] [PATCH RESEND v7 02/12] rdma: introduce qemu_update_position()

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com RDMA writes happen asynchronously, and thus the performance accounting also needs to be able to occur asynchronously. This allows anybody to call into savevm.c to update both f-pos as well as into arch_init.c to update the acct_info structure with

[Qemu-devel] [PATCH RESEND v7 05/12] rdma: introduce qemu_file_mode_is_not_valid()

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com QEMUFileRDMA also has read and write modes. This function is now shared to reduce code duplication. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- include/migration/qemu-file.h |1 + savevm.c

[Qemu-devel] [PATCH RESEND v7 00/12] rdma: migration support

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com Ooops. Forgot the signed-off bys, resending. =) Changes since v6: - added signed-off bys - *Major* bug testing: - In-depth regression testing, several bug fixes. - Over 1000+ back-to-back migrations performed without error. - rdma: introduce

[Qemu-devel] [PATCH RESEND v7 10/12] rdma: introduce capability x-rdma-pin-all

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com This capability allows you to disable dynamic chunk registration for better throughput on high-performance links. For example, using an 8GB RAM virtual machine with all 8GB of memory in active use and the VM itself is completely idle using a 40 gbps

[Qemu-devel] [PATCH RESEND v7 07/12] rdma: introduce ram_handle_compressed()

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com This gives RDMA shared access to madvise() on the destination side when an entire chunk is found to be zero. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- arch_init.c | 24

[Qemu-devel] [PATCH RESEND v7 04/12] rdma: export throughput w/ MigrationStats QMP

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com This exposes throughput (in megabits/sec) through QMP. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- hmp.c |2 ++ include/migration/migration.h |1 + migration.c

[Qemu-devel] [PATCH RESEND v7 08/12] rdma: introduce qemu_ram_foreach_block()

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com This is used during RDMA initialization in order to transmit a description of all the RAM blocks to the peer for later dynamic chunk registration purposes. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael R. Hines mrhi...@us.ibm.com

[Qemu-devel] [PATCH RESEND v7 03/12] rdma: export yield_until_fd_readable()

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com The RDMA event channel can be made non-blocking just like a TCP socket. Exporting this function allows us to yield so that the QEMU monitor remains available. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael R. Hines

[Qemu-devel] [PATCH RESEND v7 12/12] rdma: send pc.ram

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com This takes advantages of the previous patches: 1. use the new QEMUFileOps hook 'save_page' 2. call out to the right accessor methods to invoke the iteration hooks defined in QEMUFileOps Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by:

[Qemu-devel] [PATCH RESEND v7 01/12] rdma: add documentation

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com docs/rdma.txt contains full documentation, wiki links, github url and contact information. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- docs/rdma.txt | 404

[Qemu-devel] [PATCH RESEND v7 09/12] rdma: new QEMUFileOps hooks

2013-06-10 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com These are the prototypes and implementation of new hooks that RDMA takes advantage of to perform dynamic page registration. An optional hook is also introduced for a custom function to be able to override the default save_page function. Also included

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Scott Wood
On 06/10/2013 09:26:18 AM, Alexander Graf wrote: On 06/10/2013 02:47 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: Andreas Färber [mailto:afaer...@suse.de] Sent: Monday, June 10, 2013 5:43 PM To: Bhushan Bharat-R65777 Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org;

[Qemu-devel] [PATCH 4/9] blockdev: use error_setg_file_open()

2013-06-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- blockdev.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/blockdev.c b/blockdev.c index 9937311..5975dde 100644 --- a/blockdev.c +++ b/blockdev.c @@ -899,7 +899,7 @@ static void

[Qemu-devel] [PATCH v2 0/9] QMP/HMP: add error reason to open failures

2013-06-10 Thread Luiz Capitulino
I was surprised to find out that we still have old users of QERR_OPEN_FILE_FAILED that print errors like: (qemu) dump-guest-memory -p /lkmads/foo Could not open '/lkmads/foo' (qemu) This series converts all those users to a new helper called error_setg_file_open(), which adds error reason to

[Qemu-devel] [PATCH 5/9] cpus: use error_setg_file_open()

2013-06-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- cpus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index c232265..c8bc8ad 100644 --- a/cpus.c +++ b/cpus.c @@ -1278,7 +1278,7 @@ void qmp_memsave(int64_t addr, int64_t size, const char

[Qemu-devel] [PATCH 1/9] error: add error_setg_file_open() helper

2013-06-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- include/qapi/error.h | 5 + util/error.c | 5 + 2 files changed, 10 insertions(+) diff --git a/include/qapi/error.h b/include/qapi/error.h index 5cd2f0c..ffd1cea 100644 --- a/include/qapi/error.h +++ b/include/qapi/error.h

[Qemu-devel] [PATCH v2] gtk: implement -full-screen

2013-06-10 Thread Peter Wu
Aiming for GTK as replacement for SDL, a feature like -full-screen should also be implemented. Bringing the window into full-screen mode is done by activating the Fullscreen menu item. This is done after showing the windows to make the cursor and menu hidden. v2: drop -no-frame implementation,

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Alexander Graf
On 10.06.2013, at 19:20, Scott Wood wrote: On 06/10/2013 09:26:18 AM, Alexander Graf wrote: On 06/10/2013 02:47 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: Andreas Färber [mailto:afaer...@suse.de] Sent: Monday, June 10, 2013 5:43 PM To: Bhushan Bharat-R65777 Cc:

[Qemu-devel] [PATCH] ide-test: fix failure for test_flush

2013-06-10 Thread Michael Roth
bd07684aacfb61668ae2c25b7dd00b64f3d7c7f3 added a test to ensure BSY flag is set when a flush request is in flight. It does this by setting a blkdebug breakpoint on flush_to_os before issuing a CMD_FLUSH_CACHE. It then resumes CMD_FLUSH_CACHE operation and checks that BSY is unset. The actual

Re: [Qemu-devel] [PATCH 1/4] tcg: Split rem requirement from div requirement

2013-06-10 Thread Richard Henderson
Ping. On 05/30/2013 10:53 AM, Richard Henderson wrote: There are several hosts with only a div insn. Remainder is computed manually from the quotient and inputs. We can do this generically. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.h | 2 ++

Re: [Qemu-devel] [PULL 0/2] tcg: Remove redundant tcg_target_init checks

2013-06-10 Thread Richard Henderson
Ping. On 06/05/2013 05:59 AM, Richard Henderson wrote: Reviewing the tcg/aarch64 patch set, and comparing that to existing hosts made me remember that I've wanted to do this for quite some time. Now with two reviews, please pull. r~ The following changes since commit

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] KVM: PPC: Add dummy kvm_arch_init_irq_routing()

2013-06-10 Thread Scott Wood
On 06/08/2013 02:24:21 AM, Michael Tokarev wrote: 06.06.2013 07:59, Alexey Kardashevskiy wrote: From: Scott Wood scottw...@freescale.com The common KVM code insists on calling kvm_arch_init_irq_routing() as soon as it sees kernel header support for it (regardless of whether QEMU supports

Re: [Qemu-devel] [PATCH 0/5] tcg-arm: Runtime detection of architecture

2013-06-10 Thread Richard Henderson
Ping. On 06/06/2013 11:05 AM, Richard Henderson wrote: Two prepatory generic tcg patches, to allow non-constant values for the various TCG_TARGET_HAS_foo macros. When in patch 3 this gets used, the code inlined in the translators will be able to check the relevant variable and emit either

Re: [Qemu-devel] [PATCH v2 0/4] tcg-arm: Implement tcg_register_jit

2013-06-10 Thread Richard Henderson
Ping. On 06/05/2013 10:29 AM, Richard Henderson wrote: Changes v1-v2: The suggestions for improvement I got from round 1 apply to all of the hosts, not just arm. r~ Richard Henderson (4): tcg: Fix high_pc fields in .debug_info tcg: Move the CIE and FDE header definitions to

Re: [Qemu-devel] [PATCHv2 2/2] migration: do not overwrite zero pages

2013-06-10 Thread Peter Lieven
Am 10.06.2013 um 18:10 schrieb mdroth mdr...@linux.vnet.ibm.com: On Mon, Jun 10, 2013 at 12:14:20PM +0200, Peter Lieven wrote: on incoming migration do not memset pages to zero if they already read as zero. this will allocate a new zero page and consume memory unnecessarily. even if we

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Anthony Liguori
Michael S. Tsirkin m...@redhat.com writes: This adds support for device hotplug behind pci bridges. Bridge devices themselves need to be pre-configured on qemu command line. One of the goals of this project was to demonstrate the advantages of generating ACPI tables in QEMU. In my

Re: [Qemu-devel] [PATCH v2] gtk: implement -full-screen

2013-06-10 Thread Anthony Liguori
Peter Wu lekenst...@gmail.com writes: Aiming for GTK as replacement for SDL, a feature like -full-screen should also be implemented. Bringing the window into full-screen mode is done by activating the Fullscreen menu item. This is done after showing the windows to make the cursor and menu

Re: [Qemu-devel] [PULL 0/2] tcg: Remove redundant tcg_target_init checks

2013-06-10 Thread Anthony Liguori
Richard Henderson r...@twiddle.net writes: Ping. Aurelien/Blue, can you pull this? Regards, Anthony Liguori On 06/05/2013 05:59 AM, Richard Henderson wrote: Reviewing the tcg/aarch64 patch set, and comparing that to existing hosts made me remember that I've wanted to do this for quite

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Peter Maydell
On 10 June 2013 19:58, Anthony Liguori anth...@codemonkey.ws wrote: We only care about supporting one version of SeaBIOS. SeaBIOS should only care about supporting one version of QEMU. We're not asking it to support multiple versions. I'm confused, how does this work in cross-version

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Laszlo Ersek
On 06/10/13 20:58, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: This adds support for device hotplug behind pci bridges. Bridge devices themselves need to be pre-configured on qemu command line. One of the goals of this project was to demonstrate the advantages of

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes: On 10 June 2013 19:58, Anthony Liguori anth...@codemonkey.ws wrote: We only care about supporting one version of SeaBIOS. SeaBIOS should only care about supporting one version of QEMU. We're not asking it to support multiple versions. I'm

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Anthony Liguori
Laszlo Ersek ler...@redhat.com writes: On 06/10/13 20:58, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: This adds support for device hotplug behind pci bridges. Bridge devices themselves need to be pre-configured on qemu command line. One of the goals of this project

[Qemu-devel] [PATCH] device tree: Fix cppcheck warning

2013-06-10 Thread Stefan Weil
Fix this cppcheck warning: Checking device_tree.c... device_tree.c:216: style: Checking if unsigned variable 'r' is less than zero. Signed-off-by: Stefan Weil s...@weilnetz.de --- device_tree.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/device_tree.c b/device_tree.c

[Qemu-devel] [PATCH] hw/scsi: Don't increment a boolean value

2013-06-10 Thread Stefan Weil
This fixes a warning from cppcheck. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/scsi/vmw_pvscsi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index 48d12f4..446f723 100644 --- a/hw/scsi/vmw_pvscsi.c +++

[Qemu-devel] [PATCH] hw/xen: Use g_free instead of free and fix potential memory leaks

2013-06-10 Thread Stefan Weil
The wrong functions and the missing calls of g_free were reported by cppcheck. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/xen/xen_pt_config_init.c |4 ++-- xen-all.c |8 +--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH] target-sparc: Replace free by g_free

2013-06-10 Thread Stefan Weil
The wrong function was reported by cppcheck. Signed-off-by: Stefan Weil s...@weilnetz.de --- target-sparc/cpu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c index 290b580..13bb7bb 100644 --- a/target-sparc/cpu.c +++

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Laszlo Ersek
On 06/10/13 21:57, Anthony Liguori wrote: Laszlo Ersek ler...@redhat.com writes: Please take a look at my series for OVMF that adds basic support for SMBIOS tables. It took me three days of basically uninterrupted coding and two approaches to throw away until I got something submittable (with

[Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-10 Thread Michael Tokarev
Or else ./configure --disable-system --enable-virtfs (which makes no sense by its own but does not error out) will fail to build, because it will define CONFIG_VIRTFS, and the makefile will try to build virtfs-proxy-helper manpage (but not the executable). Cc: qemu-triv...@nongnu.org Cc: M.

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-10 Thread Michael Tokarev
11.06.2013 00:47, Michael Tokarev wrote: Or else ./configure --disable-system --enable-virtfs (which makes no sense by its own but does not error out) will fail to build, because it will define CONFIG_VIRTFS, and the makefile will try to build virtfs-proxy-helper manpage (but not the

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Laszlo Ersek
Sorry about replying to myself... On 06/10/13 22:43, Laszlo Ersek wrote: It's not a design purity argument, just what's cheaper. You probably consider SMBIOS/ACPI table generation guest code that has no place in the machine emulator. You're likely willing to expose the needed bits on a

Re: [Qemu-devel] [PATCH qom-cpu 31/59] monitor: Simplify do_info_numa()

2013-06-10 Thread Andreas Färber
Am 10.06.2013 09:20, schrieb Markus Armbruster: Andreas Färber afaer...@suse.de writes: Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber afaer...@suse.de --- monitor.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/monitor.c

[Qemu-devel] [PATCH] Unbreak -no-quit for GTK when SDL is disabled

2013-06-10 Thread Peter Wu
When QEMU is built without SDL support, -no-quit would print an error message that SDL is disabled. Since GTK also supports -no-quit, enable the option when GTK or SDL is enabled at compile time. While at it, do not create the no_quit variable when it is not used. Signed-off-by: Peter Wu

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-10 Thread Peter Maydell
On 10 June 2013 21:47, Michael Tokarev m...@tls.msk.ru wrote: Or else ./configure --disable-system --enable-virtfs (which makes no sense by its own but does not error out) will fail to build, because it will define CONFIG_VIRTFS, and the makefile will try to build virtfs-proxy-helper

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Anthony Liguori
Laszlo Ersek ler...@redhat.com writes: On 06/10/13 21:57, Anthony Liguori wrote: Laszlo Ersek ler...@redhat.com writes: I don't understand this piece. Other than TianoCore being a weird environment, what made this more difficult than it is to generate the tables in QEMU? QEMU can pass

Re: [Qemu-devel] [PATCH] gtk: use better icon

2013-06-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] gtk: don't resize window when enabling scaling

2013-06-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v5] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 0/2] configure: improve handling of target lists

2013-06-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 0/2] gdbstub runstate check follow-ups

2013-06-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor

2013-06-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] softfloat: Fix shift128Right for shift counts 64..127

2013-06-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH qom-cpu 09/59] cpus: Simplify hw_error()

2013-06-10 Thread Andreas Färber
Am 09.06.2013 21:12, schrieb Andreas Färber: Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/cpus.c b/cpus.c index 1975c5c..9195bc3 100644 --- a/cpus.c +++

Re: [Qemu-devel] [PATCH] Unbreak -no-quit for GTK when SDL is disabled

2013-06-10 Thread Anthony Liguori
Peter Wu lekenst...@gmail.com writes: When QEMU is built without SDL support, -no-quit would print an error message that SDL is disabled. Since GTK also supports -no-quit, enable the option when GTK or SDL is enabled at compile time. While at it, do not create the no_quit variable when it is

Re: [Qemu-devel] [PATCH qom-cpu 27/59] cpu: Turn cpu_unassigned_access() into a CPUState hook

2013-06-10 Thread Andreas Färber
Am 09.06.2013 21:12, schrieb Andreas Färber: diff --git a/include/qom/cpu.h b/include/qom/cpu.h index a69c09c..814d067 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h [...] @@ -383,6 +401,21 @@ void cpu_interrupt(CPUState *cpu, int mask); #endif /* USER_ONLY */ +#ifndef

Re: [Qemu-devel] [PATCH qom-cpu 11/59] monitor: Simplify do_inject_mce()

2013-06-10 Thread Andreas Färber
Am 10.06.2013 19:14, schrieb Luiz Capitulino: On Sun, 9 Jun 2013 21:12:38 +0200 Andreas Färber afaer...@suse.de wrote: Use qemu_get_cpu() to avoid open-coded CPU loop. Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Luiz Capitulino lcapitul...@redhat.com Thanks, applied to

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 1/3] char/serial: cosmetic fixes.

2013-06-10 Thread Peter Crosthwaite
Hi Michael, On Tue, Jun 11, 2013 at 1:29 AM, Michael Tokarev m...@tls.msk.ru wrote: 10.06.2013 19:17, Michael Tokarev пишет: 03.06.2013 09:12, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Some cosmetic fixes to char/serial fixing some checkpatch

<    1   2   3   >