[Qemu-devel] [PATCH 1/7] block: Convert BlockDriverState.in_use to refcount

2013-07-02 Thread Fam Zheng
Use numeric value to replace in_use flag in BDS, this will make lifecycle management with ref count possible. This patch only replaces existing uses of bdrv_set_in_use, so no logic change here. Signed-off-by: Fam Zheng f...@redhat.com --- block-migration.c | 4 ++-- block.c

[Qemu-devel] [PATCH 0/7] Point-in-time snapshot exporting over NBD

2013-07-02 Thread Fam Zheng
This series adds for point-in-time snapshot NBD exporting based on drive-backup. The ideas is described below and patches followed (the missing part is item 3, which work is in progress by Ian Main who will have another patch on it). As the work does not overlap, these series should be quite

[Qemu-devel] [PATCH 2/7] block: use refcount to manage BlockDriverState lifecycle

2013-07-02 Thread Fam Zheng
Device attach, NBD server and block job can share a BlockDriverState, this patch makes them to use refcount to grab/release a bs so they don't interfere each other with BDS lifecycle. Local BDS allocation/releasing don't need to use refcount to manage it, just use bdrv_new() and bdrv_delete().

[Qemu-devel] [PATCH 3/7] nbd: use BDS refcount

2013-07-02 Thread Fam Zheng
Previously, nbd call drive_get_ref on the drive of bs. A BDS doesn't always have associated dinfo, it's more proper to use bdrv_get_ref(). Signed-off-by: Fam Zheng f...@redhat.com --- blockdev-nbd.c | 9 + nbd.c | 5 + 2 files changed, 6 insertions(+), 8 deletions(-) diff

[Qemu-devel] [PATCH 5/7] block: rename bdrv_in_use to bdrv_is_shared

2013-07-02 Thread Fam Zheng
The patch only does a rename: bdrv_in_use is obsecure literally (any BDS is certain to be used somewhere). Rename it to bdrv_is_shared since we have reference count now and the user number of the BDS is reflected there. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 16

[Qemu-devel] [PATCH 6/7] block: add target-id option to drive-backup QMP command

2013-07-02 Thread Fam Zheng
Add target-id (optional) to drive-backup command, to make the target bs a named drive so that we can operate on it (e.g. export with NBD). Signed-off-by: Fam Zheng f...@redhat.com --- blockdev.c | 4 +++- qapi-schema.json | 7 +-- qmp-commands.hx | 3 ++- 3 files changed, 10

[Qemu-devel] [PATCH 4/7] block: simplify bdrv_drop_intermediate

2013-07-02 Thread Fam Zheng
Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 71 ++--- 1 file changed, 11 insertions(+), 60 deletions(-) diff --git a/block.c b/block.c index d1ce570..ae5de17 100644 --- a/block.c +++ b/block.c @@ -2015,12 +2015,6 @@

[Qemu-devel] [PATCH 7/7] block: assign backing relationship in drive-backup

2013-07-02 Thread Fam Zheng
Assign source image as the backing hd of target bs, so reading target bs gets the point-in-time copy of data from source image. Signed-off-by: Fam Zheng f...@redhat.com --- block/backup.c | 13 + 1 file changed, 13 insertions(+) diff --git a/block/backup.c b/block/backup.c index

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-07-02 Thread Amos Kong
On Wed, Jun 26, 2013 at 11:54:20AM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: We want to implement mac programming over macvtap through Libvirt, related rx-filter configuration contains main mac, some of rx-mode and mac-table. The previous patch adds QMP event

Re: [Qemu-devel] [PATCH v4 08/10] qemu-ga: call Windows VSS requester in fsfreeze command handler

2013-07-02 Thread Laszlo Ersek
On 07/01/13 19:59, Tomoki Sekiyama wrote: On 7/1/13 9:29 , Laszlo Ersek ler...@redhat.com wrote: +error: +qmp_guest_fsfreeze_thaw(NULL); Passing NULL here as errp concerns me slightly. I've been assuming that errp is never NULL due to the outermost QMP layer always wanting to receive

Re: [Qemu-devel] [PATCH v2 06/11] memory: add ref/unref calls

2013-07-02 Thread Paolo Bonzini
Il 01/07/2013 20:33, Jan Kiszka ha scritto: On 2013-06-28 18:58, Paolo Bonzini wrote: Add ref/unref calls at the following places: - places where memory regions are stashed by a listener and used outside the BQL (including in Xen or KVM). - memory_region_find callsites You missed some

Re: [Qemu-devel] [PATCH 21/24] hw/p*: pass owner to memory_region_init_io

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 01:31, Andreas Färber ha scritto: Signed-off-by: Paolo Bonzini pbonz...@redhat.com Needs an update after ppc-next merge, cf. attached. Thanks! Paolo

Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report()

2013-07-02 Thread Laszlo Ersek
On 07/01/13 20:54, Seiji Aguchi wrote: [Issue] When we offer a customer support service and a problem happens in a customer's system, we try to understand the problem by comparing what the customer reports with message logs of the customer's system. In this case, we often need to know when

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-07-02 Thread Amos Kong
On Wed, Jun 26, 2013 at 01:56:33PM +0200, Markus Armbruster wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 14 Jun 2013 13:46:41 +0800 Amos Kong ak...@redhat.com wrote: On Fri, May 31, 2013 at 08:31:17PM +0800, Amos Kong wrote: On Thu, May 30, 2013 at 11:48:46AM -0500,

[Qemu-devel] [Bug 1196773] [NEW] pci_add auto nic failed on qemu monitor

2013-07-02 Thread xingshui.dong
Public bug reported: hello! execute qemu-system-x86_64 -M pc -m 256 -hda pc/img.qcow2 -nographic -net nic,vlan=0,macaddr=00:e0:fc:00:00:01 -net tap,vlan=0,ifname=tap0,script=no -serial tcp::,server,nowait -boot c and then (qemu) pci_add auto nic vlan=1,macaddr=00:e0:fc:40:20:02 Property

Re: [Qemu-devel] [PATCH v2 07/11] exec: check MRU in qemu_ram_addr_from_host

2013-07-02 Thread Jan Kiszka
On 2013-07-01 22:48, Paolo Bonzini wrote: Il 01/07/2013 20:33, Jan Kiszka ha scritto: This function is not used outside the iothread mutex, so it can use ram_list.mru_block. Add a comment to qemu_ram_addr_from_host to document this requirement? Right now there is hardly any documentation

Re: [Qemu-devel] [PATCH v2 10/11] exec: reorganize address_space_map

2013-07-02 Thread Jan Kiszka
On 2013-07-01 22:44, Paolo Bonzini wrote: Il 01/07/2013 20:34, Jan Kiszka ha scritto: The transformation looks correct, but I'm currently not understanding in which cases we still need the loop. address_space_translate should return as much of the target mr as the region can contiguously

Re: [Qemu-devel] [PATCH v2 06/11] memory: add ref/unref calls

2013-07-02 Thread Jan Kiszka
On 2013-07-02 08:42, Paolo Bonzini wrote: Il 01/07/2013 20:33, Jan Kiszka ha scritto: On 2013-06-28 18:58, Paolo Bonzini wrote: Add ref/unref calls at the following places: - places where memory regions are stashed by a listener and used outside the BQL (including in Xen or KVM). -

[Qemu-devel] [PATCH v3] curl: refuse to open URL from HTTP server without range support

2013-07-02 Thread Fam Zheng
CURL driver requests partial data from server on guest IO req. For HTTP and HTTPS, it uses Range: *** in requests, and this will not work if server not accepting range. This patch does this check when open. * Removed curl_size_cb, which is not used: On one hand it's registered to libcurl as

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-07-02 Thread Stefan Hajnoczi
On Mon, Jul 01, 2013 at 08:10:34AM -0400, Ed Maste wrote: On 1 July 2013 07:47, Stefan Hajnoczi stefa...@gmail.com wrote: Yes, Christian Berendt admins the buildmaster. How much time has passed since you emailed? June 7; perhaps the email was lost. I would like to start with a FreeBSD

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-07-02 Thread Christian Berendt
Hello Stefan. On 07/02/2013 09:31 AM, Stefan Hajnoczi wrote: Okay, I put Christian in the To: field. Let's wait two days for a response. I dropped Andreas a few lines to get further information about the missing packages. I think the solution is to add another buildmaster administrator.

Re: [Qemu-devel] [PATCHv2 08/11] block-migration: efficiently encode zero blocks

2013-07-02 Thread Stefan Hajnoczi
On Mon, Jul 01, 2013 at 06:09:55PM +0200, Peter Lieven wrote: Am 01.07.2013 um 16:13 schrieb Stefan Hajnoczi stefa...@redhat.com: On Thu, Jun 27, 2013 at 03:11:32PM +0200, Peter Lieven wrote: /* device name */ len = strlen(blk-bmds-bs-device_name); qemu_put_byte(f,

Re: [Qemu-devel] [PATCHv2 08/11] block-migration: efficiently encode zero blocks

2013-07-02 Thread Stefan Hajnoczi
On Mon, Jul 01, 2013 at 05:55:15PM +0200, Peter Lieven wrote: Am 01.07.2013 um 16:13 schrieb Stefan Hajnoczi stefa...@redhat.com: On Thu, Jun 27, 2013 at 03:11:32PM +0200, Peter Lieven wrote: This patch breaks cross-version blog migration. We need to control whether or not to use

Re: [Qemu-devel] [PATCHv2 11/11] iscsi: assert that sectors are aligned to LUN blocksize

2013-07-02 Thread Stefan Hajnoczi
On Mon, Jul 01, 2013 at 05:59:02PM +0200, Peter Lieven wrote: Am 01.07.2013 um 16:35 schrieb Stefan Hajnoczi stefa...@redhat.com: On Thu, Jun 27, 2013 at 03:11:35PM +0200, Peter Lieven wrote: if the blocksize of an iSCSI LUN is bigger than the BDRV_SECTOR_SIZE it is possible that

Re: [Qemu-devel] [PATCH 2/2] qemu-thread: add TLS wrappers

2013-07-02 Thread Stefan Hajnoczi
On Mon, Jul 01, 2013 at 02:52:08PM -0400, Ed Maste wrote: On 1 July 2013 05:35, Stefan Hajnoczi stefa...@redhat.com wrote: From: Paolo Bonzini pbonz...@redhat.com Fast TLS is not available on some platforms, but it is always nice to use it. This wrapper implementation falls back to

Re: [Qemu-devel] [PATCH v2 07/11] exec: check MRU in qemu_ram_addr_from_host

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 09:09, Jan Kiszka ha scritto: Right now there is hardly any documentation of what does _not_ require the iothread mutex... basically everything except qemu_safe_ram_ptr and qemu_ram_ptr_length requires it. I don't disagree regarding the current state. But that doesn't

Re: [Qemu-devel] [PATCH 2/2] qemu-thread: add TLS wrappers

2013-07-02 Thread Paolo Bonzini
Il 01/07/2013 22:30, Richard Henderson ha scritto: On 07/01/2013 12:25 PM, Peter Maydell wrote: Does any OS have a __thread which compiles but is broken, or can we just have a configure test for this? That would let MacOSX+clang use __thread. I suspect that this will work. Some targets may

Re: [Qemu-devel] [PATCH v2 06/11] memory: add ref/unref calls

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 09:11, Jan Kiszka ha scritto: On 2013-07-02 08:42, Paolo Bonzini wrote: Il 01/07/2013 20:33, Jan Kiszka ha scritto: On 2013-06-28 18:58, Paolo Bonzini wrote: Add ref/unref calls at the following places: - places where memory regions are stashed by a listener and used outside

Re: [Qemu-devel] [PATCHv2 11/11] iscsi: assert that sectors are aligned to LUN blocksize

2013-07-02 Thread Peter Lieven
Am 02.07.2013 um 09:44 schrieb Stefan Hajnoczi stefa...@gmail.com: On Mon, Jul 01, 2013 at 05:59:02PM +0200, Peter Lieven wrote: Am 01.07.2013 um 16:35 schrieb Stefan Hajnoczi stefa...@redhat.com: On Thu, Jun 27, 2013 at 03:11:35PM +0200, Peter Lieven wrote: if the blocksize of an iSCSI

Re: [Qemu-devel] [PATCH v2 06/11] memory: add ref/unref calls

2013-07-02 Thread Jan Kiszka
On 2013-07-02 10:18, Paolo Bonzini wrote: Il 02/07/2013 09:11, Jan Kiszka ha scritto: On 2013-07-02 08:42, Paolo Bonzini wrote: Il 01/07/2013 20:33, Jan Kiszka ha scritto: On 2013-06-28 18:58, Paolo Bonzini wrote: Add ref/unref calls at the following places: - places where memory regions

[Qemu-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
This patch introduces a new PCI device which will act as the binding point for Citrix branded PV drivers for Xen. The intention is that Citrix Windows PV drivers will be available on Windows Update and thus using the existing Xen platform PCI device as an anchor point is not desirable as that

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Jan Beulich
On 02.07.13 at 10:39, Paul Durrant paul.durr...@citrix.com wrote: --- a/include/hw/pci/pci_ids.h +++ b/include/hw/pci/pci_ids.h @@ -151,4 +151,7 @@ #define PCI_VENDOR_ID_TEWS 0x1498 #define PCI_DEVICE_ID_TEWS_TPCI200 0x30C8 +#define PCI_VENDOR_ID_CITRIX

Re: [Qemu-devel] [RFC] qemu-img: add option -d in convert

2013-07-02 Thread Stefan Hajnoczi
On Thu, Jun 27, 2013 at 08:30:04PM +0800, Wenchao Xia wrote: 于 2013-6-27 17:01, Stefan Hajnoczi 写道: On Tue, Jun 25, 2013 at 07:14:19PM +0800, Wenchao Xia wrote: 于 2013-6-25 17:13, Stefan Hajnoczi 写道: On Thu, Jun 20, 2013 at 04:59:17PM +0800, Wenchao Xia wrote: BTW we already have qemu-io -c

Re: [Qemu-devel] [PATCH] full introspection support for QMP

2013-07-02 Thread Amos Kong
On Thu, Jun 20, 2013 at 11:20:21PM -0400, Luiz Capitulino wrote: On Wed, 19 Jun 2013 20:24:37 +0800 Amos Kong ak...@redhat.com wrote: Introduces new monitor command to query QMP schema information, the return data is a nested dict/list, it contains the useful metadata. Thanks your

Re: [Qemu-devel] [PATCH] block: add the optional file entry to query-block

2013-07-02 Thread Stefan Hajnoczi
On Fri, Jun 28, 2013 at 10:32:30AM -0400, Federico Simoncelli wrote: This patch adds the optional file entry to the query-block output. The value is a json-object representing the information about the underlying file or device (when present). Signed-off-by: Federico Simoncelli

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 09:39 +0100, Paul Durrant wrote: This patch introduces a new PCI device which will act as the binding point for Citrix branded PV drivers for Xen. The intention is that Citrix Windows PV drivers will be available on Windows Update and thus using the existing Xen platform

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
-Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: 02 July 2013 09:46 To: Paul Durrant Cc: xen-de...@lists.xen.org; qemu-devel@nongnu.org Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device On 02.07.13 at 10:39, Paul Durrant paul.durr...@citrix.com wrote:

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 08:57 +, Paul Durrant wrote: -Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: 02 July 2013 09:46 To: Paul Durrant Cc: xen-de...@lists.xen.org; qemu-devel@nongnu.org Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device On

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
-Original Message- From: Ian Campbell Sent: 02 July 2013 10:02 To: Paul Durrant Cc: Jan Beulich; qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device On Tue, 2013-07-02 at 08:57 +, Paul Durrant wrote: -Original

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-07-02 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: On Wed, Jun 26, 2013 at 11:54:20AM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: We want to implement mac programming over macvtap through Libvirt, related rx-filter configuration contains main mac, some of rx-mode and mac-table.

[Qemu-devel] [PATCH] target-openrisc: Add typename for CPU models.

2013-07-02 Thread Dongxue Zhang
Make target-openrisc running OK by add typename in openrisc_cpu_class_by_name(). Signed-off-by: Dongxue Zhang elta@gmail.com --- target-openrisc/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c index fd90d37..d38c28b

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
-Original Message- From: Ian Campbell Sent: 02 July 2013 09:57 To: Paul Durrant Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device On Tue, 2013-07-02 at 09:39 +0100, Paul Durrant wrote: This patch introduces a new PCI device

Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report()

2013-07-02 Thread Stefan Hajnoczi
On Mon, Jul 01, 2013 at 02:54:07PM -0400, Seiji Aguchi wrote: diff --git a/qemu-options.hx b/qemu-options.hx index ca6fdf6..a6dac1a 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -3102,3 +3102,15 @@ HXCOMM This is the last statement. Insert new options before this line! STEXI

Re: [Qemu-devel] [PATCH] target-openrisc: Add typename for CPU models.

2013-07-02 Thread Jia Liu
Hi Dongxue, On Tue, Jul 2, 2013 at 5:11 PM, Dongxue Zhang elta@gmail.com wrote: Make target-openrisc running OK by add typename in openrisc_cpu_class_by_name(). Signed-off-by: Dongxue Zhang elta@gmail.com --- target-openrisc/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [Qemu-devel] [PATCH v2 06/11] memory: add ref/unref calls

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 10:36, Jan Kiszka ha scritto: Hmm, two solutions for one problem - can we improve this in the next round? Sure, I can adapt the hw/acpi/piix4.c to use ifs in the same style as hw/isa/lpc_ich9.c (I find the code easier to read). I was more referring to

Re: [Qemu-devel] [PATCH v2 06/11] memory: add ref/unref calls

2013-07-02 Thread Jan Kiszka
On 2013-07-02 11:28, Paolo Bonzini wrote: Il 02/07/2013 10:36, Jan Kiszka ha scritto: Hmm, two solutions for one problem - can we improve this in the next round? Sure, I can adapt the hw/acpi/piix4.c to use ifs in the same style as hw/isa/lpc_ich9.c (I find the code easier to read). I was

[Qemu-devel] [PATCH] qom: Use atomics for object refcounting

2013-07-02 Thread Jan Kiszka
Objects can soon be referenced/dereference outside the BQL. So we need to use atomics in object_ref/unref. Based on patch by Liu Ping Fan. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- qom/object.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/qom/object.c

Re: [Qemu-devel] [PATCHv2 07/11] iscsi: let bdrv_create conditionally zero out the device

2013-07-02 Thread Paolo Bonzini
Il 01/07/2013 23:36, Peter Lieven ha scritto: Am 01.07.2013 um 22:20 schrieb Paolo Bonzini pbonz...@redhat.com: Il 27/06/2013 15:11, Peter Lieven ha scritto: if the device supports unmapping and unmapped blocks read as zero ensure that the whole device is unmapped and report

Re: [Qemu-devel] [PATCH v2 06/11] memory: add ref/unref calls

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 11:31, Jan Kiszka ha scritto: On 2013-07-02 11:28, Paolo Bonzini wrote: Il 02/07/2013 10:36, Jan Kiszka ha scritto: Hmm, two solutions for one problem - can we improve this in the next round? Sure, I can adapt the hw/acpi/piix4.c to use ifs in the same style as

Re: [Qemu-devel] [PATCH] block: fix bdrv_flush() ordering in bdrv_close()

2013-07-02 Thread Kevin Wolf
Am 01.07.2013 um 13:29 hat Stefan Hajnoczi geschrieben: Since 80ccf93b we flush the block device during close. The bdrv_drain_all() call should come before bdrv_flush() to ensure guest write requests have completed. Otherwise we may miss pending writes when flushing. However, there is

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 10:14 +0100, Paul Durrant wrote: -Original Message- From: Ian Campbell Sent: 02 July 2013 09:57 To: Paul Durrant Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device On Tue, 2013-07-02 at 09:39

Re: [Qemu-devel] [PATCH 28/30] exec: change iotlb APIs to take AddressSpaceDispatch

2013-07-02 Thread Jan Kiszka
On 2013-06-28 20:26, Paolo Bonzini wrote: This makes it possible to start following RCU rules, which require not dereferencing as-dispatch more than once. It is not covering the whole of TCG, since the TLB data structures are not RCU-friendly, but it is enough for exec.c. Signed-off-by:

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Tim Deegan
At 10:56 +0100 on 02 Jul (1372762607), Ian Campbell wrote: On Tue, 2013-07-02 at 10:14 +0100, Paul Durrant wrote: I had actually coded up a solution based on the existing Xen platform device, by having it synthesize a device ID based on the Xen version to which we could then host the xenbus

Re: [Qemu-devel] [PATCH 3/7] nbd: use BDS refcount

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 07:59, Fam Zheng ha scritto: Previously, nbd call drive_get_ref on the drive of bs. A BDS doesn't always have associated dinfo, it's more proper to use bdrv_get_ref(). This has the important side effect of marking the exported disk as in_use (to use the terms before the series).

Re: [Qemu-devel] [PATCH] target-openrisc: Add typename for CPU models.

2013-07-02 Thread Andreas Färber
Hi Jia, Am 02.07.2013 11:29, schrieb Jia Liu: On Tue, Jul 2, 2013 at 5:11 PM, Dongxue Zhang elta@gmail.com mailto:elta@gmail.com wrote: Make target-openrisc running OK by add typename in openrisc_cpu_class_by_name(). Signed-off-by: Dongxue Zhang elta@gmail.com

Re: [Qemu-devel] [PATCH 1/7] block: Convert BlockDriverState.in_use to refcount

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 07:59, Fam Zheng ha scritto: Use numeric value to replace in_use flag in BDS, this will make lifecycle management with ref count possible. This patch only replaces existing uses of bdrv_set_in_use, so no logic change here. This still does not entirely explain the rules for who

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 11:15 +0100, Tim Deegan wrote: At 10:56 +0100 on 02 Jul (1372762607), Ian Campbell wrote: On Tue, 2013-07-02 at 10:14 +0100, Paul Durrant wrote: I had actually coded up a solution based on the existing Xen platform device, by having it synthesize a device ID based on

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
-Original Message- From: Ian Campbell Sent: 02 July 2013 11:24 To: Tim (Xen.org) Cc: Paul Durrant; qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device On Tue, 2013-07-02 at 11:15 +0100, Tim Deegan wrote: At 10:56 +0100 on 02 Jul

Re: [Qemu-devel] [PATCHv2 07/11] iscsi: let bdrv_create conditionally zero out the device

2013-07-02 Thread Peter Lieven
Am 02.07.2013 um 11:22 schrieb Paolo Bonzini pbonz...@redhat.com: Il 01/07/2013 23:36, Peter Lieven ha scritto: Am 01.07.2013 um 22:20 schrieb Paolo Bonzini pbonz...@redhat.com: Il 27/06/2013 15:11, Peter Lieven ha scritto: if the device supports unmapping and unmapped blocks read as

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
-Original Message- From: Ian Campbell Sent: 02 July 2013 11:24 To: Tim (Xen.org) Cc: Paul Durrant; qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device On Tue, 2013-07-02 at 11:15 +0100, Tim Deegan wrote: At 10:56 +0100 on 02 Jul

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 11:31 +0100, Paul Durrant wrote: XS, XC and anyone else who chooses could carry a separate patch that changes the default to 'install if there are no drivers', signalling over xenstore, or ACPI, or a Windows domain policy, or whatever. Right. Surely having

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Tim Deegan
At 10:31 + on 02 Jul (1372761105), Paul Durrant wrote: Well, the WU drivers could refuse to install except as upgrade to themselves (i.e. fail if there's any unknown driver bound to the xen platform device, and also fail if there's _no_ driver bound). Then the guest admin can

Re: [Qemu-devel] [PATCHv2 11/11] iscsi: assert that sectors are aligned to LUN blocksize

2013-07-02 Thread Peter Lieven
Am 02.07.2013 um 12:44 schrieb Paolo Bonzini pbonz...@redhat.com: Il 02/07/2013 10:28, Peter Lieven ha scritto: I agree that it's better to emit an error than to corrupt the disk. I'm just trying to understand what needs to be done on top of this to make 4 KB LUNs work. Reading is quite

Re: [Qemu-devel] [PATCHv2 08/11] block-migration: efficiently encode zero blocks

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 09:40, Stefan Hajnoczi ha scritto: On Mon, Jul 01, 2013 at 05:55:15PM +0200, Peter Lieven wrote: Am 01.07.2013 um 16:13 schrieb Stefan Hajnoczi stefa...@redhat.com: On Thu, Jun 27, 2013 at 03:11:32PM +0200, Peter Lieven wrote: This patch breaks cross-version blog migration.

Re: [Qemu-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
-Original Message- From: Andreas Färber [mailto:afaer...@suse.de] Sent: 02 July 2013 11:46 To: Paul Durrant Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Paolo Bonzini; Michael S. Tsirkin Subject: Re: [Qemu-devel] [PATCH] Citrix PV Bus device Am 02.07.2013 10:39, schrieb

Re: [Qemu-devel] [PATCHv2 11/11] iscsi: assert that sectors are aligned to LUN blocksize

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 12:49, Peter Lieven ha scritto: Am 02.07.2013 um 12:44 schrieb Paolo Bonzini pbonz...@redhat.com: Il 02/07/2013 10:28, Peter Lieven ha scritto: I agree that it's better to emit an error than to corrupt the disk. I'm just trying to understand what needs to be done on top of

Re: [Qemu-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 12:45, Andreas Färber ha scritto: Am 02.07.2013 10:39, schrieb Paul Durrant: This patch introduces a new PCI device which will act as the binding point for Citrix branded PV drivers for Xen. The intention is that Citrix Windows PV drivers will be available on Windows Update and

Re: [Qemu-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Andreas Färber
Am 02.07.2013 10:39, schrieb Paul Durrant: This patch introduces a new PCI device which will act as the binding point for Citrix branded PV drivers for Xen. The intention is that Citrix Windows PV drivers will be available on Windows Update and thus using the existing Xen platform PCI device

Re: [Qemu-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
-Original Message- From: Paolo Bonzini [mailto:pbonz...@redhat.com] Sent: 02 July 2013 11:54 To: Andreas Färber Cc: Paul Durrant; qemu-devel@nongnu.org; xen-de...@lists.xen.org; Michael S. Tsirkin Subject: Re: [Qemu-devel] [PATCH] Citrix PV Bus device Il 02/07/2013 12:45, Andreas

Re: [Qemu-devel] [PATCHv2 07/11] iscsi: let bdrv_create conditionally zero out the device

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 12:36, Peter Lieven ha scritto: Perhaps we can have a new discard_zeroes field in bdrv_get_info, and the unmap functionality can be moved up to qemu-img convert? Is there any other storage protocol out there that could benefit from it? Definitely LVM. Perhaps in the future

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Pasi Kärkkäinen
On Tue, Jul 02, 2013 at 11:48:46AM +0100, Ian Campbell wrote: On Tue, 2013-07-02 at 11:31 +0100, Paul Durrant wrote: XS, XC and anyone else who chooses could carry a separate patch that changes the default to 'install if there are no drivers', signalling over xenstore, or ACPI, or a

Re: [Qemu-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 12:57, Paul Durrant ha scritto: So the reason to place the device here is TARGET_PAGE_SIZE... We really need a way to access that value from common code, somewhere down my TODO list. :/ Why does it need to be in pages rather than bytes? It doesn't necessarily need to be in

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-07-02 Thread Amos Kong
On Tue, Jul 02, 2013 at 11:05:56AM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: diff --git a/net/net.c b/net/net.c index 43a74e4..7b73a10 100644 --- a/net/net.c +++ b/net/net.c @@ -961,6 +961,53 @@ void print_net_client(Monitor *mon, NetClientState *nc)

Re: [Qemu-devel] [PATCHv2 07/11] iscsi: let bdrv_create conditionally zero out the device

2013-07-02 Thread Peter Lieven
Am 02.07.2013 um 12:49 schrieb Paolo Bonzini pbonz...@redhat.com: Il 02/07/2013 12:36, Peter Lieven ha scritto: Perhaps we can have a new discard_zeroes field in bdrv_get_info, and the unmap functionality can be moved up to qemu-img convert? Is there any other storage protocol out there

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 11:49 +0100, Tim Deegan wrote: At 10:31 + on 02 Jul (1372761105), Paul Durrant wrote: Well, the WU drivers could refuse to install except as upgrade to themselves (i.e. fail if there's any unknown driver bound to the xen platform device, and also fail if

Re: [Qemu-devel] [PATCHv2 11/11] iscsi: assert that sectors are aligned to LUN blocksize

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 10:28, Peter Lieven ha scritto: I agree that it's better to emit an error than to corrupt the disk. I'm just trying to understand what needs to be done on top of this to make 4 KB LUNs work. Reading is quite easy, you just have to have a wrapper that is reading an aligned

Re: [Qemu-devel] [PATCHv2 07/11] iscsi: let bdrv_create conditionally zero out the device

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 12:56, Peter Lieven ha scritto: Am 02.07.2013 um 12:49 schrieb Paolo Bonzini pbonz...@redhat.com: Il 02/07/2013 12:36, Peter Lieven ha scritto: Perhaps we can have a new discard_zeroes field in bdrv_get_info, and the unmap functionality can be moved up to qemu-img convert?

Re: [Qemu-devel] [PATCH] qom: Use atomics for object refcounting

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 13:15, Andreas Färber ha scritto: @@ -683,16 +683,15 @@ GSList *object_class_get_list(const char *implements_type, void object_ref(Object *obj) { -obj-ref++; + __sync_fetch_and_add(obj-ref, 1); How widespread are these in GCC/clang? Is there any fallback?

Re: [Qemu-devel] [PATCHv2 07/11] iscsi: let bdrv_create conditionally zero out the device

2013-07-02 Thread Peter Lieven
Am 02.07.2013 um 13:04 schrieb Paolo Bonzini pbonz...@redhat.com: Il 02/07/2013 12:56, Peter Lieven ha scritto: Am 02.07.2013 um 12:49 schrieb Paolo Bonzini pbonz...@redhat.com: Il 02/07/2013 12:36, Peter Lieven ha scritto: Perhaps we can have a new discard_zeroes field in bdrv_get_info,

Re: [Qemu-devel] [PATCH] qom: Use atomics for object refcounting

2013-07-02 Thread Andreas Färber
Am 02.07.2013 11:36, schrieb Jan Kiszka: Objects can soon be referenced/dereference outside the BQL. So we need to use atomics in object_ref/unref. Based on patch by Liu Ping Fan. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- qom/object.c |5 ++--- 1 files changed, 2

Re: [Qemu-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Peter Maydell
On 2 July 2013 11:57, Paul Durrant paul.durr...@citrix.com wrote: -Original Message- From: Paolo Bonzini [mailto:pbonz...@redhat.com] So the reason to place the device here is TARGET_PAGE_SIZE... We really need a way to access that value from common code, somewhere down my TODO

Re: [Qemu-devel] [PATCH] qom: Use atomics for object refcounting

2013-07-02 Thread Jan Kiszka
On 2013-07-02 13:28, Paolo Bonzini wrote: Il 02/07/2013 13:15, Andreas Färber ha scritto: @@ -683,16 +683,15 @@ GSList *object_class_get_list(const char *implements_type, void object_ref(Object *obj) { -obj-ref++; + __sync_fetch_and_add(obj-ref, 1); How widespread are these

Re: [Qemu-devel] [PATCH] MAINTAINERS: fix bad F: patterns

2013-07-02 Thread Peter Maydell
Ping! thanks -- PMM On 24 June 2013 11:49, Peter Maydell peter.mayd...@linaro.org wrote: This patch fixes a number of incorrect F: patterns which didn't match any files in the source tree. This was caused by a mix of minor typos (- for _ and the like) and a few entries which hadn't been

Re: [Qemu-devel] [PATCH] qom: Use atomics for object refcounting

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 13:44, Jan Kiszka ha scritto: On 2013-07-02 13:28, Paolo Bonzini wrote: Il 02/07/2013 13:15, Andreas Färber ha scritto: @@ -683,16 +683,15 @@ GSList *object_class_get_list(const char *implements_type, void object_ref(Object *obj) { -obj-ref++; +

Re: [Qemu-devel] [PATCH] MAINTAINERS: fix bad F: patterns

2013-07-02 Thread Alexander Graf
On 07/02/2013 01:29 PM, Peter Maydell wrote: Ping! Who are you pinging here? Alex thanks -- PMM On 24 June 2013 11:49, Peter Maydellpeter.mayd...@linaro.org wrote: This patch fixes a number of incorrect F: patterns which didn't match any files in the source tree. This was caused by a

Re: [Qemu-devel] [PATCH] qom: Use atomics for object refcounting

2013-07-02 Thread Jan Kiszka
On 2013-07-02 13:49, Paolo Bonzini wrote: Il 02/07/2013 13:44, Jan Kiszka ha scritto: On 2013-07-02 13:28, Paolo Bonzini wrote: Il 02/07/2013 13:15, Andreas Färber ha scritto: @@ -683,16 +683,15 @@ GSList *object_class_get_list(const char *implements_type, void object_ref(Object *obj)

Re: [Qemu-devel] [PATCH] MAINTAINERS: fix bad F: patterns

2013-07-02 Thread Peter Maydell
On 2 July 2013 12:51, Alexander Graf ag...@suse.de wrote: On 07/02/2013 01:29 PM, Peter Maydell wrote: Ping! Who are you pinging here? Our nonexistent mechanism for dealing with patches to files which don't have an obvious maintainer :-) (I didn't realise I hadn't cc'd Anthony on the patch

Re: [Qemu-devel] [PATCH] target-openrisc: Add typename for CPU models.

2013-07-02 Thread Jia Liu
Hi Andreas, On Tue, Jul 2, 2013 at 6:18 PM, Andreas Färber afaer...@suse.de wrote: Hi Jia, Am 02.07.2013 11:29, schrieb Jia Liu: On Tue, Jul 2, 2013 at 5:11 PM, Dongxue Zhang elta@gmail.com mailto:elta@gmail.com wrote: Make target-openrisc running OK by add typename in

Re: [Qemu-devel] [PATCH v4 06/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-07-02 Thread Gal Hammer
On 01/07/2013 21:57, Tomoki Sekiyama wrote: So why don't you query for the interface you supports rather than checking the OS version? Hmm, I don't know what I should query for. Microsoft's document above only provides a table of compatibility between VSS SDK version and OS version. Of

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
-Original Message- From: Ian Campbell Sent: 02 July 2013 11:57 To: Tim (Xen.org) Cc: Paul Durrant; qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device On Tue, 2013-07-02 at 11:49 +0100, Tim Deegan wrote: At 10:31 + on 02 Jul

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Paul Durrant
-Original Message- From: Tim Deegan [mailto:t...@xen.org] Sent: 02 July 2013 11:50 To: Paul Durrant Cc: Ian Campbell; qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device At 10:31 + on 02 Jul (1372761105), Paul Durrant wrote:

Re: [Qemu-devel] [PATCH v2] spapr: Fix compiler warnings for some versions of gcc

2013-07-02 Thread Alexander Graf
On 06/29/2013 03:47 PM, Stefan Weil wrote: i686-w64-mingw32-gcc (GCC) 4.6.3 from Debian wheezy reports these warnings: hw/ppc/spapr_hcall.c:188:1: warning: control reaches end of non-void function [-Wreturn-type] hw/ppc/spapr_pci.c:454:1: warning: control reaches end of non-void function

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-02 Thread Ian Campbell
On Tue, 2013-07-02 at 13:35 +0100, Paul Durrant wrote: -Original Message- From: Ian Campbell Sent: 02 July 2013 11:57 To: Tim (Xen.org) Cc: Paul Durrant; qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device On Tue, 2013-07-02

Re: [Qemu-devel] [PATCH 1/3] spapr: Use named enum for function remove_hpte

2013-07-02 Thread Alexander Graf
On 06/24/2013 07:48 PM, Stefan Weil wrote: The function returned a target_ulong which was made from unnamed enum values. The target_ulong was then assigned to an int variable which was used in a switch statement. Using a named enum in both cases makes reviews easier. Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH 3/3] spapr: Fix compiler warning for some versions of gcc (spapr_io_read)

2013-07-02 Thread Alexander Graf
On 06/24/2013 07:48 PM, Stefan Weil wrote: i686-w64-mingw32-gcc (GCC) 4.6.3 from Debian wheezy reports this warning: hw/ppc/spapr_pci.c:454:1: warning: control reaches end of non-void function [-Wreturn-type] Adding a default case to the switch statement satisfies the compiler. This

[Qemu-devel] [PATCH] int128: optimize

2013-07-02 Thread Jay Foad
static inline Int128 int128_neg(Int128 a) { -a.lo = ~a.lo; -a.hi = ~a.hi; -return int128_add(a, int128_one()); +uint64_t lo = -a.lo; +return (Int128) { lo, ~a.hi + !lo }; } This leaves int128_one unused. (Also the temporary lo seems a bit pointless, since you could

Re: [Qemu-devel] [PATCH] qom: Use atomics for object refcounting

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 13:52, Jan Kiszka ha scritto: But then atomic_dec_and_test or so. Letting the inc/dec return some value leaves room for interpretations (value of before or after the modification?). In qemu, I made all atomic_* functions return the old value. This is consistent with

Re: [Qemu-devel] Significant slowdown after qemu-kvm-1.2.0

2013-07-02 Thread jinho hwang
On Mon, Jul 1, 2013 at 7:48 PM, Andreas Färber afaer...@suse.de wrote: Hi, Am 02.07.2013 00:24, schrieb jinho hwang: Thank you for your reply. I tried qemu-1.5.0 with --enable-kvm, but there is still a big difference between qemu-kvm-1.2.0 and qemu-1.5.0. They both use the same command

Re: [Qemu-devel] [PATCH v3] e600 core for MPC86xx processors

2013-07-02 Thread Alexander Graf
On 06/24/2013 11:15 PM, Julio Guerra wrote: MPC86xx processors are based on the e600 core, which is not the case in qemu where it is based on the 7400 processor. This patch creates the e600 core and instantiates the MPC86xx processors based on it. Therefore, adding the high BATs, the SPRG 4..7

Re: [Qemu-devel] [PATCH 3/3] target-arm: explicitly decode SEVL instruction

2013-07-02 Thread Peter Maydell
On 13 June 2013 14:15, Andreas Färber afaer...@suse.de wrote: Am 07.06.2013 14:06, schrieb Mans Rullgard: case 2: /* wfe */ case 4: /* sev */ +case 5: /* sevl */ /* TODO: Implement SEV and WFE. May help SMP performance. */ default: /* nop */ break;

  1   2   3   >