Re: [Qemu-devel] [PATCH 3/7] nbd: use BDS refcount

2013-07-03 Thread Paolo Bonzini
Il 03/07/2013 03:10, Fam Zheng ha scritto: This has the important side effect of marking the exported disk as in_use (to use the terms before the series). Right now you can serve a disk and, at the same time, stream it or mirror it or create a live snapshot of it. Do we really want

Re: [Qemu-devel] [PATCH 04/30] add a header file for atomic operations

2013-07-03 Thread Paolo Bonzini
Il 03/07/2013 04:24, liu ping fan ha scritto: +- atomic operations in Linux are always on a 32-bit int type and 32-bit? int should be the integer type that the target processor is most efficient working with. Has Linux ever been ported to a machine where sizeof(int) != 4? (Honest question.

[Qemu-devel] moving CHR_EVENT_OPEN out of BH broke echo for muxed mon

2013-07-03 Thread Michael Tokarev
Before commit bd5c51ee6c4f1c79cae5ad2516d711a27b4ea8ec Author: Michael Roth mdr...@linux.vnet.ibm.com Date: Fri Jun 7 15:19:53 2013 -0500 qemu-char: don't issue CHR_EVENT_OPEN in a BH we had no echo by default with -nographic, and it gave the prompt when switching to monitor: $

Re: [Qemu-devel] Wayland support

2013-07-03 Thread Alexandre DERUMIER
I don't known if it's what you want, but wayland have a beta spice backend http://www.phoronix.com/scan.php?page=news_itempx=MTM1NzQ - Mail original - De: Max A Yu max.a...@intel.com À: qemu-devel@nongnu.org Envoyé: Mardi 2 Juillet 2013 05:36:50 Objet: [Qemu-devel] Wayland support

Re: [Qemu-devel] [PATCH v2 5/6] net: defer nested call to BH

2013-07-03 Thread Paolo Bonzini
Il 13/06/2013 11:03, Liu Ping Fan ha scritto: From: Liu Ping Fan pingf...@linux.vnet.ibm.com Nested call caused by -receive() will raise issue like deadlock, so postphone it to BH. When I read this patch, I am completely puzzled. All I see is that a qemu_net_queue_flush is done in a bottom

Re: [Qemu-devel] [PATCH 3/7] nbd: use BDS refcount

2013-07-03 Thread Fam Zheng
On Wed, 07/03 07:58, Paolo Bonzini wrote: Il 03/07/2013 03:10, Fam Zheng ha scritto: This has the important side effect of marking the exported disk as in_use (to use the terms before the series). Right now you can serve a disk and, at the same time, stream it or mirror it or create a

[Qemu-devel] [PATCH v2 1/2] trap signals for -serial mon:stdio

2013-07-03 Thread Michael Tokarev
From: Paolo Bonzini pbonz...@redhat.com With mon:stdio you can exit the VM by switching to the monitor and sending the quit command. It is then useful to pass Ctrl-C to the VM instead of exiting. This in turn lets us stop tying the default signal handling behavior to -nographic, removing

[Qemu-devel] [PATCH v2 2/2] display: stop using DT_NOGRAPHIC, use DT_NONE

2013-07-03 Thread Michael Tokarev
It looks like initially there was -nographic option to turn off display, now there's another option of the same sort, -display none. But code in other places of qemu checks for DT_NOGRAPHIC and does not work well with -display none. Make DT_NOGRAPHIC an internal version which selects DT_NONE, and

Re: [Qemu-devel] [PATCH 04/30] add a header file for atomic operations

2013-07-03 Thread liu ping fan
On Wed, Jul 3, 2013 at 1:59 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 03/07/2013 04:24, liu ping fan ha scritto: +- atomic operations in Linux are always on a 32-bit int type and 32-bit? int should be the integer type that the target processor is most efficient working with. Has

Re: [Qemu-devel] [PATCH v2 1/2] trap signals for -serial mon:stdio

2013-07-03 Thread Paolo Bonzini
Il 03/07/2013 08:44, Michael Tokarev ha scritto: V2: added code comments and documentation fixes by mjt (hopefully the s-o-b stands still) Yes, s-o-b means I effectively donate the patch to the community. Paolo

Re: [Qemu-devel] [PATCH v2 1/2] trap signals for -serial mon:stdio

2013-07-03 Thread Paolo Bonzini
Il 03/07/2013 08:44, Michael Tokarev ha scritto: From: Paolo Bonzini pbonz...@redhat.com With mon:stdio you can exit the VM by switching to the monitor and sending the quit command. It is then useful to pass Ctrl-C to the VM instead of exiting. This in turn lets us stop tying the default

Re: [Qemu-devel] [PATCH 3/7] nbd: use BDS refcount

2013-07-03 Thread Paolo Bonzini
Il 03/07/2013 08:30, Fam Zheng ha scritto: The close notifier runs when the user invokes a drive_del or eject command from the monitor. The drive_get_ref/drive_put_ref delays the bdrv_delete until after nbd.c has cleaned up all the connections. But drive_put_ref is called by close

Re: [Qemu-devel] [PATCH v2 3/6] net: make netclient re-entrant with refcnt

2013-07-03 Thread Stefan Hajnoczi
On Wed, Jul 03, 2013 at 11:41:19AM +0800, liu ping fan wrote: On Mon, Jul 1, 2013 at 7:50 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jun 20, 2013 at 05:14:56PM +0800, liu ping fan wrote: On Tue, Jun 18, 2013 at 8:41 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jun

Re: [Qemu-devel] [RFC V8 01/24] qcow2: Add journal specification.

2013-07-03 Thread Stefan Hajnoczi
On Tue, Jul 02, 2013 at 04:54:46PM +0200, Kevin Wolf wrote: Am 02.07.2013 um 16:42 hat Stefan Hajnoczi geschrieben: On Thu, Jun 20, 2013 at 04:26:09PM +0200, Benoît Canet wrote: --- docs/specs/qcow2.txt | 42 ++ 1 file changed, 42

Re: [Qemu-devel] [PATCH v2 3/6] net: make netclient re-entrant with refcnt

2013-07-03 Thread liu ping fan
On Wed, Jul 3, 2013 at 3:49 PM, Stefan Hajnoczi stefa...@redhat.com wrote: On Wed, Jul 03, 2013 at 11:41:19AM +0800, liu ping fan wrote: On Mon, Jul 1, 2013 at 7:50 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jun 20, 2013 at 05:14:56PM +0800, liu ping fan wrote: On Tue, Jun 18,

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Paul Durrant
-Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: 02 July 2013 17:42 To: Paul Durrant Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device [V3] On Tue, 2 Jul 2013, Paul Durrant wrote:

Re: [Qemu-devel] 回复: Re: Which part of qemu responds to ACPI control method?

2013-07-03 Thread Laszlo Ersek
On 07/03/13 04:14, bobooscar wrote: Take the method “_PTS” for example, how could I know how it access a certain hardware, and what hardware it accesses? I am a newbie in this field, thanks in advance;) In POSIX-like guests, you can dump the ACPI tables with the acpidump utility (pmtools

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-03 Thread Qiao Nuohan
On 07/01/2013 07:45 PM, Stefan Hajnoczi wrote: I'm now convinced that kdump is worthwhile, thanks for providing data. It would be nice to see the flattened kdump approach. Hi Stefan and Luiz, Thanks for Stefan's review again! I am starting to implement the function using flatten format. And

Re: [Qemu-devel] [RFC V8 01/24] qcow2: Add journal specification.

2013-07-03 Thread Stefan Hajnoczi
On Tue, Jul 02, 2013 at 11:23:56PM +0200, Benoît Canet wrote: +QCOW2 can use one or more instance of a metadata journal. s/instance/instances/ Is there a reason to use multiple journals rather than a single journal for all entry types? The single journal area avoids seeks. Here

Re: [Qemu-devel] [RFC V8 01/24] qcow2: Add journal specification.

2013-07-03 Thread Kevin Wolf
Am 02.07.2013 um 23:23 hat Benoît Canet geschrieben: Also since deduplication will not work on spinning disk I discarded the seek time factor. Care to explain that in more detail? Why shouldn't it work on spinning disks? Kevin

Re: [Qemu-devel] [PATCH 6/9] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-07-03 Thread Asias He
On Wed, Jul 03, 2013 at 11:23:26AM +0800, Asias He wrote: On Fri, Jun 21, 2013 at 10:16:48AM +, Libaiqing wrote: Hi Asias, -Original Message- From: Asias He [mailto:as...@redhat.com] Sent: Thursday, June 20, 2013 5:39 PM To: Libaiqing Cc: Paolo Bonzini; Wenchao

Re: [Qemu-devel] [RFC V8 01/24] qcow2: Add journal specification.

2013-07-03 Thread Kevin Wolf
Am 02.07.2013 um 23:26 hat Benoît Canet geschrieben: 2. Byte-granularity means that read-modify-write is necessary to append entries to the journal. Therefore a failure could destroy previously committed entries. Any ideas how existing journals handle this? You

Re: [Qemu-devel] [PATCH v2 1/2] trap signals for -serial mon:stdio

2013-07-03 Thread Michael Tokarev
03.07.2013 11:13, Paolo Bonzini wrote: ... --- a/qemu-options.hx +++ b/qemu-options.hx @@ -842,7 +842,8 @@ STEXI Normally, QEMU uses SDL to display the VGA output. With this option, you can totally disable graphical output so that QEMU is a simple command line application. The emulated

Re: [Qemu-devel] [PATCH v3] linux-user: improve target_to_host_sock_type conversion

2013-07-03 Thread Petar Jovanovic
From: Peter Maydell [peter.mayd...@linaro.org] Sent: Tuesday, July 02, 2013 6:34 PM To: Petar Jovanovic Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurel...@aurel32.net; riku.voi...@linaro.org; r...@twiddle.net Subject: Re: [PATCH v3] linux-user: improve

Re: [Qemu-devel] [RFC V8 01/24] qcow2: Add journal specification.

2013-07-03 Thread Stefan Hajnoczi
On Tue, Jul 02, 2013 at 11:23:56PM +0200, Benoît Canet wrote: Any ideas how existing journals handle this? By the way, I don't know much about journalling techniques. So I'm asking you these questions so that either you can answer them straight away or because they might warrant a look at

Re: [Qemu-devel] [PATCH v2 1/2] trap signals for -serial mon:stdio

2013-07-03 Thread Michael Tokarev
03.07.2013 12:09, Michael Tokarev wrote: ... I'll resend a v3 with this change. The first 1/2 patch (trap signals) and the actual code did not change. ... @@ -2494,7 +2503,7 @@ listening on port would be: @item -serial mon:telnet::,server,nowait @end table When monitor is

Re: [Qemu-devel] Wayland support

2013-07-03 Thread Yu, Max A
Thanks Alex! Currently I'm trying to enable Wayland in Tizen Emulator. Tizen Emulator is a clone of QEMU. Tizen can run in it as guest OS. It seems like that spice does not fit this requirement. Thanks, Max -Original Message- From: Alexandre DERUMIER [mailto:aderum...@odiso.com] Sent:

Re: [Qemu-devel] [PATCH v2 1/2] trap signals for -serial mon:stdio

2013-07-03 Thread Paolo Bonzini
Just a couple more suggestions. /mjt --- a/qemu-options.hx +++ b/qemu-options.hx @@ -825,7 +825,11 @@ a text mode. Generally only the VGA device models support text mode. @item none Do not display video output. The guest will still see an emulated graphics card, but its output will

Re: [Qemu-devel] [PATCH v2] semaphore: fix a hangup problem under load on NetBSD hosts.

2013-07-03 Thread Laszlo Ersek
On 07/02/13 18:54, Izumi Tsutsui wrote: Fix following bugs in fallback implementation of counting semaphores with mutex+condvar added in c166cb72f1676855816340666c3b618beef4b976: - waiting threads are not restarted properly if more than one threads are waiting unblock signals in

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Ian Campbell
On Tue, 2013-07-02 at 19:05 +0100, Stefano Stabellini wrote: On Tue, 2 Jul 2013, Stefano Stabellini wrote: - the new device should have configurable vendor and device ids, so that host admins can select which vendor's PV drivers are going to be automatically installed on all your Windows

Re: [Qemu-devel] [PATCH v2] block: fix bdrv_flush() ordering in bdrv_close()

2013-07-03 Thread Stefan Hajnoczi
On Tue, Jul 02, 2013 at 03:36:25PM +0200, Stefan Hajnoczi wrote: Since 80ccf93b we flush the block device during close. The bdrv_drain_all() call should come before bdrv_flush() to ensure guest write requests have completed. Otherwise we may miss pending writes when flushing. Call

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Paul Durrant
-Original Message- From: Ian Campbell Sent: 03 July 2013 09:29 To: Stefano Stabellini Cc: Paolo Bonzini; Paul Durrant; qemu-devel@nongnu.org; Anthony Liguori; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [Qemu-devel] [PATCH] Citrix PV Bus device [V3] On Tue, 2013-07-02 at

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Ian Campbell
On Wed, 2013-07-03 at 09:34 +0100, Paul Durrant wrote: -Original Message- From: Ian Campbell Sent: 03 July 2013 09:29 To: Stefano Stabellini Cc: Paolo Bonzini; Paul Durrant; qemu-devel@nongnu.org; Anthony Liguori; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [Qemu-devel]

[Qemu-devel] [PULL 0/5] KVM changes for 2013-07-03

2013-07-03 Thread Paolo Bonzini
Anthony, The following changes since commit 1acd5a373905ddb28957842256a038956941f332: Merge remote-tracking branch 'agraf/ppc-for-upstream' into staging (2013-07-01 09:03:04 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master for

[Qemu-devel] [PATCH 3/5] kvm: skip system call when msi route is unchanged

2013-07-03 Thread Paolo Bonzini
From: Michael S. Tsirkin m...@redhat.com Some guests do a large number of mask/unmask calls which currently trigger expensive route update system calls. Detect that route in unchanged and skip the system call. Reported-by: Zhanghaoyu (A) haoyu.zh...@huawei.com Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PATCH 2/5] kvm: zero-initialize KVM_SET_GSI_ROUTING input

2013-07-03 Thread Paolo Bonzini
From: Michael S. Tsirkin m...@redhat.com kvm_add_routing_entry makes an attempt to zero-initialize any new routing entry. However, it fails to initialize padding within the u field of the structure kvm_irq_routing_entry. Other functions like kvm_irqchip_update_msi_route also fail to initialize

[Qemu-devel] [PATCH 4/5] pci-assign: remove the duplicate function name in debug message

2013-07-03 Thread Paolo Bonzini
From: Wanlong Gao gaowanl...@cn.fujitsu.com While DEBUG() already includes the function name. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Acked-by: Alex Williamson alex.william...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/i386/kvm/pci-assign.c | 12 ++--

[Qemu-devel] [PATCH 1/5] kvm: add detail error message when fail to add ioeventfd

2013-07-03 Thread Paolo Bonzini
From: Amos Kong ak...@redhat.com I try to hotplug 28 * 8 multiple-function devices to guest with old host kernel, ioeventfds in host kernel will be exhausted, then qemu fails to allocate ioeventfds for blk/nic devices. It's better to add detail error here. Signed-off-by: Amos Kong

[Qemu-devel] [PATCH 5/5] kvmclock: clock should count only if vm is running

2013-07-03 Thread Paolo Bonzini
From: Marcelo Tosatti mtosa...@redhat.com kvmclock should not count while vm is paused, because: 1) if the vm is paused for long periods, timekeeping math can overflow while converting the (large) clocksource delta to nanoseconds. 2) Users rely on CLOCK_MONOTONIC to count run time, that is,

Re: [Qemu-devel] [PATCH v2] semaphore: fix a hangup problem underload on NetBSD hosts.

2013-07-03 Thread Izumi Tsutsui
Laszlo Ersek wrote: On 07/02/13 18:54, Izumi Tsutsui wrote: : @@ -249,16 +250,19 @@ int qemu_sem_timedwait(QemuSemaphore *sem, int ms) void qemu_sem_wait(QemuSemaphore *sem) { +int rc; + #if defined(__APPLE__) || defined(__NetBSD__) pthread_mutex_lock(sem-lock);

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-07-03 Thread Stefan Hajnoczi
On Tue, Jul 02, 2013 at 09:35:41AM +0200, Christian Berendt wrote: On 07/02/2013 09:31 AM, Stefan Hajnoczi wrote: I think the solution is to add another buildmaster administrator. I believe Christian offered that in the past. Sure. I think it would be the best to have an additional admin

[Qemu-devel] [PATCH v3] semaphore: fix a hangup problem under load on NetBSD hosts.

2013-07-03 Thread Izumi Tsutsui
Fix following bugs in fallback implementation of counting semaphores with mutex+condvar added in c166cb72f1676855816340666c3b618beef4b976: - waiting threads are not restarted properly if more than one threads are waiting unblock signals in qemu_sem_timedwait() - possible missing

Re: [Qemu-devel] [PATCH v2 1/9] tcg: Split rem requirement from div requirement

2013-07-03 Thread Claudio Fontana
Hi Richard, On 26.06.2013 22:52, Richard Henderson wrote: There are several hosts with only a div insn. Remainder is computed manually from the quotient and inputs. We can do this generically. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.h | 2 ++

Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report()

2013-07-03 Thread Stefan Hajnoczi
On Tue, Jul 02, 2013 at 02:09:24PM +, Seiji Aguchi wrote: diff --git a/util/qemu-time.c b/util/qemu-time.c new file mode 100644 index 000..3862788 --- /dev/null +++ b/util/qemu-time.c @@ -0,0 +1,26 @@ +/* + * Time handling + * + * Copyright (C) 2013 Hitachi

Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report()

2013-07-03 Thread Stefan Hajnoczi
On Tue, Jul 02, 2013 at 02:09:24PM +, Seiji Aguchi wrote: +DEF(msg, HAS_ARG, QEMU_OPTION_msg, +-msg [timestamp=on|off]\n + change the format of messages\n + timestamp=on|off enables leading timestamps (default:on)\n, +QEMU_ARCH_ALL) +STEXI +@item -msg

Re: [Qemu-devel] [PATCH v3] semaphore: fix a hangup problem under load on NetBSD hosts.

2013-07-03 Thread Laszlo Ersek
On 07/03/13 10:58, Izumi Tsutsui wrote: Fix following bugs in fallback implementation of counting semaphores with mutex+condvar added in c166cb72f1676855816340666c3b618beef4b976: - waiting threads are not restarted properly if more than one threads are waiting unblock signals in

[Qemu-devel] [PATCH] ich9: update sci on gpe write

2013-07-03 Thread Hu Tao
Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/acpi/ich9.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 4a17f32..8dc5300 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -79,6 +79,7 @@ static void ich9_gpe_writeb(void *opaque, hwaddr addr,

Re: [Qemu-devel] [PATCH 01/15] target-i386: cpu: convert 'family' to static property

2013-07-03 Thread chenfan
On Mon, 2013-06-24 at 13:53 -0300, Eduardo Habkost wrote: On Wed, Jun 05, 2013 at 03:18:32PM +0200, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Chen Fan chen.fan.f...@cn.fujitsu.com ---

Re: [Qemu-devel] [PATCH v4 3/3] blockdev: do not open block device if password is not required but user provides one

2013-07-03 Thread Stefan Hajnoczi
On Mon, Jun 24, 2013 at 02:12:52PM +0200, Pavel Hrdina wrote: This fixes the issue that block device is openned successfully with an error as warning if password is provided but not required. Now the open fails with the error message. Signed-off-by: Pavel Hrdina phrd...@redhat.com ---

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Stefano Stabellini
On Wed, 3 Jul 2013, Paul Durrant wrote: - the Citrix [vendor id|device id] pair has to be different from the xenproject one (0x5853|0x0001). I am sure we can arrange the xenproject device id space so that Windows PV drivers vendors don't have to acquire their own PCI vendor ids. This

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Paul Durrant
-Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: 03 July 2013 11:50 To: Paul Durrant Cc: Stefano Stabellini; qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: RE: [Xen-devel] [PATCH] Citrix PV Bus device [V3] On Wed, 3 Jul 2013,

[Qemu-devel] [PATCH] Xen PV Device

2013-07-03 Thread Paul Durrant
This patch introduces a new Xen PV PCI device which will act as a new binding point for PV drivers for Xen. The device has parameterized vendor-id, device-id and revision to allow to be configured as a binding point for any vendor's PV drivers. Signed-off-by: Paul Durrant paul.durr...@citrix.com

Re: [Qemu-devel] [PATCH v2 3/6] net: make netclient re-entrant with refcnt

2013-07-03 Thread Stefan Hajnoczi
On Wed, Jul 03, 2013 at 03:54:44PM +0800, liu ping fan wrote: On Wed, Jul 3, 2013 at 3:49 PM, Stefan Hajnoczi stefa...@redhat.com wrote: On Wed, Jul 03, 2013 at 11:41:19AM +0800, liu ping fan wrote: On Mon, Jul 1, 2013 at 7:50 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jun 20,

[Qemu-devel] Dataplane status for RHEL7

2013-07-03 Thread Stefan Hajnoczi
Ademar asked for a status update on virtio-blk-data-plane. Here is my status, please let me know if you have any questions or concerns. RHEL7 Features -- For RHEL7 my goal is to deliver the following dataplane features: 1. Image format support 2. QMP 'transaction' support (creating

Re: [Qemu-devel] [RFC V8 01/24] qcow2: Add journal specification.

2013-07-03 Thread Benoît Canet
Care to explain that in more detail? Why shouldn't it work on spinning disks? Hash are random they introduce random read access. With a QCOW2 cluster size of 4KB the deduplication code when writting duplicated data will do one random read per 4KB block to deduplicate. A server grade hardisk

Re: [Qemu-devel] [RFC V8 01/24] qcow2: Add journal specification.

2013-07-03 Thread Benoît Canet
Does this mean the journal forms the first-stage data structure for deduplication? Dedup records will accumulate in the journal until it becomes time to convert them in bulk into a more compact representation? The journal is mainly used to persist the last inserted dedup metadata across QEMU

Re: [Qemu-devel] [PATCH 6/9] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-07-03 Thread Libaiqing
Hi asias, I got the rootcause:guest was installed on raw img with lvm partition,which vhost does not support. Now vhost-scsi can be used as bootable device. Thanks baiqing -Original Message- From: Asias He [mailto:as...@redhat.com] Sent: Wednesday, July 03, 2013 4:09 PM

Re: [Qemu-devel] [RFC V8 01/24] qcow2: Add journal specification.

2013-07-03 Thread Benoît Canet
By the way, I don't know much about journalling techniques. So I'm asking you these questions so that either you can answer them straight away or because they might warrant a look at existing journal implementations like: I tried to so something simple and performing for the deduplication

Re: [Qemu-devel] Dataplane status for RHEL7

2013-07-03 Thread Stefan Hajnoczi
On Wed, Jul 3, 2013 at 2:26 PM, Stefan Hajnoczi stefa...@redhat.com wrote: This email was sent to qemu-devel by mistake. Please disregard. I will indeed be sending patches later this week. Stefan

Re: [Qemu-devel] [PATCH] full introspection support for QMP

2013-07-03 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 02/07/2013 22:58, Anthony Liguori ha scritto: We consume the schema in QEMU. No reason for us to consume it in a different format than libvirt. One reason could be that qapi-schema.json, as written, lacks a schema that can be expressed

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Anthony Liguori
Ian Campbell ian.campb...@citrix.com writes: On Wed, 2013-07-03 at 09:34 +0100, Paul Durrant wrote: Already did that :-) There are also sub-vendor and sub-device IDs but I don't think they are so useful for us (AFAIK they are intended to allow the board manufacturer to subclass the IDs

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Ian Campbell
On Wed, 2013-07-03 at 08:45 -0500, Anthony Liguori wrote: Ian Campbell ian.campb...@citrix.com writes: On Wed, 2013-07-03 at 09:34 +0100, Paul Durrant wrote: Already did that :-) There are also sub-vendor and sub-device IDs but I don't think they are so useful for us (AFAIK they

[Qemu-devel] best way to provide disk storage for vm without shared storage system

2013-07-03 Thread Vasiliy Tolstov
Hello. I'm very happy with libvirt and qemu, that great software! (after some playing i want to create golang bindings to libvirt).. Now i provide ext4 fs for qcow2 images (raid1 with two sata disks). Now i don't need live migration (but may need it in feature). What is the best way to provide

[Qemu-devel] [PATCH 03/17] cow: do not call bdrv_co_is_allocated

2013-07-03 Thread Paolo Bonzini
As we change bdrv_is_allocated to gather more information from bs and bs-file, it will become a bit slower. It is still appropriate for online jobs, but not for reads/writes. Call the internal function instead. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/cow.c | 5 - 1 file

[Qemu-devel] [PATCH 04/17] block: make bdrv_co_is_allocated static

2013-07-03 Thread Paolo Bonzini
bdrv_is_allocated can detect coroutine context and go through a fast path, similar to other block layer functions. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c | 24 +++- block/raw.c | 2 +- block/stream.c| 4 ++--

[Qemu-devel] [PATCH 00/17] Add qemu-img subcommand to dump file metadata

2013-07-03 Thread Paolo Bonzini
This series adds a subcommand to map that can dump file metadata. Metadata that is dumped includes: - whether blocks are allocated in bs-file and, if so, where - whether blocks are zero - whether data is read from bs or bs-backing_hd Metadata is dumped for an entire chain of images. One

[Qemu-devel] [PATCH 01/17] cow: make reads go at a decent speed

2013-07-03 Thread Paolo Bonzini
Do not do two reads for each sector; load each sector of the bitmap and use bitmap operations to process it. Writes are still dog slow! Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/cow.c | 54 -- 1 file changed, 32 insertions(+),

[Qemu-devel] [PATCH 07/17] qemu-img: always probe the input image for allocated sectors

2013-07-03 Thread Paolo Bonzini
qemu-img convert is assuming that sectors which are unallocated in the input image are present in both the output's and input's base images, but it is only doing this if the output image is zero initialized. And checking if the output image is zero initialized does not make much sense if the

[Qemu-devel] [PATCH 11/17] block: return get_block_status data and flags for formats

2013-07-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/cow.c | 8 +++- block/qcow.c | 9 - block/qcow2.c| 16 ++-- block/qed.c | 35 --- block/sheepdog.c | 2 +- block/vdi.c | 13 - block/vmdk.c

[Qemu-devel] [PATCH 08/17] block: make bdrv_has_zero_init return false for copy-on-write-images

2013-07-03 Thread Paolo Bonzini
This helps implementing is_allocated on top of get_block_status. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c| 5 + qemu-img.c | 9 + 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/block.c b/block.c index 3852130..ab7d0bc 100644 --- a/block.c +++

[Qemu-devel] [PATCH 02/17] cow: make writes go at a less indecent speed

2013-07-03 Thread Paolo Bonzini
Only sync once per write, rather than once per sector. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/cow.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/block/cow.c b/block/cow.c index 204451e..133e596 100644 --- a/block/cow.c +++

[Qemu-devel] [PATCH 05/17] block: remove bdrv_is_allocated_above/bdrv_co_is_allocated_above distinction

2013-07-03 Thread Paolo Bonzini
Now that bdrv_is_allocated detects coroutine context, the two can use the same code. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c | 46 -- block/commit.c| 6 +++--- block/mirror.c| 4 ++-- block/stream.c

[Qemu-devel] [PATCH 12/17] qemu-img: add a map subcommand

2013-07-03 Thread Paolo Bonzini
This command dumps the metadata of an entire chain, in either tabular or JSON format. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-img-cmds.hx | 6 ++ qemu-img.c | 186 +++ 2 files changed, 192 insertions(+) diff --git

[Qemu-devel] [PATCH 09/17] block: introduce bdrv_get_block_status API

2013-07-03 Thread Paolo Bonzini
For now, bdrv_get_block_status is just another name for bdrv_is_allocated. The next patches will add more flags. This also touches all block drivers with a mostly mechanical rename. The sole exception is cow; because it calls cow_co_is_allocated from the read code, we keep that function and make

[Qemu-devel] [PATCH 06/17] block: expect errors from bdrv_co_is_allocated

2013-07-03 Thread Paolo Bonzini
Some bdrv_is_allocated callers do not expect errors, but the fallback in qcow2.c might make other callers trip on assertion failures or infinite loops. Fix the callers to always look for errors. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/qcow2.c | 4

[Qemu-devel] [PATCH 14/17] raw-posix: return get_block_status data and flags

2013-07-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/raw-posix.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index dbc65b0..d011cfd 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -1089,7 +1089,7 @@

[Qemu-devel] [PATCH 17/17] block: look for zero blocks in bs-file

2013-07-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index ff8ced7..80f8dee 100644 --- a/block.c +++ b/block.c @@ -2963,7 +2963,7 @@ static int64_t coroutine_fn

[Qemu-devel] [PATCH 10/17] block: define get_block_status return value

2013-07-03 Thread Paolo Bonzini
Define the return value of get_block_status. Bits 0, 1, 2 and 8-62 are valid; bit 63 (the sign bit) is reserved for errors. Bits 3-7 are left for future extensions. The return code is compatible with the old is_allocated API: returning just 0 or 1 (aka BDRV_BLOCK_DATA) will not cause any

[Qemu-devel] [PATCH 13/17] block: use bdrv_has_zero_init to return BDRV_BLOCK_ZERO

2013-07-03 Thread Paolo Bonzini
Alternatively, this could use a discard zeroes data flag returned by bdrv_get_info. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 8931cac..cd371cd 100644 --- a/block.c +++ b/block.c

[Qemu-devel] [PATCH 15/17] raw-posix: detect XFS unwritten extents

2013-07-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/raw-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index d011cfd..1b41ea3 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -1128,6 +1128,9 @@ static int64_t coroutine_fn

[Qemu-devel] [PATCH 16/17] block: add default get_block_status implementation for protocols

2013-07-03 Thread Paolo Bonzini
Protocols return raw data, so you can assume the offsets to pass through unchanged. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index cd371cd..ff8ced7 100644 --- a/block.c +++ b/block.c @@

Re: [Qemu-devel] [PATCH] full introspection support for QMP

2013-07-03 Thread Paolo Bonzini
Il 03/07/2013 14:54, Anthony Liguori ha scritto: So, qapi-schema.json has to be readable/writable _mostly_ by humans. That it is valid JSON is little more than a curious accident, because I can assure you that it wasn't an accident. Sure, it is not. But when designing the right API for a

Re: [Qemu-devel] [PATCH 1/4] qemu-char: Fix ringbuf option size

2013-07-03 Thread Luiz Capitulino
On Thu, 27 Jun 2013 16:22:07 +0200 Markus Armbruster arm...@redhat.com wrote: Any attempt to use it trips an opt-desc-type == QEMU_OPT_NUMBER assertion. Broken in commit 1da48c65. Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster arm...@redhat.com Applied to the qmp branch,

[Qemu-devel] [Bug 1187529] [PATCH] Update mappings after PCI bridge live migration or save-restore.

2013-07-03 Thread Don Koch
From: Don Koch dk...@verizon.com Update mappings for PCI bridge after live migration. Signed-off-by: Don Koch dk...@verizon.com --- This fixes bug 1187529: devices on a PCI bridge stop working after migration. hw/pci-bridge/pci_bridge_dev.c | 9 + hw/pci/pci_bridge.c| 2 +-

Re: [Qemu-devel] [PATCH 0/4] qemu-char: ringbuf fixes

2013-07-03 Thread Luiz Capitulino
On Thu, 27 Jun 2013 16:22:06 +0200 Markus Armbruster arm...@redhat.com wrote: The first patch is a straightforward bug fix. The rest fix code to match documentation. The patches take pains to preserve command-line, HMP and QMP bug-compatibility. I'm not sure that's actually needed,

Re: [Qemu-devel] [PATCH] full introspection support for QMP

2013-07-03 Thread Kevin Wolf
Am 02.07.2013 um 19:06 hat Anthony Liguori geschrieben: Eric Blake ebl...@redhat.com writes: On 07/02/2013 08:51 AM, Anthony Liguori wrote: Amos Kong ak...@redhat.com writes: Introduces new monitor command to query QMP schema information, the return data is a nested dict/list, it

Re: [Qemu-devel] [PATCH 3/4] qemu-char: Register ring buffer driver with correct name ringbuf

2013-07-03 Thread Luiz Capitulino
On Thu, 27 Jun 2013 16:22:09 +0200 Markus Armbruster arm...@redhat.com wrote: The driver is new in 1.4, with the documented name ringbuf. However, it's actual name is the completely undocumented memory. Screwed up in commit 3949e59. Fix code to match documentation. Keep the undocumented

Re: [Qemu-devel] help me for nahanni device

2013-07-03 Thread Cam Macdonell
Hello, Can you please try with the most recent version? I would suggest building from the source code which can be found here: http://qemu-project.org/Main_Page Sincerely, Cam On Tue, Jul 2, 2013 at 7:50 PM, DAI Weibin weibin@alcatel-sbell.com.cnwrote: Hello Cam, I am honored

Re: [Qemu-devel] PVFS2 Block Driver Support

2013-07-03 Thread Timothy Scott
In testing my block driver implementation, I am receiving the following error when trying to run an orangefs protocol with a qcow2 image format: +Header extension too large +qemu-io: can't open device pvfs2:/... +no file open, try 'help open' Is './check -pvfs2 -qcow2' a valid usecase in

[Qemu-devel] [PATCH] monitor: Fix 'mouse_button': do not move mouse

2013-07-03 Thread Eugene Shatokhin
If absolute positions are used, 'mouse_button' command moved mouse pointer to (0, 0) before generating a mouse button event. The event was therefore generated at incorrect position. This problem is now fixed. Signed-off-by: Eugene Shatokhin eugene.shatok...@rosalab.ru --- monitor.c | 14

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

2013-07-03 Thread James Bulpin
On Tue, 2013-07-02 at 10:05, Paul Durrant wrote: -Original Message- From: Ian Campbell Sent: 02 July 2013 10:02 To: Paul Durrant Cc: Jan Beulich; qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device On Tue, 2013-07-02 at 08:57

[Qemu-devel] [PATCH v5 01/11] configure: Support configuring C++ compiler

2013-07-03 Thread Tomoki Sekiyama
Add configuration for C++ compiler in configure and Makefiles. The C++ compiler is choosed as following: - ${CXX}, if it is specified. - ${cross_prefix}g++, if ${cross_prefix} is specified. - Otherwise, c++ is used. Currently, usage of C++ language is only for access to Windows VSS using COM+

[Qemu-devel] [PATCH v5 05/11] qemu-ga: Add configure options to specify path to Windows/VSS SDK

2013-07-03 Thread Tomoki Sekiyama
To enable VSS support in qemu-ga for Windows, header files included in VSS SDK are required. The VSS support is enabled by the configure option like below: ./configure --with-vss-sdk=/path/to/VSS SDK If the path is omitted, it tries to search the headers from default paths and VSS support is

[Qemu-devel] [PATCH v5 04/11] Add a script to extract VSS SDK headers on POSIX system

2013-07-03 Thread Tomoki Sekiyama
VSS SDK(*) setup.exe is only runnable on Windows. This adds a script to extract VSS SDK headers on POSIX-systems using msitools. * http://www.microsoft.com/en-us/download/details.aspx?id=23490 From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com

[Qemu-devel] [PATCH v5 03/11] checkpatch.pl: Check .cpp files

2013-07-03 Thread Tomoki Sekiyama
Enable checkpatch.pl to apply the same checks as C source files for C++ files with .cpp extensions. It also adds some exceptions for C++ sources to suppress errors for: - used in C++ template arguments (e.g. template class T) - :: used to represent namespaces (e.g. SomeClass::method()) -

[Qemu-devel] [PATCH v5 06/11] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-07-03 Thread Tomoki Sekiyama
Implements a basic stub of software VSS provider. Currently, this module only provides a relay function of events between qemu-guest-agent and Windows VSS when VSS finished filesystem freeze and when qemu snapshot is done. In the future, this module could be extended to support the other VSS

[Qemu-devel] [PATCH v5 02/11] Add c++ keywords to QAPI helper script

2013-07-03 Thread Tomoki Sekiyama
Add c++ keywords to avoid errors in compiling with c++ compiler. This also renames class member of PciDeviceInfo to q_class. Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com Reviewed-by: Laszlo Ersek ler...@redhat.com --- hmp.c |2 +- hw/pci/pci.c|2 +-

[Qemu-devel] [PATCH v5 07/11] error: Add error_set_win32 and error_setg_win32

2013-07-03 Thread Tomoki Sekiyama
These functions help maintaining homogeneous formatting of error messages with Windows error code and description (generated by g_win32_error_message()). Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com --- include/qapi/error.h | 14 ++ util/error.c | 35

[Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install'

2013-07-03 Thread Tomoki Sekiyama
Register QGA VSS provider library into Windows when qemu-ga is installed as Windows service ('-s install' option). It is deregistered when the service is uninstalled ('-s uninstall' option). Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com --- qga/main.c | 10 +- 1 file changed,

[Qemu-devel] [PATCH v5 08/11] qemu-ga: Add Windows VSS requester to quiesce applications and filesystems

2013-07-03 Thread Tomoki Sekiyama
Add VSS requester functions to qemu-ga. This provides facility to request VSS service in Windows guest to quiesce applications and filesystems. These functions are only supported in Windows 2003 or later. In older guests, these functions do nothing. In several versions of Windows which don't

  1   2   >