Re: [Qemu-devel] [PATCH v2 03/30] net/pcnet-pci: QOM Upcast Sweep

2013-07-22 Thread Andreas Färber
Am 30.06.2013 09:34, schrieb Andreas Färber: Am 24.06.2013 08:52, schrieb peter.crosthwa...@xilinx.com: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct - style upcasting. Signed-off-by: Peter Crosthwaite

[Qemu-devel] [PATCH 4/9] PlatBus: Hook up into Makefile system

2013-07-22 Thread Alexander Graf
Hook up the platform bus helpers into our Makefile system, so that they get compiled. Signed-off-by: Alexander Graf ag...@suse.de --- hw/Makefile.objs | 1 + hw/platbus/Makefile.objs | 1 + 2 files changed, 2 insertions(+) create mode 100644 hw/platbus/Makefile.objs diff --git

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 22/07/2013 08:49, Orit Wasserman ha scritto: Older KVM versions save CS dpl value to an invalid value for real mode guests (0x3). This patch detect this situation when loading CPU state and set all the segments dpl to zero. This will allow

[Qemu-devel] [PATCH 2/9] PlatBus: Add abstract Platform Device

2013-07-22 Thread Alexander Graf
This patch adds an abstract platform device class. Real platform devices should use this as their parent class. It manages IO memory regions and IRQ ranges for the actual device. Signed-off-by: Alexander Graf ag...@suse.de --- hw/platbus/device.c | 162

[Qemu-devel] [PATCH 3/9] PlatBus: Add Sysbus/Platform bridge device

2013-07-22 Thread Alexander Graf
We have to be able to plug our platform bus into an existing system somehow. To achieve this, we add a sysbus - platbus bridge device that maps an arbitrary number of IRQ lines to a self-contained linear platform IRQ range. It also provides a memory region that is the parent region for all

[Qemu-devel] [PATCH 7/9] PPC: Add PlatBus Serial to default configs

2013-07-22 Thread Alexander Graf
We support the platform bus, so we also support platbus serial devices. Enable the respective config option. Signed-off-by: Alexander Graf ag...@suse.de --- default-configs/ppc-softmmu.mak| 1 + default-configs/ppc64-softmmu.mak | 1 + default-configs/ppcemb-softmmu.mak | 1 + 3 files

[Qemu-devel] [PATCH 0/9] Add platform bus

2013-07-22 Thread Alexander Graf
Platforms without ISA and/or PCI have had a seriously hard time in the dynamic device creation world of QEMU. Devices on these were modeled as SysBus devices which can only be instantiated in machine files, not through -device. Why is that so? Well, SysBus is trying to be incredibly generic. It

[Qemu-devel] [PATCH 8/9] PPC: E500: Spawn PlatBus bridge for ppce500 machine

2013-07-22 Thread Alexander Graf
With the PV ppce500 we don't have to adhere to real hardware constraints, but can instead layout the physical address space any way we like it. So we can also add our fancy new platform bus to it. Through this we add enablement to spawn platform devices with -M ppce500. Signed-off-by: Alexander

Re: [Qemu-devel] [PATCH 0/9] Add platform bus

2013-07-22 Thread Peter Maydell
On 22 July 2013 18:50, Alexander Graf ag...@suse.de wrote: Platforms without ISA and/or PCI have had a seriously hard time in the dynamic device creation world of QEMU. Devices on these were modeled as SysBus devices which can only be instantiated in machine files, not through -device. Why is

[Qemu-devel] [PATCH 5/9] PPC: Add platform bus to the default compile set

2013-07-22 Thread Alexander Graf
On e500 we will enable platform bus support, so make sure we always compile it in on PPC targets. Signed-off-by: Alexander Graf ag...@suse.de --- default-configs/ppc-softmmu.mak| 1 + default-configs/ppc64-softmmu.mak | 1 + default-configs/ppcemb-softmmu.mak | 1 + 3 files changed, 3

[Qemu-devel] [PATCH 1/9] PlatBus: Add Platform Bus

2013-07-22 Thread Alexander Graf
The platform bus is a very simple bus, similar to SysBus. However it has a linear IRQ range that platform devices can attach to. It also provdes mechanisms to dynamically place IO regions. This patch implements the bus logic itself. Signed-off-by: Alexander Graf ag...@suse.de ---

Re: [Qemu-devel] [PATCH 6/9] PlatBus: Add serial-platbus device

2013-07-22 Thread Peter Maydell
On 22 July 2013 18:50, Alexander Graf ag...@suse.de wrote: We want to be able to spawn a serial console on the platform bus. Create a small platbus wrapper device very similar to the ISA one. Why not use virtio-console? -- PMM

Re: [Qemu-devel] [PATCH qom-cpu] HACKING: Document vaddr type usage

2013-07-22 Thread Andreas Färber
Am 22.07.2013 19:27, schrieb Peter Maydell: On 22 July 2013 17:36, Andreas Färber afaer...@suse.de wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- HACKING | 1 + 1 file changed, 1 insertion(+) diff --git a/HACKING b/HACKING index e73ac79..d9dbb46 100644 --- a/HACKING +++

[Qemu-devel] [PATCH 6/9] PlatBus: Add serial-platbus device

2013-07-22 Thread Alexander Graf
We want to be able to spawn a serial console on the platform bus. Create a small platbus wrapper device very similar to the ISA one. Signed-off-by: Alexander Graf ag...@suse.de --- hw/char/Makefile.objs| 1 + hw/char/serial-platbus.c | 100

[Qemu-devel] [PATCHv3 1/2] seccomp: no need to check arch in syscall whitelist

2013-07-22 Thread Eduardo Otubo
v2 update: - set libseccomp 2.1.0 as requirement on configure script. Since libseccomp 2.0 there's no need to check the architecture type anymore. Signed-off-by: Eduardo Otubo ot...@linux.vnet.ibm.com --- configure | 2 +- qemu-seccomp.c | 13 - 2 files changed, 1

Re: [Qemu-devel] -cpu behavior (was: [PATCH v3 4/4] target-openrisc: Fix cpu_model by name)

2013-07-22 Thread Michael Mueller
We are currently working on a first prototype to support models for s390. The current model list we want to go with is here: [mimu@p57lp59 qemu]$ qemu-system-s390x -cpu help s390 z900 IBM zSeries 900 (Type 2064) s390 z800 IBM zSeries 800 (Type 2066) s390 z990 IBM zSeries 990

[Qemu-devel] [PATCHv3 0/2] seccomp: remove unused syscalls - for 1.6

2013-07-22 Thread Eduardo Otubo
In this small patch series I basically: v3 update: - reincluded getrlimit(), it's used by Xen. v2 update: - set libseccomp 2.1.0 as requirement on configure script. - reincluded setrlimit() (used by Xen) and removed sendfile64() from the whitelist. 1) Remove the ifdef's for the

[Qemu-devel] [PATCH 2/2] seccomp: removing unused syscalls gtom whitelist

2013-07-22 Thread Eduardo Otubo
v3 update: - reincluding getrlimit(), it is used by Xen. v2 update: - reincluding setrlimit(), it is used by Xen. Signed-off-by: Eduardo Otubo ot...@linux.vnet.ibm.com --- qemu-seccomp.c | 4 1 file changed, 4 deletions(-) diff --git a/qemu-seccomp.c b/qemu-seccomp.c index

[Qemu-devel] The difference between qemu-kvm-1.2.0 qemu-1.5.1

2013-07-22 Thread Yaodong Yang
Hi everyone, Previously, I used the qemu-kvm-1.2.0 from (http://www.linux-kvm.org/page/Downloads), and it worked well in my ubuntu server. Later, I found that some of the implementation(qemu-kvm-1.2.0) is out of date, so that I changed to qemu-1.5.1 (http://wiki.qemu.org/Download). I found

Re: [Qemu-devel] [PATCH V6 1/8] snapshot: new function bdrv_snapshot_find_by_id_and_name()

2013-07-22 Thread Eric Blake
On 07/20/2013 07:31 AM, Wenchao Xia wrote: To make it clear about id and name in searching, add this API to distinguish them. Caller can choose to search by id or name, *errp will be set only for exception. Some code are modified based on Pavel's patch. Signed-off-by: Wenchao Xia

Re: [Qemu-devel] [PATCH 0/9] Add platform bus

2013-07-22 Thread Alexander Graf
On 22.07.2013, at 20:21, Peter Maydell wrote: On 22 July 2013 18:50, Alexander Graf ag...@suse.de wrote: Platforms without ISA and/or PCI have had a seriously hard time in the dynamic device creation world of QEMU. Devices on these were modeled as SysBus devices which can only be

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Gleb Natapov
On Mon, Jul 22, 2013 at 12:50:23PM -0500, Anthony Liguori wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 22/07/2013 08:49, Orit Wasserman ha scritto: Older KVM versions save CS dpl value to an invalid value for real mode guests (0x3). This patch detect this situation when loading

Re: [Qemu-devel] [PATCH 6/9] PlatBus: Add serial-platbus device

2013-07-22 Thread Alexander Graf
On 22.07.2013, at 20:26, Peter Maydell wrote: On 22 July 2013 18:50, Alexander Graf ag...@suse.de wrote: We want to be able to spawn a serial console on the platform bus. Create a small platbus wrapper device very similar to the ISA one. Why not use virtio-console? Because eventually we

[Qemu-devel] [qom-cpu PATCH 0/2] i386: disable PMU passthrough mode by default

2013-07-22 Thread Eduardo Habkost
The series conflict with the current X86CPU static properties series from Igor, so it may need to be rebased in case Igor's patches get included first. Eduardo Habkost (2): i386: pass X86CPU object to cpu_x86_find_by_name() i386: disable PMU passthrough mode by default include/hw/i386/pc.h

[Qemu-devel] [qom-cpu PATCH 1/2] i386: pass X86CPU object to cpu_x86_find_by_name()

2013-07-22 Thread Eduardo Habkost
This will help us change the initialization code to not require carrying some intermediate values in a x86_def_t struct (and eventually kill the x86_def_t struct entirely). Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[Qemu-devel] [qom-cpu PATCH 2/2] i386: disable PMU passthrough mode by default

2013-07-22 Thread Eduardo Habkost
Bug description: QEMU currently gets all bits from GET_SUPPORTED_CPUID for CPUID leaf 0xA and passes them directly to the guest. This makes the guest ABI depend on host kernel and host CPU capabilities, and breaks live migration if we migrate between host with different capabilities (e.g.

Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

2013-07-22 Thread Michael S. Tsirkin
On Mon, Jul 22, 2013 at 07:42:43PM +0200, Andreas Färber wrote: Am 21.07.2013 22:26, schrieb Michael S. Tsirkin: On Sun, Jul 21, 2013 at 04:09:04PM +0200, Andreas Färber wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-bridge/ioh3420.c| 23

Re: [Qemu-devel] [PATCH 0/9] Add platform bus

2013-07-22 Thread Anthony Liguori
Alexander Graf ag...@suse.de writes: Platforms without ISA and/or PCI have had a seriously hard time in the dynamic device creation world of QEMU. Devices on these were modeled as SysBus devices which can only be instantiated in machine files, not through -device. Why is that so? Well,

Re: [Qemu-devel] [PATCH 0/9] Add platform bus

2013-07-22 Thread Alexander Graf
On 22.07.2013, at 21:38, Anthony Liguori wrote: Alexander Graf ag...@suse.de writes: Platforms without ISA and/or PCI have had a seriously hard time in the dynamic device creation world of QEMU. Devices on these were modeled as SysBus devices which can only be instantiated in machine

Re: [Qemu-devel] [PATCH 2/2] seccomp: removing unused syscalls gtom whitelist

2013-07-22 Thread Eduardo Otubo
Ended up my tests were inconclusive. So removing this one from this patch. Resubmited a v3 without it. Thanks for pointing that. On 07/16/2013 02:49 PM, Paolo Bonzini wrote: Il 16/07/2013 19:45, Eduardo Otubo ha scritto: -{ SCMP_SYS(ugetrlimit), 241 }, Xen uses getrlimit, not sure

Re: [Qemu-devel] [PATCH 0/9] Add platform bus

2013-07-22 Thread Anthony Liguori
Alexander Graf ag...@suse.de writes: On 22.07.2013, at 21:38, Anthony Liguori wrote: Alexander Graf ag...@suse.de writes: tl;dr, this is a PV bus for the e500 described as something more generic. I don't buy it. I don't think there are many platforms or devices out there where you can

Re: [Qemu-devel] [PATCH 8/9] linux-user: Default to 64k guest base

2013-07-22 Thread Riku Voipio
On 6 July 2013 15:17, Alexander Graf ag...@suse.de wrote: Most kernels these days have protection code in place to forbid user space to access low memory. The barrier varies between architectures though. For this purpose we have the guest base option that allows us to offset guest visible

Re: [Qemu-devel] [PATCH v7 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-07-22 Thread Tomoki Sekiyama
Hi Michael, CoCreateInstance(VSSCoordinator) failed. (Error: 80040154) Class not registered I have seen this error when I ran 32bit qemu-ga on 64bit Windows (2008 server R2). Just in case, could you confirm qemu-ga.exe and qga-vss.dll are built for the correct architecture? I have confirmed

Re: [Qemu-devel] [PATCH 00/28] Memory API for 1.6: fix I/O port endianness mess

2013-07-22 Thread Hervé Poussineau
Paolo Bonzini a écrit : Il 22/07/2013 17:04, Peter Maydell ha scritto: On 22 July 2013 15:36, Paolo Bonzini pbonz...@redhat.com wrote: Il 22/07/2013 16:32, Peter Maydell ha scritto: In the long term it would be good to identify which boards were using isa_mmio purely for the benefit of

Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

2013-07-22 Thread Anthony Liguori
Michael S. Tsirkin m...@redhat.com writes: On Sun, Jul 21, 2013 at 04:09:04PM +0200, Andreas Färber wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-bridge/ioh3420.c| 23 ++- hw/pci-bridge/xio3130_downstream.c | 23 ++-

Re: [Qemu-devel] [PATCH v7 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-07-22 Thread Michael Roth
Quoting Tomoki Sekiyama (2013-07-22 15:02:23) Hi Michael, CoCreateInstance(VSSCoordinator) failed. (Error: 80040154) Class not registered I have seen this error when I ran 32bit qemu-ga on 64bit Windows (2008 server R2). Just in case, could you confirm qemu-ga.exe and qga-vss.dll are

Re: [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor

2013-07-22 Thread Bruce Rogers
On 6/3/2013 at 03:14 PM, Anthony Liguori aligu...@us.ibm.com wrote: It's not a GObject. Cc: Gerd Hoffman kra...@redhat.com Reported-by: Michael Tokarev m...@tls.msk.ru Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- v1 - v2 - Fix summary to agree with code (Peter) ---

Re: [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor

2013-07-22 Thread Bruce Rogers
On 6/3/2013 at 03:14 PM, Anthony Liguori aligu...@us.ibm.com wrote: It's not a GObject. Cc: Gerd Hoffman kra...@redhat.com Reported-by: Michael Tokarev m...@tls.msk.ru Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- v1 - v2 - Fix summary to agree with code (Peter) ---

Re: [Qemu-devel] [PATCH v7 01/10] configure: Support configuring C++ compiler

2013-07-22 Thread Michael Roth
Quoting Tomoki Sekiyama (2013-07-15 11:20:29) Add configuration for C++ compiler in configure and Makefiles. The C++ compiler is choosed as following: - ${CXX}, if it is specified. - ${cross_prefix}g++, if ${cross_prefix} is specified. - Otherwise, c++ is used. Currently, usage of C++

Re: [Qemu-devel] [PATCH] gtk: Fix compiler warning (GTK 3 deprecated function)

2013-07-22 Thread Bruce Rogers
On 6/16/2013 at 08:13 AM, Stefan Weil s...@weilnetz.de wrote: With GTK 3, the function gdk_cursor_unref is deprecated: qemu/ui/gtk.c: In function *gd_cursor_define*: qemu/ui/gtk.c:380:5: error: *gdk_cursor_unref* is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkcursor.h:233): Use

Re: [Qemu-devel] [PATCH v7 02/10] Add c++ keywords to QAPI helper script

2013-07-22 Thread Michael Roth
Quoting Tomoki Sekiyama (2013-07-15 11:20:33) Add c++ keywords to avoid errors in compiling with c++ compiler. This also renames class member of PciDeviceInfo to q_class. Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com Reviewed-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Michael

[Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp

2013-07-22 Thread Seiji Aguchi
Convert stderr messages calling error_get_pretty() to error_report(). Timestamp is prepended by -msg timstamp option with it. This is suggested by Luiz Capitulino. http://marc.info/?l=qemu-develm=137331442628866w=2 Signed-off-by: Seiji Aguchi seiji.agu...@hds.com --- arch_init.c

Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

2013-07-22 Thread Andreas Färber
Am 22.07.2013 22:29, schrieb Anthony Liguori: Michael S. Tsirkin m...@redhat.com writes: On Sun, Jul 21, 2013 at 04:09:04PM +0200, Andreas Färber wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-bridge/ioh3420.c| 23 ++-

[Qemu-devel] [PATCH 0/8] OptsVisitor: support / flatten integer ranges for repeating options

2013-07-22 Thread Laszlo Ersek
rfc-v1: - addressed Paolo's comments for patches 1 and 2, - patches 7 and 8 are new (unit tests), - updated the cover letter to take native lists into account, plus cleaned it up. Consider the following QAPI schema fragment, for the purpose of command line parsing with OptsVisitor: {

Re: [Qemu-devel] [PATCH v7 03/10] checkpatch.pl: Check .cpp files

2013-07-22 Thread Michael Roth
Quoting Tomoki Sekiyama (2013-07-15 11:20:37) Enable checkpatch.pl to apply the same checks as C source files for C++ files with .cpp extensions. It also adds some exceptions for C++ sources to suppress errors for: - used in C++ template arguments (e.g. template class T) - :: used to

Re: [Qemu-devel] [PATCH 00/28] Memory API for 1.6: fix I/O port endianness mess

2013-07-22 Thread Alexander Graf
On 22.07.2013, at 22:16, Hervé Poussineau wrote: Paolo Bonzini a écrit : Il 22/07/2013 17:04, Peter Maydell ha scritto: On 22 July 2013 15:36, Paolo Bonzini pbonz...@redhat.com wrote: Il 22/07/2013 16:32, Peter Maydell ha scritto: In the long term it would be good to identify which boards

[Qemu-devel] [PATCH 3/8] OptsVisitor: opts_type_int(): recognize intervals when LM_IN_PROGRESS

2013-07-22 Thread Laszlo Ersek
When a well-formed range value, bounded by signed integers, is encountered while processing a repeated option, enter LM_SIGNED_INTERVAL and return the low bound. Signed-off-by: Laszlo Ersek ler...@redhat.com --- qapi/opts-visitor.c | 34 -- 1 files changed, 28

Re: [Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp

2013-07-22 Thread Andreas Färber
Am 22.07.2013 23:03, schrieb Seiji Aguchi: Convert stderr messages calling error_get_pretty() to error_report(). Timestamp is prepended by -msg timstamp option with it. This is suggested by Luiz Capitulino. http://marc.info/?l=qemu-develm=137331442628866w=2 Signed-off-by: Seiji

[Qemu-devel] [PATCH 1/8] OptsVisitor: introduce basic list modes

2013-07-22 Thread Laszlo Ersek
We're going to need more state while processing a list of repeated options. This change eliminates repeated_opts_first and adds a new state variable: list_mode repeated_opts repeated_opts_first -- - --- LM_NONE NULL false

Re: [Qemu-devel] [PATCH 00/28] Memory API for 1.6: fix I/O port endianness mess

2013-07-22 Thread Andreas Färber
Am 22.07.2013 22:16, schrieb Hervé Poussineau: BTW, I've a patch to really cleanup i82378 implementation (47 insertions, 175 deletions). Should I send it now, during 1.6 soft freeze? Yes please, since it's a PReP-only device and relevant to the general discussion. Andreas -- SUSE LINUX

Re: [Qemu-devel] [PATCH v7 04/10] Add a script to extract VSS SDK headers on POSIX system

2013-07-22 Thread Michael Roth
Quoting Tomoki Sekiyama (2013-07-15 11:20:41) VSS SDK(*) setup.exe is only runnable on Windows. This adds a script to extract VSS SDK headers on POSIX-systems using msitools. * http://www.microsoft.com/en-us/download/details.aspx?id=23490 From: Paolo Bonzini pbonz...@redhat.com

Re: [Qemu-devel] [PATCH v7 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-07-22 Thread Tomoki Sekiyama
Hi Michael, Thank you for testing. So I think that solves the 'hang'/CoCreateInstance issue, although it would be nice if 32-bit could run on 64-bit, since that's supported currently. Is this a known issue/limitation? If so, perhaps we can avoid registering the VSS provider if the arch

[Qemu-devel] [PATCH 6/8] OptsVisitor: don't try to flatten overlong integer ranges

2013-07-22 Thread Laszlo Ersek
Prevent mistyped command line options from incurring high memory and CPU usage at startup. 64K elements in a range should be enough for everyone (TM). The OPTS_VISITOR_RANGE_MAX macro is public so that unit tests can construct corner cases with it. Signed-off-by: Laszlo Ersek ler...@redhat.com

[Qemu-devel] [PATCH 5/8] OptsVisitor: opts_type_uint64(): recognize intervals when LM_IN_PROGRESS

2013-07-22 Thread Laszlo Ersek
When a well-formed range value, bounded by unsigned integers, is encountered while processing a repeated option, enter LM_UNSIGNED_INTERVAL and return the low bound. Signed-off-by: Laszlo Ersek ler...@redhat.com --- qapi/opts-visitor.c | 32 +++- 1 files changed, 27

Re: [Qemu-devel] [PATCH v7 05/10] qemu-ga: Add configure options to specify path to Windows/VSS SDK

2013-07-22 Thread Michael Roth
Quoting Tomoki Sekiyama (2013-07-15 11:20:45) To enable VSS support in qemu-ga for Windows, header files included in VSS SDK are required. The VSS support is enabled by the configure option like below: ./configure --with-vss-sdk=/path/to/VSS SDK If the path is omitted, it tries to search

[Qemu-devel] [PATCH 4/8] OptsVisitor: rebase opts_type_uint64() to parse_uint_full()

2013-07-22 Thread Laszlo Ersek
Simplify the code in preparation for the next patch. Signed-off-by: Laszlo Ersek ler...@redhat.com --- qapi/opts-visitor.c | 23 +-- 1 files changed, 5 insertions(+), 18 deletions(-) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index 90be583..d8f9a0e 100644 ---

[Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-07-22 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek ler...@redhat.com --- tests/Makefile|6 +- qapi-schema-test.json | 15 +++ tests/test-opts-visitor.c | 275 + .gitignore|1 + 4 files changed, 296 insertions(+), 1 deletions(-)

Re: [Qemu-devel] [PATCH 0/9] Add platform bus

2013-07-22 Thread Peter Maydell
On 22 July 2013 20:52, Anthony Liguori anth...@codemonkey.ws wrote: Alexander Graf ag...@suse.de writes: On 22.07.2013, at 21:38, Anthony Liguori wrote: This could be used just the same for ARM's mach-virt, so I'd rather not make it e500 specific. If someone designed a virt machine and

Re: [Qemu-devel] [PATCH v7 06/10] error: Add error_set_win32 and error_setg_win32

2013-07-22 Thread Michael Roth
Quoting Tomoki Sekiyama (2013-07-15 11:20:49) These functions help maintaining homogeneous formatting of error messages with Windows error code and description (generated by g_win32_error_message()). Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com Reviewed-by: Michael Roth

[Qemu-devel] [PATCH 7/8] add test-int128 to .gitignore

2013-07-22 Thread Laszlo Ersek
Probably missed in commit 6046c620 (int128: optimize and add test cases). Signed-off-by: Laszlo Ersek ler...@redhat.com --- .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 0fe114d..388cb45 100644 --- a/.gitignore +++ b/.gitignore

Re: [Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-07-22 Thread Eric Blake
On 07/22/2013 03:07 PM, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com --- tests/Makefile|6 +- qapi-schema-test.json | 15 +++ tests/test-opts-visitor.c | 275 + .gitignore|1 + 4

Re: [Qemu-devel] [PATCH 0/9] Add platform bus

2013-07-22 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes: On 22 July 2013 20:52, Anthony Liguori anth...@codemonkey.ws wrote: Alexander Graf ag...@suse.de writes: On 22.07.2013, at 21:38, Anthony Liguori wrote: This could be used just the same for ARM's mach-virt, so I'd rather not make it e500

Re: [Qemu-devel] [PATCH RFC qom-next 0/4] QOM'ification of pci-bridge types

2013-07-22 Thread Andreas Färber
Am 22.07.2013 19:22, schrieb Andreas Färber: Am 21.07.2013 22:26, schrieb Michael S. Tsirkin: On Sun, Jul 21, 2013 at 04:09:00PM +0200, Andreas Färber wrote: Hello Michael et al., This series turns PCIBridge, PCIEPort and PCIESlot into abstract QOM types, so that we can use QOM casts to

[Qemu-devel] [PATCH 2/8] OptsVisitor: introduce list modes for interval flattening

2013-07-22 Thread Laszlo Ersek
The new modes are equal-rank, exclusive alternatives of LM_IN_PROGRESS. Teach opts_next_list(), opts_type_int() and opts_type_uint64() to handle them. Also enumerate explicitly what functions are valid to call in what modes: - opts_next_list() is valid to call while flattening a range, -

[Qemu-devel] [PATCH V6 0/3] Implement sync modes for drive-backup.

2013-07-22 Thread Ian Main
This patch adds sync modes on top of the work that Stefan Hajnoczi has done. These patches apply on kevin/block. Hopefully all is in order as this is my first QEMU patch. Many thanks to Stephan and Fam Zheng for their help. V2: - No longer poll, instead use qemu_coroutine_yield(). - Use

[Qemu-devel] [PATCH V6 3/3] Add backing drive while performing backup.

2013-07-22 Thread Ian Main
This patch adds the original source drive as a backing drive to our target image so that the target image will appear complete during backup. This is especially useful for SYNC_MODE_NONE as it allows export via NBD to have a complete point-in-time snapshot available for export. Signed-off-by:

[Qemu-devel] [PATCH V6 2/3] Add tests for sync modes 'TOP' and 'NONE'

2013-07-22 Thread Ian Main
This patch adds tests for sync modes top and none. Also added are tests for invalid and missing formats. Signed-off-by: Ian Main im...@redhat.com --- tests/qemu-iotests/055| 108 +- tests/qemu-iotests/055.out| 4 +- tests/qemu-iotests/group

[Qemu-devel] [PATCH V6 1/3] Implement sync modes for drive-backup.

2013-07-22 Thread Ian Main
This patch adds sync-modes to the drive-backup interface and implements the FULL, NONE and TOP modes of synchronization. FULL performs as before copying the entire contents of the drive while preserving the point-in-time using CoW. NONE only copies new writes to the target drive. TOP copies

Re: [Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-07-22 Thread Eric Blake
On 07/22/2013 04:24 PM, Laszlo Ersek wrote: Pretty thorough, although I thought of a couple other ideas to test: i64=5z-6 should fail; i64=5-6-7 should fail I can add them if you insist, but I wrote (and single-stepped all of) the test cases so that all branches added by patches 3, 5 and 6

Re: [Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-07-22 Thread Laszlo Ersek
On 07/23/13 00:04, Eric Blake wrote: On 07/22/2013 03:07 PM, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com --- tests/Makefile|6 +- qapi-schema-test.json | 15 +++ tests/test-opts-visitor.c | 275 +

Re: [Qemu-devel] [PATCH 0/9] Add platform bus

2013-07-22 Thread Peter Maydell
On 22 July 2013 23:05, Anthony Liguori anth...@codemonkey.ws wrote: Peter Maydell peter.mayd...@linaro.org writes: We don't currently have any PCI host controller which is: (a) for ARM In QEMU? You can make one super easily by just extending PCIHostState. It's just a matter of mapping the

Re: [Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-07-22 Thread Laszlo Ersek
On 07/23/13 00:26, Eric Blake wrote: On 07/22/2013 04:24 PM, Laszlo Ersek wrote: Pretty thorough, although I thought of a couple other ideas to test: i64=5z-6 should fail; i64=5-6-7 should fail I can add them if you insist, but I wrote (and single-stepped all of) the test cases so that all

[Qemu-devel] [PATCH qom-next v2 2/4] pci-bridge-dev: QOM parent field cleanup

2013-07-22 Thread Andreas Färber
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-bridge/pci_bridge_dev.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/pci-bridge/pci_bridge_dev.c

[Qemu-devel] [PATCH qom-next v2 1/4] pci-bridge: Turn PCIBridge into abstract QOM type

2013-07-22 Thread Andreas Färber
Introduce TYPE_PCI_BRIDGE as base type and use PCI_BRIDGE() casts. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-bridge/dec.c| 4 ++-- hw/pci-bridge/i82801b11.c | 6 +++--- hw/pci-bridge/ioh3420.c| 18 -

[Qemu-devel] [PATCH qom-next v2 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

2013-07-22 Thread Andreas Färber
Move PCIEPort's port property to the new type, same for aer_log_max. Move PCIESlot's chassis and slot properties to the new type. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-bridge/ioh3420.c| 31 ++- hw/pci-bridge/xio3130_downstream.c | 31

[Qemu-devel] [PATCH qom-next v2 3/4] pci-bridge/i82801b11: Rename parent field

2013-07-22 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-bridge/i82801b11.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/pci-bridge/i82801b11.c b/hw/pci-bridge/i82801b11.c index 88f489a..90fc91d 100644 --- a/hw/pci-bridge/i82801b11.c +++ b/hw/pci-bridge/i82801b11.c

[Qemu-devel] [PATCH qom-next v2 0/4] QOM'ification of pci-bridge types

2013-07-22 Thread Andreas Färber
Hello Michael et al., This series turns PCIBridge, PCIEPort and PCIESlot into abstract QOM types, so that we can use QOM casts to obtain a pointer. The PCIBridge part was prompted by Don Koch's PCI bridge patch; the remainder by Peter C.'s PCIDevice cast cleanups. This prepares for turning the

Re: [Qemu-devel] [PATCH 0/9] Add platform bus

2013-07-22 Thread Andreas Färber
Am 23.07.2013 00:34, schrieb Peter Maydell: On 22 July 2013 23:05, Anthony Liguori anth...@codemonkey.ws wrote: Peter Maydell peter.mayd...@linaro.org writes: We don't currently have any PCI host controller which is: (a) for ARM In QEMU? You can make one super easily by just extending

Re: [Qemu-devel] [PATCH] linux-user: Use X86CPU property to retrieve CPUID family

2013-07-22 Thread Andreas Färber
Am 11.07.2013 07:35, schrieb Igor Mammedov: On Wed, 10 Jul 2013 18:26:17 +0200 Andreas Färber afaer...@suse.de wrote: Avoids duplicating the calculation. Signed-off-by: Andreas Färber afaer...@suse.de --- Have this lying around for a while already, apparently not sent out yet.

[Qemu-devel] [PULL 09/55] scsi/lsi53c895a: QOM Upcast Sweep

2013-07-22 Thread Andreas Färber
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/scsi/lsi53c895a.c | 26

[Qemu-devel] [PULL 01/55] hw: Avoid use of QOM type name macros in VMStateDescriptions

2013-07-22 Thread Andreas Färber
From: Peter Maydell peter.mayd...@linaro.org The name field in a VMStateDescription is part of the migration state versioning, so changing it will break migration. It's therefore a bad idea to use a QOM typename macro to initialize it, because in general we're free to rename QOM types as part of

[Qemu-devel] [PULL 07/55] usb/hcd-xhci: QOM Upcast Sweep

2013-07-22 Thread Andreas Färber
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com [AF: Dropped usb_xhci_init() DeviceState argument and renamed variable]

[Qemu-devel] [PULL 11/55] scsi/megasas: QOM Upcast Sweep

2013-07-22 Thread Andreas Färber
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/scsi/megasas.c | 15

[Qemu-devel] [PULL 13/55] scsi/esp-pci: QOM Upcast Sweep

2013-07-22 Thread Andreas Färber
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/scsi/esp-pci.c | 14

[Qemu-devel] [PULL 02/55] net/e1000: QOM Upcast Sweep

2013-07-22 Thread Andreas Färber
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/net/e1000.c | 18

[Qemu-devel] [PULL 03/55] net/e1000: QOM parent field cleanup

2013-07-22 Thread Andreas Färber
Replace direct uses of E1000State::dev field with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/net/e1000.c | 35 ++- 1 file changed, 22 insertions(+), 13

[Qemu-devel] [PULL 26/55] xen/xen_platform: QOM parent field cleanup

2013-07-22 Thread Andreas Färber
Replace direct uses of PCIXenPlatformState::pci_dev field with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/xen/xen_platform.c | 21 + 1 file changed, 13 insertions(+), 8

[Qemu-devel] [PULL 12/55] scsi/megasas: QOM parent field cleanup

2013-07-22 Thread Andreas Färber
Replace direct uses of MegasasState::dev with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/scsi/megasas.c | 46 ++ 1 file changed, 26

[Qemu-devel] [PULL 21/55] display/vmware_vga: QOM casting sweep

2013-07-22 Thread Andreas Färber
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style casting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com [AF: Renamed to TYPE_VMWARE_VGA and VMWARE_VGA()] Signed-off-by: Andreas Färber

[Qemu-devel] [PULL 30/55] i440fx: Use type-safe cast instead of direct access of parent dev

2013-07-22 Thread Andreas Färber
From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Converted remaining accesses and renamed to parent_obj] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-host/piix.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff

[Qemu-devel] [PULL 19/55] misc/pci-testdev: QOM Upcast Sweep

2013-07-22 Thread Andreas Färber
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com [AF: Replaced another DO_UPCAST()] Signed-off-by: Andreas Färber afaer...@suse.de

[Qemu-devel] [PULL 18/55] acpi/piix4: QOM parent field cleanup

2013-07-22 Thread Andreas Färber
Replace direct uses of PIIX4PMState::dev with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/acpi/piix4.c | 32 1 file changed, 20 insertions(+), 12

[Qemu-devel] [PULL 23/55] misc/ivshmem: QOM Upcast Sweep

2013-07-22 Thread Andreas Färber
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com [AF: Simplified casts and converted two more DO_UPCAST()s] Signed-off-by: Andreas

[Qemu-devel] [PULL 25/55] xen/xen_platform: QOM casting sweep

2013-07-22 Thread Andreas Färber
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com [AF: Dropped opaque casts] Signed-off-by: Andreas Färber afaer...@suse.de ---

[Qemu-devel] [PULL 17/55] acpi/piix4: QOM Upcast Sweep

2013-07-22 Thread Andreas Färber
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/acpi/piix4.c | 31

[Qemu-devel] [PULL 36/55] pflash-cfi02: QOM'ify some more

2013-07-22 Thread Andreas Färber
From: Hu Tao hu...@cn.fujitsu.com Introduce type constant and replace FROM_SYSBUS(). Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Renamed parent field] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/block/pflash_cfi02.c | 21 - 1 file changed, 12 insertions(+), 9

[Qemu-devel] [PULL 22/55] display/vmware_vga: QOM parent field cleanup

2013-07-22 Thread Andreas Färber
Replace direct uses of pci_vmsvga_state_s::card with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/display/vmware_vga.c | 23 +-- 1 file changed, 13 insertions(+), 10

[Qemu-devel] [PULL 47/55] fw_cfg: Use QOM realize for fw_cfg

2013-07-22 Thread Andreas Färber
From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Moved sysbus_init_mmio() to instance_init, renamed variable] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/nvram/fw_cfg.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-)

[Qemu-devel] [PULL 27/55] sysbus: Document SysBusDeviceClass::init and realize semantics

2013-07-22 Thread Andreas Färber
From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Syntax and wording changes] Signed-off-by: Andreas Färber afaer...@suse.de --- include/hw/sysbus.h | 12 1 file changed, 12 insertions(+) diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h index

[Qemu-devel] [PULL 37/55] ahci: QOM'ify some more

2013-07-22 Thread Andreas Färber
From: Hu Tao hu...@cn.fujitsu.com Introduce type constant and avoid DO_UPCAST(). Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Renamed parent field] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/ide/ahci.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff

  1   2   3   4   >