Re: [Qemu-devel] [PATCH qom-cpu for-1.6] cpu: Partially revert cpu: Change qemu_init_vcpu() argument to CPUState

2013-07-28 Thread Igor Mammedov
On Sat, 27 Jul 2013 04:01:50 +0200 Andreas Färber afaer...@suse.de wrote: Commit c643bed99 moved qemu_init_vcpu() calls to common CPUState code. This causes x86 cpu-add to fail with KVM: setting VAPIC address failed. The reason for the failure is that CPUClass::kvm_fd is not yet initialized

Re: [Qemu-devel] [PATCH] musicpal: Fix typo in name of local function

2013-07-28 Thread Jan Kiszka
On 2013-07-28 07:54, Stefan Weil wrote: The misspelling was spotted by Andreas Färber. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/arm/musicpal.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index

Re: [Qemu-devel] [PATCH 1/2] hw/virtio/virtio: Don't allow guests to add/remove queues

2013-07-28 Thread Michael S. Tsirkin
On Fri, Jul 26, 2013 at 09:05:33AM +0100, Peter Maydell wrote: On 26 July 2013 00:27, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jul 25, 2013 at 11:37:22PM +0100, Peter Maydell wrote: On 25 July 2013 23:33, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jul 25, 2013 at 02:37:42PM

Re: [Qemu-devel] [PATCH v3 14/14] i386: ACPI table generation code from seabios

2013-07-28 Thread Michael S. Tsirkin
On Fri, Jul 26, 2013 at 05:30:29PM +0200, Gerd Hoffmann wrote: Hi, That's something I think that it's best for firmware to avoid. Much better to load tables in memory and use standard ACPI methods to find specific tables. Problem is this happens relatively late in the firmware boot

[Qemu-devel] [PATCH 1/6] pc: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/ioapic.h

2013-07-28 Thread Igor Mammedov
From: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/i386/pc.c | 2 -- include/hw/i386/ioapic.h | 1 + 2 files changed, 1 insertion(+), 2

[Qemu-devel] [PATCH 2/6] pc: add I440FX QOM cast macro

2013-07-28 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/pci-host/piix.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 3908860..bf879e7 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -38,6 +38,10 @@ *

[Qemu-devel] [PATCH 0/6 v2 for-1.6] pc: limit 64 bit hole to 2G by default

2013-07-28 Thread Igor Mammedov
It turns out that some 32 bit windows guests crash if 64 bit PCI hole size is 2G. Limit it to 2G for piix and q35 by default. v1-v2: * redone using QOM properties to pass value around git-tree for testing: https://github.com/imammedo/qemu/commits/pcihole64_fix_v2 Igor Mammedov (5): pc: add

[Qemu-devel] [PATCH 5/6] pc: add Q35 to QOM composition tree under /machine

2013-07-28 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/i386/pc_q35.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 0b1d2e3..5140caf 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -130,7 +130,7 @@ static void

[Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default

2013-07-28 Thread Igor Mammedov
It turns out that some 32 bit windows guests crash if 64 bit PCI hole size is 2G. Limit it to 2G for piix and q35 by default. User may override default boundaries by using pci_hole64_end property. Examples: -global i440FX-pcihost.pci_hole64_end=0x -global

Re: [Qemu-devel] [PATCH v3 11/14] piix: APIs for pc guest info

2013-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 02:12:49AM +0200, Andreas Färber wrote: Am 25.07.2013 11:32, schrieb Michael S. Tsirkin: This adds APIs that will be used to fill in guest info table, implemented using QOM, to various piix components. Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PATCH 3/6] utils: add range_size() wrapper

2013-07-28 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- include/qemu/range.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/qemu/range.h b/include/qemu/range.h index b76cc0d..19b742c 100644 --- a/include/qemu/range.h +++ b/include/qemu/range.h @@ -42,4 +42,10 @@ static inline int

[Qemu-devel] [PATCH 4/6] pc: replace i440fx_common_init() with i440fx_init() as it isn't used by anywhere else

2013-07-28 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/pci-host/piix.c | 50 +- 1 file changed, 13 insertions(+), 37 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index bf879e7..4624d04 100644 --- a/hw/pci-host/piix.c +++

Re: [Qemu-devel] [PATCH v3 10/14] ich9: APIs for pc guest info

2013-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 02:37:59AM +0200, Andreas Färber wrote: Am 24.07.2013 18:02, schrieb Michael S. Tsirkin: This adds APIs that will be used to fill in guest info table, implemented using QOM, to various ich9 components. Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

Re: [Qemu-devel] [PATCH v3 09/14] i386: define pc guest info

2013-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 02:41:51AM +0200, Andreas Färber wrote: Am 24.07.2013 18:02, schrieb Michael S. Tsirkin: This defines a structure that will be used to fill in guest info table. This structure will be filled in in follow-up patches, using QOM. Fill in NUMA node info is not available

Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default

2013-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 09:29:13AM +0200, Igor Mammedov wrote: It turns out that some 32 bit windows guests crash if 64 bit PCI hole size is 2G. Limit it to 2G for piix and q35 by default. User may override default boundaries by using pci_hole64_end property. Examples: -global

Re: [Qemu-devel] [PATCH v3 06/14] i386: add bios linker/loader

2013-07-28 Thread Michael S. Tsirkin
On Fri, Jul 26, 2013 at 11:42:45AM +0200, Gerd Hoffmann wrote: Hi, Hacked up coreboot support to verify the interface. +/* + * COMMAND_ALLOCATE - allocate a table from @alloc_file + * subject to @alloc_align alignment (must be power of 2) + * and

Re: [Qemu-devel] vhost acceleration broken?

2013-07-28 Thread Michael S. Tsirkin
On Fri, Jul 26, 2013 at 10:43:44AM +0100, Peter Maydell wrote: On 26 July 2013 10:25, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jul 25, 2013 at 05:53:06PM +0300, Michael S. Tsirkin wrote: On Thu, Jul 25, 2013 at 03:12:31PM +0100, Peter Maydell wrote: On 25 July 2013 03:08, Anthony

Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default

2013-07-28 Thread Igor Mammedov
On Sun, 28 Jul 2013 10:57:12 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Jul 28, 2013 at 09:29:13AM +0200, Igor Mammedov wrote: It turns out that some 32 bit windows guests crash if 64 bit PCI hole size is 2G. Limit it to 2G for piix and q35 by default. User may override

Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default

2013-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 10:21:56AM +0200, Igor Mammedov wrote: On Sun, 28 Jul 2013 10:57:12 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Jul 28, 2013 at 09:29:13AM +0200, Igor Mammedov wrote: It turns out that some 32 bit windows guests crash if 64 bit PCI hole size is 2G.

Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default

2013-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 10:21:56AM +0200, Igor Mammedov wrote: On Sun, 28 Jul 2013 10:57:12 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Jul 28, 2013 at 09:29:13AM +0200, Igor Mammedov wrote: It turns out that some 32 bit windows guests crash if 64 bit PCI hole size is 2G.

[Qemu-devel] [PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-28 Thread Marcel Apfelbaum
Categorize devices that appear as output to -device ? command by logical functionality. Sort the devices by logical categories before showing them to user. The sort is done by functionality rather than alphabetical. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- Changes from RFC Made

[Qemu-devel] [PATCH 0/2] qemu-help: improve -device command line help

2013-07-28 Thread Marcel Apfelbaum
Running qemu with -device ? option returns ~145 lines. It is hard to manage understanding the output. Theses patches aim to partially solve the problem by dividing the devices into logical categories like Network/Display/... and sorting them by it. Categories: Assembly - hosts/hubs/...

Re: [Qemu-devel] [PATCH v3 11/14] piix: APIs for pc guest info

2013-07-28 Thread Andreas Färber
Am 28.07.2013 09:30, schrieb Michael S. Tsirkin: On Sun, Jul 28, 2013 at 02:12:49AM +0200, Andreas Färber wrote: Am 25.07.2013 11:32, schrieb Michael S. Tsirkin: This adds APIs that will be used to fill in guest info table, implemented using QOM, to various piix components. Signed-off-by:

Re: [Qemu-devel] [PATCH] musicpal: Fix typo in name of local function

2013-07-28 Thread Andreas Färber
Am 28.07.2013 07:54, schrieb Stefan Weil: The misspelling was spotted by Andreas Färber. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/arm/musicpal.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index

Re: [Qemu-devel] [PATCH 1/6] pc: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/ioapic.h

2013-07-28 Thread Andreas Färber
Am 28.07.2013 09:29, schrieb Igor Mammedov: From: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Laszlo Ersek ler...@redhat.com Missing Reviewed-bys from Gerd and me. Andreas Signed-off-by: Igor Mammedov imamm...@redhat.com ---

Re: [Qemu-devel] [PATCH 2/6] pc: add I440FX QOM cast macro

2013-07-28 Thread Andreas Färber
Am 28.07.2013 09:29, schrieb Igor Mammedov: Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/pci-host/piix.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 3908860..bf879e7 100644 --- a/hw/pci-host/piix.c

Re: [Qemu-devel] [PATCH 4/6] pc: replace i440fx_common_init() with i440fx_init() as it isn't used by anywhere else

2013-07-28 Thread Andreas Färber
Am 28.07.2013 09:29, schrieb Igor Mammedov: Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/pci-host/piix.c | 50 +- 1 file changed, 13 insertions(+), 37 deletions(-) Subject should probably be rebroken to have It isn't ... in the body.

Re: [Qemu-devel] [PATCH 5/6] pc: add Q35 to QOM composition tree under /machine

2013-07-28 Thread Andreas Färber
Am 28.07.2013 09:29, schrieb Igor Mammedov: Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/i386/pc_q35.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 0b1d2e3..5140caf 100644 --- a/hw/i386/pc_q35.c +++

Re: [Qemu-devel] [PATCH v3 11/14] piix: APIs for pc guest info

2013-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 11:38:17AM +0200, Andreas Färber wrote: Am 28.07.2013 09:30, schrieb Michael S. Tsirkin: On Sun, Jul 28, 2013 at 02:12:49AM +0200, Andreas Färber wrote: Am 25.07.2013 11:32, schrieb Michael S. Tsirkin: This adds APIs that will be used to fill in guest info table,

Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default

2013-07-28 Thread Andreas Färber
Am 28.07.2013 11:11, schrieb Michael S. Tsirkin: On Sun, Jul 28, 2013 at 10:21:56AM +0200, Igor Mammedov wrote: On Sun, 28 Jul 2013 10:57:12 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Jul 28, 2013 at 09:29:13AM +0200, Igor Mammedov wrote: info = g_malloc(sizeof *info);

Re: [Qemu-devel] [PATCH v3 11/14] piix: APIs for pc guest info

2013-07-28 Thread Andreas Färber
Am 28.07.2013 12:14, schrieb Michael S. Tsirkin: On Sun, Jul 28, 2013 at 11:38:17AM +0200, Andreas Färber wrote: Am 28.07.2013 09:30, schrieb Michael S. Tsirkin: On Sun, Jul 28, 2013 at 02:12:49AM +0200, Andreas Färber wrote: Am 25.07.2013 11:32, schrieb Michael S. Tsirkin: diff --git

Re: [Qemu-devel] [PATCH v3 11/14] piix: APIs for pc guest info

2013-07-28 Thread Andreas Färber
Am 28.07.2013 12:31, schrieb Andreas Färber: Am 28.07.2013 12:14, schrieb Michael S. Tsirkin: On Sun, Jul 28, 2013 at 11:38:17AM +0200, Andreas Färber wrote: Am 28.07.2013 09:30, schrieb Michael S. Tsirkin: On Sun, Jul 28, 2013 at 02:12:49AM +0200, Andreas Färber wrote: Am 25.07.2013 11:32,

Re: [Qemu-devel] [PATCH] musicpal: Fix typo in name of local function

2013-07-28 Thread Stefan Weil
Am 28.07.2013 11:46, schrieb Andreas Färber: Am 28.07.2013 07:54, schrieb Stefan Weil: The misspelling was spotted by Andreas Färber. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/arm/musicpal.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) [...] Reviewed-by: Andreas

Re: [Qemu-devel] [PATCH qom-cpu for-1.6] cpu: Partially revert cpu: Change qemu_init_vcpu() argument to CPUState

2013-07-28 Thread Andreas Färber
Am 28.07.2013 08:13, schrieb Igor Mammedov: On Sat, 27 Jul 2013 04:01:50 +0200 Andreas Färber afaer...@suse.de wrote: Commit c643bed99 moved qemu_init_vcpu() calls to common CPUState code. This causes x86 cpu-add to fail with KVM: setting VAPIC address failed. The reason for the failure is

Re: [Qemu-devel] [PATCH qom-next v2 0/4] QOM'ification of pci-bridge types

2013-07-28 Thread Andreas Färber
Am 23.07.2013 00:36, schrieb Andreas Färber: Andreas Färber (4): pci-bridge: Turn PCIBridge into abstract QOM type pci-bridge-dev: QOM parent field cleanup pci-bridge/i82801b11: Rename parent field pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types Thanks, applied to

Re: [Qemu-devel] [PATCH v3 11/14] piix: APIs for pc guest info

2013-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 01:08:13PM +0200, Andreas Färber wrote: Am 28.07.2013 12:31, schrieb Andreas Färber: Am 28.07.2013 12:14, schrieb Michael S. Tsirkin: On Sun, Jul 28, 2013 at 11:38:17AM +0200, Andreas Färber wrote: Am 28.07.2013 09:30, schrieb Michael S. Tsirkin: On Sun, Jul 28,

Re: [Qemu-devel] [PATCH qom-cpu for-1.6] cpu: Partially revert cpu: Change qemu_init_vcpu() argument to CPUState

2013-07-28 Thread Jia Liu
On Sat, Jul 27, 2013 at 10:01 AM, Andreas Färber afaer...@suse.de wrote: Commit c643bed99 moved qemu_init_vcpu() calls to common CPUState code. This causes x86 cpu-add to fail with KVM: setting VAPIC address failed. The reason for the failure is that CPUClass::kvm_fd is not yet initialized in

[Qemu-devel] [PATCH for-1.6] fw_cfg: the I/O port variant expects little-endian

2013-07-28 Thread Paolo Bonzini
The I/O port variant of fw_cfg is used by sparc64, which is a big-endian machine. Firmware swaps bytes before sending them to fw_cfg, so we need to unswap them in the device. This is only used on sparc64 and on (little-endian) x86, so it does not affect any other target. 32-bit Sparc and PPC

[Qemu-devel] [PATCH for-1.6] memory: add tracepoints for MMIO reads/writes

2013-07-28 Thread Paolo Bonzini
This is quite handy to debug softmmu targets. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- memory.c | 5 + trace-events | 4 2 files changed, 9 insertions(+) diff --git a/memory.c b/memory.c index 1494e95..ac6f3c6 100644 --- a/memory.c +++ b/memory.c @@ -19,6 +19,7 @@

Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

2013-07-28 Thread Andreas Färber
Hi Anthony, Am 22.07.2013 22:29, schrieb Anthony Liguori: for consistency, I think having everything be relatively to *one* type for a Property list is pretty helpful. Expecting someone to know the type hierarchy by heart such that this doesn't look like a bug is too much IMHO. I have

Re: [Qemu-devel] [PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 12:14:53PM +0300, Marcel Apfelbaum wrote: Categorize devices that appear as output to -device ? command by logical functionality. Sort the devices by logical categories before showing them to user. The sort is done by functionality rather than alphabetical.

Re: [Qemu-devel] [PATCH for-1.6] memory: add tracepoints for MMIO reads/writes

2013-07-28 Thread Andreas Färber
Am 28.07.2013 14:35, schrieb Paolo Bonzini: This is quite handy to debug softmmu targets. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- memory.c | 5 + trace-events | 4 2 files changed, 9 insertions(+) diff --git a/memory.c b/memory.c index 1494e95..ac6f3c6 100644

Re: [Qemu-devel] [PATCH 0/2] qemu-help: improve -device command line help

2013-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 12:14:52PM +0300, Marcel Apfelbaum wrote: Running qemu with -device ? option returns ~145 lines. It is hard to manage understanding the output. Theses patches aim to partially solve the problem by dividing the devices into logical categories like Network/Display/...

Re: [Qemu-devel] [PATCH] target-or32: fix masking in openrisc_pic_cpu_handler()

2013-07-28 Thread Jia Liu
Hi Xi, On Tue, Jan 22, 2013 at 11:57 PM, Xi Wang xi.w...@gmail.com wrote: A correct mask should be `x (1 i)', rather than `x (1 i)'. Also, in C99 signed shift (1 31) is undefined behavior, since the result exceeds INT_MAX; use 1U instead. Signed-off-by: Xi Wang xi.w...@gmail.com ---

Re: [Qemu-devel] [PATCH for-1.6] memory: add tracepoints for MMIO reads/writes

2013-07-28 Thread Paolo Bonzini
Il 28/07/2013 14:45, Andreas Färber ha scritto: Am 28.07.2013 14:35, schrieb Paolo Bonzini: This is quite handy to debug softmmu targets. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- memory.c | 5 + trace-events | 4 2 files changed, 9 insertions(+) diff --git

Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

2013-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 02:36:33PM +0200, Andreas Färber wrote: Hi Anthony, Am 22.07.2013 22:29, schrieb Anthony Liguori: for consistency, I think having everything be relatively to *one* type for a Property list is pretty helpful. Expecting someone to know the type hierarchy by heart

[Qemu-devel] [PATCH for-1.6 v2] memory: add tracepoints for MMIO reads/writes

2013-07-28 Thread Paolo Bonzini
This is quite handy to debug softmmu targets. Reviewed-by: Andreas Faerber afaer...@suse.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- memory.c | 5 + trace-events | 4 2 files changed, 9 insertions(+) diff --git a/memory.c b/memory.c index 1494e95..ac6f3c6 100644 ---

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-07-28 Thread Gleb Natapov
On Thu, Jul 25, 2013 at 05:05:22PM +0200, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- target-i386/cpu.h | 23 + target-i386/kvm.c | 93 --- target-i386/machine.c | 44

Re: [Qemu-devel] [PATCH for-1.6] memory: add tracepoints for MMIO reads/writes

2013-07-28 Thread Andreas Färber
Am 28.07.2013 14:55, schrieb Paolo Bonzini: Il 28/07/2013 14:45, Andreas Färber ha scritto: Am 28.07.2013 14:35, schrieb Paolo Bonzini: diff --git a/trace-events b/trace-events index 002df83..3e0dd74 100644 --- a/trace-events +++ b/trace-events @@ -1165,6 +1165,10 @@ kvm_vm_ioctl(int type,

Re: [Qemu-devel] [PATCH v2 0/2] kvm: migrate vPMU state

2013-07-28 Thread Andreas Färber
Am 25.07.2013 17:05, schrieb Paolo Bonzini: Same code as v1, but with all tabs expunged from cpu.h. Paolo Bonzini (2): target-i386: remove tabs from target-i386/cpu.h kvm: migrate vPMU state target-i386/cpu.h | 215 --

Re: [Qemu-devel] [PATCH v2 0/2] kvm: migrate vPMU state

2013-07-28 Thread Gleb Natapov
On Sun, Jul 28, 2013 at 03:03:50PM +0200, Andreas Färber wrote: Am 25.07.2013 17:05, schrieb Paolo Bonzini: Same code as v1, but with all tabs expunged from cpu.h. Paolo Bonzini (2): target-i386: remove tabs from target-i386/cpu.h kvm: migrate vPMU state target-i386/cpu.h

Re: [Qemu-devel] [PATCH RFC for-1.6 qom-next 0/3] PCIe VMState cleanups for 1.6

2013-07-28 Thread Andreas Färber
Am 28.07.2013 03:41, schrieb Andreas Färber: Patch 1 assumes the following are equivalent: a) - Struct A - Field Aa ... - Field X ... b) - Struct A - Field Aa ... - Field X Patch 2 relies on XHCI not being released yet, thus no compatibiliy concerns.

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-07-28 Thread Paolo Bonzini
Il 28/07/2013 14:57, Gleb Natapov ha scritto: @@ -1114,6 +1135,33 @@ static int kvm_put_msrs(X86CPU *cpu, int level) kvm_msr_entry_set(msrs[n++], MSR_KVM_STEAL_TIME, env-steal_time_msr); } +if (has_msr_architectural_pmu) { +

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-07-28 Thread Gleb Natapov
On Sun, Jul 28, 2013 at 03:51:25PM +0200, Paolo Bonzini wrote: Il 28/07/2013 14:57, Gleb Natapov ha scritto: @@ -1114,6 +1135,33 @@ static int kvm_put_msrs(X86CPU *cpu, int level) kvm_msr_entry_set(msrs[n++], MSR_KVM_STEAL_TIME,

Re: [Qemu-devel] [PATCH RFC for-1.6 qom-next 0/3] PCIe VMState cleanups for 1.6

2013-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 03:41:07AM +0200, Andreas Färber wrote: Hello Michael and Gerd, As discussed, this series attempts to clean up PCIe devices fiddling with individual PCIe VMState fields. It is based on my qom-next queue, containing type and field changes for PCIe devices. Patch 1

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-07-28 Thread Paolo Bonzini
Il 28/07/2013 15:54, Gleb Natapov ha scritto: On Sun, Jul 28, 2013 at 03:51:25PM +0200, Paolo Bonzini wrote: Il 28/07/2013 14:57, Gleb Natapov ha scritto: @@ -1114,6 +1135,33 @@ static int kvm_put_msrs(X86CPU *cpu, int level) kvm_msr_entry_set(msrs[n++], MSR_KVM_STEAL_TIME,

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-07-28 Thread Gleb Natapov
On Sun, Jul 28, 2013 at 04:07:37PM +0200, Paolo Bonzini wrote: Il 28/07/2013 15:54, Gleb Natapov ha scritto: On Sun, Jul 28, 2013 at 03:51:25PM +0200, Paolo Bonzini wrote: Il 28/07/2013 14:57, Gleb Natapov ha scritto: @@ -1114,6 +1135,33 @@ static int kvm_put_msrs(X86CPU *cpu, int level)

Re: [Qemu-devel] [PATCH RFC for-1.6 qom-next 0/3] PCIe VMState cleanups for 1.6

2013-07-28 Thread Andreas Färber
Am 28.07.2013 15:44, schrieb Andreas Färber: Am 28.07.2013 03:41, schrieb Andreas Färber: Patch 1 assumes the following are equivalent: a) - Struct A - Field Aa ... - Field X ... b) - Struct A - Field Aa ... - Field X Patch 2 relies on XHCI not being

Re: [Qemu-devel] [PATCH for-1.6] memory: add tracepoints for MMIO reads/writes

2013-07-28 Thread Peter Maydell
On 28 July 2013 13:35, Paolo Bonzini pbonz...@redhat.com wrote: This is quite handy to debug softmmu targets. Signed-off-by: Paolo Bonzini pbonz...@redhat.com (not a nak, just a tangential thought) It would be cute if you could just insert a trace this access and pass it through container

Re: [Qemu-devel] [PATCH RFC for-1.6 qom-next 0/3] PCIe VMState cleanups for 1.6

2013-07-28 Thread Andreas Färber
Am 28.07.2013 16:08, schrieb Michael S. Tsirkin: On Sun, Jul 28, 2013 at 03:41:07AM +0200, Andreas Färber wrote: Hello Michael and Gerd, As discussed, this series attempts to clean up PCIe devices fiddling with individual PCIe VMState fields. It is based on my qom-next queue, containing type

Re: [Qemu-devel] [PATCH for-1.6] memory: add tracepoints for MMIO reads/writes

2013-07-28 Thread Andreas Färber
Am 28.07.2013 16:34, schrieb Peter Maydell: On 28 July 2013 13:35, Paolo Bonzini pbonz...@redhat.com wrote: This is quite handy to debug softmmu targets. Signed-off-by: Paolo Bonzini pbonz...@redhat.com (not a nak, just a tangential thought) It would be cute if you could just insert a

Re: [Qemu-devel] VFIO and scheduled SR-IOV cards

2013-07-28 Thread Benoît Canet
Confused. You have one VF accessing BAR of another VF? Why? The VFs are scheduled and the board have only one microcontroller responsible to give the read results for some memory mapped registers. So it could respond the value of the active VF when a bar of an inactive VF is read. I handed

Re: [Qemu-devel] [PATCH RFC for-1.6 qom-next 0/3] PCIe VMState cleanups for 1.6

2013-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 04:59:18PM +0200, Andreas Färber wrote: Am 28.07.2013 16:08, schrieb Michael S. Tsirkin: On Sun, Jul 28, 2013 at 03:41:07AM +0200, Andreas Färber wrote: Hello Michael and Gerd, As discussed, this series attempts to clean up PCIe devices fiddling with individual

Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15

2013-07-28 Thread Aurelien Jarno
On Thu, May 23, 2013 at 07:37:53PM +0200, Petar Jovanovic wrote: From: Petar Jovanovic petar.jovano...@imgtec.com Multiplication of Q15 fractional halfword vectors was incorrect in the previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take element signs into account. This

Re: [Qemu-devel] [RFC PATCH] vga: Start supporting resolution not multiple of 16 correctly.

2013-07-28 Thread Frediano Ziglio
2013/7/23 Gerd Hoffmann kra...@redhat.com Hi, Tested-by: Fabio Fantoni fabio.fant...@m2r.biz I tested it for a long time with spice on xen (because qxl will be fully working only after adding SSE support on hvm domUs). It works, I think it is good to add this and the respective

Re: [Qemu-devel] [PATCH] target-mips: fix branch in likely delay slot tcg assert

2013-07-28 Thread Aurelien Jarno
On Mon, Jun 24, 2013 at 05:45:39PM +0100, Yongbok Kim wrote: From: James Hogan james.ho...@imgtec.com When a branch delay slot contains another branch instruction, the code generated raises an exception, however since is_branch==1, handle_delay_slot() doesn't get called immediately. This

Re: [Qemu-devel] [PATCH 1/6] pc: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/ioapic.h

2013-07-28 Thread Igor Mammedov
On Sun, 28 Jul 2013 11:54:46 +0200 Andreas Färber afaer...@suse.de wrote: Am 28.07.2013 09:29, schrieb Igor Mammedov: From: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Laszlo Ersek ler...@redhat.com Missing Reviewed-bys from

Re: [Qemu-devel] [PATCH 2/6] pc: add I440FX QOM cast macro

2013-07-28 Thread Igor Mammedov
On Sun, 28 Jul 2013 11:57:14 +0200 Andreas Färber afaer...@suse.de wrote: Am 28.07.2013 09:29, schrieb Igor Mammedov: Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/pci-host/piix.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 2/6] pc: add I440FX QOM cast macro

2013-07-28 Thread Andreas Färber
Am 28.07.2013 19:21, schrieb Igor Mammedov: On Sun, 28 Jul 2013 11:57:14 +0200 Andreas Färber afaer...@suse.de wrote: Am 28.07.2013 09:29, schrieb Igor Mammedov: Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/pci-host/piix.c | 8 ++-- 1 file changed, 6 insertions(+), 2

Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default

2013-07-28 Thread Igor Mammedov
On Sun, 28 Jul 2013 12:13:17 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Jul 28, 2013 at 10:21:56AM +0200, Igor Mammedov wrote: On Sun, 28 Jul 2013 10:57:12 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Jul 28, 2013 at 09:29:13AM +0200, Igor Mammedov wrote: It

Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default

2013-07-28 Thread Igor Mammedov
On Sun, 28 Jul 2013 12:11:42 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Jul 28, 2013 at 10:21:56AM +0200, Igor Mammedov wrote: On Sun, 28 Jul 2013 10:57:12 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Jul 28, 2013 at 09:29:13AM +0200, Igor Mammedov wrote: It

Re: [Qemu-devel] [PATCH 1/6] pc: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/ioapic.h

2013-07-28 Thread Andreas Färber
Am 28.07.2013 19:19, schrieb Igor Mammedov: On Sun, 28 Jul 2013 11:54:46 +0200 Andreas Färber afaer...@suse.de wrote: Am 28.07.2013 09:29, schrieb Igor Mammedov: From: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Laszlo Ersek

Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default

2013-07-28 Thread Igor Mammedov
On Sun, 28 Jul 2013 12:17:47 +0200 Andreas Färber afaer...@suse.de wrote: Am 28.07.2013 11:11, schrieb Michael S. Tsirkin: On Sun, Jul 28, 2013 at 10:21:56AM +0200, Igor Mammedov wrote: On Sun, 28 Jul 2013 10:57:12 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Jul 28, 2013 at

Re: [Qemu-devel] [PATCH 2/6] pc: add I440FX QOM cast macro

2013-07-28 Thread Igor Mammedov
On Sun, 28 Jul 2013 19:24:03 +0200 Andreas Färber afaer...@suse.de wrote: Am 28.07.2013 19:21, schrieb Igor Mammedov: On Sun, 28 Jul 2013 11:57:14 +0200 Andreas Färber afaer...@suse.de wrote: Am 28.07.2013 09:29, schrieb Igor Mammedov: Signed-off-by: Igor Mammedov imamm...@redhat.com

[Qemu-devel] Jiajun, please add me to your LinkedIn network

2013-07-28 Thread Jagan Teki (U-Boot Custodian) via LinkedIn
LinkedIn Jagan Teki (U-Boot Custodian) requested to add you as a connection on LinkedIn: -- Jiajun, I'd like to add you to my professional network on LinkedIn. - Jagan Teki Accept invitation from Jagan Teki (U-Boot Custodian)

Re: [Qemu-devel] [RFC 0/3 v2] qdev: handle global properties after all instance_init calls

2013-07-28 Thread Andreas Färber
Am 10.07.2013 22:08, schrieb Eduardo Habkost: Updated version of the series sent in October 2012. References: http://article.gmane.org/gmane.comp.emulators.qemu/173753 (old discussion) http://article.gmane.org/gmane.comp.emulators.qemu/173782 (previous version of this series)

Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default

2013-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 07:40:32PM +0200, Igor Mammedov wrote: On Sun, 28 Jul 2013 12:17:47 +0200 Andreas Färber afaer...@suse.de wrote: Am 28.07.2013 11:11, schrieb Michael S. Tsirkin: On Sun, Jul 28, 2013 at 10:21:56AM +0200, Igor Mammedov wrote: On Sun, 28 Jul 2013 10:57:12 +0300

Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default

2013-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 07:33:27PM +0200, Igor Mammedov wrote: On Sun, 28 Jul 2013 12:11:42 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Jul 28, 2013 at 10:21:56AM +0200, Igor Mammedov wrote: On Sun, 28 Jul 2013 10:57:12 +0300 Michael S. Tsirkin m...@redhat.com wrote:

Re: [Qemu-devel] [qom-cpu PATCH 0/2] i386: disable PMU CPUID leaf by default

2013-07-28 Thread Andreas Färber
Am 26.07.2013 22:15, schrieb Andreas Färber: Am 26.07.2013 22:09, schrieb Eduardo Habkost: Changes v1 - v2: * compat property is now named pmu instead of pmu-passthrough Eduardo Habkost (2): i386: pass X86CPU object to cpu_x86_find_by_name() i386: disable PMU CPUID leaves by default

Re: [Qemu-devel] [PATCH qom-cpu v9] target-i386: Move hyperv_* static globals to X86CPU

2013-07-28 Thread Andreas Färber
Am 08.07.2013 14:40, schrieb Igor Mammedov: On Mon, 8 Jul 2013 03:03:54 +0200 Andreas Färber afaer...@suse.de wrote: From: Igor Mammedov imamm...@redhat.com - since hyperv_* helper functions are used only in target-i386/kvm.c move them there as static helpers Requested-by: Eduardo

[Qemu-devel] syscall _llseek does not work with file offset = 2 GB

2013-07-28 Thread Gilles Mouchard
Hello, In Linux user mode, system call _llseek returns EINVAL when offset_low = 2 GB. Replacing __NR_llseek by __NR__llseek has solved the bug (note the missing underscore). diff -Naur qemu-1.5.2-orig/linux-user/ openrisc/syscall_nr.h qemu-1.5.2-new/linux-user/openrisc/syscall_nr.h ---

[Qemu-devel] [PATCH] hw/usb/redirect.c: crash in QOM cleanup

2013-07-28 Thread Martin Cerveny
Hello. Qemu crashes during remote usb device removal. The associated chardev is destroyed qemu_chr_delete() in usbredir_handle_destroy() but pointer is not cleared. QOM cleanup is using pointer to previously freed memory. Example cmds: chardev-add

Re: [Qemu-devel] [PATCH 0/6] mips_malta: fixes to support YAMON firmware

2013-07-28 Thread Aurelien Jarno
On Fri, Jun 14, 2013 at 08:30:42AM +0100, Leon Alrae wrote: From: Paul Burton paul.bur...@imgtec.com This patchset fixes some bugs with MIPS malta emulation allowing the YAMON firmware to run. YAMON can be found at http://www.mips.com/products/system-software/yamon/ You can then boot to

Re: [Qemu-devel] [PATCH v2] target-mips: fix mipsdsp_trunc16_sat16_round

2013-07-28 Thread Aurelien Jarno
On Mon, Jul 01, 2013 at 01:54:47AM +0200, Petar Jovanovic wrote: From: Petar Jovanovic petar.jovano...@imgtec.com This change corrects rounding and saturation of Q31 fractional value in mipsdsp_trunc16_sat16_round(). Overflow detection was incorrect for the corner case for PRECRQ_RS.PH, and

Re: [Qemu-devel] [PATCH] hw/mips: align initrd to 64KB to avoid kernel error

2013-07-28 Thread Aurelien Jarno
On Thu, Jun 27, 2013 at 08:35:27AM +0100, Leon Alrae wrote: From: James Hogan james.ho...@imgtec.com The Linux kernel can be configured to use 64KB pages, but it also requires initrd to be page aligned. Therefore, to be safe, align the initrd to 64KB using a new INITRD_PAGE_MASK rather than

Re: [Qemu-devel] [PATCH] target-mips: Remove assignment to a variable which is never used

2013-07-28 Thread Aurelien Jarno
On Thu, Jul 25, 2013 at 10:10:31PM +0200, Stefan Weil wrote: This assignment causes a compiler warning for compilations with the compiler option -Wunused-but-set-variable (which is included with -Wextra). Removing it allows using -Wextra for QEMU code without suppressing too many extra

Re: [Qemu-devel] [PATCH] linux-user: correct argument number for sys_mremap and sys_splice

2013-07-28 Thread Aurelien Jarno
On Tue, Jul 23, 2013 at 07:00:10PM +0200, Petar Jovanovic wrote: From: Petar Jovanovic petar.jovano...@imgtec.com sys_mremap missed 5th argument (new_address), which caused examples that remap to a specific address to fail. sys_splice missed 5th and 6th argument which caused different

Re: [Qemu-devel] qemu aborts with temp_save: Assertion `s-temps[temp].val_type == 2 || s-temps[temp].fixed_reg' failed

2013-07-28 Thread Aurelien Jarno
On Thu, Jul 11, 2013 at 08:01:19AM +0400, Max Filippov wrote: On Thu, Jul 11, 2013 at 6:35 AM, Max Filippov jcmvb...@gmail.com wrote: Hi Peter, I suddenly found qemu built with debug enabled aborting with an assertion on one of xtensa tests: qemu-system-xtensa -M sim -cpu dc232b

Re: [Qemu-devel] qemu aborts with temp_save: Assertion `s-temps[temp].val_type == 2 || s-temps[temp].fixed_reg' failed

2013-07-28 Thread Max Filippov
On Mon, Jul 29, 2013 at 3:01 AM, Aurelien Jarno aurel...@aurel32.net wrote: On Thu, Jul 11, 2013 at 08:01:19AM +0400, Max Filippov wrote: On Thu, Jul 11, 2013 at 6:35 AM, Max Filippov jcmvb...@gmail.com wrote: Hi Peter, I suddenly found qemu built with debug enabled aborting with an

Re: [Qemu-devel] [PATCH qom-next for-1.6 07/15] imx_avic: QOM cast cleanup

2013-07-28 Thread Peter Chubb
Andreas == Andreas Färber afaer...@suse.de writes: Andreas Signed-off-by: Andreas Färber afaer...@suse.de --- Acked-by: Peter Chubb peter.ch...@nicta.com.au -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems

Re: [Qemu-devel] [PATCH qom-next for-1.6 06/14] imx_ccm: QOM cast cleanup

2013-07-28 Thread Peter Chubb
Andreas == Andreas Färber afaer...@suse.de writes: Andreas Signed-off-by: Andreas Färber afaer...@suse.de --- Acked-by: Peter Chubb peter.ch...@nicta.com.au -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems

[Qemu-devel] [PATCH qom-next for-next v2 5/6] pci: Move vmstate_pcie_aer_log into vmstate_pci_device

2013-07-28 Thread Andreas Färber
Make it conditional on PCIe and allocation of the AER log. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-bridge/ioh3420.c| 2 -- hw/pci-bridge/xio3130_downstream.c | 2 -- hw/pci-bridge/xio3130_upstream.c | 2 -- hw/pci/pci.c | 9 +

[Qemu-devel] [PATCH qom-next for-next v2 3/6] vmstate: Introduce VMSTATE_BUFFER_UNSAFE_INFO_TEST()

2013-07-28 Thread Andreas Färber
To be used by PCIDevice. Signed-off-by: Andreas Färber afaer...@suse.de --- include/migration/vmstate.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 1c31b5d..3590e1f 100644 ---

[Qemu-devel] [PATCH qom-next for-next v2 1/6] pci: Simplify VMSTATE_PCI_DEVICE() macro

2013-07-28 Thread Andreas Färber
Drop the arguments to avoid QOM refactorings causing more churn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/acpi/piix4.c| 2 +- hw/audio/ac97.c| 2 +- hw/audio/es1370.c | 2 +- hw/audio/intel-hda.c | 2 +- hw/char/serial-pci.c

[Qemu-devel] [PATCH qom-next for-next v2 2/6] pci: Simplify VMSTATE_PCIE_DEVICE() macro

2013-07-28 Thread Andreas Färber
Drop the arguments to avoid QOM refactorings causing more churn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-bridge/ioh3420.c| 2 +- hw/pci-bridge/xio3130_downstream.c | 2 +- hw/pci-bridge/xio3130_upstream.c | 2 +- hw/usb/hcd-xhci.c | 2 +-

[Qemu-devel] [PATCH RFC qom-next for-next v2 6/6] pci: Move VMSTATE_MSIX() into vmstate_pci_device

2013-07-28 Thread Andreas Färber
Use it conditional on msix_present() and drop msix_{save,load}() calls following pci_device_{save,load}(). This reorders the msix_save() and msix_unuse_all_vectors() calls for virtio-pci, but they seem independent of each other. Signed-off-by: Andreas Färber afaer...@suse.de ---

[Qemu-devel] [PATCH qom-next for-next v2 4/6] pci: Unify vmstate_{pci, pcie}_device

2013-07-28 Thread Andreas Färber
The only difference so far is the size of the config space. It is always used through either VMSTATE_{PCI,PCIE}_DEVICE() or pci_device_save(), so the name change for PCIe shouldn't matter. Suggested-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de ---

[Qemu-devel] [PATCH qom-next for-next v2 0/6] PCI VMState cleanups

2013-07-28 Thread Andreas Färber
Hello Michael and Gerd, As discussed, this series attempts to clean up PCIe devices fiddling with individual PCI VMStateFields. It is based on my qom-devices queue, containing changes to PCIe devices. v2 has been changed to use VMStateField::field_exists instead of subsections and unifies PCI

Re: [Qemu-devel] [PATCH 3/4] qemu-nbd: add doc for internal snapshot export

2013-07-28 Thread Wenchao Xia
于 2013-7-26 16:11, Stefan Hajnoczi 写道: On Wed, Jul 17, 2013 at 10:03:54PM +0800, Wenchao Xia wrote: Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- qemu-nbd.c|2 ++ qemu-nbd.texi |3 +++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/qemu-nbd.c

Re: [Qemu-devel] vhost acceleration broken?

2013-07-28 Thread Rusty Russell
Anthony Liguori anth...@codemonkey.ws writes: Michael S. Tsirkin m...@redhat.com writes: On Thu, Jul 25, 2013 at 04:56:05PM +0200, Andreas Färber wrote: Am 25.07.2013 16:52, schrieb Michael S. Tsirkin: On Thu, Jul 25, 2013 at 08:28:00AM -0500, Anthony Liguori wrote: We have a pretty awful

  1   2   >