[Qemu-devel] [PATCH v4 01/13] block: vhdx - minor comments and typo correction.

2013-08-20 Thread Jeff Cody
Just a couple of minor comments to help note where allocated buffers are freed, and a typo fix. Signed-off-by: Jeff Cody jc...@redhat.com --- block/vhdx.c | 6 -- block/vhdx.h | 6 +++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/block/vhdx.c b/block/vhdx.c index

[Qemu-devel] [PATCH v4 00/13] VHDX log replay and write support, .bdrv_create()

2013-08-20 Thread Jeff Cody
This patch series contains the initial VHDX log parsing, replay, and write support. (New with v4: VHDX image file creation) === v4 changes === v4 patches are available from github as well, on branch vhdx-write-v4-upstream: https://github.com/codyprime/qemu-kvm-jtc/tree/vhdx-write-v4-upstream

[Qemu-devel] [PATCH v4 02/13] block: vhdx - add header update capability.

2013-08-20 Thread Jeff Cody
This adds the ability to update the headers in a VHDX image, including generating a new MS-compatible GUID. As VHDX depends on uuid.h, VHDX is now a configurable build option. If VHDX support is enabled, that will also enable uuid as well. The default is to have VHDX enabled. To enable/disable

[Qemu-devel] [PATCH v4 03/13] block: vhdx code movement - VHDXMetadataEntries and BDRVVHDXState to header.

2013-08-20 Thread Jeff Cody
In preparation for VHDX log support, move these structures to the header. Signed-off-by: Jeff Cody jc...@redhat.com --- block/vhdx.c | 51 --- block/vhdx.h | 47 +++ 2 files changed, 47 insertions(+), 51

[Qemu-devel] [PATCH v4 08/13] block: vhdx - add log write support

2013-08-20 Thread Jeff Cody
This adds support for writing to the VHDX log. For spec details, see VHDX Specification Format v1.00: https://www.microsoft.com/en-us/download/details.aspx?id=34750 There are a few limitations to this log support: 1.) There is no caching yet 2.) The log is flushed after each entry The primary

[Qemu-devel] [PATCH v4 10/13] block: vhdx - move more endian translations to vhdx-endian.c

2013-08-20 Thread Jeff Cody
In preperation for vhdx_create(), move more endian translation functions out to vhdx-endian.c. Signed-off-by: Jeff Cody jc...@redhat.com --- block/vhdx-endian.c | 75 + block/vhdx.c| 20 +++--- block/vhdx.h| 9 ++-

[Qemu-devel] [PATCH v4 09/13] block: vhdx write support

2013-08-20 Thread Jeff Cody
This adds support for writing to VHDX image files, using coroutines. Writes into the BAT table goes through the VHDX log. Currently, BAT table writes occur when expanding a dynamic VHDX file, and allocating a new BAT entry. Signed-off-by: Jeff Cody jc...@redhat.com --- block/vhdx.c | 150

[Qemu-devel] [PATCH v4 05/13] block: vhdx - break endian translation functions out

2013-08-20 Thread Jeff Cody
This moves the endian translation functions out from the vhdx.c source, into a separate source file. In addition to the previously defined endian functions, new endian translation functions for log support are added as well. Signed-off-by: Jeff Cody jc...@redhat.com --- block/Makefile.objs | 2

[Qemu-devel] [PATCH v4 06/13] block: vhdx - update log guid in header, and first write tracker

2013-08-20 Thread Jeff Cody
Allow tracking of first file write in the VHDX image, as well as the ability to update the GUID in the header. This is in preparation for log support. Signed-off-by: Jeff Cody jc...@redhat.com --- block/vhdx.c | 30 -- block/vhdx.h | 6 ++ 2 files changed, 30

[Qemu-devel] [PATCH v4 11/13] block: vhdx - break out code operations to functions

2013-08-20 Thread Jeff Cody
This is preperation for vhdx_create(). The ability to write headers, and calculate the number of BAT entries will be needed within the create() functions, so move this relevant code into helper functions. Signed-off-by: Jeff Cody jc...@redhat.com --- block/vhdx.c | 121

[Qemu-devel] [PATCH v4 07/13] block: vhdx - log parsing, replay, and flush support

2013-08-20 Thread Jeff Cody
This adds support for VHDX v0 logs, as specified in Microsoft's VHDX Specification Format v1.00: https://www.microsoft.com/en-us/download/details.aspx?id=34750 The following support is added: * Log parsing, and validation - validate that an existing log is correct. * Log search - search

[Qemu-devel] [PATCH v4 13/13] block: vhdx - add .bdrv_create() support

2013-08-20 Thread Jeff Cody
This adds support for VHDX image creation, for images of type Fixed and Dynamic. Differencing types (i.e., VHDX images with backing files) are currently not supported. Options for image creation include: * log size: The size of the journaling log for VHDX. Minimum is 1MB,

[Qemu-devel] [PATCH v4 12/13] block: vhdx - fix comment typos in header, fix incorrect struct fields

2013-08-20 Thread Jeff Cody
VHDXPage83Data and VHDXParentLocatorHeader both incorrectly had their MSGUID fields set as arrays of 16. This is incorrect (it stems from an early version where those fields were uint_8 arrays). Those fields were, up to this patch, unused. Also, there were a couple of typos and incorrect

Re: [Qemu-devel] [PATCH] qemu-kvm bugfix for IA32_FEATURE_CONTROL

2013-08-20 Thread Liu, Jinsong
Paolo Bonzini wrote: Il 19/08/2013 16:59, Andreas Färber ha scritto: qemu-kvm is no longer maintained since 1.3 so it should not be occurring any more. Please use a prefix of target-i386: (the directory name) to signal where you are changing code, i.e. x86 only. bugfix is not a very

[Qemu-devel] [PATCH v4 04/13] block: vhdx - log support struct and defines

2013-08-20 Thread Jeff Cody
This adds some magic number defines, and internal structure definitions for VHDX log replay support. The struct VHDXLogEntries does not reflect an on-disk data structure, and thus does not need to be packed. Some minor code style fixes are applied as well. Signed-off-by: Jeff Cody

Re: [Qemu-devel] [PATCHv11 13/31] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-20 Thread Alex Bligh
for (bh = ctx-first_bh; bh; bh = bh-next) { if (!bh-deleted bh-scheduled) { if (bh-idle) { /* idle bottom halves will be polled at least * every 10ms */ -*timeout = 10; +*timeout =

Re: [Qemu-devel] vmdk stream-optimised format

2013-08-20 Thread Alex Bligh
On 20 Aug 2013, at 02:42, Fam Zheng wrote: OK, thanks for explaination. That sounds a valid use case for streamOptimized. However I am afraid QEMU and its users benefit not much from this feature anyway, because it's moving a VM away to VMware, :) that might be the reason it's not there yet,

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Alexander Graf
On 20.08.2013, at 02:36, Alexey Kardashevskiy wrote: On 08/19/2013 07:47 PM, Paolo Bonzini wrote: Il 19/08/2013 10:44, Alexey Kardashevskiy ha scritto: It means that if you use the same QEMU version with the same command line on a different kernel version, your guest looks different because

Re: [Qemu-devel] [PATCH v2 1/9] tests: QAPI schema parser tests

2013-08-20 Thread Markus Armbruster
Laszlo Ersek ler...@redhat.com writes: On 07/27/13 17:41, Markus Armbruster wrote: The parser handles erroneous input badly. To be improved shortly. Signed-off-by: Markus Armbruster arm...@redhat.com diff --git a/tests/Makefile b/tests/Makefile index cdbb79e..ddb957c 100644 ---

Re: [Qemu-devel] [PATCH RESEND] RCU implementation for Qemu. Fixup some dynamic casts in the Qemu device tree to correspond to the QOM type-checking system.

2013-08-20 Thread Markus Armbruster
Eric's advice in Message-ID: 5212712c.1080...@redhat.com applies: Your subject line is atrociously long. Please put a blank line between the summary (ca. 60 characters or less) and the rest of your commit message. 'git shortlog -30' will give you a hint on typical summary naming.

Re: [Qemu-devel] vmdk stream-optimised format

2013-08-20 Thread Fam Zheng
On Tue, 08/20 07:51, Alex Bligh wrote: On 20 Aug 2013, at 02:42, Fam Zheng wrote: OK, thanks for explaination. That sounds a valid use case for streamOptimized. However I am afraid QEMU and its users benefit not much from this feature anyway, because it's moving a VM away to VMware, :)

Re: [Qemu-devel] [PATCH v2] monitor: print the invalid char in error message

2013-08-20 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: It's more friendly to print which char is invalid to user, especially when user tries to input a float value and expect the monitor to round it to int. Since we don't round float number when we look for a integer, telling which char is invalid is less

Re: [Qemu-devel] [PATCHv11 13/31] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-20 Thread Wenchao Xia
于 2013-8-20 14:48, Alex Bligh 写道: for (bh = ctx-first_bh; bh; bh = bh-next) { if (!bh-deleted bh-scheduled) { if (bh-idle) { /* idle bottom halves will be polled at least * every 10ms */ -*timeout = 10; +

Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h

2013-08-20 Thread Erik Rull
On August 19, 2013 at 6:15 PM Erik Rull erik.r...@rdsoftware.de wrote: Luiz Capitulino wrote: On Fri, 16 Aug 2013 14:21:50 +0100 Peter Maydell peter.mayd...@linaro.org wrote: On 16 August 2013 08:59, Erik Rull erik.r...@rdsoftware.de wrote: Hi all, when using the released

[Qemu-devel] [PATCH 1/2] tests: Fix schema parser test for in-tree build

2013-08-20 Thread armbru
From: Markus Armbruster arm...@redhat.com Commit 4f193e3 added the test, but screwed up in-tree builds (SRCDIR=.): the tests's output overwrites the expected output, and is thus compared to itself. Reported-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Markus Armbruster arm...@redhat.com ---

[Qemu-devel] [PATCH 0/2] tests: Fixes for in-tree build

2013-08-20 Thread armbru
From: Markus Armbruster arm...@redhat.com Markus Armbruster (2): tests: Fix schema parser test for in-tree build tests: Update .gitignore for test-int128 and test-bitops tests/.gitignore | 3 +++ tests/Makefile | 8 2 files changed, 7 insertions(+), 4 deletions(-) -- 1.8.1.4

[Qemu-devel] [PATCH 2/2] tests: Update .gitignore for test-int128 and test-bitops

2013-08-20 Thread armbru
From: Markus Armbruster arm...@redhat.com Forgotten in commit 6046c62 and 3464700. Signed-off-by: Markus Armbruster arm...@redhat.com --- tests/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/.gitignore b/tests/.gitignore index d9c2ef4..9ac044d 100644 ---

Re: [Qemu-devel] [PATCH 7/7] switch raw block driver from raw.o to raw_bsd.o

2013-08-20 Thread Kevin Wolf
Am 18.08.2013 um 16:29 hat Paolo Bonzini geschrieben: Il 16/08/2013 16:15, Laszlo Ersek ha scritto: +static int raw_reopen_prepare(BDRVReopenState *reopen_state, + BlockReopenQueue *queue, Error **errp) { -return bdrv_reopen_prepare(bs-file); +

Re: [Qemu-devel] [PATCH 4/7] raw_bsd: introduce special members

2013-08-20 Thread Kevin Wolf
Am 16.08.2013 um 16:15 hat Laszlo Ersek geschrieben: On 08/05/13 15:03, Paolo Bonzini wrote: [...] 3) These members are special .format_name is the string raw .bdrv_open raw_open should set bs-sg to bs-file-sg and return 0 .bdrv_closeraw_close should do

Re: [Qemu-devel] [PATCH 0/3] target-ppc: Add support for dumping guest memory using qemu gdb server

2013-08-20 Thread Aneesh Kumar K.V
Andreas Färber afaer...@suse.de writes: Hi Aneesh, Am 19.08.2013 14:29, schrieb Aneesh Kumar K.V: This patch series implement support for dumping guest memory using qemu gdb server. I had a quick look through but will leave in-depth review to Alex or Anthony. Do you plan to implement

Re: [Qemu-devel] [PATCH 0/7] introduce BSD-licensed block driver for raw

2013-08-20 Thread Kevin Wolf
Am 16.08.2013 um 16:15 hat Laszlo Ersek geschrieben: Paolo asked me to write such a driver based on his textual specification alone. The first patch captures his email in full, the rest re-quotes parts that are being implemented. The tree compiles at each patch. The series passes make

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 03:36, Alexey Kardashevskiy ha scritto: Hm. Here we might have a problem like this is we decide to migrate from QEMU with this patch running on modern kernel to QEMU without this patch running on old kernel - for this we might want to be able to disable multi-tce via machine

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Alexey Kardashevskiy
On 08/20/2013 06:39 PM, Paolo Bonzini wrote: Il 20/08/2013 03:36, Alexey Kardashevskiy ha scritto: Hm. Here we might have a problem like this is we decide to migrate from QEMU with this patch running on modern kernel to QEMU without this patch running on old kernel - for this we might want to

Re: [Qemu-devel] [PATCH v2 6/7] vl: Set current_machine early

2013-08-20 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Am 19.08.2013 11:35, schrieb Markus Armbruster: Andreas Färber afaer...@suse.de writes: Am 16.08.2013 15:18, schrieb arm...@redhat.com: From: Markus Armbruster arm...@redhat.com I'd like to access QEMUMachine from a QEMUMachine init() method, which

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 10:49, Alexey Kardashevskiy ha scritto: On 08/20/2013 06:39 PM, Paolo Bonzini wrote: Il 20/08/2013 03:36, Alexey Kardashevskiy ha scritto: Hm. Here we might have a problem like this is we decide to migrate from QEMU with this patch running on modern kernel to QEMU without this

Re: [Qemu-devel] [Xen-devel] [PATCH] Qemu-xen: HVM S3 bugfix

2013-08-20 Thread George Dunlap
On Mon, Aug 19, 2013 at 3:47 PM, Liu, Jinsong jinsong@intel.com wrote: Ping? I know Ian and Stefano are doing something at ARM this week -- Anthony might be able to give a review, at least... -George

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Benjamin Herrenschmidt
On Tue, 2013-08-20 at 11:09 +0200, Paolo Bonzini wrote: Sorry if I miss anything, but is not it what the patch already does? :) No, you need to expose multitce unconditionally in the device tree. If I'm not mistaken the multitce kernel side patches are still not upstream so I disagree.

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 11:13, Benjamin Herrenschmidt ha scritto: On Tue, 2013-08-20 at 11:09 +0200, Paolo Bonzini wrote: Sorry if I miss anything, but is not it what the patch already does? :) No, you need to expose multitce unconditionally in the device tree. If I'm not mistaken the multitce

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Benjamin Herrenschmidt
On Tue, 2013-08-20 at 11:15 +0200, Paolo Bonzini wrote: - provide the infrastructure to enable/disable it from the command line (which will be enough design effort alone); sight ... why do things simply when we can come up with a cathedral instead ? - add pseries-1.6 as a synonym of

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 11:20, Benjamin Herrenschmidt ha scritto: On Tue, 2013-08-20 at 11:15 +0200, Paolo Bonzini wrote: - provide the infrastructure to enable/disable it from the command line (which will be enough design effort alone); sight ... why do things simply when we can come up with a

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Benjamin Herrenschmidt
On Tue, 2013-08-20 at 11:22 +0200, Paolo Bonzini wrote: Uhm... I thought Alex and I were the one who proposed the simple things. You _will_ need to do the complicated stuff sooner or later, but it's probably early enough now to ignore it. And I'm not saying this out of love for big

Re: [Qemu-devel] [PATCHv11 13/31] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-20 Thread Alex Bligh
On 20 Aug 2013, at 08:19, Wenchao Xia wrote: Thanks for the explanation. It seems *timeout is always set to -1 before calling GSource's prepare(), so *timeout = qemu_soonest_timeout(*timeout, 10); will always get *timeout = 10, so this call can be saved. I believe that's incorrect too.

Re: [Qemu-devel] [RFC] Convert AioContext to Gsource sub classes

2013-08-20 Thread Wenchao Xia
于 2013-8-16 16:12, Wenchao Xia 写道: 于 2013-8-16 15:15, Wenchao Xia 写道: 于 2013-8-16 0:32, Michael Roth 写道: Quoting Michael Roth (2013-08-15 10:23:20) Quoting Wenchao Xia (2013-08-13 03:44:39) 于 2013-8-13 1:01, Michael Roth 写道: Quoting Paolo Bonzini (2013-08-12 02:30:28) 1) rename AioContext

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 11:26, Benjamin Herrenschmidt ha scritto: On Tue, 2013-08-20 at 11:22 +0200, Paolo Bonzini wrote: Uhm... I thought Alex and I were the one who proposed the simple things. You _will_ need to do the complicated stuff sooner or later, but it's probably early enough now to ignore

Re: [Qemu-devel] minimal linux distribution for qemu

2013-08-20 Thread Rob Landley
On 08/18/2013 08:57:08 AM, Herbei Dacian wrote: good to know. I was working back in 2005-2006 with a company that had a 4MB kernel. At that time I was too inexperienced to work at that level but I thought now I could reproduce their work with some help. Anyhow for the moment I'll go for 256

Re: [Qemu-devel] [PATCH v2] Fix query-migrate documentation in qmp-commands.hx

2013-08-20 Thread Orit Wasserman
On 08/19/2013 09:41 PM, Luiz Capitulino wrote: On Mon, 12 Aug 2013 10:19:52 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 8 Aug 2013 20:05:48 +0300 Orit Wasserman owass...@redhat.com wrote: ram is present also when migration completes. expected-downtime, total-time and

Re: [Qemu-devel] [PATCH 0/2] tests: Fixes for in-tree build

2013-08-20 Thread Andreas Färber
Am 20.08.2013 09:47, schrieb arm...@redhat.com: From: Markus Armbruster arm...@redhat.com Markus Armbruster (2): tests: Fix schema parser test for in-tree build tests: Update .gitignore for test-int128 and test-bitops Series Reviewed-by: Andreas Färber afaer...@suse.de but you should

[Qemu-devel] [PATCH -V2 3/4] target-ppc: Fix page table lookup with kvm enabled

2013-08-20 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com With kvm enabled, we store the hash page table information in the hypervisor. Use ioctl to read the htab contents. Without this we get the below error when trying to read the guest address (gdb) x/10 do_fork 0xc0098660 do_fork:

[Qemu-devel] [PATCH -V2 2/4] target-ppc: Use #define instead of opencoding SLB valid bit

2013-08-20 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Use SLB_ESID_V instead of (1 27) in the code Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- target-ppc/mmu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PATCH -V2 0/4] target-ppc: Add support for dumping guest memory using qemu gdb server

2013-08-20 Thread Aneesh Kumar K.V
This patch series implement support for dumping guest memory using qemu gdb server. With this patch series we can now do (gdb) x/4i htab_call_hpte_insert1 0xc00470d8 .htab_call_hpte_insert1:bl 0xc00470d8 .htab_call_hpte_insert1 0xc00470dc

[Qemu-devel] [PATCH -V2 1/4] target-ppc: Update slb array with correct index values.

2013-08-20 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Without this, a value of rb=0 and rs=0 results in replacing the 0th index. This can be observed when using gdb remote debugging support. (gdb) x/10i do_fork 0xc0085330 do_fork:Cannot access memory at address

[Qemu-devel] [PATCH -V2 4/4] target-ppc: Check for error on address translation in memsave command

2013-08-20 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com When we translate the virtual address to physical check for error. Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- cpus.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cpus.c b/cpus.c index

Re: [Qemu-devel] vmdk stream-optimised format

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 09:08, Fam Zheng ha scritto: On Tue, 08/20 07:51, Alex Bligh wrote: On 20 Aug 2013, at 02:42, Fam Zheng wrote: OK, thanks for explaination. That sounds a valid use case for streamOptimized. However I am afraid QEMU and its users benefit not much from this feature anyway,

Re: [Qemu-devel] [RFC] Hardware acceleration for Windows and OS X?

2013-08-20 Thread Paolo Bonzini
Il 19/08/2013 22:17, Stefan Weil ha scritto: Hello, is anybody working on KVM or something equivalent for Windows and Mac OS X? I recently noticed that the QEMU based Android emulator uses KVM for Linux and HAXM, an Intel hypervisor, for Windows and Mac OS X. Would it be a good plan to

Re: [Qemu-devel] [RFC] Hardware acceleration for Windows and OS X?

2013-08-20 Thread Peter Maydell
On 20 August 2013 11:56, Paolo Bonzini pbonz...@redhat.com wrote: I guess patches are welcome---if they are of good quality, why not. Well, sort of. Given the fairly minimal level of support we currently have for OSX (ie Andreas and I test it a bit and fix egregious breakage), I'd prefer it if

Re: [Qemu-devel] [PATCHv11 13/31] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-20 Thread Wenchao Xia
于 2013-8-20 17:29, Alex Bligh 写道: On 20 Aug 2013, at 08:19, Wenchao Xia wrote: Thanks for the explanation. It seems *timeout is always set to -1 before calling GSource's prepare(), so *timeout = qemu_soonest_timeout(*timeout, 10); will always get *timeout = 10, so this call can be saved.

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Benjamin Herrenschmidt
On Tue, 2013-08-20 at 12:14 +0200, Paolo Bonzini wrote: I suppose if RH is going to deploy 3.10 and we aren't going to backport the multitce patches then there *might* be a case for supporting that combo specifically... but it's going to be that bad every time we add a new feature with a

[Qemu-devel] [PATCH v2 1/2] tests: Fix schema parser test for in-tree build

2013-08-20 Thread armbru
From: Markus Armbruster arm...@redhat.com Commit 4f193e3 added the test, but screwed up in-tree builds (SRCDIR=.): the tests's output overwrites the expected output, and is thus compared to itself. Cc: qemu-sta...@nongnu.org Reported-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Andreas Färber

[Qemu-devel] [PATCH v2 2/2] tests: Update .gitignore for test-int128 and test-bitops

2013-08-20 Thread armbru
From: Markus Armbruster arm...@redhat.com Forgotten in commit 6046c62 and 3464700. Cc: qemu-sta...@nongnu.org Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: Markus Armbruster arm...@redhat.com --- tests/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Qemu-devel] [PATCH 0/2] tests: Fixes for in-tree build

2013-08-20 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Am 20.08.2013 09:47, schrieb arm...@redhat.com: From: Markus Armbruster arm...@redhat.com Markus Armbruster (2): tests: Fix schema parser test for in-tree build tests: Update .gitignore for test-int128 and test-bitops Series Reviewed-by:

[Qemu-devel] [PATCH v2 0/2] tests: Fixes for in-tree build

2013-08-20 Thread armbru
From: Markus Armbruster arm...@redhat.com v2: Nominate for qemu-stable (Andreas) Markus Armbruster (2): tests: Fix schema parser test for in-tree build tests: Update .gitignore for test-int128 and test-bitops tests/.gitignore | 3 +++ tests/Makefile | 8 2 files changed, 7

Re: [Qemu-devel] [PATCH 0/3] target-ppc: Add support for dumping guest memory using qemu gdb server

2013-08-20 Thread Andreas Färber
Am 20.08.2013 10:19, schrieb Aneesh Kumar K.V: Andreas Färber afaer...@suse.de writes: Hi Aneesh, Am 19.08.2013 14:29, schrieb Aneesh Kumar K.V: This patch series implement support for dumping guest memory using qemu gdb server. I had a quick look through but will leave in-depth review

Re: [Qemu-devel] [PATCH] target-i386: Only provide CMOV and friends if feature bit set

2013-08-20 Thread Peter Maydell
Ping^2! This has been reviewed and I've checked that the patch still applies to master. thanks -- PMM On 25 July 2013 17:54, Peter Maydell peter.mayd...@linaro.org wrote: Ping! (patchwork url: http://patchwork.ozlabs.org/patch/259148/) thanks -- PMM On 15 July 2013 18:21, Peter Maydell

Re: [Qemu-devel] [PATCH] hw/openrisc/openrisc_sim: Avoid using uninitialised variable 'entry'

2013-08-20 Thread Peter Maydell
Ping for qemu-trivial now 1.7 is open. thanks -- PMM On 5 August 2013 19:24, Peter Maydell peter.mayd...@linaro.org wrote: clang warns that cpu_openrisc_load_kernel() can use 'entry' uninitialized: hw/openrisc/openrisc_sim.c:69:9: error: variable 'entry' is used uninitialized whenever

Re: [Qemu-devel] [PATCH] configure: disable clang -Wstring-plus-int warning

2013-08-20 Thread Peter Maydell
Ping for qemu-trivial now 1.7 is open. thanks -- PMM On 5 August 2013 20:16, Peter Maydell peter.mayd...@linaro.org wrote: Some versions of clang will warn about adding integers to strings: disas/i386.c:4753:23: error: adding 'char' to a string does not append to the string

Re: [Qemu-devel] [PATCH 00/14] ARM: make IRQ/FIQ gpio lines on CPU object

2013-08-20 Thread Peter Maydell
On 8 August 2013 17:04, Peter Maydell peter.mayd...@linaro.org wrote: This patch series makes IRQ and FIQ be inbound gpio lines on the ARMCPU object (which we can do now that it is a subclass of DeviceState). This allows us to drop the odd 'arm_pic' shim, which doesn't correspond to real

Re: [Qemu-devel] [PATCH v2 0/4] target-arm: Implement support for generic timers

2013-08-20 Thread Peter Maydell
On 9 August 2013 17:17, Peter Maydell peter.mayd...@linaro.org wrote: This patch series implements support for the 'generic timers', which are a set of timers defined in the ARM Architecture Reference Manual and implemented by the Cortex-A15. We've got away without these up til now because

Re: [Qemu-devel] [PATCH] default-configs: Fix A9MP and A15MP config names

2013-08-20 Thread Peter Maydell
On 9 August 2013 14:50, Peter Maydell peter.mayd...@linaro.org wrote: When individual CONFIG_ switches for the A9MPcore and A15MPcore devices were created, they were inadvertently given incorrect names (CONFIG_ARM9MPCORE and CONFIG_ARM15MPCORE). These CPUs are Cortex-A9MP and Cortex-A15MP, and

Re: [Qemu-devel] [PATCH] hw/openrisc/openrisc_sim: Avoid using uninitialised variable 'entry'

2013-08-20 Thread Jia Liu
Hi Peter, On Tue, Aug 20, 2013 at 9:00 PM, Peter Maydell peter.mayd...@linaro.org wrote: Ping for qemu-trivial now 1.7 is open. Thank you, I'll send a PULL very soon. thanks -- PMM On 5 August 2013 19:24, Peter Maydell peter.mayd...@linaro.org wrote: clang warns that

Re: [Qemu-devel] vm performance degradation after kvm live migration or save-restore with EPT enabled

2013-08-20 Thread Zhanghaoyu (A)
The QEMU command line (/var/log/libvirt/qemu/[domain name].log), LC_ALL=C PATH=/bin:/sbin:/usr/bin:/usr/sbin HOME=/ QEMU_AUDIO_DRV=none /usr/local/bin/qemu-system-x86_64 -name ATS1 -S -M pc-0.12 -cpu qemu32 -enable-kvm -m 12288 -smp 4,sockets=4,cores=1,threads=1 -uuid

Re: [Qemu-devel] [PATCHv11 13/31] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-20 Thread Alex Bligh
On 20 Aug 2013, at 12:19, Wenchao Xia wrote: So it is an undefined value, should avoid use it? It's not an undefined value. It's the value that the poll should wait for subject to modification by the prepare call. -- Alex Bligh

Re: [Qemu-devel] vmdk stream-optimised format

2013-08-20 Thread Alex Bligh
On 20 Aug 2013, at 11:53, Paolo Bonzini wrote: It doesn't look too different from what qemu-img convert -c does, except that you need to use the right -o incantation to specify the format type. Extensive incanting did not produce a result that works. Possibly inadequate haruspication on my

Re: [Qemu-devel] vmdk stream-optimised format

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 15:37, Alex Bligh ha scritto: On 20 Aug 2013, at 11:53, Paolo Bonzini wrote: It doesn't look too different from what qemu-img convert -c does, except that you need to use the right -o incantation to specify the format type. Extensive incanting did not produce a result that

Re: [Qemu-devel] [PATCH v2] monitor: print the invalid char in error message

2013-08-20 Thread Eric Blake
On 08/19/2013 08:58 PM, Fam Zheng wrote: It's more friendly to print which char is invalid to user, especially when user tries to input a float value and expect the monitor to round it to int. Since we don't round float number when we look for a integer, telling which char is invalid is less

Re: [Qemu-devel] Call for agenda for 2013-08-20

2013-08-20 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Hi Please, send any topic that you are interested in covering. Call cancelled. As this was the only topic, and neither Frederik or Konrad are able to attend today, topic got moved to next call in two weeks. Thanks, Juan. Agenda so far: - Talk

Re: [Qemu-devel] [PATCH V8 07/11] NUMA: set guest numa nodes memory policy

2013-08-20 Thread Andrew Jones
- Original Message - Set the guest numa nodes memory policies using the mbind(2) system call node by node. After this patch, we are able to set guest nodes memory policies through the QEMU options, this arms to solve the guest cross nodes memory access performance issue. And as you

[Qemu-devel] [PATCH] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-20 Thread Charlie Shepherd
cow_co_is_allocated and cow_update_bitmap set bits by reading the relevant word, setting the specific bit in it and writing it back. These functions set a number of contiguous bits however, so this is an extremely inefficient way of doing this. This patch converts them to read the whole bitmap

Re: [Qemu-devel] [PATCH V8 00/11] Add support for binding guest numa nodes to host numa nodes

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 03:07, Wanlong Gao ha scritto: -numa node,nodeid=0,cpus=0, \ -numa mem,size=1024M,policy=membind,host-nodes=0-1 \ -numa node,nodeid=1,cpus=1 \ -numa mem,size=1024M,policy=interleave,host-nodes=1 What nodes would the memory be in, for this command line? Does it just compute

Re: [Qemu-devel] [PATCH] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 15:42, Charlie Shepherd ha scritto: cow_co_is_allocated and cow_update_bitmap set bits by reading the relevant word, setting the specific bit in it and writing it back. These functions set a number of contiguous bits however, so this is an extremely inefficient way of doing this.

Re: [Qemu-devel] [Patch] ARM: Simplify and fix imx_epit implementation.

2013-08-20 Thread Peter Maydell
On 5 August 2013 02:27, Peter Chubb peter.ch...@nicta.com.au wrote: When imx_epit.c was last refactored, a common usecase (comparison register zero) broke. This patch fixes that, and simplifies the code yet more. It also fixes a major thinko in the reset path --- the wrong bits in the

Re: [Qemu-devel] [PATCH] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-20 Thread Charlie Shepherd
On 20/08/2013 14:45, Paolo Bonzini wrote: I had very similar patches in my series to add get_block_status... Ah, sorry if I've duplicated something you've already done. Stefan encouraged me to contribute to an area of QEMU I found interesting and seeing the XXX I thought I'd take a shot at

Re: [Qemu-devel] [Patch] ARM: Simplify and fix imx_epit implementation.

2013-08-20 Thread Andreas Färber
Am 20.08.2013 15:46, schrieb Peter Maydell: On 5 August 2013 02:27, Peter Chubb peter.ch...@nicta.com.au wrote: When imx_epit.c was last refactored, a common usecase (comparison register zero) broke. This patch fixes that, and simplifies the code yet more. It also fixes a major thinko in

Re: [Qemu-devel] vmdk stream-optimised format

2013-08-20 Thread Alex Bligh
On 20 Aug 2013, at 14:37, Paolo Bonzini wrote: Yes, because vmdk does not implement bdrv_write_compressed. Sorry for leaving out the small detail. :( Would that be easy for me to fix? -- Alex Bligh

Re: [Qemu-devel] [Patch] ARM: Simplify and fix imx_epit implementation.

2013-08-20 Thread Peter Maydell
On 20 August 2013 15:01, Andreas Färber afaer...@suse.de wrote: Peter Ch., please call such a patch imx_epit: rather than ARM: since it affects only your device. (PMM, can you fix?) Yes, I fixed it to say hw/timer/imx_epit: ... -- PMM

Re: [Qemu-devel] [PATCH V8 00/13] monitor: support sub command group in auto completion and help

2013-08-20 Thread Luiz Capitulino
On Tue, 30 Jul 2013 12:03:11 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: On Fri, 26 Jul 2013 11:20:29 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: This series make auto completion and help functions works normal for sub command, by using reentrant functions. In order to do

Re: [Qemu-devel] [PATCH] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 15:50, Charlie Shepherd ha scritto: On 20/08/2013 14:45, Paolo Bonzini wrote: I had very similar patches in my series to add get_block_status... Ah, sorry if I've duplicated something you've already done. Stefan encouraged me to contribute to an area of QEMU I found interesting

[Qemu-devel] [PULL 08/21] hw/arm/musicpal: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Message-id: 1375977856-25046-8-git-send-email-peter.mayd...@linaro.org --- hw/arm/musicpal.c |4 +--- 1 file changed, 1

[Qemu-devel] [PULL 07/21] hw/arm/kzm: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Message-id: 1375977856-25046-7-git-send-email-peter.mayd...@linaro.org --- hw/arm/kzm.c |8 +++- 1 file changed, 3

[Qemu-devel] [PULL 16/21] target-arm: Allow raw_read() and raw_write() to handle 64 bit regs

2013-08-20 Thread Peter Maydell
Extend the raw_read() and raw_write() helper accessors so that they can be used for 64 bit registers as well as 32 bit registers. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Tested-by: Laurent Desnogues laurent.desnog...@gmail.com Reviewed-by: Edgar E. Iglesias edgar.igles...@gmail.com

[Qemu-devel] [PULL 11/21] hw/arm/strongarm: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Message-id: 1375977856-25046-11-git-send-email-peter.mayd...@linaro.org --- hw/arm/strongarm.c |6 +++--- 1 file changed, 3

[Qemu-devel] [PULL 17/21] target-arm: Support coprocessor registers which do I/O

2013-08-20 Thread Peter Maydell
Add an ARM_CP_IO flag which an ARMCPRegInfo definition can use to indicate that the register's implementation does I/O and thus its accesses need to be surrounded by gen_io_start()/gen_io_end() in order for icount to work. Most notably, cp registers which implement clocks or timers need this.

[Qemu-devel] [PULL 13/21] hw/arm/vexpress: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Message-id: 1375977856-25046-13-git-send-email-peter.mayd...@linaro.org --- hw/arm/vexpress.c |8 ++-- 1 file changed, 2

[Qemu-devel] [PULL 20/21] default-configs: Fix A9MP and A15MP config names

2013-08-20 Thread Peter Maydell
When individual CONFIG_ switches for the A9MPcore and A15MPcore devices were created, they were inadvertently given incorrect names (CONFIG_ARM9MPCORE and CONFIG_ARM15MPCORE). These CPUs are Cortex-A9MP and Cortex-A15MP, and in particular the ARM9 is a different (rather older) CPU than the

[Qemu-devel] [PULL 05/21] hw/arm/highbank: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Message-id: 1375977856-25046-5-git-send-email-peter.mayd...@linaro.org --- hw/arm/highbank.c |4 +--- 1 file changed, 1

[Qemu-devel] [PULL 21/21] hw/timer/imx_epit: Simplify and fix imx_epit implementation

2013-08-20 Thread Peter Maydell
From: Peter Chubb peter.ch...@nicta.com.au When imx_epit.c was last refactored, a common usecase (comparison register zero) broke. This patch fixes that, and simplifies the code yet more. It also fixes a major thinko in the reset path --- the wrong bits in the control register were being

[Qemu-devel] [PULL 01/21] target-arm: Implement 'int' loglevel

2013-08-20 Thread Peter Maydell
The 'int' loglevel for recording interrupts and exceptions requires support in the target-specific code. Implement it for ARM. This improves debug logging in some situations that were otherwise pretty opaque, such as when we fault trying to execute at an exception vector address, which would

[Qemu-devel] [PULL 14/21] hw/arm/xilinx_zynq: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Message-id: 1375977856-25046-14-git-send-email-peter.mayd...@linaro.org --- hw/arm/xilinx_zynq.c |7 ++- 1 file changed, 2

[Qemu-devel] [PULL 15/21] hw/arm/pic_cpu: Remove the now-unneeded arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Now all the boards have been converted arm_pic_init_cpu() is unused and can just be deleted. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Message-id: 1375977856-25046-15-git-send-email-peter.mayd...@linaro.org --- hw/arm/Makefile.objs |2 +- hw/arm/pic_cpu.c | 25

[Qemu-devel] [PULL 19/21] hw/cpu/a15mpcore: Wire generic timer outputs to GIC inputs

2013-08-20 Thread Peter Maydell
Now our A15 CPU implements the generic timers, we can wire them up to the appropriate inputs on the GIC. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Tested-by: Laurent Desnogues laurent.desnog...@gmail.com Message-id: 1376065080-26661-5-git-send-email-peter.mayd...@linaro.org ---

[Qemu-devel] [PULL 09/21] hw/arm/omap*: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Message-id: 1375977856-25046-9-git-send-email-peter.mayd...@linaro.org --- hw/arm/omap1.c |8 hw/arm/omap2.c |8

  1   2   >