On Tue, Aug 27, 2013 at 05:22:19PM -0600, Eric Blake wrote:
On 08/27/2013 11:04 AM, Michael S. Tsirkin wrote:
On Fri, Aug 16, 2013 at 03:18:34PM +0200, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
Currently, we get SeaBIOS defaults: manufacturer Bochs, product Bochs,
Il 28/08/2013 05:26, Lei Li ha scritto:
RAMBlock structs are not visible outside of exec.c and arch_init.c,
how did you do this?
Hi Michael,
Good catch!
Actually this is the 'Known issue' that I listed in the cover
letter, and I planed to ask suggestions on this.
Currently the
Hi,
+static void tcp_chr_detach(CharDriverState *chr)
+{
+TCPCharDriver *s = chr-opaque;
+
+if (s-tag) {
+io_remove_watch_poll(s-tag);
+s-tag = 0;
+}
+}
Lots of simliar functions in the other patches.
Doesn't it make sense to move the tag field from
On 08/27/2013 06:33 PM, Alexander Graf wrote:
On 27.08.2013, at 05:42, Alexey Kardashevskiy wrote:
This has reworked USB OHCI and adds support of USB EHCI,
VIRTIO-SCSI and various fixes (IBM VSCSI, VGA and more).
The full list of fixes is:
* usb-ohci: Convert td-phys every time to
- Original Message -
On 08/23/2013 07:24 AM, Andrew Jones wrote:
The comment in kvm_max_vcpus() states that it's using the recommended
procedure from the kernel API documentation to get the max number
of vcpus that kvm supports. It is, but by always returning the
maximum number
On Tue, Aug 27, 2013 at 11:31:28PM +0200, Paolo Bonzini wrote:
Il 27/08/2013 22:26, Erik Rull ha scritto:
It's more a guess, there must be a
change between 1.2.0 and 1.6.0 that prevents a simple Windows XP from
booting completely, if the guest HDD image is placed on a SSD. On a
rotating
Am 27.08.2013 um 18:07 hat Stefan Weil geschrieben:
Am 27.08.2013 17:56, schrieb Kevin Wolf:
The failing condition is checked immediately before the assertion, so
keeping the assertion is kind of redundant.
Are you sure that it is not the check which is redundant?
Is file == NULL allowed
On Tue, Aug 27, 2013 at 05:55:26PM -0500, Yaodong Yang wrote:
Step 3:
file block.c
function：
static BlockDriverAIOCB *bdrv_co_aio_rw_vector(BlockDriverState *bs,
int64_t sector_num,
QEMUIOVector
-- Forwarded message --
From: she roy she.min@gmail.com
Date: 2013/8/28
Subject: Re: [Qemu-devel] trigger a gpio interrupt inside qemu
To: Max Filippov jcmvb...@gmail.com
I tested qemu_irq_pulse(gPl061-irq); the guest did not generate an
interrupt. so I changed to
Bandan Das b...@redhat.com writes:
Move common defines and structs to a header file.
We will then include these twice in hda-codec.c -
a version with mixer enabled and another with not enabled.
Suggest:
The next commit will include it twice, once for a device with a
mixer, and once
On Tue, Aug 27, 2013 at 09:55:22AM +0100, Alex Bligh wrote:
On 27 Aug 2013, at 09:23, Stefan Hajnoczi wrote:
diff --git a/include/qemu/timer.h b/include/qemu/timer.h
index e4934dd..b58903b 100644
--- a/include/qemu/timer.h
+++ b/include/qemu/timer.h
@@ -115,6 +115,10 @@ static inline
On August 27, 2013 at 11:37 PM Anthony Liguori anth...@codemonkey.ws wrote:
On Aug 27, 2013 4:32 PM, Paolo Bonzini pbonz...@redhat.com wrote:
Il 27/08/2013 22:26, Erik Rull ha scritto:
Hi Stefan,
which BIOS is selected by default?
QEMU only ships with SeaBIOS.
It's more a
On Wed, Aug 28, 2013 at 03:18:39AM +, Xie, Huawei wrote:
I am developing virtio user space poll mode network driver. We allocate vring
physical memory from huge page. On VMs with less than 4GB memory, it works
well. But on VMs with like 8GB memory, huge page are all allocated from high
Implement bdrv_amend_options for compat, size, backing_file, backing_fmt
and lazy_refcounts.
Downgrading images from compat=1.1 to compat=0.10 is achieved through
handling all incompatible flags accordingly, clearing all compatible and
autoclear flags and expanding all zero clusters.
This series adds support to qemu-img, block and qcow2 for amending image
options on existing image files.
Max Reitz (3):
block: Image file option amendment
qcow2: Implement bdrv_amend_options
qemu-iotest: qcow2 image option amendment
block.c| 8 ++
Add tests for qemu-img amend on qcow2 image files.
Signed-off-by: Max Reitz mre...@redhat.com
---
This test is numbered 061 for not interfering with my metadata overlap
checks series (although I will have to adapt my code to those new checks
anyway when/if they are included in master).
---
On (Wed) 28 Aug 2013 [09:09:47], Gerd Hoffmann wrote:
Hi,
+static void tcp_chr_detach(CharDriverState *chr)
+{
+TCPCharDriver *s = chr-opaque;
+
+if (s-tag) {
+io_remove_watch_poll(s-tag);
+s-tag = 0;
+}
+}
Lots of simliar functions in the
On Thu, 2013-08-22 at 15:48 +0300, Marcel Apfelbaum wrote:
This patch follows Markus Armbruster suggestion:
A possibly better way to group help by category: instead of adding
categories to each line, add category headlines, like this:
Controller/Bridge/Hub devices:
name NAME, bus
This patch adds the amend option to qemu-img which allows changing
image options on existing image files. It also adds the generic bdrv
implementation which is basically just a wrapper for the image format
specific function.
Signed-off-by: Max Reitz mre...@redhat.com
---
block.c
On Wed, Aug 28, 2013 at 10:14:04AM +0500, Taimoor Mirza wrote:
I am building QEMU on Windows using MinGW + Msys. If I build QEMU with
Glib 2.28, qemu binary works fine for sdcard. I noticed that QEMU
binary has dependency on libgthread-2.0-0.dll in this case.
But when I build QEMU with Glib
On Sun, 2013-08-25 at 13:23 +0300, Michael S. Tsirkin wrote:
On Thu, Aug 22, 2013 at 08:11:36PM +0300, Marcel Apfelbaum wrote:
usb-tablet device was wrongly assigned to Misc category
Reported-by: Markus Armbruster arm...@redhat.com
Cc: qemu-sta...@nongnu.org
Signed-off-by: Marcel
On 28 August 2013 05:39, Stefan Weil s...@weilnetz.de wrote:
These unimplemented opcodes are handled like illegal opcodes, but
they are used in existing code. We should at least report when they
are executed.
Yeah, seems reasonable. (There might be other unimplemented
bits lurking too but we
On Wed, Aug 28, 2013 at 12:01 PM, she roy she.min@gmail.com wrote:
I tested qemu_irq_pulse(gPl061-irq); the guest did not generate an
interrupt. so I changed to
qemu_set_irq(gPl061-irq, 1);
sleep(1);
qemu_set_irq(gPl061-irq, 0);
A lot of interrupts generated. Is it possible to
PL061 has a register GPIOIS to control if the interrupt is lever-triggered
or edge-triggered, I will try this. Thanks.
2013/8/28 Max Filippov jcmvb...@gmail.com
On Wed, Aug 28, 2013 at 12:01 PM, she roy she.min@gmail.com wrote:
I tested qemu_irq_pulse(gPl061-irq); the guest did not
On 1 July 2013 04:30, Mike Frysinger vap...@gentoo.org wrote:
This avoids needing to execute a program and keeping an (incomplete)
list when cross-compiling.
Signed-off-by: Mike Frysinger vap...@gentoo.org
This fixes mipsel cross compiling. I also checked it detected a mips
(be) compiler as
On 28 August 2013 09:01, she roy she.min@gmail.com wrote:
qemu_set_irq(gPl061-irq, 1);
sleep(1);
qemu_set_irq(gPl061-irq, 0);
Never call sleep() inside a qemu device implementation:
this will just make the whole of QEMU (including the guest)
stop running.
-- PMM
On 27/08/13 19:39, Richard Henderson wrote:
On 08/27/2013 09:02 AM, James Hogan wrote:
The configure script was setting HOST_WORDS_BIGENDIAN for all $cpu =
mips|mips64 when cross compiling, since endianness cannot be detected by
running a test program. This includes little endian MIPS though.
Thanks!
2013/8/28 Peter Maydell peter.mayd...@linaro.org
On 28 August 2013 09:01, she roy she.min@gmail.com wrote:
qemu_set_irq(gPl061-irq, 1);
sleep(1);
qemu_set_irq(gPl061-irq, 0);
Never call sleep() inside a qemu device implementation:
this will just make the whole of QEMU
On Wed, Aug 28, 2013 at 12:19 PM, she roy she.min@gmail.com wrote:
PL061 has a register GPIOIS to control if the interrupt is lever-triggered
or edge-triggered, I will try this. Thanks.
This register defines which event on the GPIO side causes PL061 to
generate IRQ. The IRQ it generates is
On 27/08/13 20:48, Richard Henderson wrote:
On 08/27/2013 09:48 AM, Yongbok Kim wrote:
#if 0
-qemu_log(TARGET_FMT_lx %d %d = TARGET_FMT_lx %d (%d)\n,
+qemu_log(TARGET_FMT_lx %d %d = % HWADDR_PRIx %d (%d)\n,
address, rw, access_type, *physical, *prot, ret);
#endif
On Wed, Aug 28, 2013 at 12:27 PM, Max Filippov jcmvb...@gmail.com wrote:
On Wed, Aug 28, 2013 at 12:19 PM, she roy she.min@gmail.com wrote:
PL061 has a register GPIOIS to control if the interrupt is lever-triggered
or edge-triggered, I will try this. Thanks.
This register defines which
On Wed, Aug 28, 2013 at 11:25:33AM +0800, Wenchao Xia wrote:
+void aio_context_release(AioContext *ctx)
+{
+qemu_mutex_lock(ctx-acquire_lock);
+assert(ctx-owner qemu_thread_is_self(ctx-owner));
+ctx-owner = NULL;
+qemu_cond_signal(ctx-acquire_cond);
+
On 2013/8/27 21:49, Kevin Wolf wrote:
Am 13.08.2013 um 06:31 hat Dong Xu Wang geschrieben:
qemu_opts_print has no user now, so can re-write the function safely.
qemu_opts_print is used while using qemu-img create, it
produces the same output as previous code.
The behavior of this function has
On 2013/8/28 7:13, Eric Blake wrote:
On 08/27/2013 08:12 AM, Kevin Wolf wrote:
Am 13.08.2013 um 06:32 hat Dong Xu Wang geschrieben:
QMP command query-command-line-options shows details information of
parameters, since added def_value_str, also output it in the QMP
command.
v16-v17:
1) add
On August 28, 2013 at 9:50 AM Stefan Hajnoczi stefa...@gmail.com wrote:
On Tue, Aug 27, 2013 at 11:31:28PM +0200, Paolo Bonzini wrote:
Il 27/08/2013 22:26, Erik Rull ha scritto:
It's more a guess, there must be a
change between 1.2.0 and 1.6.0 that prevents a simple Windows XP from
Bandan Das b...@redhat.com writes:
Currently, hda-codec mixer emulation can only be enabled by using the
--enable-mixemu option to configure at compile time. These patches add
the option to make it configurable at runtime as well.
An example usage could be a qemu cmdline :
-device
Am 23.08.2013 um 18:35 hat Peter Maydell geschrieben:
The expression 1LL 63 tries to shift the 1 into the sign bit of a
'long long', which provokes a clang sanitizer warning:
runtime error: left shift of 1 by 63 places cannot be represented in type
'long long'
Use 1ULL 63 as the
Hi Stefan:
I think you mention the descriptor address? I mean the vring PFN register.
/* A 32-bit r/w PFN for the currently selected queue */
#define VIRTIO_PCI_QUEUE_PFN8
And the linux driver sample code:
iowrite32(virt_to_phys(info-queue) VIRTIO_PCI_QUEUE_ADDR_SHIFT,
On Mon, Aug 26, 2013 at 07:43:41PM +0300, Michael S. Tsirkin wrote:
From: yinyin yin@cs2c.com.cn
virtqueue_get_avail_bytes: when found a indirect desc, we need loop over it.
/* loop over the indirect descriptor table */
indirect = 1;
max =
PAPR+ requires two RTAS calls to be supported by the hypervisor in
order to allow hotplugging VCPUs from the guest. The start-cpu RTAS
call was already there but stop-self was not.
This adds the stop-self RTAS call.
Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru
---
Changes:
v2:
*
I tried to set GPIOIC in the ISR, but the result was the same, a lot of
interrupts generated. I guess it is because I call
qemu_set_irq(gPl061-irq, 1);
sleep(1);
qemu_set_irq(gPl061-irq, 0);
in a thread I created. And I don't know how to call these functions in a
qemu thread.
2013/8/28
On 08/22/2013 09:29 PM, Alexey Kardashevskiy wrote:
I made a couple of small patches while debugging VFIO on SPAPR
which uses IOMMU MemoryRegion 2^64 bytes long.
Changes:
v3:
* int128: add int128_exts64() updated
v2:
* added int128_exts64() function as a separate patch and used in
Am 28.08.2013 um 10:08 hat Max Reitz geschrieben:
This patch adds the amend option to qemu-img which allows changing
image options on existing image files. It also adds the generic bdrv
implementation which is basically just a wrapper for the image format
specific function.
Signed-off-by:
If this is the case, one possible fix would be:
Write two continuous 32bit DWORD to combine a 64bit address
Use the upper 12 bits of PFN val to indicate if it is combined write
In this way, we wouldn't break other virtio driver, register layout and only
need a few lines of
On 08/27/2013 12:32 AM, Andreas Färber wrote:
Am 26.08.2013 15:04, schrieb Alexander Graf:
On 19.08.2013, at 06:06, Alexey Kardashevskiy wrote:
IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and
a CPU version in lower 16 bits. Since there is no significant change
in
Am 28.08.2013 12:31, schrieb Alexey Kardashevskiy:
On 08/27/2013 12:32 AM, Andreas Färber wrote:
Am 26.08.2013 15:04, schrieb Alexander Graf:
On 19.08.2013, at 06:06, Alexey Kardashevskiy wrote:
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 13b290c..dfe398d
IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and
a CPU version in lower 16 bits. Since there is no significant change
in behavior between versions, there is no point to add every single CPU
version in QEMU's CPU list. Also, new CPU versions of already supported
CPU won't
On 08/20/13 13:43, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
v2: Nominate for qemu-stable (Andreas)
Markus Armbruster (2):
tests: Fix schema parser test for in-tree build
tests: Update .gitignore for test-int128 and test-bitops
tests/.gitignore | 3 +++
On 08/21/13 12:41, Laszlo Ersek wrote:
v1-v2:
- added comment to raw_probe() [Kevin]
- fixed raw_reopen_prepare() [Paolo Kevin]
- keeping BSDL: according to the v1 discussion, LGPLv2+ could work too,
but but most of the block layer is BSD [Paolo] and I haven't been
clearly instructed to
Am 28.08.2013 12:37, schrieb Alexey Kardashevskiy:
IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and
a CPU version in lower 16 bits. Since there is no significant change
in behavior between versions, there is no point to add every single CPU
version in QEMU's CPU list.
On 28 August 2013 10:33, she roy she.min@gmail.com wrote:
I tried to set GPIOIC in the ISR, but the result was the same, a lot of
interrupts generated. I guess it is because I call
qemu_set_irq(gPl061-irq, 1);
sleep(1);
qemu_set_irq(gPl061-irq, 0);
in a thread I created. And I don't
On 08/28/2013 08:49 PM, Andreas Färber wrote:
Am 28.08.2013 12:37, schrieb Alexey Kardashevskiy:
IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and
a CPU version in lower 16 bits. Since there is no significant change
in behavior between versions, there is no point to add
On Mon, Jul 22, 2013 at 03:54:18PM +0200, Paolo Bonzini wrote:
This fixes endianness bugs in I/O port access.
It looks like it actually did the reverse, ie introducing endianness
bugs. With this patch, the pcnet-pci NIC (default NIC card) doesn't work
any more on big endian Malta, while it still
Am 28.08.2013 um 10:08 hat Max Reitz geschrieben:
Implement bdrv_amend_options for compat, size, backing_file, backing_fmt
and lazy_refcounts.
Downgrading images from compat=1.1 to compat=0.10 is achieved through
handling all incompatible flags accordingly, clearing all compatible and
Il 27/08/2013 23:37, Anthony Liguori ha scritto:
On Aug 27, 2013 4:32 PM, Paolo Bonzini pbonz...@redhat.com
mailto:pbonz...@redhat.com wrote:
Il 27/08/2013 22:26, Erik Rull ha scritto:
Hi Stefan,
which BIOS is selected by default?
QEMU only ships with SeaBIOS.
It's more a guess,
Il 28/08/2013 11:13, Markus Armbruster ha scritto:
1. Why is CONFIG_MIXEMU off by default?
We generally default optional code to on, to avoid bit-rot. We
make exceptions only when the optional code is truly unwanted by a
clear majority of our users. Why would anyone want hda audio
Il 28/08/2013 11:46, Alexey Kardashevskiy ha scritto:
On 08/22/2013 09:29 PM, Alexey Kardashevskiy wrote:
I made a couple of small patches while debugging VFIO on SPAPR
which uses IOMMU MemoryRegion 2^64 bytes long.
Changes:
v3:
* int128: add int128_exts64() updated
v2:
* added
On Do, 2013-08-22 at 20:11 +0300, Marcel Apfelbaum wrote:
usb-tablet device was wrongly assigned to Misc category
Added to usb patch queue.
thanks,
Gerd
On Wed, Aug 28, 2013 at 01:03:01PM +0200, Aurelien Jarno wrote:
On Mon, Jul 22, 2013 at 03:54:18PM +0200, Paolo Bonzini wrote:
This fixes endianness bugs in I/O port access.
It looks like it actually did the reverse, ie introducing endianness
bugs. With this patch, the pcnet-pci NIC
Hi Stefan,
Thanks for your reply. Below are answers
$ grep CONFIG_COROUTINE_BACKEND config-host.mak
CONFIG_COROUTINE_BACKEND=win32
(gdb) r
Starting program: C:\tools\qemu\qemu-system-arm.exe
-M realview-eb -m 256 -kernel DebugKD2.out -sd fat:16:rw:C:\\testCard
[New Thread 3836.0x404]
[New
Il 28/08/2013 13:13, Aurelien Jarno ha scritto:
On Wed, Aug 28, 2013 at 01:03:01PM +0200, Aurelien Jarno wrote:
On Mon, Jul 22, 2013 at 03:54:18PM +0200, Paolo Bonzini wrote:
This fixes endianness bugs in I/O port access.
It looks like it actually did the reverse, ie introducing endianness
Hi,
Only pulse and the spice audio backends set VOICE_VOLUME_CAP.
Impact on users isn't obvious to me.
It offloads volume control to the audio backend, i.e. it will be done by
pulseaudio/spice-client instead of mixemu.
Questions (not just for you, Bandan):
1. Why is CONFIG_MIXEMU
We don't need to worry about the listening socket for this patchset,
should we then just keep that in the tcp struct, and use the tag as
the generic one in CharDriverState for all of the backends?
Yes, I think that will simplify the series. And maybe name the one one
in CharDriverState
Hi,
Am 28.08.2013 13:06, schrieb Kevin Wolf:
Am 28.08.2013 um 10:08 hat Max Reitz geschrieben:
Implement bdrv_amend_options for compat, size, backing_file, backing_fmt
and lazy_refcounts.
Downgrading images from compat=1.1 to compat=0.10 is achieved through
handling all incompatible flags
Am 28.08.2013 um 10:08 hat Max Reitz geschrieben:
Add tests for qemu-img amend on qcow2 image files.
Signed-off-by: Max Reitz mre...@redhat.com
---
This test is numbered 061 for not interfering with my metadata overlap
checks series (although I will have to adapt my code to those new checks
On 08/28/13 11:22, Xie, Huawei wrote:
Hi Stefan:
I think you mention the descriptor address? I mean the vring PFN register.
/* A 32-bit r/w PFN for the currently selected queue */
#define VIRTIO_PCI_QUEUE_PFN 8
And the linux driver sample code:
iowrite32(virt_to_phys(info-queue)
(qemu-devel CC'd)
On 08/28/13 12:35, Gary Ching-Pang Lin wrote:
Hi,
I recently updated qemu to 1.6.0 and found OVMF just showed a blank
screen when kvm was enabled. I tried to dump OVMF log with the
following commond but nothing was stored in debug.log.
qemu-system-x86_64 -s -enable-kvm
Gerd Hoffmann kra...@redhat.com writes:
Hi,
Only pulse and the spice audio backends set VOICE_VOLUME_CAP.
Impact on users isn't obvious to me.
It offloads volume control to the audio backend, i.e. it will be done by
pulseaudio/spice-client instead of mixemu.
Questions (not just
Am 28.08.2013 13:40, schrieb Kevin Wolf:
Am 28.08.2013 um 10:08 hat Max Reitz geschrieben:
Add tests for qemu-img amend on qcow2 image files.
Signed-off-by: Max Reitz mre...@redhat.com
---
This test is numbered 061 for not interfering with my metadata overlap
checks series (although I will
Am 28.08.2013 um 13:39 hat Max Reitz geschrieben:
+/* clear incompatible features */
+if (s-incompatible_features QCOW2_INCOMPAT_DIRTY) {
+BdrvCheckResult result;
+ret = qcow2_check(bs, result, BDRV_FIX_ERRORS);
+if (ret 0) {
+return ret;
+
Am 28.08.2013 13:45, schrieb Laszlo Ersek:
(qemu-devel CC'd)
On 08/28/13 12:35, Gary Ching-Pang Lin wrote:
Hi,
I recently updated qemu to 1.6.0 and found OVMF just showed a blank
screen when kvm was enabled. I tried to dump OVMF log with the
following commond but nothing was stored in
Hi,
2. Why do we bother providing these devices when CONFIG_MIXEMU off?
Why would anyone want hda audio devices without a mixer? Why
wouldn't anyone who wants hda audio devices also want CONFIG_MIXEMU
enabled?
It'll actually work just fine with HDA. The guest figures
Am 28.08.2013 um 13:47 hat Max Reitz geschrieben:
Am 28.08.2013 13:40, schrieb Kevin Wolf:
Am 28.08.2013 um 10:08 hat Max Reitz geschrieben:
Add tests for qemu-img amend on qcow2 image files.
Signed-off-by: Max Reitz mre...@redhat.com
---
This test is numbered 061 for not interfering with
If PFLASH_DEBUG is enabled then we have some build errors:
hw/block/pflash_cfi02.c: In function ‘pflash_timer’:
hw/block/pflash_cfi02.c:128:5: error: expected ‘)’ before string constant
hw/block/pflash_cfi02.c:128:5: error: too few arguments to function ‘fprintf’
This patch fixes the problem.
Hi,
Am 28.08.2013 13:48, schrieb Kevin Wolf:
Am 28.08.2013 um 13:39 hat Max Reitz geschrieben:
+/* clear incompatible features */
+if (s-incompatible_features QCOW2_INCOMPAT_DIRTY) {
+BdrvCheckResult result;
+ret = qcow2_check(bs, result, BDRV_FIX_ERRORS);
+if
Hi,
Am 28.08.2013 13:54, schrieb Kevin Wolf:
Am 28.08.2013 um 13:47 hat Max Reitz geschrieben:
Am 28.08.2013 13:40, schrieb Kevin Wolf:
Am 28.08.2013 um 10:08 hat Max Reitz geschrieben:
Add tests for qemu-img amend on qcow2 image files.
Signed-off-by: Max Reitz mre...@redhat.com
---
This
On 08/28/13 13:49, Andreas Färber wrote:
Am 28.08.2013 13:45, schrieb Laszlo Ersek:
(qemu-devel CC'd)
On 08/28/13 12:35, Gary Ching-Pang Lin wrote:
Hi,
I recently updated qemu to 1.6.0 and found OVMF just showed a blank
screen when kvm was enabled. I tried to dump OVMF log with the
Am 28.08.2013 um 14:05 hat Max Reitz geschrieben:
Hi,
Am 28.08.2013 13:48, schrieb Kevin Wolf:
Am 28.08.2013 um 13:39 hat Max Reitz geschrieben:
+/* clear incompatible features */
+if (s-incompatible_features QCOW2_INCOMPAT_DIRTY) {
+BdrvCheckResult result;
+ret =
Now that the memory subsystem is propagating the endianness correctly,
the pcnet-pci device should have its I/O ports and MMIO memory marked
as LITTLE_ENDIAN, as PCI devices are little endian.
This makes the pcnet-pci NIC to work again on big endian MIPS Malta
(default NIC).
Cc:
On 28/08/13 13:45, Laszlo Ersek wrote:
On 08/28/13 11:22, Xie, Huawei wrote:
Hi Stefan:
I think you mention the descriptor address? I mean the vring PFN register.
/* A 32-bit r/w PFN for the currently selected queue */
#define VIRTIO_PCI_QUEUE_PFN 8
And the linux driver sample code:
On 08/28/2013 02:08 AM, Max Reitz wrote:
This patch adds the amend option to qemu-img which allows changing
image options on existing image files. It also adds the generic bdrv
implementation which is basically just a wrapper for the image format
specific function.
+
+@item amend [-f
Am 28.08.2013 um 14:22 hat Eric Blake geschrieben:
On 08/28/2013 02:08 AM, Max Reitz wrote:
This patch adds the amend option to qemu-img which allows changing
image options on existing image files. It also adds the generic bdrv
implementation which is basically just a wrapper for the image
All the backends implement an io watcher tag for callbacks. Move it to
CharDriverState from each backend's struct to make accessing the tag from
backend-neutral functions easier.
This will be used later to cancel a callback on chardev detach from a
frontend.
CC: qemu-sta...@nongnu.org
This deduplicates code used a lot of times.
CC: qemu-sta...@nongnu.org
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 62 +++--
1 file changed, 19 insertions(+), 43 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index
This series fixes a segfault when a frontend is detached from a
chardev while the chardev had a pending callback registered. Further
details in patch 3.
Please review.
v2:
* Move tag property to CharDriverState to simplify everything (Gerd)
Amit Shah (3):
char: move backends' io watch tag
If a frontend device releases the chardev (via unplug), the chr handlers
are set to NULL via qdev's exit callbacks invoking
qemu_chr_add_handlers(). If the chardev had a pending operation, a
callback will be invoked, which will try to access data in the
just-released frontend, causing a segfault.
On Mi, 2013-08-28 at 17:59 +0530, Amit Shah wrote:
This series fixes a segfault when a frontend is detached from a
chardev while the chardev had a pending callback registered. Further
details in patch 3.
Nice.
Reviewed-by: Gerd Hoffmann kra...@redhat.com
cheers,
Gerd
On 08/28/2013 01:45 AM, Andrew Jones wrote:
What I'm more worried about is what number is libvirt supposed to show
to the end user, and should libvirt enforce the lower recommended max,
or the larger kernel absolute max? Which of the two values does the QMP
'MachineInfo' type return in its
All the backends implement an io watcher tag for callbacks. Move it to
CharDriverState from each backend's struct to make accessing the tag from
backend-neutral functions easier.
This will be used later to cancel a callback on chardev detach from a
frontend.
CC: qemu-sta...@nongnu.org
This series fixes a segfault when a frontend is detached from a
chardev while the chardev had a pending callback registered. Further
details in patch 3.
Please review.
v3:
* fix whitespace issues in patch 1
v2:
* Move tag property to CharDriverState to simplify everything (Gerd)
Amit Shah
If a frontend device releases the chardev (via unplug), the chr handlers
are set to NULL via qdev's exit callbacks invoking
qemu_chr_add_handlers(). If the chardev had a pending operation, a
callback will be invoked, which will try to access data in the
just-released frontend, causing a segfault.
On (Wed) 28 Aug 2013 [14:33:13], Gerd Hoffmann wrote:
On Mi, 2013-08-28 at 17:59 +0530, Amit Shah wrote:
This series fixes a segfault when a frontend is detached from a
chardev while the chardev had a pending callback registered. Further
details in patch 3.
Nice.
Reviewed-by: Gerd
This deduplicates code used a lot of times.
CC: qemu-sta...@nongnu.org
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 62 +++--
1 file changed, 19 insertions(+), 43 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index
From: James Hogan james.ho...@imgtec.com
Commit a427338 (mips_malta: correct reading MIPS revision at 0x1fc00010)
altered the behaviour of the monitor flash mapping at the reset address
by making it read only. However this causes data bus error exceptions
when it is written to since it is
Hi,
Result of the most recent usb debugging session. Some tracing
improvements and bugfixes for xhci, uas and the usb hub.
please review,
Gerd
Gerd Hoffmann (10):
xhci: remove leftover debug printf
xhci: add tracepoint for endpoint state changes
xhci: add port to slot_address
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/hcd-xhci.c | 2 +-
trace-events | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 83161b9..4d693bc 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -2135,7
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/dev-uas.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c
index 63ad12e..8701292 100644
--- a/hw/usb/dev-uas.c
+++ b/hw/usb/dev-uas.c
@@ -113,6 +113,9 @@ struct
Cc: qemu-sta...@nongnu.org
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/hcd-xhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 4d693bc..3826979 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -1274,7
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/hcd-xhci.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index be6b86e..57c06e7 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -1164,8 +1164,6 @@ static XHCIStreamContext
Cc: qemu-sta...@nongnu.org
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/hcd-xhci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 2e2eb55..10c938a 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -2123,6 +2123,7 @@ static
1 - 100 of 261 matches
Mail list logo
