Re: [Qemu-devel] [PATCH V3 0/7] export internal snapshot by qemu-nbd

2013-09-30 Thread Wenchao Xia
于 2013/9/26 8:16, Wenchao Xia 写道: This series allow user to read internal snapshot's contents without qemu-img convert. V2: Address Stefan's comments: 02: add 'fall through' comments in the case statement. 03: add doc about the difference of internal snapshot and backing chain

Re: [Qemu-devel] help me with qemu-img theory(snapshot and backing file)

2013-09-30 Thread Fam Zheng
On Mon, 09/30 12:48, yue-kvm wrote: hi,all if there any documents about snapshot and backing file's theory. as we know vmware has composor which can upgrade images(top of backing chain ) by upgrading backing file What does upgrade images mean? Thanks, Fam

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td

2013-09-30 Thread Gerd Hoffmann
Hi, While the actual interesting change (adding break) looks correct, and the whole thing is trivial indeed, this area has a maintainer, -- Cc'ing Gerd for this. If he's okay I'll pick it up. Patch is fine. Acked-by: Gerd Hoffmann kra...@gmail.com cheers, Gerd

[Qemu-devel] [PATCH] qcow2: Correct endianness in overlap check

2013-09-30 Thread Max Reitz
If an inactive L1 table is loaded from disk, its entries are in big endian and have to be converted to host byte order before using them. Signed-off-by: Max Reitz mre...@redhat.com --- block/qcow2-refcount.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH] qcow2: CHECK_OFLAG_COPIED is obsolete

2013-09-30 Thread Max Reitz
CHECK_OFLAG_COPIED as a parameter to check_refcounts_l1 and check_refcounts_l2 is obselete now, since the OFLAG_COPIED consistency check is actually no longer performed by these functions (but by check_oflag_copied). Signed-off-by: Max Reitz mre...@redhat.com --- block/qcow2-refcount.c | 4 +---

Re: [Qemu-devel] drive-backup locks VM if target has issues?

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 00:46, Wolfgang Richter ha scritto: I wanted to explore overhead with the new drive-backup command and I noticed if I set the target to something like '/dev/null' the guest VM starts having IO errors and loses write access to its root file system. Here is the qmp-shell command

Re: [Qemu-devel] [PATCH v6 00/26] qemu: generate acpi tables for the guest

2013-09-30 Thread Gerd Hoffmann
On So, 2013-09-29 at 13:58 +0300, Michael S. Tsirkin wrote: This code can also be found here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi Reviewed-and-tested-by: Gerd Hoffmann kra...@redhat.com cheers, Gerd

Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: Remove unused assignment (fixes warning from clang)

2013-09-30 Thread Kevin Wolf
Am 29.09.2013 um 22:15 hat Stefan Weil geschrieben: Am 29.09.2013 21:44, schrieb Michael Tokarev: 28.09.2013 13:55, Stefan Weil wrote: [...] diff --git a/blockdev.c b/blockdev.c index 8aa66a9..8c83f6f 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1926,7 +1926,6 @@ void

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td

2013-09-30 Thread Michael Tokarev
30.09.2013 10:32, Gerd Hoffmann wrote: Hi, While the actual interesting change (adding break) looks correct, and the whole thing is trivial indeed, this area has a maintainer, -- Cc'ing Gerd for this. If he's okay I'll pick it up. Patch is fine. No, I didn't ask whenever the patch is

[Qemu-devel] Minimal Qemu build for Plan9

2013-09-30 Thread Ashish Kaila
Hi, I am a graduate student from CMU and currently working on trying to port Qemu on plan9. I was trying to initially build a minimal Qemu with the least set of devices that are necessary to support a machine, however I noticed that I couldn't understand some of the dependencies such as

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-30 Thread liu ping fan
On Sun, Sep 29, 2013 at 12:15 PM, Michael S. Tsirkin m...@redhat.com wrote: On Sun, Sep 29, 2013 at 11:49:41AM +0800, liu ping fan wrote: On Sun, Sep 29, 2013 at 3:56 AM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Sep 12, 2013 at 11:25:15AM +0800, Liu Ping Fan wrote: On PC, IRQ2/8 can

Re: [Qemu-devel] [PATCH v5 1/5] hpet: inverse polarity when pin above ISA_NUM_IRQS

2013-09-30 Thread liu ping fan
On Sun, Sep 29, 2013 at 12:20 PM, Michael S. Tsirkin m...@redhat.com wrote: On Sun, Sep 29, 2013 at 11:25:24AM +0800, liu ping fan wrote: On Sun, Sep 29, 2013 at 3:52 AM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Sep 12, 2013 at 11:25:14AM +0800, Liu Ping Fan wrote: According to hpet

Re: [Qemu-devel] [PATCH] qcow2: Correct endianness in overlap check

2013-09-30 Thread Kevin Wolf
Am 30.09.2013 um 08:59 hat Max Reitz geschrieben: If an inactive L1 table is loaded from disk, its entries are in big endian and have to be converted to host byte order before using them. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com Sounds like there's

Re: [Qemu-devel] [PATCH] qcow2: CHECK_OFLAG_COPIED is obsolete

2013-09-30 Thread Kevin Wolf
Am 30.09.2013 um 09:21 hat Max Reitz geschrieben: CHECK_OFLAG_COPIED as a parameter to check_refcounts_l1 and check_refcounts_l2 is obselete now, since the OFLAG_COPIED consistency check is actually no longer performed by these functions (but by check_oflag_copied). Signed-off-by: Max Reitz

Re: [Qemu-devel] [PATCH] qcow2: Correct endianness in overlap check

2013-09-30 Thread Max Reitz
On 2013-09-30 10:06, Kevin Wolf wrote: Am 30.09.2013 um 08:59 hat Max Reitz geschrieben: If an inactive L1 table is loaded from disk, its entries are in big endian and have to be converted to host byte order before using them. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-30 Thread Marcel Apfelbaum
On Sun, 2013-09-29 at 18:06 +0300, Michael S. Tsirkin wrote: On Sun, Sep 29, 2013 at 05:40:54PM +0300, Marcel Apfelbaum wrote: Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices should not call directly qemu_set_irq and specify the INTx

Re: [Qemu-devel] qemu, numa: non-contiguous cpusets

2013-09-30 Thread Daniel P. Berrange
On Sun, Sep 29, 2013 at 05:10:44PM +0200, Borislav Petkov wrote: Btw, while I got your attention, on a not-really related topic: how do we feel about adding support for specifying a non-contiguous set of cpus for a numa node in qemu with the -numa option? I.e., like this, for example:

Re: [Qemu-devel] [PATCH] exec: Fix prototype of phys_mem_set_alloc and related functions

2013-09-30 Thread Markus Armbruster
Stefan Weil s...@weilnetz.de writes: phys_mem_alloc and its assigned values qemu_anon_ram_alloc and legacy_s390_alloc must have identical argument lists. legacy_s390_alloc uses the size parameter to call mmap, so size_t is good enough for all of them. This patch fixes compiler errors on

Re: [Qemu-devel] [PATCH v3 for 1.6 0/8] Guest memory allocation fixes cleanup

2013-09-30 Thread Markus Armbruster
Stefan Weil s...@weilnetz.de writes: Am 31.07.2013 15:11, schrieb Markus Armbruster: All I wanted to do is exit(1) instead of abort() on guest memory allocation failure [07/08]. But that lead me into a minor #ifdef bog, and here's what I brought back. Enjoy! Testing: * Christian

Re: [Qemu-devel] [PATCH v2 2/7] smbios: Convert to QemuOpts

2013-09-30 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Fri, Aug 16, 2013 at 03:18:29PM +0200, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com So that it can be set in config file for -readconfig. This tightens parsing of -smbios, and makes it more consistent with other options:

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3 1/2] tests: Fix schema parser test for in-tree build

2013-09-30 Thread Markus Armbruster
Michael Tokarev m...@tls.msk.ru writes: 24.09.2013 11:43, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com Commit 4f193e3 added the test, but screwed up in-tree builds (SRCDIR=.): the tests's output overwrites the expected output, and is thus compared to itself. []

Re: [Qemu-devel] KVM call for agenda for 2013-10-01

2013-09-30 Thread Orit Wasserman
On 09/24/2013 05:09 PM, Juan Quintela wrote: Hi Please, send any topic that you are interested in covering. Last week I forgot to send the call for topics. We still have a topic there. Thanks, Juan. Agenda so far: - Talk about qemu reverse executing (1st description was done this

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 11:14:56AM +0300, Marcel Apfelbaum wrote: On Sun, 2013-09-29 at 18:06 +0300, Michael S. Tsirkin wrote: On Sun, Sep 29, 2013 at 05:40:54PM +0300, Marcel Apfelbaum wrote: Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 10:58, Michael S. Tsirkin ha scritto: As a next step, can we make pci_set_irq non-inline and make it call pci_irq_handler directly, and get rid of the irq field? What irq field? /* IRQ objects for the INTA-INTD pins. */ qemu_irq *irq; That's still used by

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 04:02:29PM +0800, liu ping fan wrote: On Sun, Sep 29, 2013 at 12:15 PM, Michael S. Tsirkin m...@redhat.com wrote: On Sun, Sep 29, 2013 at 11:49:41AM +0800, liu ping fan wrote: On Sun, Sep 29, 2013 at 3:56 AM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Sep

Re: [Qemu-devel] qemu, numa: non-contiguous cpusets

2013-09-30 Thread Paolo Bonzini
Il 29/09/2013 17:10, Borislav Petkov ha scritto: Btw, while I got your attention, on a not-really related topic: how do we feel about adding support for specifying a non-contiguous set of cpus for a numa node in qemu with the -numa option? I.e., like this, for example:

Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool

2013-09-30 Thread Stefan Hajnoczi
On Fri, Sep 27, 2013 at 06:49:18PM +0200, Stefan Weil wrote: Am 27.09.2013 11:11, schrieb Stefan Hajnoczi: On Fri, Sep 27, 2013 at 07:20:21AM +0200, Stefan Weil wrote: Am 11.09.2013 16:42, schrieb Stefan Hajnoczi: The 'gthread' coroutine backend was written before the freelist (aka pool)

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 11:06, Michael S. Tsirkin ha scritto: On Mon, Sep 30, 2013 at 04:02:29PM +0800, liu ping fan wrote: On Sun, Sep 29, 2013 at 12:15 PM, Michael S. Tsirkin m...@redhat.com wrote: On Sun, Sep 29, 2013 at 11:49:41AM +0800, liu ping fan wrote: On Sun, Sep 29, 2013 at 3:56 AM, Michael

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 11:02:06AM +0200, Paolo Bonzini wrote: Il 30/09/2013 10:58, Michael S. Tsirkin ha scritto: As a next step, can we make pci_set_irq non-inline and make it call pci_irq_handler directly, and get rid of the irq field? What irq field? /* IRQ objects for the

[Qemu-devel] [PATCH 1/9] roms: add 'make clean'

2013-09-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a/roms/Makefile b/roms/Makefile index 7a228ae..b646060 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -75,3 +75,10 @@ efi-rom-%: ipxe/src/config/local/general.h

[Qemu-devel] [PULL 0/9] roms: various build improvements

2013-09-30 Thread Gerd Hoffmann
Hi, Here is a collection of improvements for rom building: Proper support for parallel builds, more build targets, initial support for cross builds (some targets only). please pull, Gerd The following changes since commit 53d09b761f032f50c4424e8649396a9041070bae: linux-user: Handle

[Qemu-devel] [PATCH 5/9] roms: rewrite scripts/refresh-pxe-roms.sh

2013-09-30 Thread Gerd Hoffmann
Just use the Makefile in roms/ Signed-off-by: Gerd Hoffmann kra...@redhat.com --- scripts/refresh-pxe-roms.sh | 80 - 1 file changed, 6 insertions(+), 74 deletions(-) diff --git a/scripts/refresh-pxe-roms.sh b/scripts/refresh-pxe-roms.sh index

[Qemu-devel] [PATCH 6/9] roms: add rules to build slof

2013-09-30 Thread Gerd Hoffmann
Add some logic to detect cross compilers. Add support for make slof, which should JustWork[tm] if you are on a ppx64 machine or have a ppc64 cross compiler installed somewhere in your path. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile | 22 ++ 1 file

[Qemu-devel] [PATCH 8/9] roms: enable parallel seabios / seavgabios builds

2013-09-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile | 29 ++- roms/{config.vga.cirrus = config.vga-cirrus} | 0 roms/{config.vga.isavga = config.vga-isavga} | 0 roms/{config.vga.qxl = config.vga-qxl} | 0

[Qemu-devel] [PATCH 7/9] roms: enable ipxe cross builds

2013-09-30 Thread Gerd Hoffmann
--- roms/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/roms/Makefile b/roms/Makefile index 5fcc77d..1966f04 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -31,6 +31,7 @@ find-cross-gcc = $(firstword $(wildcard $(patsubst %ld,%gcc,$(call find-cross-ld find-cross-prefix =

[Qemu-devel] [PATCH 2/9] roms: enable parallel builds for 'make lgplvgabios'

2013-09-30 Thread Gerd Hoffmann
Recurse into vgabios once, adjust dependencies, call make using $(MAKE) $(MAKEFLAGS) so jobserver mode works. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/roms/Makefile b/roms/Makefile index

Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: Remove unused assignment (fixes warning from clang)

2013-09-30 Thread Stefan Hajnoczi
On Sun, Sep 29, 2013 at 10:15:10PM +0200, Stefan Weil wrote: Am 29.09.2013 21:44, schrieb Michael Tokarev: 28.09.2013 13:55, Stefan Weil wrote: [...] diff --git a/blockdev.c b/blockdev.c index 8aa66a9..8c83f6f 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1926,7 +1926,6 @@ void

[Qemu-devel] [PATCH 4/9] roms: parallel ipxe builds

2013-09-30 Thread Gerd Hoffmann
Enable parallel ipxe builds. Reduce the recursive make calls. Call recursive make properly using $(MAKE) $(MAKEFLAGS). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/roms/Makefile

[Qemu-devel] [PATCH 9/9] roms: add support for building sgabios

2013-09-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile | 9 + 1 file changed, 9 insertions(+) diff --git a/roms/Makefile b/roms/Makefile index 6994873..10d5a65 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -50,6 +50,7 @@ default: @echo bios -- update

[Qemu-devel] [PATCH 3/9] roms: build lgplvgabios isavga variant

2013-09-30 Thread Gerd Hoffmann
Add logic to also build+install the isavga vgabios variant. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/roms/Makefile b/roms/Makefile index 6d4330f..11d7837 100644 --- a/roms/Makefile +++

Re: [Qemu-devel] [PATCH] block: use correct filename for error report

2013-09-30 Thread Dunrong Huang
ping? On Tue, Sep 24, 2013 at 8:12 PM, Max Reitz mre...@redhat.com wrote: On 2013-09-24 12:14, Dunrong Huang wrote: The content filename point to will be erased by qemu_opts_absorb_qdict() in raw_open_common() in drv-bdrv_file_open() So it's better to use bs-filename. Signed-off-by:

[Qemu-devel] [PULL 0/1] seabios update to 1.7.3.2

2013-09-30 Thread Gerd Hoffmann
Hi, New seabios release is out, here comes the update for qemu. please pull, Gerd The following changes since commit 53d09b761f032f50c4424e8649396a9041070bae: linux-user: Handle SOCK_CLOEXEC/NONBLOCK if unavailable on host (2013-09-24 10:47:07 +0300) are available in the git repository

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 11:06:48AM +0200, Paolo Bonzini wrote: Il 30/09/2013 11:06, Michael S. Tsirkin ha scritto: On Mon, Sep 30, 2013 at 04:02:29PM +0800, liu ping fan wrote: On Sun, Sep 29, 2013 at 12:15 PM, Michael S. Tsirkin m...@redhat.com wrote: On Sun, Sep 29, 2013 at 11:49:41AM

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-30 Thread Marcel Apfelbaum
On Mon, 2013-09-30 at 12:14 +0300, Michael S. Tsirkin wrote: On Mon, Sep 30, 2013 at 11:02:06AM +0200, Paolo Bonzini wrote: Il 30/09/2013 10:58, Michael S. Tsirkin ha scritto: As a next step, can we make pci_set_irq non-inline and make it call pci_irq_handler directly, and get rid of

Re: [Qemu-devel] [PATCH 2/3] qcow2: Free allocated L2 cluster on error

2013-09-30 Thread Max Reitz
On 2013-09-27 16:54, Kevin Wolf wrote: Am 25.09.2013 um 16:37 hat Max Reitz geschrieben: If an error occurs in l2_allocate, the allocated (but unused) L2 cluster should be freed. Signed-off-by: Max Reitz mre...@redhat.com --- block/qcow2-cluster.c | 4 1 file changed, 4 insertions(+)

Re: [Qemu-devel] qemu, numa: non-contiguous cpusets

2013-09-30 Thread Borislav Petkov
On Mon, Sep 30, 2013 at 11:05:10AM +0200, Paolo Bonzini wrote: I think there are already patches on the list to do that, as part of the NUMA memory binding series from Wanlong Gao. Yeah: https://lists.gnu.org/archive/html/qemu-devel/2013-09/msg02833.html Although I don't see from it how the

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-30 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Fri, Sep 27, 2013 at 07:06:44PM +0200, Markus Armbruster wrote: Marcel Apfelbaum marcel.apfelb...@gmail.com writes: On Wed, 2013-09-25 at 10:01 +0300, Michael S. Tsirkin wrote: On Tue, Sep 24, 2013 at 06:01:02AM -0400, Laine Stump wrote:

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-09-30 Thread Markus Armbruster
Stefan Weil s...@weilnetz.de writes: Am 29.09.2013 22:13, schrieb Michael Tokarev: 29.09.2013 19:41, Stefan Weil wrote: The QEMU buildbot default_i386_debian_6_0 shows this warning: CCmigration.o migration.c: In function 'qmp_query_migrate_capabilities': migration.c:149: warning:

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 12:43:20PM +0300, Marcel Apfelbaum wrote: On Mon, 2013-09-30 at 12:14 +0300, Michael S. Tsirkin wrote: On Mon, Sep 30, 2013 at 11:02:06AM +0200, Paolo Bonzini wrote: Il 30/09/2013 10:58, Michael S. Tsirkin ha scritto: As a next step, can we make pci_set_irq

[Qemu-devel] [PATCH uq/master] kvmvapic: Prevent reading beyond the end of guest RAM

2013-09-30 Thread Jan Kiszka
rom_state_paddr is guest provided (caller address of outw(VAPIC_PORT) + writen 16-bit value) and can be influenced to point beyond the end of the host memory backing the guest's RAM. Make sure we do not use this pointer to actually read beyond the limits. Reading arbitrary guest bytes is

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-30 Thread Marcel Apfelbaum
On Mon, 2013-09-30 at 13:10 +0300, Michael S. Tsirkin wrote: On Mon, Sep 30, 2013 at 12:43:20PM +0300, Marcel Apfelbaum wrote: On Mon, 2013-09-30 at 12:14 +0300, Michael S. Tsirkin wrote: On Mon, Sep 30, 2013 at 11:02:06AM +0200, Paolo Bonzini wrote: Il 30/09/2013 10:58, Michael S.

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-30 Thread Laine Stump
On 09/30/2013 05:55 AM, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: I never heard of a pci/pci express one but it's not impossible I think. PCI on one side of the card, PCIe on the other, and a switchable backplate? Weird :) Again, I can't see why we'd want to model

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 11:55:47AM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Fri, Sep 27, 2013 at 07:06:44PM +0200, Markus Armbruster wrote: Marcel Apfelbaum marcel.apfelb...@gmail.com writes: On Wed, 2013-09-25 at 10:01 +0300, Michael S. Tsirkin

[Qemu-devel] [RfC PATCH 0/2] seabios: going to 256k size

2013-09-30 Thread Gerd Hoffmann
Hi, With the seabios update to the next master branch relase (NOT the stable branch pull sent out earlier today) seabios rom size will cross the 128k boundary and we have to deal with that. So here is a RfC patch series with one aproach to handle this: We'll go build two seabios binaries, one

[Qemu-devel] [PATCH 1/2] roms: build two seabios binaries

2013-09-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile| 7 --- roms/config.seabios | 1 - roms/config.seabios-128k | 5 + roms/config.seabios-256k | 3 +++ 4 files changed, 12 insertions(+), 4 deletions(-) delete mode 100644 roms/config.seabios create mode

[Qemu-devel] [PATCH 2/2] machine type dependant bios

2013-09-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/i386/pc_piix.c| 1 + hw/i386/pc_q35.c | 1 + hw/i386/pc_sysfw.c | 4 ++-- include/hw/i386/pc.h | 2 ++ 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 907792b..35188a5 100644

Re: [Qemu-devel] [PATCH uq/master] kvmvapic: Prevent reading beyond the end of guest RAM

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 12:35:13PM +0200, Jan Kiszka wrote: rom_state_paddr is guest provided (caller address of outw(VAPIC_PORT) + writen 16-bit value) and can be influenced to point beyond the end of the host memory backing the guest's RAM. Make sure we do not use this pointer to actually

[Qemu-devel] mail to Paul Brook p...@codesourcery.com bouncing [postmas...@relay1.mentorg.com: Delivery Status Notification (Failure)]

2013-09-30 Thread Michael S. Tsirkin
Anyone knows what's going on? If no mail should be sent to p...@codesourcery.com, let's add .mailcap so get_maintainer doesn't suggest this address. - Forwarded message from postmas...@relay1.mentorg.com - Date: Mon, 30 Sep 2013 03:08:22 -0700 From: postmas...@relay1.mentorg.com To:

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 12:39, Marcel Apfelbaum ha scritto: Thanks! That means that hpev_intx is not necessary at all. By the way, aer_intx used by Advanced Error Reporting is also unnecessary. (6.2.4.1.2 has the same note) I will remove the above fields from PCIExpressDevice. vmxnet is also buggy

Re: [Qemu-devel] [PATCH 1/2] roms: build two seabios binaries

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 12:46, Gerd Hoffmann ha scritto: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile| 7 --- roms/config.seabios | 1 - roms/config.seabios-128k | 5 + roms/config.seabios-256k | 3 +++ 4 files changed, 12 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH v3] spapr-rtas: fix h_rtas parameters reading

2013-09-30 Thread Alexander Graf
On 27.09.2013, at 10:10, Alexey Kardashevskiy wrote: On the real hardware, RTAS is called in real mode and therefore top 4 bits of the address passed in the call are ignored. So does the patch. This converts h_rtas() to use existing rtas_ld() handlers. This fixed rtas_ld()/rtas_st() to

Re: [Qemu-devel] [PATCH v2] spapr: Add ibm, purr property on power7 and newer

2013-09-30 Thread Alexander Graf
On 27.09.2013, at 10:11, Alexey Kardashevskiy wrote: PAPR+ says that no ibm,purr tells the guest that H_PURR is not supported. However some guests still try calling H_PURR on POWER7 unless the property is present and equal to 0. This adds the property for CPUs supporting the PURR special

Re: [Qemu-devel] [PATCH 2/3] qcow2: Free allocated L2 cluster on error

2013-09-30 Thread Kevin Wolf
Am 30.09.2013 um 11:48 hat Max Reitz geschrieben: On 2013-09-27 16:54, Kevin Wolf wrote: Am 25.09.2013 um 16:37 hat Max Reitz geschrieben: If an error occurs in l2_allocate, the allocated (but unused) L2 cluster should be freed. Signed-off-by: Max Reitz mre...@redhat.com ---

Re: [Qemu-devel] [PATCH] spapr: add compat machine option

2013-09-30 Thread Alexander Graf
On 27.09.2013, at 10:06, Alexey Kardashevskiy wrote: To be able to boot on newer hardware that the software support, PowerISA defines a logical PVR, one per every PowerISA specification version from 2.04. This adds the compat option which takes values 205 or 206 and forces QEMU to boot

Re: [Qemu-devel] [PATCH v7] powerpc: add PVR mask support

2013-09-30 Thread Alexander Graf
On 27.09.2013, at 10:05, Alexey Kardashevskiy wrote: IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and a CPU version in lower 16 bits. Since there is no significant change in behavior between versions, there is no point to add every single CPU version in QEMU's CPU

[Qemu-devel] [PATCH V3] block: Add BlockDriver.bdrv_check_ext_snapshot.

2013-09-30 Thread Benoît Canet
This field is used by blkverify to disable external snapshots creation. I will also be used by block filters like quorum to disable external snapshots creation. Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 14 ++ block/blkverify.c | 2 ++

[Qemu-devel] [PATCH V3] disable blkverify external snapshot creation

2013-09-30 Thread Benoît Canet
Hello, Here is the new version of the snapshot forbidding patch. v3: functions return an enum [Jeff] rename forbiding function [Kevin] v2: Use NULL fields to avoid having to fill the new field in every BlockDriver  [Jeff] Rename the field [Kevin] Benoît Canet (1): block:

Re: [Qemu-devel] [PATCH] spapr: add compat machine option

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 13:25, Alexander Graf ha scritto: On 27.09.2013, at 10:06, Alexey Kardashevskiy wrote: To be able to boot on newer hardware that the software support, PowerISA defines a logical PVR, one per every PowerISA specification version from 2.04. This adds the compat option

[Qemu-devel] [PATCH v4 1/7] block: add bdrv_common_ancestor()

2013-09-30 Thread Fam Zheng
This function finds the common ancestor in backing chain of two BDSes. If there's no common ancestor, NULL is returned. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 15 +++ include/block/block.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/block.c

[Qemu-devel] [PATCH v4 0/7] block: allow commit active as top

2013-09-30 Thread Fam Zheng
Previously live commit of active block device is not supported, this series implements it and updates corresponding qemu-iotests cases. v4: Rewrite to reuse block/mirror.c. When committing the active layer, the job is internally a mirror job with type name faked to commit. When the

[Qemu-devel] [PATCH v4 5/7] commit: support commit active layer

2013-09-30 Thread Fam Zheng
If active is top, it will be mirrored to base, (with block/mirror.c code), then the image is switched when user completes the block job. Signed-off-by: Fam Zheng f...@redhat.com --- blockdev.c | 42 -- 1 file changed, 40 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH v4 2/7] qmp: add internal sync mode common to mirror_start

2013-09-30 Thread Fam Zheng
This adds a new sync mode common which only copies data that is above the common ancestor of source and target. In general, this could be useful in cases like: base_bs --- common_ancestor --- foo --- bar ---source \ \---

[Qemu-devel] [PATCH v4 6/7] commit: remove unused check

2013-09-30 Thread Fam Zheng
We support top == active for commit now, remove the check which is dead code now. Signed-off-by: Fam Zheng f...@redhat.com --- block/commit.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/block/commit.c b/block/commit.c index ac4b7cc..086f8c9 100644 --- a/block/commit.c +++

[Qemu-devel] [PATCH v4 7/7] qemu-iotests: update test cases for commit active

2013-09-30 Thread Fam Zheng
Factor out commit test common logic into super class, and update test of committing the active image. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/040 | 73 +- 1 file changed, 31 insertions(+), 42 deletions(-) diff --git

[Qemu-devel] [PATCH v4 3/7] mirror: don't close target

2013-09-30 Thread Fam Zheng
Let reference count manage target and don't call bdrv_close here. Signed-off-by: Fam Zheng f...@redhat.com --- block/mirror.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index fdc7fa8..af6851f 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -479,7

[Qemu-devel] [PATCH v4 4/7] mirror: Add commit_job_type to perform commit with mirror code

2013-09-30 Thread Fam Zheng
Commit active layer will be implemented in block/mirror.c, prepare a new job type to let it have a right type name for the user. Signed-off-by: Fam Zheng f...@redhat.com --- block/mirror.c| 12 +++- blockdev.c| 2 +- include/block/block_int.h | 2 ++ 3 files

Re: [Qemu-devel] [PATCH v4 5/7] commit: support commit active layer

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 14:02, Fam Zheng ha scritto: +/* Mirror code already swapped bs and base, we drop the bs loop chain + * formed by the swap: break the loop chain, trigger the chain unref. + */ +p = info-base-backing_hd; +info-base-backing_hd = NULL; +

Re: [Qemu-devel] [PATCH v4 6/7] commit: remove unused check

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 14:02, Fam Zheng ha scritto: We support top == active for commit now, remove the check which is dead code now. Signed-off-by: Fam Zheng f...@redhat.com --- block/commit.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/block/commit.c b/block/commit.c index

Re: [Qemu-devel] qemu, numa: non-contiguous cpusets

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 11:49, Borislav Petkov ha scritto: Yeah: https://lists.gnu.org/archive/html/qemu-devel/2013-09/msg02833.html Although I don't see from it how the syntax for -cpus will look like from that QAPI magic except that it is an + '*cpus': ['uint16'], It's -numa

Re: [Qemu-devel] [PATCH v4 2/3] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-09-30 Thread Mike Day
Stefan Hajnoczi stefa...@redhat.com writes: Introduce QEMUTimerList-active_timers_lock to protect the linked list of active timers. This allows qemu_timer_mod_ns() to be called from any thread. Note that vm_clock is not thread-safe and its use of qemu_clock_has_timers() works fine today

Re: [Qemu-devel] [RFC V8 03/13] quorum: Add quorum_aio_writev and its dependencies.

2013-09-30 Thread Benoît Canet
Le Friday 27 Sep 2013 à 12:03:07 (+0200), Kevin Wolf a écrit : Am 26.09.2013 um 18:29 hat Benoît Canet geschrieben: Le Friday 08 Feb 2013 à 11:38:38 (+0100), Kevin Wolf a écrit : Am 28.01.2013 18:07, schrieb Benoît Canet: Signed-off-by: Benoit Canet ben...@irqsave.net ---

Re: [Qemu-devel] mail to Paul Brook p...@codesourcery.com bouncing [postmas...@relay1.mentorg.com: Delivery Status Notification (Failure)]

2013-09-30 Thread Andreas Färber
Am 30.09.2013 12:55, schrieb Michael S. Tsirkin: Anyone knows what's going on? I've already ping'ed him on IRC without success and wrote to another email address that I found on GitHub, where there was some recent activity. If no mail should be sent to p...@codesourcery.com, let's add

Re: [Qemu-devel] [PATCH v4 2/3] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-09-30 Thread Alex Bligh
On 30 Sep 2013, at 13:45, Mike Day wrote: I've applied this set to Paolo's rcu tree - I see a couple of routines that appear to need the active_timers_lock: (line 137 of qemu-timer.c in my tree) void qemu_clock_notify(QEMUClockType type) { QEMUTimerList *timer_list; QEMUClock

Re: [Qemu-devel] [PATCH] spapr: add compat machine option

2013-09-30 Thread Alexey Kardashevskiy
On 30.09.2013 21:52, Paolo Bonzini wrote: Il 30/09/2013 13:25, Alexander Graf ha scritto: On 27.09.2013, at 10:06, Alexey Kardashevskiy wrote: To be able to boot on newer hardware that the software support, PowerISA defines a logical PVR, one per every PowerISA specification version from

Re: [Qemu-devel] [RFC V8 06/13] quorum: Add quorum mechanism.

2013-09-30 Thread Benoît Canet
Le Friday 08 Feb 2013 à 13:07:03 (+0100), Kevin Wolf a écrit : Am 28.01.2013 18:07, schrieb Benoît Canet: Use gnutls's SHA-256 to compare versions. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 303 +++-

Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

2013-09-30 Thread Igor Mammedov
On Sun, 29 Sep 2013 13:58:24 +0300 Michael S. Tsirkin m...@redhat.com wrote: This is so qom headers can use it without pulling in extra headers. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qemu/typedefs.h | 1 + 1 file

Re: [Qemu-devel] [PATCH v4 2/3] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-09-30 Thread Mike Day
On Mon, Sep 30, 2013 at 8:55 AM, Alex Bligh a...@alex.org.uk wrote: On 30 Sep 2013, at 13:45, Mike Day wrote: I've applied this set to Paolo's rcu tree - I see a couple of routines that appear to need the active_timers_lock: (line 137 of qemu-timer.c in my tree) void

Re: [Qemu-devel] [PATCH] spapr: add compat machine option

2013-09-30 Thread Alexey Kardashevskiy
On 30.09.2013 21:25, Alexander Graf wrote: On 27.09.2013, at 10:06, Alexey Kardashevskiy wrote: To be able to boot on newer hardware that the software support, PowerISA defines a logical PVR, one per every PowerISA specification version from 2.04. This adds the compat option which takes

Re: [Qemu-devel] [PATCH v4 2/3] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-09-30 Thread Alex Bligh
Mike, void qemu_clock_notify(QEMUClockType type) ... int64_t qemu_clock_deadline_ns_all(QEMUClockType type) ... I think these functions are always called now with the BQL held, so I wonder if they are good candidates for RCU? These routines iterate through the list of timerlists held

Re: [Qemu-devel] Minimal Qemu build for Plan9

2013-09-30 Thread Andreas Färber
Hi, Am 30.09.2013 10:00, schrieb Ashish Kaila: I am a graduate student from CMU and currently working on trying to port Qemu on plan9. I was trying to initially build a minimal Qemu with the least set of devices that are necessary to support a machine, however I noticed that I couldn’t

Re: [Qemu-devel] [PATCH 1/2] roms: build two seabios binaries

2013-09-30 Thread Gerd Hoffmann
diff --git a/roms/config.seabios-128k b/roms/config.seabios-128k new file mode 100644 index 000..23ca812 --- /dev/null +++ b/roms/config.seabios-128k @@ -0,0 +1,5 @@ +# for qemu machine types 1.6 + older +# need to turn off features (xhci) to make it fit into 128k

Re: [Qemu-devel] Minimal Qemu build for Plan9

2013-09-30 Thread Peter Maydell
On 30 September 2013 17:00, Ashish Kaila ashishkai...@gmail.com wrote: Additionally if someone could point me to a to-do list of things to look out for while porting Qemu on a new platform (new OS/hardware), I would be extremely grateful. It doesn't get ported to new OSes very often, so

Re: [Qemu-devel] [PATCH 0/2] make -kernel optional for all ARM boards

2013-09-30 Thread Andreas Färber
Am 24.09.2013 02:01, schrieb Peter Maydell: Make -kernel optional for all ARM boards, by allowing arm_load_kernel() to return without doing anything if no kernel filename was provided. In this case we will start execution at address zero (as the hardware does). This allows the user to provide

Re: [Qemu-devel] [PATCH v3 02/18] arm/boot: Turn arm_load_kernel() into no-op for qtest without -kernel

2013-09-30 Thread Andreas Färber
Am 24.09.2013 01:55, schrieb Peter Maydell: On 23 September 2013 23:51, Andreas Färber afaer...@suse.de wrote: Am 23.09.2013 15:35, schrieb Andreas Färber: Signed-off-by: Andreas Färber afaer...@suse.de --- hw/arm/boot.c | 4 1 file changed, 4 insertions(+) Sorry, I forgot that Grant

Re: [Qemu-devel] [PATCH 1/2] roms: build two seabios binaries

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 15:44, Gerd Hoffmann ha scritto: +# for qemu machine types 1.6 + older +# need to turn off features (xhci) to make it fit into 128k +CONFIG_QEMU=y +CONFIG_ROM_SIZE=128 +CONFIG_USB_XHCI=n Is it enough to disable Xen or perhaps OHCI? We can try that. I've picked

Re: [Qemu-devel] [PATCH v3 00/18] qtest: Test all targets

2013-09-30 Thread Andreas Färber
Am 23.09.2013 15:35, schrieb Andreas Färber: Andreas Färber (18): mips_mipssim: Silence BIOS loading warning for qtest arm/boot: Turn arm_load_kernel() into no-op for qtest without -kernel With the exception of this patch for which PMM provided a replacement... puv3: Turn

Re: [Qemu-devel] [PATCH v4 2/3] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-09-30 Thread Mike Day
On Mon, Sep 30, 2013 at 9:34 AM, Alex Bligh a...@alex.org.uk wrote: void qemu_clock_notify(QEMUClockType type) ... int64_t qemu_clock_deadline_ns_all(QEMUClockType type) ... I think these functions are always called now with the BQL held, so I wonder if they are good candidates for

Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 03:10:56PM +0200, Igor Mammedov wrote: On Sun, 29 Sep 2013 13:58:24 +0300 Michael S. Tsirkin m...@redhat.com wrote: This is so qom headers can use it without pulling in extra headers. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael S.

Re: [Qemu-devel] drive-backup locks VM if target has issues?

2013-09-30 Thread Wolfgang Richter
On Mon, Sep 30, 2013 at 3:41 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 30/09/2013 00:46, Wolfgang Richter ha scritto: All writes to the drive-backup source have to first copy the pre-write data to the target. Thus, drive-backup usually works best if you are using werror=stop on the

Re: [Qemu-devel] [PATCH v4 2/7] qmp: add internal sync mode common to mirror_start

2013-09-30 Thread Eric Blake
On 09/30/2013 06:02 AM, Fam Zheng wrote: This adds a new sync mode common which only copies data that is above the common ancestor of source and target. In general, this could be useful in cases like: base_bs --- common_ancestor --- foo --- bar ---source

  1   2   >