Re: [Qemu-devel] [PATCH v3 08/21] block: Allow reference for bdrv_file_open()

2013-12-12 Thread Fam Zheng
On 2013年12月12日 02:11, Max Reitz wrote: Allow specifying a reference to an existing block device (by name) for bdrv_file_open() instead of a filename and/or options. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 27 --- block/blkdebug.c |

Re: [Qemu-devel] [PATCH v6 00/10] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2013-12-12 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: On 2013年11月28日 16:39, Fam Zheng wrote: This series adds for point-in-time snapshot NBD exporting based on blockdev-backup (variant of drive-backup with existing device as target). We get a thin point-in-time snapshot by COW mechanism of drive-backup, and

Re: [Qemu-devel] issue with vgabios lfb and virtio vga

2013-12-12 Thread Gerd Hoffmann
On Do, 2013-12-12 at 09:51 +1000, Dave Airlie wrote: Now the vgabios.c does a check of bar 0 and bar 1 to see if they are 0xfff1 masked, this protects against the the i/o bar but fails to protect against the LFB one as PCI BARs don't encode the size just the base address, and a 4k BAR can be

Re: [Qemu-devel] [PATCH v6 00/10] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2013-12-12 Thread Fam Zheng
On 2013年12月12日 16:14, Markus Armbruster wrote: Fam Zheng f...@redhat.com writes: On 2013年11月28日 16:39, Fam Zheng wrote: This series adds for point-in-time snapshot NBD exporting based on blockdev-backup (variant of drive-backup with existing device as target). We get a thin point-in-time

Re: [Qemu-devel] [RFC PATCH 09/14] qom: fix leak for objects created with -object

2013-12-12 Thread Stefan Hajnoczi
On Wed, Dec 11, 2013 at 01:19:16PM +0100, Paolo Bonzini wrote: The object must be unref-ed when its variable goes out of scope. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [RFC PATCH 10/14] qom: catch errors in object_property_add_child

2013-12-12 Thread Stefan Hajnoczi
On Wed, Dec 11, 2013 at 01:19:17PM +0100, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qom/object.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] [PATCH] block/vvfat: Fix compiler warnings for OpenBSD

2013-12-12 Thread Stefan Hajnoczi
On Wed, Dec 11, 2013 at 09:37:11PM +0100, Stefan Weil wrote: The buildbot shows these compiler warnings: block/vvfat.c: In function 'create_short_and_long_name': block/vvfat.c:620: warning: array size (8) smaller than bound length (11) block/vvfat.c:620: warning: array size (8) smaller than

[Qemu-devel] [PATCH v7 00/10] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2013-12-12 Thread Fam Zheng
This series adds for point-in-time snapshot NBD exporting based on blockdev-backup (variant of drive-backup with existing device as target). We get a thin point-in-time snapshot by COW mechanism of drive-backup, and export it through built in NBD server. The steps are as below: 1. (SHELL)

[Qemu-devel] [PATCH v7 05/10] stream: Use bdrv_drop_intermediate and drop close_unused_images

2013-12-12 Thread Fam Zheng
This reuses the new bdrv_drop_intermediate. Signed-off-by: Fam Zheng f...@redhat.com --- block/stream.c | 28 +--- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/block/stream.c b/block/stream.c index 46bec7d..9cdcf0e 100644 --- a/block/stream.c +++

[Qemu-devel] [PATCH v7 04/10] block: support dropping active in bdrv_drop_intermediate

2013-12-12 Thread Fam Zheng
Dropping intermediate could be useful both for commit and stream, and BDS refcnt plus bdrv_swap could do most of the job nicely. It also need some improvements in preparation for op blockers. Signed-off-by: Fam Zheng f...@redhat.com --- block.c| 152

[Qemu-devel] [PATCH v7 03/10] block: Parse backing option to reference existing BDS

2013-12-12 Thread Fam Zheng
Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 109 +- block/mirror.c| 2 +- include/block/block.h | 3 +- include/block/block_int.h | 3 ++ 4 files changed, 76 insertions(+), 41 deletions(-) diff --git

[Qemu-devel] [PATCH v7 01/10] qapi: Add BlockOperationType enum

2013-12-12 Thread Fam Zheng
This adds the enum of all the operations that can be taken on a block device. Signed-off-by: Fam Zheng f...@redhat.com --- qapi-schema.json | 49 + 1 file changed, 49 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index

[Qemu-devel] [PATCH v7 09/10] qmp: add command 'blockdev-backup'

2013-12-12 Thread Fam Zheng
Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Signed-off-by: Fam Zheng f...@redhat.com --- block/backup.c | 21 + blockdev.c

[Qemu-devel] [PATCH v7 06/10] block: Replace in_use with operation blocker

2013-12-12 Thread Fam Zheng
This drops BlockDriverState.in_use with op_blockers: - Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1). - Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0). - Check bdrv_op_is_blocked() in place of bdrv_in_use(bs). The specific types are used, e.g. in place of

[Qemu-devel] [PATCH v7 02/10] block: Introduce op_blockers to BlockDriverState

2013-12-12 Thread Fam Zheng
BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX elements. Each list is a list of blockers of an operation type (BlockOpType), that marks this BDS as currently blocked for a certain type of operation with reason errors stored in the list. The rule of usage is: * BDS user

[Qemu-devel] [PATCH v7 10/10] block: Allow backup on referenced named BlockDriverState

2013-12-12 Thread Fam Zheng
Drive backup is a read only operation on source bs. We want to allow this specific case to enable image-fleecing. Note that when image-fleecing job starts, the job still add its blocker to source bs, and any other operation on it will be blocked by that. Signed-off-by: Fam Zheng f...@redhat.com

[Qemu-devel] [PATCH v7 08/10] block: Add checks of blocker in block operations

2013-12-12 Thread Fam Zheng
Before operate on a BlockDriverState, respective types are checked against bs-op_blockers and it will error out if there's a blocker. Signed-off-by: Fam Zheng f...@redhat.com --- block/snapshot.c | 11 +++ blockdev.c | 8 2 files changed, 19 insertions(+) diff --git

[Qemu-devel] [PATCH v7 07/10] block: Pass error in bdrv_snapshot_create

2013-12-12 Thread Fam Zheng
This allows descent error information to be reported. Signed-off-by: Fam Zheng f...@redhat.com --- block/snapshot.c | 5 +++-- blockdev.c | 2 +- include/block/snapshot.h | 3 ++- qemu-img.c | 2 +- savevm.c | 2 +- 5 files changed, 8

Re: [Qemu-devel] RFC: kvm call reschedule

2013-12-12 Thread Stefan Hajnoczi
On Tue, Dec 10, 2013 at 04:23:25PM +0100, Kevin Wolf wrote: Am 10.12.2013 um 16:11 hat Juan Quintela geschrieben: I can do any of them. Votes for the people that attend? As I guess he commutes everyday, moving the day will not help :p I prefer 15:00 CET (14:00 UTC). +1 Stefan

Re: [Qemu-devel] [PATCH v11 1/5] vmstate: add VMSTATE_PTIMER_ARRAY

2013-12-12 Thread Li Guang
ping ... this patch is not changed since v8, can it get some comments? Thanks! liguang wrote: Signed-off-by: liguanglig.f...@cn.fujitsu.com --- include/migration/vmstate.h |4 savevm.c| 31 +++ 2 files changed, 35 insertions(+), 0

Re: [Qemu-devel] RFC: kvm call reschedule

2013-12-12 Thread Zhi Yong Wu
On Tue, Dec 10, 2013 at 11:23 PM, Kevin Wolf kw...@redhat.com wrote: Am 10.12.2013 um 16:11 hat Juan Quintela geschrieben: Anthony can't assist this call, just in the middle of his commute. As it looks like a good idea that he can assit, can we move the call? Options so far are (his local

Re: [Qemu-devel] [PATCH] block/vvfat: Fix compiler warnings for OpenBSD

2013-12-12 Thread Kevin Wolf
Am 12.12.2013 um 09:22 hat Stefan Hajnoczi geschrieben: On Wed, Dec 11, 2013 at 09:37:11PM +0100, Stefan Weil wrote: The buildbot shows these compiler warnings: block/vvfat.c: In function 'create_short_and_long_name': block/vvfat.c:620: warning: array size (8) smaller than bound length

[Qemu-devel] [PATCH v2] roms: Flush icache when writing roms to guest memory

2013-12-12 Thread Alexander Graf
We use the rom infrastructure to write firmware and/or initial kernel blobs into guest address space. So we're basically emulating the cache off phase on very early system bootup. That phase is usually responsible for clearing the instruction cache for anything it writes into cachable memory, to

Re: [Qemu-devel] [PATCH 01/22] block: Move initialisation of BlockLimits to bdrv_refresh_limits()

2013-12-12 Thread Kevin Wolf
Am 12.12.2013 um 08:51 hat Thomas Huth geschrieben: On Thu, 12 Dec 2013 10:57:49 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: +static int bdrv_refresh_limits(BlockDriverState *bs) +{ +BlockDriver *drv = bs-drv; + +memset(bs-bl, 0, sizeof(bs-bl)); + +

Re: [Qemu-devel] [PATCH 01/22] block: Move initialisation of BlockLimits to bdrv_refresh_limits()

2013-12-12 Thread Kevin Wolf
Am 12.12.2013 um 07:17 hat Peter Lieven geschrieben: Am 11.12.2013 22:08, schrieb Kevin Wolf: This function separates filling the BlockLimits from bdrv_open(), which allows it to call it from other operations which may change the limits (e.g. modifications to the backing file chain or

Re: [Qemu-devel] [PATCH 0/5] target-s390: Use the new qemu_ld/st opcodes

2013-12-12 Thread Alexander Graf
On 11.12.2013, at 20:30, Richard Henderson r...@twiddle.net wrote: The first patch is purely mechanical. The subsequent patches tidy things up as allowed by the new interfaces. Reviewed-by: Alexander Graf ag...@suse.de Alex

Re: [Qemu-devel] [PATCH v2 0/4] X86/KVM: enable Intel MPX for KVM

2013-12-12 Thread Paolo Bonzini
Il 12/12/2013 06:47, Liu, Jinsong ha scritto: Paolo Bonzini wrote: Il 11/12/2013 09:31, Liu, Jinsong ha scritto: Paolo, comments for version 2? I think I commented that it's fine, I'm just waiting for a rebase on top of the generic patches. Paolo Thanks! common MPX definiation patches

Re: [Qemu-devel] [PATCH 00/22] block: Support for 512b-on-4k emulation

2013-12-12 Thread Kevin Wolf
Am 12.12.2013 um 07:09 hat Peter Lieven geschrieben: Should it be possible to boot from a 4K-native drive with this series? If yes, I will run some test with some new iSCSI arrays we got for testing they can export 4k blocksize LUNs. Yes, you should be able to use a 4k-native backend for a

Re: [Qemu-devel] [PATCH v2 1/8] target-arm: A64: add support for ld/st pair

2013-12-12 Thread C Fontana
Hi, I saw a missing return below: On 11 December 2013 23:01, Peter Maydell peter.mayd...@linaro.org wrote: From: Alex Bennée alex.ben...@linaro.org This patch support the basic load and store pair instructions and includes the generic helper functions: * do_gpr_st() * do_fp_st() *

Re: [Qemu-devel] [PATCH 00/22] block: Support for 512b-on-4k emulation

2013-12-12 Thread Peter Lieven
Am 12.12.2013 10:47, schrieb Kevin Wolf: Am 12.12.2013 um 07:09 hat Peter Lieven geschrieben: Should it be possible to boot from a 4K-native drive with this series? If yes, I will run some test with some new iSCSI arrays we got for testing they can export 4k blocksize LUNs. Yes, you should be

Re: [Qemu-devel] [PATCH v3 21/21] iotests: Test new blkdebug/blkverify interface

2013-12-12 Thread Fam Zheng
On 2013年12月12日 02:11, Max Reitz wrote: Add a test for the new blkdebug/blkverify interface. Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/071 | 201 + tests/qemu-iotests/071.out | 73

Re: [Qemu-devel] [PATCH v3 00/21] blkdebug/blkverify: Allow QMP configuration

2013-12-12 Thread Fam Zheng
On 2013年12月12日 02:10, Max Reitz wrote: Currently, the configuration of blkdebug and blkverify is done through the filename alone. There is now way of manually choosing blkdebug or blkverify as a driver and using a normal image filename. In the case of blkdebug, the filename starts with the

Re: [Qemu-devel] [PATCH v2 0/4] X86/KVM: enable Intel MPX for KVM

2013-12-12 Thread Liu, Jinsong
Paolo Bonzini wrote: Il 12/12/2013 06:47, Liu, Jinsong ha scritto: Paolo Bonzini wrote: Il 11/12/2013 09:31, Liu, Jinsong ha scritto: Paolo, comments for version 2? I think I commented that it's fine, I'm just waiting for a rebase on top of the generic patches. Paolo Thanks!

Re: [Qemu-devel] [PATCH v2 1/8] target-arm: A64: add support for ld/st pair

2013-12-12 Thread Alex Bennée
claudio.font...@linaro.org writes: Hi, I saw a missing return below: snip +default: /* Failed decoder tree? */ +unallocated_encoding(s); +break; +} This doesn't seem right (break instead of return): default: unallocated_encoding(s); return; } Good

Re: [Qemu-devel] [PATCH v2 1/8] target-arm: A64: add support for ld/st pair

2013-12-12 Thread Peter Maydell
On 12 December 2013 11:43, Alex Bennée alex.ben...@linaro.org wrote: claudio.font...@linaro.org writes: Hi, I saw a missing return below: snip +default: /* Failed decoder tree? */ +unallocated_encoding(s); +break; +} This doesn't seem right (break instead of

Re: [Qemu-devel] [PATCH v3] char: restore read callback on a reattached (hotplug) chardev

2013-12-12 Thread Markus Armbruster
Gal Hammer gham...@redhat.com writes: Fix a bug that was introduced in commit 386a5a1e. A removal of a device set the chr handlers to NULL. However when the device is plugged back, its read callback is not restored so data can't be transftered from the host to the guest (e.g. via the

Re: [Qemu-devel] [PATCH v2 1/8] target-arm: A64: add support for ld/st pair

2013-12-12 Thread C Fontana
On 12 December 2013 12:45, Peter Maydell peter.mayd...@linaro.org wrote: On 12 December 2013 11:43, Alex Bennée alex.ben...@linaro.org wrote: claudio.font...@linaro.org writes: Hi, I saw a missing return below: snip +default: /* Failed decoder tree? */ +

Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset

2013-12-12 Thread Paolo Bonzini
Il 12/12/2013 03:52, Fernando Luis Vázquez Cao ha scritto: On 12/09/2013 05:50 PM, Fernando Luis Vázquez Cao wrote: On 12/06/2013 11:22 PM, Marcelo Tosatti wrote: On Fri, Dec 06, 2013 at 05:24:18PM +0900, Fernando Luis Vázquez Cao wrote: I also wanted to make sure that the initialization that

Re: [Qemu-devel] [PATCH v7 01/10] qapi: Add BlockOperationType enum

2013-12-12 Thread Kevin Wolf
Am 12.12.2013 um 09:23 hat Fam Zheng geschrieben: This adds the enum of all the operations that can be taken on a block device. Signed-off-by: Fam Zheng f...@redhat.com --- qapi-schema.json | 49 + 1 file changed, 49 insertions(+) diff

Re: [Qemu-devel] [PATCH] inet_listen_opts: add error checking

2013-12-12 Thread Gerd Hoffmann
Hi, +if (port_offset) { +int baseport; +errno = 0; +baseport = strtol(port, NULL, 10); rant WHY is strtol() such a PAINFUL interface to use correctly? Crossed my mind too after reading the manpage, which sayed you should clear errno to reliable detect

Re: [Qemu-devel] [PATCH v7 01/10] qapi: Add BlockOperationType enum

2013-12-12 Thread Fam Zheng
On 2013年12月12日 20:21, Kevin Wolf wrote: Am 12.12.2013 um 09:23 hat Fam Zheng geschrieben: This adds the enum of all the operations that can be taken on a block device. Signed-off-by: Fam Zheng f...@redhat.com --- qapi-schema.json | 49 + 1

Re: [Qemu-devel] [PATCH] vnc: refuse to set a password with VNC_AUTH_NONE

2013-12-12 Thread Gerd Hoffmann
Hi, Isn't this backwards-incompatible? Yes. I think it is the correct thing nevertheless. Fine by me, let's just make sure we document it well. Can you start the 2.0 changelog wiki page? -ENOACCOUNT Anthony? Can you add me? uid kraxel please. cheers, Gerd

Re: [Qemu-devel] [PATCH 00/22] block: Support for 512b-on-4k emulation

2013-12-12 Thread Peter Lieven
Am 12.12.2013 10:47, schrieb Kevin Wolf: Am 12.12.2013 um 07:09 hat Peter Lieven geschrieben: Should it be possible to boot from a 4K-native drive with this series? If yes, I will run some test with some new iSCSI arrays we got for testing they can export 4k blocksize LUNs. Yes, you should be

Re: [Qemu-devel] RFC: kvm call reschedule

2013-12-12 Thread Michael S. Tsirkin
On Tue, Dec 10, 2013 at 04:23:25PM +0100, Kevin Wolf wrote: Am 10.12.2013 um 16:11 hat Juan Quintela geschrieben: Anthony can't assist this call, just in the middle of his commute. As it looks like a good idea that he can assit, can we move the call? Options so far are (his local

Re: [Qemu-devel] [PATCH v7 01/10] qapi: Add BlockOperationType enum

2013-12-12 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: This adds the enum of all the operations that can be taken on a block device. All operations? All blockable operations? Something else? Signed-off-by: Fam Zheng f...@redhat.com --- qapi-schema.json | 49 +

Re: [Qemu-devel] RFC: kvm call reschedule

2013-12-12 Thread Michael S. Tsirkin
On Thu, Dec 12, 2013 at 05:01:55PM +0800, Zhi Yong Wu wrote: On Tue, Dec 10, 2013 at 11:23 PM, Kevin Wolf kw...@redhat.com wrote: Am 10.12.2013 um 16:11 hat Juan Quintela geschrieben: Anthony can't assist this call, just in the middle of his commute. As it looks like a good idea that he

Re: [Qemu-devel] [PATCH v7 02/10] block: Introduce op_blockers to BlockDriverState

2013-12-12 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX elements. Each list is a list of blockers of an operation type (BlockOpType), that marks this BDS as currently blocked for a certain type of operation with reason errors stored in the

Re: [Qemu-devel] [PATCH v7 03/10] block: Parse backing option to reference existing BDS

2013-12-12 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 109 +- block/mirror.c| 2 +- include/block/block.h | 3 +- include/block/block_int.h | 3 ++ 4 files changed, 76

Re: [Qemu-devel] [PATCH v7 01/10] qapi: Add BlockOperationType enum

2013-12-12 Thread Fam Zheng
On 2013年12月12日 20:49, Markus Armbruster wrote: Fam Zheng f...@redhat.com writes: This adds the enum of all the operations that can be taken on a block device. All operations? All blockable operations? Something else? All QMP operations those apply on device, plus all operations those

Re: [Qemu-devel] [PATCH 1/8] ui/sdl2 : initial port to SDL 2.0 (v2.0)

2013-12-12 Thread Gerd Hoffmann
On Mi, 2013-12-11 at 11:12 +1000, Dave Airlie wrote: On Wed, Dec 11, 2013 at 12:35 AM, Gerd Hoffmann kra...@redhat.com wrote: Hi, The biggest changes were in the input handling, where SDL2 has done a major overhaul, and I've had to include a generated translation file to get from SDL2

[Qemu-devel] [PATCH] block: expect get_block_status errors in bdrv_make_zero

2013-12-12 Thread Peter Lieven
during testing around with 4k LUNs a bad target implementation triggert an -EIO in iscsi_get_block_status, but it got never caught resulting in an invinite loop. CC: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven p...@kamp.de --- block.c |5 + 1 file changed, 5 insertions(+) diff

Re: [Qemu-devel] RFC: kvm call reschedule

2013-12-12 Thread Zhi Yong Wu
On Thu, Dec 12, 2013 at 8:53 PM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Dec 12, 2013 at 05:01:55PM +0800, Zhi Yong Wu wrote: On Tue, Dec 10, 2013 at 11:23 PM, Kevin Wolf kw...@redhat.com wrote: Am 10.12.2013 um 16:11 hat Juan Quintela geschrieben: Anthony can't assist this call,

Re: [Qemu-devel] [Spice-devel] Vdagent not working on xen linux hvm DomUs

2013-12-12 Thread Fabio Fantoni
Il 11/12/2013 17:55, Wei Liu ha scritto: On Wed, Dec 11, 2013 at 05:11:37PM +0100, Fabio Fantoni wrote: Il 11/12/2013 16:38, Wei Liu ha scritto: On Wed, Dec 11, 2013 at 02:41:57PM +0100, Fabio Fantoni wrote: [...] Thanks for your reply. Before starting bisection I tried with qemu 1.3.1 from

[Qemu-devel] [RFC 0/7] dataplane: switch to N:M devices-per-thread model

2013-12-12 Thread Stefan Hajnoczi
This series moves the event loop thread out of dataplane code. It makes -iothread id=foo a separate concept. This makes it possible to bind several devices to the same iothread. Syntax: qemu -iothread id=iothread0 \ -device virtio-blk-pci,iothread=iothread0,x-data-plane=on,... For

[Qemu-devel] [RFC 1/7] rfifolock: add recursive FIFO lock

2013-12-12 Thread Stefan Hajnoczi
QemuMutex does not guarantee fairness and cannot be acquired recursively: Fairness means each locker gets a turn and the scheduler cannot cause starvation. Recursive locking is useful for composition, it allows a sequence of locking operations to be invoked atomically by acquiring the lock

[Qemu-devel] [RFC 2/7] aio: add aio_context_acquire() and aio_context_release()

2013-12-12 Thread Stefan Hajnoczi
It can be useful to run an AioContext from a thread which normally does not own the AioContext. For example, request draining can be implemented by acquiring the AioContext and looping aio_poll() until all requests have been completed. The following pattern should work: /* Event loop thread

[Qemu-devel] [RFC 3/7] iothread: add I/O thread object

2013-12-12 Thread Stefan Hajnoczi
This is a stand-in for Michael Roth's QContext. I expect this to be replaced once QContext is completed. The IOThread object is an AioContext event loop thread. This patch adds the concept of multiple event loop threads, allowing users to define them. When SMP guests run on SMP hosts it makes

[Qemu-devel] [RFC 5/7] qdev: add get_pointer_and_free() for temporary strings

2013-12-12 Thread Stefan Hajnoczi
get_pointer() assumes the string has unspecified lifetime (at least as long as the object is alive). In some cases we can only produce a temporary string that should be freed when get_pointer() is done. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/core/qdev-properties-system.c | 14

[Qemu-devel] [RFC 7/7] dataplane: replace internal thread with IOThread

2013-12-12 Thread Stefan Hajnoczi
Today virtio-blk dataplane uses a 1:1 device-per-thread model. Now that IOThreads have been introduced we can generalize this to N:M devices per threads. This patch drops thread code from dataplane in favor of running inside an IOThread AioContext. As a bonus we solve the case where a guest

[Qemu-devel] [RFC 4/7] iothread: command-line option

2013-12-12 Thread Stefan Hajnoczi
The -object option has several limitations that prevent it from fully instantiating an IOThread. Igor Mammedov and Paolo Bonzini are fixing -object. In the meantime, add a traditional -iothread command-line option that takes an identifier and keeps a global list of IOThreads. Signed-off-by:

[Qemu-devel] [RFC 6/7] iothread: add iothread qdev property type

2013-12-12 Thread Stefan Hajnoczi
Add a iothread qdev property type so devices can be hooked up to an IOThread from the comand-line: qemu -iothread id=iothread0 \ -device some-device,iothread=iothread0 Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/core/qdev-properties-system.c | 51

Re: [Qemu-devel] [PATCH v7 04/10] block: support dropping active in bdrv_drop_intermediate

2013-12-12 Thread Kevin Wolf
Am 12.12.2013 um 09:23 hat Fam Zheng geschrieben: Dropping intermediate could be useful both for commit and stream, and BDS refcnt plus bdrv_swap could do most of the job nicely. It also need some improvements in preparation for op blockers. Signed-off-by: Fam Zheng f...@redhat.com ---

Re: [Qemu-devel] [PATCH] block: expect get_block_status errors in bdrv_make_zero

2013-12-12 Thread Stefan Hajnoczi
On Thu, Dec 12, 2013 at 01:57:05PM +0100, Peter Lieven wrote: during testing around with 4k LUNs a bad target implementation triggert an -EIO in iscsi_get_block_status, but it got never caught resulting in an invinite loop. CC: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven p...@kamp.de

Re: [Qemu-devel] [PATCH 1/2] tcg: add TCGMemOp short constants for single byte loads

2013-12-12 Thread Aurelien Jarno
On Wed, Dec 11, 2013 at 11:07:20AM -0800, Richard Henderson wrote: On 12/11/2013 06:07 AM, Aurelien Jarno wrote: Cc: Richard Henderson r...@twiddle.net Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- tcg/tcg.h |6 ++ 1 file changed, 6 insertions(+) diff --git

[Qemu-devel] [PATCH v2] target-mips: Use new qemu_ld/st opcodes

2013-12-12 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- target-mips/translate.c | 119 +-- 1 file changed, 52 insertions(+), 67 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index e302734..ef0a2c3 100644 ---

Re: [Qemu-devel] save compiled qemu traces.

2013-12-12 Thread Laurent Desnogues
On Thu, Dec 12, 2013 at 5:07 AM, Xin Tong trent.t...@gmail.com wrote: see questions below. On Tue, Dec 10, 2013 at 12:25 AM, Alex Bennée alex.ben...@linaro.org wrote: trent.t...@gmail.com writes: Does anyone have profiles on how much time QEMU spends in translating instructions. QEMU does

Re: [Qemu-devel] Debugging with printf

2013-12-12 Thread Stefan Hajnoczi
On Wed, Dec 11, 2013 at 04:36:14PM +0200, Mar Tsan wrote: Hello. I'm working with Android Emulator (which as I understand is something like QEMU but not the same) and I would like to print messages concerning the Emulator. What I mean is that I want to edit the source code of the Emulator

Re: [Qemu-devel] QEMU+SystemC

2013-12-12 Thread Frederic Konrad
On 12/12/2013 01:09, Sean Xie wrote: Hi all, Recently I am struggling in examing the effect of host kernel I/O stacks on high-speed SSD, especially the new PCIe SSD, without the availability of the necessary hardware. After several reading online I found out QEMU+SystemC model environment

Re: [Qemu-devel] A question about virtio inside qemu

2013-12-12 Thread Stefan Hajnoczi
On Wed, Dec 11, 2013 at 08:55:33PM +, Yaodong Yang wrote: I have a quick question about the virtio inside qemu. When the user application sends to a specific virtual disk a large number of read requests in a very short time, where should these requests be queued? Inside the virtqueue?

Re: [Qemu-devel] [PATCH v7 06/10] block: Replace in_use with operation blocker

2013-12-12 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: This drops BlockDriverState.in_use with op_blockers: - Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1). - Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0). - Check bdrv_op_is_blocked() in place of bdrv_in_use(bs). The specific

[Qemu-devel] [PATCH] usb-host: add range checks for usb-host parameters

2013-12-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/host-libusb.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index fd320cd..164adf8 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -898,6 +898,19 @@ static

Re: [Qemu-devel] [PATCH v7 07/10] block: Pass error in bdrv_snapshot_create

2013-12-12 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: This allows descent error information to be reported. Signed-off-by: Fam Zheng f...@redhat.com --- block/snapshot.c | 5 +++-- blockdev.c | 2 +- include/block/snapshot.h | 3 ++- qemu-img.c | 2 +- savevm.c

Re: [Qemu-devel] [PATCH v7 08/10] block: Add checks of blocker in block operations

2013-12-12 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: Before operate on a BlockDriverState, respective types are checked against bs-op_blockers and it will error out if there's a blocker. Signed-off-by: Fam Zheng f...@redhat.com So this patch adds protection against two of the same kind simultaneously. How

Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support

2013-12-12 Thread Michael S. Tsirkin
On Wed, Dec 11, 2013 at 09:22:13PM +1100, Alexey Kardashevskiy wrote: With the great help from Paolo, I am presenting yet another try of bootindex support on sPAPR, this time with some QOM fixes. Details are in the commit messages. Please, comment. Thanks. Alexey Kardashevskiy (5):

Re: [Qemu-devel] [PATCH] Move hpet_find function from hpet.c to pc.c

2013-12-12 Thread Michael S. Tsirkin
On Wed, Dec 11, 2013 at 12:59:37PM +0100, mreza...@redhat.com wrote: From: Miroslav Rezanina mreza...@redhat.com Function hpet_find could not be used for checking hpet availability becouse it was not build when hpet was disabled. To allow proper use of this function, moving it from

Re: [Qemu-devel] [PATCH v3 0/6] Add error_abort and associated cleanups

2013-12-12 Thread Luiz Capitulino
On Thu, 12 Dec 2013 08:23:06 +0100 Markus Armbruster arm...@redhat.com wrote: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: On Wed, Dec 11, 2013 at 11:57 PM, Markus Armbruster arm...@redhat.com wrote: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: Following our

Re: [Qemu-devel] [PATCH] block: expect get_block_status errors in bdrv_make_zero

2013-12-12 Thread Kevin Wolf
Am 12.12.2013 um 14:31 hat Stefan Hajnoczi geschrieben: On Thu, Dec 12, 2013 at 01:57:05PM +0100, Peter Lieven wrote: during testing around with 4k LUNs a bad target implementation triggert an -EIO in iscsi_get_block_status, but it got never caught resulting in an invinite loop.

Re: [Qemu-devel] RFC: kvm call reschedule

2013-12-12 Thread Paolo Bonzini
Il 12/12/2013 13:52, Michael S. Tsirkin ha scritto: On Tue, Dec 10, 2013 at 04:23:25PM +0100, Kevin Wolf wrote: Am 10.12.2013 um 16:11 hat Juan Quintela geschrieben: Anthony can't assist this call, just in the middle of his commute. As it looks like a good idea that he can assit, can we

Re: [Qemu-devel] [PATCH v2 10/14] pci: allow 0 address for PCI IO regions

2013-12-12 Thread Michael S. Tsirkin
On Thu, Dec 05, 2013 at 11:33:48PM +, Peter Maydell wrote: On 5 December 2013 22:33, Michael Roth mdr...@linux.vnet.ibm.com wrote: Some kernels program a 0 address for io regions. PCI 3.0 spec sectio 6.2.5.1 doesn't seem to disallow this. Hmm. The last PCI spec I looked at said 0

[Qemu-devel] [PATCH] trace: add glib 2.32+ static GMutex support

2013-12-12 Thread Stefan Hajnoczi
The GStaticMutex API was deprecated in glib 2.32. We cannot switch over to GMutex unconditionally since we would drop support for older glib versions. But the deprecated API warnings during build are annoying so use static GMutex when possible. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com

[Qemu-devel] Fwd: [sheepdog] Call to sd_truncate()

2013-12-12 Thread Hadrien KOHL
Hello everyone, I am having trouble with my qemu guests. I am facing buffer input output errors on the guests' kernel log: [TIMESTAMP] Buffer I/O error on device vda1, logical block XX [TIMESTAMP] end_request: I/O error, dev vda, sector XX I am also reading in the qemu log:

Re: [Qemu-devel] [Spice-devel] Vdagent not working on xen linux hvm DomUs

2013-12-12 Thread Wei Liu
On Thu, Dec 12, 2013 at 02:10:23PM +0100, Fabio Fantoni wrote: [...] I did some other tests, I narrowed down the commit range to the one between: commit c9fea5d701f8fd33f0843728ec264d95cee3ed37 Mon, 22 Jul 2013 15:14:18 (Merge remote-tracking branch 'bonzini/iommu-for-anthony') where there

[Qemu-devel] [PATCH V5 0/7] Giving names to BlockDriverState graph nodes

2013-12-12 Thread Benoît Canet
v5: block empty node names [Kevin] factorize setting of node-name option [Kevin] NULL terminate node_name on removal [Kevin] make query-named-block-nodes return BlockDeviceInfo structure [Eric] Change some doc in query-named-block-nodes [Eric] Document the choice of the QMP

[Qemu-devel] [PATCH V5 2/7] block: Allow the user to define node-name option.

2013-12-12 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/block.c b/block.c index 481d566..1c57f0d 100644 --- a/block.c +++ b/block.c @@ -735,6 +735,39 @@ static int bdrv_open_flags(BlockDriverState *bs,

[Qemu-devel] [PATCH V5 1/7] block: Add bs-node_name to hold the name of a bs node of the bs graph.

2013-12-12 Thread Benoît Canet
Add the minimum of code to prepare for the following patches. Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 57 +++ include/block/block.h | 1 + include/block/block_int.h | 9 +++- 3 files changed, 52

[Qemu-devel] [PATCH V5 4/7] qmp: Allow to change password on named block driver states.

2013-12-12 Thread Benoît Canet
There was two candidate ways to implement named node manipulation: 1) { 'command': 'block_passwd', 'data': {'*device': 'str', '*node-name': 'str', 'password': 'str'} } 2) { 'command': 'block_passwd', 'data': {'device': 'str',

[Qemu-devel] [PATCH V5 3/7] qmp: Add a command to list the named BlockDriverState nodes.

2013-12-12 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 18 + block/qapi.c | 109 +- blockdev.c| 5 +++ include/block/block.h | 1 + include/block/qapi.h | 1 + qapi-schema.json | 16

[Qemu-devel] [PATCH V5 6/7] qmp: Allow block_resize to manipulate bs graph nodes.

2013-12-12 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- blockdev.c | 18 ++ hmp.c| 2 +- qapi-schema.json | 10 -- qmp-commands.hx | 3 ++- 4 files changed, 25 insertions(+), 8 deletions(-) diff --git a/blockdev.c b/blockdev.c index ebb8f48..374d03d 100644

[Qemu-devel] [PATCH V5 7/7] qmp: Allow to take external snapshots on bs graphs node.

2013-12-12 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- blockdev.c | 55 --- hmp.c| 4 +++- qapi-schema.json | 13 ++--- qmp-commands.hx | 11 ++- 4 files changed, 71 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PATCH V5 5/7] block: Create authorizations mechanism for external snapshot and resize.

2013-12-12 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 65 --- block/blkverify.c | 2 +- blockdev.c| 2 +- include/block/block.h | 20 +++ include/block/block_int.h | 12 ++--- 5

Re: [Qemu-devel] [PATCH] trace: add glib 2.32+ static GMutex support

2013-12-12 Thread Michael Tokarev
12.12.2013 18:52, Stefan Hajnoczi wrote: The GStaticMutex API was deprecated in glib 2.32. We cannot switch over to GMutex unconditionally since we would drop support for older glib versions. But the deprecated API warnings during build are annoying so use static GMutex when possible.

Re: [Qemu-devel] [PATCH v3] char: restore read callback on a reattached (hotplug) chardev

2013-12-12 Thread Eric Blake
On 12/12/2013 05:02 AM, Markus Armbruster wrote: Gal Hammer gham...@redhat.com writes: Fix a bug that was introduced in commit 386a5a1e. A removal of a device set the chr handlers to NULL. However when the device is plugged back, its read callback is not restored so data can't be transftered

Re: [Qemu-devel] [PATCH 5/11 v3 FIXED] qdev: add hotplugable property to Device

2013-12-12 Thread Igor Mammedov
On Wed, 11 Dec 2013 20:57:43 +0100 Markus Armbruster arm...@redhat.com wrote: Please spell it pluggable, both in C identifiers and strings. Sure, I'll respin series since it will touch several patches.

[Qemu-devel] Occasional clockjump in Win2012 after Live Migration

2013-12-12 Thread Peter Lieven
Hi, is anyone aware of a problem with a clock jump in Windows (observed in Server 2012) where after a successful live migration the clock jumps roughly 2 days into the future? Maybe this is already fixed we observed this with qemu-kvm-1.2.0. I have not yet managed to reproduce this, but it

Re: [Qemu-devel] [Spice-devel] Vdagent not working on xen linux hvm DomUs

2013-12-12 Thread Fabio Fantoni
Il 12/12/2013 16:23, Wei Liu ha scritto: On Thu, Dec 12, 2013 at 02:10:23PM +0100, Fabio Fantoni wrote: [...] I did some other tests, I narrowed down the commit range to the one between: commit c9fea5d701f8fd33f0843728ec264d95cee3ed37 Mon, 22 Jul 2013 15:14:18 (Merge remote-tracking branch

Re: [Qemu-devel] [PATCH 0/5] Monitor commands for object-add/del

2013-12-12 Thread Igor Mammedov
On Tue, 10 Dec 2013 18:00:23 +0100 Paolo Bonzini pbonz...@redhat.com wrote: These allow hotplugging (and hot-unplugging without leaking an object) virtio-rng devices. They can also be used for memory hotplug. Paolo Bonzini (5): rng: initialize file descriptor to -1 qom: fix leak for

Re: [Qemu-devel] [PATCH] inet_listen_opts: add error checking

2013-12-12 Thread Eric Blake
On 12/12/2013 05:27 AM, Gerd Hoffmann wrote: Hi, +if (port_offset) { +int baseport; +errno = 0; +baseport = strtol(port, NULL, 10); rant WHY is strtol() such a PAINFUL interface to use correctly? Crossed my mind too after reading the manpage, which

Re: [Qemu-devel] [PATCH 0/7] target-arm: Support AArch64 KVM

2013-12-12 Thread Peter Maydell
Last call for review/testing/comments on this patchset: I'm planning to do a target-arm pullreq early next week which will include this patchset. thanks -- PMM On 5 December 2013 15:23, Peter Maydell peter.mayd...@linaro.org wrote: Slightly over-eager ping for code review and/or testing, since

Re: [Qemu-devel] [PATCH v2] target-arm: add support for v8 AES instructions

2013-12-12 Thread Peter Maydell
On 5 December 2013 17:54, Ard Biesheuvel ard.biesheu...@linaro.org wrote: This adds support for the AESE/AESD/AESMC/AESIMC instructions that are available on some v8 implementations of Aarch32. Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org I finally managed to get set up to compare

Re: [Qemu-devel] [PATCH V5 5/7] Add max device width parameter for NOR devices

2013-12-12 Thread Peter Maydell
On 5 December 2013 21:35, Roy Franz roy.fr...@linaro.org wrote: For handling CFI and device ID reads, we need to not only know the width that a NOR flash device is configured for, but also its maximum width. The maximum width addressing mode is used for multi-width parts no matter which width

  1   2   >