Re: [Qemu-devel] [PATCHv2] ui/vnc: set TCP_NODELAY

2014-09-08 Thread Gerd Hoffmann
Hi, if (csock != -1) { +socket_set_nodelay(csock); vnc_connect(vs, csock, false, websocket); Added to vnc patch queue. thanks, Gerd

[Qemu-devel] [PATCH] translate-all.c: memory walker initial address miscalculation

2014-09-08 Thread m . ilin
From: Mikhail Ilyin m.i...@samsung.com The initial base address is miscalculated in walk_memory_regions(). It has to be shifted TARGET_PAGE_BITS more. Holder variables are extended to target_ulong size otherwise they don't fit for MIPS N32 (a 32-bit ABI with a 64-bit address space) and qemu won't

Re: [Qemu-devel] [libvirt] IO accounting overhaul

2014-09-08 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 01.09.2014 um 13:41 hat Markus Armbruster geschrieben: Benoît Canet benoit.ca...@irqsave.net writes: The Monday 01 Sep 2014 à 11:52:00 (+0200), Markus Armbruster wrote : Cc'ing libvirt following Stefan's lead. Benoît Canet

Re: [Qemu-devel] qcow2, lazy_refcounts and killing qemu

2014-09-08 Thread Markus Armbruster
Richard W.M. Jones rjo...@redhat.com writes: On Fri, Sep 05, 2014 at 04:39:51PM +0100, Stefan Hajnoczi wrote: Did you try older QEMU versions? I'm curious if this is something that crept in later or is fundamentally broken in lazy_refcounts=on. At your prompting, I've done a bit more

Re: [Qemu-devel] [PATCH v5 3/3] ivshmem: add check on protocol version in QEMU

2014-09-08 Thread Stefan Hajnoczi
On Fri, Sep 05, 2014 at 02:25:05PM +0200, David Marchand wrote: Hello Stefan, On 09/05/2014 12:29 PM, Stefan Hajnoczi wrote: On Thu, Sep 04, 2014 at 02:51:01PM +0200, David Marchand wrote: +server using a different protocol please check your setup\n); +

Re: [Qemu-devel] the whole virtual machine hangs when IO does not come back!

2014-09-08 Thread Stefan Hajnoczi
On Tue, Aug 12, 2014 at 09:10:26AM +0800, Bin Wu wrote: On 2014/8/11 22:21, Stefan Hajnoczi wrote: On Mon, Aug 11, 2014 at 04:33:21PM +0800, Bin Wu wrote: Hi, I tested the reliability of qemu in the IPSAN environment as follows: (1) create one VM on a X86 server which is connected to an

Re: [Qemu-devel] [PATCH v5 10/10] block/vvfat: fix setbuf stream parameter may be NULL

2014-09-08 Thread Stefan Hajnoczi
On Mon, Aug 11, 2014 at 04:53:09PM +0800, zhanghailiang wrote: From: Li Liu john.li...@huawei.com fopen() may return NULL which will cause setbuf() segmentfault Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Li Liu john.li...@huawei.com --- block/vvfat.c | 5

Re: [Qemu-devel] [RFC PATCH v6 00/14] Reverse execution.

2014-09-08 Thread Frederic Konrad
On 08/09/2014 10:29, Paolo Bonzini wrote: Il 08/09/2014 10:09, Frederic Konrad ha scritto: By the way how do you want to have this discussion? At the KVM forum? Or by phone on KVM phone call? Or both. :) Seriously, Pavel is presenting on record/replay at KVM Forum. I guess there will be

Re: [Qemu-devel] [PATCH V2 0/3] image-fuzzer: Support refcount structures in the qcow2 image generator

2014-09-08 Thread Stefan Hajnoczi
On Tue, Aug 19, 2014 at 04:25:10PM +0400, Maria Kustova wrote: This patch series was created for the 'block-next' branch and based on the next series: [PATCH V3] layout: Reduce number of generator functions in __init__ v0 - v1 (based on the review of Fam Zheng): * Fixed typos

Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-09-08 Thread Stefan Hajnoczi
On Sun, Sep 07, 2014 at 10:07:10PM +0300, Valentin Manea wrote: Did anybody get the chance to review this patch? It would be quite nice to integrate it before all the other openrisc changes, to get the IDE working also. Resending a patch as a reply in an existing thread increases the

Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-09-08 Thread Stefan Hajnoczi
On Sun, Aug 31, 2014 at 11:32:08AM +0300, Valentin Manea wrote: Set the IDE MMIO memory type to little endian. The ATA specs identify words part of the control commands encoded as little endian. While this has no impact on little endian systems, it's required for big endian systems(eg

Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-09-08 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 08/09/2014 11:07, Stefan Hajnoczi ha scritto: This patch changes the semantics of the sh4eb target (with the r2d machine type), where the mmio-ide registers currently don't need byteswapping. I guess a real big-endian SH4 with MMIO IDE

Re: [Qemu-devel] [libvirt] IO accounting overhaul

2014-09-08 Thread Kevin Wolf
Am 08.09.2014 um 09:12 hat Markus Armbruster geschrieben: Kevin Wolf kw...@redhat.com writes: Am 01.09.2014 um 13:41 hat Markus Armbruster geschrieben: Benoît Canet benoit.ca...@irqsave.net writes: The Monday 01 Sep 2014 à 11:52:00 (+0200), Markus Armbruster wrote : Cc'ing libvirt

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: fix filter of encryption option

2014-09-08 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 05:03:01PM +0800, Hu Tao wrote: On Fri, Aug 29, 2014 at 05:06:20PM +0100, Stefan Hajnoczi wrote: On Thu, Aug 28, 2014 at 04:56:03PM +0800, Hu Tao wrote: We should filter out encryption=on, too. Signed-off-by: Hu Tao hu...@cn.fujitsu.com ---

[Qemu-devel] [PATCH v6 3/3] ivshmem: add check on protocol version in QEMU

2014-09-08 Thread David Marchand
Send a protocol version as the first message from server, clients must close communication if they don't support this protocol version. Older QEMUs should be fine with this change in the protocol since they overrides their own vm_id on reception of an id associated to no eventfd. Signed-off-by:

[Qemu-devel] [PATCH v6 1/3] contrib: add ivshmem client and server

2014-09-08 Thread David Marchand
When using ivshmem devices, notifications between guests can be sent as interrupts using a ivshmem-server (typical use described in documentation). The client is provided as a debug tool. Signed-off-by: Olivier Matz olivier.m...@6wind.com Signed-off-by: David Marchand david.march...@6wind.com ---

[Qemu-devel] [PATCH v6 2/3] docs: update ivshmem device spec

2014-09-08 Thread David Marchand
Add some notes on the parts needed to use ivshmem devices: more specifically, explain the purpose of an ivshmem server and the basic concept to use the ivshmem devices in guests. Move some parts of the documentation and re-organise it. Signed-off-by: David Marchand david.march...@6wind.com

[Qemu-devel] [PATCH v6 0/3] ivshmem: update documentation, add client/server tools

2014-09-08 Thread David Marchand
Here is a patchset containing an update on ivshmem specs documentation and importing ivshmem server and client tools. These tools have been written from scratch and are not related to what is available in nahanni repository. I put them in contrib/ directory as the qemu-doc.texi was already telling

Re: [Qemu-devel] [RFC][patch 0/6] pci pass-through support for qemu/KVM on s390

2014-09-08 Thread Paolo Bonzini
Il 06/09/2014 01:19, Alexander Graf ha scritto: 1) interpretive execution of pci load/store instruction. If we use this function pci access does not get intercepted (no SIE exit) but is handled via microcode. To enable this we have to disable zpci device and enable it again with

Re: [Qemu-devel] [PATCH v6 3/3] ivshmem: add check on protocol version in QEMU

2014-09-08 Thread Michael S. Tsirkin
On Mon, Sep 08, 2014 at 11:17:50AM +0200, David Marchand wrote: Send a protocol version as the first message from server, clients must close communication if they don't support this protocol version. What's the motivation here? This is at best a way to break all clients if an incompatible

Re: [Qemu-devel] [PATCH v6 1/3] contrib: add ivshmem client and server

2014-09-08 Thread Michael S. Tsirkin
On Mon, Sep 08, 2014 at 11:17:48AM +0200, David Marchand wrote: ... diff --git a/configure b/configure index 961bf6f..a41a16c 100755 --- a/configure +++ b/configure @@ -4125,6 +4125,9 @@ if test $want_tools = yes ; then if [ $linux = yes -o $bsd = yes -o $solaris = yes ] ; then

Re: [Qemu-devel] [Bug 1362635] Re: bdrv_read co-routine re-entered recursively

2014-09-08 Thread Stefan Hajnoczi
On Mon, Sep 08, 2014 at 08:01:18AM -, senya wrote: Thanks.. I know about Fam's patch, but I need reverse delta backups, and Jagane's work is more appropriate then qemu snapshot approach. Jagane's approach needs a lot of work to make it mergable, that's why I suggested Fam's work. Stefan

Re: [Qemu-devel] qcow2, lazy_refcounts and killing qemu

2014-09-08 Thread Stefan Hajnoczi
On Fri, Sep 05, 2014 at 06:41:37PM +0100, Richard W.M. Jones wrote: On Fri, Sep 05, 2014 at 04:39:51PM +0100, Stefan Hajnoczi wrote: Did you try older QEMU versions? I'm curious if this is something that crept in later or is fundamentally broken in lazy_refcounts=on. At your prompting,

Re: [Qemu-devel] [PATCH v6 2/3] docs: update ivshmem device spec

2014-09-08 Thread Michael S. Tsirkin
On Mon, Sep 08, 2014 at 11:17:49AM +0200, David Marchand wrote: Add some notes on the parts needed to use ivshmem devices: more specifically, explain the purpose of an ivshmem server and the basic concept to use the ivshmem devices in guests. Move some parts of the documentation and

Re: [Qemu-devel] I/O parallelism on QCOW2

2014-09-08 Thread Stefan Hajnoczi
On Fri, Sep 05, 2014 at 12:45:27PM -0400, Xingbo Wu wrote: On Fri, Sep 5, 2014 at 6:02 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Sep 04, 2014 at 12:32:12PM -0400, Xingbo Wu wrote: After running a 16-thread sync-random-write test against qcow2, It is observed that QCOW2

Re: [Qemu-devel] [PATCH] spapr: Fix spapr_populate_memory() to compile on windows

2014-09-08 Thread Alexander Graf
On 08.09.14 01:59, Alexey Kardashevskiy wrote: This replaces gcc's ffsl() function (find first bit set in a word) with QEMU's ctzl (count trailing zeros). There are no corner cases in the affected code so simple replacement ffsl()-1 by ctzl() works. Signed-off-by: Alexey Kardashevskiy

[Qemu-devel] [PULL v2 00/24] Block patches

2014-09-08 Thread Stefan Hajnoczi
v2: * Dropped Fam's dataplane virtio header patches that break win32 build [Peter] The following changes since commit f102f224556f292f55b6e25147741bb8c48c9451: Merge remote-tracking branch 'remotes/afaerber/tags/qom-cpu-for-peter' into staging (2014-09-05 16:03:56 +0100) are available in

[Qemu-devel] [PULL 04/24] tests: Functions bus_foreach and device_find from libqos virtio API

2014-09-08 Thread Stefan Hajnoczi
From: Marc Marí marc.mari.barc...@gmail.com Virtio header has been changed to compile and work with a real device. Functions bus_foreach and device_find have been implemented for PCI. Virtio-blk test case now opens a fake device. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by:

[Qemu-devel] [PULL 02/24] pflash_cfi01: fixup stale DPRINTF() calls

2014-09-08 Thread Stefan Hajnoczi
From: Laszlo Ersek ler...@redhat.com Signed-off-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/block/pflash_cfi01.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index

[Qemu-devel] [PULL 07/24] libqos: Added indirect descriptor support to virtio implementation

2014-09-08 Thread Stefan Hajnoczi
From: Marc Marí marc.mari.barc...@gmail.com Add functions necessary for working with indirect descriptors. Add test using new functions. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com ---

[Qemu-devel] [PULL 03/24] pflash_cfi01: write flash contents to bdrv on incoming migration

2014-09-08 Thread Stefan Hajnoczi
From: Laszlo Ersek ler...@redhat.com A drive that backs a pflash device is special: - it is very small, - its entire contents are kept in a RAMBlock at all times, covering the guest-phys address range that provides the guest's view of the emulated flash chip. The pflash device model keeps

[Qemu-devel] [PULL 01/24] block: kill tail whitespace in block.c

2014-09-08 Thread Stefan Hajnoczi
From: Liu Yuan namei.u...@gmail.com Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Liu Yuan namei.u...@gmail.com Reviewed-by: Benoît Canet benoit.ca...@nodalink.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block.c | 2 +- 1 file changed, 1

[Qemu-devel] [PULL 09/24] libqos: Added MSI-X support

2014-09-08 Thread Stefan Hajnoczi
From: Marc Marí marc.mari.barc...@gmail.com Added MSI-X support for qtest PCI. Added MSI-X support for virtio-pci. Added MSI-X test case in virtio-blk-test. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/libqos/pci.c|

[Qemu-devel] [PULL 10/24] libqos: Added EVENT_IDX support

2014-09-08 Thread Stefan Hajnoczi
From: Marc Marí marc.mari.barc...@gmail.com Added avail_event and NO_NOTIFY check before notifying. Added used_event setting. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/libqos/virtio-pci.c | 1 + tests/libqos/virtio.c

[Qemu-devel] [PULL 05/24] tests: Add virtio device initialization

2014-09-08 Thread Stefan Hajnoczi
From: Marc Marí marc.mari.barc...@gmail.com Add functions to read and write virtio header fields. Add status bit setting in virtio-blk-device. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/Makefile| 2 +-

[Qemu-devel] [PULL 11/24] qemu-img: clarify src_cache option documentation

2014-09-08 Thread Stefan Hajnoczi
The source cache option takes the same values as the cache option. The documentation reads a little strange because it starts with In contrast the src_cache option The fact that this is comparing with the previous documented option (the 'cache' option) is implicit. Readers may be confused,

[Qemu-devel] [PULL 13/24] block/archipelago: Use QEMU atomic builtins

2014-09-08 Thread Stefan Hajnoczi
From: Chrysostomos Nanakos cnana...@grnet.gr Replace __sync builtins with ones provided by QEMU for atomic operations. Special thanks goes to Paolo Bonzini for his refactoring suggestion in order to use the already existing atomic builtins interface. Signed-off-by: Chrysostomos Nanakos

[Qemu-devel] [PULL 21/24] vmdk: fix vmdk_parse_extents() extent_file leaks

2014-09-08 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com Reviewed-by: Fam Zheng f...@redhat.com --- block/vmdk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/vmdk.c b/block/vmdk.c index 07cb62c..9bf28f3 100644 --- a/block/vmdk.c +++ b/block/vmdk.c

[Qemu-devel] [PULL 06/24] libqos: Added basic virtqueue support to virtio implementation

2014-09-08 Thread Stefan Hajnoczi
From: Marc Marí marc.mari.barc...@gmail.com Add status changing and feature negotiation. Add basic virtqueue support for adding and sending virtqueue requests. Add ISR checking. [Squashed request endianness fix by Greg Kurz gk...@linux.vnet.ibm.com --Stefan] Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PULL 16/24] qemu-nbd: fix indentation and coding style

2014-09-08 Thread Stefan Hajnoczi
From: Peter Lieven p...@kamp.de Signed-off-by: Peter Lieven p...@kamp.de Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Benoit Canet benoit.ca...@nodalink.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- qemu-nbd.c | 75

[Qemu-devel] [PULL 15/24] qemu-nbd: add option to set detect-zeroes mode

2014-09-08 Thread Stefan Hajnoczi
From: Peter Lieven p...@kamp.de Signed-off-by: Peter Lieven p...@kamp.de Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Benoit Canet benoit.ca...@nodalink.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- qemu-nbd.c | 25 + 1 file changed, 25

[Qemu-devel] [PULL 22/24] vmdk: fix buf leak in vmdk_parse_extents()

2014-09-08 Thread Stefan Hajnoczi
vmdk_open_sparse() does not take ownership of buf so the caller always needs to free it. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com Reviewed-by: Fam Zheng f...@redhat.com --- block/vmdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [PULL 08/24] libqos: Added test case for configuration changes in virtio-blk test

2014-09-08 Thread Stefan Hajnoczi
From: Marc Marí marc.mari.barc...@gmail.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/virtio-blk-test.c | 34 ++ 1 file changed, 34

[Qemu-devel] [PULL 20/24] ide: Add wwn support to IDE-ATAPI drive

2014-09-08 Thread Stefan Hajnoczi
From: John Snow js...@redhat.com Although it is possible to specify the wwn property for cdrom devices on the command line, the underlying driver fails to relay this information to the guest operating system via IDENTIFY. This is a simple patch to correct that. See ATA8-ACS, Table 22 parts 5,

[Qemu-devel] [PULL 14/24] rename parse_enum_option to qapi_enum_parse and make it public

2014-09-08 Thread Stefan Hajnoczi
From: Peter Lieven p...@kamp.de relaxing the license to LGPLv2+ is intentional. Suggested-by: Markus Armbruster arm...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Peter Lieven p...@kamp.de Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Benoit Canet

[Qemu-devel] [PULL 12/24] qemu-img: fix rebase src_cache option documentation

2014-09-08 Thread Stefan Hajnoczi
The src_cache option (-T) specifies the cache mode for backing files. It applies both the image's old backing file as well as the new backing file: ret = bdrv_open(bs_old_backing, backing_name, NULL, NULL, src_flags, old_backing_drv, local_err); if (ret) { ... } if

[Qemu-devel] [PULL 23/24] IDE: Fill the IDENTIFY request consistently

2014-09-08 Thread Stefan Hajnoczi
From: John Snow js...@redhat.com IDE-HD, IDE-ATAPI and IDE-CFATA all fill the identify buffer in slightly different ways, this is a relatively minor patch to make them uniform, to emphasize that: (1) We build the s-identify_data cache first, then (2) We copy it to s-io_buffer to fulfill the

[Qemu-devel] [PULL 19/24] qtest/ide: Uninitialize PC allocator

2014-09-08 Thread Stefan Hajnoczi
From: John Snow js...@redhat.com Use the new call to pc_alloc_uninit as a test for the new pathways. The leak checking / assert pathways are not enabled in this patch, leaving this as an option to future test writers. Signed-off-by: John Snow js...@redhat.com Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 17/24] MAINTAINERS: update sheepdog maintainer

2014-09-08 Thread Stefan Hajnoczi
From: MORITA Kazutaka morita.kazut...@gmail.com Hitoshi takes over sheepdog maintenance from me. Signed-off-by: MORITA Kazutaka morita.kazut...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/52] ppc patch queue 2014-09-04

2014-09-08 Thread Alexander Graf
On 05.09.14 12:36, Peter Maydell wrote: On 4 September 2014 23:17, Alexander Graf ag...@suse.de wrote: Peter, please pull the same tag name again - I updated it with the now working state. Doesn't build on Windows: hw/ppc/spapr.o: In function `spapr_populate_memory':

Re: [Qemu-devel] [PATCH v2 0/2] block: Always compile virtio-blk dataplane

2014-09-08 Thread Stefan Hajnoczi
On Tue, Sep 02, 2014 at 11:42:14AM +0800, Fam Zheng wrote: v2: Import virtio_vring.h. Fam Zheng (2): virtio: Import virtio_vring.h block: Always compile virtio-blk dataplane configure | 21 + hw/block/Makefile.objs | 2 +-

Re: [Qemu-devel] [PATCH v5 10/10] block/vvfat: fix setbuf stream parameter may be NULL

2014-09-08 Thread Michael Tokarev
08.09.2014 12:37, Stefan Hajnoczi wrote: On Mon, Aug 11, 2014 at 04:53:09PM +0800, zhanghailiang wrote: From: Li Liu john.li...@huawei.com fopen() may return NULL which will cause setbuf() segmentfault [] This no longer exists: commit 13b552c2f43298a42e26d7aec7b58a5c205b75a0 Author:

Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-09-08 Thread Michael Tokarev
08.09.2014 13:07, Stefan Hajnoczi wrote: This patch changes the semantics of the sh4eb target (with the r2d machine type), where the mmio-ide registers currently don't need byteswapping. I guess a real big-endian SH4 with MMIO IDE *should* byteswap but want to double-check. Does anyone

Re: [Qemu-devel] [PATCH v2 0/2] block: Always compile virtio-blk dataplane

2014-09-08 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 08/09/2014 12:56, Stefan Hajnoczi ha scritto: On Tue, Sep 02, 2014 at 11:42:14AM +0800, Fam Zheng wrote: v2: Import virtio_vring.h. Fam Zheng (2): virtio: Import virtio_vring.h block: Always compile virtio-blk dataplane configure

[Qemu-devel] [PULL 24/24] ide: Add resize callback to ide/core

2014-09-08 Thread Stefan Hajnoczi
From: John Snow js...@redhat.com Currently, if the block device backing the IDE drive is resized, the information about the device as cached inside of the IDEState structure is not updated, thus when a guest OS re-queries the drive, it is unable to see the expanded size. This patch adds a resize

Re: [Qemu-devel] [PATCH] Fix improper usage of cpu_to_be32 in vpc

2014-09-08 Thread Kevin Wolf
Am 05.09.2014 um 20:40 hat 21G geschrieben: cpu_to_be32() is wrong since vhd_type is an enum constant (just a regular CPU-endian integer). Signed-off-by: Xiaodong Gong gordongong0...@gmail.com Please use 'git send-email' to send patches. Neither 'git am' nor 'patch' can seem to apply this

Re: [Qemu-devel] [PATCH 3/3] target-ppc: virtex-ml507 machine type should depend on CONFIG_XILINX

2014-09-08 Thread Alexander Graf
On 26.08.14 06:30, David Gibson wrote: The virtex-ml507 is a Xilinx CPU based system, and requires several sub devices which are only included with CONFIG_XILINX. Therefore, it should only be compiled if CONFIG_XILINX is set. Signed-off-by: David Gibson da...@gibson.dropbear.id.au

[Qemu-devel] [PULL 18/24] libqos: add a simple first-fit memory allocator

2014-09-08 Thread Stefan Hajnoczi
From: John Snow js...@redhat.com Implement a simple first-fit memory allocator that attempts to keep track of leased blocks of memory in order to be able to re-use blocks. Additionally, allow the user to specify when initializing the device that upon cleanup, we would like to assert that there

[Qemu-devel] [PATCH] arch_init: Setting QEMU_ARCH enum straight

2014-09-08 Thread Bastian Koppelmann
Every QEMU_ARCH is now hexadecimal instead of a mixture of decimal and hexadecimal. Signed-off-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de --- include/sysemu/arch_init.h | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] spapr: Cleanup machine naming conventions, and prepare for 2.2 release

2014-09-08 Thread Alexander Graf
On 08.09.14 07:30, David Gibson wrote: As of qemu-2.1, spapr/pseries, has a set of versioned machine classes to represent the machine type as it appeared to the guest in different qemu versions. This allows for safe migration of guests between current and future qemu versions. However,

Re: [Qemu-devel] Supporting multiple CPU AddressSpaces and memory transaction attributes

2014-09-08 Thread Peter Maydell
On 7 September 2014 02:47, Edgar E. Iglesias edgar.igles...@gmail.com wrote: On Thu, Sep 04, 2014 at 06:47:58PM +0100, Peter Maydell wrote: We introduce the concept of memory transaction attributes, which are a guest-CPU specific bunch of bits (say, a uint32_t). We also allow the CPU to have

Re: [Qemu-devel] [PATCH v7 05/28] bootindex: rework add_boot_device_path function

2014-09-08 Thread Gonglei
Subject: Re: [Qemu-devel] [PATCH v7 05/28] bootindex: rework add_boot_device_path function On Fri, Sep 05, 2014 at 04:37:13PM +0800, arei.gong...@huawei.com wrote: [...] +static void del_original_boot_device(DeviceState *dev, const char *suffix) +{ +FWBootEntry *i; + +if

Re: [Qemu-devel] VFIO NATIVE_ENDIAN regions question

2014-09-08 Thread Alexander Graf
On 08.09.14 02:06, Alexey Kardashevskiy wrote: On 09/08/2014 06:35 AM, Alexander Graf wrote: On 06.09.14 04:49, Alexey Kardashevskiy wrote: At the moment VFIO's BARs are NATIVE_ENDIAN. The idea is that since it does not parse BARs content and just provides transport, it should not do byte

Re: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom property

2014-09-08 Thread Gonglei
Subject: Re: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom property On Fri, Sep 05, 2014 at 04:37:32PM +0800, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property, things

Re: [Qemu-devel] [PATCH v7 08/28] virtio-net: add bootindex to qom property

2014-09-08 Thread Gonglei
Subject: Re: [Qemu-devel] [PATCH v7 08/28] virtio-net: add bootindex to qom property On Fri, Sep 05, 2014 at 04:37:16PM +0800, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com Add a qom property with the same name 'bootindex', when we remove it form qdev property,

Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-09-08 Thread Peter Maydell
On 8 September 2014 10:07, Stefan Hajnoczi stefa...@gmail.com wrote: This patch changes the semantics of the sh4eb target (with the r2d machine type), where the mmio-ide registers currently don't need byteswapping. I guess a real big-endian SH4 with MMIO IDE *should* byteswap but want to

[Qemu-devel] [PATCH v2 2/3] timers: Move NANOSECONDS_PER_SECONDS to timer.h for future reuse

2014-09-08 Thread Benoît Canet
Signed-off-by: Benoît Canet benoit.ca...@nodalink.com --- include/qemu/throttle.h | 2 -- include/qemu/timer.h| 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qemu/throttle.h b/include/qemu/throttle.h index 8f9e611..1c639d2 100644 --- a/include/qemu/throttle.h

[Qemu-devel] [PATCH v2 1/3] throttle: Make NANOSECONDS_PER_SECOND an integer

2014-09-08 Thread Benoît Canet
We will want to reuse this define in the future by making it common to multiples QEMU modules. It would be safer that this define be an integer so we avoid stranges float rounding errors. Do this conversion. Signed-off-by: Benoît Canet benoit.ca...@nodalink.com --- include/qemu/throttle.h | 2 +-

[Qemu-devel] [PATCH v2 3/3] util: Add an utility infrastructure used to compute an average on a time slice

2014-09-08 Thread Benoît Canet
The algorithm used was defined on the list while discussing the new IO accounting overhaul. See http://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg04954.html Also the module takes care of computing minimal and maximal values over the time slice duration. Signed-off-by: Benoît Canet

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/52] ppc patch queue 2014-09-04

2014-09-08 Thread Peter Maydell
On 8 September 2014 11:52, Alexander Graf ag...@suse.de wrote: On 05.09.14 12:36, Peter Maydell wrote: On 4 September 2014 23:17, Alexander Graf ag...@suse.de wrote: Peter, please pull the same tag name again - I updated it with the now working state. Doesn't build on Windows:

[Qemu-devel] [PATCH v2 0/3] Add the infrastructure that will be used to compute I/O accouting averages

2014-09-08 Thread Benoît Canet
Tiny module of code to maintain and compute timed average on a given period. It comes with unit tests so we are sure the code will not bitrot while waiting for the accouting code to use it. in v2: Make NANOSECONDS_PER_SECONDS an integer [Peter, Eric] Change module's license

Re: [Qemu-devel] [PULL 3/4] vfio: Make BARs native endian

2014-09-08 Thread Alexander Graf
On 30.06.14 19:28, Alex Williamson wrote: From: Alexey Kardashevskiy a...@ozlabs.ru Slow BAR access path is used when VFIO fails to mmap() BAR. Since this is just a transport between the guest and a device, there is no need to do endianness swapping. This changes BARs to use native

Re: [Qemu-devel] VFIO NATIVE_ENDIAN regions question

2014-09-08 Thread Alexey Kardashevskiy
On 09/08/2014 10:04 PM, Alexander Graf wrote: On 08.09.14 02:06, Alexey Kardashevskiy wrote: On 09/08/2014 06:35 AM, Alexander Graf wrote: On 06.09.14 04:49, Alexey Kardashevskiy wrote: At the moment VFIO's BARs are NATIVE_ENDIAN. The idea is that since it does not parse BARs content

Re: [Qemu-devel] [PATCH v3] target-arm: Fix resetting issues on ARMv7-M CPUs

2014-09-08 Thread Martin Galvan
On Sat, Sep 6, 2014 at 8:00 AM, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Sat, Sep 6, 2014 at 8:42 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 6 September 2014 03:45, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: CC Alistair who is into ARMv7M On Sat, Sep 6,

Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in transports

2014-09-08 Thread Gonglei
Subject: Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in transports On Fri, Sep 05, 2014 at 11:46:32PM +0800, Gonglei wrote: Hi, Subject: Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in transports On Thu, Sep 04, 2014 at

Re: [Qemu-devel] [PATCH v3] target-arm: Fix resetting issues on ARMv7-M CPUs

2014-09-08 Thread Peter Maydell
On 8 September 2014 13:37, Martin Galvan martin.gal...@tallertechnologies.com wrote: On Sat, Sep 6, 2014 at 8:00 AM, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Sat, Sep 6, 2014 at 8:42 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 6 September 2014 03:45, Peter

[Qemu-devel] [BUG] Guest kernel divide error in kvm_unlock_kick

2014-09-08 Thread Chris Webb
I've reported this bug before, which reliably crashes a guest kernel shortly after boot, but have just reconfirmed that it is still present with Linux 3.16.2 guest and host kernels and Qemu 2.1. Running a 3.16.2 x86-64 SMP guest kernel on qemu-2.1, with kvm enabled and -cpu host on a 3.16.2 AMD

Re: [Qemu-devel] [PATCH] translate-all.c: memory walker initial address miscalculation

2014-09-08 Thread m . ilin
From: Mikhail Ilyin m.i...@samsung.com The initial base address is miscalculated in walk_memory_regions(). It has to be shifted TARGET_PAGE_BITS more. Holder variables are extended to target_ulong size otherwise they don't fit for MIPS N32 (a 32-bit ABI with a 64-bit address space) and qemu won't

Re: [Qemu-devel] [PULL 01/12] pci: Use bus master address space for delivering MSI/MSI-X messages

2014-09-08 Thread Michael S. Tsirkin
On Thu, Aug 14, 2014 at 06:08:44PM +0200, Michael S. Tsirkin wrote: From: Jan Kiszka jan.kis...@siemens.com The spec says (and real HW confirms this) that, if the bus master bit is 0, the device will not generate any PCI accesses. MSI and MSI-X messages fall among these, so we should use the

Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests

2014-09-08 Thread Benoît Canet
The Friday 05 Sep 2014 à 18:51:26 (+0200), Peter Lieven wrote : Signed-off-by: Peter Lieven p...@kamp.de --- block.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/block.c b/block.c index 2c4a5de..fa4c34b 100644 --- a/block.c +++ b/block.c @@ -3215,6 +3215,13 @@

Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests

2014-09-08 Thread Paolo Bonzini
Il 08/09/2014 15:56, Peter Lieven ha scritto: Look like you are changing the coroutine version. Some hardware like virtio-blk uses the AIO version of read and writes. What would happen if all the block drivers down the chain are AIO enabled ? The AIO version still goes through

Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests

2014-09-08 Thread Peter Lieven
On 08.09.2014 15:58, Paolo Bonzini wrote: Il 08/09/2014 15:56, Peter Lieven ha scritto: Look like you are changing the coroutine version. Some hardware like virtio-blk uses the AIO version of read and writes. What would happen if all the block drivers down the chain are AIO enabled ? The AIO

[Qemu-devel] [PATCH] Fix improper usage of cpu_to_be32 in vpc

2014-09-08 Thread Xiaodong Gong
From: Xiaodong Gong gordongong0...@gmail.com cpu_to_be32() is wrong since vhd_type is an enum constant (just a regular CPU-endian integer). Signed-off-by: Xiaodong Gong gordongong0...@gmail.com --- block/vpc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 4/5] qcow2: Check L1/L2/reftable entries for alignment

2014-09-08 Thread Benoît Canet
The Friday 05 Sep 2014 à 16:07:18 (+0200), Max Reitz wrote : Offsets taken from the L1, L2 and refcount tables are generally assumed to be correctly aligned. However, this cannot be guaranteed if the image has been written to by something different than qemu, thus check all offsets taken from

[Qemu-devel] [PATCH v2] Support vhd type VHD_DIFFERENCING

2014-09-08 Thread Xiaodong Gong
From: Xiaodong Gong gordongong0...@gmail.com Now qemu only supports vhd type VHD_FIXED and VHD_DYNAMIC, so qemu can't read snapshot volume of vhd, and can't support other storage features of vhd file. This patch add read parent information in function vpc_open, read bitmap in vpc_read, and

Re: [Qemu-devel] [PATCH] block: extend BLOCK_IO_ERROR event with nospace indicator

2014-09-08 Thread Luiz Capitulino
On Fri, 29 Aug 2014 16:07:27 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: Management software, such as RHEV's vdsm, want to be able to allocate disk space on demand. The basic use case is to start a VM with a small disk and then the disk is enlarged when QEMU hits a ENOSPC condition.

Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests

2014-09-08 Thread Paolo Bonzini
Il 08/09/2014 16:35, Peter Lieven ha scritto: messages. :) So you would not throw an error msg here? No, though a trace could be useful. Is there a howto somewhere how to implement that? Try commit 4ac4458076e1aaf3b01a6361154117df20e22215. Whats your opinion changed the max_xfer_len to

Re: [Qemu-devel] [PATCH v2 1/3] throttle: Make NANOSECONDS_PER_SECOND an integer

2014-09-08 Thread Eric Blake
On 09/08/2014 06:18 AM, Benoît Canet wrote: We will want to reuse this define in the future by making it common to multiples s/multiples/multiple/ QEMU modules. It would be safer that this define be an integer so we avoid stranges float s/stranges/strange/ rounding errors. Do this

Re: [Qemu-devel] [PATCH v2 3/3] util: Add an utility infrastructure used to compute an average on a time slice

2014-09-08 Thread Benoît Canet
The Monday 08 Sep 2014 à 16:29:26 (+0200), Paolo Bonzini wrote : Il 08/09/2014 14:18, Benoît Canet ha scritto: The algorithm used was defined on the list while discussing the new IO accounting overhaul. See http://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg04954.html Also

[Qemu-devel] [Bug 1366836] [NEW] Core2Duo and KVM may not boot Win8 properly on 3.x kernels

2014-09-08 Thread Erik Rull
Public bug reported: When I start up QEMU w/ KVM 1.7.0 on a Core2Duo machine running a vanilla kernel 3.4.67 or 3.10.12 to run a Windows 8.0 guest, the guest freezes at Windows 8 boot without any error. When I dump the CPU registers via info registers, nothing changes, that means the system

Re: [Qemu-devel] [PATCH v2 2/3] timers: Move NANOSECONDS_PER_SECONDS to timer.h for future reuse

2014-09-08 Thread Eric Blake
On 09/08/2014 06:18 AM, Benoît Canet wrote: Signed-off-by: Benoît Canet benoit.ca...@nodalink.com --- include/qemu/throttle.h | 2 -- include/qemu/timer.h| 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat

Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests

2014-09-08 Thread Peter Lieven
On 08.09.2014 16:42, Paolo Bonzini wrote: Il 08/09/2014 16:35, Peter Lieven ha scritto: messages. :) So you would not throw an error msg here? No, though a trace could be useful. Is there a howto somewhere how to implement that? Try commit 4ac4458076e1aaf3b01a6361154117df20e22215. Thanks

[Qemu-devel] [Bug 1366836] Re: Core2Duo and KVM may not boot Win8 properly on 3.x kernels

2014-09-08 Thread Erik Rull
** Description changed: - When I start up QEMU w/ KVM 1.7.0 on a Core2Duo machine running a vanilla kernel - 3.4.67 or 3.10.12 to run a Windows 8.0 guest, the guest freezes at Windows 8 boot without any error. - When I dump the CPU registers via info registers, nothing changes, that means -

Re: [Qemu-devel] [PATCH v2 3/3] util: Add an utility infrastructure used to compute an average on a time slice

2014-09-08 Thread Paolo Bonzini
Il 08/09/2014 16:49, Benoît Canet ha scritto: - create two windows, with twice the suggested expiration period, and return min/avg/max from the oldest window. Example t=0 |t=1 |t=2 |t=3 |t=4 wnd0: [0,1) |wnd0: [1,3) |

[Qemu-devel] [Bug 1366836] Re: Core2Duo and KVM may not boot Win8 properly on 3.x kernels

2014-09-08 Thread Erik Rull
** Description changed: When I start up QEMU w/ KVM 1.7.0 on a Core2Duo machine running a vanilla kernel 3.4.67 or 3.10.12 to run a Windows 8.0 guest, the guest freezes at Windows 8 boot without any error. When I dump the CPU registers via info registers, nothing changes, that means the

Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests

2014-09-08 Thread ronnie sahlberg
On Mon, Sep 8, 2014 at 7:42 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 08/09/2014 16:35, Peter Lieven ha scritto: messages. :) So you would not throw an error msg here? No, though a trace could be useful. Is there a howto somewhere how to implement that? Try commit

Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests

2014-09-08 Thread Paolo Bonzini
Il 08/09/2014 17:13, ronnie sahlberg ha scritto: What I would like to see would also be to report these limitations to the guest itself to prevent it from generating too large I/Os. That's difficult because you don't want a backend change (e.g. from local storage to iSCSI) to change the vital

Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests

2014-09-08 Thread Peter Lieven
On 08.09.2014 17:13, ronnie sahlberg wrote: On Mon, Sep 8, 2014 at 7:42 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 08/09/2014 16:35, Peter Lieven ha scritto: messages. :) So you would not throw an error msg here? No, though a trace could be useful. Is there a howto somewhere how to

Re: [Qemu-devel] [PATCH 1/2] tcg: Compress TCGLabelQemuLdst

2014-09-08 Thread Claudio Fontana
Reviewed-by: Claudio Fontana claudio.font...@huawei.com On 03.09.2014 18:46, Richard Henderson wrote: Use 1 32-bit word instead of 6. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/tcg-be-ldst.h | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff

Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests

2014-09-08 Thread Peter Lieven
On 08.09.2014 17:15, Paolo Bonzini wrote: Il 08/09/2014 17:13, ronnie sahlberg ha scritto: What I would like to see would also be to report these limitations to the guest itself to prevent it from generating too large I/Os. That's difficult because you don't want a backend change (e.g. from

  1   2   >