struct kvm_msrs contains padding bytes. Let's use a designated
initializer on the info part to avoid false positives from
valgrind/memcheck. Do the same for generic MSRS, the TSC and
feature control.
We also need to zero out the reserved fields in the entries.
We do this in kvm_msr_entry_set as
kvm_clock_data contains pad fields. Let's use a designated
initializer to avoid false positives from valgrind/memcheck.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
hw/i386/kvm/clock.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/i386/kvm/clock.c
struct kvm_xcrs contains padding bytes. Let's use a designated
initializer to avoid false positives from valgrind/memcheck.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
target-i386/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/kvm.c
struct kvm_fpu contains an alignment padding on s390x. Let's use a
designated initializer to avoid false positives from valgrind/memcheck.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
target-s390x/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Paolo Bonzini reported that Coverity reports an uninitialized pad value.
Let's use a designated initializer for kvm_irq_routing_entry to avoid
this false positive. This is similar to kvm_irqchip_add_msi_route and
other users of kvm_irq_routing_entry.
Signed-off-by: Christian Borntraeger
On 11/20/2014 10:06 AM, Max Reitz wrote:
Add a helper function for reallocating a refcount array, independent of
the refcount order. The newly allocated space is zeroed and the function
handles failed reallocations gracefully.
The helper function will always align the buffer size to a
On 11/20/2014 10:06 AM, Max Reitz wrote:
Since refcounts do not always have to be a uint16_t, all refcount blocks
and arrays in memory should not have a specific type (thus they become
pointers to void) and for accessing them, two helper functions are used
(a getter and a setter). Those
On 11/20/2014 10:06 AM, Max Reitz wrote:
Add helper functions for getting and setting refcounts in a refcount
array for any possible refcount order, and choose the correct one during
refcount initialization.
Signed-off-by: Max Reitz mre...@redhat.com
---
block/qcow2-refcount.c | 124
On 11/20/2014 10:06 AM, Max Reitz wrote:
Add a refcount_order parameter to qcow2_create2(), use that value for
the image header and for calculating the size required for
preallocation.
For now, always pass 4.
This addition requires changes to the calculation of the file size for
the full
On 11/20/2014 10:06 AM, Max Reitz wrote:
Progress may regress; this should be displayed correctly by
qemu_progress_print().
Signed-off-by: Max Reitz mre...@redhat.com
---
util/qemu-progress.c | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake ebl...@redhat.com
diff --git
** Description changed:
+ ==
+ Impact: occasional qcow2 corruption
+ Test case: see the qemu-img command below
+ Regression potential: this cherrypicks a patch from upstream to a
not-insignificantly older qemu source tree. While the
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1() to
pc_machine_initfn().
xen_enabled() does not return the correct value in
pc_machine_initfn().
Changed vmport from a bool to an enum. Added the
Hi Serge,
Is there any chance these fixes will go into trusty?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1368815
Title:
qemu-img convert intermittently corrupts output images
Status in
On 11/20/2014 10:06 AM, Max Reitz wrote:
Add a test for conversion between different refcount widths and errors
specific to certain widths (i.e. snapshots with refcount_width=1).
Signed-off-by: Max Reitz mre...@redhat.com
---
tests/qemu-iotests/112 | 278
On 11/20/2014 01:55 AM, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
---
hw/pci/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
adding qemu-trivial in cc. This is a candidate for 2.2.
Reviewed-by: Eric
On 11/20/2014 04:04 AM, Stefan Hajnoczi wrote:
We're only talking about an optimisation here, even though a very
useful one, so I wouldn't easily make compromises here. We should
probably insist on using the node-name. Management tools need new code
anyway to make use of the new
On 11/20/2014 03:34 AM, Vladimir Sementsov-Ogievskiy wrote:
QDB file is for storing dirty bitmap. The specification is based on
qcow2 specification.
Saving several bitmaps is necessary when server shutdowns during
backup. In this case 2 tables for each disk are available. One
collected for
On 2014/11/21 8:01, Eric Blake wrote:
On 11/20/2014 01:55 AM, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
---
hw/pci/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
adding qemu-trivial in cc. This is
On 2014/11/18 10:47, Gonglei (Arei) wrote:
From: Gonglei arei.gong...@huawei.com
Reported-by:
https://bugs.launchpad.net/qemu/+bug/1393440
Signed-off-by: Gonglei arei.gong...@huawei.com
---
hw/pci/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 11/20/2014 07:35 PM, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
s-xmit_pos maybe assigned to a negative value (-1),
but in this branch variable s-xmit_pos as an index to
array s-buffer. Let's add a check for s-xmit_pos.
Signed-off-by: Gonglei
On 11/20/2014 07:35 PM, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
Coverity spot:
Assigning: iov = struct iovec [3]({{buf, 12UL},
{(void *)dot1q_buf, 4UL},
{buf + 12, size - 12}})
(address of temporary variable of
This fixes a crash by just skipping the vte resize hack if cur is NULL.
Reproducer:
qemu-system-x86_64 -nodefaults
Signed-off-by: Fam Zheng f...@redhat.com
---
ui/gtk.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index
On Thu, Nov 20, 2014 at 05:32:56PM -0500, Don Slutz wrote:
[...]
@@ -1711,18 +1711,23 @@ static void pc_machine_set_max_ram_below_4g(Object
*obj, Visitor *v,
pcms-max_ram_below_4g = value;
}
-static bool pc_machine_get_vmport(Object *obj, Error **errp)
+static void
Hi David,
When i migrated VM in postcopy way when configuring VM with '-realtime
mlock=on' option,
It failed, and reports postcopy_ram_hosttest: remap_anon_pages not available: File
exists in destination,
Is it a bug of userfaultfd API?
cc: Andrea
reproduce Steps:
Source:
qemu-postcopy/qemu
Hi Tony,
yes, I've uploaded a proposed fix for trusty-proposed earlier today. It
should be available for testing as soon as it is accepted.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1368815
On (Thu) 20 Nov 2014 [09:16:31], Igor Mammedov wrote:
On Thu, 20 Nov 2014 09:49:20 +0530
Amit Shah amit.s...@redhat.com wrote:
On (Wed) 19 Nov 2014 [11:08:46], Igor Mammedov wrote:
On Wed, 19 Nov 2014 12:51:00 +0530
Amit Shah amit.s...@redhat.com wrote:
-static void
@Leen,
I am pushing qemu 2.1+dfsg-4ubuntu6.3~ppa1 (which includes the fix
proposed by Gonglei in comment #7) to ppa:serge-hallyn/libvirt-testing.
Please let us know whether it does in fact solve your issue.
** Also affects: qemu (Ubuntu)
Importance: Undecided
Status: New
** Changed
Awesome.
Thanks!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1368815
Title:
qemu-img convert intermittently corrupts output images
Status in OpenStack Compute (Nova):
In Progress
Status in
Eric Blake wrote on 2014-11-06:
Hi Eric
Thanks for your review and comment.
On 11/06/2014 12:08 PM, Li Liang wrote:
Instead of sending the guest memory directly, this solution compress
the ram page before sending, after receiving, the data will be
decompressed.
This feature can help to
On Wed, Nov 19, 2014 at 05:53:54PM +, Dr. David Alan Gilbert wrote:
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Fri, Oct 03, 2014 at 06:47:30PM +0100, Dr. David Alan Gilbert (git)
wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
Use that to split the
On Wed, Nov 19, 2014 at 05:50:11PM +, Dr. David Alan Gilbert wrote:
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Fri, Oct 03, 2014 at 06:47:25PM +0100, Dr. David Alan Gilbert (git)
wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
Postcopy needs to have two
+static void migrate_put_be32(MigBuf *f, unsigned int v)
+{
+migrate_put_byte(f, v 24);
+migrate_put_byte(f, v 16);
+migrate_put_byte(f, v 8);
+migrate_put_byte(f, v);
+}
+
+static void migrate_put_be64(MigBuf *f, uint64_t v)
+{
+migrate_put_be32(f, v
Hi,
I know recent Intel chips (eg, baytrail) have a builtin sdhci
controller (eg, 8086:0f16). However, that has quirks defined in the
Linux driver. Basic functionality still does seem to work though when
I use those ids in qemu. The same basic functionality also seems to
work when I use
On 2014/11/21 1:38, Andrea Arcangeli wrote:
Hi,
On Thu, Nov 20, 2014 at 10:54:29AM +0800, zhanghailiang wrote:
Yes, you are right. This is what i really want, bypass all non-present faults
and only track strict wrprotect faults. ;)
So, do you plan to support that in the userfault API?
Yes I
On 2014/11/6 19:08, Li Liang wrote:
Instead of sending the guest memory directly, this solution compress
the ram page before sending, after receiving, the data will be
decompressed.
This feature can help to reduce the data transferred about
60%, this is very useful when the network bandwidth
+int migrate_compress_threads(void)
+{
+MigrationState *s;
+
+s = migrate_get_current();
+
+return s-compress_thread_count;
+}
+
int migrate_use_xbzrle(void)
{
MigrationState *s;
@@ -697,4 +795,5 @@ void migrate_fd_connect(MigrationState *s)
On Fr, 2014-11-21 at 09:59 +0800, Fam Zheng wrote:
This fixes a crash by just skipping the vte resize hack if cur is
NULL.
Picked up for 2.2.
thanks,
Gerd
201 - 237 of 237 matches
Mail list logo
