[Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring

2015-02-17 Thread Michael Roth
From: Simon Zolin szo...@parallels.com Moved the code that sets non-blocking flag on fd into a separate function. Signed-off-by: Simon Zolin szo...@parallels.com Reviewed-by: Roman Kagan rka...@parallels.com Signed-off-by: Denis V. Lunev d...@openvz.org CC: Michael Roth mdr...@linux.vnet.ibm.com

[Qemu-devel] [PATCH 07/10] qga: implement qmp_guest_set_memory_blocks() for Linux with sysfs

2015-02-17 Thread Michael Roth
From: zhanghailiang zhang.zhanghaili...@huawei.com We can change guest's online/offline state of memory blocks, by using command 'guest-set-memory-blocks'. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/commands-posix.c

[Qemu-devel] [PULL v2 00/10] Fixes and new commands for QEMU Guest Agent

2015-02-17 Thread Michael Roth
The following changes since commit cd2d5541271f1934345d8ca42f5fafff1744eee7: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20150212' into staging (2015-02-13 11:44:50 +) are available in the git repository at: git://github.com/mdroth/qemu.git tags/qga-pull-2015-02-16-v2-tag

Re: [Qemu-devel] qemu-arm does not boot kernel since 3.19

2015-02-17 Thread Peter Maydell
On 18 February 2015 at 04:33, Waldemar Brodkorb w...@openadk.org wrote: I am regulary using qemu with arm. Since Linux 3.19 my system no longer boots. I am using Qemu 2.2.0 on Linux/amd64. System is started via: qemu-system-arm -nographic -M vexpress-a9 -cpu cortex-a9 -net user -net

[Qemu-devel] [PATCH 01/10] qga: add guest-set-user-password command

2015-02-17 Thread Michael Roth
From: Daniel P. Berrange berra...@redhat.com Add a new 'guest-set-user-password' command for changing the password of guest OS user accounts. This command is needed to enable OpenStack to support its API for changing the admin password of guests running on KVM/QEMU. It is not practical to provide

[Qemu-devel] [PATCH 10/10] qemu-ga-win: Fail loudly on bare 'set-time'

2015-02-17 Thread Michael Roth
From: Michal Privoznik mpriv...@redhat.com The command is not implemented correctly yet. The documentation allows to not pass any value to set, in which case the time is re-read from RTC. However, reading CMOS on Windows is not trivial to implement. So instead of pretending we've set the correct

[Qemu-devel] [PATCH 02/10] utils: drop strtok_r from envlist_parse

2015-02-17 Thread Michael Roth
From: Olga Krishtal okrish...@parallels.com The problem is that mingw 4.9.1 fails to compile the code with the following warning: /mingw/include/string.h:88:9: note: previous declaration of 'strtok_r' was here char *strtok_r(char * __restrict__ _Str, const char *

Re: [Qemu-devel] [PATCH v1 1/2] arm: Add the cortex-a9 CPU to the a9mpcore device

2015-02-17 Thread Alistair Francis
On Tue, Feb 10, 2015 at 4:44 PM, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Wed, Jan 21, 2015 at 5:06 PM, Alistair Francis alistair.fran...@xilinx.com wrote: This patch adds the Cortex-A9 ARM CPU to the A9MPCore. The CPU is only created if the num-cpu property is set. This

Re: [Qemu-devel] [PATCH v1 2/2] zynq: Update Zynq to init the CPU in the a9mpcore device

2015-02-17 Thread Alistair Francis
On Tue, Feb 10, 2015 at 4:45 PM, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Wed, Jan 21, 2015 at 5:06 PM, Alistair Francis alistair.fran...@xilinx.com wrote: This patch removes the initialisation of the ARM Cortex-A9 in Zynq and instead allows the a9mpcore device to init the

[Qemu-devel] [PATCH v2 2/2] zynq: Update Zynq to init the CPU in the a9mpcore device

2015-02-17 Thread Alistair Francis
This patch removes the initialisation of the ARM Cortex-A9 in Zynq and instead allows the a9mpcore device to init the CPU. This also updates components that rely on the CPU and GIC, as they are now initialised in a slightly different way Signed-off-by: Alistair Francis alistair.fran...@xilinx.com

[Qemu-devel] [PATCH v2] sheepdog: fix confused return values

2015-02-17 Thread Liu Yuan
From: Liu Yuan liuy...@cmss.chinamobile.com These functions mix up -1 and -errno in return values and would might cause trouble error handling in the call chain. This patch let them return -errno and add some comments. Cc: qemu-devel@nongnu.org Cc: Markus Armbruster arm...@redhat.com Cc: Kevin

[Qemu-devel] [PATCH 09/10] qga: add memory block command that unsupported

2015-02-17 Thread Michael Roth
From: zhanghailiang zhang.zhanghaili...@huawei.com For memory block command, we only support for linux with sysfs. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com ---

[Qemu-devel] [PATCH 04/10] qga: implement file commands for Windows guest

2015-02-17 Thread Michael Roth
From: Olga Krishtal okrish...@parallels.com The following commands are implemented: - guest_file_open - guest_file_close - guest_file_write - guest_file_read - guest_file_seek - guest_file_flush Motivation is quite simple: Windows guests should be supported with the same set of features as Linux

Re: [Qemu-devel] [PATCH 1/6 v2] target-tilegx: Firstly add to qemu with minimized features

2015-02-17 Thread Chen Gang S
On 2/17/15 23:58, Richard Henderson wrote: On 02/16/2015 06:59 PM, Chen Gang S wrote: I have the related documents, but I can not find pc register, and I originally misunderstood lr can be treated as pc. After I know we can not treat lr as pc, so I want to consult about it for confirmation.

Re: [Qemu-devel] [PATCH v2 3/6] target-tricore: Add instructions of RRR2 opcode format

2015-02-17 Thread Bastian Koppelmann
On 02/17/2015 07:56 PM, Richard Henderson wrote: On 02/11/2015 08:49 AM, Bastian Koppelmann wrote: -OPC2_32_RRR2_MADD_U_32 = 0x68, +OPC2_32_RRR2_MADD_U_64 = 0x68, I guess this is a change to the spec, after the V1.0, 2012-05 edition that I

Re: [Qemu-devel] [PATCH v4 18/18] vfio: Enable in-kernel acceleration via VFIO KVM device

2015-02-17 Thread David Gibson
On Tue, Feb 17, 2015 at 01:36:38PM +1100, Alexey Kardashevskiy wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/05/2015 03:49 PM, David Gibson wrote: On Thu, Jan 29, 2015 at 08:27:30PM +1100, Alexey Kardashevskiy wrote: TCE hypercalls (H_PUT_TCE, H_PUT_TCE_INDIRECT, H_STUFF_TCE)

Re: [Qemu-devel] [PATCH v4 15/18] spapr_pci_vfio: Enable multiple groups per container

2015-02-17 Thread David Gibson
On Tue, Feb 17, 2015 at 11:34:27AM +1100, Alexey Kardashevskiy wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/05/2015 03:19 PM, David Gibson wrote: On Thu, Jan 29, 2015 at 08:27:27PM +1100, Alexey Kardashevskiy wrote: This enables multiple IOMMU groups in one VFIO container

Re: [Qemu-devel] [PATCH v4 08/18] vfio: Add DMA memory registering

2015-02-17 Thread David Gibson
On Tue, Feb 17, 2015 at 01:14:33PM +1100, Alexey Kardashevskiy wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2015 06:04 PM, David Gibson wrote: On Thu, Jan 29, 2015 at 08:27:20PM +1100, Alexey Kardashevskiy wrote: [snip] +vfio_mem_unregister(container, vaddr, end -

Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-17 Thread Liu Yuan
On Mon, Feb 16, 2015 at 12:56:04PM +0100, Kevin Wolf wrote: Am 13.02.2015 um 04:45 hat Liu Yuan geschrieben: From: Liu Yuan liuy...@cmss.chinamobile.com These functions mix up -1 and -errno in return values and would might cause trouble error handling in the call chain. This patch

[Qemu-devel] [PATCH 05/10] qga: introduce three guest memory block commmands with stubs

2015-02-17 Thread Michael Roth
From: zhanghailiang zhang.zhanghaili...@huawei.com Introduce three new guest commands: guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size. With these three commands, we can support online/offline guest's memory block (logical memory hotplug/unplug) as required from

[Qemu-devel] [PATCH 06/10] qga: implement qmp_guest_get_memory_blocks() for Linux with sysfs

2015-02-17 Thread Michael Roth
From: zhanghailiang zhang.zhanghaili...@huawei.com We can get guest's memory block information by using command guest-get-memory-blocks, the returned value contains a list of memory block info, such as phys-index, online state, can-offline info. Signed-off-by: zhanghailiang

[Qemu-devel] [PATCH 08/10] qga: implement qmp_guest_get_memory_block_info() for Linux with sysfs

2015-02-17 Thread Michael Roth
From: zhanghailiang zhang.zhanghaili...@huawei.com This conveys general information about guest memory blocks. Currently, just the memory block size. The size of a memory block is architecture dependent, it represents the logical unit upon which memory online/offline operations are to be

Re: [Qemu-devel] [PATCH] Make platform-bus enabled only on E500 by default

2015-02-17 Thread Paolo Bonzini
On 18/02/2015 06:28, David Gibson wrote: Despite the name, platform-bus is used only by PPC E500 targets. This patch alters the default config to include it in the build only when E500 is enabled. Signed-off-by: David Gibson da...@gibson.dropbear.id.au --- hw/core/Makefile.objs | 2 +-

[Qemu-devel] [PATCH] Make i82801b11 and ioh3420 x86 only by default

2015-02-17 Thread David Gibson
As PCI devices, the i82801b11 and ioh3420 devices could theoretically exist on any platform with a PCI bus. However in practice, they're Intel specific devices, that are very unlikely to appear on anything other than an x86. Therefore this patch gives them their own config options, enabled only

[Qemu-devel] [PATCH] Make sysbus EHCI devices ARM only by default

2015-02-17 Thread David Gibson
A number of ARM embedded boards include EHCI USB host controllers which appear as directly mapped devices, rather than sitting on a PCI bus. At present code to emulate such devices is included whenever EHCI support is included. This patch adjusts teh config options to only include them in builds

Re: [Qemu-devel] [PATCH v2 0/3] -incoming pause

2015-02-17 Thread Amit Shah
On (Tue) 17 Feb 2015 [09:14:27], Eric Blake wrote: On 02/17/2015 07:59 AM, Amit Shah wrote: So the only comment I have is with the 'pause' name. 'pause' to me means there's a time period for which a pause has to be done; or pausing an activity which is already in progress, both of

[Qemu-devel] [PATCH v2 1/2] arm: Add the cortex-a9 CPU to the a9mpcore device

2015-02-17 Thread Alistair Francis
This patch adds the Cortex-A9 ARM CPU to the A9MPCore. The CPU is only created if the num-cpu property is set. This patch allows the midr and reset-cbar properties to be set Signed-off-by: Alistair Francis alistair.fran...@xilinx.com --- V2: - Rename num_cpus function to match QOM style -

Re: [Qemu-devel] [PATCH] block/vdi: Fix locking for parallel requests

2015-02-17 Thread Paolo Bonzini
On 17/02/2015 22:33, Max Reitz wrote: Concurrently modifying the bmap is not a good idea; this patch adds a lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what can go wrong without. Signed-off-by: Max Reitz mre...@redhat.com --- block/vdi.c | 23

Re: [Qemu-devel] [PATCH] Make i82801b11 and ioh3420 x86 only by default

2015-02-17 Thread Paolo Bonzini
On 18/02/2015 05:59, David Gibson wrote: As PCI devices, the i82801b11 and ioh3420 devices could theoretically exist on any platform with a PCI bus. However in practice, they're Intel specific devices, They can be used as a generic PCIe root port and PCIe-to-PCI bridge, they're not

Re: [Qemu-devel] [PATCH v2 0/3] -incoming pause

2015-02-17 Thread Amit Shah
On (Tue) 17 Feb 2015 [20:13:25], Dr. David Alan Gilbert wrote: * Eric Blake (ebl...@redhat.com) wrote: On 02/17/2015 07:59 AM, Amit Shah wrote: So the only comment I have is with the 'pause' name. 'pause' to me means there's a time period for which a pause has to be done; or

Re: [Qemu-devel] [PATCH] Make i82801b11 and ioh3420 x86 only by default

2015-02-17 Thread David Gibson
On Wed, Feb 18, 2015 at 03:59:56PM +1100, David Gibson wrote: As PCI devices, the i82801b11 and ioh3420 devices could theoretically exist on any platform with a PCI bus. However in practice, they're Intel specific devices, that are very unlikely to appear on anything other than an x86.

Re: [Qemu-devel] [PATCH] Make platform-bus enabled only on E500 by default

2015-02-17 Thread Alexander Graf
Am 18.02.2015 um 06:28 schrieb David Gibson da...@gibson.dropbear.id.au: Despite the name, platform-bus is used only by PPC E500 targets. This patch alters the default config to include it in the build only when E500 is enabled. Signed-off-by: David Gibson da...@gibson.dropbear.id.au

[Qemu-devel] [PATCH] Make platform-bus enabled only on E500 by default

2015-02-17 Thread David Gibson
Despite the name, platform-bus is used only by PPC E500 targets. This patch alters the default config to include it in the build only when E500 is enabled. Signed-off-by: David Gibson da...@gibson.dropbear.id.au --- hw/core/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH v2] virtio-blk: Check return value of blk_aio_ioctl

2015-02-17 Thread Kevin Wolf
Am 17.02.2015 um 16:40 hat Stefan Hajnoczi geschrieben: On Tue, Feb 17, 2015 at 05:55:53PM +0800, Fam Zheng wrote: Since commit 1dc936aa84 (virtio-blk: Use blk_aio_ioctl) we silently lose the request if blk_aio_ioctl returns NULL (not implemented). Fix it by directly returning

Re: [Qemu-devel] [PATCH v3 05/52] acpi: add aml_def_block() term

2015-02-17 Thread Michael S. Tsirkin
On Mon, Feb 09, 2015 at 10:53:27AM +, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/acpi/aml-build.c | 38 ++ hw/i386/acpi-build.c| 4 include/hw/acpi/aml-build.h | 10 ++ 3 files changed,

[Qemu-devel] [PATCH v2 0/4] spice: minor improvements

2015-02-17 Thread Radim Krčmář
Series contains two logical parts: [1-2/4] fix a segfault after user misconfiguration (too big vgamem_mb), [3-4/4] improve code that was modified by [2/4]. v2 summary: - added [1/4] to explain the size bump in [2/4] - modified Gerd's proposed solution as [2/4] - added [3/4] to have at least one

[Qemu-devel] [PATCH v2 1/4] qxl: document minimal video memory for new modes

2015-02-17 Thread Radim Krčmář
The alternative to removing existing comments. Signed-off-by: Radim Krčmář rkrc...@redhat.com --- v2: new hw/display/qxl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 61df47726481..6e9079783e27 100644 --- a/hw/display/qxl.c +++

[Qemu-devel] [PATCH 1/3] qapi-schema: Make @password in set_password optional

2015-02-17 Thread Michal Privoznik
So, imagine you've started a guest with ticketing enabled. You've set some password to access your SPICE/VNC session. However, later you want to give the access to somebody else's and therefore disable the ticketing. Come on, be imaginative! Currently, there's no way how to achieve this. And while

[Qemu-devel] [PATCH 3/3] vnc: Implement set_password without password

2015-02-17 Thread Michal Privoznik
Well, this is a bit difficult since VNC has many ways of authentication. So, if no password was provided, the current authentication method is held in a variable (oldauth) and the method is set to VNC_AUTH_NONE to mark it explicitly that no password is required. However, as soon as the password is

[Qemu-devel] [PATCH 0/3] SPICE/VNC: Allow ticketing on the fly

2015-02-17 Thread Michal Privoznik
Currently, if the ticketing (password) is not set at the command line, there's no way how to set it afterwards. Or vice versa - disable previously set password. I think it's worth allowing users to do that. The use case may be a teacher, who wants to share a graphical session with students, but

Re: [Qemu-devel] [PATCH v3 05/52] acpi: add aml_def_block() term

2015-02-17 Thread Igor Mammedov
On Tue, 17 Feb 2015 17:35:55 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Feb 09, 2015 at 10:53:27AM +, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/acpi/aml-build.c | 38 ++ hw/i386/acpi-build.c

Re: [Qemu-devel] [PATCH 2/4] acpi-build: fix ACPI RAM management

2015-02-17 Thread Igor Mammedov
On Tue, 17 Feb 2015 11:05:39 +0100 Michael S. Tsirkin m...@redhat.com wrote: This fixes multiple issues around ACPI RAM management: RSDP and linker RAM aren't currently marked dirty on update, so they won't be migrated correctly. Let's handle all tables in the same way: set correct size

[Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines

2015-02-17 Thread Michael Mueller
This patch implements the functions: - s390_get_proceccor_props() - s390_set_proceccor_props() They can be used to request or retrieve processor related information from an accelerator. That information comprises the cpu identifier, the ICB value and the facility lists. Signed-off-by: Michael

Re: [Qemu-devel] [PATCH v3 06/52] pc: acpi-build: use aml_def_block() for declaring SSDT table

2015-02-17 Thread Michael S. Tsirkin
On Mon, Feb 09, 2015 at 10:53:28AM +, Igor Mammedov wrote: it replaces prebuilt SSDT table header template copying/patching with AML API Signed-off-by: Igor Mammedov imamm...@redhat.com I note that this changed the SSDT signature in random ways, for example, it used to be named BXPCSSDT,

Re: [Qemu-devel] [PATCH 10/13] block: Simplify setting numeric options

2015-02-17 Thread Eric Blake
On 02/16/2015 07:44 AM, Markus Armbruster wrote: Don't convert numbers to strings for use with qemu_opt_set(), simply use qemu_opt_set_number() instead. Signed-off-by: Markus Armbruster arm...@redhat.com --- blockdev.c | 4 +--- vl.c | 13 ++--- 2 files changed, 7

Re: [Qemu-devel] [PATCH 13/13] qtest: Use qemu_opt_set() instead of qemu_opts_parse()

2015-02-17 Thread Eric Blake
On 02/16/2015 07:44 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster arm...@redhat.com --- qtest.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [Qemu-devel] [PATCH 2/2] pseries: Switch VGA endian on H_SET_MODE

2015-02-17 Thread Michael Roth
Quoting David Gibson (2015-02-09 22:36:16) When the guest switches the interrupt endian mode, which essentially means a global machine endian switch, we want to change the VGA framebuffer endian mode as well in order to be backward compatible with existing guests who don't know about the new

Re: [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring

2015-02-17 Thread Denis V. Lunev
On 17/02/15 18:27, Eric Blake wrote: On 02/16/2015 08:14 PM, Michael Roth wrote: From: Simon Zolin szo...@parallels.com Moved the code that sets non-blocking flag on fd into a separate function. Signed-off-by: Simon Zolin szo...@parallels.com Reviewed-by: Roman Kagan rka...@parallels.com

Re: [Qemu-devel] [PATCH v3 01/52] acpi: introduce AML composer aml_append()

2015-02-17 Thread Michael S. Tsirkin
On Mon, Feb 09, 2015 at 10:53:23AM +, Igor Mammedov wrote: Adds for dynamic AML creation, which will be used for piecing ASL/AML primitives together and hiding from user/caller details about how nested context should be closed/packed leaving less space for mistakes and necessity to know

[Qemu-devel] [PATCH v2 3/4] qxl: refactor rounding up to a nearest power of 2

2015-02-17 Thread Radim Krčmář
We already have pow2floor, mirror it and use instead of a function with similar results (same in used domain), to clarify our intent. Signed-off-by: Radim Krčmář rkrc...@redhat.com --- v2: new hw/display/qxl.c | 23 +-- include/qemu-common.h | 3 +++ util/cutils.c

Re: [Qemu-devel] [PATCH] console/gtk: add qemu_console_get_label

2015-02-17 Thread Programmingkid
On Feb 17, 2015, at 4:44 AM, Gerd Hoffmann wrote: Add a new function to get a nice label for a given QemuConsole. Drop the labeling code in gtk.c and use the new function instead. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 1 + ui/console.c | 15

Re: [Qemu-devel] [PATCH 12/13] pc: Use qemu_opt_set() instead of qemu_opts_parse()

2015-02-17 Thread Eric Blake
On 02/16/2015 07:44 AM, Markus Armbruster wrote: Less code, same result. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/i386/pc.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com

Re: [Qemu-devel] [PATCH 11/13] qemu-sockets: Simplify setting numeric and boolean options

2015-02-17 Thread Eric Blake
On 02/16/2015 07:44 AM, Markus Armbruster wrote: Don't convert numbers or bools to strings for use with qemu_opt_set(), simply use qemu_opt_set_number() or qemu_opt_set_bool() instead. Signed-off-by: Markus Armbruster arm...@redhat.com --- util/qemu-sockets.c | 16 +++- 1 file

Re: [Qemu-devel] [PATCH v3 00/52] ACPI refactoring: replace template patching with C AML API

2015-02-17 Thread Michael S. Tsirkin
This seems to change the contents of the tables in too many ways. So of it needs changing since PCI are somewhat broken by your recent patch. So let's do this: please prepare a minimal patchset that just generates PCI description dynamically. Drop everything that's not necessary, and verify

Re: [Qemu-devel] [PATCH v6 04/24] qcow2: Only return status from qcow2_get_refcount

2015-02-17 Thread Eric Blake
On 02/17/2015 03:19 AM, Kevin Wolf wrote: if (num_fixed) { ret = update_refcount(bs, i s-cluster_bits, 1, - refcount2 - refcount1, + (int)refcount2 - (int)refcount1,

Re: [Qemu-devel] [PATCH v3 23/52] pc: acpi-build: drop unsupported PM1b_CNT.SLP_TYP

2015-02-17 Thread Michael S. Tsirkin
On Mon, Feb 09, 2015 at 10:53:45AM +, Igor Mammedov wrote: QEMU doesn't implement/advertize PM1b_CNT_BLK register block so do not set/patch its \_Sx values to avoid confusion. Signed-off-by: Igor Mammedov imamm...@redhat.com I doubt guests are confused. I think you mean this confuses

[Qemu-devel] [PATCH 2/3] spice: Implement set_password without password

2015-02-17 Thread Michal Privoznik
This is quite easy. SPICE has a function to disable ticketing. So, if no password was provided, call the function, and if a password was provided, call another function to actually set it. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- ui/spice-core.c | 15 +-- 1 file

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-02-17 Thread Max Reitz
For whatever reason, using an empty image now works for me, too: $ ./qemu-img create -f vdi test.vdi 64M; ./qemu-nbd -c /dev/nbd0 test.vdi; dd if=/dev/urandom of=/dev/nbd0 bs=1K count=16384; md5sum /dev/nbd0; sync; echo 1 /proc/sys/vm/drop_caches; md5sum /dev/nbd0; ./qemu-nbd -d /dev/nbd0

Re: [Qemu-devel] [PATCH] qcow2: Remove unused struct QCowCreateState

2015-02-17 Thread Stefan Hajnoczi
On Tue, Feb 17, 2015 at 02:49:25PM +0100, Kevin Wolf wrote: The only user went away five years ago with commit a9420734 ('qcow2: Simplify image creation'). It's about time to remove it. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.h | 11 --- 1 file changed, 11

Re: [Qemu-devel] [PATCH v2] block: move I/O request processing to block/io.c

2015-02-17 Thread Eric Blake
On 02/17/2015 07:39 AM, Stefan Hajnoczi wrote: The block.c file has grown to over 6000 lines. It is time to split this file so there are fewer conflicts and the code is easier to maintain. Extract I/O request processing code: * Read * Write * Zero writes and making the image empty *

Re: [Qemu-devel] [PATCH 1/6 v2] target-tilegx: Firstly add to qemu with minimized features

2015-02-17 Thread Richard Henderson
On 02/16/2015 06:59 PM, Chen Gang S wrote: I have the related documents, but I can not find pc register, and I originally misunderstood lr can be treated as pc. After I know we can not treat lr as pc, so I want to consult about it for confirmation. Section 3.4 Program Counter, concisely

Re: [Qemu-devel] [PULL v2 00/14] target-mips queue

2015-02-17 Thread Stefan Hajnoczi
On Tue, Feb 17, 2015 at 05:02:12PM +0900, Peter Maydell wrote: On 15 February 2015 at 02:44, Leon Alrae leon.al...@imgtec.com wrote: Hi, Here is version 2 of target-mips pullreq - rebased and with signed tag. Just fyi, this hotel's wifi and my work VPN seem to disagree with each other,

Re: [Qemu-devel] [PATCH v3 47/52] pc: acpi-build: drop remaining ssdt_misc template and use acpi_def_block()

2015-02-17 Thread Michael S. Tsirkin
On Mon, Feb 09, 2015 at 10:54:09AM +, Igor Mammedov wrote: It completes dynamic SSDT generation and makes it independed of IASL binary blobs. It also hides from user all pointer arithmetic when building SSDT which makes resulting code a bit cleaner and concentrating only on composing ASL

Re: [Qemu-devel] [PATCH v2] virtio-blk: Check return value of blk_aio_ioctl

2015-02-17 Thread Stefan Hajnoczi
On Tue, Feb 17, 2015 at 05:55:53PM +0800, Fam Zheng wrote: Since commit 1dc936aa84 (virtio-blk: Use blk_aio_ioctl) we silently lose the request if blk_aio_ioctl returns NULL (not implemented). Fix it by directly returning VIRTIO_BLK_S_UNSUPP as we used to do. Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: Machine menu patch for Mac OS X

2015-02-17 Thread Programmingkid
On Feb 17, 2015, at 4:57 AM, Kevin Wolf wrote: Am 17.02.2015 um 10:41 hat Peter Maydell geschrieben: On 17 February 2015 at 18:07, Kevin Wolf kw...@redhat.com wrote: The ID is user-defined, so no, no assumption about it is safe. If you like, you can name your floppy drive 'ide0-cd1', your

Re: [Qemu-devel] [PATCH v2 0/3] -incoming pause

2015-02-17 Thread Eric Blake
On 02/17/2015 07:59 AM, Amit Shah wrote: So the only comment I have is with the 'pause' name. 'pause' to me means there's a time period for which a pause has to be done; or pausing an activity which is already in progress, both of which are not true for this case. I think that pause and

[Qemu-devel] [PATCH v2 4/4] vga: refactor vram_size clamping and rounding

2015-02-17 Thread Radim Krčmář
Make the code a bit more obvious. We don't have min/max, so a general helper for clamp probably isn't acceptable either. Signed-off-by: Radim Krčmář rkrc...@redhat.com --- v2: kept rounding and clamping (was [v1 1/2]) hw/display/vga.c | 22 +++--- 1 file changed, 15

[Qemu-devel] [PATCH v2 2/4] spice: fix invalid memory access to vga.vram

2015-02-17 Thread Radim Krčmář
vga_common_init() doesn't allow more than 256 MiB vram size and silently shrinks any larger value. qxl_dirty_surfaces() used the unshrinked size via qxl-shadow_rom.surface0_area_size when accessing the memory, which resulted in segfault. Add a workaround for this case and an assert if it happens

Re: [Qemu-devel] [PATCH 1/3] qapi-schema: Make @password in set_password optional

2015-02-17 Thread Daniel P. Berrange
On Tue, Feb 17, 2015 at 05:40:45PM +0100, Michal Privoznik wrote: So, imagine you've started a guest with ticketing enabled. You've set some password to access your SPICE/VNC session. However, later you want to give the access to somebody else's and therefore disable the ticketing. Come on, be

Re: [Qemu-devel] [PATCH 1/3] qapi-schema: Make @password in set_password optional

2015-02-17 Thread Eric Blake
On 02/17/2015 09:53 AM, Daniel P. Berrange wrote: On Tue, Feb 17, 2015 at 05:40:45PM +0100, Michal Privoznik wrote: So, imagine you've started a guest with ticketing enabled. You've set some password to access your SPICE/VNC session. However, later you want to give the access to somebody

[Qemu-devel] [PATCH 0/4] ucb: Convert remaining PCI HCDs to realize

2015-02-17 Thread Markus Armbruster
This series requires my [PATCH 00/10] pci: Partial conversion to realize and my [PATCH 0/9] Clean up around error_get_pretty(), qerror_report_err(). Markus Armbruster (4): usb: Propagate errors through usb_register_companion() usb: Improve companion configuration error messages ohci:

Re: [Qemu-devel] [PATCH 1/4] exec: round up size on MR resize

2015-02-17 Thread Igor Mammedov
On Tue, 17 Feb 2015 11:05:36 +0100 Michael S. Tsirkin m...@redhat.com wrote: Block size must fundamentally be a multiple of target page size. Aligning automatically removes need to worry about the alignment from callers. Note: the only caller of qemu_ram_resize (acpi) already happens to

Re: [Qemu-devel] [PATCH v3 10/17] virtio-scsi: use standard-headers

2015-02-17 Thread Paolo Bonzini
On 16/02/2015 22:36, Michael S. Tsirkin wrote: Drop duplicated code. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/virtio/virtio-scsi.h | 120 +++- hw/scsi/virtio-scsi.c | 1 + 2 files changed, 10 insertions(+), 111

Re: [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes

2015-02-17 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: Hi (Li special edition) Current migration code returns number of bytes transferred and from there we decide if we.have sent something or not. Problem, we need two results: number of pages written, and number of bytes written (depending on

[Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines

2015-02-17 Thread Michael Mueller
This patch provides routines to dynamically update the previously defined S390 cpu classes in the current host context. The main function performing this process is s390_setup_cpu_classes(). It takes the current host context as parameter to setup the classes accordingly. It basically performs the

[Qemu-devel] [RFC PATCH v2 09/15] cpu-model/s390: Add KVM VM attribute interface routines

2015-02-17 Thread Michael Mueller
The patch implements routines to set and retrieve processor configuration data and to retrieve machine configuration data. The machine related data is used together with the cpu model facility lists to determine the list of supported cpu models of this host. The above mentioned routines have QEMU

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-02-17 Thread Max Reitz
Hi Pierre, I can reproduce the bug with a 2 GB VDI image with a single FAT32-formatted partition (on git master): # cp src.vdi test.vdi # ./qemu-nbd -c /dev/nbd0 test.vdi # dd if=/dev/urandom of=/dev/nbd0 bs=1M count=64 64+0 records in 64+0 records out 67108864 bytes (67 MB) copied, 3.34091 s,

[Qemu-devel] [PATCH 1/4] usb: Propagate errors through usb_register_companion()

2015-02-17 Thread Markus Armbruster
This loses the messages explaining the error printed with error_printf_unless_qmp(). The next commit will make up for the loss. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/usb/bus.c | 17 ++--- hw/usb/hcd-ehci.c | 23 +-- hw/usb/hcd-ohci.c | 10

[Qemu-devel] [PATCH 3/4] ohci: Complete conversion to realize

2015-02-17 Thread Markus Armbruster
Commit 457215ec ohci: Use QOM realize for OHCI converted only sysbus-ohci. Finish the job: convert pci-ohci. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/usb/hcd-ohci.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git

[Qemu-devel] [PATCH 4/4] uhci: Convert to realize

2015-02-17 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/usb/hcd-uhci.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index 2ca8de3..e791377 100644 --- a/hw/usb/hcd-uhci.c +++ b/hw/usb/hcd-uhci.c @@ -66,7 +66,7 @@

[Qemu-devel] [RFC PATCH v2 12/15] cpu-model/s390: Extend QMP command query-cpu-definitions

2015-02-17 Thread Michael Mueller
This patch implements the QMP command 'query-cpu-definitions' in the S390 context. The command returns a in terms of machine release date descending sorted list of cpu model names in the current host context. A consumer may successfully request each listed cpu model as long for a given accelerator

[Qemu-devel] [RFC PATCH v2 08/15] cpu-model/s390: Update linux-headers/asm-s390/kvm.h

2015-02-17 Thread Michael Mueller
Signed-off-by: Michael Mueller m...@linux.vnet.ibm.com --- linux-headers/asm-s390/kvm.h | 20 1 file changed, 20 insertions(+) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index d36b2fa..e38c942 100644 --- a/linux-headers/asm-s390/kvm.h +++

Re: [Qemu-devel] [PATCH v6 09/24] qcow2: More helpers for refcount modification

2015-02-17 Thread Kevin Wolf
Am 10.02.2015 um 21:28 hat Max Reitz geschrieben: Add helper functions for getting and setting refcounts in a refcount array for any possible refcount order, and choose the correct one during refcount initialization. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v3 31/52] acpi: add aml_local() term

2015-02-17 Thread Igor Mammedov
On Tue, 17 Feb 2015 13:18:19 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Feb 09, 2015 at 10:53:53AM +, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com --- This causes asserts. hw/acpi/aml-build.c | 11 +++

Re: [Qemu-devel] [PATCH 4/4] acpi-build: simplify rsdp management for legacy

2015-02-17 Thread Igor Mammedov
On Tue, 17 Feb 2015 11:05:45 +0100 Michael S. Tsirkin m...@redhat.com wrote: For legacy machine types, rsdp is not in RAM, so we need a copy of rsdp for fw cfg. We previously used g_array_free with false parameter, but this seems to confuse people. This also wastes a bit of memory as the

[Qemu-devel] [PATCH v3 31/52] fixup! acpi: add aml_local() term

2015-02-17 Thread Igor Mammedov
fixes: qemu-system-i386: hw/acpi/aml-build.c:723: aml_local: Assertion `op = 7' failed. when pvpanic device is present Signed-off-by: Igor Mammedov imamm...@redhat.com --- this time make check on my host for all targets passes, /me sorry for mess again --- hw/acpi/aml-build.c | 2 +- 1 file

[Qemu-devel] [RFC PATCH v2 07/15] cpu-model/s390: Add cpu model alias definition routines

2015-02-17 Thread Michael Mueller
This patch implements the infrastructure to dynamically add cpu model aliases. Signed-off-by: Michael Mueller m...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com --- target-s390x/cpu-models.c | 77 +++ target-s390x/cpu-models.h

Re: [Qemu-devel] [PATCH 04/13] qemu-img: Suppress unhelpful extra errors in convert, resize

2015-02-17 Thread Eric Blake
On 02/16/2015 07:44 AM, Markus Armbruster wrote: add_old_style_options() for img_convert() and img_resize() use qemu_opt_set(), which reports errors with qerror_report_err(). Its error messages aren't helpful here, the caller reports one that actually makes sense. Reproducer: $

Re: [Qemu-devel] [PATCH v2 0/3] -incoming pause

2015-02-17 Thread Amit Shah
On (Tue) 17 Feb 2015 [13:27:03], Dr. David Alan Gilbert wrote: * Amit Shah (amit.s...@redhat.com) wrote: On (Wed) 11 Feb 2015 [16:46:21], Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com This patchset provides a way of setting options on an incoming

Re: [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring

2015-02-17 Thread Eric Blake
On 02/16/2015 08:14 PM, Michael Roth wrote: From: Simon Zolin szo...@parallels.com Moved the code that sets non-blocking flag on fd into a separate function. Signed-off-by: Simon Zolin szo...@parallels.com Reviewed-by: Roman Kagan rka...@parallels.com Signed-off-by: Denis V. Lunev

[Qemu-devel] [PATCH 2/4] usb: Improve companion configuration error messages

2015-02-17 Thread Markus Armbruster
The previous commit broke the additional messages explaining the error messages. Improve the error messages, so they don't need explaining so much. Helps QMP users as well, unlike additional explanations. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/usb/bus.c | 18

[Qemu-devel] [PATCH] qcow2: Remove unused struct QCowCreateState

2015-02-17 Thread Kevin Wolf
The only user went away five years ago with commit a9420734 ('qcow2: Simplify image creation'). It's about time to remove it. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/block/qcow2.h b/block/qcow2.h index

Re: [Qemu-devel] [PATCH v6 09/24] qcow2: More helpers for refcount modification

2015-02-17 Thread Max Reitz
On 2015-02-17 at 08:38, Kevin Wolf wrote: Am 10.02.2015 um 21:28 hat Max Reitz geschrieben: Add helper functions for getting and setting refcounts in a refcount array for any possible refcount order, and choose the correct one during refcount initialization. Signed-off-by: Max Reitz

[Qemu-devel] [RFC PATCH v2 00/15] QEMU: s390: cpu model implementation

2015-02-17 Thread Michael Mueller
This patch set in combination with its kernel kvm patch set proposes an implementation of S390 cpu models. The origin of this item is to provide a means for management interfaces like libvirt to draw decisions if life guest migration to a target hypervisor is reasonable. A migration constraint is

[Qemu-devel] [RFC PATCH v2 14/15] cpu-model/s390: Add cpu model selection routine

2015-02-17 Thread Michael Mueller
This patch basically implements the routine: - s390_select_cpu_model() It tests if the the cpu classes have been initialized and the requested cpu model is either a valid model or a valid alias. If these conditions are met, the associated cpu model properties (cpu identifier, ibc value, cpu

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-02-17 Thread Max Reitz
** Attachment added: src.qcow2 https://bugs.launchpad.net/qemu/+bug/1422307/+attachment/4321013/+files/src.qcow2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1422307 Title: qemu-nbd corrupts

Re: [Qemu-devel] [PATCH v2 1/5] qga: introduce three guest memory block commmands with stubs

2015-02-17 Thread Eric Blake
On 01/21/2015 07:40 PM, zhanghailiang wrote: Introduce three new guest commands: guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size. With these three commands, we can support online/offline guest's memory block (logical memory hotplug/unplug) as required from host.

Re: [Qemu-devel] [PATCH 05/10] qga: introduce three guest memory block commmands with stubs

2015-02-17 Thread Eric Blake
On 02/16/2015 08:14 PM, Michael Roth wrote: From: zhanghailiang zhang.zhanghaili...@huawei.com Introduce three new guest commands: guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size. Sorry for the late review, but I think guest-get-memory-block-size is the wrong

Re: [Qemu-devel] [PATCH v3 05/17] virtio-balloon: use standard headers

2015-02-17 Thread Thomas Huth
On Mon, 16 Feb 2015 22:35:52 +0100 Michael S. Tsirkin m...@redhat.com wrote: Drop code duplicated from standard headers. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/virtio/virtio-balloon.h | 35 ++- 1 file changed, 2 insertions(+), 33

Re: [Qemu-devel] [PATCH v2 0/3] -incoming pause

2015-02-17 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: On (Wed) 11 Feb 2015 [16:46:21], Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com This patchset provides a way of setting options on an incoming migration before the fd/process/socket has been created.

  1   2   3   >