On 17/02/15 18:27, Eric Blake wrote:
On 02/16/2015 08:14 PM, Michael Roth wrote:
From: Simon Zolin <[email protected]>
Moved the code that sets non-blocking flag on fd into a separate function.
Signed-off-by: Simon Zolin <[email protected]>
Reviewed-by: Roman Kagan <[email protected]>
Signed-off-by: Denis V. Lunev <[email protected]>
CC: Michael Roth <[email protected]>
CC: Eric Blake <[email protected]>
Signed-off-by: Michael Roth <[email protected]>
---
qga/commands-posix.c | 31 +++++++++++++++++++++++--------
1 file changed, 23 insertions(+), 8 deletions(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 57409d0..ed527a3 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -376,13 +376,33 @@ safe_open_or_create(const char *path, const char *mode,
Error **errp)
return NULL;
}
+static int guest_file_toggle_flags(int fd, int flags, bool set, Error **err)
+{
Why are you reinventing qemu_set_nonblock()?
because we are uneducated :)
Anyway, qemu_set_nonblock() does not handle error
and resides in a strange header aka "include/qemu/sockets.h"
Technically I can switch to it immediately. Though error
check condition will be lost.
What is better at your opinion?
a) return error from qemu_set_nonblock()/qemu_set_block()
b) drop error check here. The descriptor is just opened
and we know that it is valid. I could not imagine real
error other than broken descriptor for this exact fcntl.
Regards,
Den
