[Qemu-devel] [PATCH] vfio: allow to disable MMAP per device with -x-mmap=off option

2015-02-24 Thread Samuel Pitoiset
Disabling MMAP support uses the slower read/write accesses but allows to trace all MMIO accesses, which is not good for performance, but very useful for reverse engineering PCI drivers. This option allows to disable MMAP per device without a compile-time change. Signed-off-by: Samuel Pitoiset

[Qemu-devel] [PATCH 09/43] iotests: Add test for unsupported image creation

2015-02-24 Thread Michael Roth
From: Max Reitz mre...@redhat.com Add a test for creating and amending images (amendment uses the creation options) with formats not supporting creation over protocols not supporting creation. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v5 08/16] spapr_events: re-use EPOW event infrastructure for hotplug events

2015-02-24 Thread Michael Roth
Quoting David Gibson (2015-02-24 00:49:42) On Mon, Feb 16, 2015 at 08:27:44AM -0600, Michael Roth wrote: From: Nathan Fontenot nf...@linux.vnet.ibm.com This extends the data structures currently used to report EPOW events to guests via the check-exception RTAS interfaces to also include

Re: [Qemu-devel] [PATCH RFC v3 00/27] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2015-02-24 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: This is the 3th version of COLO, it is only COLO frame part, include: VM checkpoint, failover, proxy API, block replication API, not include block replication. The block part has been sent by wencongyang: '[RFC PATCH 00/14] Block

Re: [Qemu-devel] [PATCH 8/9] throttle: Update throttle infrastructure copyright

2015-02-24 Thread Benoît Canet
On Tue, Feb 24, 2015 at 09:49:26AM -0700, Eric Blake wrote: On 02/13/2015 09:06 AM, Alberto Garcia wrote: From: Benoît Canet benoit.ca...@nodalink.com Signed-off-by: Benoit Canet benoit.ca...@nodalink.com Signed-off-by: Alberto Garcia be...@igalia.com --- include/qemu/throttle.h | 4

[Qemu-devel] [PATCH v5 3/5] libqos: Remove PCI assumptions in constants of virtio driver

2015-02-24 Thread Marc Marí
Convert PCI-specific constants names of libqos virtio driver. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 30 +++--- tests/libqos/virtio-pci.h | 24 tests/virtio-blk-test.c | 11 ++- 3 files

[Qemu-devel] [PATCH v5 0/5] libqos: Virtio MMIO driver

2015-02-24 Thread Marc Marí
Add virtio-mmio support to libqos and test case for virtio-blk. Changes for version 3: - Fix leaks and minor bugs - Extract basic test case to a function Changes for version 4: - Add format=raw to images, to avoid warnings - Solve bug with timeout in interrupt checking in virtio MMIO due to

[Qemu-devel] [PATCH v5 4/5] libqos: Add malloc generic

2015-02-24 Thread Marc Marí
This malloc is a basic interface implementation that works for any platform. It should be replaced in the future for a real malloc implementation for each of the platforms. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/malloc-generic.c | 39

[Qemu-devel] Patch Round-up for stable 2.2.1, freeze on 2015-03-05

2015-02-24 Thread Michael Roth
Hi everyone, The following new patches are queued for QEMU stable v2.2.1: https://github.com/mdroth/qemu/commits/stable-2.2-staging The release is planned for 2015-03-10: http://wiki.qemu.org/Planning/2.2 Please respond here or CC qemu-sta...@nongnu.org on any patches you think should be

[Qemu-devel] [PATCH 18/43] linuxboot: fix loading old kernels

2015-02-24 Thread Michael Roth
From: Paolo Bonzini pbonz...@redhat.com Old kernels that used high memory only allowed the initrd to be in the first 896MB of memory. If you load the initrd above, they complain that initrd extends beyond end of memory. In order to fix this, while not breaking machines with small amounts of

[Qemu-devel] [PATCH 14/43] block migration: fix return value

2015-02-24 Thread Michael Roth
From: Gary R Hook gary.h...@nimboxx.com Modify block_save_iterate() to return positive/zero/negative (success/not done/failure) return status. The computation of the blocks transferred (an int64_t) exceeds the size of an int return value. Signed-off-by: Gary R Hook gary.h...@nimboxx.com

Re: [Qemu-devel] [PATCH] vfio: allow to disable MMAP per device with -x-mmap=off option

2015-02-24 Thread Eric Blake
On 02/24/2015 01:38 PM, Samuel Pitoiset wrote: Disabling MMAP support uses the slower read/write accesses but allows to trace all MMIO accesses, which is not good for performance, but very useful for reverse engineering PCI drivers. This option allows to disable MMAP per device without a

[Qemu-devel] [PATCH 11/43] qcow2: Flushing the caches in qcow2_close may fail

2015-02-24 Thread Michael Roth
From: Max Reitz mre...@redhat.com qcow2_cache_flush() may fail; if one of the caches failed to be flushed successfully to disk in qcow2_close() the image should not be marked clean, and we should emit a warning. This breaks the (qcow2-specific) iotests 026, 071 and 089; change their output

[Qemu-devel] [PATCH 21/43] target-xtensa: test cross-page opcode

2015-02-24 Thread Michael Roth
From: Max Filippov jcmvb...@gmail.com Alter cross-page TB test to also test cross-page opcode. Signed-off-by: Max Filippov jcmvb...@gmail.com (cherry picked from commit 85d36377e4ff8b98119420099d445369bfd6b7bb) Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com ---

[Qemu-devel] [RFC PATCH 2/2] qga: add --getenv option to get env. vars from fw_cfg

2015-02-24 Thread Gabriel L. Somlo
The new -g (or --getenv) command line option causes qemu-ga to extract and parse the etc/guestenv blob from fw_cfg, and return the value of the requested key (if available) on stdout. Warnings and error messages are printed to stderr, and only the actual value portion of a key=value string

[Qemu-devel] [RFC PATCH 0/2] host-guest environment variables via fw_cfg

2015-02-24 Thread Gabriel L. Somlo
Following up on a conversation I started a few weeks ago, regarding the ability to pass environment variables into a guest from the host, via the qemu command line, and without further requirements for guest- or host-initiated synchronization at a later time, after the act of firing up the guest.

Re: [Qemu-devel] [PATCH v5 07/16] spapr_rtas: add ibm, configure-connector RTAS interface

2015-02-24 Thread Michael Roth
Quoting David Gibson (2015-02-24 00:40:32) On Mon, Feb 16, 2015 at 08:27:43AM -0600, Michael Roth wrote: This interface is used to fetch an OF device-tree nodes that describes a newly-attached device to guest. It is called multiple times to walk the device-tree node and fetch individual

[Qemu-devel] [PATCH v5 1/5] libqos: Change use of pointers to uint64_t in virtio

2015-02-24 Thread Marc Marí
Convert use of pointers in functions of virtio to uint64_t in order to make it platform-independent. Add casting from pointers (in PCI functions) to uint64_t and vice versa through uintptr_t. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 20

[Qemu-devel] [RFC PATCH 1/2] fw_cfg: Add -guestenv qemu command line option

2015-02-24 Thread Gabriel L. Somlo
Introduce -guestenv command line option, which allows passing of environment variables to the guest in a fire-and-forget, asynchronous way. The guest may retrieve this data at its convenience, by accessing the provided fw_cfg device from the inside. The new etc/guestenv blob will be a set of

Re: [Qemu-devel] [PATCH v4 0/5] libqos: Virtio MMIO driver

2015-02-24 Thread Marc Marí
El Thu, 19 Feb 2015 18:46:44 +0100 Kevin Wolf kw...@redhat.com escribió: Am 18.02.2015 um 18:07 hat Stefan Hajnoczi geschrieben: On Fri, Jan 23, 2015 at 05:38:48PM +0100, Marc Marí wrote: Add virtio-mmio support to libqos and test case for virtio-blk. Changes for version 3: - Fix

[Qemu-devel] [PATCH v5 5/5] libqos: Add virtio MMIO support

2015-02-24 Thread Marc Marí
Add virtio MMIO support. Add virtio-blk-test MMIO test case. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/Makefile |4 +- tests/libqos/virtio-mmio.c | 198 tests/libqos/virtio-mmio.h | 46 ++

[Qemu-devel] [PATCH v5 2/5] tests: Prepare virtio-blk-test for multi-arch implementation

2015-02-24 Thread Marc Marí
Modularize functions in virtio-blk-test and add PCI suffix for PCI specific components. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/virtio-blk-test.c | 154 +++ 1 file changed, 89 insertions(+), 65 deletions(-) diff --git

Re: [Qemu-devel] [RFC PATCH v1 13/13] spapr: Memory hotplug support

2015-02-24 Thread Bharata B Rao
On Tue, Feb 24, 2015 at 05:26:12PM +1100, David Gibson wrote: On Thu, Jan 08, 2015 at 11:40:20AM +0530, Bharata B Rao wrote: Make use of pc-dimm infrastructure to support memory hotplug for PowerPC. Modelled on i386 memory hotplug. Signed-off-by: Bharata B Rao

Re: [Qemu-devel] [PATCH v5 08/16] spapr_events: re-use EPOW event infrastructure for hotplug events

2015-02-24 Thread David Gibson
On Mon, Feb 16, 2015 at 08:27:44AM -0600, Michael Roth wrote: From: Nathan Fontenot nf...@linux.vnet.ibm.com This extends the data structures currently used to report EPOW events to guests via the check-exception RTAS interfaces to also include event types for hotplug/unplug events. This

Re: [Qemu-devel] [PATCH v5 03/16] spapr_rtas: add get/set-power-level RTAS interfaces

2015-02-24 Thread David Gibson
On Mon, Feb 16, 2015 at 08:27:39AM -0600, Michael Roth wrote: From: Nathan Fontenot nf...@linux.vnet.ibm.com These interfaces manage the power domains that guest devices are assigned to and are used to power on/off devices. Currently we only utilize 1 power domain, the 'live-insertion'

Re: [Qemu-devel] [PATCH v5 14/16] pci: make pci_bar useable outside pci.c

2015-02-24 Thread David Gibson
On Mon, Feb 16, 2015 at 08:27:50AM -0600, Michael Roth wrote: We need to work with PCI BARs to generate OF properties during PCI hotplug for sPAPR guests. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com Added Michael Tsirkin to the Cc list, since he usually handles the PCI subsystem.

Re: [Qemu-devel] [PATCH v2] utils: Add pow2ceil()

2015-02-24 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 02/23/2015 10:40 AM, Markus Armbruster wrote: int64_t pow2floor(int64_t value) { assert(value 0); return 0x8000u clz64(value); } Needs to be 0x8000ull for 32-bit machines to compile correctly. Why? Because

Re: [Qemu-devel] [PATCH RFC v3 17/27] COLO: Add new command parameter 'colo_nicname' 'colo_script' for net

2015-02-24 Thread Wen Congyang
On 02/17/2015 07:50 AM, Eric Blake wrote: On 02/11/2015 08:17 PM, zhanghailiang wrote: The 'colo_nicname' should be assigned with network name, for exmple, 'eth2'. It will be parameter of 'colo_script', s/exmple/example/ 'colo_script' should be assigned with an scirpt path. s/an

Re: [Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU

2015-02-24 Thread Igor Mammedov
On Thu, 12 Feb 2015 15:50:35 -0200 Eduardo Habkost ehabk...@redhat.com wrote: Instead of silently assigning CPU to node 0 when it is omitted from the command-line, check if all CPUs up to max_cpus are present in the NUMA configuration. That would also trigger warning for possible (i.e. to be

Re: [Qemu-devel] [PATCH v5 05/16] spapr_rtas: add get-sensor-state RTAS interface

2015-02-24 Thread David Gibson
On Mon, Feb 16, 2015 at 08:27:41AM -0600, Michael Roth wrote: From: Mike Day ncm...@ncultra.org This interface allows a guest to read various platform/device sensors. initially, we only implement support necessary to support hotplug: reading of the dr-entity-sense sensor, which communicates

Re: [Qemu-devel] [PATCH v5 07/16] spapr_rtas: add ibm, configure-connector RTAS interface

2015-02-24 Thread David Gibson
On Mon, Feb 16, 2015 at 08:27:43AM -0600, Michael Roth wrote: This interface is used to fetch an OF device-tree nodes that describes a newly-attached device to guest. It is called multiple times to walk the device-tree node and fetch individual properties into a 'workarea'/buffer provided by

Re: [Qemu-devel] [PATCH v5 04/16] spapr_rtas: add set-indicator RTAS interface

2015-02-24 Thread David Gibson
On Mon, Feb 16, 2015 at 08:27:40AM -0600, Michael Roth wrote: From: Mike Day ncm...@ncultra.org This interface allows a guest to control various platform/device sensors. Initially, we only implement support necessary to control sensors that are required for hotplug: DR connector

Re: [Qemu-devel] [PATCH 2/3] Create specific config option for platform-bus

2015-02-24 Thread David Gibson
On Mon, Feb 23, 2015 at 10:27:20PM -0800, Peter Crosthwaite wrote: On Mon, Feb 23, 2015 at 3:05 PM, David Gibson da...@gibson.dropbear.id.au wrote: Currently the platform-bus device is included for all softmmu builds. This bridge is intended for use on any platforms that require dynamic

Re: [Qemu-devel] [PATCH 1/5] migration: Remove unused functions

2015-02-24 Thread Amit Shah
On (Thu) 19 Feb 2015 [18:12:19], Thomas Huth wrote: dup_mig_bytes_transferred(), skipped_mig_bytes_transferred(), migrate_rdma_pin_all(), qsb_clone() and qsb_set_length() are completely unused and thus can be deleted. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Cc: Juan Quintela

Re: [Qemu-devel] [PATCH 1/6] ram: make all save_page functions take a uint64_t parameter

2015-02-24 Thread Amit Shah
On (Thu) 12 Feb 2015 [23:03:06], Juan Quintela wrote: It used to be an int, but then we can't pass directly the bytes_transferred parameter, that would happen later in the series. Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 11 ---

Re: [Qemu-devel] [PATCH 1/3] Add specific config options for PCI-E bridges

2015-02-24 Thread David Gibson
On Mon, Feb 23, 2015 at 10:17:58PM -0800, Peter Crosthwaite wrote: On Mon, Feb 23, 2015 at 3:05 PM, David Gibson da...@gibson.dropbear.id.au wrote: The i82801b11, ioh3420 and xio3130 PCI Express devices are currently included in the build unconditionally. While they could theoretically

Re: [Qemu-devel] [PATCH 3/3] Give ivshmem its own config option

2015-02-24 Thread David Gibson
On Mon, Feb 23, 2015 at 10:38:06PM -0800, Peter Crosthwaite wrote: On Mon, Feb 23, 2015 at 3:05 PM, David Gibson da...@gibson.dropbear.id.au wrote: Currently the ivshmem device is built whenever both PCI and KVM support are included. This patch gives it its own config option to allow easier

Re: [Qemu-devel] [PATCH v5 09/16] spapr_events: event-scan RTAS interface

2015-02-24 Thread David Gibson
On Mon, Feb 16, 2015 at 08:27:45AM -0600, Michael Roth wrote: From: Tyrel Datwyler tyr...@linux.vnet.ibm.com We don't actually rely on this interface to surface hotplug events, and instead rely on the similar-but-interrupt-driven check-exception RTAS interface used for EPOW events. However,

Re: [Qemu-devel] [PATCH v5 10/16] spapr_drc: add spapr_drc_populate_dt()

2015-02-24 Thread David Gibson
On Mon, Feb 16, 2015 at 08:27:46AM -0600, Michael Roth wrote: This function handles generation of ibm,drc-* array device tree properties to describe DRC topology to guests. This will by used by the guest to direct RTAS calls to manage any dynamic resources we associate with a particular DR

Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully

2015-02-24 Thread Chen Gang S
On 2/24/15 15:53, Chen Gang S wrote: [...] diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 5131fa7..82c751e 100644 --- a/target-tilegx/translate.c +++ b/target-tilegx/translate.c @@ -25,18 +25,880 @@ #include exec/cpu_ldst.h #include exec/helper-gen.h

Re: [Qemu-devel] [PATCH 2/6] ram_find_and_save_block: change calling convention

2015-02-24 Thread Amit Shah
On (Thu) 12 Feb 2015 [23:03:07], Juan Quintela wrote: Add a parameter to pass the number of bytes written, and make it return the number of pages written instead. Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 44 ++-- 1 file

Re: [Qemu-devel] [PATCH v5 13/16] spapr_pci: populate DRC dt entries for PHBs

2015-02-24 Thread David Gibson
On Mon, Feb 16, 2015 at 08:27:49AM -0600, Michael Roth wrote: Reserve 32 entries of type PCI in each PHB's initial FDT. This I find this description odd. It's not reallky reserving anything, just publishing the DRCs you already created in the FDT. I wonder if this should be merged with the

Re: [Qemu-devel] [PATCH v7 0/5] Geometry and blocksize detection for backing devices.

2015-02-24 Thread Christian Borntraeger
Am 16.02.2015 um 12:47 schrieb Ekaterina Tumanova: Updates v6 - v7: Fix 1. Set default blocksizes via blkconf_blocksizes call in ide_dev_initfn and scsi_hd_realise before using these values. 2. Remove asserts in bdrv functions, check drv for being NULL instead. 3. Adjust logic in

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2015-02-24 Thread Thierry Carrez
** Changed in: nova Milestone: kilo-3 = None -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1368815 Title: qemu-img convert intermittently corrupts output images Status in Cinder: Triaged

Re: [Qemu-devel] [PATCH] virtio-scsi: Allocate op blocker reason before blocking

2015-02-24 Thread Markus Armbruster
Max Reitz mre...@redhat.com writes: s-blocker is really only used in hw/scsi/virtio-scsi.c; the only places where it is used in hw/scsi/virtio-scsi-dataplane.c is when it is allocated and when it is freed. That does not make a whole lot of sense (and is actually wrong because this leads to

Re: [Qemu-devel] [PATCH v3 0/3] -incoming defer

2015-02-24 Thread Stefan Hajnoczi
On Mon, Feb 23, 2015 at 10:55:53AM +, Dr. David Alan Gilbert wrote: * Stefan Hajnoczi (stefa...@gmail.com) wrote: On Thu, Feb 19, 2015 at 11:40:26AM +, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com This patchset provides a way of

Re: [Qemu-devel] [PULL 0/7] vnc: fixup some QemuOpts conversion fallout.

2015-02-24 Thread Peter Maydell
On 16 February 2015 at 17:25, Gerd Hoffmann kra...@redhat.com wrote: Hi, The multiple vnc servers patch series introduced some issues, mostly due to the QemuOpts conversion of the vnc option parsing. This pull fixes most of them. There also is one optimization. There is one pending

Re: [Qemu-devel] [PATCH 4/6] save_xbzrle_page: change calling convention

2015-02-24 Thread Amit Shah
On (Thu) 12 Feb 2015 [23:03:09], Juan Quintela wrote: Add a parameter to pass the number of bytes written, and make it return the number of pages written instead. Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 44 +--- 1 file

Re: [Qemu-devel] [PATCH RFC v3 00/27] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2015-02-24 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: 3. Prepare host kernel colo-proxy kernel module need cooperate with linux kernel. You should put a kernel patch 'colo-patch-for-kernel.patch' (It's based on linux kernel-3.19) which you can get from

Re: [Qemu-devel] [PATCH v2] utils: Add pow2ceil()

2015-02-24 Thread Peter Maydell
On 24 February 2015 at 18:39, Markus Armbruster arm...@redhat.com wrote: Eric Blake ebl...@redhat.com writes: Because 0x8000u is only required to be a 'long', and on 32-bit machines, your constant would overflow long. See, for example, commit 5cb6be2ca. You NEED the 'll' suffix

Re: [Qemu-devel] [PATCH] e1000: work around win 8.0 boot hang

2015-02-24 Thread Stefan Hajnoczi
On Tue, Feb 24, 2015 at 11:35 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Feb 19, 2015 at 08:24:19PM +0100, Radim Krčmář wrote: Window 8.0 driver has a particular behavior for a small time frame after it enables rx interrupts: the interrupt handler never clears E1000_ICR_RXT0. The

Re: [Qemu-devel] [PULL v2 00/14] target-mips queue

2015-02-24 Thread Peter Maydell
On 15 February 2015 at 02:44, Leon Alrae leon.al...@imgtec.com wrote: Hi, Here is version 2 of target-mips pullreq - rebased and with signed tag. Thanks, Leon Cc: Peter Maydell peter.mayd...@linaro.org Cc: Aurelien Jarno aurel...@aurel32.net The following changes since commit

Re: [Qemu-devel] [PATCH v7 0/5] Geometry and blocksize detection for backing devices.

2015-02-24 Thread Stefan Hajnoczi
On Mon, Feb 16, 2015 at 12:47:53PM +0100, Ekaterina Tumanova wrote: Updates v6 - v7: Fix 1. Set default blocksizes via blkconf_blocksizes call in ide_dev_initfn and scsi_hd_realise before using these values. 2. Remove asserts in bdrv functions, check drv for being NULL instead. 3.

Re: [Qemu-devel] [PATCH v2] utils: Add pow2ceil()

2015-02-24 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 24 February 2015 at 18:39, Markus Armbruster arm...@redhat.com wrote: Eric Blake ebl...@redhat.com writes: Because 0x8000u is only required to be a 'long', and on 32-bit machines, your constant would overflow long. See, for

Re: [Qemu-devel] [PATCH] e1000: work around win 8.0 boot hang

2015-02-24 Thread Stefan Hajnoczi
On Thu, Feb 19, 2015 at 08:24:19PM +0100, Radim Krčmář wrote: Window 8.0 driver has a particular behavior for a small time frame after it enables rx interrupts: the interrupt handler never clears E1000_ICR_RXT0. The handler does this something like this: set_imc(-1) (1)

Re: [Qemu-devel] [PATCH 6/6] rename save_block_hdr to save_page_header

2015-02-24 Thread Amit Shah
On (Thu) 12 Feb 2015 [23:03:11], Juan Quintela wrote: It has always been a page header, not a block header. Once there, the flag argument was only passed to make a bit or with it, just do the or on the caller. I prefer not to do that -- if one looks at the function signature, he'll only

[Qemu-devel] Packet dropps in virtual tap interface

2015-02-24 Thread Michael Kazakov
Hello. We use our highly load system in OpenStack environment. And faced with serious problems in network highload guests. At a relatively high CPU load of hypervisor (40-60%) virtual network interfaces of this guests starts to droppart of the packets. We use for virtualization qemu-kvm with

Re: [Qemu-devel] unable to set SATA serial with a spaces

2015-02-24 Thread Alan Latteri
Bug 1195660 https://bugzilla.redhat.com/show_bug.cgi?id=1195660 has been added to the database On Feb 23, 2015, at 3:41 AM, Michal Privoznik mpriv...@redhat.com wrote: On 23.02.2015 11:18, Markus Armbruster wrote: Alan Latteri a...@instinctual.tv writes: The left padding is important and

Re: [Qemu-devel] [PATCH v5 3/4] arm: Add PCIe host bridge in virt machine

2015-02-24 Thread Peter Maydell
On 7 February 2015 at 02:04, Alexander Graf ag...@suse.de wrote: typedef struct MemMapEntry { @@ -129,13 +131,21 @@ static const MemMapEntry a15memmap[] = { [VIRT_FW_CFG] = { 0x0902, 0x000a }, [VIRT_MMIO] = { 0x0a00, 0x0200 }, /* ...repeating for a

Re: [Qemu-devel] [PATCH 0/5] tcg-arm: LPAE: fix and extend xn control

2015-02-24 Thread Andrew Jones
On Thu, Feb 12, 2015 at 04:05:02PM +0100, Andrew Jones wrote: This series fixes and extends the determination of whether or not an address is executable for LPAE translations. The main patch is 4/5, and describes the details in its commit message. Patches 1-3 prepare for the main patch, and

Re: [Qemu-devel] [PATCH 0/5] tcg-arm: LPAE: fix and extend xn control

2015-02-24 Thread Peter Maydell
On 25 February 2015 at 00:06, Andrew Jones drjo...@redhat.com wrote: Ping? This isn't a huge priority, but I wouldn't want it to get lost either. I'm on holiday :-) Easy stuff is getting done but things that take time (read: code review) are postponed til mid-March. You can wait til then, or

[Qemu-devel] [PATCH 0/1] Get the list of arguments from a QMP command

2015-02-24 Thread Alberto Garcia
Hello, this is a follow-up to the comments from Eric Blake about my patches to extend the block streaming API: https://lists.gnu.org/archive/html/qemu-devel/2015-02/msg04231.html Since QEMU doesn't have an easy way to tell the arguments that a particular QMP command supports, and it seems

[Qemu-devel] [PATCH 1/1] qmp: Add support for requesting the list of arguments from a command

2015-02-24 Thread Alberto Garcia
This patch adds the CommandArgumentInfo type that lists the details of an argument that a QMP command can take. It currently includes its name and whether it's optional or not, but it can be extended in the future to include other information. A new 'query-command-args' command returns a list of

Re: [Qemu-devel] [PULL v2 00/65] Block patches

2015-02-24 Thread Peter Maydell
On 17 February 2015 at 00:45, Stefan Hajnoczi stefa...@redhat.com wrote: The following changes since commit cd2d5541271f1934345d8ca42f5fafff1744eee7: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20150212' into staging (2015-02-13 11:44:50 +) are available in the git

[Qemu-devel] [PULL 00/10] QOM devices patch queue 2015-02-24

2015-02-24 Thread Andreas Färber
Hello Peter, This is my QOM (devices) patch queue. Please pull. Regards, Andreas Cc: Peter Maydell peter.mayd...@linaro.org Cc: Markus Armbruster arm...@redhat.com The following changes since commit cd2d5541271f1934345d8ca42f5fafff1744eee7: Merge remote-tracking branch

[Qemu-devel] QEMU pci mach-virt: setting PCI_INTERRUPT_LINE?

2015-02-24 Thread Claudio Fontana
Hello, I am trying to set the pci interrupt line field in the configuration space (offset 0x3c), since it is initialized as zero. I would like to set it to the right value as read from the device tree, in order for other existing software which relies on it to be able to work unmodified.. but

[Qemu-devel] [PATCH 00/10] s390x: move sigp handling to user space

2015-02-24 Thread Jens Freimann
Cornelia, Alex, Christian, these patches move large parts of SIGP handling from kernel to user space. Please note: This series needs a linux-headers sync with v4.0-rc1 to work and should be applied only after Michael Tsirkin's series virtio: pull headers from linux was applied and a header

[Qemu-devel] [PULL 09/10] parallel: Factor out common parallel_hds_isa_init()

2015-02-24 Thread Andreas Färber
From: Markus Armbruster arm...@redhat.com Maintainers of affected machines cc'ed. Cc: Anthony Liguori aligu...@amazon.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Aurelien Jarno aurel...@aurel32.net Cc: Leon Alrae leon.al...@imgtec.com Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Markus

[Qemu-devel] [PULL 06/10] etsec: Replace qdev_init() by qdev_init_nofail()

2015-02-24 Thread Andreas Färber
From: Markus Armbruster arm...@redhat.com etsec_create() is a helper to create and realize the eTSEC. It's currently unused. Similar helpers for other NICs use qdev_init_nofail(). Match that. Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de ---

Re: [Qemu-devel] [PATCH 3/5] vpc: Ignore geometry for large images

2015-02-24 Thread Max Reitz
On 2015-02-24 at 01:45, Peter Lieven wrote: Am 23.02.2015 um 19:34 schrieb Max Reitz: On 2015-02-23 at 09:27, Peter Lieven wrote: From: Kevin Wolf kw...@redhat.com The CHS calculation as done per the VHD spec imposes a maximum image size of ~127 GB. Real VHD images exist that are larger than

[Qemu-devel] [PATCH 01/10] s390x: introduce defines for SIGP condition codes

2015-02-24 Thread Jens Freimann
From: David Hildenbrand d...@linux.vnet.ibm.com This patch introduces defines for the SIGP condition codes and replaces all occurrences of numeral condition codes with the new defines. Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com

[Qemu-devel] [PATCH 09/10] s390x/kvm: deliver SIGP RESTART directly if stopped

2015-02-24 Thread Jens Freimann
From: David Hildenbrand d...@linux.vnet.ibm.com According to the PoP, a restart irq has to be delivered without first honoring any other pending interruptions, if a cpu is in the STOPPED state. While it is hard to implement this case in kvm, it can easily be handled in qemu. Reviewed-by:

[Qemu-devel] [PATCH 05/10] s390x/kvm: trace all SIGP orders

2015-02-24 Thread Jens Freimann
From: David Hildenbrand d...@linux.vnet.ibm.com This patch adds tracing code for all SIGP orders (including the destination vcpu and the resulting condition code). Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Jens Freimann

[Qemu-devel] [PULL 02/10] qom: Fix typo, 'my_class_init' - 'derived_class_init'

2015-02-24 Thread Andreas Färber
From: Zhoujian jianjay.z...@huawei.com Signed-off-by: Zhoujian jianjay.z...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Signed-off-by: Andreas Färber afaer...@suse.de --- include/qom/object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qom/object.h

[Qemu-devel] [PULL 07/10] serial: Factor out common serial_hds_isa_init()

2015-02-24 Thread Andreas Färber
From: Markus Armbruster arm...@redhat.com It's the same old loop copied five times, plus another instance where it's clipped to two iterations and unrolled. No external users of serial_isa_init() are left, so give it internal linkage. Maintainers of affected machines cc'ed. Cc: Richard

[Qemu-devel] [PULL 04/10] ide/isa: Replace unchecked qdev_init() by qdev_init_nofail()

2015-02-24 Thread Andreas Färber
From: Markus Armbruster arm...@redhat.com isa_ide_init()'s callers don't check for failure. isa_ide_init() looks like it could fail, but since isa_ide_realizefn() can't fail, it actually can't. Replace its qdev_init() by qdev_init_nofail() to make it obvious. Cc: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH] virtio-scsi: Allocate op blocker reason before blocking

2015-02-24 Thread Max Reitz
On 2015-02-24 at 04:43, Markus Armbruster wrote: Max Reitz mre...@redhat.com writes: s-blocker is really only used in hw/scsi/virtio-scsi.c; the only places where it is used in hw/scsi/virtio-scsi-dataplane.c is when it is allocated and when it is freed. That does not make a whole lot of sense

[Qemu-devel] [PULL 01/10] qdev: Avoid type assertion in qdev_build_hotpluggable_device_list()

2015-02-24 Thread Andreas Färber
From: Jun Li junm...@gmail.com Currently when *obj is not a TYPE_DEVICE, QEMU will abort. This patch fixes it. When *obj is not a TYPE_DEVICE, just do not add it to hotpluggable device list. This patch also fixes the following issue: 1. boot QEMU using cli: $

Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully

2015-02-24 Thread Peter Maydell
On 24 February 2015 at 23:21, Chris Metcalf cmetc...@ezchip.com wrote: On 2/24/2015 2:53 AM, Chen Gang S wrote: typedef struct CPUTLState { +uint64_t regs[TILEGX_R_COUNT]; /* Common used registers by outside */ +uint64_t zero; /* Zero register */ +uint64_t pc;

[Qemu-devel] [PATCH 04/10] s390x/kvm: helper to set the SIGP status in SigpInfo

2015-02-24 Thread Jens Freimann
From: David Hildenbrand d...@linux.vnet.ibm.com Whenever we set the SIGP status in the status register, we have to wipe out the lower 4 bytes and keep the higher 4 bytes. Also the condition code will always be set to STATUS_STORED. Let's introduce the wrapper for SigpInfo, as this will avoid

[Qemu-devel] [PATCH 08/10] s390x: add function to deliver restart irqs

2015-02-24 Thread Jens Freimann
From: David Hildenbrand d...@linux.vnet.ibm.com This patch adds a helper function to deliver restart irqs. To be able to be used by kvm, the psw load/store methods have to perform special cc-code handling only when running with tcg. Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com

[Qemu-devel] [PATCH 07/10] s390x/kvm: SIGP START is only applicable when STOPPED

2015-02-24 Thread Jens Freimann
From: David Hildenbrand d...@linux.vnet.ibm.com In preparation for other CPU states, SIGP START will only start a VCPU if it is in the STOPPED state. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Jens Freimann

[Qemu-devel] [PULL 08/10] serial: serial_hds_isa_init() shouldn't fail

2015-02-24 Thread Andreas Färber
From: Markus Armbruster arm...@redhat.com It shouldn't fail, and no caller checks for failure. Make failure fatal. Maintainers of affected machines cc'ed. Cc: Richard Henderson r...@twiddle.net Cc: Anthony Liguori aligu...@amazon.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Aurelien Jarno

[Qemu-devel] [PULL 05/10] leon3: Replace unchecked qdev_init() by qdev_init_nofail()

2015-02-24 Thread Andreas Färber
From: Markus Armbruster arm...@redhat.com grlib_irqmp_create(), grlib_gptimer_create() and grlib_apbuart_create() are helpers to create and realize GRLIB devices. Their only caller leon3_generic_hw_init() doesn't check for failure. Only the first can actually fail, and only when the caller

[Qemu-devel] [PULL 03/10] qdev: Improve qdev_init_nofail()'s error reporting

2015-02-24 Thread Andreas Färber
From: Markus Armbruster arm...@redhat.com We get two error messages: a specific one from qdev_init(), and a generic one from qdev_init_nofail(). The specific one gets suppressed in QMP context. qdev_init_nofail() failing there is a bug, though. Cut out the qdev_init() middle-man: realize the

Re: [Qemu-devel] [PATCH 4/5] block/vpc: make calculate_geometry spec conform

2015-02-24 Thread Max Reitz
On 2015-02-24 at 01:49, Peter Lieven wrote: Am 23.02.2015 um 19:59 schrieb Max Reitz: On 2015-02-23 at 09:27, Peter Lieven wrote: The VHD spec [1] allows for total_sectors of 65535 x 16 x 255 (~127GB) represented by a CHS geometry. If total_sectors is greater than 65535 x 16 x 255 this

[Qemu-devel] [PULL 10/10] parallel: parallel_hds_isa_init() shouldn't fail

2015-02-24 Thread Andreas Färber
From: Markus Armbruster arm...@redhat.com It shouldn't fail, and no caller checks for failure. Make failure fatal. Maintainers of affected machines cc'ed. Cc: Anthony Liguori aligu...@amazon.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Aurelien Jarno aurel...@aurel32.net Cc: Leon Alrae

Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully

2015-02-24 Thread Chris Metcalf
On 2/24/2015 2:53 AM, Chen Gang S wrote: typedef struct CPUTLState { +uint64_t regs[TILEGX_R_COUNT]; /* Common used registers by outside */ +uint64_t zero; /* Zero register */ +uint64_t pc; /* Current pc */ CPU_COMMON } CPUTLState; I

[Qemu-devel] [PATCH 03/10] s390x/kvm: pass the SIGP instruction parameter to the SIGP handler

2015-02-24 Thread Jens Freimann
From: David Hildenbrand d...@linux.vnet.ibm.com The parameter of the SIGP instruction will be neded in the future. Let's read it out and store it in the struct sigp_info, so it can be passed to the sigp handlers. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck

[Qemu-devel] [PATCH 02/10] s390x/kvm: more details for SIGP handler with one destination vcpu

2015-02-24 Thread Jens Freimann
From: David Hildenbrand d...@linux.vnet.ibm.com Whenever a sigp order is to be executed by a target vcpu, we use run_on_cpu(). As we have only one pointer to pass all data to these sigp handlers, let's introduce the struct sigp_info and use it as a transport container. All orders targeting a

[Qemu-devel] [PATCH 10/10] s390x/kvm: enable the new SIGP handling in user space

2015-02-24 Thread Jens Freimann
From: David Hildenbrand d...@linux.vnet.ibm.com All required SIGP handlers have been implemented in QEMU. Let's enable the new sigp handling in user space if the kernel supports it. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com

[Qemu-devel] [PATCH 06/10] s390x/kvm: implement handling of new SIGP orders

2015-02-24 Thread Jens Freimann
From: David Hildenbrand d...@linux.vnet.ibm.com This patch adds handling code for the following SIGP orders: - SIGP SET ARCHITECTURE - SIGP SET PREFIX - SIGP STOP - SIGP STOP AND STORE STATUS - SIGP STORE STATUS AT ADDRESS SIGP STOP (AND STORE STATUS) are the only orders that can stay pending

Re: [Qemu-devel] [PATCH 2/3] block: Add QMP support for streaming to an intermediate layer

2015-02-24 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 23.02.2015 um 13:23 hat Alberto Garcia geschrieben: On Fri, Feb 20, 2015 at 03:38:04PM -0700, Eric Blake wrote: +if (has_top) { +top_bs = bdrv_find_backing_image(bs, top); +if (top_bs == NULL) { +

Re: [Qemu-devel] [PATCH 2/5] block/vpc: simplify vpc_read

2015-02-24 Thread Max Reitz
On 2015-02-24 at 01:44, Peter Lieven wrote: Am 23.02.2015 um 19:29 schrieb Max Reitz: On 2015-02-23 at 09:27, Peter Lieven wrote: Signed-off-by: Peter Lieven p...@kamp.de --- block/vpc.c | 116 +++ 1 file changed, 52 insertions(+),

[Qemu-devel] [PATCH v3 08/11] block: Make bdrv_close() static

2015-02-24 Thread Max Reitz
There are no users of bdrv_close() left, except for one of bdrv_open()'s failure paths, bdrv_close_all() and bdrv_delete(), and that is good. Make bdrv_close() static so nobody makes the mistake of directly using bdrv_close() again. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric

Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully

2015-02-24 Thread Chen Gang S
On 2/24/15 22:38, Peter Maydell wrote: On 24 February 2015 at 23:21, Chris Metcalf cmetc...@ezchip.com wrote: On 2/24/2015 2:53 AM, Chen Gang S wrote: typedef struct CPUTLState { +uint64_t regs[TILEGX_R_COUNT]; /* Common used registers by outside */ +uint64_t zero;

[Qemu-devel] [PATCH v3 09/11] blockdev: Keep track of monitor-owned BDS

2015-02-24 Thread Max Reitz
...and release the reference on bdrv_close_all(). Signed-off-by: Max Reitz mre...@redhat.com --- block.c| 5 + blockdev.c | 18 ++ include/block/block_int.h | 4 stubs/Makefile.objs

Re: [Qemu-devel] [PATCH 0/5] tcg-arm: LPAE: fix and extend xn control

2015-02-24 Thread Andrew Jones
On Wed, Feb 25, 2015 at 12:08:16AM +0900, Peter Maydell wrote: On 25 February 2015 at 00:06, Andrew Jones drjo...@redhat.com wrote: Ping? This isn't a huge priority, but I wouldn't want it to get lost either. I'm on holiday :-) Easy stuff is getting done but things that take time (read:

[Qemu-devel] [PATCH 5/9] blockdev: Add list of monitor-owned BlockBackends

2015-02-24 Thread Max Reitz
The monitor does hold references to some BlockBackends so it should have a list of those BBs; blk_backends is a different list, as it contains references to all BBs (after a follow-up patch, that is), and that should not be changed because we do need such a list. monitor_remove_blk() is

[Qemu-devel] [PATCH 2/9] block: Add blk_next_inserted()

2015-02-24 Thread Max Reitz
This function skips to the next BlockBackend for which blk_is_inserted() is true. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block/block-backend.c | 15 +++ include/sysemu/block-backend.h | 1 + 2 files changed, 16 insertions(+)

  1   2   3   >