Re: [Qemu-devel] [PATCH v3 2/4] target-tilegx: Add single floating point implementation

On 12/21/15 23:01, Richard Henderson wrote: > On 12/20/2015 07:30 AM, Chen Gang wrote: >> And we have to still check TILEGX_F_CALC_CVT, for they are really two >> different format: TILEGX_F_CALC_CVT has no HBIT, but TILEGX_F_CALC_NCVT >> has HBIT (which we need process it specially). > > The

Re: [Qemu-devel] [PATCH] ivshmem: remove redundant assignment, fix crash with msi=off

+-- On Mon, 21 Dec 2015, marcandre.lur...@redhat.com wrote --+ | diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c | index 7d14222..dcfc8cc 100644 | --- a/hw/misc/ivshmem.c | +++ b/hw/misc/ivshmem.c | @@ -355,12 +355,9 @@ static CharDriverState* create_eventfd_chr_device(IVShmemState *s, |

Re: [Qemu-devel] [Qemu-block] Jobs 2.0 QAPI [RFC]

On 12/21/2015 11:58 AM, Alberto Garcia wrote: > On Thu 17 Dec 2015 01:50:08 AM CET, John Snow wrote: >> In working through a prototype to enable multiple block jobs. A few >> problem spots in our API compatibility become apparent. >> >> In a nutshell, old Blockjobs rely on the

Re: [Qemu-devel] [PATCH v2 2/3] hw/sd: model a power-up delay, as a workaround for an EDK2 bug

> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Sunday, 20 December 2015 14:58 > On Wed, Dec 16, 2015 at 11:02 AM, Andrew Baumann > wrote: > > The SD spec for ACMD41 says that a zero argument is an "inquiry" > > ACMD41, which does not start

Re: [Qemu-devel] [PATCH 1/3] net/vmxnet3: return 1 on device activation failure

+-- On Mon, 21 Dec 2015, Miao Yan wrote --+ | So return 1 on device activation failure instead of -1; | | Signed-off-by: Miao Yan | --- | hw/net/vmxnet3.c | 2 +- | 1 file changed, 1 insertion(+), 1 deletion(-) | | diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c | index

Re: [Qemu-devel] [PATCH v14 Resend 10/13] pci: add pci device pre-post reset callbacks for host bus reset

On Fri, 2015-12-18 at 11:29 +0800, Chen Fan wrote: > On 12/18/2015 04:31 AM, Alex Williamson wrote: > > On Thu, 2015-12-17 at 09:41 +0800, Cao jin wrote: > > > From: Chen Fan > > > > > > Particularly, For vfio devices, Once need to recovery devices > > > by bus

[Qemu-devel] [PATCH v2 3/3] sdhci: add optional quirk property to disable card insertion/removal interrupts

This is needed for a quirk of the Raspberry Pi (bcm2835/6) MMC controller, where the card insert bit is documented as unimplemented (always reads zero, doesn't generate interrupts) but is in fact observed on hardware as set at power on, but is cleared (and remains clear) on subsequent controller

[Qemu-devel] [PATCH v2 1/3] sd: sdhci: Delete over-zealous power check

From: Peter Crosthwaite This check was conditionalising SD card operation on the card being powered by the SDHCI host controller. It is however possible (particularly in embedded systems) for the power control of the SD card to be managed outside of SDHCI. This can be

[Qemu-devel] [PATCH v2 2/3] sdhci: don't raise a command index error for an unexpected response

This deletes a block of code that raised a command index error if a command returned response data, but the guest did not set the appropriate bits in the response register to handle such a response. I cannot find any documentation that suggests the controller should behave in this way, the error

[Qemu-devel] [Bug 893208] Re: qemu on ARM hosts can't boot i386 image

Still present in 2.5. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/893208 Title: qemu on ARM hosts can't boot i386 image Status in QEMU: New Status in Linaro QEMU: New Bug description: If

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Frame v12 25/38] qmp event: Add event notification for COLO error

On 12/19/2015 05:02 AM, Markus Armbruster wrote: > Copying qemu-block because this seems related to generalising block jobs > to background jobs. > > zhanghailiang writes: > >> If some errors happen during VM's COLO FT stage, it's important to notify >> the

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

On Mon, Dec 21, 2015 at 09:41:32AM +, Gonglei (Arei) wrote: > When the gurb of OS is booting, then the softirq and C function send_disk_op() > may use extra stack of SeaBIOS. If we inject a NMI, romlayout.S: > irqentry_extrastack > is invoked, and the extra stack will be used again. And the

Re: [Qemu-devel] [PATCH 1/8] bcm2835_sbm: add BCM2835 mailboxes

On Mon, Dec 21, 2015 at 3:15 PM, Andrew Baumann wrote: > Hi Peter, > > Thanks for the review! > >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >> Sent: Monday, 21 December 2015 14:49 >> On Thu, Dec 3, 2015 at 10:01 PM, Andrew Baumann >>

[Qemu-devel] [PATCH v2 07/14] qapi: add json output visitor

We have several places that want to go from qapi to JSON; right now, they have to create an intermediate QObject to do the work. That also has the drawback that the JSON formatting of a QDict will rearrange keys (according to a deterministic, but unpredictable, hash), when humans have an easier

[Qemu-devel] [PATCH v2 02/14] qapi: Improve use of qmp/types.h

'qobject-json.h' is not a QObject subtype; include this file directly in .c files that are using it, rather than abusing qmp/types.h for that purpose. Meanwhile, for files that include a list of individual QObject subtypes, it's easier to just use qmp/types.h for that purpose. Signed-off-by:

[Qemu-devel] [PATCH v2 13/14] qapi: Support pretty printing in JSON output visitor

Similar to pretty printing in the QObject visitor. The rickiest parts are the fact that during type_any(), we have to coordinate with QObject to also print pretty; and the fact that the testsuite now has to honor parameterization on whether pretty printing is enabled. Signed-off-by: Eric Blake

[Qemu-devel] [PATCH v2 06/14] qapi: Add qstring_append_format()

Back in commit 764c1ca (Nov 2009), we added qstring_append_int(). However, it did not see any use until commit 190c882 (Jan 2015). Furthermore, it has a rather limited use case - to print anything else, callers still have to format into a temporary buffer, unless we want to introduce an explosion

[Qemu-devel] [PATCH v2 04/14] qapi: Factor out JSON number formatting

Pull out a new qstring_append_json_number() helper, so that all JSON output producers can use a consistent style for printing floating point without duplicating code (since we are doing more data massaging than a simple printf format can handle). Address one FIXME by adding an Error parameter and

Re: [Qemu-devel] [PATCH v2 3/3] sdhci: add optional quirk property to disable card insertion/removal interrupts

> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Monday, 21 December 2015 13:42 > On Mon, Dec 21, 2015 at 1:31 PM, Andrew Baumann > wrote: > > This is needed for a quirk of the Raspberry Pi (bcm2835/6) MMC > > controller, where the card insert

Re: [Qemu-devel] [PATCH v2 2/3] hw/sd: model a power-up delay, as a workaround for an EDK2 bug

On Mon, Dec 21, 2015 at 2:25 PM, Andrew Baumann wrote: >> From: qemu-devel-bounces+andrew.baumann=microsoft@nongnu.org >> [mailto:qemu-devel- >> bounces+andrew.baumann=microsoft@nongnu.org] On Behalf Of >> Peter Crosthwaite >> Sent: Monday, 21 December 2015

[Qemu-devel] [PATCH v2 14/14] qemu-img: Use new JSON output formatter

Now that we can pretty-print straight to JSON from a visitor, we can eliminate the temporary conversion into QObject inside qemu-img. The changes to qemu-iotests 043 expected output demonstrates the fact that output is now done in qapi declaration order, rather than QDict hash order.

Re: [Qemu-devel] [PATCH v2 2/3] hw/sd: model a power-up delay, as a workaround for an EDK2 bug

> From: qemu-devel-bounces+andrew.baumann=microsoft@nongnu.org > [mailto:qemu-devel- > bounces+andrew.baumann=microsoft@nongnu.org] On Behalf Of > Peter Crosthwaite > Sent: Monday, 21 December 2015 13:46 > On Wed, Dec 16, 2015 at 11:02 AM, Andrew Baumann >

[Qemu-devel] [PATCH v2 12/14] qapi: Add qobject_to_json_pretty_prefix()

The next patch will add pretty indentation to the JSON visitor. But in order to support pretty output in the type_any() callback, we need to prefix every line of the QObject visitor by the current indentation in the JSON visitor. Hence, a new function qobject_to_json_pretty_indent(), and the old

[Qemu-devel] [PATCH v2 00/14] Add qapi-to-JSON output visitor

Prerequisites: + my qapi cleanups subset E v8: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03863.html I wrote this series for several reasons: 1. I've been doing a lot of churn in the qapi visitor interfaces lately; adding a new visitor is good proof whether the changes still make

[Qemu-devel] [PATCH v2 10/14] vmstate: use new JSON output visitor

Rather than using a QJSON object and converting the QString result to a char *, we can use the new JSON output visitor and get directly to a char *. The conversions are a bit tricky in place (in places, we have to copy an integer to an int64_t temporary to get the right pointer for

[Qemu-devel] [PATCH v2 05/14] qapi: Use qstring_append_chr() where appropriate

No need to create a temporary buffer, when we already have a function available for our needs. Signed-off-by: Eric Blake --- qobject/json-parser.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/qobject/json-parser.c b/qobject/json-parser.c index

[Qemu-devel] [PATCH v2 03/14] qapi: Factor out JSON string escaping

Pull out a new qstring_append_json_string() helper, so that all JSON output producers can use the same output escaping rules. While it appears that vmstate's use of the simpler qjson.c formatter is not currently encountering any string that needs escapes to be valid JSON, it is better to be safe

Re: [Qemu-devel] [PATCH v2 2/3] hw/sd: model a power-up delay, as a workaround for an EDK2 bug

On Wed, Dec 16, 2015 at 11:02 AM, Andrew Baumann wrote: > The SD spec for ACMD41 says that a zero argument is an "inquiry" > ACMD41, which does not start initialisation and is used only for > retrieving the OCR. However, Tianocore EDK2 (UEFI) has a bug [1]: it >

[Qemu-devel] [PATCH v2 0/3] sdhci patches to enable Raspberry Pi

This is a series of three tweaks needed to enable the generic sdhci controller to emulate Raspberry Pi (bcm2835/2836), and boot Linux and Windows. There was some discussion of these changes in the following thread: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg01401.html v2 is

[Qemu-devel] [PATCH v2 01/14] qapi: Rename (one) qjson.h to qobject-json.h

We have two different JSON visitors in the tree; and having both named 'qjson.h' can cause include confusion. Rename the qapi version. Why did I pick that one? A later patch plans on deleting the top-level qjson.c once we have a native JSON output visitor; we could have renamed that one for

[Qemu-devel] [PATCH v2 08/14] qjson: Simplify by using json-output-visitor

Instead of rolling our own limited JSON outputter, we can just wrap the more full-featured JSON output Visitor. This slightly changes the output (different spacing), but the result is still equivalent JSON contents. Signed-off-by: Eric Blake --- v2: rebase to earlier changes

[Qemu-devel] [PATCH v2 11/14] qjson: Remove unused file

Now that we have a JSON output visitor, and the previous patch fixed the only client of vmstate to use it, we no longer need the simpler QJSON object doing the same thing. Signed-off-by: Eric Blake --- v2: new patch This is part of alternative 2, along with patch 10. See

[Qemu-devel] [PATCH v2 09/14] Revert "qjson: Simplify by using json-output-visitor"

This reverts commit 5859ad241516eed8cb9ba60889efa0ed47648b38. The revert is here only to show the difference between two alternatives, the final series will have just one choice of patch 8, or of patches 10-11 --- qjson.c | 61 +++-- 1

[Qemu-devel] [PATCH v3 0/3] sdhci patches to enable Raspberry Pi

This is a series of three tweaks needed to enable the generic sdhci controller to emulate Raspberry Pi (bcm2835/2836), and boot Linux and Windows. There was some discussion of these changes in the following thread: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg01401.html v2 is

[Qemu-devel] [PATCH v3 3/3] sdhci: add optional quirk property to disable card insertion/removal interrupts

This is needed for a quirk of the Raspberry Pi (bcm2835/6) MMC controller, where the card insert bit is documented as unimplemented (always reads zero, doesn't generate interrupts) but is in fact observed on hardware as set at power on, but is cleared (and remains clear) on subsequent controller

[Qemu-devel] [PATCH v3 1/3] sd: sdhci: Delete over-zealous power check

From: Peter Crosthwaite This check was conditionalising SD card operation on the card being powered by the SDHCI host controller. It is however possible (particularly in embedded systems) for the power control of the SD card to be managed outside of SDHCI. This can be

Re: [Qemu-devel] [PATCH] qmp: return err msg when powerdown a vm when it isn't in running state

Thanks for your help, i'll resubmit the patch right away. At 2015-12-22 01:55:35, "P J P" wrote: >+-- On Mon, 21 Dec 2015, Qinghua Jin wrote --+ >| -void qmp_system_powerdown(Error **erp) >| +void qmp_system_powerdown(Error **errp) >| { >| +if (!runstate_is_running()) {

Re: [Qemu-devel] [PATCH v5 RFC] spec: add qcow2 bitmaps extension specification

On 21.12.2015 16:25, Vladimir Sementsov-Ogievskiy wrote: > The new feature for qcow2: storing bitmaps. > > Only bitmaps, relative to the virtual disk, stored in qcow2 file, should > be stored in this qcow2 file. > > Strings started from +# are RFC-strings, not to be commited of course > >

Re: [Qemu-devel] [PATCH 1/8] bcm2835_sbm: add BCM2835 mailboxes

On Thu, Dec 3, 2015 at 10:01 PM, Andrew Baumann wrote: > This adds the system mailboxes which are used to communicate with a > number of GPU peripherals on Pi/Pi2. > > Signed-off-by: Andrew Baumann > --- >

[Qemu-devel] [PATCH v3 2/3] sdhci: don't raise a command index error for an unexpected response

This deletes a block of code that raised a command index error if a command returned response data, but the guest did not set the appropriate bits in the response register to handle such a response. I cannot find any documentation that suggests the controller should behave in this way, the error

Re: [Qemu-devel] [PATCH 1/8] bcm2835_sbm: add BCM2835 mailboxes

> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Monday, 21 December 2015 15:33 > On Mon, Dec 21, 2015 at 3:15 PM, Andrew Baumann > wrote: > >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > >> Sent: Monday, 21 December 2015 14:49

Re: [Qemu-devel] [PATCH v2 2/3] hw/sd: model a power-up delay, as a workaround for an EDK2 bug

On Mon, Dec 21, 2015 at 1:04 PM, Andrew Baumann wrote: >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >> Sent: Sunday, 20 December 2015 14:58 >> On Wed, Dec 16, 2015 at 11:02 AM, Andrew Baumann >> wrote: >> > The SD spec

Re: [Qemu-devel] [PATCH v2 3/3] sdhci: add optional quirk property to disable card insertion/removal interrupts

On Mon, Dec 21, 2015 at 1:31 PM, Andrew Baumann wrote: > This is needed for a quirk of the Raspberry Pi (bcm2835/6) MMC > controller, where the card insert bit is documented as unimplemented > (always reads zero, doesn't generate interrupts) but is in fact > observed

Re: [Qemu-devel] [PATCH 1/8] bcm2835_sbm: add BCM2835 mailboxes

Hi Peter, Thanks for the review! > From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Monday, 21 December 2015 14:49 > On Thu, Dec 3, 2015 at 10:01 PM, Andrew Baumann > wrote: > > This adds the system mailboxes which are used to communicate with a

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

Dear Kevin, > -Original Message- > From: Kevin O'Connor [mailto:ke...@koconnor.net] > Sent: Sunday, December 20, 2015 10:33 PM > To: Gonglei (Arei) > Cc: Xulei (Stone); Paolo Bonzini; qemu-devel; seab...@seabios.org; > Huangweidong (C); k...@vger.kernel.org; Radim Krcmar > Subject: Re:

Re: [Qemu-devel] [PATCH] qmp: return err msg when powerdown a vm when it isn't in running state

+-- On Mon, 21 Dec 2015, Qinghua Jin wrote --+ | -void qmp_system_powerdown(Error **erp) | +void qmp_system_powerdown(Error **errp) | { | +if (!runstate_is_running()) { | +error_setg(errp, "Can't powerdown the Virtual Machine when it isn't running"); | +return; | +} |

Re: [Qemu-devel] [PATCH] scsi: initialise info object with appropriate size

+-- On Mon, 21 Dec 2015, Paolo Bonzini wrote --+ | I can add the Cc to the commit message as well. For now it's enough to | send a message in Cc so that the qemu-stable people notice it. Okay, great! Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13

Re: [Qemu-devel] [PATCH v4 RFC] spec: add qcow2-dirty-bitmaps specification

On 14.12.2015 23:45, John Snow wrote: On 12/14/2015 03:05 PM, Max Reitz wrote: On 14.12.2015 18:43, Vladimir Sementsov-Ogievskiy wrote: The new feature for qcow2: storing dirty bitmaps. Only dirty bitmaps relative to this qcow2 image should be stored in it. Strings started from +# are

[Qemu-devel] ODP: [PATCH 02/12] Added reset-pin emulation in model.

W dniu 21.12.2015 o 12:04, Peter Crosthwaite pisze: > On Wed, Dec 16, 2015 at 4:57 AM, wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Marcin Krzeminski >> --- >> hw/block/m25p80.c | 38

[Qemu-devel] ODP: [PATCH 04/12] Changed variable type to allow serial eeprom emulation (changing 0->1).

W dniu 21.12.2015 o 12:23, Peter Crosthwaite pisze: > Your commit message subject line should be a little shorter and > lengthier explanations of the patch content go here as a paragraph. > You should also have subsystem prefixes to patch subject lines. This > patch would be something like: > >

[Qemu-devel] ODP: [PATCH 10/12] Support for quad commands.

W dniu 21.12.2015 o 12:52, Peter Crosthwaite pisze: > On Wed, Dec 16, 2015 at 4:57 AM, wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Pawel Lenkow > > Same comments as for earlier patches. Need to

[Qemu-devel] [Bug 1528239] [NEW] Unable to debug PIE binaries with QEMU gdb stub.

Public bug reported: The issue occurs on current trunk: max@max:~/build/qemu$ cat test.c #include int main() { printf("Hello, world!\n"); return 0; } max@max:~/build/qemu$ gcc test.c -fPIC -pie -o bad.x max@max:~/build/qemu$ ./x86_64-linux-user/qemu-x86_64 -g 1234 bad.x

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

On 12/21/2015 06:08 PM, Marcel Apfelbaum wrote: On 12/21/2015 04:59 AM, Cao jin wrote: [...] Another question: because some of this series is CCed to qemu-trivial(which means: reviewed-by?) by other maintainer, so next time, do I need to send the whole series with "v2", or the rest?

Re: [Qemu-devel] [PATCH 02/12] Added reset-pin emulation in model.

On Wed, Dec 16, 2015 at 4:57 AM, wrote: > From: Marcin Krzeminski > > Signed-off-by: Marcin Krzeminski > --- > hw/block/m25p80.c | 38 +- > 1 file changed, 37

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

Hello! > Yes, we can use KVM_EXIT_REG_IO/MSR_IO for Hyper-V SynIC MSRS's changes > and can even use only one MSR value . So union inside struct > kvm_hyperv_exit is excessive. > > But we still need Vcpu exit to handle VMBus hypercalls by QEMU to > emulate VMBus devices inside QEMU. > > And

[Qemu-devel] ODP: [PATCH 05/12] Added support for serial eeproms - AT25128A/AT25256A

W dniu 21.12.2015 o 12:28, Peter Crosthwaite pisze: > Subsystem prefix needed in commit subject (block: m25p80). Bring the > mention of specific parts to the paragraph to shorten the subject. I accidentally removed word m25p80 from all patches subject. Sorry. > > > On Wed, Dec 16, 2015 at 4:57

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

On 12/21/2015 04:28 PM, Pavel Fedin wrote: Hello! Yes, we can use KVM_EXIT_REG_IO/MSR_IO for Hyper-V SynIC MSRS's changes and can even use only one MSR value . So union inside struct kvm_hyperv_exit is excessive. But we still need Vcpu exit to handle VMBus hypercalls by QEMU to emulate

[Qemu-devel] ODP: [PATCH 08/12] Support for N25Q256A/N25Q512A

W dniu 21.12.2015 o 11:29, Peter Crosthwaite pisze: > On Wed, Dec 16, 2015 at 4:57 AM, wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Marcin Krzeminski >> --- >> hw/block/m25p80.c | 2 ++ >> 1

[Qemu-devel] ODP: [PATCH 06/12] 4byte address mode support added.

W dniu 21.12.2015 o 12:35, Peter Crosthwaite pisze: > Commit subject subsystem prefix (block: m25p80:) needed. > > On Wed, Dec 16, 2015 at 4:57 AM, wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Marcin Krzeminski

Re: [Qemu-devel] [PATCH 1/1] qga: guest-set-user-password - added ability to create new user

On 12/20/2015 11:40 PM, Denis V. Lunev wrote: > From: Yuri Pudgorodskiy > > Added optional 'create' flag to guest-set-user-password command. > When it is specified, a new user will be created if it is not > exists yet. s/is not exists/does not exist/ > > The option to the

[Qemu-devel] ODP: [PATCH 12/12] Read flag status register command support added.

W dniu 21.12.2015 o 12:54, Peter Crosthwaite pisze: > Subsystem prefix needed and reverse commit subject to start with verb: > > "block: m25p80: Add Read Flag Status command" > > On Wed, Dec 16, 2015 at 4:57 AM, wrote: >> From: Marcin Krzeminski

Re: [Qemu-devel] [Xen-devel] new barrier type for paravirt (was Re: [PATCH] virtio_ring: use smp_store_mb)

On Mon, 21 Dec 2015, David Vrabel wrote: > On 20/12/15 09:25, Michael S. Tsirkin wrote: > > > > I noticed that drivers/xen/xenbus/xenbus_comms.c uses > > full memory barriers to communicate with the other side. > > For example: > > > > /* Must write data /after/ reading the

[Qemu-devel] ODP: [PATCH 03/12] Reset enable and reset memory commands support.

W dniu 21.12.2015 o 12:18, Peter Crosthwaite pisze: > On Wed, Dec 16, 2015 at 4:57 AM, wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Marcin Krzeminski >> --- >> hw/block/m25p80.c | 15

[Qemu-devel] ODP: [PATCH 07/12] Added support for extend address mode commands.

W dniu 21.12.2015 o 12:41, Peter Crosthwaite pisze: > Subsystem prefix. > > On Wed, Dec 16, 2015 at 4:57 AM, wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Marcin Krzeminski >> --- >>

Re: [Qemu-devel] [PATCH 1/1] qga: guest-set-user-password - added ability to create new user

On 12/21/2015 05:00 PM, Eric Blake wrote: On 12/20/2015 11:40 PM, Denis V. Lunev wrote: From: Yuri Pudgorodskiy Added optional 'create' flag to guest-set-user-password command. When it is specified, a new user will be created if it is not exists yet. s/is not exists/does

Re: [Qemu-devel] [PATCH v9 0/5] implement vNVDIMM

On 12/10/2015 11:11 AM, Xiao Guangrong wrote: New version, new week, and unfortunate new ping... :( Ping again to see what happened...

[Qemu-devel] [Bug 1528214] [NEW] qemu 1.7.0 vhost_net crash

Public bug reported: i find the crash in /var/crash the crash content is : <4>Pid: 6949, comm: qemu-system-x86 Not tainted 2.6.32-431.el6.x86_64 #1 Powerleader PR2530G2/SC612DI-8F <4>RIP: 0010:[] [] fput+0x9/0x30 <4>RSP: 0018:88015b601d98 EFLAGS: 00010292 <4>RAX: 0382 RBX:

[Qemu-devel] [Bug 1528214] Re: qemu 1.7.0 vhost_net crash

my envionment is centos6.5 and libvirt version is 1.2.14 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1528214 Title: qemu 1.7.0 vhost_net crash Status in QEMU: New Bug description: i find

[Qemu-devel] ODP: [PATCH 09/12] Support for 6Bytes jdec.

W dniu 21.12.2015 o 11:47, Peter Crosthwaite pisze: > You need to add more notes in commit messages about what you have > changed. Specifically here, you need to say something about the > arrayification of the Jedec ID. You are also correcting terminology by > changing ext_jedec to ext_id which

Re: [Qemu-devel] [PATCH v3 18/24] vmdk: Clean up "Invalid extent lines" error message

On Fri, 12/18 16:35, Markus Armbruster wrote: > vmdk_parse_extents() reports parse errors like this: > > error_setg(errp, "Invalid extent lines:\n%s", p); > > where p points to the beginning of the malformed line in the image > descriptor. This results in a multi-line error message > >

Re: [Qemu-devel] [PATCH v2] linux-user/mmap.c: Always zero MAP_ANONYMOUS memory inmmap_frag()

> From: "Laurent Vivier";; > > Le 21/12/2015 03:33, cheng...@emindsoft.com.cn a écrit : >> From: Chen Gang >> >> When mapping MAP_ANONYMOUS memory fragments, still need notice about to >> set it zero, or it will cause issues. > > Perhaps you can

Re: [Qemu-devel] [PATCH v3 2/4] target-tilegx: Add single floating point implementation

On 12/21/2015 10:54 AM, Chen Gang wrote: The both do, in that you re-normalize to produce that HBIT. That's the whole point. Oh, yes. But all together, we want to normalize the float value in fsingle_pack2, so we can not use float64_to_float32()... Of course not. I told you that you

[Qemu-devel] [PATCH v2] xen-pvdevice: convert to realize()

Signed-off-by: Cao jin --- hw/i386/xen/xen_pvdevice.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/i386/xen/xen_pvdevice.c b/hw/i386/xen/xen_pvdevice.c index c218947..9abcf25 100644 --- a/hw/i386/xen/xen_pvdevice.c +++

[Qemu-devel] [PATCH v2 08/11] iotests: 038: Use TEST_IMG override instead of "mv"

Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/qemu-iotests/038 | 5 - tests/qemu-iotests/038.out | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/038 b/tests/qemu-iotests/038 index cfaf00a..34fe698

[Qemu-devel] [PATCH v2 06/11] iotests: 034: Use TEST_IMG override instead of "mv"

Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/qemu-iotests/034 | 6 +- tests/qemu-iotests/034.out | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/034 b/tests/qemu-iotests/034 index 69c7858..c769dd8

[Qemu-devel] [PATCH v2 04/11] iotests: 024: Use TEST_IMG override instead of "mv"

Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/qemu-iotests/024 | 10 -- tests/qemu-iotests/024.out | 4 ++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/024 b/tests/qemu-iotests/024 index

[Qemu-devel] [PATCH v2 03/11] iotests: 020: Use TEST_IMG override instead of "mv"

Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/qemu-iotests/020 | 7 +-- tests/qemu-iotests/020.out | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/020 b/tests/qemu-iotests/020 index

[Qemu-devel] [PATCH v2 01/11] iotests: 018: Use TEST_IMG override instead of "mv"

Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/qemu-iotests/018 | 8 tests/qemu-iotests/018.out | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/018 b/tests/qemu-iotests/018 index

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

Hi, Kevin, Can you tell how to reset/reboot this VM, if it goes to the handle_hwpic1() on its booting procedure? I mean, usually, SeaBIOS would not go to handle_hwpic routine. But in my test case, SeaBIOS calls handle_hwpic when KVM injects a #UD expcetion (not irq) and SeaBIOS will loop to

[Qemu-devel] [PATCH v2] qmp: return err msg when powerdown a vm when it isn't in running state

This is an update of patch previously show in msg: http://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03817.html When send system_powerdown to QMP when the vm isn't in RUN_STATE_RUNNING, it will be ignored by system. So reply a err msg with the situation. Signed-off-by: Qinghua Jin

Re: [Qemu-devel] [PATCH 1/3] net/vmxnet3: return 1 on device activation failure

2015-12-22 2:15 GMT+08:00 P J P : > +-- On Mon, 21 Dec 2015, Miao Yan wrote --+ > | So return 1 on device activation failure instead of -1; > | > | Signed-off-by: Miao Yan > | --- > | hw/net/vmxnet3.c | 2 +- > | 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH v2 2/4] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DID_* command

VMXNET3_CMD_GET_DID_LO should return PCI ID of the device and VMXNET3_CMD_GET_DID_HI should return vmxnet3 revision ID. This behavior can be observed by the following steps: 1) run a Linux distro on esxi server 2) modify vmxnet3 Linux driver to read DID_HI and DID_LO:

[Qemu-devel] [PATCH v2 3/4] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DEV_EXTRA_INFO

VMXNET3_CMD_GET_DEV_EXTRA_INFO should return 0 for emulation mode This behavior can be observed by the following steps: 1) run a Linux distro on esxi server 2) modify vmxnet3 Linux driver to read the register: VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD, VMXNET3_CMD_GET_DEV_EXTRA_INFO);

[Qemu-devel] [PATCH v2 1/4] net/vmxnet3: return 1 on device activation failure

When reading device status, 0 means device is successfully activated and 1 means error. This behavior can be observed by the following steps: 1) run a Linux distro on esxi server 2) modify vmxnet3 Linux driver to give it an invalid address to 'adapter->shared_pa' which is the shared memory

Re: [Qemu-devel] 回复： 回复： someconfusion on qemu i/o pocess and the qcow2format

On Mon, Dec 21, 2015 at 10:48:07AM +0800, 浩樊啊 wrote: > I want to change the queue_size of virtio-blk ring from 128 to 1024, so I > change here: > s->vq = virtio_add_queue(vdev, 128, virtio_blk_handle_output); > but the vm will not work. Are any thing i missed ? I think 1024 should work in

Re: [Qemu-devel] [PATCH 10/10] iotests: 095: Use TEST_IMG override instead of "mv"

On Fri, 12/18 19:18, Max Reitz wrote: > On 16.12.2015 10:54, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > tests/qemu-iotests/095 | 12 ++-- > > tests/qemu-iotests/095.out | 8 > > 2 files changed, 10 insertions(+), 10 deletions(-) > > > > diff

Re: [Qemu-devel] [PATCH v5 RFC] spec: add qcow2 bitmaps extension specification

On 22.12.2015 02:56, Max Reitz wrote: On 21.12.2015 16:25, Vladimir Sementsov-Ogievskiy wrote: The new feature for qcow2: storing bitmaps. Only bitmaps, relative to the virtual disk, stored in qcow2 file, should be stored in this qcow2 file. Strings started from +# are RFC-strings, not to be

[Qemu-devel] [PATCH v2 10/11] iotests: 095: Use TEST_IMG override instead of "mv"

Signed-off-by: Fam Zheng --- tests/qemu-iotests/095 | 6 ++ tests/qemu-iotests/095.out | 4 ++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/095 b/tests/qemu-iotests/095 index 6630181..57a730e 100755 --- a/tests/qemu-iotests/095 +++

[Qemu-devel] [PATCH v2 02/11] iotests: 019: Use TEST_IMG override instead of "mv"

Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/qemu-iotests/019 | 13 +++-- tests/qemu-iotests/019.out | 4 ++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/tests/qemu-iotests/019 b/tests/qemu-iotests/019 index

[Qemu-devel] [PATCH v2 05/11] iotests: 028: Use TEST_IMG override instead of "mv"

Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/qemu-iotests/028 | 5 - tests/qemu-iotests/028.out | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/028 b/tests/qemu-iotests/028 index a1f4423..009510d

[Qemu-devel] [PATCH v2 00/11] iotests: Clean up "mv $TEST_IMG $TEST_IMG.XXX"

v2: Add Max's rev-by in patches 1-9. Fix quote bugs in patch 10 and split out _img_info filtering patch 11. Commit 794d00f71d fixed two "mv" commands into the TEST_IMG override approach. There are still more occasions of "mv", this series fixes them. The benefit is it drops the assumption

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

On 12/21/2015 11:49 PM, Paolo Bonzini wrote: On 20/12/2015 12:38, Cao jin wrote: +object_unref(OBJECT(ds)); +object_unref(OBJECT(bds)); +object_unref(OBJECT(bus)); I think these should be object_unparent, not unref. But, it seems these 3 objects isn`t added as a

Re: [Qemu-devel] [PATCH 5/5] xen-pvdevice: convert to realize()

Hi On 12/22/2015 09:24 AM, Cao jin wrote: On 12/21/2015 11:15 PM, Stefano Stabellini wrote: On Fri, 18 Dec 2015, Cao jin wrote: [...] This doesn't even compile: you are missing a ';' Please at least build test patches. Yup...sorry for the silly mistake...but weird, I did build and

[Qemu-devel] [PATCH v2 0/4] correct some register return values for vxmnet3

Qemu vmxnet3 emulation doesn't recognize VMXNET3_CMD_GET_DID_LO, VMXNET3_CMD_GET_DID_HI and VMXNET3_CMD_GET_DEV_EXTRA_INFO command and returns -1 on all of them. This patchset makes them return correct values. Changes in v2: - return 0 on unknown command Miao Yan (4): net/vmxnet3: return 1

[Qemu-devel] [PATCH v2 4/4] net/vmxnet3: return 0 on unknown command

Return 0 on unknown command, this is what esxi behaves. Signed-off-by: Miao Yan --- hw/net/vmxnet3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index b8bc360..a429405 100644 --- a/hw/net/vmxnet3.c +++

Re: [Qemu-devel] [PATCH 5/5] xen-pvdevice: convert to realize()

On 12/21/2015 11:15 PM, Stefano Stabellini wrote: On Fri, 18 Dec 2015, Cao jin wrote: Signed-off-by: Cao jin --- hw/i386/xen/xen_pvdevice.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/i386/xen/xen_pvdevice.c

Re: [Qemu-devel] [PATCH v2] qmp: return err msg when powerdown a vm when it isn't in running state

On Tue, 12/22 09:42, Qinghua Jin wrote: > This is an update of patch previously show in msg: > > http://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03817.html The patch looks good to me, thanks for submitting the patch! There is only one minor comment: Patch revision note should go after

Re: [Qemu-devel] [PATCH v2] qmp: return err msg when powerdown a vm when it isn't in running state

Thanks for helping me, i'll use the patch format suggested by you. At 2015-12-22 10:06:17, "Fam Zheng" wrote: >On Tue, 12/22 09:42, Qinghua Jin wrote: >> This is an update of patch previously show in msg: >> >>

[Qemu-devel] [PATCH v2 07/11] iotests: 037: Use TEST_IMG override instead of "mv"

Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/qemu-iotests/037 | 5 - tests/qemu-iotests/037.out | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/037 b/tests/qemu-iotests/037 index 9171d8c..5862451

[Qemu-devel] [PATCH v3] qmp: return err msg when powerdown a vm when it isn't in running state

When send system_powerdown to QMP when the vm isn't in RUN_STATE_RUNNING, it will be ignored by system. So reply a err msg with the situation. Signed-off-by: Qinghua Jin --- This is an update of the patch as per Fam Zheng's suggestion:

  1   2   3   >