Re: [Qemu-devel] [PATCH 2/3] hw/net/spapr_llan: Fix receive buffer handling for better performance

2016-03-19 Thread David Gibson
On Fri, Mar 18, 2016 at 08:56:56AM +0100, Thomas Huth wrote: > On 17.03.2016 23:33, David Gibson wrote: > > On Thu, Mar 17, 2016 at 04:15:38PM +0100, Thomas Huth wrote: > >> On 17.03.2016 08:30, Thomas Huth wrote: > >>> On 17.03.2016 07:23, David Gibson wrote: > On Wed, Mar 16, 2016 at

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

2016-03-19 Thread Christian Borntraeger
On 03/16/2016 12:09 PM, Paolo Bonzini wrote: > > > On 16/03/2016 11:49, Christian Borntraeger wrote: >> Seems to lockup. > > That's an improvement actually. :) > >> Thread 3 (Thread 0x3ff888dc910 (LWP 88958)): >> #0 0x03ff8ca90cd4 in __lll_lock_wait () at /lib64/libpthread.so.0 >> #1

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

2016-03-19 Thread Paolo Bonzini
On 16/03/2016 14:38, Christian Borntraeger wrote: > > If you just remove the calls to virtio_queue_host_notifier_read, here > > and in virtio_queue_aio_set_host_notifier_fd_handler, does it work > > (keeping patches 2-4 in)? > > With these changes and patch 2-4 it does no longer locks up. > I

[Qemu-devel] [PATCH V7 1/2] net/filter-mirror: implement filter-redirector

2016-03-19 Thread Zhang Chen
Filter-redirector is a netfilter plugin. It gives qemu the ability to redirect net packet. redirector can redirect filter's net packet to outdev. and redirect indev's packet to filter. filter + redirector | +--+

[Qemu-devel] [PULL 15/29] block: Add bdrv_next_monitor_owned()

2016-03-19 Thread Kevin Wolf
From: Max Reitz Add a function for iterating over all monitor-owned BlockDriverStates so the generic block layer can do so. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- blockdev.c | 7 +++

[Qemu-devel] [PATCH v4 01/17] monitor: Use BB list for BB name completion

2016-03-19 Thread Max Reitz
Signed-off-by: Max Reitz --- monitor.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 894f862..4c02f0f 100644 --- a/monitor.c +++ b/monitor.c @@ -42,6 +42,7 @@ #include "ui/console.h" #include "ui/input.h" #include

[Qemu-devel] [PULL 08/40] ivshmem-test: Clean up wait for devices to become operational

2016-03-19 Thread Markus Armbruster
test_ivshmem_server() waits until the first byte in BAR 2 contains the 0x42 we put into shared memory. Works because the byte reads zero until the device maps the shared memory gotten from the server. Check the IVPosition register instead: it's initially -1, and becomes non-negative right when

Re: [Qemu-devel] [ Patch 0/2] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest

2016-03-19 Thread Wei Xu
On 2016年03月17日 23:44, Michael S. Tsirkin wrote: On Thu, Mar 17, 2016 at 11:21:28PM +0800, Wei Xu wrote: On 2016年03月17日 14:47, Jason Wang wrote: On 03/15/2016 05:17 PM,w...@redhat.com wrote: From: Wei Xu Fixed issues based on rfc patch v2: 1. Removed big param list, replace

Re: [Qemu-devel] [PATCH v4 25/28] migration: define 'tls-creds' and 'tls-hostname' migration parameters

2016-03-19 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > Define two new migration parameters to be used with TLS encryption. > The 'tls-creds' parameter provides the ID of an instance of the > 'tls-creds' object type, or rather a subclass such as 'tls-creds-x509'. > Providing these credentials will

Re: [Qemu-devel] [PATCH v4 09/11] block: m25p80: Implemented FSR register

2016-03-19 Thread Peter Crosthwaite
On Mon, Feb 22, 2016 at 12:03 AM, wrote: > From: Marcin Krzeminski > > Implements FSR register, it is used for busy waits. > > Signed-off-by: Marcin Krzeminski > --- > hw/block/m25p80.c | 11 +++ >

[Qemu-devel] [PATCH v5 26/28] migration: add support for encrypting data with TLS

2016-03-19 Thread Daniel P. Berrange
This extends the migration_set_incoming_channel and migration_set_outgoing_channel methods so that they will automatically wrap the QIOChannel in a QIOChannelTLS instance if TLS credentials are configured in the migration parameters. This allows TLS to work for tcp, unix, fd and exec migration

Re: [Qemu-devel] [Qemu-block] [PATCH 00/16] AioContext fine-grained locking, part 1 of 3, including bdrv_drain rewrite

2016-03-19 Thread Stefan Hajnoczi
On Thu, Mar 17, 2016 at 02:48:00PM +0100, Paolo Bonzini wrote: > > > On 17/03/2016 14:44, Stefan Hajnoczi wrote: > > > For example, each part will probably have an uncontroversial and > > > generally useful prefix---for example patches 1-4 in this case, or the > > > change to a single linux-aio

Re: [Qemu-devel] [PULL 00/15] QAPI patches for 2016-03-18

2016-03-19 Thread Peter Maydell
On 18 March 2016 at 10:04, Markus Armbruster wrote: > The following changes since commit 6741d38ad0f2405a6e999ebc9550801b01aca479: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2016-03-17 15:59:42 +) > > are available in the git

[Qemu-devel] [PULL 32/40] ivshmem: Simplify memory regions for BAR 2 (shared memory)

2016-03-19 Thread Markus Armbruster
ivshmem_realize() puts the shared memory region in a container region. Used to be necessary to permit delayed mapping of the shared memory. However, we recently moved to synchronous mapping, in "ivshmem: Receive shared memory synchronously in realize()" and the commit following it. The container

[Qemu-devel] [PULL 11/21] i.MX: Add missing descriptions in devices.

2016-03-19 Thread Peter Maydell
From: Jean-Christophe Dubois Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois Message-id: f1f565eb9dffdeb582feb1b15ba9e8b0afcf5468.1456868959.git@tribudubois.net Signed-off-by: Peter Maydell

[Qemu-devel] [PULL 17/29] block: Rewrite bdrv_next()

2016-03-19 Thread Kevin Wolf
From: Max Reitz Instead of using the bdrv_states list, iterate over all the BlockDriverStates attached to BlockBackends, and over all the monitor-owned BDSs afterwards (except for those attached to a BB). Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v3] net: Allocating Large sized arrays to heap

2016-03-19 Thread Stefan Hajnoczi
On Tue, Mar 15, 2016 at 11:55:13PM +0530, Pooja Dhannawat wrote: > nc_sendv_compat has a huge stack usage of 69680 bytes approx. > Moving large arrays to heap to reduce stack usage. > > Signed-off-by: Pooja Dhannawat > --- > net/net.c | 14 ++ > 1 file

[Qemu-devel] [PATCH v4 14/17] block: Add blk_next_root_bs()

2016-03-19 Thread Max Reitz
This function iterates over all BDSs attached to a BB. We are going to need it when rewriting bdrv_next() so it no longer uses bdrv_states. Signed-off-by: Max Reitz --- block/block-backend.c | 24 include/sysemu/block-backend.h | 1 + 2

[Qemu-devel] [PATCH V7 2/2] tests/test-filter-redirector: Add unit test for filter-redirector

2016-03-19 Thread Zhang Chen
In this unit test,we will test the filter redirector function. Case 1, tx traffic flow: qemu side | test side | +-+| +---+ | backend <---+ sock0 | +++| +---+ | | +v+

Re: [Qemu-devel] [ Patch 2/2] virtio-net rsc: support coalescing ipv6 tcp traffic

2016-03-19 Thread Wei Xu
On 2016年03月17日 16:50, Jason Wang wrote: On 03/15/2016 05:17 PM, w...@redhat.com wrote: From: Wei Xu Most things like ipv4 except there is a significant difference between ipv4 and ipv6, the fragment lenght in ipv4 header includes itself, while it's not included for ipv6,

Re: [Qemu-devel] [PATCH v3 0/2] spapr: QMP: add query-hotpluggable-cpus

2016-03-19 Thread Christian Borntraeger
On 03/15/2016 02:24 PM, Igor Mammedov wrote: > Changes since v2: > - rebase on top of hte lates spapr cpu hotpug series > - add 'vcpus-count' field, pkre...@redhat.com > - s/CpuInstanceProps/CpuInstanceProperties/ > - use '#optional' marker > - make "props" as always present even if it's

Re: [Qemu-devel] [PATCH] acpi: Add missing GCC_FMT_ATTR

2016-03-19 Thread Igor Mammedov
On Wed, 16 Mar 2016 20:43:37 +0100 Stefan Weil wrote: > This fixes a compiler warning when compiling with -Wextra. > > Signed-off-by: Stefan Weil Reviewed-by: Igor Mammedov > --- > include/hw/acpi/aml-build.h | 3 ++- > 1 file

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

2016-03-19 Thread Christian Borntraeger
Good (or bad?) news is the assert also triggers on F23, it just seems to take longer. trace 1 (compiled on F20) Thread 5 (Thread 0x3ff84b7f910 (LWP 33030)): #0 0x03ff86a817b8 in ppoll () at /lib64/libc.so.6 #1 0x102c712e in qemu_poll_ns (fds=0x3ff80001e70, nfds=3, timeout=-1) at

Re: [Qemu-devel] [PATCH] vfio/pci: replace 1 with PCI_CAP_LIST_NEXT to make code self-explain

2016-03-19 Thread Michael Tokarev
11.02.2016 03:54, Wei Yang wrote: > Use the macro PCI_CAP_LIST_NEXT instead of 1, so that the code would be > more self-explain. > > This patch makes this change and also fixs one typo in comment. > > for (tmp = pdev->config[PCI_CAPABILITY_LIST]; tmp; > - tmp = pdev->config[tmp +

Re: [Qemu-devel] [PATCH v12 0/9] PTimer fixes/features and ARM MPTimer conversion

2016-03-19 Thread Peter Maydell
On 30 January 2016 at 16:43, Dmitry Osipenko wrote: > Changelog for ARM MPTimer QEMUTimer to ptimer conversion: So, where are we with this series? It looked from the mailing list threads as if there were still a few things Peter C hadn't got closure on, but we're rapidly

[Qemu-devel] [PULL 07/21] i.MX: Rename CCM NOCLK to CLK_NONE for naming consistency.

2016-03-19 Thread Peter Maydell
From: Jean-Christophe Dubois This way all CCM clock defines/enums are named CLK_XXX Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois Message-id:

[Qemu-devel] [PULL v1 10/13] crypto: refactor code for dealing with AES cipher

2016-03-19 Thread Daniel P. Berrange
The built-in and nettle cipher backends for AES maintain two separate AES contexts, one for encryption and one for decryption. This is going to be inconvenient for the future code dealing with XTS, so wrap them up in a single struct so there is just one pointer to pass around for both encryption

Re: [Qemu-devel] [PATCH 5/9] hw/arm: QOM'ify pxa2xx_pic.c

2016-03-19 Thread Peter Maydell
On 7 March 2016 at 07:05, xiaoqiang zhao wrote: > Remove the empty 'pxa2xx_pic_initfn' and it's > setup code in the 'pxa2xx_pic_class_init' > > Signed-off-by: xiaoqiang zhao Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v2 03/10] ppc: Add a bunch of hypervisor SPRs to Book3s

2016-03-19 Thread Thomas Huth
On 16.03.2016 14:13, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > We don't give them a KVM reg number to most of the registers yet as no > current KVM version supports HV mode. For DAWR and DAWRX, the KVM reg > number is needed since this register can be

Re: [Qemu-devel] [PATCH v5 7/7] block: drop support for using qcow[2] encryption with system emulators

2016-03-19 Thread Daniel P. Berrange
On Fri, Mar 18, 2016 at 01:11:27PM +0100, Kevin Wolf wrote: > Am 17.03.2016 um 18:51 hat Daniel P. Berrange geschrieben: > > For a couple of releases we have been warning > > > > Encrypted images are deprecated > > Support for them will be removed in a future release. > > You can use

[Qemu-devel] [PULL v3 01/13] crypto: add cryptographic random byte source

2016-03-19 Thread Daniel P. Berrange
There are three backend impls provided. The preferred is gnutls, which is backed by nettle in modern distros. The gcrypt impl is provided for cases where QEMU build against gnutls is disabled, but crypto is still desired. No nettle impl is provided, since it is non-trivial to use the nettle APIs

[Qemu-devel] [PATCH v2 02/10] ppc: Add macros to register hypervisor mode SPRs

2016-03-19 Thread Cédric Le Goater
From: Benjamin Herrenschmidt The current set of spr_register_* macros only take the user and supervisor function pointers. To make the transition easy, we don't change that but we add "_hv" variants that can be used to register all 3 sets. To simplify the transition,

[Qemu-devel] [PULL 24/29] block: Use blk_co_pwritev() in blk_write_zeroes()

2016-03-19 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/block-backend.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/block/block-backend.c b/block/block-backend.c index 475d27a..886c2f4 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@

[Qemu-devel] [PATCH v4 04/17] block: Use blk_{commit, flush}_all() consistently

2016-03-19 Thread Max Reitz
Replace bdrv_commmit_all() and bdrv_flush_all() by their BlockBackend equivalents. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- blockdev.c | 2 +- cpus.c | 5 +++-- qemu-char.c | 3 ++- 3 files changed, 6 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PULL v2 03/13] crypto: add support for generating initialization vectors

2016-03-19 Thread Daniel P. Berrange
There are a number of different algorithms that can be used to generate initialization vectors for disk encryption. This introduces a simple internal QCryptoBlockIV object to provide a consistent internal API to the different algorithms. The initially implemented algorithms are 'plain', 'plain64'

Re: [Qemu-devel] [PATCH 0/2] Emit QUORUM_REPORT_BAD for reads in fifo mode

2016-03-19 Thread Max Reitz
On 15.03.2016 10:41, Alberto Garcia wrote: > This is a follow-up to the "Separate QUORUM_REPORT_BAD events" series: > >https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg02402.html > > If there's an I/O error in one of Quorum children then QEMU should > emit QUORUM_REPORT_BAD. However

[Qemu-devel] [PATCH 1/1] backend: multi-client-socket

2016-03-19 Thread Baptiste Reynal
This patch introduces a new socket for QEMU, called multi-client-socket. This socket allows multiple QEMU instances to communicate by sharing messages and file descriptors. A socket can be instantiated with the following parameters: -object multi-socket-backend,id=,path=,listen= If listen is

[Qemu-devel] [PATCH v2 09/10] ppc: Add dummy CIABR SPR

2016-03-19 Thread Cédric Le Goater
From: Benjamin Herrenschmidt We should implement HW breakpoint/watchpoint, qemu supports them... Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Thomas Huth Reviewed-by: David Gibson ---

Re: [Qemu-devel] [PATCH v2 02/16] block: move restarting of throttled reqs to block/throttle-groups.c

2016-03-19 Thread Fam Zheng
On Wed, 03/16 15:16, Paolo Bonzini wrote: > We want to remove throttled_reqs from block/io.c. This is the easy > part---hide the handling of throttled_reqs during disable/enable of > throttling within throttle-groups.c. > > Signed-off-by: Paolo Bonzini Reviewed-by: Fam

[Qemu-devel] [PATCH for-2.6 04/14] pc-bios/s390-ccw: qemuize types

2016-03-19 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Turn [the most of] existing declarations from struct type_name { ... }; into struct TypeName { ... }; typedef struct TypeName TypeName; and make use of them. Also switch u{8,16,32,64} to uint{8,16,32,64}_t. Acked-by:

[Qemu-devel] [PULL 18/29] block: Use bdrv_next() instead of bdrv_states

2016-03-19 Thread Kevin Wolf
From: Max Reitz There is no point in manually iterating through the bdrv_states list when there is bdrv_next(). Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block.c | 12 ++--

[Qemu-devel] GSoC Application 2016 (Postcopy Migration: Recovery from a broken network connection)

2016-03-19 Thread Ashi
Hi all, I have completed my GSoC Application for the project idea regarding postcopy migration. I would like to get views from the qemu community before I finally post it. Proposal Timeline: The progress will be tracked through weekly email updates and blog posts documenting the work. ->

[Qemu-devel] [PATCH 10/20] block: Move enable_write_cache to BB level

2016-03-19 Thread Kevin Wolf
Whether a write cache is used or not is a decision that concerns the user (e.g. the guest device) rather than the backend. It was already logically part of the BB level as bdrv_move_feature_fields() always kept it on top of the BDS tree; with this patch, the core of it (the actual flag and the

[Qemu-devel] [PATCH v2 01/16] block: make bdrv_start_throttled_reqs return void

2016-03-19 Thread Paolo Bonzini
The return value is unused and I am not sure why it would be useful. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- block/io.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/block/io.c b/block/io.c index

Re: [Qemu-devel] [PATCH v2] Sort the fw_cfg file list

2016-03-19 Thread Corey Minyard
On 03/15/2016 12:01 PM, Michael S. Tsirkin wrote: On Tue, Mar 15, 2016 at 11:36:39AM -0500, Corey Minyard wrote: I've hit a bit of a snag here. For 0.11 and before, PCI option ROMs were loaded via fw_cfg, not in the PCI ROM BAR. This causes two issues: * The order depends on the device

[Qemu-devel] [PULL 03/40] ivshmem-server: Don't overload POSIX shmem and file name

2016-03-19 Thread Markus Armbruster
Option -m NAME is interpreted as directory name if we can statfs() it and its on hugetlbfs. Else it's interpreted as POSIX shared memory object name. This is nuts. Always interpret -m as directory. Create new -M for POSIX shared memory. Last of -m or -M wins. Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PULL v1 00/13] Merge crypto code for LUKS encryption

2016-03-19 Thread Peter Maydell
On 17 March 2016 at 13:51, Peter Maydell wrote: > On 17 March 2016 at 13:42, Daniel P. Berrange wrote: >> The following changes since commit 8c4575472494a5dfedfe05e7b58ca9ce3872ad56: >> >> Merge remote-tracking branch

[Qemu-devel] [PULL 19/40] ivshmem: Clean up MSI-X conditions

2016-03-19 Thread Markus Armbruster
There are three predicates related to MSI-X: * ivshmem_has_feature(s, IVSHMEM_MSI) is true unless the non-MSI-X variant of the device is selected with msi=off. * msix_present() is true when the device has the PCI capability MSI-X. It's initially false, and becomes true during successful

Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/

2016-03-19 Thread Paolo Bonzini
On 17/03/2016 14:35, Michael S. Tsirkin wrote: > > We meant just two partitions of the namespace. "opt/" and non-"opt/". > > The latter belongs to QEMU, the former belongs to everything else, and > > the subdivision of everything else doesn't belong into QEMU. OVMF is > > part of everything

[Qemu-devel] [PATCH 05/20] qemu-img: Call blk_set_enable_write_cache() explicitly

2016-03-19 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- qemu-img.c | 79 ++ 1 file changed, 48 insertions(+), 31 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 839e05b..96b51d4 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -245,7 +245,7

[Qemu-devel] [PATCH v6 16/16] qapi: Consolidate object visitors

2016-03-19 Thread Eric Blake
Rather than having two separate visitor callbacks with items already broken out, pass the actual QAPISchemaObjectType object to the visitor. This lets the visitor access things like type.is_implicit() without needing another parameter, resolving a TODO from previous patches. For convenience and

Re: [Qemu-devel] [PATCH v2 0/2] usb, xen: add pvUSB backend

2016-03-19 Thread Juergen Gross
On 18/03/16 13:52, Gerd Hoffmann wrote: > On Do, 2016-03-10 at 16:19 +0100, Juergen Gross wrote: >> This series adds a Xen pvUSB backend driver to qemu. USB devices >> connected to the host can be passed through to a Xen guest. The >> devices are specified via Xenstore. Access to the devices is

[Qemu-devel] [PULL v3 11/13] crypto: wire up XTS mode for cipher APIs

2016-03-19 Thread Daniel P. Berrange
Introduce 'XTS' as a permitted mode for the cipher APIs. With XTS the key provided must be twice the size of the key normally required for any given algorithm. This is because the key will be split into two pieces for use in XTS mode. Reviewed-by: Eric Blake Signed-off-by:

Re: [Qemu-devel] [PATCH 00/16] AioContext fine-grained locking, part 1 of 3, including bdrv_drain rewrite

2016-03-19 Thread Paolo Bonzini
On 16/03/2016 19:18, Stefan Hajnoczi wrote: > Looks good overall. I'm a little nervous about merging it for QEMU 2.6 > but the block job, NBD, and data plane tests should give it a good > workout. Apart from QEMU nearing hard freeze, I totally understand not wanting to commit to merging part 1

[Qemu-devel] [PULL v3 03/13] crypto: add support for generating initialization vectors

2016-03-19 Thread Daniel P. Berrange
There are a number of different algorithms that can be used to generate initialization vectors for disk encryption. This introduces a simple internal QCryptoBlockIV object to provide a consistent internal API to the different algorithms. The initially implemented algorithms are 'plain', 'plain64'

Re: [Qemu-devel] [PATCH 06/17] ppc: Create cpu_ppc_set_papr() helper

2016-03-19 Thread David Gibson
On Thu, Mar 17, 2016 at 01:33:31PM +0100, Cédric Le Goater wrote: > On 03/17/2016 03:34 AM, David Gibson wrote: > > On Mon, Mar 14, 2016 at 05:56:29PM +0100, Cédric Le Goater wrote: > >> From: Benjamin Herrenschmidt > >> > >> And move the code adjusting the MSR mask and

Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/

2016-03-19 Thread Michael S. Tsirkin
On Thu, Mar 17, 2016 at 02:55:52PM +0100, Paolo Bonzini wrote: > > > On 17/03/2016 14:49, Michael S. Tsirkin wrote: > >> On 17/03/2016 14:13, Michael S. Tsirkin wrote: > >>> > >>> QEMU command line: > >>> A. -fw-cfg RFQDN/PATH prepends usr/. So users will not get conflicts > >>> with QEMU

[Qemu-devel] [PULL v3 07/13] crypto: add support for the serpent cipher algorithm

2016-03-19 Thread Daniel P. Berrange
New cipher algorithms 'serpent-128', 'serpent-192' and 'serpent-256' are defined for the Serpent algorithm. The nettle and gcrypt cipher backends are updated to support the new cipher and a test vector added to the cipher test suite. The new algorithm is enabled in the LUKS block encryption

Re: [Qemu-devel] [PATCH 1/9] hw/arm: QOM'ify armv7m.c

2016-03-19 Thread Peter Maydell
On 7 March 2016 at 07:05, xiaoqiang zhao wrote: > Drop the use of old SysBus init function and use instance_init > > Signed-off-by: xiaoqiang zhao > --- > hw/arm/armv7m.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) Reviewed-by:

Re: [Qemu-devel] Our use of #include is undisciplined, and what to do about it

2016-03-19 Thread Paolo Bonzini
On 17/03/2016 17:29, Dr. David Alan Gilbert wrote: > OK, so I see TraceEvent has a TraceEventID field; so yes that works easily; > it turns out to be a little more expensive though since what was a: > >trace_events_dstate[id] > > is now >trace_events_dstate[te->id] That however makes

[Qemu-devel] [PATCH 3/3] hw/net/spapr_llan: Enable the RX buffer pools by default for new machines

2016-03-19 Thread Thomas Huth
RX buffer pools are now enabled by default for new machine types. For older machine types, they are still disabled to avoid breaking migration. Signed-off-by: Thomas Huth --- hw/net/spapr_llan.c | 2 +- hw/ppc/spapr.c | 7 ++- 2 files changed, 7 insertions(+), 2

Re: [Qemu-devel] basic block tracing question

2016-03-19 Thread Peter Maydell
On 16 March 2016 at 20:28, Tim Newsham wrote: > Hi, I would like to create an accurate trace of basic blocks that get > executed. I'm interested in a trace of what a CPU would execute, and not > for the purposes of studying qemu itself. > > I'm currently emitting trace

[Qemu-devel] [PULL 38/40] ivshmem: Drop ivshmem property x-memdev

2016-03-19 Thread Markus Armbruster
Use ivshmem-plain instead. Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <1458066895-20632-39-git-send-email-arm...@redhat.com> --- hw/misc/ivshmem.c | 23 +++ 1 file changed, 3 insertions(+), 20

[Qemu-devel] [PULL 01/29] block: Fix qemu_root_bds_opts.head initialisation

2016-03-19 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- blockdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 322ca03..e7b8676 100644 --- a/blockdev.c +++ b/blockdev.c @@ -4221,7 +4221,7 @@ QemuOptsList

[Qemu-devel] [PATCH v6 13/16] qapi: Make BlockdevOptions doc example closer to reality

2016-03-19 Thread Eric Blake
Although we don't want to repeat the entire BlockdevOptions QMP command in the example, it helps if we aren't needlessly diverging (the initial example was written before we had committed the actual QMP interface). Use names that match what is found in qapi/block-core.json, such as '*read-only'

Re: [Qemu-devel] [PATCH 16/17] ppc: Add dummy CIABR SPR

2016-03-19 Thread David Gibson
On Wed, Mar 16, 2016 at 07:24:01AM +0100, Thomas Huth wrote: > On 16.03.2016 02:14, David Gibson wrote: > > On Mon, Mar 14, 2016 at 05:56:39PM +0100, Cédric Le Goater wrote: > >> From: Benjamin Herrenschmidt > >> > >> We should implement HW breakpoint/watchpoint, qemu

[Qemu-devel] [PATCH v6 04/16] qapi: Adjust names of implicit types

2016-03-19 Thread Eric Blake
The original choice of ':obj-' as the prefix for implicit types made it obvious that we weren't going to clash with any user-defined names, which cannot contain ':'. But now we want to create structs for implicit types, to get rid of special cases in the generators, and our use of ':' in implicit

Re: [Qemu-devel] [PATCH v4 08/28] migration: introduce a new QEMUFile impl based on QIOChannel

2016-03-19 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > Introduce a new QEMUFile implementation that is based on > the QIOChannel objects. This impl is different from existing > impls in that there is no file descriptor that can be made > available, as some channels may be based on higher level >

Re: [Qemu-devel] [PATCH 07/16] block: change drain to look only at one child at a time

2016-03-19 Thread Paolo Bonzini
On 16/03/2016 17:39, Stefan Hajnoczi wrote: > The tree looks like this: > > [NBD export] > / > v > [guest] temporary qcow2 >\/ > v v > disk > > Block backend access is in square brackets. Nodes without square > brackets are BDS nodes. > >

[Qemu-devel] Ubuntu 14.04 LTS Arm for Raspberry - QEMU Support

2016-03-19 Thread Vincenzo Calabrò
Hi Andrew, I got your contact from Peter Maydell on the IRC channel #qemu. I would like to submit the following bug affecting the Raspberry 2 platform under the specified os. Let me explain what I'm trying to do and where I'm failing: 1. I'm using the "official" arm ubuntu 14.04 (

[Qemu-devel] [PULL v2 04/13] crypto: add support for anti-forensic split algorithm

2016-03-19 Thread Daniel P. Berrange
The LUKS format specifies an anti-forensic split algorithm which is used to artificially expand the size of the key material on disk. This is an implementation of that algorithm. Reviewed-by: Fam Zheng Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PULL 0/1] Error reporting patches for 2016-03-16

2016-03-19 Thread Peter Maydell
On 16 March 2016 at 10:04, Markus Armbruster wrote: > The following changes since commit a6cdb77f816961f929d7934643febd2852230135: > > Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into > staging (2016-03-15 17:09:52 +) > > are available in the git

[Qemu-devel] [PULL 10/29] blockdev: Add list of all BlockBackends

2016-03-19 Thread Kevin Wolf
From: Max Reitz While monitor_block_backends contains nearly all BBs, we sometimes really need all BBs. To this end, this patch adds the block_backend list. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/block-backend.c |

[Qemu-devel] [PATCH v2 07/16] block: change drain to look only at one child at a time

2016-03-19 Thread Paolo Bonzini
bdrv_requests_pending is checking children to also wait until internal requests (such as metadata writes) have completed. However, checking children is in general overkill. Children requests can be of two kinds: - requests caused by an operation on bs, e.g. a bdrv_aio_write to bs causing a

Re: [Qemu-devel] [PATCH] target-arm: Fix descriptor address masking in ARM address translation

2016-03-19 Thread Peter Maydell
On 13 March 2016 at 18:28, Sergey Sorokin wrote: > 12.03.2016, 03:18, "Peter Maydell" : >>(I agree we have a bug here, I'm just trying to work out when it >>can trigger; if it's only possible for S2 page tables then it's >>not a visible bug yet

Re: [Qemu-devel] [PATCH 5/6] hw/char: QOM'ify sclpconsole-lm.c

2016-03-19 Thread Cornelia Huck
On Thu, 17 Mar 2016 17:20:29 +0800 xiaoqiang zhao wrote: > Drop the DO_UPCAST macro > > Signed-off-by: xiaoqiang zhao > --- > hw/char/sclpconsole-lm.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git

Re: [Qemu-devel] [Qemu-block] [PATCH 00/16] AioContext fine-grained locking, part 1 of 3, including bdrv_drain rewrite

2016-03-19 Thread Stefan Hajnoczi
On Wed, Mar 16, 2016 at 11:29:02PM +0100, Paolo Bonzini wrote: > On 16/03/2016 19:18, Stefan Hajnoczi wrote: > > Looks good overall. I'm a little nervous about merging it for QEMU 2.6 > > but the block job, NBD, and data plane tests should give it a good > > workout. > > Apart from QEMU nearing

Re: [Qemu-devel] [PATCH v5 00/14] easier unboxed visits/qapi implicit types

2016-03-19 Thread Eric Blake
On 03/16/2016 09:24 AM, Markus Armbruster wrote: > I think the additional changes I'd like to see are small enough to not > require a full respin. I took the liberty to work them in, and pushed > the result to my qapi-not-next branch. Let me know whether you like > them. The code changes looked

[Qemu-devel] [PATCH v5 00/28] Convert migration to QIOChannel & support TLS

2016-03-19 Thread Daniel P. Berrange
This is an update of patches that were previously posted FYI: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00829.html v1: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg01914.html v2: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg03509.html v3:

[Qemu-devel] [PATCH v5 21/28] migration: delete QEMUFile sockets implementation

2016-03-19 Thread Daniel P. Berrange
Now that the tcp, unix and fd migration backends have converted to use the QIOChannel based QEMUFile, there is no user remaining for the sockets based QEMUFile impl and it can be deleted. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH v4 05/11] block: m25p80: 4byte address mode

2016-03-19 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
> -Original Message- > From: EXT Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Thursday, March 17, 2016 6:27 PM > To: Krzeminski, Marcin (Nokia - PL/Wroclaw) > > Cc: qemu-devel@nongnu.org Developers ; > Cédric Le Goater

[Qemu-devel] [PULL v1 05/13] crypto: skip testing of unsupported cipher algorithms

2016-03-19 Thread Daniel P. Berrange
We don't guarantee that all crypto backends will support all cipher algorithms, so we should skip tests unless the crypto backend indicates support. Reviewed-by: Fam Zheng Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange ---

[Qemu-devel] [PULL 0/2] Block patches for 2.6

2016-03-19 Thread Jeff Cody
The following changes since commit 0ebc03bc065329eaefb6493f5fa7df08df528f2a: util/base64.c: Clean includes (2016-03-16 12:48:11 +) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git tags/block-pull-request for you to fetch changes up to

Re: [Qemu-devel] [PATCH] block/sheepdog: add error handling to sd_snapshot_delete()

2016-03-19 Thread Jeff Cody
On Fri, Mar 18, 2016 at 05:54:38PM +0900, Takashi Menjo wrote: > Errors have been ignored in some code paths in sd_snapshot_delete(). > This patch adds error handling. > > Signed-off-by: Takashi Menjo Thank you for the patch! > --- > block/sheepdog.c | 3 +++ > 1

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

2016-03-19 Thread Paolo Bonzini
On 17/03/2016 13:39, Christian Borntraeger wrote: > As an interesting side note, I updated my system from F20 to F23 some days ago > (after the initial report). While To Bo is still on a F20 system. I was not > able > to reproduce the original crash on f23. but going back to F20 made this >

[Qemu-devel] commit 084a85e breaks build

2016-03-19 Thread Gabriel L. Somlo
Hi Daniel, I get the error below when I try to build QEMU, and bisect claims it started with commit 084a85e (crypto: add support for the cast5-128 cipher algorithm). Sorry if this is already a known issue. Let me know if there's anything you'd like me to test. My command line is:

[Qemu-devel] [PULL v2 02/13] crypto: add support for PBKDF2 algorithm

2016-03-19 Thread Daniel P. Berrange
The LUKS data format includes use of PBKDF2 (Password-Based Key Derivation Function). The Nettle library can provide an implementation of this, but we don't want code directly depending on a specific crypto library backend. Introduce a new include/crypto/pbkdf.h header which defines a QEMU API for

Re: [Qemu-devel] [PATCH 0/5] block: API changes for 2.6

2016-03-19 Thread Kevin Wolf
Am 14.03.2016 um 16:44 hat Kevin Wolf geschrieben: > This series contains those part of my current work that I want to be in > the 2.6 release because they change the semantics of some QMP > interfaces. > > This is especially true for the WCE changes, which concern things that > weren't even

Re: [Qemu-devel] [PATCH v5 10/28] migration: add reporting of errors for outgoing migration

2016-03-19 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > Currently if an application initiates an outgoing migration, > it may or may not, get an error reported back on failure. If > the error occurs synchronously to the 'migrate' command > execution, the client app will see the error message. This >

[Qemu-devel] [PATCH for-2.6 10/14] pc-bios/s390-ccw: add virtio-scsi implementation

2016-03-19 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Add virtio-scsi.[ch] with primary implementation of virtio-scsi. Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/virtio-scsi.c | 342

Re: [Qemu-devel] [PATCH] remove comment for nonexistent structure member

2016-03-19 Thread Michael Tokarev
18 Feb 2016 11:18, Cao jin wrote > - * @id: unique identification string in memdev namespace Applied to -trivial, thanks!

Re: [Qemu-devel] [PATCH] hw/usb/dev-mtp: Guard inotify usage with CONFIG_INOTIFY1

2016-03-19 Thread Gerd Hoffmann
On Di, 2016-02-23 at 15:44 +, Matthew Fortune wrote: > inotify_init1 usage was guarded by a check for linux but does not > exist on older distributions like CentOS 5 resulting in build > failures. Added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v3 1/2] QMP: add query-hotpluggable-cpus

2016-03-19 Thread Eduardo Habkost
On Tue, Mar 15, 2016 at 02:24:07PM +0100, Igor Mammedov wrote: [...] > diff --git a/stubs/qmp_query_hotpluggable_cpus.c > b/stubs/qmp_query_hotpluggable_cpus.c > new file mode 100644 > index 000..21a75a3 > --- /dev/null > +++ b/stubs/qmp_query_hotpluggable_cpus.c > @@ -0,0 +1,9 @@ > +#include

[Qemu-devel] [PULL 23/29] block: Pull up blk_read_unthrottled() implementation

2016-03-19 Thread Kevin Wolf
Use blk_read(), so that it goes through blk_co_preadv() like all read requests from the BB to the BDS. Signed-off-by: Kevin Wolf --- block/block-backend.c | 12 ++-- block/io.c| 14 -- include/block/block.h | 2 -- 3 files changed, 10

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-19 Thread Wen Congyang
On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 03/17/2016 05:10 PM, Alberto Garcia wrote: >>> On Thu 17 Mar 2016 02:22:40 AM CET, Wen Congyang >>> wrote: @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState {

[Qemu-devel] [PATCH v2 04/16] block: plug whole tree at once, introduce bdrv_io_unplugged_begin/end

2016-03-19 Thread Paolo Bonzini
Extract the handling of io_plug "depth" from linux-aio.c and let the main bdrv_drain loop do nothing but wait on I/O. Like the two newly introduced functions, bdrv_io_plug and bdrv_io_unplug now operate on all children. The visit order is now symmetrical between plug and unplug, making it

Re: [Qemu-devel] [PATCH v3 33/40] ivshmem: Inline check_shm_size() into its only caller

2016-03-19 Thread Marc-André Lureau
Hi On Tue, Mar 15, 2016 at 7:34 PM, Markus Armbruster wrote: > Improve the error messages while there. > > Signed-off-by: Markus Armbruster I'd prefer we keep a seperate function to handle the shm checks, but I don't mind much so: Reviewed-by: Marc-André

[Qemu-devel] [PATCH 3/6] hw/char: QOM'ify lm32_juart.c

2016-03-19 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/char/lm32_juart.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/char/lm32_juart.c b/hw/char/lm32_juart.c index 5bf8acf..cd8d0ee 100644 ---

[Qemu-devel] [PULL 02/15] qapi: Fix command with named empty argument type

2016-03-19 Thread Markus Armbruster
From: Eric Blake The generator special-cased { 'command':'foo', 'data': {} } to avoid emitting a visitor variable, but failed to see that { 'struct':'NamedEmptyType, 'data': {} } { 'command':'foo', 'data':'NamedEmptyType' } needs the same treatment. There, the

[Qemu-devel] [PATCH v5 20/28] migration: delete QEMUSizedBuffer struct

2016-03-19 Thread Daniel P. Berrange
Now that we don't have have a buffer based QemuFile implementation, the QEMUSizedBuffer code is also unused and can be deleted. A simpler buffer class also exists in util/buffer.c which other code can used as needed. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel

  1   2   3   4   5   6   7   8   >