Re: [Qemu-devel] [PATCH v2] hw/ptimer: Don't wrap around counter for expired timer that uses tick handler

2016-07-07 Thread Dmitry Osipenko
On 07.07.2016 13:53, Peter Maydell wrote: > On 4 July 2016 at 10:55, Peter Maydell wrote: >> On 1 July 2016 at 18:49, Dmitry Osipenko wrote: >>> On 01.07.2016 19:36, Peter Maydell wrote: On 30 June 2016 at 20:01, Dmitry Osipenko wrote: > On 30.06.2016 18:02, Peter Maydell wrote: >>

[Qemu-devel] [PATCH v3 09/11] block: Accept node-name for drive-mirror

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts drive-mirror to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command returns the G

Re: [Qemu-devel] [PATCH] block/iscsi: precache the allocation status of a target

2016-07-07 Thread Paolo Bonzini
On 07/07/2016 13:40, Peter Lieven wrote: >>> >> This can take a long time and the disks may not even be ever used. I >> don't think it's a good idea. > > Sure, the target might stay unused, but why do you suspect its slow? I don't suspect it's slow; it's just that it can be O(size of disk), an

[Qemu-devel] [PATCH v3 04/11] block: Accept node-name for blockdev-mirror

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-mirror to accept a node-name without lifting the restriction that we're operating at a root node. Signed-off-by: Kevin Wolf --- blockdev.c | 10

[Qemu-devel] [PATCH v3 08/11] block: Accept node-name for drive-backup

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts drive-backup and the corresponding transaction action to accept a node-name without lifting the restriction that we're operating at a root node. In case of an inval

Re: [Qemu-devel] [SeaBIOS] [PATCH v3] fw/msr_feature_control: add support to set MSR_IA32_FEATURE_CONTROL

2016-07-07 Thread Paolo Bonzini
> I've worried that if I only *call* these interfaces to set the MSR, then > the next (independent) use of the same interfaces would clear the MSR > through the INIT-SIPI-SIPI. That would have forced me to modify the > protocol / PPI implementations so that any use of them would reprogram > the MS

[Qemu-devel] [PATCH v3 05/11] block: Accept node-name for blockdev-snapshot-delete-internal-sync

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-snapshot-delete-internal-sync to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name,

[Qemu-devel] [PATCH v3 06/11] block: Accept node-name for blockdev-snapshot-internal-sync

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-snapshot-internal-sync to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the co

[Qemu-devel] [PATCH v3 07/11] block: Accept node-name for change-backing-file

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts change-backing-file to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command return

[Qemu-devel] [PATCH v3 03/11] block: Accept node-name for blockdev-backup

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-backup and the corresponding transaction action to accept a node-name without lifting the restriction that we're operating at a root node. In case of an in

[Qemu-devel] [PATCH v3 01/11] block: Accept node-name for block-stream

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts block-stream to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command returns the G

[Qemu-devel] [PATCH v3 02/11] block: Accept node-name for block-commit

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts block-commit to accept a node-name without lifting the restriction that we're operating at a root node. As libvirt makes use of the DeviceNotFound error class, we m

[Qemu-devel] [PATCH v3 00/11] block: Accept node-name in all node level QMP commands

2016-07-07 Thread Kevin Wolf
As stated in the RFC I sent two weeks ago: * Node level commands: We need to complete the conversion that makes commands accept node names instead of BlockBackend names. In some places we intentionally allow only BlockBackends because we don't know if the command works in other p

[Qemu-devel] [PATCH] disas: avoid including everything in headers compiled from C++

2016-07-07 Thread Paolo Bonzini
disas/arm-a64.cc is careful to include only the bare minimum that it needs---qemu/osdep.h and disas/bfd.h. Unfortunately, disas/bfd.h then includes qemu-common.h, which brings in qemu/option.h and from there we get the kitchen sink. This causes problems because for example QEMU's atomic macros co

Re: [Qemu-devel] [PATCH v3] translate-all: Bugfix for user-mode self-modifying code in 2 page long TB

2016-07-07 Thread Sergey Fedorov
On 07/07/16 11:33, Stanislav Shmarov wrote: > In user-mode emulation Translation Block can consist of 2 guest pages. > In that case QEMU also mprotects 2 host pages that are dedicated for > guest memory, containing instructions. QEMU detects self-modifying code > with SEGFAULT signal processing. >

Re: [Qemu-devel] [PATCH v3 3/5] numa: reduce code duplication by adding helper numa_get_node_for_cpu()

2016-07-07 Thread Andrew Jones
On Mon, Jul 04, 2016 at 09:06:16AM +0200, Igor Mammedov wrote: > On Fri, 1 Jul 2016 14:30:12 +0200 > Andrew Jones wrote: > > On Fri, Jul 01, 2016 at 01:50:24PM +0200, Igor Mammedov wrote: > > > --- a/hw/arm/virt-acpi-build.c > > > +++ b/hw/arm/virt-acpi-build.c > > > @@ -426,11 +426,9 @@ build_sra

Re: [Qemu-devel] [PATCH] block/iscsi: precache the allocation status of a target

2016-07-07 Thread Peter Lieven
Am 30.06.2016 um 17:59 schrieb Paolo Bonzini: On 30/06/2016 13:08, Peter Lieven wrote: this fills up the allocationmap at iscsi_open. This helps to reduce the number of get_block_status requests during runtime significantly. Signed-off-by: Peter Lieven --- block/iscsi.c | 16 +++

[Qemu-devel] [PATCH V3 6/6] coroutine: reduce stack size to 64kB

2016-07-07 Thread Peter Lieven
evaluation with the recently introduced maximum stack usage monitoring revealed that the actual used stack size was never above 4kB so allocating 1MB stack for each coroutine is a lot of wasted memory. So reduce the stack size to 64kB which should still give enough head room. The guard page added i

[Qemu-devel] [PATCH V3 1/6] oslib-posix: add helpers for stack alloc and free

2016-07-07 Thread Peter Lieven
the allocated stack will be adjusted to the minimum supported stack size by the OS. Additionally an architecture dependent guard page is added to the stack to catch stack overflows. Suggested-by: Peter Maydell Signed-off-by: Peter Lieven --- include/sysemu/os-posix.h | 23 ++

Re: [Qemu-devel] Qemu and PCI Interrupt Link?

2016-07-07 Thread Peter Lieven
Am 05.07.2016 um 22:53 schrieb Paolo Bonzini: On 05/07/2016 20:30, Laszlo Ersek wrote: On 07/04/16 15:14, Peter Lieven wrote: Hi, i noticed that newer guest kernels emit the following message at startup: ACPI: No IRQ available for PCI Interrupt Link [LNKS]. Try pci=noacpi or acpi=off Cmdlin

Re: [Qemu-devel] [PATCH 1/3] linux-user: fd_trans_*_data() returns the length

2016-07-07 Thread Laurent Vivier
Le 30/06/2016 à 09:52, Riku Voipio a écrit : > > Hi, > > I've merged the netlink patches the que[1]. I'm waiting to see if > we'll get some fixup patches to the fairly substantial changes > linux-user has seen in this cycle. > > Riku > > [1] > https://git.linaro.org/people/riku.voipio/qemu.g

[Qemu-devel] [PATCH V3 2/6] coroutine: add a macro for the coroutine stack size

2016-07-07 Thread Peter Lieven
Reviewed-by: Richard Henderson Signed-off-by: Peter Lieven --- include/qemu/coroutine_int.h | 2 ++ util/coroutine-sigaltstack.c | 2 +- util/coroutine-ucontext.c| 2 +- util/coroutine-win32.c | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/include/qemu/coroutine

[Qemu-devel] [PATCH V3 4/6] coroutine-sigaltstack: use helper for allocating stack memory

2016-07-07 Thread Peter Lieven
Reviewed-by: Richard Henderson Signed-off-by: Peter Lieven --- util/coroutine-sigaltstack.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/util/coroutine-sigaltstack.c b/util/coroutine-sigaltstack.c index 9c2854c..ccf4861 100644 --- a/util/coroutine-sigaltstack.c +++

[Qemu-devel] [PATCH V3 3/6] coroutine-ucontext: use helper for allocating stack memory

2016-07-07 Thread Peter Lieven
Reviewed-by: Richard Henderson Signed-off-by: Peter Lieven --- util/coroutine-ucontext.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c index 31254ab..b7dea8c 100644 --- a/util/coroutine-ucontext.c +++ b/util/cor

[Qemu-devel] [PATCH V3 5/6] oslib-posix: add a configure switch to debug stack usage

2016-07-07 Thread Peter Lieven
this adds a knob to track the maximum stack usage of stacks created by qemu_alloc_stack. Signed-off-by: Peter Lieven --- configure | 19 +++ util/oslib-posix.c | 37 + 2 files changed, 56 insertions(+) diff --git a/configure b/configu

[Qemu-devel] [PATCH V3 0/6] coroutine: mmap stack memory and stack size

2016-07-07 Thread Peter Lieven
I decided to split this from the rest of the Qemu RSS usage series as it contains the more or less non contentious patches. I omitted the MAP_GROWSDOWN flag in mmap as we are not 100% sure which side effects it has. I kept the guard page which is now nicely makes the stacks visible in smaps. The

Re: [Qemu-devel] [PATCH v8 11/16] qapi-event: Reduce chance of collision with event data

2016-07-07 Thread Markus Armbruster
Eric Blake writes: > When an unboxed event has accompanying data, we are exposing all > of its members alongside our local variables in the generated > qapi_event_send_FOO() function. So far, we haven't hit a > collision, but it may be a matter of time before someone wants > to name a QMP data e

[Qemu-devel] [PATCH v2] qapi: change QmpInputVisitor to QSLIST

2016-07-07 Thread Paolo Bonzini
This saves a lot of memory compared to a statically-sized array, or at least 24kb could be considered a lot on an Atari ST. It also makes the code more similar to QmpOutputVisitor. Signed-off-by: Paolo Bonzini --- v1->v2: leave assert in check_struct [Eric, Markus] qapi/qmp-input-visit

Re: [Qemu-devel] [PATCH v4 00/29] vhost-user reconnect fixes

2016-07-07 Thread Marc-André Lureau
Hi On Thu, Jul 7, 2016 at 3:00 AM, wrote: > From: Marc-André Lureau > > Hi, > > Since 'vhost-user: simple reconnection support' was merged, it is > possible to disconnect and reconnect a vhost-user backend. However, > many code paths in qemu may trigger assert() when the backend is > disconnect

Re: [Qemu-devel] [PATCH] qapi: change QmpInputVisitor to QSLIST

2016-07-07 Thread Paolo Bonzini
On 06/07/2016 17:39, Eric Blake wrote: > On 07/06/2016 06:43 AM, Paolo Bonzini wrote: >> This saves a lot of memory compared to a statically-sized array. >> >> Signed-off-by: Paolo Bonzini >> --- >> qapi/qmp-input-visitor.c | 53 >> >> 1 file ch

Re: [Qemu-devel] [PATCH] qapi: change QmpInputVisitor to QSLIST

2016-07-07 Thread Paolo Bonzini
On 07/07/2016 10:19, Markus Armbruster wrote: > Actually, you should either prove that untrusted input still cannot make > us allocated unbounded amounts of memory, or bring the limit right back. This is not where untrusted input can be blocked from allocating unbounded memory---that would be Qm

Re: [Qemu-devel] [PATCH v2] hw/ptimer: Don't wrap around counter for expired timer that uses tick handler

2016-07-07 Thread Peter Maydell
On 4 July 2016 at 10:55, Peter Maydell wrote: > On 1 July 2016 at 18:49, Dmitry Osipenko wrote: >> On 01.07.2016 19:36, Peter Maydell wrote: >>> On 30 June 2016 at 20:01, Dmitry Osipenko wrote: On 30.06.2016 18:02, Peter Maydell wrote: > What I meant was: ptimer_get_count() is typically

Re: [Qemu-devel] [PATCH v8 08/16] qapi: Implement boxed types for commands/events

2016-07-07 Thread Markus Armbruster
Eric Blake writes: > Turn on the ability to pass command and event arguments in > a single boxed parameter, which must name a non-empty type > (although the type can be a struct with all optional members). > For structs, it makes it possible to pass a single qapi type > instead of a breakout of a

Re: [Qemu-devel] [PULL] Net patches

2016-07-07 Thread Peter Maydell
On 7 July 2016 at 07:53, Jason Wang wrote: > The following changes since commit 91d35509903464c7f4b9ed56be223d7370d3597c: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20160706' into > staging (2016-07-06 17:32:09 +0100) > > are available in the git repository at: > > https://gi

Re: [Qemu-devel] [PATCH] timer.h: fix typo

2016-07-07 Thread Peter Maydell
On 7 July 2016 at 11:15, Cao jin wrote: > Signed-off-by: Cao jin > --- > include/qemu/timer.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/qemu/timer.h b/include/qemu/timer.h > index 309f3d0..41e8325 100644 > --- a/include/qemu/timer.h > +++ b/include/qe

[Qemu-devel] [PATCH] timer.h: fix typo

2016-07-07 Thread Cao jin
Signed-off-by: Cao jin --- include/qemu/timer.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/qemu/timer.h b/include/qemu/timer.h index 309f3d0..41e8325 100644 --- a/include/qemu/timer.h +++ b/include/qemu/timer.h @@ -179,7 +179,7 @@ int64_t qemu_clock_deadline

Re: [Qemu-devel] [RfC PATCH] gtk: prefer version 3.x

2016-07-07 Thread Peter Maydell
On 7 July 2016 at 10:29, Daniel P. Berrange wrote: > On Thu, Jul 07, 2016 at 09:34:47AM +0200, Gerd Hoffmann wrote: >> This patch flips the default from gtk2 to gtk3. >> >> Sounds like a bigger change than it actually is as configure already >> uses gtk3 in case it doesn't find gtk2. So this chan

Re: [Qemu-devel] [RfC PATCH] gtk: prefer version 3.x

2016-07-07 Thread Daniel P. Berrange
On Thu, Jul 07, 2016 at 09:34:47AM +0200, Gerd Hoffmann wrote: > This patch flips the default from gtk2 to gtk3. > > Sounds like a bigger change than it actually is as configure already > uses gtk3 in case it doesn't find gtk2. So this changes behavior > only in case both gtk2 and gtk3 devel pack

Re: [Qemu-devel] [PULL v2 0/4] tcg-ish updates

2016-07-07 Thread Peter Maydell
On 6 July 2016 at 17:18, Richard Henderson wrote: > Three tcg patches, and a build change so that we can still > use --cpu=i686 on a x86_64 host, now that linux-user has > the syscall assembly thunks. > > Change from v1 to v2 is a one-line revert to patch 3, the > spilling of constants, which affe

Re: [Qemu-devel] [PATCH v1 1/2] crypto: use glib as fallback for hash algorithm

2016-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2016 at 08:53:56AM -0600, Eric Blake wrote: > On 07/06/2016 05:58 AM, Alberto Garcia wrote: > > On Tue 05 Jul 2016 12:49:59 PM CEST, "Daniel P. Berrange" > > wrote: > > > >> GLib >= 2.16 provides GChecksum API which is good enough > >> for md5, sha1, sha256 and sha512. Use this a

Re: [Qemu-devel] [PATCH v1 3/2] crypto: don't open-code qcrypto_hash_supports

2016-07-07 Thread Alberto Garcia
On Tue 05 Jul 2016 06:43:13 PM CEST, "Daniel P. Berrange" wrote: > Call the existing qcrypto_hash_supports method from > qcrypto_hash_bytesv instead of open-coding it again. > > Signed-off-by: Daniel P. Berrange "PATCH 3/2" ? :-) Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v2] vmdk: fix metadata write regression

2016-07-07 Thread Fam Zheng
On Thu, 07/07 10:42, Reda Sallahi wrote: > Commit "cdeaf1f vmdk: add bdrv_co_write_zeroes" causes a regression on > writes. It writes metadata after every write instead of doing it only once > for each cluster. > > vmdk_pwritev() writes metadata whenever m_data is set as valid so this patch > sets

Re: [Qemu-devel] [PATCH v3 5/7] ppc: each machine type to provide vcpu_dt_id

2016-07-07 Thread Greg Kurz
On Thu, 7 Jul 2016 12:01:51 +1000 David Gibson wrote: > On Wed, Jul 06, 2016 at 02:14:36PM +0200, Greg Kurz wrote: > > This patch switches machine types to provide device-tree cpu ids. > > > > We have three cases to handle: > > > > - pseries < 2.7 call ppc_cpu_init() and should compute the DT i

Re: [Qemu-devel] [PATCH v1 1/2] crypto: use glib as fallback for hash algorithm

2016-07-07 Thread Alberto Garcia
On Tue 05 Jul 2016 12:49:59 PM CEST, "Daniel P. Berrange" wrote: > +cs = g_checksum_new(qcrypto_hash_alg_map[alg]); > + > +for (i = 0; i < niov; i++) { > +g_checksum_update(cs, iov[i].iov_base, iov[i].iov_len); > +} Not too important, but you could do this after checking the

Re: [Qemu-devel] [PATCH v1 2/2] Revert "block: don't register quorum driver if SHA256 support is unavailable"

2016-07-07 Thread Alberto Garcia
On Tue 05 Jul 2016 12:50:00 PM CEST, "Daniel P. Berrange" wrote: > The qcrypto hash APIs now guarantee that sha256 is available at > compile time, so skipping registration is rarely needed. A check > at time of open is kept to ensure good error reporting in the > (unlikely) case sha256 is runtime

Re: [Qemu-devel] [PATCH] qapi: change QmpInputVisitor to QSLIST

2016-07-07 Thread Markus Armbruster
Eric Blake writes: > On 07/06/2016 06:43 AM, Paolo Bonzini wrote: >> This saves a lot of memory compared to a statically-sized array. >> >> Signed-off-by: Paolo Bonzini >> --- >> qapi/qmp-input-visitor.c | 53 >> >> 1 file changed, 26 insertion

Re: [Qemu-devel] [PATCH] qapi: change QmpOutputVisitor to QSLIST

2016-07-07 Thread Markus Armbruster
Paolo Bonzini writes: > This saves a little memory compared to the doubly-linked QTAILQ. > > Signed-off-by: Paolo Bonzini The memory savings are trivial: we go from 160 + 24*d to 160 + 16*d, where d is the depth of the tree we visit, almost always in the single digits. But I like the simplicit

Re: [Qemu-devel] [PATCH] qapi: change QmpInputVisitor to QSLIST

2016-07-07 Thread Markus Armbruster
Needs a rebase. The other one, too. Paolo Bonzini writes: > This saves a lot of memory compared to a statically-sized array. > > Signed-off-by: Paolo Bonzini Saves 24KiB - d*32B. That's "a lot" for an Atari ST or something, or if you're juggling hundreds of these things at the same time. Al

Re: [Qemu-devel] [PATCH v3 7/7] spapr: consolidate the logic of core cpu_dt_id

2016-07-07 Thread Greg Kurz
On Thu, 7 Jul 2016 12:05:02 +1000 David Gibson wrote: > On Wed, Jul 06, 2016 at 02:14:59PM +0200, Greg Kurz wrote: > > POWER5 and newer cpus from IBM have a specific numbering scheme for > > DT ids. This is currently open coded in several places. > > > > This patch consolidates the logic in help

[Qemu-devel] [PATCH v2] vmdk: fix metadata write regression

2016-07-07 Thread Reda Sallahi
Commit "cdeaf1f vmdk: add bdrv_co_write_zeroes" causes a regression on writes. It writes metadata after every write instead of doing it only once for each cluster. vmdk_pwritev() writes metadata whenever m_data is set as valid so this patch sets m_data as valid only when we have a new cluster whic

Re: [Qemu-devel] [RFC PATCH V5 0/4] Introduce COLO-compare

2016-07-07 Thread Jason Wang
On 2016年07月07日 15:47, Zhang Chen wrote: Hi~~ Jason~ Have any comments? By the way this patch set depend on the patch Will go through this tomorrow. [RFC PATCH V2] qemu-char: Fix context for g_source_attach() but no one review itany suggestion? I think you may want to ping the mainta

[Qemu-devel] [PATCH v3] translate-all: Bugfix for user-mode self-modifying code in 2 page long TB

2016-07-07 Thread Stanislav Shmarov
In user-mode emulation Translation Block can consist of 2 guest pages. In that case QEMU also mprotects 2 host pages that are dedicated for guest memory, containing instructions. QEMU detects self-modifying code with SEGFAULT signal processing. In case if instruction in 1st page is modifying memor

[Qemu-devel] [PATCH] gtk: fix build

2016-07-07 Thread Gerd Hoffmann
Commit "9d8256e virgl: pass whole GL scanout dimensions" missed the opengl code path for gtk versions >= 3.16. Update that one too and fix the build with recent gtk versions. Reported-by: Dr. David Alan Gilbert Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 1 + ui/gtk-gl-area.c | 1 + 2

Re: [Qemu-devel] [RFC PATCH V5 0/4] Introduce COLO-compare

2016-07-07 Thread Zhang Chen
Hi~~ Jason~ Have any comments? By the way this patch set depend on the patch [RFC PATCH V2] qemu-char: Fix context for g_source_attach() but no one review itany suggestion? Thanks Zhang Chen On 06/23/2016 07:34 PM, Zhang Chen wrote: COLO-compare is a part of COLO project. It is used to

[Qemu-devel] [PATCH] vmdk: fix metadata write regression

2016-07-07 Thread Reda Sallahi
Commit "cde6361 vmdk: add bdrv_co_write_zeroes" causes a regression on writes. It writes metadata after every write instead of doing it only once for each cluster. vmdk_pwritev() writes metadata whenever m_data is set as valid so this patch sets m_data as valid only when we have a new cluster whic

[Qemu-devel] [RfC PATCH] gtk: prefer version 3.x

2016-07-07 Thread Gerd Hoffmann
This patch flips the default from gtk2 to gtk3. Sounds like a bigger change than it actually is as configure already uses gtk3 in case it doesn't find gtk2. So this changes behavior only in case both gtk2 and gtk3 devel packages are installed. Signed-off-by: Gerd Hoffmann --- configure | 8 +++

Re: [Qemu-devel] [PATCH v3 2/7] ppc: move smp_threads sanity checks to spapr

2016-07-07 Thread Greg Kurz
On Thu, 07 Jul 2016 11:57:32 +1000 Benjamin Herrenschmidt wrote: > On Thu, 2016-07-07 at 11:12 +1000, David Gibson wrote: > > I'm not comfortable with this.  SMT may only be used for pseries at > > the moment, but the SMT possibilities are absolutely a constraint of > > the CPU itself, not the ma

<    1   2   3