[Qemu-devel] [Bug 995758] Re: Possibly inaccurate statement in PC Platform Docs

2016-10-24 Thread Thomas Huth
As far as I can see, the wording on the page only says that the BIOS ends at address 0xF, not that it starts execution at exactly that address. So I think that page is ok. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu

Re: [Qemu-devel] vt-x support for qemu

2016-10-24 Thread Anand J
Hi, I have the following setup. I'm running qemu in software mode, installed KVM inside qemu. And on top of that I need to run qemu again but with kvm enabled. But I'm getting the following error when I try to do that. Can somebody please help me with this? KVM internal error. Suberror: 1 emulati

[Qemu-devel] [PATCH v2 4/6] blockjob: add block_job_start

2016-10-24 Thread John Snow
Instead of automatically starting jobs at creation time via backup_start et al, we'd like to return a job object pointer that can be started manually at later point in time. For now, add the block_job_start mechanism and start the jobs automatically as we have been doing, with conversions job-by-j

[Qemu-devel] [PATCH v2 5/6] blockjob: refactor backup_start as backup_job_create

2016-10-24 Thread John Snow
Refactor backup_start as backup_job_create, which only creates the job, but does not automatically start it. The old interface, 'backup_start', is not kept in favor of limiting the number of nearly-identical interfaces that would have to be edited to keep up with QAPI changes in the future. Caller

[Qemu-devel] [PATCH v2 0/6] jobs: fix transactional race condition

2016-10-24 Thread John Snow
Requires: [Qemu-devel] [PATCH 0/7] blockjobs: preliminary refactoring work, Pt 1 There are a few problems with transactional job completion right now. First, if jobs complete so quickly they complete before remaining jobs get a chance to join the transaction, the completion mode can leave well kn

[Qemu-devel] [PATCH v2 6/6] iotests: add transactional failure race test

2016-10-24 Thread John Snow
Add a regression test for the case found by Vladimir. Reported-by: Vladimir Sementsov-Ogievskiy Signed-off-by: John Snow --- tests/qemu-iotests/124 | 53 ++ tests/qemu-iotests/124.out | 4 ++-- 2 files changed, 37 insertions(+), 20 deletions(-)

[Qemu-devel] [PATCH v2 1/6] blockjob: fix dead pointer in txn list

2016-10-24 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Though it is not intended to be reached through normal circumstances, if we do not gracefully deconstruct the transaction QLIST, we may wind up with stale pointers in the list. The rest of this series attempts to address the underlying issues, but this should f

[Qemu-devel] [PATCH v2 2/6] blockjob: add .clean property

2016-10-24 Thread John Snow
Cleaning up after we have deferred to the main thread but before the transaction has converged can be dangerous and result in deadlocks if the job cleanup invokes any BH polling loops. A job may attempt to begin cleaning up, but may induce another job to enter its cleanup routine. The second job,

[Qemu-devel] [PATCH v2 3/6] blockjob: add .start field

2016-10-24 Thread John Snow
Add an explicit start field to specify the entrypoint. We already have ownership of the coroutine itself AND managing the lifetime of the coroutine, let's take control of creation of the coroutine, too. This will allow us to delay creation of the actual coroutine until we know we'll actually start

[Qemu-devel] [Bug 1017793] Re: S3 Trio64V+ support

2016-10-24 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1017793 Title: S3 Trio64V+ support Status in QEMU: New Bug description: Is it possible t

[Qemu-devel] [Bug 1013691] Re: ppc64 + virtio-scsi: only first scsi disk shows up in the guest

2016-10-24 Thread Thomas Huth
** Tags added: ppc -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1013691 Title: ppc64 + virtio-scsi: only first scsi disk shows up in the guest Status in QEMU: New Bug description: When addin

[Qemu-devel] [Bug 1543057] Re: Warnings are treated as errors

2016-10-24 Thread Thomas Huth
Closing this as invalid - unless you can reproduce this with the latest release version or the current master branch again, then please feel free to open this ticket again. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- d

[Qemu-devel] [PATCH 7/7] acpi/ipmi: Initialize the fwinfo before fetching it

2016-10-24 Thread minyard
From: Corey Minyard The initialization was missed before, resulting in some bad data in the smbus case. Signed-off-by: Corey Minyard --- hw/acpi/ipmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/acpi/ipmi.c b/hw/acpi/ipmi.c index 7e74ce4..651e2e9 100644 --- a/hw/acpi/ipmi.c +++ b/h

[Qemu-devel] [PATCH 3/7] ipmi: chassis poweroff should use qemu_system_shutdown_request()

2016-10-24 Thread minyard
From: Cédric Le Goater When issuing a chassis 'powerdown' control command, the routine qemu_system_shutdown_request() should be used to exit the guest. qemu_system_powerdown_request() will initiate a soft shutdown which is not what is required by the IPMI (28.3 Chassis Control Command): 0h =

[Qemu-devel] [PATCH 2/7] ipmi_bmc_sim: Remove an unnecessary mutex

2016-10-24 Thread minyard
From: Corey Minyard Get rid of the unnecessary mutex, it was a vestige of something else that was not done. That way we don't have to free it. Signed-off-by: Corey Minyard Reviewed-by: Marc-André Lureau --- hw/ipmi/ipmi_bmc_sim.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/ip

[Qemu-devel] [PATCH 0/7] ipmi: Various little IPMI fixes

2016-10-24 Thread minyard
I've posted these before in various forms, but they haven't been picked up. These are little fixed noticed by others and myself, nothing huge, but things that needed attention. -corey

Re: [Qemu-devel] target-ppc: gdbstub breakpoints get stuck in an infinite loop on next/continue

2016-10-24 Thread Benjamin Herrenschmidt
On Mon, 2016-10-24 at 12:00 +1100, David Gibson wrote: > Ben, does it look like the other extraneous changes in bd6fefe are at > least correct, apart from being in the wrong patch? It looks like part of my big rewrite of the exception stuff, so I'd assume it's mostly correct minus a few bugs I fix

Re: [Qemu-devel] Assertion failure on qcow2 disk with cluster_size != 64k

2016-10-24 Thread Eric Blake
On 10/21/2016 08:14 AM, Ed Swierk wrote: > On Thu, Oct 20, 2016 at 6:38 PM, Eric Blake wrote: >> On 10/20/2016 07:24 PM, Ed Swierk wrote: >>> Changing max_transfer in the normal write case to >>> MIN_NON_ZERO(alignment, MAX_WRITE_ZEROES_BOUNCE_BUFFER) appears to fix >>> the problem, but I don't pr

[Qemu-devel] [PULL v2 02/16] pc: acpi: x2APIC support for SRAT table

2016-10-24 Thread Eduardo Habkost
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c| 34 -- include/hw/acpi/acpi-defs.h | 11 +++ 2 files changed, 35 insertions(+), 10 deletions(-) diff --git a/

[Qemu-devel] [PULL v2 01/16] pc: acpi: x2APIC support for MADT table and _MAT method

2016-10-24 Thread Eduardo Habkost
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- hw/acpi/cpu.c | 5 +++ hw/i386/acpi-build.c| 78 +++-- include/hw/acpi/acpi-defs.h | 18 +++ 3 files changed,

[Qemu-devel] [PULL v2 00/16] x86 and CPU queue, 2016-10-24

2016-10-24 Thread Eduardo Habkost
Change in v2: * Removed patch: "target-i386: Print warning when mixing [+-]foo and foo=(on|off)" The following changes since commit a3ae21ec3fe036f536dc94cad735931777143103: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2016-10-24 15:03:09 +0100) are availab

[Qemu-devel] [PATCH 6/7] ipmi: Add graceful shutdown handling to the external BMC

2016-10-24 Thread minyard
From: Corey Minyard I misunderstood the workings of the power settings, the power off is a force off operation and there needs to be a separate graceful shutdown operation. So replace the force off operation with a graceful shutdown. Signed-off-by: Corey Minyard --- hw/ipmi/ipmi_bmc_extern.c

[Qemu-devel] [PATCH 5/7] ipmi: fix build config variable name for ipmi_bmc_extern.o

2016-10-24 Thread minyard
From: "Daniel P. Berrange" The original commit: commit 67aa56fc03bea44ccf384ea400515a8a58844a50 Author: Corey Minyard Date: Thu Dec 17 12:50:06 2015 -0600 ipmi: Add an external connection simulation interface defined a new variable CONFIG_IPMI_EXTERN, but then went on to mistakely

Re: [Qemu-devel] [PATCH 0/2] less confusing block file names

2016-10-24 Thread Eric Blake
On 10/24/2016 10:14 AM, Kevin Wolf wrote: > Am 24.10.2016 um 16:44 hat Paolo Bonzini geschrieben: >> On 24/10/2016 15:47, Kevin Wolf wrote: >>> One effect that makes me less than fully happy is that 'git log >>> block/raw.c' without --follow mixes the history of the renamed driver >>> with the hist

[Qemu-devel] [PULL v2 13/16] pc: q35: Bump max_cpus to 288

2016-10-24 Thread Eduardo Habkost
From: Igor Mammedov Along with it for machine versions 2.7 and older keep it at 255. Signed-off-by: Igor Mammedov Reviewed-by: Radim Krčmář Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- hw/i386/pc_q35.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/pc_q35.c

[Qemu-devel] [PATCH 4/7] ipmi: Implement shutdown via ACPI overtemp

2016-10-24 Thread minyard
From: Corey Minyard This is allowed by the IPMI specification for graceful shutdown, so implement it. Signed-off-by: Corey Minyard --- hw/ipmi/ipmi.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/ipmi/ipmi.c b/hw/ipmi/ipmi.c index f91c7b7..5cf1caa 100644 --- a/h

[Qemu-devel] [PULL v2 11/16] pc: Add 'etc/boot-cpus' fw_cfg file for machine with more than 255 CPUs

2016-10-24 Thread Eduardo Habkost
From: Igor Mammedov Currently firmware uses 1 byte at 0x5F offset in RTC CMOS to get number of CPUs present at boot. However 1 byte is not enough to handle more than 255 CPUs. So add a new fw_cfg file that would allow QEMU to tell it. For compat reasons add file only for machine types that suppo

[Qemu-devel] [PATCH 1/7] ipmi: Remove hotplug from IPMI BMCs

2016-10-24 Thread minyard
From: Corey Minyard No hotplug support, make sure it doesn't happen. Signed-off-by: Corey Minyard Reviewed-by: Marc-André Lureau --- hw/ipmi/ipmi_bmc_extern.c | 1 + hw/ipmi/ipmi_bmc_sim.c| 1 + 2 files changed, 2 insertions(+) diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_ex

[Qemu-devel] [PULL v2 15/16] exec: move cpu_exec_init() calls to realize functions

2016-10-24 Thread Eduardo Habkost
From: Laurent Vivier Modify all CPUs to call it from XXX_cpu_realizefn() function. Remove all the cannot_destroy_with_object_finalize_yet as unsafe references have been moved to cpu_exec_realizefn(). (tested with QOM command provided by commit 4c315c27) for arm: Setting of cpu->mp_affinity is

[Qemu-devel] [PULL v2 10/16] Increase MAX_CPUMASK_BITS from 255 to 288

2016-10-24 Thread Eduardo Habkost
From: Igor Mammedov so that it would be possible to increase maxcpus limit for x86 target. Keep spapr/virt_arm at limit they used to have 255. Signed-off-by: Igor Mammedov Reviewed-by: Andrew Jones Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- hw/arm/virt.c | 2 +

Re: [Qemu-devel] [PATCH 1/2] block/nfs: Introduce runtime_opts in NFS

2016-10-24 Thread Ashijeet Acharya
On Tue, Oct 25, 2016 at 12:12 AM, Ashijeet Acharya wrote: > On Mon, Oct 24, 2016 at 8:40 PM, Kevin Wolf wrote: >> Am 19.10.2016 um 14:38 hat Ashijeet Acharya geschrieben: >>> Make NFS block driver use various fine grained runtime_opts. >>> Set .bdrv_parse_filename() to nfs_parse_filename() and in

[Qemu-devel] [PATCH v2] target-i386: Print warning when mixing [+-]foo and foo=(on|off)

2016-10-24 Thread Eduardo Habkost
Print a warning when mixing [+-]foo and foo=(on|off) in the -cpu argument in a way that will break in the future. Signed-off-by: Eduardo Habkost --- Changes v2: * Put the whole parsing-plus-minus test cases inside #ifdef CONFIG_HAS_GLIB_SUBPROCESS_TESTS because they would trigger warnings dur

[Qemu-devel] [PULL v2 16/16] exec: call cpu_exec_exit() from a CPU unrealize common function

2016-10-24 Thread Eduardo Habkost
From: Laurent Vivier As cpu_exec_exit() mirrors the cpu_exec_realizefn(), rename it as cpu_exec_unrealizefn(). Create and register a cpu_common_unrealizefn() function for the CPU device class and call cpu_exec_unrealizefn() from this function. Remove cpu_exec_exit() from cpu_common_finalize() (

[Qemu-devel] [PULL v2 09/16] pc: Clarify FW_CFG_MAX_CPUS usage comment

2016-10-24 Thread Eduardo Habkost
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index b1f8638..83ad556 100644 --- a/hw/i386/pc.c ++

[Qemu-devel] [PULL v2 12/16] pc: Require IRQ remapping and EIM if there could be x2APIC CPUs

2016-10-24 Thread Eduardo Habkost
From: Igor Mammedov It would prevent starting guest with incorrect configs where interrupts couldn't be delivered to CPUs with APIC IDs > 255. Signed-off-by: Igor Mammedov Reviewed-by: Radim Krčmář Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 14 +++

[Qemu-devel] [PULL v2 14/16] exec: split cpu_exec_init()

2016-10-24 Thread Eduardo Habkost
From: Laurent Vivier Put in cpu_exec_initfn() what initializes the CPU, and leave in cpu_exec_init() what adds it to the environment. As cpu_exec_initfn() is called by all XX_cpu_initfn(), call it directly in cpu_common_initfn(). cpu_exec_init() is now a realize function, it will be renamed to c

[Qemu-devel] [PULL v2 07/16] pc: apic_common: Reset APIC ID to initial ID when switching into x2APIC mode

2016-10-24 Thread Eduardo Habkost
From: Igor Mammedov SDM: x2APIC State Transitions: State Changes From xAPIC Mode to x2APIC Mode " Any APIC ID value written to the memory-mapped local APIC ID register is not preserved " Signed-off-by: Igor Mammedov Reviewed-by: Radim Krčmář Reviewed-by: Eduardo Habkost Signed-off-by

[Qemu-devel] [PULL v2 08/16] pc: kvm_apic: Pass APIC ID depending on xAPIC/x2APIC mode

2016-10-24 Thread Eduardo Habkost
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Radim Krčmář Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- hw/i386/kvm/apic.c | 12 ++-- target-i386/kvm.c | 13 ++--- target-i386/kvm_i386.h | 1 + 3 files changed, 21 insertions(+), 5

Re: [Qemu-devel] [PATCH v5 0/4] fdc: Use separate qdev device for drives

2016-10-24 Thread John Snow
On 10/24/2016 07:37 AM, Kevin Wolf wrote: We have been complaining for a long time about how the floppy controller and floppy drives are combined in a single qdev device and how this makes the device awkward to work with because it behaves different from all other block devices. The latest rea

[Qemu-devel] [PULL v2 05/16] pc: apic_common: Extend APIC ID property to 32bit

2016-10-24 Thread Eduardo Habkost
From: Igor Mammedov ACPI ID is 32 bit wide on CPUs with x2APIC support. Extend 'id' property to support it. Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- hw/intc/apic_common.c | 46 - include/hw/

[Qemu-devel] [PULL v2 04/16] pc: Leave max apic_id_limit only in legacy cpu hotplug code

2016-10-24 Thread Eduardo Habkost
From: Igor Mammedov That's enough to make old code that depends on it to prevent QEMU starting with more than 255 CPUs. Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- hw/acpi/cpu_hotplug.c | 7 ++- hw/i386/pc.c | 6 -- 2 files ch

Re: [Qemu-devel] [PULL 00/23] Block layer patches

2016-10-24 Thread Peter Maydell
On 24 October 2016 at 18:01, Kevin Wolf wrote: > The following changes since commit a3ae21ec3fe036f536dc94cad735931777143103: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2016-10-24 15:03:09 +0100) > > are available in the git repository at: > > > git:/

[Qemu-devel] [PULL v2 06/16] pc: apic_common: Restore APIC ID to initial ID on reset

2016-10-24 Thread Eduardo Habkost
From: Igor Mammedov APIC ID should be restored to initial APIC ID state after Reset and Power-On. Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- hw/intc/apic_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/intc/apic_common.c b/hw/

[Qemu-devel] [PULL v2 03/16] acpi: cphp: Force switch to modern cpu hotplug if APIC ID > 254

2016-10-24 Thread Eduardo Habkost
From: Igor Mammedov Switch to modern cpu hotplug at machine startup time if a cpu present at boot has apic-id in range unsupported by legacy cpu hotplug interface (i.e. > 254), to avoid killing QEMU from legacy cpu hotplug code with error: "acpi: invalid cpu id: #apic-id#" Signed-off-by: Igor

Re: [Qemu-devel] [PATCH 08/38] mux: split mux_chr_update_read_handler()

2016-10-24 Thread Eric Blake
On 10/22/2016 04:52 AM, Marc-André Lureau wrote: > Make qemu_chr_add_handlers_full() aware of mux handling. This allows > introduction of a tag associated with the fe handlers and a > qemu_chr_set_handlers() function to set the handler for a particular > tag. That will allow to get rid of qemu_chr_

Re: [Qemu-devel] [PATCH v8 00/37] cmpxchg atomic operations

2016-10-24 Thread Emilio G. Cota
On Mon, Oct 24, 2016 at 10:39:11 -0700, Richard Henderson wrote: > Changes v7-v8: > * Atomics fix for gcc 4.2 (centos6) > * All atomic.h changes split out from 'tcg: Add atomic helpers', > as requested by ... someone (Emilio?) Yep that was me, thanks for doing it. > * Unused function re

[Qemu-devel] [PATCH] hw/i2c/bitbang_i2c: Handle NACKs from devices

2016-10-24 Thread Peter Maydell
If the guest attempts to talk to a nonexistent device over i2c, the i2c_start_transfer() function will return non-zero, indicating that the bus is signalling a NACK. Similarly, if the i2c_send() function returns nonzero then the target device returned a NACK. Handle this possibility in the bitbang_

[Qemu-devel] [PATCH v2 1/2] block/nfs: Introduce runtime_opts in NFS

2016-10-24 Thread Ashijeet Acharya
Make NFS block driver use various fine grained runtime_opts. Set .bdrv_parse_filename() to nfs_parse_filename() and introduce two new functions nfs_parse_filename() and nfs_parse_uri() to help parsing the URI. Signed-off-by: Ashijeet Acharya --- block/nfs.c | 348

Re: [Qemu-devel] [PATCH] tests: Remove unneeded "-vnc none" option

2016-10-24 Thread John Snow
On 10/24/2016 12:25 PM, Eduardo Habkost wrote: Some tests use the "-vnc none" option without any clear reason, making those tests break when --disable-vnc is specified on ./configure. Remove the unnecessary option. Signed-off-by: Eduardo Habkost --- tests/ide-test.c | 1 - tests/ipmi-b

[Qemu-devel] [PATCH v2 0/2] block: allow blockdev-add for NFS

2016-10-24 Thread Ashijeet Acharya
Previously posted series patches: v1: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg04487.html This series adds blockdev-add support for NFS block driver. Patch 1 helps to prepare NFS driver to make use of several runtime_opts as they appear in the URI. This will make NFS to do things

[Qemu-devel] [PATCH v8 32/37] target-arm: emulate aarch64's LL/SC using cmpxchg helpers

2016-10-24 Thread Richard Henderson
From: "Emilio G. Cota" Emulating LL/SC with cmpxchg is not correct, since it can suffer from the ABA problem. Portable parallel code, however, is written assuming only cmpxchg--and not LL/SC--is available. This means that in practice emulating LL/SC with cmpxchg is a viable alternative. The appe

[Qemu-devel] [PATCH v8 35/37] target-arm: remove EXCP_STREX + cpu_exclusive_{test, info}

2016-10-24 Thread Richard Henderson
From: "Emilio G. Cota" The exception is not emitted anymore; remove it and the associated TCG variables. Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Richard Henderson Message-Id: <1467054136-10430-31-git-send-email-c...@braap.org> --- target-arm/cpu.h | 17 +++

Re: [Qemu-devel] [PATCHv3 07/12] pseries: Consolidate construction of /chosen device tree node

2016-10-24 Thread Michael Roth
Quoting David Gibson (2016-10-24 00:04:38) > For historical reasons, building the /chosen node in the guest device tree > is split across several places and includes both parts which write the DT > sequentially and others which use random access functions. > > This patch consolidates construction

[Qemu-devel] [PATCH v2 2/2] qapi: allow blockdev-add for NFS

2016-10-24 Thread Ashijeet Acharya
Introduce new object 'BlockdevOptionsNFS' in qapi/block-core.json to support blockdev-add for NFS network protocol driver. Also make a new struct NFSServer to support tcp connection. Signed-off-by: Ashijeet Acharya --- qapi/block-core.json | 56 ---

[Qemu-devel] [PATCH v8 27/37] target-i386: remove helper_lock()

2016-10-24 Thread Richard Henderson
From: "Emilio G. Cota" It's been superseded by the atomic helpers. The use of the atomic helpers provides a significant performance and scalability improvement. Below is the result of running the atomic_add-test microbenchmark with: $ x86_64-linux-user/qemu-x86_64 tests/atomic_add-bench -o 500

Re: [Qemu-devel] [PULL 00/17] x86 and CPU queue, 2016-10-24

2016-10-24 Thread Eduardo Habkost
On Mon, Oct 24, 2016 at 06:26:44PM +0100, Peter Maydell wrote: > On 24 October 2016 at 17:34, Eduardo Habkost wrote: > > On Mon, Oct 24, 2016 at 05:20:17PM +0100, Peter Maydell wrote: > >> Tests should never print out strings with "warning:" in them, > >> to avoid false-positives when scanning bui

[Qemu-devel] [PATCH v8 31/37] target-arm: emulate SWP with atomic_xchg helper

2016-10-24 Thread Richard Henderson
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Message-Id: <1467054136-10430-25-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- target-arm/translate.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/target-arm/translate

Re: [Qemu-devel] [PATCH v2 00/18] tcg field extract primitives

2016-10-24 Thread Richard Henderson
Pinging target maintainers. If I don't get responses by the end of the week, I'll only push the generic tcg bits and the two targets that I maintain. r~ On 10/18/2016 08:10 AM, Richard Henderson wrote: Better tested this time, including aarch64 host. Changes since v1: * Added tcg_gen_dep

[Qemu-devel] [PATCH v8 25/37] target-i386: emulate LOCK'ed BTX ops using atomic helpers

2016-10-24 Thread Richard Henderson
From: "Emilio G. Cota" [rth: Avoid redundant qemu_ld in locked case. Fix previously unnoticed incorrect zero-extension of address in register-offset case.] Signed-off-by: Emilio G. Cota Message-Id: <1467054136-10430-18-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- targe

[Qemu-devel] [PATCH v8 22/37] target-i386: emulate LOCK'ed NOT using atomic helper

2016-10-24 Thread Richard Henderson
From: "Emilio G. Cota" [rth: Avoid qemu_load that's redundant with the atomic op.] Signed-off-by: Emilio G. Cota Message-Id: <1467054136-10430-15-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- target-i386/translate.c | 26 -- 1 file changed, 20 ins

[Qemu-devel] [PATCH v8 21/37] target-i386: emulate LOCK'ed INC using atomic helper

2016-10-24 Thread Richard Henderson
From: "Emilio G. Cota" [rth: Merge gen_inc_locked back into gen_inc to share cc update.] Signed-off-by: Emilio G. Cota Message-Id: <1467054136-10430-14-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- target-i386/translate.c | 24 +--- 1 file changed, 13

Re: [Qemu-devel] [PATCH] tests: Remove unneeded "-vnc none" option

2016-10-24 Thread Corey Minyard
On 10/24/2016 11:25 AM, Eduardo Habkost wrote: Some tests use the "-vnc none" option without any clear reason, making those tests break when --disable-vnc is specified on ./configure. Remove the unnecessary option. Signed-off-by: Eduardo Habkost --- tests/ide-test.c | 1 - tests/ipmi-b

Re: [Qemu-devel] [PULL 00/32] target-arm queue

2016-10-24 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1477329928-26414-1-git-send-email-peter.mayd...@linaro.org Subject: [Qemu-devel] [PULL 00/32] target-arm queue === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(gi

Re: [Qemu-devel] [PATCHv3 02/12] pseries: Remove rtas_addr and fdt_addr fields from machinestate

2016-10-24 Thread Michael Roth
Quoting David Gibson (2016-10-24 00:04:33) > These values are used only within ppc_spapr_reset(), so just change them > to local variables. > > Signed-off-by: David Gibson > Reviewed-by: Thomas Huth > Reviewed-by: Alexey Kardashevskiy Reviewed-by: Michael Roth > --- > hw/ppc/spapr.c

Re: [Qemu-devel] [PATCH 1/2] block/nfs: Introduce runtime_opts in NFS

2016-10-24 Thread Ashijeet Acharya
On Mon, Oct 24, 2016 at 8:40 PM, Kevin Wolf wrote: > Am 19.10.2016 um 14:38 hat Ashijeet Acharya geschrieben: >> Make NFS block driver use various fine grained runtime_opts. >> Set .bdrv_parse_filename() to nfs_parse_filename() and introduce two >> new functions nfs_parse_filename() and nfs_parse_

[Qemu-devel] [PATCH v8 06/37] int128: Use __int128 if available

2016-10-24 Thread Richard Henderson
Reviewed-by: Emilio G. Cota Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/qemu/int128.h | 135 +- tests/test-int128.c | 22 2 files changed, 145 insertions(+), 12 deletions(-) diff --git a/include/qemu/int128.h

[Qemu-devel] [PATCH v8 13/37] cputlb: Move most of iotlb code out of line

2016-10-24 Thread Richard Henderson
Saves 2k code size off of a cold path. Reviewed-by: Emilio G. Cota Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- cputlb.c | 37 + softmmu_template.h | 52 ++-- 2 files changed, 47 inse

Re: [Qemu-devel] [PATCH v17 00/14] PTimer fixes/features and ARM MPTimer conversion

2016-10-24 Thread Dmitry Osipenko
On 24.10.2016 15:23, Peter Maydell wrote: > On 2 October 2016 at 16:53, Dmitry Osipenko wrote: >> Hello, >> >> Currently, QEMU ARM MPTimer device model provides only a certain subset of >> the emulation behavior. This patch series is supposed to add missing parts by >> converting the MPTimer to us

Re: [Qemu-devel] [PATCHv3 01/12] pseries: Split device tree construction from device tree load

2016-10-24 Thread Michael Roth
Quoting David Gibson (2016-10-24 00:04:32) > spapr_finalize_fdt() both finishes building the device tree for the guest > and loads it into guest memory. For future cleanups, it's going to be > more convenient to do these two things separately. The loading portion is > pretty trivial, so we move i

[Qemu-devel] [PATCH v8 10/37] cputlb: Replace SHIFT with DATA_SIZE

2016-10-24 Thread Richard Henderson
Reviewed-by: Emilio G. Cota Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- cputlb.c | 16 softmmu_template.h | 7 ++- 2 files changed, 10 insertions(+), 13 deletions(-) diff --git a/cputlb.c b/cputlb.c index 3c99c34..5575b73 100644 --- a/cputlb.c

Re: [Qemu-devel] [PATCH v8 04/37] atomics: Add __nocheck atomic operations

2016-10-24 Thread Emilio G. Cota
On Mon, Oct 24, 2016 at 10:39:15 -0700, Richard Henderson wrote: > While the check against sizeof(void *) is appropriate for > normal usage within qemu, there are places in which we want > wider operaions and have checked for their existance. s/operaions/operations/ > Signed-off-by: Richard Hende

[Qemu-devel] [PATCH v8 07/37] int128: Add int128_make128

2016-10-24 Thread Richard Henderson
Allows Int128 to be used more generally, rather than having to begin with 64-bit inputs and accumulate. Reviewed-by: Emilio G. Cota Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/qemu/int128.h | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) d

[Qemu-devel] [PATCH v8 05/37] exec: Avoid direct references to Int128 parts

2016-10-24 Thread Richard Henderson
Reviewed-by: Emilio G. Cota Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- exec.c| 4 ++-- include/qemu/int128.h | 10 ++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index 6d7f600..2bddbd3 100644 --- a/exec.c +++ b/exec

Re: [Qemu-devel] [PULL 00/35] cmpxchg atomic operations

2016-10-24 Thread Peter Maydell
On 24 October 2016 at 18:27, Richard Henderson wrote: > Bah. Annoyingly, even though I didn't configure with --disable-werror, I only > got the warning from clang, which of course flashed by unseen. I think that configure looks for "does this compiler support the GCC diagnostic pragma" (which cl

Re: [Qemu-devel] [PATCH v8 01/37] atomics: Add parameters to macros

2016-10-24 Thread Emilio G. Cota
On Mon, Oct 24, 2016 at 10:39:12 -0700, Richard Henderson wrote: > Making these functional rather than object macros will > prevent later problems with complex macro expansion. > > Signed-off-by: Richard Henderson Reviewed-by: Emilio G. Cota E.

Re: [Qemu-devel] [PULL 00/35] cmpxchg atomic operations

2016-10-24 Thread Richard Henderson
On 10/24/2016 03:51 AM, Peter Maydell wrote: > /Users/pm215/src/qemu-for-merges/target-arm/translate.c:1019:1: error: > unused function 'gen_aa32_ld16ua > ' [-Werror,-Wunused-function] > DO_GEN_LD(16ua, MO_UW | MO_ALIGN) > ^ > /Users/pm215/src/qemu-for-merges/target-arm/translate.c:954:20: note: >

[Qemu-devel] [PATCH v8 33/37] linux-user: remove handling of ARM's EXCP_STREX

2016-10-24 Thread Richard Henderson
From: "Emilio G. Cota" The exception is not emitted anymore. Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Richard Henderson Message-Id: <1467054136-10430-29-git-send-email-c...@braap.org> --- linux-user/main.c | 93

[Qemu-devel] [PATCH v8 37/37] target-alpha: Emulate LL/SC using cmpxchg helpers

2016-10-24 Thread Richard Henderson
Emulating LL/SC with cmpxchg is not correct, since it can suffer from the ABA problem. However, portable parallel code is written assuming only cmpxchg which means that in practice this is a viable alternative. Signed-off-by: Richard Henderson --- linux-user/main.c| 49

Re: [Qemu-devel] [PULL 00/17] x86 and CPU queue, 2016-10-24

2016-10-24 Thread Peter Maydell
On 24 October 2016 at 17:34, Eduardo Habkost wrote: > On Mon, Oct 24, 2016 at 05:20:17PM +0100, Peter Maydell wrote: >> Tests should never print out strings with "warning:" in them, >> to avoid false-positives when scanning build logs. >> >> I'm not entirely sure why these only happen on OSX, thou

[Qemu-devel] [PATCH v8 26/37] target-i386: emulate XCHG using atomic helper

2016-10-24 Thread Richard Henderson
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Message-Id: <1467054136-10430-19-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- target-i386/translate.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/target-i386/translate.c b/target-i386/tr

[Qemu-devel] [PATCH v8 29/37] target-arm: Rearrange aa32 load and store functions

2016-10-24 Thread Richard Henderson
Stop specializing on TARGET_LONG_BITS == 32; unconditionally allocate a temp and expand with tcg_gen_extu_i32_tl. Split out gen_aa32_addr, gen_aa32_frob64, gen_aa32_ld_i32 and gen_aa32_st_i32 as separate interfaces. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target-arm/trans

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-24 Thread Max Reitz
On 24.10.2016 12:11, Kevin Wolf wrote: [...] > Now, the big question is how to translate this into file locking. This > could become a little tricky. I had a few thoughts involving another > lock on byte 2, but none of them actually worked out so far, because > what we want is essentially a lock

[Qemu-devel] [PULL 00/32] target-arm queue

2016-10-24 Thread Peter Maydell
nzini/tags/for-upstream' into staging (2016-10-24 15:03:09 +0100) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20161024 for you to fetch changes up to cc083d8a25e0a886c3cd4bea0bf57ac4e896fa3f: i2c: Add asserts f

[Qemu-devel] [PATCH v8 19/37] target-i386: emulate LOCK'ed cmpxchg using cmpxchg helpers

2016-10-24 Thread Richard Henderson
From: "Emilio G. Cota" The diff here is uglier than necessary. All this does is to turn FOO into: if (s->prefix & PREFIX_LOCK) { BAR } else { FOO } where FOO is the original implementation of an unlocked cmpxchg. [rth: Adjust unlocked cmpxchg to use movcond instead of branches. Adjust he

[Qemu-devel] [PATCH v8 24/37] target-i386: emulate LOCK'ed XADD using atomic helper

2016-10-24 Thread Richard Henderson
From: "Emilio G. Cota" [rth: Move load of reg value to common location.] Signed-off-by: Emilio G. Cota Message-Id: <1467054136-10430-17-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- target-i386/translate.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletio

[Qemu-devel] [PATCH v8 12/37] cputlb: Remove includes from softmmu_template.h

2016-10-24 Thread Richard Henderson
We already include exec/address-spaces.h and exec/memory.h in cputlb.c; the include of qemu/timer.h appears to be a fossil. Reviewed-by: Emilio G. Cota Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- softmmu_template.h | 4 1 file changed, 4 deletions(-) diff --git a/softmm

[Qemu-devel] [PULL 06/32] target-arm: Make page size a runtime setting

2016-10-24 Thread Peter Maydell
Rather than defining TARGET_PAGE_BITS to always be 10, switch to using a value picked at runtime. This allows us to use 4K pages for modern ARM CPUs (and in particular all 64-bit CPUs) without having to drop support for the old ARMv5 CPUs which had 1K pages. Signed-off-by: Peter Maydell Reviewed-

[Qemu-devel] [PATCH v8 11/37] cputlb: Move probe_write out of softmmu_template.h

2016-10-24 Thread Richard Henderson
Reviewed-by: Emilio G. Cota Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- cputlb.c | 21 + softmmu_template.h | 23 --- 2 files changed, 21 insertions(+), 23 deletions(-) diff --git a/cputlb.c b/cputlb.c index 5575b73..0c9b77b 1

[Qemu-devel] [PATCH v8 36/37] target-alpha: Introduce MMU_PHYS_IDX

2016-10-24 Thread Richard Henderson
Rather than using helpers for physical accesses, use a mmu index. The primary cleanup is with store-conditional on physical addresses. Signed-off-by: Richard Henderson --- target-alpha/cpu.h| 18 +--- target-alpha/helper.c | 8 ++ target-alpha/helper.h | 9 -- t

[Qemu-devel] [PULL 11/32] tests: ptimer: Add tests for "continuous trigger" policy

2016-10-24 Thread Peter Maydell
From: Dmitry Osipenko PTIMER_POLICY_CONTINUOUS_TRIGGER makes periodic ptimer to re-trigger every period in case of load = delta = 0. Signed-off-by: Dmitry Osipenko Message-id: 7a908ab38b902d521eb959941f9efe2df8ce4297.1475421224.git.dig...@gmail.com Reviewed-by: Peter Maydell Signed-off-by: Pe

[Qemu-devel] [PATCH v8 20/37] target-i386: emulate LOCK'ed OP instructions using atomic helpers

2016-10-24 Thread Richard Henderson
From: "Emilio G. Cota" [rth: Eliminate some unnecessary temporaries.] Signed-off-by: Emilio G. Cota Message-Id: <1467054136-10430-13-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- target-i386/translate.c | 76 + 1 file chang

[Qemu-devel] [PATCH v8 09/37] linux-user: enable parallel code generation on clone

2016-10-24 Thread Richard Henderson
From: Alex Bennée The variable parallel_cpus controls the generation of thread aware atomic code. We only need to set it once we clone our first thread. At this point any existing translations need to be thrown away. Reviewed-by: Emilio G. Cota Signed-off-by: Alex Bennée Signed-off-by: Richar

[Qemu-devel] [PATCH v8 34/37] linux-user: remove handling of aarch64's EXCP_STREX

2016-10-24 Thread Richard Henderson
From: "Emilio G. Cota" The exception is not emitted anymore. Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Richard Henderson Message-Id: <1467054136-10430-30-git-send-email-c...@braap.org> --- linux-user/main.c | 125 ---

[Qemu-devel] [PULL 32/32] i2c: Add asserts for second smbus i2c_start_transfer()

2016-10-24 Thread Peter Maydell
From: Corey Minyard Some SMBus operations restart the transfer to convert from write to read mode without an intervening i2c_end_transfer(). The second call cannot fail, so the return code is unchecked, but this causes Coverity to complain. So add some asserts and documentation about this. Sign

[Qemu-devel] [PATCH v8 16/37] tcg: Add atomic128 helpers

2016-10-24 Thread Richard Henderson
Force the use of cmpxchg16b on x86_64. Wikipedia suggests that only very old AMD64 (circa 2004) did not have this instruction. Further, it's required by Windows 8 so no new cpus will ever omit it. If we truely care about these, then we could check this at startup time and then avoid executing pa

[Qemu-devel] [PATCH v8 01/37] atomics: Add parameters to macros

2016-10-24 Thread Richard Henderson
Making these functional rather than object macros will prevent later problems with complex macro expansion. Signed-off-by: Richard Henderson --- include/qemu/atomic.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h inde

[Qemu-devel] [PATCH v8 30/37] target-arm: emulate LL/SC using cmpxchg helpers

2016-10-24 Thread Richard Henderson
From: "Emilio G. Cota" Emulating LL/SC with cmpxchg is not correct, since it can suffer from the ABA problem. Portable parallel code, however, is written assuming only cmpxchg--and not LL/SC--is available. This means that in practice emulating LL/SC with cmpxchg is a viable alternative. The appe

[Qemu-devel] [PULL 15/32] tests: ptimer: Add tests for "no immediate reload" policy

2016-10-24 Thread Peter Maydell
From: Dmitry Osipenko PTIMER_POLICY_NO_IMMEDIATE_RELOAD makes ptimer to not to re-load counter on setting counter value to "0" or starting to run with "0". Signed-off-by: Dmitry Osipenko Message-id: a7acf805e447cc7f637ecacbd45cca34ea3bf425.1475421224.git.dig...@gmail.com Reviewed-by: Peter May

[Qemu-devel] [PATCH v8 18/37] tcg: Emit barriers with parallel_cpus

2016-10-24 Thread Richard Henderson
Reviewed-by: Emilio G. Cota Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index cdd61d6..bb2bfee 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -150,17 +150

[Qemu-devel] [PATCH v8 28/37] tests: add atomic_add-bench

2016-10-24 Thread Richard Henderson
From: "Emilio G. Cota" With this microbenchmark we can measure the overhead of emulating atomic instructions with a configurable degree of contention. The benchmark spawns $n threads, each performing $o atomic ops (additions) in a loop. Each atomic operation is performed on a different cache lin

<    1   2   3   4   5   >